Re: [PATCH] dma-buf/sync_file: Use fdget()

2023-05-11 Thread Al Viro
On Fri, May 05, 2023 at 11:03:39AM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > convert the fget() use to fdget(). NAK.

Re: [PATCH] dma-buf: Use fdget()

2023-05-11 Thread Al Viro
On Fri, May 05, 2023 at 10:18:47AM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > convert the fget() use to fdget(). NAK.

Re: [PATCH v7 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-11 Thread Marijn Suijten
On 2023-05-11 07:26:28, Dmitry Baryshkov wrote: > On 11/05/2023 01:35, Jessica Zhang wrote: > > > > > > On 5/9/2023 11:29 PM, Marijn Suijten wrote: > >> On 2023-05-09 15:06:48, Jessica Zhang wrote: > >>> From: Dmitry Baryshkov > >>> > >>> Add a helper setting config values which are typically

Re: [PATCH v7 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-11 Thread Dmitry Baryshkov
On 11/05/2023 09:18, Marijn Suijten wrote: On 2023-05-11 07:26:28, Dmitry Baryshkov wrote: On 11/05/2023 01:35, Jessica Zhang wrote: On 5/9/2023 11:29 PM, Marijn Suijten wrote: On 2023-05-09 15:06:48, Jessica Zhang wrote: From: Dmitry Baryshkov Add a helper setting config values which

Re: [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-11 Thread Marijn Suijten
On 2023-05-10 14:03:14, Jessica Zhang wrote: > > > On 5/9/2023 11:33 PM, Marijn Suijten wrote: > > On 2023-05-09 15:06:50, Jessica Zhang wrote: > >> Introduce MSM-specific DSC helper methods, as some calculations are > >> common between DP and DSC. > >> > >> Reviewed-by: Dmitry Baryshkov > >>

Re: [PATCH] drm: sun4i_tcon: use devm_clk_get_enabled in `sun4i_tcon_init_clocks`

2023-05-11 Thread XuDong Liu
On 2023/4/30 19:23, XuDong Liu wrote: Smatch reports: drivers/gpu/drm/sun4i/sun4i_tcon.c:805 sun4i_tcon_init_clocks() warn: 'tcon->clk' from clk_prepare_enable() not released on lines: 792,801. In the function sun4i_tcon_init_clocks(), tcon->clk and tcon->sclk0 are not disabled in the error

[PULL] drm-misc-next

2023-05-11 Thread Maxime Ripard
Hi, Here's the first drm-misc-next PR for 6.5 Please note that I'll be off for about a month starting next week, and Thomas has kindly agreed to fill in. Thanks! Maxime drm-misc-next-2023-05-11: drm-misc-next for 6.5: UAPI Changes: Cross-subsystem Changes: - arch: Consolidate Core

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by:

Re: [PULL] drm-misc-fixes

2023-05-11 Thread Thomas Zimmermann
A friendly ping to merge this PR. The patches appear to be missing from drm-fixes. Am 26.04.23 um 07:59 schrieb Maarten Lankhorst: Hi Dave, Daniel, drm-misc-fixes pull request for rc1. drm-misc-next-fixes coming up.. next ~Maarten drm-misc-fixes-2023-04-26: drm-misc-fixes for v6.4-rc1: -

Re: [PATCH v3] firmware/sysfb: Fix VESA format selection

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 19:25 schrieb Pierre Asselin: Thomas Zimmerman writes: I found this casting mess even more unreadable. I went back to v2, fixed the style issues and committed the patch as v4 (still under your name).

Re: [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-11 Thread Dmitry Baryshkov
On 11/05/2023 00:03, Jessica Zhang wrote: On 5/9/2023 11:33 PM, Marijn Suijten wrote: On 2023-05-09 15:06:50, Jessica Zhang wrote: Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang ---  

Re: (subset) [PATCH] drm: sun4i_tcon: use devm_clk_get_enabled in `sun4i_tcon_init_clocks`

2023-05-11 Thread Maxime Ripard
On Sun, 30 Apr 2023 19:23:46 +0800, XuDong Liu wrote: > Smatch reports: > drivers/gpu/drm/sun4i/sun4i_tcon.c:805 sun4i_tcon_init_clocks() warn: > 'tcon->clk' from clk_prepare_enable() not released on lines: 792,801. > > In the function sun4i_tcon_init_clocks(), tcon->clk and tcon->sclk0 are > not

Re: [PATCH] dma-buf/sync_file: Use fdget()

2023-05-11 Thread Al Viro
On Fri, May 05, 2023 at 10:22:09AM +0200, Christian König wrote: > Am 05.05.23 um 05:03 schrieb ye.xingc...@zte.com.cn: > > From: Ye Xingchen > > > > convert the fget() use to fdget(). > > Well the rational is missing. Why should we do that? We very definitely should not. The series appears

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Sui Jingfeng
Hi On 2023/5/11 15:55, Thomas Zimmermann wrote: Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Arnd Bergmann
On Thu, May 11, 2023, at 14:35, Geert Uytterhoeven wrote: > CC Artur, who's working on HP Jornada 680. > > On Wed, May 10, 2023 at 5:55 PM Arnd Bergmann wrote: >> On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote: >> > Am 10.05.23 um 16:15 schrieb Arnd Bergmann: >> >> On Wed, May 10, 2023,

Re: [Intel-gfx] [RFC PATCH 0/4] Add support for DRM cgroup memory accounting.

2023-05-11 Thread Tvrtko Ursulin
On 10/05/2023 19:46, Tejun Heo wrote: Hello, On Wed, May 10, 2023 at 04:59:01PM +0200, Maarten Lankhorst wrote: The misc controller is not granular enough. A single computer may have any number of graphics cards, some of them with multiple regions of vram inside a single card. Extending

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 09:55, Thomas Zimmermann wrote: Hi Am 10.05.23 um 20:20 schrieb Sui Jingfeng: Hi, Thomas I love your patch, yet something to improve: On 2023/5/10 19:05, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd

Re: [PATCH 00/15] fbdev: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 14:53, Thomas Zimmermann wrote: Hi Am 11.05.23 um 14:51 schrieb Helge Deller: Hi Thomas, On 5/11/23 14:08, Thomas Zimmermann wrote: I thought these patches would go through the fbdev tree, but I could not find them v6.4-rc1. Please review the remaining ones, so that I can merge

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Karol Herbst
On Wed, May 10, 2023 at 9:59 AM Jonas Ådahl wrote: > > On Tue, May 09, 2023 at 08:22:30PM +, Simon Ser wrote: > > On Tuesday, May 9th, 2023 at 21:53, Dave Airlie wrote: > > > > > There are also other vendor side effects to having this in userspace. > > > > > > Will the library have a loader?

[PATCH 1/2] drm/fourcc: define Intel Meteorlake related ccs modifiers

2023-05-11 Thread Juha-Pekka Heikkila
Add Tile4 type ccs modifiers with aux buffer needed for MTL Cc: dri-devel@lists.freedesktop.org Cc: Jani Nikula Signed-off-by: Juha-Pekka Heikkila --- include/uapi/drm/drm_fourcc.h | 43 +++ 1 file changed, 43 insertions(+) diff --git

Re: [PATCH v9 1/8] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-11 Thread Ville Syrjälä
On Wed, May 10, 2023 at 03:54:41PM -0700, Jessica Zhang wrote: > Add helpers to calculate det_thresh_flatness and initial_scale_value as > these calculations are defined within the DSC spec. > > Signed-off-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Marijn Suijten >

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Geert Uytterhoeven
Hi Arnd, CC Artur, who's working on HP Jornada 680. On Wed, May 10, 2023 at 5:55 PM Arnd Bergmann wrote: > On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote: > > Am 10.05.23 um 16:15 schrieb Arnd Bergmann: > >> On Wed, May 10, 2023, at 16:03, kernel test robot wrote: > > >> I think that's

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 17:54 schrieb Arnd Bergmann: On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote: Am 10.05.23 um 16:15 schrieb Arnd Bergmann: On Wed, May 10, 2023, at 16:03, kernel test robot wrote: I think that's a preexisting bug and I have no idea what the correct solution is.

Re: [PATCH 00/15] fbdev: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
Hi Thomas, On 5/11/23 14:08, Thomas Zimmermann wrote: I thought these patches would go through the fbdev tree, but I could not find them v6.4-rc1. Please review the remaining ones, so that I can merge them via drm-misc. Sorry, I thought you had planned to take them through drm-misc anyway, so

Re: [PATCH v3 29/65] clk: socfpga: gate: Add a determine_rate hook

2023-05-11 Thread Maxime Ripard
Hi Dinh, On Tue, May 09, 2023 at 12:37:39PM -0500, Dinh Nguyen wrote: > Hi Maxime, > > On 5/4/23 12:04, Maxime Ripard wrote: > > Hi Dinh, > > > > On Thu, Apr 27, 2023 at 02:09:48PM -0500, Dinh Nguyen wrote: > > > Hi Maxime, > > > > > > On 4/25/23 09:48, Maxime Ripard wrote: > > > > Hi Dinh, >

[PULL] drm-intel-fixes

2023-05-11 Thread Joonas Lahtinen
Hi Dave & Daniel, Here goes drm-intel-fixes for v6.4-rc2. Important fix to taint kernel when force_probe is used, two display fixes (null deref/div-by-zero) and a GuC error capture register list correction. Regards, Joonas PS. Again had to remove one commit with incorrect Fixes: tag so check

Re: [PATCH 00/15] fbdev: Remove trailing whitespaces

2023-05-11 Thread Thomas Zimmermann
Hi Am 11.05.23 um 14:51 schrieb Helge Deller: Hi Thomas, On 5/11/23 14:08, Thomas Zimmermann wrote: I thought these patches would go through the fbdev tree, but I could not find them v6.4-rc1. Please review the remaining ones, so that I can merge them via drm-misc. Sorry, I thought you had

Re: [RFC PATCH 0/4] Add support for DRM cgroup memory accounting.

2023-05-11 Thread Maarten Lankhorst
Hey, On 2023-05-10 20:46, Tejun Heo wrote: > Hello, > > On Wed, May 10, 2023 at 04:59:01PM +0200, Maarten Lankhorst wrote: >> The misc controller is not granular enough. A single computer may have any >> number of >> graphics cards, some of them with multiple regions of vram inside a single >>

Re: [PATCH 00/15] fbdev: Remove trailing whitespaces

2023-05-11 Thread Thomas Zimmermann
(ping) Hi, I thought these patches would go through the fbdev tree, but I could not find them v6.4-rc1. Please review the remaining ones, so that I can merge them via drm-misc. Best regards Thomas Am 31.03.23 um 11:22 schrieb Thomas Zimmermann: The trailing whitespaces are annoying. So

Re: [PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-11 Thread Neil Armstrong
Hi, On Mon, 08 May 2023 16:38:24 +0800, Liu Ying wrote: > This patch series aims to add BOE EV121WXM-N10-1850 panel support > in the DRM simple panel driver. > > Patch 1/2 adds dt-bindings support for the panel. > Patch 2/2 adds the panel support in the DRM simple panel driver. > > v1->v2: > *

Re: [PATCH 1/2] drm/panel: sharp-ls043t1le01: adjust mode settings

2023-05-11 Thread Neil Armstrong
Hi, On Sun, 07 May 2023 20:26:38 +0300, Dmitry Baryshkov wrote: > Using current settings causes panel flickering on APQ8074 dragonboard. > Adjust panel settings to follow the vendor-provided mode. This also > enables MIPI_DSI_MODE_VIDEO_SYNC_PULSE, which is also specified by the > vendor dtsi for

[PULL] drm-misc-fixes

2023-05-11 Thread Maarten Lankhorst
Hi Dave, Daniel, Next pull request, with the previous one included too: drm-misc-fixes-2023-05-11: drm-misc-fixes for v6.4-rc2: - More DSC macro fixes. - Small mipi-dsi fix. - Scheduler timeout handling fix. --- drm-misc-fixes for v6.4-rc1: - Fix DSC macros. - Fix VESA format for simplefb. -

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915: use pat_index instead of cache_level

2023-05-11 Thread Tvrtko Ursulin
On 09/05/2023 18:12, Yang, Fei wrote: > On 09/05/2023 00:48, fei.y...@intel.com wrote: >> From: Fei Yang >> >> Currently the KMD is using enum i915_cache_level to set caching policy for >> buffer objects. This is flaky because the PAT index which really controls >> the caching

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Geert Uytterhoeven
Hi Helge, On Thu, May 11, 2023 at 3:05 PM Helge Deller wrote: > On 5/11/23 09:55, Thomas Zimmermann wrote: > > But the work I do within fbdev is mostly for improving DRM. > > Sure. > > > For the > > other issues in this file, I don't think that matroxfb should even be > > around any longer.

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 17:54 schrieb Arnd Bergmann: On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote: Am 10.05.23 um 16:15 schrieb Arnd Bergmann: On Wed, May 10, 2023, at 16:03, kernel test robot wrote: I think that's a preexisting bug and I have no idea what the correct solution is.

Re: [PATCH v2] drm/mgag200: Fix gamma lut not initialized.

2023-05-11 Thread Thomas Zimmermann
Hi Am 10.05.23 um 15:10 schrieb Jocelyn Falempe: When mgag200 switched from simple KMS to regular atomic helpers, the initialization of the gamma settings was lost. This leads to a black screen, if the bios/uefi doesn't use the same pixel color depth. v2: rebase on top of drm-misc-fixes, and

[PATCH 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-11 Thread Bagas Sanjaya
Replace GPL boilerplate notice on remaining files with appropriate SPDX tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. Cc: David A. Hinds Cc: Donald Becker Cc: Peter De Schrijver Cc: Greg Ungerer Cc: Simon Horman Signed-off-by: Bagas Sanjaya ---

[PATCH 00/10] Treewide GPL SPDX conversion (love letter to Didi)

2023-05-11 Thread Bagas Sanjaya
I trigger this patch series because of Didi's GPL full name fixes attempt [1], for which all of them had been NAKed. In many cases, the appropriate correction is to use SPDX license identifier instead. Often, when replacing license notice boilerplates with their equivalent SPDX identifier, the

[PATCH 03/10] net: bonding: Add SPDX identifier to remaining files

2023-05-11 Thread Bagas Sanjaya
Previous batches of SPDX conversion missed bond_main.c and bonding_priv.h because these files doesn't mention intended GPL version. Add SPDX identifier to these files, assuming GPL 1.0+. Cc: Thomas Davis Cc: Christophe JAILLET Cc: Stephen Hemminger Signed-off-by: Bagas Sanjaya ---

[PATCH 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier

2023-05-11 Thread Bagas Sanjaya
Replace unversioned GPL notice boilerplate on dsp_* with SPDX identifier for GPL 1.0+. These files missed previous SPDX conversion batches due to not specifying GPL version. Cc: Stephen Hemminger Signed-off-by: Bagas Sanjaya --- drivers/isdn/mISDN/dsp_audio.c| 4 +---

[pull] amdgpu drm-fixes-6.4

2023-05-11 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.4-2023-05-11 for you to

Re: [PATCH 10/10] include: synclink: Replace GPL license notice with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:06PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL license notice with appropriate SPDX > identifier, which is GPL 1.0+. > > Signed-off-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH 09/10] udf: Replace license notice with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:05PM +0700, Bagas Sanjaya wrote: > Except Kconfig and Makefile, all source files for UDF filesystem doesn't > bear SPDX license identifier. Add appropriate license identifier while > replacing boilerplates. > > Cc: Thomas Gleixner > Signed-off-by: Bagas Sanjaya

[PATCH v3 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-11 Thread Rob Clark
From: Rob Clark When the special handling of qcom,adreno-smmu was moved into qcom_smmu_create(), it was overlooked that we didn't have all the required entries in qcom_smmu_impl_of_match. So we stopped getting adreno_smmu_priv on sc7180, breaking per-process pgtables. Fixes: 30b912a03d91

[PATCH v3 2/2] drm/msm: Be more shouty if per-process pgtables aren't working

2023-05-11 Thread Rob Clark
From: Rob Clark Otherwise it is not always obvious if a dt or iommu change is causing us to fall back to global pgtable. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_iommu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Wed, May 10, 2023 at 05:39:07PM -0700, Abhinav Kumar wrote: > > > On 5/10/2023 4:55 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > > The internal_hpd flag was introduced to handle external DP HPD derived > > > from GPIO > > > pinmuxed into DP controller. > > > >

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 15:10, Geert Uytterhoeven wrote: Hi Helge, On Thu, May 11, 2023 at 3:05 PM Helge Deller wrote: On 5/11/23 09:55, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should

Re: [PATCH v6 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-11 Thread Kuogee Hsieh
On 5/10/2023 9:52 PM, Dmitry Baryshkov wrote: On 11/05/2023 01:07, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not     used at

[PATCH AUTOSEL 6.3 01/11] drm/amdgpu: release gpu full access after "amdgpu_device_ip_late_init"

2023-05-11 Thread Sasha Levin
From: Chong Li [ Upstream commit 38eecbe086a4e52f54b2bbda8feba65d44addbef ] [WHY] Function "amdgpu_irq_update()" called by "amdgpu_device_ip_late_init()" is an atomic context. We shouldn't access registers through KIQ since "msleep()" may be called in "amdgpu_kiq_rreg()". [HOW] Move

[PATCH AUTOSEL 6.3 04/11] drm/amd/display: Do not set drr on pipe commit

2023-05-11 Thread Sasha Levin
From: Wesley Chalmers [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ] [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required.

[PATCH AUTOSEL 6.3 05/11] drm/amd/display: fix memleak in aconnector->timing_requested

2023-05-11 Thread Sasha Levin
From: Hersen Wu [ Upstream commit 025ce392b5f213696ca0af3e07735d0fae020694 ] [Why] when amdgpu_dm_update_connector_after_detect is called two times successively with valid sink, memory allocated of aconnector->timing_requested for the first call is not free. this causes memeleak. [How]

Re: [Intel-gfx] [PATCH 1/2] drm/fourcc: define Intel Meteorlake related ccs modifiers

2023-05-11 Thread Matt Atwood
On Thu, May 11, 2023 at 01:37:13PM +0300, Juha-Pekka Heikkila wrote: > Add Tile4 type ccs modifiers with aux buffer needed for MTL > Bspec: 49251, 49252, 49253 > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula Reviewed-by: Matt Atwood > Signed-off-by: Juha-Pekka Heikkila > --- >

[git pull] drm fixes for 6.4-rc2

2023-05-11 Thread Dave Airlie
Hi Linus, About the usual for this stage, bunch of amdgpu, a few i915 and a scattering of fixes across the board, Regards, Dave. drm-fixes-2023-05-12: drm fixes for 6.4-rc2 dsc: - macro fixes simplefb: - fix VESA format scheduler: - Scheduler timeout handling fix. fbdev: - Prohibit

Re: [PATCH v2 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-11 Thread Arthur Grillo Queiroz Cabral
On 07/05/23 17:28, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed-point value. > > Signed-off-by: Maíra Canal > --- > > v1 -> v2: > https://lore.kernel.org/dri-devel/20230425153353.238844-1-mca...@igalia.com/T/ > > * New patch >

[PATCH AUTOSEL 6.2 01/10] drm/amdgpu: release gpu full access after "amdgpu_device_ip_late_init"

2023-05-11 Thread Sasha Levin
From: Chong Li [ Upstream commit 38eecbe086a4e52f54b2bbda8feba65d44addbef ] [WHY] Function "amdgpu_irq_update()" called by "amdgpu_device_ip_late_init()" is an atomic context. We shouldn't access registers through KIQ since "msleep()" may be called in "amdgpu_kiq_rreg()". [HOW] Move

[PATCH AUTOSEL 6.2 04/10] drm/amd/display: Do not set drr on pipe commit

2023-05-11 Thread Sasha Levin
From: Wesley Chalmers [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ] [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required.

[PATCH AUTOSEL 6.2 10/10] drm/amdgpu: Use the default reset when loading or reloading the driver

2023-05-11 Thread Sasha Levin
From: lyndonli [ Upstream commit 4eea7fb980dc44545a32eec92e2662053b34cd9d ] Below call trace and errors are observed when reloading amdgpu driver with the module parameter reset_method=3. It should do a default reset when loading or reloading the driver, regardless of the module parameter

[PATCH AUTOSEL 6.3 11/11] drm/amdgpu: Use the default reset when loading or reloading the driver

2023-05-11 Thread Sasha Levin
From: lyndonli [ Upstream commit 4eea7fb980dc44545a32eec92e2662053b34cd9d ] Below call trace and errors are observed when reloading amdgpu driver with the module parameter reset_method=3. It should do a default reset when loading or reloading the driver, regardless of the module parameter

Re: [PATCH v2] drm/amdkfd: Fix potential deallocation of previously deallocated memory.

2023-05-11 Thread Felix Kuehling
On 2023-05-11 07:23, Daniil Dulov wrote: Pointer mqd_mem_obj can be deallocated in kfd_gtt_sa_allocate(). The function then returns non-zero value, which causes the second deallocation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d1f8f0d17d40 ("drm/amdkfd: Move

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Simon Ser
On Thursday, May 11th, 2023 at 18:56, Joshua Ashton wrote: > When we are talking about being 'prescriptive' in the API, are we > outright saying we don't want to support arbitrary 3D LUTs, or are we > just offering certain algorithms to be 'executed' for a plane/crtc/etc > in the atomic API? I

Re: [PATCH v2 2/2] drm/vkms: Fix RGB565 pixel conversion

2023-05-11 Thread Arthur Grillo Queiroz Cabral
On 07/05/23 17:28, Maíra Canal wrote: > Currently, the pixel conversion isn't rounding the fixed-point values > before assigning it to the RGB coefficients, which is causing the IGT > pixel-format tests to fail. So, use the drm_fixp2int_round() fixed-point > helper to round the values when

Re: [Intel-gfx] [RFC PATCH 0/4] Add support for DRM cgroup memory accounting.

2023-05-11 Thread Maarten Lankhorst
Hey, On 2023-05-11 12:14, Tvrtko Ursulin wrote: > > On 10/05/2023 19:46, Tejun Heo wrote: >> Hello, >> >> On Wed, May 10, 2023 at 04:59:01PM +0200, Maarten Lankhorst wrote: >>> The misc controller is not granular enough. A single computer may have any >>> number of >>> graphics cards, some of

Re: [git pull] drm fixes for 6.4-rc2

2023-05-11 Thread pr-tracker-bot
The pull request you sent on Fri, 12 May 2023 06:59:57 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-05-12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc3c44c9fda264c6d401be04e95449a57c1231c6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Jonas Ådahl
On Thu, May 11, 2023 at 04:56:47PM +, Joshua Ashton wrote: > When we are talking about being 'prescriptive' in the API, are we > outright saying we don't want to support arbitrary 3D LUTs, or are we > just offering certain algorithms to be 'executed' for a plane/crtc/etc > in the atomic API? I

Re: [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-11 Thread Abhinav Kumar
On 5/10/2023 11:28 PM, Dmitry Baryshkov wrote: On 11/05/2023 00:03, Jessica Zhang wrote: On 5/9/2023 11:33 PM, Marijn Suijten wrote: On 2023-05-09 15:06:50, Jessica Zhang wrote: Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Reviewed-by:

[PATCH AUTOSEL 6.1 1/9] drm/amdgpu: release gpu full access after "amdgpu_device_ip_late_init"

2023-05-11 Thread Sasha Levin
From: Chong Li [ Upstream commit 38eecbe086a4e52f54b2bbda8feba65d44addbef ] [WHY] Function "amdgpu_irq_update()" called by "amdgpu_device_ip_late_init()" is an atomic context. We shouldn't access registers through KIQ since "msleep()" may be called in "amdgpu_kiq_rreg()". [HOW] Move

[PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit

2023-05-11 Thread Sasha Levin
From: Wesley Chalmers [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ] [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required.

[PATCH AUTOSEL 6.1 9/9] drm/amdgpu: Use the default reset when loading or reloading the driver

2023-05-11 Thread Sasha Levin
From: lyndonli [ Upstream commit 4eea7fb980dc44545a32eec92e2662053b34cd9d ] Below call trace and errors are observed when reloading amdgpu driver with the module parameter reset_method=3. It should do a default reset when loading or reloading the driver, regardless of the module parameter

[PATCH AUTOSEL 5.15 1/5] drm/amdgpu: release gpu full access after "amdgpu_device_ip_late_init"

2023-05-11 Thread Sasha Levin
From: Chong Li [ Upstream commit 38eecbe086a4e52f54b2bbda8feba65d44addbef ] [WHY] Function "amdgpu_irq_update()" called by "amdgpu_device_ip_late_init()" is an atomic context. We shouldn't access registers through KIQ since "msleep()" may be called in "amdgpu_kiq_rreg()". [HOW] Move

[PATCH AUTOSEL 5.15 5/5] drm/amdgpu: Use the default reset when loading or reloading the driver

2023-05-11 Thread Sasha Levin
From: lyndonli [ Upstream commit 4eea7fb980dc44545a32eec92e2662053b34cd9d ] Below call trace and errors are observed when reloading amdgpu driver with the module parameter reset_method=3. It should do a default reset when loading or reloading the driver, regardless of the module parameter

Re: [PATCH v7 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-11 Thread Abhinav Kumar
On 5/10/2023 11:15 PM, Marijn Suijten wrote: On 2023-05-10 14:03:14, Jessica Zhang wrote: On 5/9/2023 11:33 PM, Marijn Suijten wrote: On 2023-05-09 15:06:50, Jessica Zhang wrote: Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Reviewed-by:

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Simon Ser
On Friday, May 5th, 2023 at 15:30, Joshua Ashton wrote: > > > AMD would expose the following objects and properties: > > > > > > Plane 10 > > > ├─ "type": immutable enum {Overlay, Primary, Cursor} = Primary > > > └─ "color_pipeline": enum {0, 42} = 0 > > > Color operation 42

Re: [PATCH 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:00PM +0700, Bagas Sanjaya wrote: > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. Reviewed-by: Simon Horman

Re: [PATCH 07/10] drivers: staging: wlan-ng: Remove GPL/MPL boilerplate

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:03PM +0700, Bagas Sanjaya wrote: > Remove the license boilerplate as there is already SPDX license > identifier which fulfills the same intention as the boilerplate. Reviewed-by: Simon Horman

Re: [PATCH 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-11 Thread Guenter Roeck
On Thu, May 11, 2023 at 08:34:04PM +0700, Bagas Sanjaya wrote: > Many watchdog drivers's source files has already SPDX license > identifier, while some remaining doesn't. > > Convert notices on remaining files to SPDX identifier. > > Cc: Ray Lehtiniemi > Cc: Alessandro Zummo > Cc: Andrey Panin

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Wed, May 10, 2023 at 04:55:04PM -0700, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > The internal_hpd flag was introduced to handle external DP HPD derived from > > GPIO > > pinmuxed into DP controller. > > Was it? It looks more like it was done to differentiate between

Re: [PATCH] drivers: fbdev: arcfb: Fix error handling in arcfb_probe()

2023-05-11 Thread Helge Deller
On 5/9/23 13:27, Zongjie Li wrote: Smatch complains that: arcfb_probe() warn: 'irq' from request_irq() not released on lines: 587. Fix error handling in the arcfb_probe() function. If IO addresses are not provided or framebuffer registration fails, the code will jump to the err_addr or

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-11 Thread Joshua Ashton
When we are talking about being 'prescriptive' in the API, are we outright saying we don't want to support arbitrary 3D LUTs, or are we just offering certain algorithms to be 'executed' for a plane/crtc/etc in the atomic API? I am confused... There is so much stuff to do with color, that I don't

Re: [PATCH v6 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-11 Thread Dmitry Baryshkov
On 11/05/2023 20:00, Kuogee Hsieh wrote: On 5/10/2023 9:52 PM, Dmitry Baryshkov wrote: On 11/05/2023 01:07, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is

Re: [PATCH v2] drm/mgag200: Fix gamma lut not initialized.

2023-05-11 Thread Jocelyn Falempe
On 11/05/2023 14:26, Thomas Zimmermann wrote: Hi Am 10.05.23 um 15:10 schrieb Jocelyn Falempe: When mgag200 switched from simple KMS to regular atomic helpers, the initialization of the gamma settings was lost. This leads to a black screen, if the bios/uefi doesn't use the same pixel color

Re: [PATCH 03/10] net: bonding: Add SPDX identifier to remaining files

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:59PM +0700, Bagas Sanjaya wrote: > Previous batches of SPDX conversion missed bond_main.c and bonding_priv.h > because these files doesn't mention intended GPL version. Add SPDX identifier > to these files, assuming GPL 1.0+. Reviewed-by: Simon Horman

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-11 Thread Rob Clark
On Tue, May 9, 2023 at 9:37 AM Rob Clark wrote: > > From: Rob Clark > > When the special handling of qcom,adreno-smmu was moved into > qcom_smmu_create(), it was overlooked that we didn't have all the > required entries in qcom_smmu_impl_of_match. So we stopped getting > adreno_smmu_priv on

Re: [PATCH 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:58PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL notice boilerplate on dsp_* with SPDX identifier > for GPL 1.0+. These files missed previous SPDX conversion batches > due to not specifying GPL version. Reviewed-by: Simon Horman

Re: [PATCH 06/10] pcmcia: Add SPDX identifier

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:34:02PM +0700, Bagas Sanjaya wrote: > Add SPDX identifier on remaining files untouched during previous > rounds of SPDX conversion while replacing boilerplate notice if any. Reviewed-by: Simon Horman

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Thu, May 11, 2023 at 07:24:46AM +0300, Dmitry Baryshkov wrote: > On Wed, 10 May 2023 at 23:31, Kuogee Hsieh wrote: > > > > The internal_hpd flag was introduced to handle external DP HPD derived from > > GPIO > > pinmuxed into DP controller. HPD plug/unplug interrupts cannot be enabled > >

Re: [PATCH v1 0/2] enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Dmitry Baryshkov
On 10/05/2023 23:31, Kuogee Hsieh wrote: There is bug report on exteranl DP display does not work. This patch add below two patches to fix the problem. 1) enable HDP plugin/unplugged interrupts to hpd_enable/disable 2) add mutex to protect internal_hpd against race condition between different

Re: [PATCH v2] video: imsttfb: Fix use after free bug in imsttfb_probe due to lack of error-handling of init_imstt

2023-05-11 Thread Helge Deller
On 4/27/23 05:08, Zheng Wang wrote: A use-after-free bug may occur if init_imstt invokes framebuffer_release and free the info ptr. The caller, imsttfb_probe didn't notice that and still keep the ptr as private data in pdev. If we remove the driver which will call imsttfb_remove to make

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-05-11 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-05-09 20:41:54) > On Sat, Apr 29, 2023 at 12:47 PM Stephen Boyd wrote: > > > > Good point. I'm suggesting to make the drm bridge chain into a tree. We > > need to teach drm_bridge core about a mux, and have some logic to > > navigate atomically switching from one output

Re: [PATCH 01/10] agp/amd64: Remove GPL distribution notice

2023-05-11 Thread Simon Horman
On Thu, May 11, 2023 at 08:33:57PM +0700, Bagas Sanjaya wrote: > There is already SPDX tag which does the job, so remove the redundant > notice. > > Cc: Christophe JAILLET > Signed-off-by: Bagas Sanjaya Reviewed-by: Simon Horman

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Stephen Boyd
Quoting Bjorn Andersson (2023-05-11 08:44:16) > On Wed, May 10, 2023 at 05:39:07PM -0700, Abhinav Kumar wrote: > > > > > > On 5/10/2023 4:55 PM, Stephen Boyd wrote: > > > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > > > The internal_hpd flag was introduced to handle external DP HPD derived > >

Re: [Intel-xe] [PATCH 1/2] drm/xe: Fix unlocked access of the vma::rebind_link

2023-05-11 Thread Matthew Brost
On Wed, May 10, 2023 at 04:19:31PM +0200, Thomas Hellström wrote: > the vma::rebind_link is protected by the vm's resv, but we was > modifying it without. Fix this by use the vma::userptr_link instead > for the tmp_evict list. The vma::userptr_link is protected by the > vm lock. > >

Re: [PATCH 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-11 Thread Rob Clark
On Thu, May 11, 2023 at 7:51 AM Dmitry Baryshkov wrote: > > On Tue, 9 May 2023 at 19:37, Rob Clark wrote: > > > > From: Rob Clark > > > > When the special handling of qcom,adreno-smmu was moved into > > qcom_smmu_create(), it was overlooked that we didn't have all the > > required entries in

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Helge Deller
On 5/11/23 16:27, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should even be around any longer. Fbdev has been deprecated for a long time. But a small number of drivers are still in

[PATCH v7 8/8] drm/msm/dpu: tear down DSC data path when DSC disabled

2023-05-11 Thread Kuogee Hsieh
Unset DSC_ACTIVE bit at dpu_hw_ctl_reset_intf_cfg_v1(), dpu_encoder_unprep_dsc() and dpu_encoder_dsc_pipe_clr() functions to tear down DSC data path if DSC data path was setup previous. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c |

[PATCH v7 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-11 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in v4: -- delete DPU_DSC_HW_REV_1_1 -- delete

[PATCH v7 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-11 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush

[PATCH v7 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-11 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. changes in v4: --

[RESEND PATCH] drm/i915: constify pointers to hwmon_channel_info

2023-05-11 Thread Krzysztof Kozlowski
Statically allocated array of pointers to hwmon_channel_info can be made const for safety. Acked-by: Jani Nikula Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/i915/i915_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_hwmon.c

[RESEND PATCH] drm/nouveau: constify pointers to hwmon_channel_info

2023-05-11 Thread Krzysztof Kozlowski
Statically allocated array of pointers to hwmon_channel_info can be made const for safety. Reviewed-by: Lyude Paul Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-11 Thread Bagas Sanjaya
Many watchdog drivers's source files has already SPDX license identifier, while some remaining doesn't. Convert notices on remaining files to SPDX identifier. Cc: Ray Lehtiniemi Cc: Alessandro Zummo Cc: Andrey Panin Cc: Oleg Drokin Cc: Marc Zyngier Cc: Jonas Jensen Cc: Sylver Bruneau Cc:

  1   2   >