[PATCH] drm/msm/dpu: tidy up some error checking

2023-06-06 Thread Dan Carpenter
The "vsync_hz" variable is unsigned int so it can't be less than zero. The dpu_kms_get_clk_rate() function used to return a u64 but I previously changed it to return an unsigned long and zero on error so it matches clk_get_rate(). Change the "vsync_hz" type to unsigned long as well and change

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

[PATCH v7 7/8] drm/tidss: Update encoder/bridge chain connect model

2023-06-06 Thread Aradhya Bhatia
With the new encoder/bridge chain model, the display controller driver is required to create a drm_connector entity instead of asking the bridge to do so during drm_bridge_attach. Moreover, the controller driver should create a drm_bridge entity to negotiate bus formats and a 'simple' drm_encoder

[PATCH v7 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar When removing the tidss driver, there is a warning reported by kernel about an unhandled interrupt for mhdp driver. [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) ... [snipped backtrace] [ 43.330735] handlers: [ 43.333020]

[PATCH v7 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook for the same.

[PATCH v7 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format negotiation can be added based on EDID data.

[PATCH v7 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Signed-off-by: Nikhil

[PATCH v7 0/8] drm/tidss: Use new connector model for tidss

2023-06-06 Thread Aradhya Bhatia
Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR. It also now creates bridge to

[PATCH v7 1/8] drm/bridge: tfp410: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar With new connector model, tfp410 will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input format is the one

[PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-06-06 Thread Aradhya Bhatia
With new connector model, sii902x will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper functions for state management. Input

[PATCH v7 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-06-06 Thread Aradhya Bhatia
From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement atomic_check hook

Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API

2023-06-06 Thread Daniel Thompson
On Mon, Jun 05, 2023 at 07:07:24PM +0300, Andy Shevchenko wrote: > On Mon, Mar 20, 2023 at 01:54:26PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 17, 2023 at 09:53:40PM +0100, Linus Walleij wrote: > > > On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko > > > wrote: > > > > > > > The of_gpio.h is

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 06.06.23 um 09:49 schrieb Dan Carpenter: On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To:

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-06 Thread Thomas Zimmermann
Hi Javierm, I've read through the patches and they look correct to me. Reviewed-by: Thomas Zimmermann But I had one question about the page size. You round up to multiples of page_size in several places. That could lead to an out-of-bounds access. Do you need to allocate GEM buffers to be

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Joonas Lahtinen
Quoting Yang, Fei (2023-06-06 09:51:06) > >> On 31/05/2023 18:10, fei.y...@intel.com wrote: > >>> From: Fei Yang > >>> > >>> To comply with the design that buffer objects shall have immutable > >>> cache setting through out their life cycle, {set, get}_caching ioctl's > >>> are no longer

[PATCH] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-06 Thread Su Hui
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Dan Carpenter
On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: > > > -Original Message- > > > From: dri-devel On Behalf Of > > > Thomas Zimmermann > > > Sent: Monday, June 5, 2023 10:48 AM > > > To: dan...@ffwll.ch;

Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-06 Thread Paulo Pavacic
Hello Krzysztof, uto, 6. lip 2023. u 09:14 Krzysztof Kozlowski napisao je: > > On 05/06/2023 17:35, Paulo Pavacic wrote: > > Fannal C3004 is a 480x800 display made by fannal that requires > > DCS initialization sequences. > > > > Signed-off-by: Paulo Pavacic > > --- > > > v3 changelog: > > -

Re: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 ttm_bo_release+0x27e/0x2d0 [ttm]

2023-06-06 Thread Thomas Zimmermann
Hi Am 05.06.23 um 18:36 schrieb Deucher, Alexander: [...] [ 17.217468] Call Trace: [ 17.217470] [ 17.217472] ? __warn+0x97/0x160 [ 17.217476] ? ttm_bo_release+0x27e/0x2d0 [ttm] [ 17.217481] ? report_bug+0x1ec/0x200 [ 17.217487] ? handle_bug+0x3c/0x70 [ 17.217490] ?

Re: [PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent

2023-06-06 Thread Thomas Zimmermann
Hi Am 06.06.23 um 07:28 schrieb Dan Carpenter: On Mon, Jun 05, 2023 at 04:48:00PM +0200, Thomas Zimmermann wrote: Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To: dan...@ffwll.ch; javi...@redhat.com; s...@ravnborg.org; del...@gmx.de; geert+rene...@glider.be; l...@kernel.org;

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

Re: [PATCH V3 1/3] dt-bindings: panel: Add Anbernic RG353V-V2 panel compatible

2023-06-06 Thread Frank Oltmanns
Hi Chris, hi Guido, On 2023-04-26 at 16:54:46 +0200, Guido Günther wrote: > Hi Chris, > could you check if these two modifications by Frank of the init sequence > > > https://lore.kernel.org/dri-devel/20230211171748.36692-2-fr...@oltmanns.dev/ > >

Re: [PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Fannal C3004 is a 480x800 display made by fannal that requires > DCS initialization sequences. > > Signed-off-by: Paulo Pavacic > --- > v3 changelog: > - using generic mipi_dsi_dcs_write_seq This is marked as v2? > - removed success prints > -

Re: [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > DCS initialization sequences with certain delays between certain > commands. > +#include > +dsi { > +

Re: [PATCH v2 1/3] dt-bindings: add fannal vendor prefix

2023-06-06 Thread Krzysztof Kozlowski
On 05/06/2023 17:35, Paulo Pavacic wrote: > Fannal is a one-stop-solution provider for touch displays in industrial > application, committed to delivering a variety of professional high-quality > products and technical services globally. > > Website: www.fannal.com > > Signed-off-by: Paulo

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-06 Thread Yang, Fei
>> On 31/05/2023 18:10, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> To comply with the design that buffer objects shall have immutable >>> cache setting through out their life cycle, {set, get}_caching ioctl's >>> are no longer supported from MTL onward. With that change caching >>>

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-06 Thread kernel test robot
Hi Daniele, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-gsc-fixes-and-updates-for-GSC-memory-allocation/20230606-102510 base: git

Re: [PATCH v9 0/4] drm/i915: use ref_tracker library for tracking wakerefs

2023-06-06 Thread Andrzej Hajda
On 06.06.2023 00:33, Jakub Kicinski wrote: On Fri, 02 Jun 2023 12:21:32 +0200 Andrzej Hajda wrote: This is reviewed series of ref_tracker patches, ready to merge via network tree, rebased on net-next/main. i915 patches will be merged later via intel-gfx tree. FWIW I'll try to merge these on

<    1   2   3