Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-12 Thread Thomas Zimmermann
Hi Am 11.06.23 um 18:37 schrieb Sam Ravnborg: Hi Thomas, On Mon, Jun 05, 2023 at 04:48:12PM +0200, Thomas Zimmermann wrote: Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev device optional. If the new option has not been selected, fbdev does not create a files in devfs or sysfs.

[PATCH] gpu: drm/amd: Fix the bug in list_for_each_entry() loops

2023-06-12 Thread Lu Hongfei
pqn bound in list_for_each_entry loop will not be null, so there is no need to check whether pqn is NULL or not. We could remove this check. Signed-off-by: Lu Hongfei --- drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_d

RE: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-12 Thread Kasireddy, Vivek
Hi Mike, Sorry for the late reply; I just got back from vacation. If it is unsafe to directly use the subpages of a hugetlb page, then reverting this patch seems like the only option for addressing this issue immediately. So, this patch is Acked-by: Vivek Kasireddy As far as the use-case is conc

RE: [PATCH v4 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-06-12 Thread Kalyan Thota
Thanks for your email. Can you help share some details. 1) https://termbin.com/31lc , I am unable to open the link in my office network, can you copy the logs in a text file and share with me. 2) Which DPU version are you trying from the catalogue, can you share the version ? 3) The patch will fa

Re: [PATCH 2/2] drm/msm/dsi: don't allow enabling 7nm VCO with unprogrammed rate

2023-06-12 Thread Degdag Mohamed
[Dmitry Baryshkov], Thank you for sharing the patches. I have reviewed and tested all three patches, and they seem to be working correctly. Tested-by: Degdag Mohamed degdagmoha...@gmail.com Please let me know if you need any further information or assistance. Best regards, Degdag Mohamed On 6/

Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7

2023-06-12 Thread Alexandre TORGUE
hi Dario On 6/9/23 08:21, Dario Binacchi wrote: Hi Alexandre, On Thu, Jun 8, 2023 at 2:42 PM Alexandre TORGUE wrote: Hi Dario On 6/7/23 08:31, Dario Binacchi wrote: Add pin configurations for using LTDC (LCD-tft Display Controller) on stm32f746-disco board. Signed-off-by: Dario Binacchi

RE: [PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-12 Thread Quan, Evan
[AMD Official Use Only - General] Thanks Johannes. Comment in-line > -Original Message- > From: Johannes Berg > Sent: Friday, June 9, 2023 4:21 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...

Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-12 Thread David Hildenbrand
On 12.06.23 09:10, Kasireddy, Vivek wrote: Hi Mike, Hi Vivek, Sorry for the late reply; I just got back from vacation. If it is unsafe to directly use the subpages of a hugetlb page, then reverting this patch seems like the only option for addressing this issue immediately. So, this patch is

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-12 Thread Thomas Zimmermann
Hi Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: Conor Dooley writes: On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: Conor Dooley writes: On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: A default resolution in the ssd130x driv

[PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Liu Ying
When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), overlay plane's framebuffer pointer is NULL. So, dereferencing it would cause a kernel Oops(NULL pointer dereferencing). Fix the issue by disabling overlay plane in mxsfb_plane_overlay_atomic_disable() instead. Fixes: cb285a534

Re: [PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Sam Ravnborg
Hi Liu Ying. On Mon, Jun 12, 2023 at 03:55:30PM +0800, Liu Ying wrote: > When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), > overlay plane's framebuffer pointer is NULL. So, dereferencing it would > cause a kernel Oops(NULL pointer dereferencing). Fix the issue by > disabling

Re: [PATCH 1/5] drm/mediatek: Remove freeing not dynamic allocated memory

2023-06-12 Thread 胡俊光

Re: [PATCH 1/2] drm/msm: provide fb_dirty implemenation

2023-06-12 Thread Thomas Zimmermann
Hi Am 12.06.23 um 05:16 schrieb Dmitry Baryshkov: Since commit 93e81e38e197 ("drm/fb_helper: Minimize damage-helper overhead") the drm_fb_helper_funcs::fb_dirty helper is required for proper dirty/damage processing. The drm/msm driver requires that to function to let CMD panels to work. Use simp

Re: [PATCH 2/5] drm/mediatek: Add cnt checking for coverity issue

2023-06-12 Thread 胡俊光

Re: [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-12 Thread Tvrtko Ursulin
On 09/06/2023 18:09, Rob Clark wrote: On Fri, Jun 9, 2023 at 7:12 AM Tvrtko Ursulin wrote: On 09/06/2023 13:44, Iddamsetty, Aravind wrote: On 09-06-2023 17:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which will return

Re: [PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Ying Liu
On Mon, Jun 12, 2023 at 4:04 PM Sam Ravnborg wrote: > > Hi Liu Ying. Hi Sam, > > On Mon, Jun 12, 2023 at 03:55:30PM +0800, Liu Ying wrote: > > When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), > > overlay plane's framebuffer pointer is NULL. So, dereferencing it would > > cau

Re: [PATCH 3/5] drm/mediatek: Add initialization for mtk_gem_obj

2023-06-12 Thread 胡俊光

Re: [PATCH 3/7] drm/panel: sitronix-st7789v: Specify the expected bus format

2023-06-12 Thread Maxime Ripard
Hi, On Fri, Jun 09, 2023 at 04:59:47PM +0200, Miquel Raynal wrote: > The LCD controller supports RGB444, RGB565 and RGB888. The value that is > written in the COLMOD register indicates using RGB888, so let's clearly > specify the in-use bus format. > > Signed-off-by: Miquel Raynal > --- > drive

Re: [PATCH 6/7] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support

2023-06-12 Thread Maxime Ripard
On Fri, Jun 09, 2023 at 04:59:50PM +0200, Miquel Raynal wrote: > This panel from Emerging Display Technologies Corporation features an > ST7789V2 panel inside which is almost identical to what the Sitronix > panel driver supports. > > In practice, the module physical size is specific, and experime

[PATCH v6 00/11] MediaTek DDP GAMMA - 12-bit LUT support

2023-06-12 Thread AngeloGioacchino Del Regno
Changes in v6: - Fixed smatch warning in patch 11/11, ref.: https://lore.kernel.org/all/202306101458.lrxhee0z-...@intel.com/ Changes in v5: - Removed incorrect comment on default LUT size and bits - Removed useless check for num_lut_banks - Added comment about CMDQ implementation on patch 5

[PATCH v6 01/11] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters

2023-06-12 Thread AngeloGioacchino Del Regno
From: "Jason-JH.Lin" Adjust the parameters in mtk_drm_gamma_set_common() - add (struct device *dev) to get lut_diff from gamma's driver data - remove (bool lut_diff) and use false as default value in the function Signed-off-by: Jason-JH.Lin Signed-off-by: AngeloGioacchino Del Regno --- d

[PATCH v6 04/11] drm/mediatek: gamma: Improve and simplify HW LUT calculation

2023-06-12 Thread AngeloGioacchino Del Regno
Use drm_color_lut_extract() to avoid open-coding the bits reduction calculations for each color channel and use a struct drm_color_lut to temporarily store the information instead of an array of u32. Also, slightly improve the precision of the HW LUT calculation in the LUT DIFF case by performing

[PATCH v6 10/11] drm/mediatek: gamma: Make sure relay mode is disabled

2023-06-12 Thread AngeloGioacchino Del Regno
Disable relay mode at the end of LUT programming to make sure that the processed image goes through. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediate

[PATCH v6 08/11] drm/mediatek: gamma: Support multi-bank gamma LUT

2023-06-12 Thread AngeloGioacchino Del Regno
Newer Gamma IP have got multiple LUT banks: support specifying the size of the LUT banks and handle bank-switching before programming the LUT in mtk_gamma_set_common() in preparation for adding support for MT8195 and newer SoCs. Suggested-by: Jason-JH.Lin [Angelo: Refactored original commit] Sign

[PATCH v6 06/11] drm/mediatek: gamma: Use bitfield macros

2023-06-12 Thread AngeloGioacchino Del Regno
Make the code more robust and improve readability by using bitfield macros instead of open coding bit operations. While at it, also add a definition for LUT_BITS_DEFAULT. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 41

[PATCH v6 03/11] drm/mediatek: gamma: Support SoC specific LUT size

2023-06-12 Thread AngeloGioacchino Del Regno
Newer SoCs support a bigger Gamma LUT table: wire up a callback to retrieve the correct LUT size for each different Gamma IP. Co-developed-by: Jason-JH.Lin Signed-off-by: Jason-JH.Lin [Angelo: Rewritten commit message/description + porting] Signed-off-by: AngeloGioacchino Del Regno Reviewed-by

[PATCH v6 02/11] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common()

2023-06-12 Thread AngeloGioacchino Del Regno
Invert the check for state->gamma_lut and move it at the beginning of the function to reduce indentation: this prepares the code for keeping readability on later additions. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin --- driver

[PATCH v6 07/11] drm/mediatek: gamma: Support specifying number of bits per LUT component

2023-06-12 Thread AngeloGioacchino Del Regno
New SoCs, like MT8195, not only may support bigger lookup tables, but have got a different register layout to support bigger precision: support specifying the number of `lut_bits` for each SoC and use it in mtk_gamma_set_common() to perform the right calculation. Signed-off-by: AngeloGioacchino De

[PATCH v6 09/11] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-06-12 Thread AngeloGioacchino Del Regno
Add support for 12-bit gamma lookup tables and introduce the first user for it: MT8195. While at it, also reorder the variables in mtk_gamma_set_common() and rename `lut_base` to `lut0_base` to improve readability. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin --- drivers

[PATCH v6 05/11] drm/mediatek: gamma: Enable the Gamma LUT table only after programming

2023-06-12 Thread AngeloGioacchino Del Regno
Move the write to DISP_GAMMA_CFG to enable the Gamma LUT to after programming the actual table to avoid potential visual glitches during table modification. Note: GAMMA should get enabled in between vblanks, but this requires many efforts in order to make this happen, as that requires migrating al

[PATCH v6 11/11] drm/mediatek: gamma: Program gamma LUT type for descending or rising

2023-06-12 Thread AngeloGioacchino Del Regno
All of the SoCs that don't have dithering control in the gamma IP have got a GAMMA_LUT_TYPE bit that tells to the IP if the LUT is "descending" (bit set) or "rising" (bit cleared): make sure to set it correctly after programming the LUT. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jas

Re: [PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Marek Vasut
On 6/12/23 09:55, Liu Ying wrote: When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), overlay plane's framebuffer pointer is NULL. So, dereferencing it would cause a kernel Oops(NULL pointer dereferencing). Fix the issue by disabling overlay plane in mxsfb_plane_overlay_atomic_

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-12 Thread Tatsuyuki Ishi
Hi Christian, > On May 4, 2023, at 20:51, Christian König > wrote: > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 08eced097bd8..9e751f5d4aa7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH 4/5] drm/mediatek: Add casting before assign

2023-06-12 Thread 胡俊光

Re: [PATCH 5/5] drm/mediatek: Fix dereference before null check

2023-06-12 Thread 胡俊光

Re: [PATCH 1/2] drm/msm: provide fb_dirty implemenation

2023-06-12 Thread Marijn Suijten
On 2023-06-12 06:16:15, Dmitry Baryshkov wrote: > Since commit 93e81e38e197 ("drm/fb_helper: Minimize damage-helper > overhead") the drm_fb_helper_funcs::fb_dirty helper is required for > proper dirty/damage processing. The drm/msm driver requires that to > function to let CMD panels to work. Use s

Re: [PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Ying Liu
On Mon, Jun 12, 2023 at 5:06 PM Marek Vasut wrote: > > On 6/12/23 09:55, Liu Ying wrote: > > When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), > > overlay plane's framebuffer pointer is NULL. So, dereferencing it would > > cause a kernel Oops(NULL pointer dereferencing). Fix t

Re: [PATCH 2/2] drm/msm/dsi: don't allow enabling 7nm VCO with unprogrammed rate

2023-06-12 Thread Marijn Suijten
On 2023-06-12 06:16:16, Dmitry Baryshkov wrote: > CCF can try enabling VCO before the rate has been programmed. This can > cause clock lockups and/or other boot issues. Program the VCO to the > minimal PLL rate if the read rate is 0 Hz. > > Reported-by: Degdag Mohamed > Fixes: 1ef7c99d145c ("drm/

[PATCH v2] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Liu Ying
When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), overlay plane's framebuffer pointer is NULL. So, dereferencing it would cause a kernel Oops(NULL pointer dereferencing). Fix the issue by disabling overlay plane in mxsfb_plane_overlay_atomic_disable() instead. Fixes: cb285a534

Re: [PATCH 2/2] drm/msm/dsi: don't allow enabling 7nm VCO with unprogrammed rate

2023-06-12 Thread Marijn Suijten
On 2023-06-12 11:15:53, Marijn Suijten wrote: > On 2023-06-12 06:16:16, Dmitry Baryshkov wrote: > > CCF can try enabling VCO before the rate has been programmed. This can > > cause clock lockups and/or other boot issues. Program the VCO to the > > minimal PLL rate if the read rate is 0 Hz. > > > >

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-12 Thread Pekka Paalanen
On Fri, 9 Jun 2023 19:11:25 -0400 Christopher Braga wrote: > On 6/9/2023 12:30 PM, Simon Ser wrote: > > Hi Christopher, > > > > On Friday, June 9th, 2023 at 17:52, Christopher Braga > > wrote: > > > >>> The new COLOROP objects also expose a number of KMS properties. Each has a > >>> type, a

Re: [PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Marek Vasut
On 6/12/23 11:15, Ying Liu wrote: On Mon, Jun 12, 2023 at 5:06 PM Marek Vasut wrote: On 6/12/23 09:55, Liu Ying wrote: When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), overlay plane's framebuffer pointer is NULL. So, dereferencing it would cause a kernel Oops(NULL pointer

Re: [PATCH v2] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Marek Vasut
On 6/12/23 11:23, Liu Ying wrote: When disabling overlay plane in mxsfb_plane_overlay_atomic_update(), overlay plane's framebuffer pointer is NULL. So, dereferencing it would cause a kernel Oops(NULL pointer dereferencing). Fix the issue by disabling overlay plane in mxsfb_plane_overlay_atomic_

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi All, How do we proceed here between [1] and [2]? DT-Maintainers suggestion: [1] raa215300: pmic@12 { compatible = "renesas,raa215300"; reg = <0x12>, <0x6f>; reg-names = "main", "rtc"; clocks = <&x2>; clock-names = "xin"; /* Add Optional shared I

Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-12 Thread Thomas Zimmermann
Hi Javier Am 08.06.23 um 00:22 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Detect registered instances of fb_info by reading the reference counter from struct fb_info.read. Avoids looking at the dev field and prepares fbdev for making struct fb_info.dev optional. Signed-off-b

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-12 Thread Thomas Zimmermann
Hi Am 07.06.23 um 22:48 schrieb Sam Ravnborg: Hi Thomas. On Mon, Jun 05, 2023 at 04:48:10PM +0200, Thomas Zimmermann wrote: Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. Signed-off-by: Thomas Zimmermann Consider moving the

Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-12 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javier > > Am 08.06.23 um 00:22 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Detect registered instances of fb_info by reading the reference >>> counter from struct fb_info.read. Avoids looking at the dev field >>> and prepa

Re: [PATCH 00/30] fbdev: Make userspace interfaces optional

2023-06-12 Thread Thomas Zimmermann
Hi Am 07.06.23 um 10:35 schrieb Geert Uytterhoeven: [...] BTW, I am wondering if it would be possible to write a DRM emulation layer on top of (basic, e.g. no MMIO, just fb) fbdev? That exists, sort of. I first posted it here: https://patchwork.freedesktop.org/series/58569/ and it has la

[PATCH 6.3 035/160] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

2023-06-12 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 50d30040eb856ff6b0382b4d9dc332dc15597729 ] Drivers that use the gen_pool*() family of functions should select GENERIC_ALLOCATOR to prevent build errors like these: ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': include/linux/genalloc.h:172:

[PATCH v4 0/5] fdinfo memory stats

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I added tracking of most classes of objects which contribute to client's memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Accounting by keeping per client lists may not be the most eff

[PATCH 1/5] drm/i915: Add ability for tracking buffer objects per client

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold refere

[PATCH 2/5] drm/i915: Record which client owns a VM

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 --- drivers/gpu/drm/i915/gem

[PATCH 3/5] drm/i915: Track page table backing store usage

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/int

[PATCH 4/5] drm/i915: Account ring buffer and context state storage

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_context.c | 8 drivers/gpu/drm/i915/i915_drm_client.c | 10 ++ drivers/gpu/drm/i915/i915_drm_clie

[PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-06-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

Re: [PATCH 1/2] drm/msm: provide fb_dirty implemenation

2023-06-12 Thread Thomas Zimmermann
Hi Am 12.06.23 um 11:14 schrieb Marijn Suijten: On 2023-06-12 06:16:15, Dmitry Baryshkov wrote: Since commit 93e81e38e197 ("drm/fb_helper: Minimize damage-helper overhead") the drm_fb_helper_funcs::fb_dirty helper is required for proper dirty/damage processing. The drm/msm driver requires that

[RFC PATCH 0/3] Introduce KUnit tests for TTM subsystem

2023-06-12 Thread Karolina Stolarek
This series introduces KUnit[1] tests for TTM (Translation Table Manager) subsystem, a memory manager used by graphics drivers to create and manage memory buffers across different memory domains, such as system memory or VRAM. Unit tests implemented here cover two data structures: - ttm_device -

[RFC PATCH 1/3] drm/ttm: Introduce KUnit tests

2023-06-12 Thread Karolina Stolarek
Add an initial version of unit tests for ttm_device struct, together with helper functions. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig | 15 ++ drivers/gpu/drm/ttm/Makefile | 1 + drivers/gpu/drm/ttm/tests/.kunitconfig| 4 ++

[RFC PATCH 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-06-12 Thread Karolina Stolarek
Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Mak

[RFC PATCH 2/3] drm/ttm/tests: Add tests for ttm_device

2023-06-12 Thread Karolina Stolarek
Test initialization and cleanup of the ttm_device struct, including some error paths. Verify the creation of page pools if use_dma_alloc param is true. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 159 1 file changed, 159 insertions(+)

[PATCH 3/3] accel/habanalabs: change user interrupt to threaded IRQ

2023-06-12 Thread Oded Gabbay
From: Tal Cohen It is preferable to handle the user interrupt job from a threaded IRQ context. This will allow to avoid disabling interrupts when the user process registers for a new event and to avoid long handling inside an interrupt. Signed-off-by: Tal Cohen Reviewed-by: Oded Gabbay Signed-

[PATCH 2/3] accel/habanalabs: fix wait_for_interrupt abortion flow

2023-06-12 Thread Oded Gabbay
From: farah kassabri When the driver needs to abort waiters for interrupts, for cases such as critical events that occur and driver need to do hard reset, in such scenario the driver will complete the fence to wake up the waiting thread, and will set the fence error indication. The return value o

[PATCH 1/3] accel/habanalabs: Allow single timestamp registration request at a time

2023-06-12 Thread Oded Gabbay
From: farah kassabri Protect against concurrency of user requesting to register a timestamp offset (where the driver fills the timestamp when the command submission has finished executing) to a specific user interrupt ID. The protection is basically to allow only one timestamp registration reques

Re: [PATCH] accel/qaic: Fix dereferencing freed memory

2023-06-12 Thread Christian König
Am 10.06.23 um 04:12 schrieb Sukrut Bellary: smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error: dereferencing freed memory 'obj->import_attach' obj->import_attach is detached and freed using dma_buf_detach(). But used after free to decrease th

Re: [RFC PATCH 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-06-12 Thread Karolina Stolarek
Hi Christian, I have a question about how ttm_pool_alloc should handle a request for order > MAX_ORDER. Could you take a look at my comment below? Thanks a lot. On 12.06.2023 12:55, Karolina Stolarek wrote: Add KUnit tests that exercise page allocation using page pools and freeing pages, eith

Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header

2023-06-12 Thread Lee Jones
On Fri, 09 Jun 2023, Matthias Brugger wrote: > > > On 09/06/2023 10:17, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter > > or member 'clk' not described in 'mtk_disp_ccorr' > > drivers/

[PATCH v2 3/3] dw-hdmi: remove dead code and fix indentation

2023-06-12 Thread Adrián Larumbe
The hdmi_datamap enum is no longer in use. Also reindent enable_audio's call params. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH v2 2/3] dw-hdmi: truly enforce 420-only formats when drm mode demands it

2023-06-12 Thread Adrián Larumbe
The current output bus format selection logic is enforcing YUV420 even when the drm mode allows for other bus formats as well. Fix it by adding check for 420-only drm modes. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 --- 1 file changed, 4 insertions(+),

[PATCH v2 0/3] Add additional YUV420 bus format check for dw-meson's bridge enable

2023-06-12 Thread Adrián Larumbe
This is v2 of: https://lore.kernel.org/dri-devel/20230528140001.1057084-1-adrian.laru...@collabora.com/ The only difference is having added an actual commit message to patch number 3 in the series. Adrián Larumbe (3): drm/meson: dw-hdmi: change YUV420 selection logic at clock setup dw-hdmi: t

[PATCH v2 1/3] drm/meson: dw-hdmi: change YUV420 selection logic at clock setup

2023-06-12 Thread Adrián Larumbe
Right now clocking value selection code is prioritising RGB, YUV444 modes over YUV420 for HDMI2 sinks. However, because of the bus format selection procedure in dw-hdmi, for HDMI2 sinks YUV420 is the format that will always be picked during the drm bridge chain check stage. Later on dw_hdmi_setup

Re: [PATCH] gpu: drm/amd: Fix the bug in list_for_each_entry() loops

2023-06-12 Thread Markus Elfring
> pqn bound in list_for_each_entry loop will not be null, so there is > no need to check whether pqn is NULL or not. Would it be more appropriate to use the wording “Delete an unnecessary check within a list_for_each_entry() loop” instead of “Fix the bug in list_for_each_entry() loops” in the patc

[PATCH v2] gpu: drm/amd: Remove the redundant null pointer check in list_for_each_entry() loops

2023-06-12 Thread Lu Hongfei
pqn bound in list_for_each_entry loop will not be null, so there is no need to check whether pqn is NULL or not. Thus remove a redundant null pointer check. Signed-off-by: Lu Hongfei --- The filename of the previous version was: 0001-gpu-drm-amd-Fix-the-bug-in-list_for_each_entry-loops.patch The

[PATCH 1/3] accel/habanalabs: remove pdev check on idle check

2023-06-12 Thread Oded Gabbay
Our simulator supports idle check so no need anymore to check if pdev exists. Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/de

[PATCH 2/3] accel/habanalabs: reset device if scrubbing failed

2023-06-12 Thread Oded Gabbay
If scrubbing memory after user released device has failed it means the device is in a bad state and should be reset. Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/accel/habanalabs/common/devi

[PATCH 3/3] accel/habanalabs: dump temperature threshold boot error

2023-06-12 Thread Oded Gabbay
From: Ofir Bitton Add dump of an error reported from f/w during boot time. This error indicates a failure with setting temperature threshold. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/firmware_if.c | 5 + 1 file cha

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > Hi All, > > How do we proceed here between [1] and [2]? > > DT-Maintainers suggestion: > [1] > raa215300: pmic@12 { > compatible = "renesas,raa215300"; > reg = <0x12>, <0x6f>; > reg-names = "main", "rtc"; > > clo

Re: [PATCH v2 0/3] Add additional YUV420 bus format check for dw-meson's bridge enable

2023-06-12 Thread Neil Armstrong
Hi, On 12/06/2023 13:23, Adrián Larumbe wrote: This is v2 of: https://lore.kernel.org/dri-devel/20230528140001.1057084-1-adrian.laru...@collabora.com/ The only difference is having added an actual commit message to patch number 3 in the series. Seems you didn't keep my Acked-by/Reviewed-by an

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Wolfram Sang
Hi Biju, > DT-Maintainers suggestion: > [1] > raa215300: pmic@12 { > compatible = "renesas,raa215300"; > reg = <0x12>, <0x6f>; > reg-names = "main", "rtc"; > > clocks = <&x2>; > clock-names = "xin"; > /* Add Optional shared IRQ resource and share it to child an

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Wolfram, Laurent, On Mon, Jun 12, 2023 at 2:36 PM Wolfram Sang wrote: > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; If you go for separate nodes: "renesas,raa215300-pmic". > > reg = <0x12>, <0x6f>; > > reg-names = "mai

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > Hi All, > > > > How do we proceed here between [1] and [2]? > > > > DT-Maintainers suggestion: > > [1] > > raa215300: p

[PATCH] drm/i915/gmch: avoid unused variable warning

2023-06-12 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_PNP is disabled, the mchbar_addr variable is only written but not read: drivers/gpu/drm/i915/soc/intel_gmch.c: In function 'intel_alloc_mchbar_resource': drivers/gpu/drm/i915/soc/intel_gmch.c:41:13: error: variable 'mchbar_addr' set but not used [-Werror=unused-

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote: > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > Hi All, > > > > How do we proceed here between [1] and [2]? > > > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa21

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Wolfram Sang
Hi Geert, > > Would this binding allow to not use the RTC if the second reg is > > missing? What are the advantages of not enabling RTC? Saving power? > > It doesn't work if there is no clock? Maybe I am confusing something now, but if the RTC _needs_ to be enabled, then why we don't do it uncon

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
Hi Biju, On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > > Hi All, > > > > > > How do we proce

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; > > reg = <0x12>, <0x6f>; > > reg-names = "main", "rtc"

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
On Mon, Jun 12, 2023 at 02:44:33PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote: > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > > Hi All, > > > > > > How do we proceed here between [1] and [2]? > > > > > > DT-Maintainers suggestion: >

Re: [PATCH] drm/sched: Add native dependency support to drm_sched

2023-06-12 Thread Boris Brezillon
Hi Donald, On Thu, 8 Jun 2023 13:23:26 + Donald Robson wrote: > /** > * drm_sched_job_arm - arm a scheduler job for execution > * @job: scheduler job to arm > @@ -669,6 +755,7 @@ void drm_sched_job_arm(struct drm_sched_job *job) > job->s_priority = entity->rq - sched->sched_rq; >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jun 12, 2023 at 2:48 PM Wolfram Sang wrote: > > > Would this binding allow to not use the RTC if the second reg is > > > missing? What are the advantages of not enabling RTC? Saving power? > > > > It doesn't work if there is no clock? > > Maybe I am confusing something now, bu

Re: [PATCH] drm/sched: Add native dependency support to drm_sched

2023-06-12 Thread Christian König
Am 08.06.23 um 15:23 schrieb Donald Robson: This patch adds support for 'native' dependencies to DRM scheduler. In drivers that use a firmware based scheduler there are performance gains to be had by allowing waits to happen in the firmware, as this reduces the latency between signalling and job

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jun 12, 2023 at 2:54 PM Laurent Pinchart wrote: > On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > > > How do we proceed h

Re: [PATCH 06/13] drm/amdgpu: use the new drm_exec object for CS v2

2023-06-12 Thread Tatsuyuki Ishi
Hi Chrisitan, On May 4, 2023, at 20:51, Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Use the new component here as well and remove the old handling. v2: drop dupplicate handling It seems that after dropping the duplicate handling, locking of VM PDs on global BO list is bas

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
Hi Geert, On Mon, Jun 12, 2023 at 03:08:46PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 12, 2023 at 2:54 PM Laurent Pinchart wrote: > > On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > On Mon, Jun

Re: [PATCH] accel/qaic: Fix dereferencing freed memory

2023-06-12 Thread Christian König
Am 12.06.23 um 15:03 schrieb Pranjal Ramajor Asha Kanojiya: On 6/12/2023 4:52 PM, Christian König wrote: Am 10.06.23 um 04:12 schrieb Sukrut Bellary: smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:     dereferencing freed memory 'obj->import_attach' obj

Re: [PATCH] drm/i915/gmch: avoid unused variable warning

2023-06-12 Thread Andi Shyti
Hi Arnd, On Mon, Jun 12, 2023 at 02:43:59PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PNP is disabled, the mchbar_addr variable is only written but > not read: > > drivers/gpu/drm/i915/soc/intel_gmch.c: In function > 'intel_alloc_mchbar_resource': > drivers/gpu/drm/i915

[PATCH] fbdev/media: Use GPIO descriptors for VIA GPIO

2023-06-12 Thread Linus Walleij
The VIA fbdev exposes a custom GPIO chip for its GPIOs, these are in turn looked up the camera driver using a custom API. Drop the custom API, provide a look-up table and convert to GPIO descriptors. Note proper polarity on the RESET line. Cc: Jonathan Corbet Signed-off-by: Linus Walleij --- I

[PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

2023-06-12 Thread Thomas Zimmermann
Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight driver

[PATCH v2 00/38] fbdev: Make userspace interfaces optional

2023-06-12 Thread Thomas Zimmermann
Add the new config option FB_DEVICE. If enabled, fbdev provides traditional userspace interfaces in devfs, sysfs and procfs, such as /dev/fb0 or /proc/fb. Modern Linux distrobutions have adopted DRM drivers for graphics output and use fbdev only for the kernel's framebuffer console. Userspace has

[PATCH v2 06/38] backlight/lv5207lp: Rename struct lv5207lp_platform_data.fbdev to 'dev'

2023-06-12 Thread Thomas Zimmermann
Rename struct lv5207lp_platform_data.fbdev to 'dev', as it stores a pointer to the Linux platform device; not the fbdev device. Makes the code easier to understand. Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: Lee Jones Cc: Daniel Thomp

[PATCH v2 13/38] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err()

2023-06-12 Thread Thomas Zimmermann
Fix cases were output helpers are called with struct fb_info.dev. Use fb_info() and fb_err() instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/ep93xx-fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device

2023-06-12 Thread Thomas Zimmermann
Struct lv5207lp_platform_data refers to a platform device within the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight dr

  1   2   3   >