Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Helge Deller
On 7/4/23 11:36, Yangtao Li wrote: Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li applied. Thanks! Helge --- drivers/video/fbdev/imxfb.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c

Re: [PATCH 01/10] fbdev/broadsheetfb: Select FB_SYS_HELPERS_DEFERRED

2023-07-07 Thread Thomas Zimmermann
Hi Am 06.07.23 um 21:13 schrieb Helge Deller: On 7/6/23 17:08, Thomas Zimmermann wrote: The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_BROADSHEET in favor of the existing identical selection.

Re: [PATCH] drm/fbdev-dma: Fix documented default preferred_bpp value

2023-07-07 Thread Thomas Zimmermann
Hi Am 06.07.23 um 17:30 schrieb Geert Uytterhoeven: As of commit 6c80a93be62d398e ("drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function"), the preferred_bpp parameter of drm_fb_helper_prepare() defaults to 32 instead of drm_mode_config.preferred_depth. Hence this also

Re: [PATCH 01/18] drm/renesas: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Laurent Pinchart
Hi Yangtao, Thank you for the patch. On Fri, Jul 07, 2023 at 03:20:17PM +0800, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 4 +--- > 1 file

Re: [PATCH 2/5] accel/ivpu: Add firmware tracing support

2023-07-07 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 24.05.2023 09:48, Stanislaw Gruszka wrote: > Add support for firmware tracing and logging via debugfs. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/accel/ivpu/Makefile | 3 +- > drivers/accel/ivpu/ivpu_debugfs.c | 169

Re: [PATCH 1/5] accel/ivpu: Initial debugfs support

2023-07-07 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 24.05.2023 09:48, Stanislaw Gruszka wrote: > Add initial debugfs support. Provide below functionality: > > - print buffer objects > - print latest boot mode > - trigger vpu engine reset > > Signed-off-by: Stanislaw Gruszka > --- > drivers/accel/ivpu/Makefile

Re: [PATCH 11/12] dt-bindings: drm/msm/gpu: Extend bindings for chip-id

2023-07-07 Thread Krzysztof Kozlowski
On 06/07/2023 23:10, Rob Clark wrote: > From: Rob Clark > > Upcoming GPUs use an opaque chip-id for identifying the GPU. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated

Re: [PATCH 08/18] gpu: ipu-v3: prg: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Philipp Zabel
On Fr, 2023-07-07 at 15:20 +0800, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 06/18] drm: bridge: dw_hdmi: Use devm_platform_get_and_ioremap_resource()

2023-07-07 Thread Neil Armstrong
On 07/07/2023 09:20, Yangtao Li wrote: Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yangtao Li --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +-- 1 file

Re: [PATCH 07/18] drm/bridge: analogix_dp: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Neil Armstrong
On 07/07/2023 09:20, Yangtao Li wrote: Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH 3/5] accel/ivpu: Add debugfs files for testing device reset

2023-07-07 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 24.05.2023 09:48, Stanislaw Gruszka wrote: > Add new debugfs files to validate device recovery functionality. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/accel/ivpu/ivpu_debugfs.c | 41 +++ > drivers/accel/ivpu/ivpu_pm.c

Re: [PATCH v4 0/9] MediaTek DisplayPort: support eDP and aux-bus

2023-07-07 Thread Chen-Yu Tsai
On Thu, Jul 6, 2023 at 8:30 PM AngeloGioacchino Del Regno wrote: > > Changes in v4: > - Set data lanes to idle to prevent stalls if bootloader didn't >properly close the eDP port > - Now using the .done_probing() callback for AUX bus to prevent >probe deferral loops in case the

[PATCH v3 01/12] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory

2023-07-07 Thread Thomas Zimmermann
Add initializer macros for struct fb_ops for framebuffers in DMA-able memory areas. Also add a corresponding Kconfig token. As of now, this is equivalent to system framebuffers and mostly useful for labeling drivers correctly. A later patch may add a generic DMA-specific mmap operation. Linux

[PATCH v3 09/12] drm/omapdrm: Use GEM mmap for fbdev emulation

2023-07-07 Thread Thomas Zimmermann
The fbdev emulation currently uses fbdev's default mmap code, which has been written for I/O memory. Provide an mmap that uses GEM's mmap infrastructure. Utilize fine-grained fbdev macros to initialize struct fb_ops. The macros set the read/write and the draw callbacks for DMA memory. Set the

[PATCH v3 12/12] fbdev: Harmonize some comments in

2023-07-07 Thread Thomas Zimmermann
Make the comments for I/O, system and DMA memory say the same. Makes the header file's structure more obvious. Suggested-by: Javier Martinez Canillas Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- include/linux/fb.h | 12 ++-- 1 file changed, 2

[PATCH v3 10/12] drm/omapdrm: Set fbdev FBINFO_VIRTFB flag

2023-07-07 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Tomi Valkeinen

[PATCH v3 06/12] drm/exynos: Use fbdev DMA helpers

2023-07-07 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev emulation. The driver previously used the I/O-memory helpers, while allocating DMA-able system memory. This could (in theory) result in bus errors from accessing the memory range. This bug has been present since the exynos driver was first added. v2: *

[PATCH v3 03/12] drm/tegra: Use fbdev DMA helpers

2023-07-07 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev emulation. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Thierry Reding Cc: Mikko Perttunen ---

[PATCH v3 08/12] drm/omapdrm: Set VM flags in GEM-object mmap function

2023-07-07 Thread Thomas Zimmermann
Use the mmap callback in struct drm_gem_object_funcs to set the VM flags. Replace a number of mmap helpers in omapdrm with their GEM helper counterparts. Generate DRM's file-operations instance with GEM's DEFINE_DRM_GEM_FOPS. The omapdrm driver uses DRM's drm_gem_mmap() helper to prepare the VMA

[PATCH v3 07/12] drm/exynos: Set fbdev FBINFO_VIRTFB flag

2023-07-07 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_FLAG_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by : Inki Dae Acked-by: Maxime

[PATCH v3 04/12] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-07 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Thierry Reding

[PATCH v3 00/12] drm: Improve fbdev emulation for DMA-able framebuffers

2023-07-07 Thread Thomas Zimmermann
Add fbdev helpers for framebuffers in DMA-able memory and update fbdev emulation in the respective DRM drivers. DMA memory used to handled as system memory. Improve this and prepare for possible future changes. Patch 1 adds initializer macros for struct fb_ops and a Kconfig token for framebuffers

[PATCH v3 02/12] drm/fbdev-dma: Use fbdev DMA helpers

2023-07-07 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev-dma. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 2 +-

[PATCH v3 11/12] fbdev: Remove FB_DEFAULT_SYS_OPS

2023-07-07 Thread Thomas Zimmermann
Remove the initializer macro FB_DEFAULT_SYS_OPS and its helper macro __FB_DEFAULT_SYS_OPS_MMAP. There are no users. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Helge Deller (maintainer:FRAMEBUFFER LAYER) --- include/linux/fb.h | 8

[PATCH v3 05/12] drm/tegra: Store pointer to vmap'ed framebuffer in screen_buffer

2023-07-07 Thread Thomas Zimmermann
Tegra uses DMA-able memory, which has to be acessed with CPU ops for system-memory. Store the framebuffer's vmap address in struct fb_info.screen_buffer. The currently used field 'screen_base' is for I/O memory. Suggested-by: Thierry Reding Signed-off-by: Thomas Zimmermann Cc: Thierry Reding

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-07 Thread Thomas Zimmermann
Hi Am 06.07.23 um 18:37 schrieb Jocelyn Falempe: [...] You could out-comment the VGA code in the ast driver for testing. Oh, Thanks for the idea, I will try that. The result is that I get a black screen on the remote BMC. So maybe adding a remote/bmc connector will solve that. Could

Re: [PATCH 0/5] accel/ivpu: Add debugfs support

2023-07-07 Thread Stanislaw Gruszka
On Wed, May 24, 2023 at 09:48:42AM +0200, Stanislaw Gruszka wrote: > Add debugfs support for ivpu driver, most importantly firmware loging > and tracing. Applied to drm-misc-next Regards Stanislaw > > Andrzej Kacprowski (1): > accel/ivpu: Print firmware name and version > > Krystian

Re: [PATCH 02/18] gpu: ipu-v3: pre: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Philipp Zabel
On Fr, 2023-07-07 at 15:20 +0800, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-07 Thread Pekka Paalanen
On Thu, 6 Jul 2023 09:23:46 -0700 Michael Banack wrote: > On 7/6/23 01:01, Pekka Paalanen wrote: > > On Wed, 5 Jul 2023 09:08:07 -0700 > > Michael Banack wrote: > > > >> On 7/4/23 01:08, Pekka Paalanen wrote: > >>> On Mon, 3 Jul 2023 14:06:56 -0700 > >>> Michael Banack wrote: > >>> >

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-07 Thread Neil Armstrong
Hi, On 06/07/2023 11:20, Amit Pundir wrote: On Wed, 5 Jul 2023 at 11:09, Dmitry Baryshkov wrote: [Adding freedreno@ to cc list] On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: Hi Amit, On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: Hi Marek, On Wed, 5 Jul 2023 at 01:48, Marek

[PULL] drm-misc-fixes

2023-07-07 Thread Thomas Zimmermann
Hi Dave and Daniel, I just noticed that there hasn't been a fixes PR for drm-misc for some time. So here's the overdue update. Best regards Thomas drm-misc-fixes-2023-07-07: Short summary of fixes pull: * bridge: * dw_hdmi: Connector fixes * ti-sn65dsi86: Fix possible use-after-free *

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Thu, 6 Jul 2023 20:26:42 +0200 Boris Brezillon wrote: > On Fri, 30 Jun 2023 00:25:18 +0200 > Danilo Krummrich wrote: > > > +#ifdef CONFIG_LOCKDEP > > +typedef struct lockdep_map *lockdep_map_p; > > +#define drm_gpuva_manager_ext_assert_held(mgr) \ > > +

[PATCH 3/4] dummycon: limit Arm console size hack to footbridge

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann The dummycon default console size used to be determined by architecture, but now this is a Kconfig setting on everything except ARM. Tracing this back in the historic git trees, this was used to match the size of VGA console or VGA framebuffer on early machines, but nowadays

[PATCH 4/4] vgacon, arch/*: remove unused screen_info definitions

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann A number of architectures either kept the screen_info definition for historical purposes as it used to be required by the generic VT code, or they copied it from another architecture in order to build the VGA console driver in an allmodconfig build. Now that vgacon no longer

Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-07-07 Thread Christian König
Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven: On 32-bit: ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’: ../tests/amdgpu/amdgpu_stress.c:178:49: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long long

Re: [PATCH 12/18] drm/tegra: dpaux: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Thierry Reding
On Fri, Jul 07, 2023 at 03:20:28PM +0800, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/tegra/dpaux.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c

[PATCH] drm/i915: Fix one wrong caching mode enum usage

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit a4d86249c773 ("drm/i915/gt: Provide a utility to create a scratch buffer") mistakenly passed in uapi I915_CACHING_CACHED as argument to i915_gem_object_set_cache_coherency(), which actually takes internal enum i915_cache_level. No functional issue since the value

[PATCH 1/5] drm/i915: Add ability for tracking buffer objects per client

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold

[PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories.

[PATCH v5 0/5] fdinfo memory stats

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I added tracking of most classes of objects which contribute to client's memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Accounting by keeping per client lists may not be the most

[PATCH 4/5] drm/i915: Account ring buffer and context state storage

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_context.c | 13 + drivers/gpu/drm/i915/i915_drm_client.c | 10 ++

[PATCH 3/5] drm/i915: Track page table backing store usage

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c

[PATCH 2/5] drm/i915: Record which client owns a VM

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ---

[PATCH 1/4] vgacon: rework Kconfig dependencies

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann The list of dependencies here is phrased as an opt-out, but this is missing a lot of architectures that don't actually support VGA consoles, and some of the entries are stale: - powerpc used to support VGA consoles in the old arch/ppc codebase, but the merged

Re: [PATCH 1/3] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Arnd Bergmann
On Fri, Jul 7, 2023, at 11:50, Arnd Bergmann wrote: > From: Arnd Bergmann > > On non-x86 architectures, the screen_info variable is generally only > used for the VGA console where supported, and in some cases the EFI > framebuffer or vga16fb. > This should have been patch 2/4, not 1/3, please

Re: [PATCH libdrm 3/3] modetest: Add support for DRM_FORMAT_NV{24, 42}

2023-07-07 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Wed, Jul 05, 2023 at 05:26:17PM +0200, Geert Uytterhoeven wrote: > Add support for creating buffers using semi-planar YUV formats with > non-subsampled chroma planes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- >

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Danilo Krummrich
On 7/7/23 13:00, Boris Brezillon wrote: On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: +/** + * drm_gpuva_for_each_va_range - iternator to walk over a range of _gpuvas + * @va__: _gpuva structure to assign to in each iteration step + * @mgr__: _gpuva_manager to walk over + *

Re: [PATCH 11/12] dt-bindings: drm/msm/gpu: Extend bindings for chip-id

2023-07-07 Thread Rob Clark
On Fri, Jul 7, 2023 at 12:26 AM Krzysztof Kozlowski wrote: > > On 06/07/2023 23:10, Rob Clark wrote: > > From: Rob Clark > > > > Upcoming GPUs use an opaque chip-id for identifying the GPU. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might

RE: [Intel-gfx] [PATCH] drm/i915: Fix one wrong caching mode enum usage

2023-07-07 Thread Upadhyay, Tejas
> -Original Message- > From: Intel-gfx On Behalf Of > Tvrtko Ursulin > Sent: Friday, July 7, 2023 6:25 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915: Fix one wrong caching mode enum > usage > > From: Tvrtko Ursulin >

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-07 Thread Neil Armstrong
On 07/07/2023 09:18, Neil Armstrong wrote: Hi, On 06/07/2023 11:20, Amit Pundir wrote: On Wed, 5 Jul 2023 at 11:09, Dmitry Baryshkov wrote: [Adding freedreno@ to cc list] On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: Hi Amit, On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: Hi

Re: [PATCH libdrm 2/3] util: Add pattern support for DRM_FORMAT_NV{24,42}

2023-07-07 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Wed, Jul 05, 2023 at 05:26:16PM +0200, Geert Uytterhoeven wrote: > Add support for drawing the SMPTE and tiles patterns in buffers using > semi-planar YUV formats with non-subsampled chroma planes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by:

Re: [PATCH libdrm 1/3] util: Add NV24 and NV42 frame buffer formats

2023-07-07 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Wed, Jul 05, 2023 at 05:26:15PM +0200, Geert Uytterhoeven wrote: > Add the missing entries for semi-planar YUV formats with > non-subsampled chroma planes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > tests/util/format.c

Re: [PATCH 3/4] dummycon: limit Arm console size hack to footbridge

2023-07-07 Thread Linus Walleij
On Fri, Jul 7, 2023 at 11:56 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > The dummycon default console size used to be determined by architecture, > but now this is a Kconfig setting on everything except ARM. Tracing this > back in the historic git trees, this was used to match the size of

Re: [PATCH v3 03/12] drm/tegra: Use fbdev DMA helpers

2023-07-07 Thread Thierry Reding
On Fri, Jul 07, 2023 at 10:31:54AM +0200, Thomas Zimmermann wrote: > Use fbdev's DMA helpers for fbdev emulation. They are equivalent to the > previously used system-memory helpers, so no functional changes here. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas >

Re: [PATCH v3 09/17] drm/imagination: Implement power management

2023-07-07 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote: > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev) > if (err) > goto err_device_clk_fini; > > + /* Explicitly power the GPU so we can access control registers before > the FW is booted. */ > +

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Fri, 7 Jul 2023 14:41:23 +0200 Danilo Krummrich wrote: > >> + va__ && (va__->va.addr < (end__)) && \ > >> + !list_entry_is_head(va__, &(mgr__)->rb.list, rb.entry); \ > >> + va__ = list_next_entry(va__, rb.entry)) > > > > If you define: > > > > static inline struct

Re: [PATCH v3 05/12] drm/tegra: Store pointer to vmap'ed framebuffer in screen_buffer

2023-07-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Tegra uses DMA-able memory, which has to be acessed with CPU ops > for system-memory. Store the framebuffer's vmap address in struct > fb_info.screen_buffer. The currently used field 'screen_base' is > for I/O memory. > > Suggested-by: Thierry Reding > Signed-off-by:

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: > +/** > + * drm_gpuva_for_each_va_range - iternator to walk over a range of > _gpuvas > + * @va__: _gpuva structure to assign to in each iteration step > + * @mgr__: _gpuva_manager to walk over > + * @start__: starting offset, the

[PATCH] [v2] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1344:18: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is

[PATCH 1/3] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann On non-x86 architectures, the screen_info variable is generally only used for the VGA console where supported, and in some cases the EFI framebuffer or vga16fb. Now that we have a definite list of which architectures actually use it for what, use consistent #ifdef checks so

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Danilo Krummrich
On 7/7/23 09:57, Boris Brezillon wrote: On Thu, 6 Jul 2023 20:26:42 +0200 Boris Brezillon wrote: On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: +#ifdef CONFIG_LOCKDEP +typedef struct lockdep_map *lockdep_map_p; +#define drm_gpuva_manager_ext_assert_held(mgr) \ +

[PATCH 2/4] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Arnd Bergmann
From: Arnd Bergmann On non-x86 architectures, the screen_info variable is generally only used for the VGA console where supported, and in some cases the EFI framebuffer or vga16fb. Now that we have a definite list of which architectures actually use it for what, use consistent #ifdef checks so

[PATCH 16/18] drm/rockchip: vop: Use devm_platform_get_and_ioremap_resource()

2023-07-07 Thread Yangtao Li
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yangtao Li --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 03/18] drm/rockchip: dsi: Use devm_platform_get_and_ioremap_resource()

2023-07-07 Thread Yangtao Li
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yangtao Li --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 06/18] drm: bridge: dw_hdmi: Use devm_platform_get_and_ioremap_resource()

2023-07-07 Thread Yangtao Li
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yangtao Li --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/tiny/arcpgu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c index e5b10e41554a..3a5e66d909a4 100644 ---

[PATCH 07/18] drm/bridge: analogix_dp: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

[PATCH 14/18] drm/aspeed: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index

[PATCH 09/18] drm/hisilicon: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

[PATCH 11/18] drm/mxsfb: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 368b1fbd8305..c8b3fdb1ab09

[PATCH 05/18] drm/tegra: hdmi: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/tegra/hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 6eac54ae1205..f3a44ca87151 100644 ---

[PATCH 10/18] drm: lcdif: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index c9d8cbb21407..a7cdd0eec7a2

[PATCH 01/18] drm/renesas: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c

[PATCH 08/18] gpu: ipu-v3: prg: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/ipu-v3/ipu-prg.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c index 196797c1b4b3..729605709955 100644 ---

[PATCH 13/18] drm/stm: ltdc: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/stm/ltdc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index b8be4c1db423..734dca4d7dd8 100644 ---

[PATCH 18/18] drm/fsl-dcu: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index

[PATCH 12/18] drm/tegra: dpaux: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/tegra/dpaux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 4d2677dcd831..f120897ce4b3 100644 ---

[PATCH 02/18] gpu: ipu-v3: pre: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/ipu-v3/ipu-pre.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c index ad82c9e0252f..aef984a43190 100644 ---

[PATCH 04/18] drm: kirin: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c

[PATCH 15/18] drm/tegra: sor: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Yangtao Li
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/gpu/drm/tegra/sor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index abd6e3b92293..f23d54626883 100644 ---

Re: [PATCH] [v2] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

2023-07-07 Thread Christian König
Am 07.07.23 um 13:11 schrieb Arnd Bergmann: From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1344:18: error: result of comparison of constant 4294967296 with expression of type

[PATCH] drm/ttm: never consider pinned BOs for eviction

2023-07-07 Thread Christian König
There is a small window where we have already incremented the pin count but not yet moved the bo from the lru to the pinned list. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH v3 04/12] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-07 Thread Thierry Reding
On Fri, Jul 07, 2023 at 10:31:55AM +0200, Thomas Zimmermann wrote: > Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is > in DMA-able memory and should be accessed with the CPU's regular > memory ops. > > v2: > * drop FBINFO_DEFAULT > > Signed-off-by: Thomas Zimmermann >

Re: [PATCH v3 05/12] drm/tegra: Store pointer to vmap'ed framebuffer in screen_buffer

2023-07-07 Thread Thierry Reding
On Fri, Jul 07, 2023 at 10:31:56AM +0200, Thomas Zimmermann wrote: > Tegra uses DMA-able memory, which has to be acessed with CPU ops > for system-memory. Store the framebuffer's vmap address in struct > fb_info.screen_buffer. The currently used field 'screen_base' is > for I/O memory. > >

Re: [PATCH v3 05/17] drm/imagination: Get GPU resources

2023-07-07 Thread Maxime Ripard
On Tue, Jun 13, 2023 at 03:47:48PM +0100, Sarah Walker wrote: > Acquire clock, regulator and register resources, and enable/map as > appropriate. > > Signed-off-by: Sarah Walker > --- > drivers/gpu/drm/imagination/Makefile | 1 + > drivers/gpu/drm/imagination/pvr_device.c | 271

[PATCH] drm/i915: Remove dead code from gen8_pte_encode

2023-07-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific bit from gen8_pte_encode. Signed-off-by: Tvrtko Ursulin Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")

Re: [PATCH v3 04/17] drm/imagination: Add skeleton PowerVR driver

2023-07-07 Thread Maxime Ripard
Hi, [I just noticed I dropped the Cc list, resending] Thanks for contributing this driver, it's awesome to see it moving forward. And congrats on the documentation too, it's not often we see a driver that well documented on its v3. I've stripped some parts of the patch that weren't relevant to

Re: [PATCH 1/4] vgacon: rework Kconfig dependencies

2023-07-07 Thread Javier Martinez Canillas
Arnd Bergmann writes: Hello Arnd, > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old

Re: [PATCH] drm/ttm: never consider pinned BOs for eviction

2023-07-07 Thread Alex Deucher
On Fri, Jul 7, 2023 at 8:08 AM Christian König wrote: > > There is a small window where we have already incremented the pin count > but not yet moved the bo from the lru to the pinned list. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/ttm/ttm_bo.c | 6

Re: [PATCH 3/4] dummycon: limit Arm console size hack to footbridge

2023-07-07 Thread Arnd Bergmann
On Fri, Jul 7, 2023, at 13:33, Linus Walleij wrote: > On Fri, Jul 7, 2023 at 11:56 AM Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Signed-off-by: Arnd Bergmann > > Tested this before and after patch and it looks the same on the NetWinder. > Tested-by: Linus Walleij Great, thanks for

Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Arnd Bergmann
On Fri, Jul 7, 2023, at 15:40, Javier Martinez Canillas wrote: >> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c >> index 5a55ac82c13a4..0c09ff7fde46b 100644 >> --- a/arch/ia64/kernel/setup.c >> +++ b/arch/ia64/kernel/setup.c >> @@ -86,9 +86,11 @@

Re: [PATCH 3/4] dummycon: limit Arm console size hack to footbridge

2023-07-07 Thread Javier Martinez Canillas
Arnd Bergmann writes: > From: Arnd Bergmann > > The dummycon default console size used to be determined by architecture, > but now this is a Kconfig setting on everything except ARM. Tracing this > back in the historic git trees, this was used to match the size of VGA > console or VGA

Re: [PATCH 13/18] drm/stm: ltdc: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Raphael Gallais-Pou
Hi On 7/7/23 09:20, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/stm/ltdc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Raphaël Gallais-Pou Thanks for your contribution, Raphaël

Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Javier Martinez Canillas
Arnd Bergmann writes: > From: Arnd Bergmann > > On non-x86 architectures, the screen_info variable is generally only > used for the VGA console where supported, and in some cases the EFI > framebuffer or vga16fb. > > Now that we have a definite list of which architectures actually use it > for

Re: [PATCH] drm/panel: Add avdd/avee delay for Starry-himax83102-j02 and Starry-ili9882t panel

2023-07-07 Thread Doug Anderson
Hi, On Thu, Jul 6, 2023 at 6:20 PM cong yang wrote: > > Hi, > > On Fri, Jul 7, 2023 at 3:32 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 3, 2023 at 10:07 PM Cong Yang > > wrote: > > > > > > From power on/off sequence for panel data sheet[1], T2 timing VSP to VSN > > > needs 1ms

Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode

2023-07-07 Thread Rodrigo Vivi
On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") > added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific > bit from gen8_pte_encode. > > Signed-off-by: Tvrtko

Re: [PATCH 1/4] vgacon: rework Kconfig dependencies

2023-07-07 Thread Thomas Zimmermann
Hi, for the whole series: Reviewed-by: Thomas Zimmermann Best regards Thomas Am 07.07.23 um 11:52 schrieb Arnd Bergmann: From: Arnd Bergmann The list of dependencies here is phrased as an opt-out, but this is missing a lot of architectures that don't actually support VGA consoles, and

Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks

2023-07-07 Thread Javier Martinez Canillas
"Arnd Bergmann" writes: > On Fri, Jul 7, 2023, at 15:40, Javier Martinez Canillas wrote: [...] >> And this is only used by mdacon (not supported by ia64), vgacon and >> vga16fb (not supported by ia64 either). >> >> So this could just be guarded just by CONFIG_VGA_CONSOLE for ia64 ? > > Right,

[PATCH v3] drm/virtio: conditionally allocate virtio_gpu_fence

2023-07-07 Thread Gurchetan Singh
We don't want to create a fence for every command submission. It's only necessary when userspace provides a waitable token for submission. This could be: 1) bo_handles, to be used with VIRTGPU_WAIT 2) out_fence_fd, to be used with dma_fence apis 3) a ring_idx provided with

Re: [Freedreno] [PATCH 05/12] drm/msm/adreno: Use quirk to identify cached-coherent support

2023-07-07 Thread Rob Clark
On Thu, Jul 6, 2023 at 7:29 PM Dmitry Baryshkov wrote: > > On 07/07/2023 00:10, Rob Clark wrote: > > From: Rob Clark > > > > It is better to explicitly list it. With the move to opaque chip-id's > > for future devices, we should avoid trying to infer things like > > generation from the

  1   2   3   >