[PATCH RFC v5 06/10] drm/atomic: Move framebuffer checks to helper

2023-07-28 Thread Jessica Zhang
Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed, 73 insertions(+), 57 deletions(-) diff

[PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-07-28 Thread Jessica Zhang
Add support for pixel_source property to drm_plane and related documentation. In addition, force pixel_source to DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break legacy userspace. This enum property will allow user to specify a pixel source for the plane. Possible pixel

[PATCH RFC v5 00/10] Support for Solid Fill Planes

2023-07-28 Thread Jessica Zhang
Some drivers support hardware that have optimizations for solid fill planes. This series aims to expose these capabilities to userspace as some compositors have a solid fill flag (ex. SOLID_COLOR in the Android hardware composer HAL) that can be set by apps like the Android Gears app. In order to

[PATCH RFC v5 08/10] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-07-28 Thread Jessica Zhang
Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 41

[PATCH RFC v5 05/10] drm/atomic: Add solid fill data to plane state dump

2023-07-28 Thread Jessica Zhang
Add solid_fill property data to the atomic plane state dump. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_plane.c | 10 ++ include/drm/drm_plane.h | 3 +++ 3 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c

[PATCH RFC v5 04/10] drm/atomic: Add pixel source to plane state dump

2023-07-28 Thread Jessica Zhang
Add pixel source to the atomic plane state dump Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c| 1 + drivers/gpu/drm/drm_crtc_internal.h | 2 ++ drivers/gpu/drm/drm_plane.c | 12 3 files changed, 15 insertions(+) diff --git

[PATCH RFC v5 09/10] drm/msm/dpu: Use DRM solid_fill property

2023-07-28 Thread Jessica Zhang
Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_plane_color_fill_pipe() to allow userspace

[PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-07-28 Thread Jessica Zhang
Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing the following information: struct

[PATCH RFC v5 10/10] drm/msm/dpu: Add solid fill and pixel source properties

2023-07-28 Thread Jessica Zhang
Add solid_fill and pixel_source properties to DPU plane Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH RFC v5 07/10] drm/atomic: Loosen FB atomic checks

2023-07-28 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when non-FB pixel sources are enabled. To disable a plane, the pixel_source

Re: [PATCH] drm/tests: Alloc drm_device on drm_exec tests

2023-07-28 Thread Arthur Grillo Queiroz Cabral
On 28/07/23 11:33, Maxime Ripard wrote: > Hi, > > On Thu, Jul 27, 2023 at 04:22:59PM -0300, Arthur Grillo wrote: >> The drm_exec tests where crashing[0] because of a null dereference. This >> is caused by a new access of the `driver` attribute of `struct >> drm_driver` on

Re: [PATCH v2] drm/panel: Enable DSC and CMD mode for Visionox VTDR6130 panel

2023-07-28 Thread Jessica Zhang
On 7/28/2023 2:37 AM, Dmitry Baryshkov wrote: On Fri, 28 Jul 2023 at 04:26, Paloma Arellano wrote: Enable display compression (DSC v1.2) and CMD mode for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. In addition, this patch will set the default to command mode with DSC enabled. Note: This

Re: [PATCH 1/7] drm/msm/dpu: enable PINGPONG TE operations only when supported by HW

2023-07-28 Thread Dmitry Baryshkov
On 27/07/2023 23:03, Marijn Suijten wrote: On 2023-07-27 19:20:58, Dmitry Baryshkov wrote: The DPU_PINGPONG_TE bit is set for all PINGPONG blocks on DPU < 5.0. Rather than checking for the flag, check for the presense of the corresponding interrupt line. Signed-off-by: Dmitry Baryshkov

Re: [PATCH v2 5/7] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Abhinav Kumar
On 7/28/2023 2:39 PM, Dmitry Baryshkov wrote: On 29/07/2023 00:36, Abhinav Kumar wrote: On 7/28/2023 2:33 PM, Dmitry Baryshkov wrote: Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. As a side-effect, this also swithes the DPU driver from

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-07-28 Thread Gurchetan Singh
On Wed, Jul 19, 2023 at 11:58 AM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > 27.06.2023 20:16, Rob Clark пишет: > ... > >> Now these are just suggestions, and while I think they are good, you > can safely ignore them. > >> > >> But there's also the DRM requirements, which state

[PATCH v3 6/6] drm/msm/dpu: shift IRQ indices by 1

2023-07-28 Thread Dmitry Baryshkov
In order to simplify IRQ declarations, shift IRQ indices by 1. This makes 0 the 'no IRQ' value. Thanks to this change, we do no longer have to explicitly set the 'no interrupt' fields in catalog structures. Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 4

[PATCH v3 3/6] drm/msm/dpu: add helper to get IRQ-related data

2023-07-28 Thread Dmitry Baryshkov
In preparation to reworking the IRQ indices, move irq_tbl access to separate helper. Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 48 +-- .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 12 +++-- 2 files

[PATCH v3 4/6] drm/msm/dpu: make the irq table size static

2023-07-28 Thread Dmitry Baryshkov
The size of the irq table is static, it has MDP_INTR_MAX * 32 interrupt entries. Provide the fixed length and drop struct_size() statement. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 13 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h

[PATCH v3 0/6] drm/msm/dpu: change interrupts code to make 0 be the no IRQ

2023-07-28 Thread Dmitry Baryshkov
Having an explicit init of interrupt fields to -1 for not existing IRQs makes it easier to forget and/or miss such initialisation, resulting in a wrong interrupt definition. Instead shift all IRQ indices to turn '0' to be the non-existing IRQ. Dependencies: [1] [1]

[PATCH v3 1/6] drm/msm/dpu: remove irq_idx argument from IRQ callbacks

2023-07-28 Thread Dmitry Baryshkov
There is no point in passing the IRQ index to IRQ callbacks, no function uses that. Drop it at last. Reviewed-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--

[PATCH RFC v5 03/10] drm: Add solid fill pixel source

2023-07-28 Thread Jessica Zhang
Add "SOLID_FILL" as a valid pixel source. If the pixel_source property is set to "SOLID_FILL", it will display data from the drm_plane "solid_fill" blob property. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_blend.c | 10 +- include/drm/drm_plane.h | 1 + 2 files changed,

Re: [git pull] drm fixes for 6.5-rc4

2023-07-28 Thread Linus Torvalds
On Thu, 27 Jul 2023 at 19:20, Dave Airlie wrote: > > Regular scheduled fixes, msm and amdgpu leading the way, with some > i915 and a single misc fbdev, all seems fine. Pulled. Tangentially related: where do you keep your pgp key? The one I have is long expired, and doing a refresh doesn't get

[PATCH 06/47] fbdev/carminefb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 09/47] fbdev/efifb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 07/47] fbdev/chipsfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 38/47] fbdev/sh7760fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 12/47] fbdev/g364fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 16/47] fbdev/goldfishfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 32/47] fbdev/pmag-ba-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 36/47] fbdev/q40fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 45/47] fbdev/vesafb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 47/47] vfio-dev/mdpy-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 03/47] fbdev/asiliantfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 21/47] fbdev/kyro: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 44/47] fbdev/valkyriefb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 22/47] fbdev/macfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 23/47] fbdev/maxinefb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH v2] drm/tests: Alloc drm_device on drm_exec tests

2023-07-28 Thread Arthur Grillo
The drm_exec tests where crashing[0] because of a null dereference. This is caused by a new access of the `driver` attribute of `struct drm_driver` on drm_gem_private_object_init(). Alloc the drm_device to fix that. [0] [15:05:24] == drm_exec (6 subtests) ===

Re: [PATCH 5/6] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Dmitry Baryshkov
On Fri, 28 Jul 2023 at 22:25, Abhinav Kumar wrote: > > > > On 7/27/2023 8:26 AM, Dmitry Baryshkov wrote: > > On 27/07/2023 18:24, Abhinav Kumar wrote: > >> > >> > >> On 7/27/2023 1:39 AM, Dmitry Baryshkov wrote: > >>> On Thu, 27 Jul 2023 at 02:20, Abhinav Kumar > >>> wrote: > > >

Re: [PATCH 3/7] drm/msm/dpu: inline _setup_intf_ops()

2023-07-28 Thread Dmitry Baryshkov
On 27/07/2023 23:10, Marijn Suijten wrote: On 2023-07-27 19:21:00, Dmitry Baryshkov wrote: Inline the _setup_intf_ops() function, it makes it easier to handle different conditions involving INTF configuration. Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten ---

Re: [PATCH 1/7] drm/msm/dpu: enable PINGPONG TE operations only when supported by HW

2023-07-28 Thread Dmitry Baryshkov
On 27/07/2023 23:05, Marijn Suijten wrote: On 2023-07-27 19:20:58, Dmitry Baryshkov wrote: The DPU_PINGPONG_TE bit is set for all PINGPONG blocks on DPU < 5.0. Rather than checking for the flag, check for the presense of the corresponding interrupt line. Signed-off-by: Dmitry Baryshkov ---

[PATCH 34/47] fbdev/pxa168fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 00/47] fbdev: Use I/O helpers

2023-07-28 Thread Thomas Zimmermann
Most fbdev drivers operate on I/O memory. And most of those use the default implementations for file I/O and console drawing. Convert all these low-hanging fruits to the fb_ops initializer macro and Kconfig token for fbdev I/O helpers. The fbdev I/O helpers are easily grep-able. In a later patch,

[PATCH 14/47] fbdev/geode/gxfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 42/47] fbdev/sunxvr2500: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 31/47] fbdev/pmag-aa-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 08/47] fbdev/da8xx-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 25/47] fbdev/mmpfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 28/47] fbdev/offb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 29/47] fbdev/omapfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 24/47] fbdev/mb862xxfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 10/47] fbdev/fm2fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[pull] amdgpu, amdkfd, radeon drm-next-6.6

2023-07-28 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.6. The following changes since commit 6725f33228077902ddac2a05e0ab361dee36e4ba: Merge tag 'drm-misc-next-fixes-2023-07-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2023-07-07 11:05:16 +1000) are available in the Git repository at:

Re: [PATCH v2] drm: fix indirect goto into statement expression UB

2023-07-28 Thread Nathan Chancellor
+ people from trailers of 09593216bff1 On Thu, Jul 27, 2023 at 03:50:58PM -0700, ndesaulni...@google.com wrote: > A new diagnostic in clang-17 now produces the following build error: > > drivers/gpu/drm/tests/drm_exec_test.c:41:3: error: cannot jump from this > indirect goto statement to one of

Re: [PATCH 00/47] fbdev: Use I/O helpers

2023-07-28 Thread Helge Deller
On 7/28/23 18:39, Thomas Zimmermann wrote: Most fbdev drivers operate on I/O memory. Just nitpicking here: What is I/O memory? Isn't it either memory, or I/O ? I mean, I would never think of the cfb* draw functions under I/O. And most of those use the default implementations for file I/O and

Re: [PATCH 00/47] fbdev: Use I/O helpers

2023-07-28 Thread Sam Ravnborg
Hi Helge, On Fri, Jul 28, 2023 at 08:46:59PM +0200, Helge Deller wrote: > On 7/28/23 18:39, Thomas Zimmermann wrote: > > Most fbdev drivers operate on I/O memory. > > Just nitpicking here: > What is I/O memory? > Isn't it either memory, or I/O ? > I mean, I would never think of the cfb* draw

[PATCH v2 3/7] drm/msm/mdss: export UBWC data

2023-07-28 Thread Dmitry Baryshkov
DPU programming requires knowledge of some of UBWC parameters. This results in duplication of UBWC data between MDSS and DPU drivers. Export the required data from MDSS driver. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 30

[PATCH v2 7/7] drm/msm/dpu: drop BWC features from DPU_MDP_foo namespace

2023-07-28 Thread Dmitry Baryshkov
The feature bits DPU_MDP_BWC, DPU_MDP_UBWC_1_0, and DPU_MDP_UBWC_1_5 are not used by the driver, drop them completely as a followup cleanup. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH RFC v5 04/10] drm/atomic: Add pixel source to plane state dump

2023-07-28 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Add pixel source to the atomic plane state dump Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c| 1 + drivers/gpu/drm/drm_crtc_internal.h | 2 ++ drivers/gpu/drm/drm_plane.c | 12 3 files changed, 15

Re: [git pull] drm fixes for 6.5-rc4

2023-07-28 Thread pr-tracker-bot
The pull request you sent on Fri, 28 Jul 2023 12:20:10 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17bf3df9af08c5e87c07a92b811b7f9f8034a32c Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v2 5/7] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Dmitry Baryshkov
On 29/07/2023 00:36, Abhinav Kumar wrote: On 7/28/2023 2:33 PM, Dmitry Baryshkov wrote: Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. As a side-effect, this also swithes the DPU driver from DPU_HW_UBWC_VER_xx values to the UBWC_x_y enum, which

Re: [PATCH v2] drm/panel: Enable DSC and CMD mode for Visionox VTDR6130 panel

2023-07-28 Thread Dmitry Baryshkov
On 29/07/2023 00:44, Jessica Zhang wrote: On 7/28/2023 2:37 AM, Dmitry Baryshkov wrote: On Fri, 28 Jul 2023 at 04:26, Paloma Arellano wrote: Enable display compression (DSC v1.2) and CMD mode for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. In addition, this patch will set the default

[PATCH v3 2/6] drm/msm/dpu: extract dpu_core_irq_is_valid() helper

2023-07-28 Thread Dmitry Baryshkov
In preparation to reworking the IRQ indices, move irq_idx validation to the separate helper. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH v3 5/6] drm/msm/dpu: stop using raw IRQ indices in the kernel output

2023-07-28 Thread Dmitry Baryshkov
In preparation to reworking IRQ indcies, stop using raw indices in kernel output (both printk and debugfs). Instead use a pair of register index and bit. This corresponds closer to the values in HW catalog. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 49

[PATCH 30/47] fbdev/platinumfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 17/47] fbdev/grvga: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 43/47] fbdev/uvesafb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 37/47] fbdev/s3cfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 19/47] fbdev/i740fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 33/47] fbdev/pmag-b-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 02/47] fbdev/acornfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 39/47] fbdev/simplefb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 01/47] media/vivid: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 18/47] fbdev/gxt4500: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 15/47] fbdev/geode/lxfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 35/47] fbdev/pxafb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 27/47] fbdev/ocfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 26/47] fbdev/mx3fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 05/47] fbdev/aty128fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 13/47] fbdev/geode/gx1fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 04/47] fbdev/atmel_lcdfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

Re: [PATCH 00/47] fbdev: Use I/O helpers

2023-07-28 Thread Sam Ravnborg
Hi Thomas, On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote: > Most fbdev drivers operate on I/O memory. And most of those use the > default implementations for file I/O and console drawing. Convert all > these low-hanging fruits to the fb_ops initializer macro and Kconfig >

Re: [PATCH v6 2/3] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2023-07-28 Thread Janne Grunau
On 2023-07-09 23:25:10 +0300, Dmitry Baryshkov wrote: > In some cases the bridge drivers would like to receive hotplug events > even in the case new status is equal to the old status. In the DP case > this is used to deliver "attention" messages to the DP host. Stop > filtering the events in the

Re: [PATCH 00/47] fbdev: Use I/O helpers

2023-07-28 Thread Sam Ravnborg
Hi Thomas, On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote: > Most fbdev drivers operate on I/O memory. And most of those use the > default implementations for file I/O and console drawing. Convert all > these low-hanging fruits to the fb_ops initializer macro and Kconfig >

Re: [PATCH v2 5/7] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Abhinav Kumar
On 7/28/2023 2:33 PM, Dmitry Baryshkov wrote: Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. As a side-effect, this also swithes the DPU driver from DPU_HW_UBWC_VER_xx values to the UBWC_x_y enum, which reflects the hardware register values.

Re: [PATCH v4 00/11] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-07-28 Thread Doug Anderson
Hi, On Fri, Jul 28, 2023 at 8:31 AM Benjamin Tissoires wrote: > > On Jul 27 2023, Douglas Anderson wrote: > > > > The big motivation for this patch series is mostly described in the patch > > ("drm/panel: Add a way for other devices to follow panel state"), but to > > quickly summarize here: for

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-07-28 Thread Dmitry Baryshkov
On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. In addition, force pixel_source to > DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break > legacy userspace. > > This enum property will allow

Re: [PATCH RFC v5 05/10] drm/atomic: Add solid fill data to plane state dump

2023-07-28 Thread Dmitry Baryshkov
On 28/07/2023 20:02, Jessica Zhang wrote: Add solid_fill property data to the atomic plane state dump. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_plane.c | 10 ++ include/drm/drm_plane.h | 3 +++ 3 files changed, 17

[PATCH 20/47] fbdev/imxfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 41/47] fbdev/sunxvr1000: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 11/47] fbdev/fsl-diu-fb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 40/47] fbdev/sstfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

[PATCH 46/47] fbdev/xilinxfb: Use fbdev I/O helpers

2023-07-28 Thread Thomas Zimmermann
Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change.

Re: [PATCH 5/6] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Abhinav Kumar
On 7/27/2023 8:26 AM, Dmitry Baryshkov wrote: On 27/07/2023 18:24, Abhinav Kumar wrote: On 7/27/2023 1:39 AM, Dmitry Baryshkov wrote: On Thu, 27 Jul 2023 at 02:20, Abhinav Kumar wrote: On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: Switch to using data from MDSS driver to program the

[PATCH v2 4/7] drm/msm/mdss: populate missing data

2023-07-28 Thread Dmitry Baryshkov
As we are going to use MDSS data for DPU programming, populate missing MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS programming, so skip them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 21 +++-- 1 file changed, 19 insertions(+), 2

[PATCH v2 6/7] drm/msm/dpu: drop UBWC configuration

2023-07-28 Thread Dmitry Baryshkov
As the DPU driver has switched to fetching data from MDSS driver, we can now drop the UBWC and highest_bank_bit parts of the DPU hw catalog. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 6 -

[PATCH v2 5/7] drm/msm/dpu: use MDSS data for programming SSPP

2023-07-28 Thread Dmitry Baryshkov
Switch to using data from MDSS driver to program the SSPP fetch and UBWC configuration. As a side-effect, this also swithes the DPU driver from DPU_HW_UBWC_VER_xx values to the UBWC_x_y enum, which reflects the hardware register values. Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 1/7] drm/msm/mdss: correct UBWC programming for SM8550

2023-07-28 Thread Dmitry Baryshkov
The SM8550 platform employs newer UBWC decoder, which requires slightly different programming. Fixes: a2f33995c19d ("drm/msm: mdss: add support for SM8550") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 19 +-- 1 file changed, 17 insertions(+), 2

[PATCH v2 2/7] drm/msm/mdss: rename ubwc_version to ubwc_enc_version

2023-07-28 Thread Dmitry Baryshkov
Rename the ubwc_version field to ubwc_enc_version, it denotes the version of the UBWC encoder, not the "UBWC version". Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 30 +++--- 1 file changed, 15 insertions(+), 15

[PATCH v2 0/7] drm/msm/dpu: use UBWC data from MDSS driver

2023-07-28 Thread Dmitry Baryshkov
Both DPU and MDSS programming requires knowledge of some of UBWC parameters. This results in duplication of UBWC data between MDSS and DPU drivers. To remove such duplication and make the driver more error-prone, export respective configuration from the MDSS driver and make DPU use it, instead of

  1   2   3   >