Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:41, Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07

Re: [PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Ville Syrjälä
On Fri, Feb 16, 2024 at 04:09:55PM +0100, Pierre-Eric Pelloux-Prayer wrote: > With this and the dma_fence_used_as_dependency event, a tool can draw the > relationship between the compositing draw, the atomic commit, and vblank. > > An example on a 2 monitors system look like this: > >

Re: [PATCH] char/agp: remove agp_bridge_data::type

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 12:15:11PM +0100, Jiri Slaby (SUSE) wrote: > agp_bridge_data::type is unused (and I cannot find when was used last). > > Therefore, remove it. > > Found by https://github.com/jirislaby/clang-struct. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: David Airlie > Cc:

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Daniel Vetter
On Fri, Feb 16, 2024 at 05:51:59PM +0100, Christian König wrote: > Am 16.02.24 um 17:32 schrieb Daniel Vetter: > > On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: > > > This new event can be used to trace where a given dma_fence is added > > > as a dependency of some

[PATCH 1/3] drm/sun4i: Unify sun8i_*_layer structs

2024-02-16 Thread Ondřej Jirman
From: Ondrej Jirman These structs are identical, use a single struct to represent private data for the DRM plane. This is a preparation for configuring layer routing from the CRTC (mixer) instead of current approach of setting up routing from individual layer's atomic_update callback.

[PATCH 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

2024-02-16 Thread Ondřej Jirman
From: Ondrej Jirman This series refactors blender setup from individual planes to a common place where it can be performed at once and is easier to reason about. In the process this fixes a few bugs that allowed blender pipes to be disabled while corresponding DRM planes were requested to be

[PATCH 3/3] drm/sun4i: Fix layer zpos change/atomic modesetting

2024-02-16 Thread Ondřej Jirman
From: Ondrej Jirman Identical configurations of planes can lead to different (and wrong) layer -> pipe routing at HW level, depending on the order of atomic plane changes. For example: - Layer 1 is configured to zpos 0 and thus uses pipe 0. No other layer is enabled. This is a typical

[PATCH 2/3] drm/sun4i: Add more parameters to sunxi_engine commit callback

2024-02-16 Thread Ondřej Jirman
From: Ondrej Jirman These will be needed later on when we move layer configuration to crtc update. Signed-off-by: Ondrej Jirman --- drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +++- drivers/gpu/drm/sun4i/sun4i_crtc.c| 2 +- drivers/gpu/drm/sun4i/sun8i_mixer.c | 5 -

Re: [PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2024 16:09:55 +0100 Pierre-Eric Pelloux-Prayer wrote: > > Signed-off-by: Pierre-Eric Pelloux-Prayer > --- > drivers/gpu/drm/drm_atomic_uapi.c | 21 + > drivers/gpu/drm/drm_trace.h | 23 +++ > 2 files changed, 44 insertions(+) > >

Re: [PATCH 5/8] accel/ivpu: Use lazy allocation for doorbell IDs

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Reserve/allocate and free doorbells for command queues when needed using xarray. This allows to avoid reserving a doorbell for a contexts that never issues a job. Signed-off-by: Wachowski, Karol Missing your SOB.

Re: [PATCH 8/8] accel/ivpu: Rename VPU to NPU in message strings

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: VPU was renamed to NPU but due to large overhead of renaming all the sources only user visible messages are being updated. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

2024-02-16 Thread Alex Deucher
Applied. Thanks. Alex On Fri, Feb 16, 2024 at 5:38 AM Ilpo Järvinen wrote: > > On Thu, 15 Feb 2024, Deucher, Alexander wrote: > > > [Public] > > > > > -Original Message- > > > From: Ilpo Järvinen > > > Sent: Thursday, February 15, 2024 8:32 AM > > > To: Deucher, Alexander ; amd- > > >

Re: [PATCH v5 10/13] drm/mediatek: Support CRC in display driver

2024-02-16 Thread Daniel Vetter
On Thu, Feb 15, 2024 at 06:11:16PM +0800, Hsiao Chien Sung wrote: > Register CRC related function pointers to support > CRC retrieval. > > Signed-off-by: Hsiao Chien Sung > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 239 > drivers/gpu/drm/mediatek/mtk_drm_crtc.h

Re: [git pull] drm fixes for 6.8-rc5

2024-02-16 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Feb 2024 17:20:39 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-16 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ca6a62f9fe23713ea2b58a256a1ab27b9cc5a05a Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v3 2/4] dt-bindings: display/msm: Document MDSS on X1E80100

2024-02-16 Thread Rob Herring
labs.org/project/devicetree-bindings/patch/20240216-x1e80100-display-v3-2-28b1c33ac...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make s

[PATCH 3/3] drm/vc4: vec: Add the margin properties to the connector

2024-02-16 Thread Dave Stevenson
All the handling for the properties was present, but they were never attached to the connector to allow userspace to change them. Add them to the connector. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_vec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 0/3] vc4 VEC (analogue video) updates - margins and monochrome

2024-02-16 Thread Dave Stevenson
Hi All A couple of patches to vc4, including adding a new "TV mode" enum for monochrome output (yes we have some users who wish for monochrome). Adding mono has raised a query here as to whether the the TV_MODE is meant to describe the timing, or just the colour encoding. The description for

[PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-16 Thread Dave Stevenson
From: Nick Hollinghurst Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal). Change default mode creation to acommodate the new tv_mode

[PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

2024-02-16 Thread Dave Stevenson
The VEC supports not producing colour bursts for monochrome output. It also has an option for disabling the chroma input to remove chroma from the signal. Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb this in. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_vec.c |

[PATCH] drm/panel: boe-tv101wum-nl6: make use of prepare_prev_first

2024-02-16 Thread Douglas Anderson
The panel on sc7180-trogdor-wormdingler and sc7180-trogdor-quackingstick hasn't been coming up since commit 9e15123eca79 ("drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset"). Let's add "prepare_prev_first" as has been done for many other DSI panels. Fixes: 9e15123eca79

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 11:11, Harry Wentland wrote: > > > On 2024-02-16 10:42, Pekka Paalanen wrote: >> On Fri, 16 Feb 2024 09:33:47 -0500 >> Harry Wentland wrote: >> >>> On 2024-02-16 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: > We want

Re: [PATCH 1/8] accel/ivpu: Rename TILE_SKU_BOTH_MTL to TILE_SKU_BOTH

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:12 AM, Jacek Lawrynowicz wrote: Remove legacy postfix from TILE_SKU_BOTH macro. This was missed when renaming MTL to VPU37XX. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 11:20:17AM -0500, Steven Rostedt wrote: > On Tue, 13 Feb 2024 16:50:31 +0100 > Pierre-Eric Pelloux-Prayer wrote: > > > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > > drm_mode_object_put(obj); > > } > > > > + if

Re: [PATCH 7/8] accel/ivpu: Refactor BO creation functions

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Rename BO allocate/create functions, so the code is more consistent. There are now two matching buffer creation functions: - ivpu_bo_create_ioctl() - create a BO from user space - ivpu_bo_create() - create a BO from

Re: [PATCH v5 10/13] drm/mediatek: Support CRC in display driver

2024-02-16 Thread Daniel Vetter
On Fri, Feb 16, 2024 at 06:04:43PM +0100, Daniel Vetter wrote: > On Thu, Feb 15, 2024 at 06:11:16PM +0800, Hsiao Chien Sung wrote: > > Register CRC related function pointers to support > > CRC retrieval. > > > > Signed-off-by: Hsiao Chien Sung > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Alex Deucher
On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: > > Am 16.02.24 um 16:12 schrieb Mario Limonciello: > > On 2/16/2024 09:05, Harry Wentland wrote: > >> > >> > >> On 2024-02-16 09:47, Christian König wrote: > >>> Am 16.02.24 um 15:42 schrieb Mario Limonciello: > On 2/16/2024 08:38,

Re: [PATCH v3 3/8] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful

Re: [PATCH 3/8] accel/ivpu: Update FW API headers

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: Update Boot API to 3.22.0 and JSM API to 3.15.6 Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 06:39:20PM +0100, Danilo Krummrich wrote: > On 2/9/24 19:52, Daniel Vetter wrote: > > On Fri, Feb 09, 2024 at 06:41:32PM +0100, Danilo Krummrich wrote: > > > On 2/6/24 15:03, Daniel Vetter wrote: > > > > On Mon, Feb 05, 2024 at 11:00:04PM +0100, Danilo Krummrich wrote: > >

RE: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

2024-02-16 Thread Sagar, Vishal
[AMD Official Use Only - General] Hi Rohit, Thanks for the patch. > -Original Message- > From: dri-devel On Behalf Of > Rohit Visavalia > Sent: Friday, February 16, 2024 1:41 PM > To: gre...@linuxfoundation.org; laurent.pinch...@ideasonboard.com; > maarten.lankho...@linux.intel.com;

Re: [PATCH 17/27] sparc32: Drop run-time patching of ASI instructions

2024-02-16 Thread Andreas Larsson
On 2023-12-19 23:03, Sam Ravnborg via B4 Relay wrote: > From: Sam Ravnborg > > With only LEON supported there is no need to run-time patch > the instructions to match ASI. > > Move a few functions back to C with inline asm, now that > run-time patching is not needed. > > Deleted a few

Re: [PATCH] nouveau: fix function cast warnings

2024-02-16 Thread Danilo Krummrich
On 2/13/24 10:57, Arnd Bergmann wrote: From: Arnd Bergmann clang-16 warns about casting between incompatible function types: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c:161:10: error: cast from 'void (*)(const struct firmware *)' to 'void (*)(void *)' converts to incompatible function

Re: [PATCH] drm/nouveau/mmu/r535: uninitialized variable in r535_bar_new_()

2024-02-16 Thread Danilo Krummrich
On 2/13/24 19:09, Dan Carpenter wrote: If gf100_bar_new_() fails then "bar" is not initialized. Fixes: 5bf0257136a2 ("drm/nouveau/mmu/r535: initial support") Signed-off-by: Dan Carpenter Applied to drm-misc-fixes, thanks! --- It looks like this was intended to handle a failure from the

Re: [PATCH 6/8] accel/ivpu: Fix ivpu_reset_engine_fn merge issue

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: ivpu_reset_engine_fn and ivpu_reset_engine_fops were separated during merge so move them back together to keep the file consistent. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 0/1] Always record job cycle and timestamp information

2024-02-16 Thread Daniel Vetter
On Wed, Feb 14, 2024 at 01:52:05PM +, Steven Price wrote: > Hi Adrián, > > On 14/02/2024 12:14, Adrián Larumbe wrote: > > A driver user expressed interest in being able to access engine usage stats > > through fdinfo when debugfs is not built into their kernel. In the current > >

[PATCH v3 2/4] dt-bindings: display/msm: Document MDSS on X1E80100

2024-02-16 Thread Abel Vesa
Document the MDSS hardware found on the Qualcomm X1E80100 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Abel Vesa --- .../bindings/display/msm/qcom,x1e80100-mdss.yaml | 253 + 1 file changed, 253 insertions(+) diff --git

[PATCH v3 1/4] dt-bindings: display/msm: Document the DPU for X1E80100

2024-02-16 Thread Abel Vesa
Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as they are similar. Signed-off-by: Abel Vesa --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v3 3/4] drm/msm: mdss: Add X1E80100 support

2024-02-16 Thread Abel Vesa
Add support for MDSS on X1E80100. Reviewed-by: Dmitry Baryshkov Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/msm_mdss.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 35423d10aafa..6eda501e2a1a 100644

[PATCH v3 4/4] drm/msm/dpu: Add X1E80100 support

2024-02-16 Thread Abel Vesa
Add definitions for the display hardware used on the Qualcomm X1E80100 platform. Co-developed-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Abel Vesa --- .../drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 449 +

[PATCH v3 0/4] drm/msm: Add display support for X1E80100

2024-02-16 Thread Abel Vesa
This patchset adds support for display for X1E80100. The support for embedded DisplayPort on this platform will not be enabled using the connetor type from driver match data, but through some 'is-edp' property via DT. This subsequent work will be part of a separate patchset. Signed-off-by: Abel

Re: [PATCH 0/1] Always record job cycle and timestamp information

2024-02-16 Thread Tvrtko Ursulin
On 16/02/2024 16:57, Daniel Vetter wrote: On Wed, Feb 14, 2024 at 01:52:05PM +, Steven Price wrote: Hi Adrián, On 14/02/2024 12:14, Adrián Larumbe wrote: A driver user expressed interest in being able to access engine usage stats through fdinfo when debugfs is not built into their

[PATCH] drm/tests/drm_buddy: avoid 64-bit calculation

2024-02-16 Thread Arnd Bergmann
From: Arnd Bergmann The newly added drm_test_buddy_alloc_contiguous() test fails to link on 32-bit targets because of inadvertent 64-bit calculations: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! ERROR: modpost: "__aeabi_ldivmod"

[PATCH] drm/ci: skip suspend tests for both msm-sc7180 machines

2024-02-16 Thread Dmitry Baryshkov
The commit ea489a3d983b ("drm/ci: add sc7180-trogdor-kingoftown") dropped the msm-sc7180-skips.txt file, which disabled suspend-to-RAM tests. However testing shows that STR tests still can fail. Restore the skiplist, applying it to both limozeen and kingoftown machines. Fixes: ea489a3d983b

[PATCH] drm/amd: Drop abm_level property

2024-02-16 Thread Mario Limonciello
This vendor specific property has never been used by userspace software and conflicts with the panel_power_savings sysfs file. That is a compositor and user could fight over the same data. Fixes: f97e4303da16 ("drm/amd/display: add panel_power_savings sysfs entry to eDP connectors")

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Mario Limonciello
On 2/16/2024 10:13, Harry Wentland wrote: On 2024-02-16 11:11, Harry Wentland wrote: On 2024-02-16 10:42, Pekka Paalanen wrote: On Fri, 16 Feb 2024 09:33:47 -0500 Harry Wentland wrote: On 2024-02-16 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote:

Re: [PATCH 4/8] accel/ivpu: Add support for FW boot param system_time_us

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:13 AM, Jacek Lawrynowicz wrote: From: Krystian Pradzynski Add support for FW boot API param system_time_us. According to the API description this field should be set to system time in microseconds starting from 1970. Signed-off-by: Krystian Pradzynski Missing your SOB.

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: > This new event can be used to trace where a given dma_fence is added > as a dependency of some other work. How? What I'd expected here is that you add a dependency chain from one fence to another, but this only has one

Re: [PATCH] drm/amd/display: Fix memory leak in dm_sw_fini()

2024-02-16 Thread Alex Deucher
Applied. Thanks! On Mon, Feb 12, 2024 at 8:08 PM Armin Wolf wrote: > > After destroying dmub_srv, the memory associated with it is > not freed, causing a memory leak: > > unreferenced object 0x896302b45800 (size 1024): > comm "(udev-worker)", pid 222, jiffies 4294894636 > hex dump

Re: [PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Steven Rostedt
On Fri, 16 Feb 2024 17:37:23 +0100 Daniel Vetter wrote: > > > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > > > drm_mode_object_put(obj); > > > } > > > > > > + if (trace_drm_mode_atomic_commit_enabled()) { > > > + struct drm_crtc_state

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 10:42, Pekka Paalanen wrote: > On Fri, 16 Feb 2024 09:33:47 -0500 > Harry Wentland wrote: > >> On 2024-02-16 03:19, Pekka Paalanen wrote: >>> On Fri, 2 Feb 2024 10:28:35 -0500 >>> Hamza Mahfooz wrote: >>> We want programs besides the compositor to be able to enable or

Re: [PATCH v2 0/6] dma-fence, drm, amdgpu new trace events

2024-02-16 Thread Daniel Vetter
On Tue, Feb 13, 2024 at 04:50:25PM +0100, Pierre-Eric Pelloux-Prayer wrote: > This series adds new events to make it easier for tools > like gpuvis or umr to graph the GPUs, kernel and applications > activity. > > UMR patches using these events can be found here: >

Re: [PATCH 2/8] accel/ivpu: Remove legacy firmware name

2024-02-16 Thread Jeffrey Hugo
On 2/14/2024 1:12 AM, Jacek Lawrynowicz wrote: We are now using NPU IP generation based FW names instead of platform code names, so mtl_vpu.bin can be removed. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-16 Thread Daniel Vetter
On Mon, Feb 12, 2024 at 01:27:57PM +0200, Jani Nikula wrote: > On Sat, 10 Feb 2024, Mario Limonciello wrote: > > On 2/9/2024 12:57, Daniel Vetter wrote: > >> On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote: > >>> On 2/9/2024 05:07, Daniel Vetter wrote: > On Thu, Feb 08,

Re: [PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-16 Thread Christian König
Am 16.02.24 um 17:32 schrieb Daniel Vetter: On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote: This new event can be used to trace where a given dma_fence is added as a dependency of some other work. How? What I'd expected here is that you add a dependency chain from

[PATCH v3] drm/i915/guc: Simplify/extend platform check for Wa_14018913170

2024-02-16 Thread John . C . Harrison
From: John Harrison The above w/a is required for every platform that the i915 driver supports. It is fixed on the latest platforms but they are only supported by Xe instead of i915. So just remove the platform check completely and keep the code simple. Signed-off-by: John Harrison ---

Re: [PULL] drm-intel-gt-next

2024-02-16 Thread Thomas Hellström
On Fri, 2024-02-16 at 10:31 +0100, Thomas Hellström wrote: > Hi, Dave > > On Fri, 2024-02-16 at 12:58 +1000, Dave Airlie wrote: > > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > First pull request for 6.9 with probably one more coming in one >

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-16 Thread Daniel Stone
Hi, On Fri, 16 Feb 2024 at 09:00, Tomi Valkeinen wrote: > On 13/02/2024 13:39, Daniel Stone wrote: > > Specifically, you probably want commits 4cde507be6a1 and 58dde0e0c000. > > I think the window of breakage was small enough that - assuming either > > those commits or an upgrade to Weston 12/13

Re: [PATCH 0/4] TTM unlockable restartable LRU list iteration

2024-02-16 Thread Thomas Hellström
On Fri, 2024-02-16 at 15:00 +0100, Christian König wrote: > Am 16.02.24 um 14:13 schrieb Thomas Hellström: > > This patch-set is a prerequisite for a standalone TTM shrinker > > and for exhaustive TTM eviction using sleeping dma_resv locks, > > which is the motivation it. > > > > Currently when

Re: [PATCH v3 2/8] dma-buf/fence-chain: use trace_dma_fence_sync_to

2024-02-16 Thread Christian König
Am 16.02.24 um 16:09 schrieb Pierre-Eric Pelloux-Prayer: To inform tools about the relationship between the fences. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-16 Thread Doug Anderson
Hi, On Fri, Feb 16, 2024 at 12:21 AM Javier Martinez Canillas wrote: > > > The kernel tree we landed on was the v5.15 tree, which is currently > > serving all Qualcomm sc7180-based Chromebooks, all Mediatek 8173 > > Chromebooks and all Mediatek 8186 Chromebooks. There are also a pile > > of x86

Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-16 Thread Krzysztof Kozlowski
On 16/02/2024 09:43, Uwe Kleine-König wrote: >>> I applied the pwm patch now. If Lee wants to pick up this one via his >>> tree that would be fine for me, too. If that's the case please tell me, >>> then I'll drop it from my for-next branch again. Feel free to add >>> my Acked-by: Uwe Kleine-König

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Matthew Auld
On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert Karwatzki Signed-off-by: Arunpravin Paneer

Re: [PATCH 2/6] drm/buddy: fix range bias

2024-02-16 Thread Arunpravin Paneer Selvam
Looks good. Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: There is a corner case here where start/end is after/before the block range we are currently checking. If so we need to be sure that splitting the block will eventually give use the block size we

Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

2024-02-16 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next next-20240216] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4] [If your patch is applied

[PATCH] drm: xlnx: dp: Reset DisplayPort IP

2024-02-16 Thread Rohit Visavalia
Assert DisplayPort reset signal before deasserting, it is to clear out any registers programmed before booting kernel. Signed-off-by: Rohit Visavalia --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c

Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Maxime Ripard
On Fri, Feb 16, 2024 at 09:13:14AM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, February 16, 2024 9:05 AM > > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > > ARCH_K3 > > > > On Fri, Feb 16,

[PATCH 0/6] Enable Adaptive Sync SDP Support for DP

2024-02-16 Thread Mitul Golani
An Adaptive Sync SDP allows a DP protocol converter to forward Adaptive Sync video with minimal buffering overhead within the converter. An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the

[PATCH 1/6] drm/dp: Add an support to indicate if sink supports AS SDP

2024-02-16 Thread Mitul Golani
Add an API which indicates the sink support Adaptive Sync SDP, which can be used by the rest of the DP programming. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 27

[PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-16 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani]

[PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-16 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - use as_sdp instead of async [Ankit] - Correct define placeholders to where it is being actually used.

[PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-16 Thread Mitul Golani
Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.(Ankit) Signed-off-by: Mitul Golani ---

[PATCH 4/6] drm/i915/display: Compute and Enable AS SDP

2024-02-16 Thread Mitul Golani
Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx().[Ankit]

[PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-16 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 .../gpu/drm/i915/display/intel_display_device.h | 1 +

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 15:47 schrieb Matthew Auld: On 16/02/2024 14:02, Christian König wrote: Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and

[PATCH v3 6/8] drm: add drm_mode_atomic_commit event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
With this and the dma_fence_used_as_dependency event, a tool can draw the relationship between the compositing draw, the atomic commit, and vblank. An example on a 2 monitors system look like this: gnome-shell-1638[018] . 2571.905124: drm_mode_atomic_commit: file=245c3f0c, pid=

[PATCH v3 4/8] drm/amdgpu: add a amdgpu_bo_fill trace event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
Useful to identify why sdma jobs are submitted. v2: moved from amdgpu_bo_create to amdgpu_bo_fill Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ 2 files changed, 20

[PATCH v3 5/8] drm/amdgpu: add a amdgpu_cs_start trace event

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
amdgpu_cs_ioctl already exists but serves a different purpose. amdgpu_cs_start marks the beginning of the kernel processing of the ioctl which is useful for tools to map which events belong to the same submission (without this, the first event would be the amdgpu_bo_set_list ones). v2: renamed

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-16 Thread Thierry Reding
On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, other software components may rely on the kernel to > keep Host1x operational even during suspend. As such, as a quirk, > skip asserting Host1x's reset on Tegra186. This all sounds a bit vague.

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Adam Ford
On Fri, Feb 16, 2024 at 3:05 AM Alexander Stein wrote: > > Hi all, > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > From: Lucas Stach > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a little bit of SoC integration around it. > > > >

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 03:19, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 10:28:35 -0500 > Hamza Mahfooz wrote: > >> We want programs besides the compositor to be able to enable or disable >> panel power saving features. > > Could you also explain why, in the commit message, please? > > It is

Re: (subset) [PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 11:10:47 +0100, Luca Weiss wrote: > Introduce the bindings and panel driver for the LCD panel with the model > number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It > is used on the Fairphone 4 smartphone. > > Then we can add the panel to the device dts

Re: [PATCH 4/6] drm/tests/drm_buddy: add alloc_range_bias test

2024-02-16 Thread Arunpravin Paneer Selvam
Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: Sanity check range bias with DRM_BUDDY_RANGE_ALLOCATION. Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Christian König --- drivers/gpu/drm/tests/drm_buddy_test.c | 218 +

Re: [PATCH 3/6] drm/buddy: check range allocation matches alignment

2024-02-16 Thread Arunpravin Paneer Selvam
Its good to check the alignment Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: Likely not a big deal for real users, but for consistency we should respect the min_page_size here. Main issue is that bias allocations turns into normal range allocation if the

Re: [PATCH v5 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-16 Thread kernel test robot
/20240216/202402162038.hp7vzihx-...@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20240216/202402162038.hp7vzihx-...@intel.com/reproduce) If you fix the issue

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available.

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Hamza Mahfooz
On 2/16/24 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM:

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Laurent Pinchart
On Fri, Feb 16, 2024 at 10:05:26AM +0100, Alexander Stein wrote: > Hi all, > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > From: Lucas Stach > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a little bit of SoC integration around

Re: [PATCH v2 1/1] drm/mediatek: Filter modes according to hardware capability

2024-02-16 Thread 胡俊光

Re: [PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Neil Armstrong
On 16/02/2024 11:10, Luca Weiss wrote: Add support for the 2340x1080 LCD panel (DJN 9A-3R063-1102B) bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-16 Thread Arunpravin Paneer Selvam
Hi Matthew, Could you review the v6? Thanks, Arun. On 2/8/2024 9:19 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each

[PATCH v3 7/8] drm/sched: use trace_dma_fence_used_as_dependency

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
drm_sched_job_add_dependency adds dependencies so use the new trace event. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/scheduler/sched_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c

[PATCH v3 8/8] drm/amdgpu: add devname to trace_amdgpu_sched_run_job

2024-02-16 Thread Pierre-Eric Pelloux-Prayer
With the move to work queues for the drm scheduler it becomes impossible for a tool to match the events to the GPU. Before this move, the event source was fixed (eg: gfx_0.0.0-598), so even if the system had multiple GPUs with identical queue names it was possible to map the events using the PID.

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM

RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, February 16, 2024 9:05 AM > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > ARCH_K3 > > On Fri, Feb 16, 2024 at 08:47:46AM +, Biju Das wrote: > > Hi Adam Ford, > > > > >

Re: [PATCH v5 0/4] Add common1 region for AM62, AM62A & AM65x

2024-02-16 Thread Aradhya Bhatia
On 16-Feb-24 11:54, Devarsh Thakkar wrote: > This adds DSS common1 region for respective SoCs supporting it. > > Changelog: > V2 : Remove do-not-merge tag and add am62a dss common1 reion > V3 : Add Fixes tag to each commit > V4 : Add Reviewed-by tag and AM62A SoC TRM Link > V5 : Split dts

  1   2   3   >