[PATCH] drm: mm: fix range restricted allocations

2010-08-26 Thread Daniel Vetter 
With the code cleanup in

7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit
commit 7a6b2896f261894dde287d3faefa4b432cddca53
Author: Daniel Vetter 
Date:   Fri Jul 2 15:02:15 2010 +0100

drm_mm: extract check_free_mm_node

I've botched up the range-restriction checks. The result is usually
an X server dying with SIGBUS in libpixman (software fallback rendering).
Change the code to adjust the start and end for range restricted
allocations. IMHO this even makes the code a bit clearer.

Signed-off-by: Daniel Vetter 
---
 drivers/gpu/drm/drm_mm.c |   24 ++--
 1 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index da99edc..a6bfc30 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -285,21 +285,21 @@ void drm_mm_put_block(struct drm_mm_node *cur)

 EXPORT_SYMBOL(drm_mm_put_block);

-static int check_free_mm_node(struct drm_mm_node *entry, unsigned long size,
- unsigned alignment)
+static int check_free_hole(unsigned long start, unsigned long end,
+  unsigned long size, unsigned alignment)
 {
unsigned wasted = 0;

-   if (entry->size < size)
+   if (end - start < size)
return 0;

if (alignment) {
-   register unsigned tmp = entry->start % alignment;
+   unsigned tmp = start % alignment;
if (tmp)
wasted = alignment - tmp;
}

-   if (entry->size >= size + wasted) {
+   if (end >= start + size + wasted) {
return 1;
}

@@ -320,7 +320,8 @@ struct drm_mm_node *drm_mm_search_free(const struct drm_mm 
*mm,
best_size = ~0UL;

list_for_each_entry(entry, >free_stack, free_stack) {
-   if (!check_free_mm_node(entry, size, alignment))
+   if (!check_free_hole(entry->start, entry->start + entry->size,
+size, alignment))
continue;

if (!best_match)
@@ -353,10 +354,12 @@ struct drm_mm_node *drm_mm_search_free_in_range(const 
struct drm_mm *mm,
best_size = ~0UL;

list_for_each_entry(entry, >free_stack, free_stack) {
-   if (entry->start > end || (entry->start+entry->size) < start)
-   continue;
+   unsigned long adj_start = entry->start < start ?
+   start : entry->start;
+   unsigned long adj_end = entry->start + entry->size > end ?
+   end : entry->start + entry->size;

-   if (!check_free_mm_node(entry, size, alignment))
+   if (!check_free_hole(adj_start, adj_end, size, alignment))
continue;

if (!best_match)
@@ -449,7 +452,8 @@ int drm_mm_scan_add_block(struct drm_mm_node *node)
node->free_stack.prev = prev_free;
node->free_stack.next = next_free;

-   if (check_free_mm_node(node, mm->scan_size, mm->scan_alignment)) {
+   if (check_free_hole(node->start, node->start + node->size,
+   mm->scan_size, mm->scan_alignment)) {
mm->scan_hit_start = node->start;
mm->scan_hit_size = node->size;

-- 
1.7.1

i915: 2.6.36-rc2 hoses my Intel display

2010-08-26 Thread Maciej Rutecki 
On poniedzia?ek, 23 sierpnia 2010 o 19:01:45 Jonathan Corbet wrote:
> So I decided to fire up -rc2 today to see what would happen...the
> results are best described by the attached images.  Something is
> clearly scrambled between my hardware and the i915 driver.  Display with X
> is hosed, but things go weird before X gets a chance to run (it is worth
> noting that the initial output from the kernel is legible).
> 
> FWIW, my hardware is:
> 
> 00:02.1 Display controller: Intel Corporation 82Q35 Express Integrated
> Graphics Controller (rev 02) Subsystem: Dell OptiPlex 755
>   Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
> Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+
> ParErr- DEVSEL=fast >TAbort- SERR-  Latency: 0
>   Region 0: Memory at fea8 (32-bit, non-prefetchable) [size=512K]
>   Capabilities: [d0] Power Management version 2
>   Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0
> DScale=0 PME-
> 
> What else can I provide to help track this one down?

I created a Bugzilla entry at 
https://bugzilla.kernel.org/show_bug.cgi?id=17151
for your bug report, please add your address to the CC list in there, thanks!

-- 
Maciej Rutecki
http://www.maciek.unixy.pl

[PROBLEM] i915/drm: Insufficient FIFO for plane

2010-08-26 Thread Maciej Rutecki 
On niedziela, 22 sierpnia 2010 o 17:26:19 Pekka Enberg wrote:
> Hi,
> 
> I'm seeing tons of these error messages with current Linus' git:
> 
> [   95.941618] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
> plane, expect flickering: entries required = 36, available = 31.
> 
> Contrary to the error message, I don't see any flickering. I've attached
> my dmesg and config.
> 
>   Pekka
See:
https://bugzilla.kernel.org/show_bug.cgi?id=17021

Regards
-- 
Maciej Rutecki
http://www.maciek.unixy.pl

[PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Borislav Petkov 
From: Ben Hutchings 
Date: Thu, Aug 26, 2010 at 04:59:21PM +0100

>  should define dummy inline functions if CONFIG_VGA_ARB
> is not defined.  It already does this for vga_client_register() but should
> cover the other functions as well.

But what if you still need the VGA arbitration functionality? I don't
think I'll be running more than one X server on that netbook but still...

-- 
Regards/Gruss,
Boris.

[Bug 29652] Git commit e62e5b0 breaks Civilization IV (wine)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29652

Jon Severinsson  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #5 from Jon Severinsson  2010-08-26 
18:22:00 PDT ---
Fixed in git 059950, thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #13 from Alexandre  2010-08-26 17:41:29 
PDT ---
Me too. Before you patch I was finishing testing with 2.6.36-rc2 with the two
previous patches removed and it worked fine. I am testing with your patch and
it works, I could not crash it. Thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Carlos R. Mafra 
On Do 26.Aug'10 at 16:59:18 +0200, Borislav Petkov wrote:
> I get:
> 
>   LD  init/built-in.o
>   LD  .tmp_vmlinux1
> drivers/built-in.o: In function `intel_modeset_init':
> (.text+0xa993f): undefined reference to `vga_get'
> drivers/built-in.o: In function `intel_modeset_init':
> (.text+0xa9963): undefined reference to `vga_put'
> make: *** [.tmp_vmlinux1] Error 1
> 
> since CONFIG_AGB_ARB is not being selected. Make I915 driver select it
> as the numerous other things it selects.
> 
> Signed-off-by: Borislav Petkov 
> ---
> 
> This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make
> oldconfig' on an Acer Aspire One netbook.
> 
>  drivers/gpu/drm/Kconfig |1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 4cab0c6..43590ab 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -97,6 +97,7 @@ config DRM_I830
>  config DRM_I915
>   tristate "i915 driver"
>   depends on AGP_INTEL
> + select VGA_ARB
>   select SHMEM
>   select DRM_KMS_HELPER
>   select FB_CFB_FILLRECT

I reported this build failure here:

http://lkml.org/lkml/2010/8/23/127

Is there no other way to fix this? From the Kconfig description
of VGA_ARB I thought I would not need this (and it's a new thing too),
so why make my kernel bigger so easily?

[PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Ben Hutchings 
On Thu, Aug 26, 2010 at 05:29:54PM +0200, Carlos R. Mafra wrote:
> On Do 26.Aug'10 at 16:59:18 +0200, Borislav Petkov wrote:
> > I get:
> > 
> >   LD  init/built-in.o
> >   LD  .tmp_vmlinux1
> > drivers/built-in.o: In function `intel_modeset_init':
> > (.text+0xa993f): undefined reference to `vga_get'
> > drivers/built-in.o: In function `intel_modeset_init':
> > (.text+0xa9963): undefined reference to `vga_put'
> > make: *** [.tmp_vmlinux1] Error 1
> > 
> > since CONFIG_AGB_ARB is not being selected. Make I915 driver select it
> > as the numerous other things it selects.
> > 
> > Signed-off-by: Borislav Petkov 
> > ---
> > 
> > This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make
> > oldconfig' on an Acer Aspire One netbook.
> > 
> >  drivers/gpu/drm/Kconfig |1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index 4cab0c6..43590ab 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -97,6 +97,7 @@ config DRM_I830
> >  config DRM_I915
> > tristate "i915 driver"
> > depends on AGP_INTEL
> > +   select VGA_ARB
> > select SHMEM
> > select DRM_KMS_HELPER
> > select FB_CFB_FILLRECT
> 
> I reported this build failure here:
> 
> http://lkml.org/lkml/2010/8/23/127
> 
> Is there no other way to fix this? From the Kconfig description
> of VGA_ARB I thought I would not need this (and it's a new thing too),
> so why make my kernel bigger so easily?

 should define dummy inline functions if CONFIG_VGA_ARB
is not defined.  It already does this for vga_client_register() but should
cover the other functions as well.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
  - Albert Camus

[PATCH] i915, drm: Fix build dependency on VGA_ARB

2010-08-26 Thread Borislav Petkov 
I get:

  LD  init/built-in.o
  LD  .tmp_vmlinux1
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference to `vga_get'
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1

since CONFIG_AGB_ARB is not being selected. Make I915 driver select it
as the numerous other things it selects.

Signed-off-by: Borislav Petkov 
---

This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make
oldconfig' on an Acer Aspire One netbook.

 drivers/gpu/drm/Kconfig |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4cab0c6..43590ab 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -97,6 +97,7 @@ config DRM_I830
 config DRM_I915
tristate "i915 driver"
depends on AGP_INTEL
+   select VGA_ARB
select SHMEM
select DRM_KMS_HELPER
select FB_CFB_FILLRECT
-- 
1.7.1


-- 
Regards/Gruss,
Boris.

[Bug 28955] [r300g]: refresh/update/damage issues using compiz.

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28955

Scott Moreau  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #13 from Scott Moreau  2010-08-26 16:58:00 PDT 
---
Closed: Resolved/Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28955] [r300g]: refresh/update/damage issues using compiz.

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28955

--- Comment #12 from Scott Moreau  2010-08-26 16:57:09 PDT 
---
I am closing this bug since it no longer occurs with latest components. It must
have got fixed somewhere in the mix.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #27 from Ian Romanick  2010-08-26 16:31:51 
PDT ---
(In reply to comment #26)
> (In reply to comment #25)
> > Is the rendering correct on Intel hardware?  If the rendering isn't correct
> > anywhere, then the performance issues are irrelevant.  The performance will
> > change, one way or the other, when the correctness is fixed.
> 
> No, it isn't correct on i965 either. Last word was that it was a bug in the
> preprocessor, see bug 27028.

The preprocessor test mentioned in that bug seems to work correctly now.  I
believe that one is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #26 from Sven Arvidsson  2010-08-26 16:09:38 PDT ---
(In reply to comment #25)
> Is the rendering correct on Intel hardware?  If the rendering isn't correct
> anywhere, then the performance issues are irrelevant.  The performance will
> change, one way or the other, when the correctness is fixed.

No, it isn't correct on i965 either. Last word was that it was a bug in the
preprocessor, see bug 27028.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #25 from Ian Romanick  2010-08-26 15:41:05 
PDT ---
(In reply to comment #20)
> With latest git master (commit b5c07b9226d8e7de78f6367b5799b39caf820ef3) I 
> only
> get a black background and a mouse cursor. 
> 
> As for performance, it is much much slower than on my Intel IGP, slow enough
> that you need to wait for the mouse cursor to move, so something seems to be
> wrong.

Is the rendering correct on Intel hardware?  If the rendering isn't correct
anywhere, then the performance issues are irrelevant.  The performance will
change, one way or the other, when the correctness is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28474] [r300g] lugaru/etc locks up laptop

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28474

--- Comment #17 from Tormod Volden  2010-08-26 
14:57:18 PDT ---
I also tried the patch and with drm_kms_helper.poll=0 I can watch antmaze as
much as I want and more, and the lugaru bunny just keeps jumping without any
issues. If any test users want patched Ubuntu kernels, just tell me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #24 from Sven Arvidsson  2010-08-26 14:32:38 PDT ---
(Sorry for the bug spam)

The performance problem I'm having seems to be a result of the glsl2 merge, and
not from the vs loops. So I guess that's a different problem than what Pavel
have described.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #23 from Sven Arvidsson  2010-08-26 14:09:58 PDT ---
Dunno why, but the black screen was caused by libtxc_dxtn, removing it made the
problem go away. Anyway, some more observations about the performance problem: 

* It's not CPU-related, the game is only using about 60-70% on my system, so
shouldn't be a problem. 

* If run the game in a window, all other graphics related operations (such as
moving windows) slows to a crawl. 

* There's no significant difference in performance if I set all video options
in the game to their lowest setting.


Another game (from the same developers) that's having the same problem, is
Heroes of Newerth.
http://www.heroesofnewerth.com/download.php

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #12 from Till Matthiesen  2010-08-26 
13:49:21 PDT ---
Thanks, Daniel.

I'm testing against rc2-git4 and it runs fine so far (~30 min),
doing all that 'stuff' that made it easily crash within 2-5 minutes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #11 from Daniel Vetter  2010-08-26 12:37:10 PDT 
---
Created an attachment (id=38195)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38195
 Review: https://bugs.freedesktop.org/review?bug=29738=38195

fix range restriction checks in drm_mm

This patch should fix the problem. Please test.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[PATCH] drm/radeon/kms: remove stray radeon_i2c_destroy

2010-08-26 Thread Alex Deucher 
I missed this one in the i2c unification patch.  This
is handled in the core radeon i2c code now.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/radeon/radeon_pm.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c 
b/drivers/gpu/drm/radeon/radeon_pm.c
index 9a8031b..cc0f73a 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -622,8 +622,6 @@ void radeon_pm_fini(struct radeon_device *rdev)
}

radeon_hwmon_fini(rdev);
-   if (rdev->pm.i2c_bus)
-   radeon_i2c_destroy(rdev->pm.i2c_bus);
 }

 void radeon_pm_compute_clocks(struct radeon_device *rdev)
-- 
1.7.1.1

[REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Chris Wilson 
On Thu, 26 Aug 2010 02:15:20 +0200, Peter Stuge  wrote:
> It could be - the resetting backlight thing happened also before the
> backlight commit. Before pulling I was using the directly preceding
> commit.

https://bugs.freedesktop.org/show_bug.cgi?id=29716

That patch isn't complete but is on the right lines. The first bug appears
to be that in the driver we have multiple bits of code to set the panel
backlight with different bugs.

-- 
Chris Wilson, Intel Open Source Technology Centre

sigbus with drm patches

2010-08-26 Thread Alex Deucher 
Hi Daniel,

  Your recent drm lru and mm changes seem to be the cause of sigbus
errors with recent kernels.  Any insight was to what the problem is?

https://bugs.freedesktop.org/show_bug.cgi?id=29738

Thanks,

Alex

[Bug 29389] [r300g] [bisected] hard locks in openarena with kernel 2.6.35

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29389

--- Comment #2 from Niels Ole Salscheider  
2010-08-26 09:09:06 PDT ---
I can confirm this problem. With polling disabled my computer does not lock up
anymore.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

Alex Deucher  changed:

   What|Removed |Added

 CC||mikko.cal at gmail.com

--- Comment #10 from Alex Deucher  2010-08-26 08:01:25 PDT 
---
*** Bug 29819 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28966] [r300g] Dynamic branching 3 demo does not run

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28966

--- Comment #7 from Sven Arvidsson  2010-08-26 06:43:14 PDT ---
Since error messages was added to r300g it now reports:

r300 FP: Compiler Error:
Fragment program does not support relative addressing  of source operands.
Using a dummy shader instead.
r300 VP: Compiler error:
Vertex program does not support relative addressing of destination operands
(yet).
Using a dummy shader instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #22 from Sven Arvidsson  2010-08-26 06:38:10 PDT ---
No, nothing in dmesg. And just to clarify, it's only the game that's black, X
is unaffected.

I'll see if I can figure out where it broke, as it was working at least a
little bit better before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29818] New: r600g "vbo resource seems too big" spam

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29818

   Summary: r600g "vbo resource seems too big" spam
   Product: Mesa
   Version: git
  Platform: Other
OS/Version: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Drivers/DRI/R600
AssignedTo: dri-devel at lists.freedesktop.org
ReportedBy: seppo.yli-olli at iki.fi


I get lotsa (128 in dmesg) "radeon :01:00.0: vbo resource seems too big
(32769) for the bo (32768)" with glxgears atm and machine slows down to a
crawl. 
I suspect related to this http://www.spinics.net/lists/dri-devel/msg03278.html
off-by-one discussion.
Considering the version of DRM I have seems to have the line
"size = radeon_get_ib_value(p, idx+1+(i*7)+1) + 1;" and agd5f claims the patch
in the link was wrong, this could hint that r600g has the size wrong.
Mesa 90437330e2886fcd351dd11ee0e5aa3e8b523fdc.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Peter Stuge 
Chris Wilson wrote:
> > > > Xv performance
> > > 
> > > That should now be fixed in -intel,
> > 
> > Sounds good! I'd love to test. Which branch/commit is that?
> 
> Master with -vo xv should be good, if it doesn't hang.

Doesn't hang, mplayer says:

X11 error: BadAlloc (insufficient resources for operation)
X11 error: BadAlloc (insufficient resources for operation)
X11 error: BadAlloc (insufficient resources for operation)

over and over, with a window just showing the blue overlay keying.
I'm still working on the merge with your overlay branch.


> > Incidentally, apropos the backlight commit
> 
> That wasn't meant to be pushed. :( I was working on rectifying lack
> of backlight controls in on T61 and trying to reduce the number of
> pieces of code trying to accomplish the same thing through
> different means. I thought that work was contained on the T61...

It could be - the resetting backlight thing happened also before the
backlight commit. Before pulling I was using the directly preceding
commit.


//Peter

[REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Peter Stuge 
Hi again,

Chris Wilson wrote:
> > In general, Xv performance with KMS leaves me with a feeling that
> > something is not quite right in terms of playback, both with mplayer
> > and vlc. But while movies are nice, this stalling issue is more
> > important.
> 
> That should now be fixed in -intel,

Sounds good! I'd love to test. Which branch/commit is that? I just
pulled and am using 68a5ad4.

mplayer -vo gl or gl2 works but uses sw rendering and is very slow.

Incidentally, apropos the backlight commit in xf86-video-intel, it
seems like the driver always sets the backlight to 0. Whenver I start
X, backlight goes to minimum. I can crank it up with Fn+Home, but if
I restart X then it goes back down again.

/proc/acpi/ibm/brightness is always accurate, showing 0 after X
starts.


> However, we have we replaced it with a worse bug...

Oh well..


> > I get the stall precisely every 10 seconds.
> 
> This is caused by the hotplug polling code taking around 600ms to
> determine that the VGA is not connected.

Ouch. Could it rely on DDC? Maybe a quick DDC query could be done
first, and if that seems to indicate that something is connected
only then do the heavy work reading the border color?


> https://bugs.freedesktop.org/show_bug.cgi?id=29536

Lovely! The patch works well for me, booting with
drm_kms_helper.poll=0 on the kernel command line, and I'm back in X
now. I need to sort out some keyboard issues, but they are unrelated.

The commit message mentions runtime switching of the polling - how is
that done? As I understand it I might have to do that in order to run
xrandr e.g. to set up a projector, or possibly after - or no?


> > I've just upgraded my userspace and have xorg-server-1.8.2. No Xv
> > image with either xf86-video-intel driver. I haven't tried this
> > server with the 07-21 kernel to find out if Xv works there. The
> > stalling is more important.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=29574 (I think, Daniel
> reported something closer to your issue on IRC, but I don't have an
> actual bug for that.)

Disabling polling made no difference for Xv. I will try to merge your
overlay branch.


> > drm-intel.git (Should I look elsewhere?)
> 
> No, sounds like you've hit almost all of the recent 855 regressions.

.36-rc2 is the first kernel in what seems like a long time that feels
like a solid improvement, even if there are still some issues.
Well done!


> But you have a cursor, that is more than most people!

Funny you should say that! :) Actually I *don't* have a cursor in X
on cold boot, but it shows up after suspend+resume.

The cursor I mentioned is the VT blinking one.


> very pessimistic guess for the memory fetch

Aha. Thanks for the explanation!


//Peter

[REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Chris Wilson 
On Thu, 26 Aug 2010 01:33:15 +0200, Peter Stuge  wrote:
> Hi again,
> 
> Chris Wilson wrote:
> > > In general, Xv performance with KMS leaves me with a feeling that
> > > something is not quite right in terms of playback, both with mplayer
> > > and vlc. But while movies are nice, this stalling issue is more
> > > important.
> > 
> > That should now be fixed in -intel,
> 
> Sounds good! I'd love to test. Which branch/commit is that? I just
> pulled and am using 68a5ad4.
> 
> mplayer -vo gl or gl2 works but uses sw rendering and is very slow.

Master with -vo xv should be good, if it doesn't hang. 

> Incidentally, apropos the backlight commit in xf86-video-intel, it
> seems like the driver always sets the backlight to 0. Whenver I start
> X, backlight goes to minimum. I can crank it up with Fn+Home, but if
> I restart X then it goes back down again.
> 
> /proc/acpi/ibm/brightness is always accurate, showing 0 after X
> starts.

That wasn't meant to be pushed. :( I was working on rectifying lack of
backlight controls in on T61 and trying to reduce the number of pieces of
code trying to accomplish the same thing through different means. I
thought that work was contained on the T61...

-- 
Chris Wilson, Intel Open Source Technology Centre

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #9 from Alexandre  2010-08-26 00:33:25 
PDT ---
In my bisect (I tried to reduce the number of tests) by restricting the commits
to the drivers/gpu/drm include/drm directories.

The commit I got is the one below. I am not 100% confident since getting the
good is difficult (the bad is easy) and some combinations keep getting a
different bug that is described below.

7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit
commit 7a6b2896f261894dde287d3faefa4b432cddca53
Author: Daniel Vetter 
Date:   Fri Jul 2 15:02:15 2010 +0100

drm_mm: extract check_free_mm_node

There are already two copies of this logic. And the new scanning
stuff will add some more. So extract it into a small helper
function.

Signed-off-by: Daniel Vetter 
Acked-by: Thomas Hellstrom 
Signed-off-by: Chris Wilson 
Signed-off-by: Dave Airlie 

:04 04 a1d9ede188db6c1fc721c526a56437758f213c35
fcc9ba1feccf51c5d078301a27e9ec41b0498adf M  drivers

In some cases I keep getting this error. The drm restarts. I do not know if
this error is masking the fatal error to occur. I do not see this error in
2.6.35 or 2.6.25.2.

[18090.916037] WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:235
0x8138504a()
[18090.916040] Hardware name: Studio XPS 1640
[18090.916041] GPU lockup (waiting for 0x002D906A last fence id 0x002D9062)
Aug 25 20:06:58 becky3 kernel: [18090.916043] Modules linked in: mmc_block
aes_x86_64 aes_generic snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device
snd_pcm_oss snd_mixer_oss sco bnep rfcomm l2cap ipv6 acpi_cpufreq mperf btusb
bluetooth arc4 snd_hda_codec_atihdmi ecb snd_hda_codec_idt iwlagn snd_hda_intel
iwlcore snd_hda_codec snd_hwdep usbhid mac80211 uvcvideo snd_pcm snd_timer snd
videodev v4l2_compat_ioctl32 cfg80211 ehci_hcd uhci_hcd usbcore rtc_cmos
rtc_core sdhci_pci sdhci mmc_core dell_wmi dell_laptop processor snd_page_alloc
wmi ohci1394 video thermal joydev i2c_i801 rtc_lib rfkill led_class pcspkr sg
backlight output intel_agp ieee1394 thermal_sys dcdbas ac battery button
[18090.916092] Pid: 5449, comm: kwin Tainted: GW   2.6.35-rc4+ #3
[18090.916094] Call Trace:
[18090.916098]  [] 0x8103a0ca
[18090.916100]  [] 0x8103a1a1
[18090.916102]  [] 0x8138504a
[18090.916104]  [] ? 0x81051790
[18090.916106]  [] 0x8138593c
[18090.916108]  [] 0x81350906
[18090.916110]  [] 0x8139aece
[18090.916112]  [] 0x8133c3ea
[18090.916114]  [] ? 0x8139ae40
[18090.916116]  [] ? 0x810c6e12
[18090.916119]  [] 0x810d5b18
[18090.916121]  [] 0x810d5cc0
[18090.916123]  [] ? 0x810c7a70
[18090.916125]  [] 0x810d61aa
[18090.916127]  [] 0x81002ceb
[18090.916129] ---[ end trace cc0eb4d6579677d8 ]---
[18090.916136] [drm] Disabling audio support
[18090.917139] radeon :01:00.0: 88013ef8ae00 unpin not necessary
[18090.917356] radeon :01:00.0: GPU softreset
[18090.917359] radeon :01:00.0:   R_008010_GRBM_STATUS=0xA23034E0
[18090.917361] radeon :01:00.0:   R_008014_GRBM_STATUS2=0x0003
[18090.917363] radeon :01:00.0:   R_000E50_SRBM_STATUS=0x200010C0
[18090.917372] radeon :01:00.0:   R_008020_GRBM_SOFT_RESET=0x7FEE
[18090.932253] radeon :01:00.0: R_008020_GRBM_SOFT_RESET=0x0001
[18090.948123] radeon :01:00.0:   R_008010_GRBM_STATUS=0x3030
[18090.948125] radeon :01:00.0:   R_008014_GRBM_STATUS2=0x0003
[18090.948128] radeon :01:00.0:   R_000E50_SRBM_STATUS=0x20C0
[18090.949120] radeon :01:00.0: GPU reset succeed
[18090.967247] [drm] Clocks initialized !
[18091.000606] [drm] ring test succeeded in 1 usecs
[18091.000616] [drm] ib test succeeded in 1 usecs
[18091.000619] [drm] Enabling audio support
[18094.508025] radeon :01:00.0: GPU lockup CP stall for more than 1020msec

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29725] EXT_framebuffer_object extension with free radeon driver

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29725

--- Comment #6 from Andre Maasikas  2010-08-25 23:58:23 
PDT ---
seems to start & run a bit in mesa git
maybe it  was fixed by 1ec492a366e236569dc68f4de32e641c88cbcd63
or 1f7bc87391bc42eb9003020b7654e985494c6e61
These are also queued in 7.8 branch for 7.8.3
Can you try with these ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29762] [r300g] Coldest: Buffer too small for color buffer 0 (need 3407872 have 2023424) !

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29762

--- Comment #4 from Marek Ol??k  2010-08-25 23:19:49 PDT 
---
(In reply to comment #3)
> May be it will be not  too bad idea to restore this register type support in
> Gallium first? Anyone remember why it was removed?

I guess no one was using it, so I would not call it "support". Either way, we
have to start from scratch. Tom Stellard might know how hard it would be to
implement relative addressing in fragment shaders.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29725] EXT_framebuffer_object extension with free radeon driver

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29725

Alex Deucher  changed:

   What|Removed |Added

  Attachment #38168|application/octet-stream|text/plain
  mime type||
  Attachment #38168|0   |1
   is patch||

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29725] EXT_framebuffer_object extension with free radeon driver

2010-08-26 Thread bugzilla-dae...@freedesktop.org 
https://bugs.freedesktop.org/show_bug.cgi?id=29725

Alex Deucher  changed:

   What|Removed |Added

  Attachment #38167|application/octet-stream|text/plain
  mime type||
  Attachment #38167|0   |1
   is patch||

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 29725] EXT_framebuffer_object extension with free radeon driver

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29725

Alex Deucher ag...@yahoo.com changed:

   What|Removed |Added

  Attachment #38168|application/octet-stream|text/plain
  mime type||
  Attachment #38168|0   |1
   is patch||

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29725] EXT_framebuffer_object extension with free radeon driver

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29725

--- Comment #6 from Andre Maasikas amaasi...@gmail.com 2010-08-25 23:58:23 
PDT ---
seems to start  run a bit in mesa git
maybe it  was fixed by 1ec492a366e236569dc68f4de32e641c88cbcd63
or 1f7bc87391bc42eb9003020b7654e985494c6e61
These are also queued in 7.8 branch for 7.8.3
Can you try with these ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #9 from Alexandre alexandre...@gmail.com 2010-08-26 00:33:25 PDT 
---
In my bisect (I tried to reduce the number of tests) by restricting the commits
to the drivers/gpu/drm include/drm directories.

The commit I got is the one below. I am not 100% confident since getting the
good is difficult (the bad is easy) and some combinations keep getting a
different bug that is described below.

7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit
commit 7a6b2896f261894dde287d3faefa4b432cddca53
Author: Daniel Vetter daniel.vet...@ffwll.ch
Date:   Fri Jul 2 15:02:15 2010 +0100

drm_mm: extract check_free_mm_node

There are already two copies of this logic. And the new scanning
stuff will add some more. So extract it into a small helper
function.

Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Acked-by: Thomas Hellstrom thellst...@vmwgfx.com
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Dave Airlie airl...@redhat.com

:04 04 a1d9ede188db6c1fc721c526a56437758f213c35
fcc9ba1feccf51c5d078301a27e9ec41b0498adf M  drivers

In some cases I keep getting this error. The drm restarts. I do not know if
this error is masking the fatal error to occur. I do not see this error in
2.6.35 or 2.6.25.2.

[18090.916037] WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:235
0x8138504a()
[18090.916040] Hardware name: Studio XPS 1640
[18090.916041] GPU lockup (waiting for 0x002D906A last fence id 0x002D9062)
Aug 25 20:06:58 becky3 kernel: [18090.916043] Modules linked in: mmc_block
aes_x86_64 aes_generic snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device
snd_pcm_oss snd_mixer_oss sco bnep rfcomm l2cap ipv6 acpi_cpufreq mperf btusb
bluetooth arc4 snd_hda_codec_atihdmi ecb snd_hda_codec_idt iwlagn snd_hda_intel
iwlcore snd_hda_codec snd_hwdep usbhid mac80211 uvcvideo snd_pcm snd_timer snd
videodev v4l2_compat_ioctl32 cfg80211 ehci_hcd uhci_hcd usbcore rtc_cmos
rtc_core sdhci_pci sdhci mmc_core dell_wmi dell_laptop processor snd_page_alloc
wmi ohci1394 video thermal joydev i2c_i801 rtc_lib rfkill led_class pcspkr sg
backlight output intel_agp ieee1394 thermal_sys dcdbas ac battery button
[18090.916092] Pid: 5449, comm: kwin Tainted: GW   2.6.35-rc4+ #3
[18090.916094] Call Trace:
[18090.916098]  [8103a0ca] 0x8103a0ca
[18090.916100]  [8103a1a1] 0x8103a1a1
[18090.916102]  [8138504a] 0x8138504a
[18090.916104]  [81051790] ? 0x81051790
[18090.916106]  [8138593c] 0x8138593c
[18090.916108]  [81350906] 0x81350906
[18090.916110]  [8139aece] 0x8139aece
[18090.916112]  [8133c3ea] 0x8133c3ea
[18090.916114]  [8139ae40] ? 0x8139ae40
[18090.916116]  [810c6e12] ? 0x810c6e12
[18090.916119]  [810d5b18] 0x810d5b18
[18090.916121]  [810d5cc0] 0x810d5cc0
[18090.916123]  [810c7a70] ? 0x810c7a70
[18090.916125]  [810d61aa] 0x810d61aa
[18090.916127]  [81002ceb] 0x81002ceb
[18090.916129] ---[ end trace cc0eb4d6579677d8 ]---
[18090.916136] [drm] Disabling audio support
[18090.917139] radeon :01:00.0: 88013ef8ae00 unpin not necessary
[18090.917356] radeon :01:00.0: GPU softreset
[18090.917359] radeon :01:00.0:   R_008010_GRBM_STATUS=0xA23034E0
[18090.917361] radeon :01:00.0:   R_008014_GRBM_STATUS2=0x0003
[18090.917363] radeon :01:00.0:   R_000E50_SRBM_STATUS=0x200010C0
[18090.917372] radeon :01:00.0:   R_008020_GRBM_SOFT_RESET=0x7FEE
[18090.932253] radeon :01:00.0: R_008020_GRBM_SOFT_RESET=0x0001
[18090.948123] radeon :01:00.0:   R_008010_GRBM_STATUS=0x3030
[18090.948125] radeon :01:00.0:   R_008014_GRBM_STATUS2=0x0003
[18090.948128] radeon :01:00.0:   R_000E50_SRBM_STATUS=0x20C0
[18090.949120] radeon :01:00.0: GPU reset succeed
[18090.967247] [drm] Clocks initialized !
[18091.000606] [drm] ring test succeeded in 1 usecs
[18091.000616] [drm] ib test succeeded in 1 usecs
[18091.000619] [drm] Enabling audio support
[18094.508025] radeon :01:00.0: GPU lockup CP stall for more than 1020msec

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Chris Wilson 
On Thu, 26 Aug 2010 02:15:20 +0200, Peter Stuge pe...@stuge.se wrote:
 It could be - the resetting backlight thing happened also before the
 backlight commit. Before pulling I was using the directly preceding
 commit.

https://bugs.freedesktop.org/show_bug.cgi?id=29716

That patch isn't complete but is on the right lines. The first bug appears
to be that in the driver we have multiple bits of code to set the panel
backlight with different bugs.

-- 
Chris Wilson, Intel Open Source Technology Centre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #22 from Sven Arvidsson s...@whiz.se 2010-08-26 06:38:10 PDT ---
No, nothing in dmesg. And just to clarify, it's only the game that's black, X
is unaffected.

I'll see if I can figure out where it broke, as it was working at least a
little bit better before.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28966] [r300g] Dynamic branching 3 demo does not run

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28966

--- Comment #7 from Sven Arvidsson s...@whiz.se 2010-08-26 06:43:14 PDT ---
Since error messages was added to r300g it now reports:

r300 FP: Compiler Error:
Fragment program does not support relative addressing  of source operands.
Using a dummy shader instead.
r300 VP: Compiler error:
Vertex program does not support relative addressing of destination operands
(yet).
Using a dummy shader instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

Alex Deucher ag...@yahoo.com changed:

   What|Removed |Added

 CC||mikko@gmail.com

--- Comment #10 from Alex Deucher ag...@yahoo.com 2010-08-26 08:01:25 PDT ---
*** Bug 29819 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/radeon/kms: remove stray radeon_i2c_destroy

2010-08-26 Thread Alex Deucher 
I missed this one in the i2c unification patch.  This
is handled in the core radeon i2c code now.

Signed-off-by: Alex Deucher alexdeuc...@gmail.com
---
 drivers/gpu/drm/radeon/radeon_pm.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c 
b/drivers/gpu/drm/radeon/radeon_pm.c
index 9a8031b..cc0f73a 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -622,8 +622,6 @@ void radeon_pm_fini(struct radeon_device *rdev)
}
 
radeon_hwmon_fini(rdev);
-   if (rdev-pm.i2c_bus)
-   radeon_i2c_destroy(rdev-pm.i2c_bus);
 }
 
 void radeon_pm_compute_clocks(struct radeon_device *rdev)
-- 
1.7.1.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PROBLEM] i915/drm: Insufficient FIFO for plane

2010-08-26 Thread Maciej Rutecki 
On niedziela, 22 sierpnia 2010 o 17:26:19 Pekka Enberg wrote:
 Hi,
 
 I'm seeing tons of these error messages with current Linus' git:
 
 [   95.941618] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for
 plane, expect flickering: entries required = 36, available = 31.
 
 Contrary to the error message, I don't see any flickering. I've attached
 my dmesg and config.
 
   Pekka
See:
https://bugzilla.kernel.org/show_bug.cgi?id=17021

Regards
-- 
Maciej Rutecki
http://www.maciek.unixy.pl
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: i915: 2.6.36-rc2 hoses my Intel display

2010-08-26 Thread Maciej Rutecki 
On poniedziałek, 23 sierpnia 2010 o 19:01:45 Jonathan Corbet wrote:
 So I decided to fire up -rc2 today to see what would happen...the
 results are best described by the attached images.  Something is
 clearly scrambled between my hardware and the i915 driver.  Display with X
 is hosed, but things go weird before X gets a chance to run (it is worth
 noting that the initial output from the kernel is legible).
 
 FWIW, my hardware is:
 
 00:02.1 Display controller: Intel Corporation 82Q35 Express Integrated
 Graphics Controller (rev 02) Subsystem: Dell OptiPlex 755
   Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
 Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+
 ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- INTx-
 Latency: 0
   Region 0: Memory at fea8 (32-bit, non-prefetchable) [size=512K]
   Capabilities: [d0] Power Management version 2
   Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
 PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0
 DScale=0 PME-
 
 What else can I provide to help track this one down?

I created a Bugzilla entry at 
https://bugzilla.kernel.org/show_bug.cgi?id=17151
for your bug report, please add your address to the CC list in there, thanks!

-- 
Maciej Rutecki
http://www.maciek.unixy.pl
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #11 from Daniel Vetter dan...@ffwll.ch 2010-08-26 12:37:10 PDT ---
Created an attachment (id=38195)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38195
 Review: https://bugs.freedesktop.org/review?bug=29738attachment=38195

fix range restriction checks in drm_mm

This patch should fix the problem. Please test.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: mm: fix range restricted allocations

2010-08-26 Thread Daniel Vetter 
With the code cleanup in

7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit
commit 7a6b2896f261894dde287d3faefa4b432cddca53
Author: Daniel Vetter daniel.vet...@ffwll.ch
Date:   Fri Jul 2 15:02:15 2010 +0100

drm_mm: extract check_free_mm_node

I've botched up the range-restriction checks. The result is usually
an X server dying with SIGBUS in libpixman (software fallback rendering).
Change the code to adjust the start and end for range restricted
allocations. IMHO this even makes the code a bit clearer.

Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
 drivers/gpu/drm/drm_mm.c |   24 ++--
 1 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index da99edc..a6bfc30 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -285,21 +285,21 @@ void drm_mm_put_block(struct drm_mm_node *cur)
 
 EXPORT_SYMBOL(drm_mm_put_block);
 
-static int check_free_mm_node(struct drm_mm_node *entry, unsigned long size,
- unsigned alignment)
+static int check_free_hole(unsigned long start, unsigned long end,
+  unsigned long size, unsigned alignment)
 {
unsigned wasted = 0;
 
-   if (entry-size  size)
+   if (end - start  size)
return 0;
 
if (alignment) {
-   register unsigned tmp = entry-start % alignment;
+   unsigned tmp = start % alignment;
if (tmp)
wasted = alignment - tmp;
}
 
-   if (entry-size = size + wasted) {
+   if (end = start + size + wasted) {
return 1;
}
 
@@ -320,7 +320,8 @@ struct drm_mm_node *drm_mm_search_free(const struct drm_mm 
*mm,
best_size = ~0UL;
 
list_for_each_entry(entry, mm-free_stack, free_stack) {
-   if (!check_free_mm_node(entry, size, alignment))
+   if (!check_free_hole(entry-start, entry-start + entry-size,
+size, alignment))
continue;
 
if (!best_match)
@@ -353,10 +354,12 @@ struct drm_mm_node *drm_mm_search_free_in_range(const 
struct drm_mm *mm,
best_size = ~0UL;
 
list_for_each_entry(entry, mm-free_stack, free_stack) {
-   if (entry-start  end || (entry-start+entry-size)  start)
-   continue;
+   unsigned long adj_start = entry-start  start ?
+   start : entry-start;
+   unsigned long adj_end = entry-start + entry-size  end ?
+   end : entry-start + entry-size;
 
-   if (!check_free_mm_node(entry, size, alignment))
+   if (!check_free_hole(adj_start, adj_end, size, alignment))
continue;
 
if (!best_match)
@@ -449,7 +452,8 @@ int drm_mm_scan_add_block(struct drm_mm_node *node)
node-free_stack.prev = prev_free;
node-free_stack.next = next_free;
 
-   if (check_free_mm_node(node, mm-scan_size, mm-scan_alignment)) {
+   if (check_free_hole(node-start, node-start + node-size,
+   mm-scan_size, mm-scan_alignment)) {
mm-scan_hit_start = node-start;
mm-scan_hit_size = node-size;
 
-- 
1.7.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=29738

--- Comment #12 from Till Matthiesen entr...@everymail.net 2010-08-26 
13:49:21 PDT ---
Thanks, Daniel.

I'm testing against rc2-git4 and it runs fine so far (~30 min),
doing all that 'stuff' that made it easily crash within 2-5 minutes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #23 from Sven Arvidsson s...@whiz.se 2010-08-26 14:09:58 PDT ---
Dunno why, but the black screen was caused by libtxc_dxtn, removing it made the
problem go away. Anyway, some more observations about the performance problem: 

* It's not CPU-related, the game is only using about 60-70% on my system, so
shouldn't be a problem. 

* If run the game in a window, all other graphics related operations (such as
moving windows) slows to a crawl. 

* There's no significant difference in performance if I set all video options
in the game to their lowest setting.


Another game (from the same developers) that's having the same problem, is
Heroes of Newerth.
http://www.heroesofnewerth.com/download.php

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #24 from Sven Arvidsson s...@whiz.se 2010-08-26 14:32:38 PDT ---
(Sorry for the bug spam)

The performance problem I'm having seems to be a result of the glsl2 merge, and
not from the vs loops. So I guess that's a different problem than what Pavel
have described.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28474] [r300g] lugaru/etc locks up laptop

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28474

--- Comment #17 from Tormod Volden bugzi09.fdo.tor...@xoxy.net 2010-08-26 
14:57:18 PDT ---
I also tried the patch and with drm_kms_helper.poll=0 I can watch antmaze as
much as I want and more, and the lugaru bunny just keeps jumping without any
issues. If any test users want patched Ubuntu kernels, just tell me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #25 from Ian Romanick i...@freedesktop.org 2010-08-26 15:41:05 
PDT ---
(In reply to comment #20)
 With latest git master (commit b5c07b9226d8e7de78f6367b5799b39caf820ef3) I 
 only
 get a black background and a mouse cursor. 
 
 As for performance, it is much much slower than on my Intel IGP, slow enough
 that you need to wait for the mouse cursor to move, so something seems to be
 wrong.

Is the rendering correct on Intel hardware?  If the rendering isn't correct
anywhere, then the performance issues are irrelevant.  The performance will
change, one way or the other, when the correctness is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #26 from Sven Arvidsson s...@whiz.se 2010-08-26 16:09:38 PDT ---
(In reply to comment #25)
 Is the rendering correct on Intel hardware?  If the rendering isn't correct
 anywhere, then the performance issues are irrelevant.  The performance will
 change, one way or the other, when the correctness is fixed.

No, it isn't correct on i965 either. Last word was that it was a bug in the
preprocessor, see bug 27028.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28517] [r300g] loop unrolling fails (was: Savage 2 : characters are not rendered + another corruptions)

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28517

--- Comment #27 from Ian Romanick i...@freedesktop.org 2010-08-26 16:31:51 
PDT ---
(In reply to comment #26)
 (In reply to comment #25)
  Is the rendering correct on Intel hardware?  If the rendering isn't correct
  anywhere, then the performance issues are irrelevant.  The performance will
  change, one way or the other, when the correctness is fixed.
 
 No, it isn't correct on i965 either. Last word was that it was a bug in the
 preprocessor, see bug 27028.

The preprocessor test mentioned in that bug seems to work correctly now.  I
believe that one is fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28955] [r300g]: refresh/update/damage issues using compiz.

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28955

--- Comment #12 from Scott Moreau ore...@gmail.com 2010-08-26 16:57:09 PDT ---
I am closing this bug since it no longer occurs with latest components. It must
have got fixed somewhere in the mix.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28955] [r300g]: refresh/update/damage issues using compiz.

2010-08-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=28955

Scott Moreau ore...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #13 from Scott Moreau ore...@gmail.com 2010-08-26 16:58:00 PDT ---
Closed: Resolved/Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[git pull] drm fixes.

2010-08-26 Thread Dave Airlie 

Hi Linus,

Some regression fixes, a couple around the BKL removal, and one in the 
drm_mm code that was causing SIGBUS errors for some radeon users.

Dave.

The following changes since commit d03330383c9255cdb184dd33594e89c3542f191b:

  Merge remote branch 'nouveau/for-airlied' of /ssd/git/drm-nouveau-next into 
drm-core-next (2010-08-23 08:34:59 +1000)

are available in the git repository at:

  ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes

Adam Jackson (1):
  drm/modes: Fix CVT-R modeline generation

Alex Deucher (2):
  drm/radeon/kms: remove stray radeon_i2c_destroy
  drm/radeon/kms: add missing scratch update in dp_detect

Arnd Bergmann (1):
  drm: fix regression in drm locking since BKL removal.

Ben Skeggs (3):
  drm/nv50: add dcb type 14 to enum to prevent compiler complaint
  drm: export drm_global_mutex for drivers to use
  drm/nouveau: drop drm_global_mutex before sleeping in submission path

Chris Wilson (1):
  vgaarb: Wrap vga_(get|put) in CONFIG_VGA_ARB

Daniel Vetter (1):
  drm: mm: fix range restricted allocations

Dave Airlie (1):
  Merge remote branch 'nouveau/for-airlied' of /ssd/git/drm-nouveau-next 
into drm-fixes

Francisco Jerez (4):
  drm/nouveau: Use a helper function to match PCI device/subsystem IDs.
  drm/nouveau: Fix backlight control on PPC machines with an internal TMDS 
panel.
  drm/nouveau: Fix TMDS on some DCB1.5 boards.
  drm/nv20: Don't use pushbuf calls on the original nv20.

Patrice Mandin (1):
  drm/nv30: Apply modesetting to the correct slave encoder

 drivers/gpu/drm/drm_fops.c |1 +
 drivers/gpu/drm/drm_lock.c |2 +
 drivers/gpu/drm/drm_mm.c   |   24 ++
 drivers/gpu/drm/drm_modes.c|5 ++-
 drivers/gpu/drm/nouveau/nouveau_bios.c |   64 +++-
 drivers/gpu/drm/nouveau/nouveau_bios.h |1 +
 drivers/gpu/drm/nouveau/nouveau_drv.h  |9 
 drivers/gpu/drm/nouveau/nouveau_gem.c  |6 ++-
 drivers/gpu/drm/nouveau/nv04_dfp.c |   31 -
 drivers/gpu/drm/nouveau/nv17_tv.c  |   10 +---
 drivers/gpu/drm/radeon/radeon_connectors.c |1 +
 drivers/gpu/drm/radeon/radeon_pm.c |2 -
 include/linux/vgaarb.h |   15 ++-
 13 files changed, 95 insertions(+), 76 deletions(-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel