[Why]
Found kernel NULL pointer dereference under the below situation:
src — HDMI_Monitor src — HDMI_Monitor
e.g.: \=>
MSTB — MSTB (unplug) MSTB — MSTB
When display 1 HDMI and 2 DP daisy chain monitors, unplugging the dp
cable connected to source
This adds device tree bindings for the Novatek NT35510-based
family of panels. Since several such panels are in existence
we define bindings common for all, and define the compatible
string for one certain panel (Hydis HVA40WV1).
As other panels are discovered and investigated, we can add
more
This adds a driver for panels based on the Novatek NT35510
display driver IC, such as the Hydis HVA40WV1 panel found
in the Samsung GT-S7710.
The NT35510 can be used with both internal and external
backlight (such as GPIO backlight) so we support both:
if no external backlight is found, we
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: CK Hu
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Describe LVDS IP. Add the CRTC and LVDS relevant endpoints so they can
be linked together.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 37 ++
1 file changed, 37 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sil-sii8620.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c
It's no longer used, all drivers have been converted to an embedded
drm_bridge struct.
Signed-off-by: Mihail Atanassov
---
include/drm/drm_bridge.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 695d0898df38..ee175a2f95e6 100644
Document the PX30 LVDS compatible.
Signed-off-by: Miquel Raynal
Acked-by: Rob Herring
---
.../devicetree/bindings/display/rockchip/rockchip-lvds.txt | 1 +
1 file changed, 1 insertion(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/rockchip-lvds.txt
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358767.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/panel.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c
No functional change.
v3:
- drop driver_private argument (Laurent)
- update commit title prefix (Neil)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii9234.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c
Fix a #define indentation before adding more lines.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Miquel Raynal
---
drivers/gpu/drm/rockchip/rockchip_lvds.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c
As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1
follows the setting and NULLing of the 'encoder' field. Therefore, use
drm_bridge->encoder->dev in place of drm_bridge->dev.
[1] https://patchwork.freedesktop.org/patch/343824/
v3:
- resend as part of drm_bridge_init()
No functional change.
v3:
- drop driver_private argument (Laurent)
Cc: Inki Dae
Cc: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
A simple convenience function to initialize the struct drm_bridge. The
goal is to standardize initialization for any bridge registered with
drm_bridge_add() so that we can later add device links for consumers of
those bridges.
v3:
- drop driver_private parameter (Laurent)
- spelling & style
Return errors instead of returning void from internal helpers. When
these helpers are called, check the returned value and print an error
message in this case.
Signed-off-by: Miquel Raynal
---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 31 ++--
1 file changed, 23
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
Hello,
This series aims at supporting LVDS on PX30.
A first couple of patches update the documentation with the new
compatible and the presence of a PHY. Then, the existing Rockchip
driver is cleaned and extended to support PX30 specificities. Finally,
the PX30 DTSI is updated with CRTC routes,
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 83538125a722..1d6dfae8a200 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Use a container_of wrapper instead. Note that no logic depends on
driver_private being NULL or not, so the cleanup in exynos_mic_bind is
safe to apply.
Cc: Inki Dae
Signed-off-by: Mihail Atanassov
---
Reviewer note: the driver_private cleanup used to be part of the
relevant drm_bridge_init()
No functional change.
The setting of bridge->of_node by drm_bridge_init() in
analogix_dp_core.c is safe, since ->of_node isn't used directly and the
bridge isn't published with drm_bridge_add().
v3:
- drop driver_private argument (Laurent)
- pass correct struct device pointer to
Instead, embed the drm_bridge structure into analogix_dp_core and use
a container_of wrapper to access the latter.
Signed-off-by: Mihail Atanassov
---
.../drm/bridge/analogix/analogix_dp_core.c| 40 +++
.../drm/bridge/analogix/analogix_dp_core.h| 8 +++-
2 files
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
syzbot has found a reproducer for the following crash on:
HEAD commit:46cf053e Linux 5.5-rc3
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15cf54e1e0
kernel config: https://syzkaller.appspot.com/x/.config?x=ed9d672709340e35
dashboard link:
Hi all,
Version 3 of my drm_bridge_init() series here. The biggest change from
the previous version is the removal of drm_bridge->dev (1/35) and the
removal of ->driver_private (2-7/35). The rest of the patches are mostly
the same, save for dropping the driver_private argument from
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: Linus Walleij
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c
As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1
follows the setting and NULLing of the 'encoder' field. Therefore, use
drm_bridge->encoder->dev in place of drm_bridge->dev.
[1] https://patchwork.freedesktop.org/patch/343824/
v3:
- resend as part of drm_bridge_init()
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii902x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c
Add the PHY which outputs MIPI DSI and LVDS.
Signed-off-by: Miquel Raynal
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi
b/arch/arm64/boot/dts/rockchip/px30.dtsi
index b2af0f02ecbe..672a3a2f42b9
Prepare the introduction of PX30 support by using
drm_encoder_helper_funcs as platform data instead of multiple register
names which are specific to rk3288 and not generic to all Rockchip
IPs. This way adding support for a new flavor of a similar IP will be
a matter of adding the relevant helper
PX30 SoCs use a single PHY shared by two display pipelines: MIPI DSI
and LVDS. In the case of the LVDS IP, document the possibility to fill
a PHY handle.
Signed-off-by: Miquel Raynal
---
.../devicetree/bindings/display/rockchip/rockchip-lvds.txt | 3 +++
1 file changed, 3 insertions(+)
Prepare the introduction of PX30 support by clarifying the function
prefixes.
We continue to prefix with 'rockchip_lvds_' generic functions that are
not specific to a single hardware. Functions implying hardware
modifications are now prefixed with 'rk3288_lvds_'.
Signed-off-by: Miquel Raynal
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358764.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358764.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/lvds-codec.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c
Instead, embed the drm_bridge structure in the originally-pointed-to
struct and use a container_of wrapper to access it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 20
drivers/gpu/drm/sti/sti_hda.c | 17 -
The probe function is highly tighten to the RK3288 specificities, move
all specific bits into an "rk3288_probe" function, also part of the
platform data.
The goal is to ease the addition of new flavors of Rockchip LVDS IPs.
Signed-off-by: Miquel Raynal
---
Thanks for the update!
On Tue, Dec 24, 2019, 9:25 PM CK Hu wrote:
> Hi, Mark:
>
> On Wed, 2019-12-11 at 10:49 -0500, Mark Yacoub wrote:
> > drm/mediatek: return if plane pending state is disabled.
> >
> > If the plane pending state is disabled, call mtk_ovl_layer_off then
> > return.
> > This
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/parade-ps8622.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
index 3d74129b2995..784f4e4eea05 100644
---
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/i2c/tda998x_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
dw_hdmi: The drm_bridge struct is already embedded, so use
a container_of wrapper to access it.
dw-mipi-dsi: The field is unused, remove it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 15 ---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c |
No functional change.
v3:
- drop driver_private argument (Laurent)
v2:
- Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam,
Benjamin)
Reviewed-by: Benjamin Gaignard
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 3 +--
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Introduce PX30 LVDS support. This means adding the relevant helper
functions, a specific probe and also the initialization of a specific
PHY.
Signed-off-by: Miquel Raynal
---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 143 +++
drivers/gpu/drm/rockchip/rockchip_lvds.h | 14
Reorganize a bit the functions order to clarify the driver. This
change only moves functions around, there is no functional change.
Signed-off-by: Miquel Raynal
---
drivers/gpu/drm/rockchip/rockchip_lvds.c | 90
1 file changed, 45 insertions(+), 45 deletions(-)
diff
Hi Heiko,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next
tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master drm/drm-next v5.5-rc3
next-20191220]
[if your patch is applied to
55 matches
Mail list logo