Re: [git pull] drm fixes for v5.7-rc7

2020-05-22 Thread pr-tracker-bot
The pull request you sent on Sat, 23 May 2020 06:38:11 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-05-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a24deb9d68b423f3e5e190b9836d192ee3e0ff9d Thank you! -- Deet-doot-dot, I am a bot.

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #15 from Cyrax (ev...@hotmail.com) --- Created attachment 289241 --> https://bugzilla.kernel.org/attachment.cgi?id=289241=edit dump of struct dcn_bw_internal_vars -- You are receiving this mail because: You are watching the

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #14 from Cyrax (ev...@hotmail.com) --- Created attachment 289239 --> https://bugzilla.kernel.org/attachment.cgi?id=289239=edit backtrace created by executing bt -f command in crash utility -- You are receiving this mail because:

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #13 from Cyrax (ev...@hotmail.com) --- Created attachment 289237 --> https://bugzilla.kernel.org/attachment.cgi?id=289237=edit kernel log dumped from crash dump by using crash utility -- You are receiving this mail because: You

Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-22 Thread John Hubbard
On 2020-05-22 04:40, Souptick Joarder wrote: ... 3) Make it easy for an upcoming patch from Souptick, which aims to convert __get_user_pages_fast() to use a gup_flags argument, instead of a bool writeable arg. Also, if this series looks good, we can ask Souptick to change the name

Re: [PATCH] drm/msm/a6xx: don't try to set GPU frequency when GMU is suspended

2020-05-22 Thread Jordan Crouse
On Mon, May 18, 2020 at 11:07:33PM -0400, Jonathan Marek wrote: > This fixes changing the frequency in sysfs while suspended, for example > when doing something like this: > > cat devfreq/3d0.gpu/max_freq > devfreq/3d0.gpu/min_freq A patch landed to fix this [1] but it crossed paths in

[PATCH v1 0/3] drm/msm: Cleanups ahead of per-instance pagetables

2020-05-22 Thread Jordan Crouse
These are three cleanup and reorganization patches that were originally part of one of my many per-instance pagetable stacks [1] [2] but make life better in general and can stand on their own. Send them now to get them out of my other stack and make that processs ever so easier. [1]

[PATCH v1 2/3] drm/msm: Refactor address space initialization

2020-05-22 Thread Jordan Crouse
Refactor how address space initialization works. Instead of having the address space function create the MMU object (and thus require separate but equal functions for gpummu and iommu) use a single function and pass the MMU struct in. Make the generic code cleaner by using target specific

[PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-22 Thread Jordan Crouse
Everywhere an IOMMU object is created by msm_gpu_create_address_space the IOMMU device is attached immediately after. Instead of carrying around the infrastructure to do the attach from the device specific code do it directly in the msm_iommu_init() function. This gets it out of the way for more

[PATCH v1 3/3] drm/msm: Update the MMU helper function APIs

2020-05-22 Thread Jordan Crouse
Instead of using a bare unsigned type for the length value for map/unmap functions pass in a size_t to more correctly match up with the underlying APIs. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpummu.c | 4 ++-- drivers/gpu/drm/msm/msm_iommu.c | 4 ++--

[Bug 204611] amdgpu error scheduling IBs when waking from sleep

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204611 aeon.descrip...@gmail.com changed: What|Removed |Added CC||aeon.descrip...@gmail.com

[git pull] drm fixes for v5.7-rc7

2020-05-22 Thread Dave Airlie
Hi Linus, Things seemed to have quieten down, though no i915 pull (I even gave them an extra 12 hours in case they were late). The amdgpu floating point fix is probably the largest, but it just moves some code around to it doesn't do fpu stuff outside the fpu boundaries. Otherwise it's just a

Re: [PATCH] drm: rcar-du: Fix build error

2020-05-22 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Mon, May 18, 2020 at 10:16:46PM +0200, Daniel Gomez wrote: > Select DRM_KMS_HELPER dependency. > > Build error when DRM_KMS_HELPER is not selected: > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to >

Re: [PATCH 15/21] drm/rcar-du: Use GEM CMA object functions

2020-05-22 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Fri, May 22, 2020 at 03:52:40PM +0200, Thomas Zimmermann wrote: > The rcar-du driver uses the default implementation for CMA functions; > except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro > now sets these defaults and .dumb_create in

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Laurent Pinchart
Hello, On Fri, May 22, 2020 at 07:48:35PM +0200, Sam Ravnborg wrote: > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > > helpers. > > This part is fine, I like that the naming is somehow consistent. > > > An

Re: [PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions

2020-05-22 Thread Sam Ravnborg
Hi Thomas. On Fri, May 22, 2020 at 03:52:30PM +0200, Thomas Zimmermann wrote: > The atmel-hlcdc driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object

Re: [PATCH 21/21] drm/zte: Use GEM CMA object functions

2020-05-22 Thread Sam Ravnborg
Hi Thomas. On Fri, May 22, 2020 at 03:52:46PM +0200, Thomas Zimmermann wrote: > The zte driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object functions. >

Re: [PATCH v2] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-22 Thread Emil Velikov
Hi Rikard, On 2020/05/19, Rikard Falkeborn wrote: > + Andrew et al who recieved mail from the build robot this morning about > the same issue. > > On Tue, May 19, 2020 at 10:14:52PM +0100, Emil Velikov wrote: > > Recently the GENMASK_INPUT_CHECK() was added, aiming to catch cases > > where

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Sam Ravnborg
Hi Emil. > > Please fix zte/zx_drm_drv.c which also uses DRM_GEM_CMA_VMAP_DRIVER_OPS. > > > Isn't DRM_GEM_CMA_VMAP_DRIVER_OPS introduced to zte with the last > patch in the series? You are right, I just applied all patches and throw them after my build script and zte failed. Sam

Re: [PATCH 00/21] drm: Convert most CMA-based drivers to GEM object functions

2020-05-22 Thread Emil Velikov
Hi Thomas, On Fri, 22 May 2020 at 14:53, Thomas Zimmermann wrote: > 32 files changed, 52 insertions(+), 226 deletions(-) > We need more diffstat like this. With this series the .gem_print_info is no longer set. Feel free to follow-up and nuke it, alongside the glue in drm_gem.c. There's a

Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

2020-05-22 Thread Lyude Paul
On Thu, 2020-05-21 at 23:09 +0200, Sam Ravnborg wrote: > On Thu, May 21, 2020 at 04:46:47PM -0400, Lyude Paul wrote: > > On some architectures like ppc64le and aarch64, compiling with > > -Wformat=1 will throw the following warnings: > > > > In file included from

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Emil Velikov
On Fri, 22 May 2020 at 18:48, Sam Ravnborg wrote: > > Hi Thomas. > > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > > helpers. > This part is fine, I like that the naming is somehow consistent. > > > An

Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions

2020-05-22 Thread Emil Velikov
Hi Thomas, On Fri, 22 May 2020 at 14:53, Thomas Zimmermann wrote: > > The kirin driver uses the default implementation for CMA functions; except > for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets > these defaults and .dumb_create in struct drm_driver. All remaining >

Re: [PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions

2020-05-22 Thread Sam Ravnborg
Hi Thomas. On Fri, May 22, 2020 at 03:52:30PM +0200, Thomas Zimmermann wrote: > The atmel-hlcdc driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object

Re: [PATCH] drm/[radeon|amdgpu]: Replace one-element array and use struct_size() helper

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 1:39 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > form: > > struct something { > int length; > u8 data[1]; > }; > > struct something *instance; > > instance = kmalloc(sizeof(*instance) + size,

Re: [PATCH v2] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 1:29 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > form: > > struct something { > int length; > u8 data[1]; > }; > > struct something *instance; > > instance = kmalloc(sizeof(*instance) + size,

Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 1:46 PM Gustavo A. R. Silva wrote: > > On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote: > > > > > > Signed-off-by: Gustavo A. R. Silva > > > > Acked-by: Christian König > > > > May I suggest that we add a section how to correctly do this to > >

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Sam Ravnborg
Hi Thomas. On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > helpers. This part is fine, I like that the naming is somehow consistent. > An internal version is provided for drivers that override > the default

Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

2020-05-22 Thread Gustavo A. R. Silva
On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote: > > > > Signed-off-by: Gustavo A. R. Silva > > Acked-by: Christian König > > May I suggest that we add a section how to correctly do this to > Documentation/process/coding-style.rst or similar document? > That's already on my

[PATCH] drm/[radeon|amdgpu]: Replace one-element array and use struct_size() helper

2020-05-22 Thread Gustavo A. R. Silva
The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; memcpy(instance->data, source, size); but the

[PATCH v2] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Gustavo A. R. Silva
The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size; memcpy(instance->data, source, size); but the

Re: [PATCH] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Gustavo A. R. Silva
On Fri, May 22, 2020 at 09:00:09AM +0200, Christian König wrote: > > +++ b/drivers/gpu/drm/radeon/ni_dpm.c > > @@ -2685,11 +2685,12 @@ static int ni_upload_sw_state(struct radeon_device > > *rdev, > > struct rv7xx_power_info *pi = rv770_get_pi(rdev); > > u16 address =

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-22 Thread Mark Brown
On Fri, May 22, 2020 at 11:59:25PM +0800, dillon min wrote: > but, after spi-core create a dummy tx_buf or rx_buf, then i can't get > the correct spi_3wire direction. > actually, this dummy tx_buf is useless for SPI_3WIRE. it's has meaning > for SPI_SIMPLE_RX mode, > simulate SPI_FULL_DUMPLEX

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-22 Thread Matthias Brugger
On 20/05/2020 07:46, Dave Airlie wrote: > On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: >> >> On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: >>> >>> Hi, Dave & Daniel: >>> >>> This include dpi pin mode swap, config mipi_tx current and impedance, >>> and some fixup. I drop drm_bridge

[PATCH] drm/panfrost: Fix inbalance of devfreq record_busy/idle()

2020-05-22 Thread Steven Price
The calls to panfrost_devfreq_record_busy() and panfrost_devfreq_record_idle() must be balanced to ensure that the devfreq utilisation is correctly reported. But there are two cases where this doesn't work correctly. In panfrost_job_hw_submit() if pm_runtime_get_sync() fails or the WARN_ON()

[PATCH AUTOSEL 5.4 14/32] drm/amd/powerplay: perform PG ungate prior to CG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit f4fcfa4282c1a1bf51475ebb0ffda623eebf1191 ] Since gfxoff should be disabled first before trying to access those GC registers. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 35/41] drm/meson: pm resume add return errno branch

2020-05-22 Thread Sasha Levin
From: Bernard Zhao [ Upstream commit c54a8f1f329197d83d941ad84c4aa38bf282cbbd ] pm_resump api did not handle drm_mode_config_helper_resume error. This change add handle to return drm_mode_config_helper_resume`s error number. This code logic is aligned with api pm_suspend. After this change, the

[PATCH AUTOSEL 5.4 15/32] drm/amdgpu: Use GEM obj reference for KFD BOs

2020-05-22 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 39b3128d7ffd44e400e581e6f49e88cb42bef9a1 ] Releasing the AMDGPU BO ref directly leads to problems when BOs were exported as DMA bufs. Releasing the GEM reference makes sure that the AMDGPU/TTM BO is not freed too early. Also take a GEM reference when

[PATCH AUTOSEL 5.4 13/32] drm/amdgpu: drop unnecessary cancel_delayed_work_sync on PG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 1fe48ec08d9f2e26d893a6c05bd6c99a3490f9ef ] As this is already properly handled in amdgpu_gfx_off_ctrl(). In fact, this unnecessary cancel_delayed_work_sync may leave a small time window for race condition and is dangerous. Signed-off-by: Evan Quan

[PATCH AUTOSEL 5.6 26/41] drm/amd/amdgpu: Update update_config() logic

2020-05-22 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit 650e723cecf2738dee828564396f3239829aba83 ] [Why] For MST case: when update_config is called to disable a stream, this clears the settings for all the streams on that link. We should only clear the settings for the stream that was disabled. [How]

[PATCH AUTOSEL 5.6 19/41] drm/amdgpu: Use GEM obj reference for KFD BOs

2020-05-22 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 39b3128d7ffd44e400e581e6f49e88cb42bef9a1 ] Releasing the AMDGPU BO ref directly leads to problems when BOs were exported as DMA bufs. Releasing the GEM reference makes sure that the AMDGPU/TTM BO is not freed too early. Also take a GEM reference when

[PATCH AUTOSEL 5.6 18/41] drm/amd/powerplay: perform PG ungate prior to CG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit f4fcfa4282c1a1bf51475ebb0ffda623eebf1191 ] Since gfxoff should be disabled first before trying to access those GC registers. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 17/41] drm/amdgpu: drop unnecessary cancel_delayed_work_sync on PG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 1fe48ec08d9f2e26d893a6c05bd6c99a3490f9ef ] As this is already properly handled in amdgpu_gfx_off_ctrl(). In fact, this unnecessary cancel_delayed_work_sync may leave a small time window for race condition and is dangerous. Signed-off-by: Evan Quan

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 6:41 AM Christian König wrote: > > Am 20.05.20 um 18:18 schrieb Alex Deucher: > > On Wed, May 20, 2020 at 10:43 AM Christian König > > wrote: > >> Am 13.05.20 um 13:03 schrieb Christian König: > >>> Unfortunately AGP is still to widely used as we could just drop support

[PATCH 18/21] drm/sti: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The sti driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sti/sti_drv.c | 12

[PATCH 16/21] drm/shmobile: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The shmobile driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/shmobile/shmob_drm_drv.c

[PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The mcde driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mcde/mcde_drv.c | 12

[PATCH 20/21] drm/tv200: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The tve200 driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 12

[PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The kirin driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Thomas Zimmermann
Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM helpers. An internal version is provided for drivers that override the default .dumb_create callback. Adapt drivers to the changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-

[PATCH 21/21] drm/zte: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The zte driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/zte/zx_drm_drv.c | 11

[PATCH 09/21] drm/ingenic: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The ingenic driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ingenic/ingenic-drm.c | 13

[PATCH 15/21] drm/rcar-du: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The rcar-du driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 11/21] drm/malidp: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The malidp driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 19/21] drm/tilcdc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The tilcdc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13

[PATCH 08/21] drm/imx: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The imx driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/imx/imx-drm-core.c | 12

[PATCH 14/21] drm/mxsfb: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The mxsfb driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11

[PATCH 02/21] drm/arc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The arc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arc/arcpgu_drv.c | 12

[PATCH 03/21] drm/arm: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The arm driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arm/hdlcd_drv.c | 12

[PATCH 17/21] drm/stm: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The stm driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 06/21] drm/fsl-dcu: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The fsl-dcu driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

[PATCH 00/21] drm: Convert most CMA-based drivers to GEM object functions

2020-05-22 Thread Thomas Zimmermann
Most of the CMA-based drivers use the default implementation for the callbacks in struct drm_driver. With this patch, these interfaces are initialized with a common helper macro and GEM object functions replace several deprecated interfaces. The first patch updates the existing macro to similar

[PATCH 10/21] drm/komeda: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The komeda driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 13/21] drm/meson: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The meson driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 04/21] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-05-22 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The atmel-hlcdc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann ---

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Mark Brown
On Thu, May 21, 2020 at 07:30:04PM +0800, Shengjiu Wang wrote: > On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > Other drivers having problems means those drivers should be fixed, not > > that we should copy the problems. In the case of the PXA driver that's > > very old code which

Re: [PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-22 Thread Steven Price
On 21/05/2020 08:00, dinghao@zju.edu.cn wrote: Hi Steve, There are two bailing out points in panfrost_job_hw_submit(): one is the error path beginning from pm_runtime_get_sync(), the other one is the error path beginning from WARN_ON() in the if statement. The pm imbalance fixed in this

Re: [PATCH] drm/tegra: hub: Do not enable orphaned window group

2020-05-22 Thread Thierry Reding
On Tue, May 19, 2020 at 02:03:01AM -0700, Nicolin Chen wrote: > Though the unconditional enable/disable code is not a final solution, > we don't want to run into a NULL pointer situation when window group > doesn't link to its DC parent if the DC is disabled in Device Tree. > > So this patch

[PATCH v5 39/38] drm: xen: fix common struct sg_table related issues

2020-05-22 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

[Bug 206475] amdgpu under load drop signal to monitor until hard reset

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206475 andrewammerl...@riseup.net (andrewammerl...@riseup.net) changed: What|Removed |Added CC|

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-22 Thread Mark Brown
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.min...@gmail.com wrote: > 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is > null, we must add dummy data sent out before read data. > so, add stm32f4_spi_tx_dummy() to handle this situation. There are flags

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
[resending as plain text, sorry about that] Thanks Daniel, more below. From: Daniel Vetter Sent: Wednesday, May 20, 2020 12:41 AM To: Steve Pronovost Cc: Dave Airlie ; Sasha Levin ;

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
>Echoing what others said, you're not making a DRM driver. The driver should >live outside of the DRM code. Agreed, please see my earlier reply. We'll be moving the driver to drivers/hyperv node or something similar. Apology for the confusion here. > I have one question about the driver API:

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
Thanks Daniel, more below. From: Daniel Vetter Sent: Wednesday, May 20, 2020 12:41 AM To: Steve Pronovost Cc: Dave Airlie ; Sasha Levin ; linux-hyp...@vger.kernel.org; Stephen Hemminger ; Ursulin, Tvrtko ; Greg Kroah-Hartman ; Haiyang Zhang ; LKML ; dri-devel ; Chris Wilson ; Linux Fbdev

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Michel Dänzer
On 2020-05-22 12:40 p.m., Christian König wrote: > Am 20.05.20 um 18:25 schrieb Michel Dänzer: >> On 2020-05-20 4:43 p.m., Christian König wrote: >>> Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART.

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Christian König
Am 20.05.20 um 18:18 schrieb Alex Deucher: On Wed, May 20, 2020 at 10:43 AM Christian König wrote: Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Christian König
Am 20.05.20 um 18:25 schrieb Michel Dänzer: On 2020-05-20 4:43 p.m., Christian König wrote: Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in

[PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-22 Thread Jitao Shi
If panel has too small hfp or hbp, horizontal_frontporch_byte or horizontal_backporch_byte may become very small value or negative value. This patch adjusts their values so that they are greater than minimum value and keep total of them unchanged. Signed-off-by: Jitao Shi ---

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-22 Thread Pekka Paalanen
On Wed, 20 May 2020 16:19:00 +0200 Daniel Vetter wrote: > On Wed, May 20, 2020 at 3:20 PM Simon Ser wrote: > > > > On Wednesday, May 20, 2020 2:55 PM, Daniel Vetter wrote: > > > > > Maybe we should add an explicit note that there's no guarantee about the > > > new chardev minor this new

Re: [PATCH] drm: rcar-du: Fix build error

2020-05-22 Thread Kieran Bingham
Hi Daniel, On 18/05/2020 21:16, Daniel Gomez wrote: > Select DRM_KMS_HELPER dependency. > > Build error when DRM_KMS_HELPER is not selected: > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to > `drm_atomic_helper_bridge_duplicate_state' >

Re: [PATCH] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Christian König
Am 22.05.20 um 03:25 schrieb Gustavo A. R. Silva: The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size;

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-22 Thread Jeffrey Hugo
On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-22 Thread Lubomir Rintel
On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin wrote: > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > > admin: > > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach

[Bug Report] drivers/video/fbdev/da8xx-fb.c: undefined behavior when left shifting

2020-05-22 Thread Changming Liu
Hi Bartlomiej, Greetings, it's me again, I sent you a bug report yesterday, I hope that find you well. This time I found that in /drivers/video/fbdev/da8xx-fb.c function lcd_cfg_vertical_sync, there might be an undefined result by left shifting. More specifically, in function

[PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/panfrost/panfrost_job.c | 4 +++- 1 file changed, 3

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > enables when vaddr is not in the fixmap. > > > > Fixes:

[PATCH] drm/nouveau/debugfs: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 5 - 1 file changed, 4

[PATCH v2 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-22 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Jan Engelhardt
On Tuesday 2020-05-19 22:36, Sasha Levin wrote: > >> - Why DX12 on linux? Looking at this feels like classic divide and > > There is a single usecase for this: WSL2 developer who wants to run > machine learning on his GPU. The developer is working on his laptop, > which is running Windows and

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Shengjiu Wang
On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > > > I see some driver also request dma channel in open() or hw_params(). > > how can they avoid the defer probe issue? > > for example: > > sound/arm/pxa2xx-pcm-lib.c > >

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-22 Thread Jeffrey Hugo
On 5/20/2020 9:59 AM, Greg Kroah-Hartman wrote: On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote: On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19,

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/21/20 10:42 AM, Ira Weiny wrote: > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: >> On 5/19/20 10:13 PM, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19,

[PATCH] drm/nouveau: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++- 1 file changed, 3

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/21/20 5:46 PM, Al Viro wrote: > On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: >> On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: >>> On 5/21/20 10:27 AM, Al Viro wrote: On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Rui Salvaterra
Hi, Christian, On Wed, 20 May 2020 at 16:00, Christian König wrote: > > So I've used an ancient system (32bit) to setup a test box for this. > > > The first GPU I could test is an RV280 (Radeon 9200 PRO) which is easily > 15 years old. Oh, I have one of those in box somewhere, but no AGP

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: > > On 5/21/20 10:27 AM, Al Viro wrote: > > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > >> On Mon, May 18, 2020 at 11:48:43AM -0700,

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > Mainline, with: > > > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > > -snapshot -drive file=rootfs.ext2,format=raw,if=scsi \ > >

[PATCH 0/2] add generic DT binding for RTS/CTS

2020-05-22 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Erwan Le Ray (2): dt-bindings: serial: add generic DT binding for announcing RTS/CTS

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Shengjiu Wang
Hi On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > There are two requirements that we need to move the request > > of dma channel from probe to open. > > How do you handle -EPROBE_DEFER return code from the channel

  1   2   >