Re: [BUG] fbdev: sm712fb: Page fault in smtcfb_read

2022-02-26 Thread Zheyu Ma
On Sat, Feb 26, 2022 at 11:03 PM Helge Deller wrote: > > * Zheyu Ma : > > I found a minor in the smtcfb_read() function of the driver sm712fb. > > > > This read function can not handle the case that the size of the > > buffer is 3 and does not check for it, which may cause a page fault. > > > >

[GIT PULL] mediatek drm next for 5.18

2022-02-26 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Transfer display binding document to yaml format. 2. Add mt8195 display device binding. 3. Allow commands to be sent during video mode. 4. Add wait_for_event for crtc disable by cmdq. Regards, Chun-Kuang. The following changes since commit

Re: [PATCH v4 1/2] drm/mediatek: add wait_for_event for crtc disable by cmdq

2022-02-26 Thread Chun-Kuang Hu
Hi, Jason: Chun-Kuang Hu 於 2021年12月3日 週五 上午7:21寫道: > > Hi, Jason: > > jason-jh.lin 於 2021年12月2日 週四 下午2:41寫道: > > > > mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, > > so it may not finish when cmdq_suspend is called sometimes. > > > > Add wait_for_event after sending async

Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

2022-02-26 Thread Chun-Kuang Hu
Hi, Jason: Build error: ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c: In function ‘mtk_drm_crtc_create’: ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:902:26: error: ‘struct mtk_drm_private’ has no member named ‘dev’ mtk_crtc->drm_dev = priv->dev; ^

Re: [PATCH] drm/msm/dpu: Use indexed array initializer to prevent mismatches

2022-02-26 Thread Dmitry Baryshkov
On 26/02/2022 22:46, Marijn Suijten wrote: While there's a comment pointing from dpu_intr_set to dpu_hw_intr_reg and vice-versa, an array initializer using indices makes it so that the indices between the enum and array cannot possibly get out of sync even if they're accidentially ordered

RE: [PATCH] drm/amdgpu: Fix realloc of ptr

2022-02-26 Thread David Laight
From: t...@redhat.com > Sent: 26 February 2022 15:59 > > From: Tom Rix > > Clang static analysis reports this error > amdgpu_debugfs.c:1690:9: warning: 1st function call > argument is an uninitialized value > tmp = krealloc_array(tmp, i + 1, > ^~~ > >

[PATCH] drm/msm/dpu: Use indexed array initializer to prevent mismatches

2022-02-26 Thread Marijn Suijten
While there's a comment pointing from dpu_intr_set to dpu_hw_intr_reg and vice-versa, an array initializer using indices makes it so that the indices between the enum and array cannot possibly get out of sync even if they're accidentially ordered wrongly. It is still useful to keep the comment to

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-26 Thread Rob Clark
On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Jani, > > > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: > >> > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj

[PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-26 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Note that there is no hpd-gpio installed

[PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-26 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git

[PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-02-26 Thread H. Nikolaus Schaller
Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connectors and bridges which is to be used e.g. for the jz4780 based CI20 board. In this case dw-hdmi sets up a list of formats in

[PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support

2022-02-26 Thread H. Nikolaus Schaller
"hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HPD. This was not reflected in code. Now, the driver activates the ddc gpio after probe

[PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI

2022-02-26 Thread H. Nikolaus Schaller
PATCH V16 2022-02-26 18:13:02: * fixed and renamed dw-hdmi bus negotiation patch (by narmstr...@baylibre.com) * reordered and merged HPD fix (suggested by p...@crapouillou.net) * fixed MODULE_ALIAS for dw-hdmi-ingenic (reported by p...@crapouillou.net) * dropped some already merged commits from

Re: [PATCH v15 4/7] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-26 Thread H. Nikolaus Schaller
Hi Neil, > Am 21.02.2022 um 09:11 schrieb Neil Armstrong : > > Hi, > > On 12/02/2022 16:50, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to negotiate bus formats between hdmi connector >>

[PATCH] drm/amdgpu: Fix realloc of ptr

2022-02-26 Thread trix
From: Tom Rix Clang static analysis reports this error amdgpu_debugfs.c:1690:9: warning: 1st function call argument is an uninitialized value tmp = krealloc_array(tmp, i + 1, ^~~ realloc will free tmp, so tmp can not be garbage. And the return needs to be

Re: [BUG] fbdev: sm712fb: Page fault in smtcfb_read

2022-02-26 Thread Helge Deller
* Zheyu Ma : > I found a minor in the smtcfb_read() function of the driver sm712fb. > > This read function can not handle the case that the size of the > buffer is 3 and does not check for it, which may cause a page fault. > > The following log reveals it: > > [ 2432.614490] BUG: unable to handle

[BUG] fbdev: sm712fb: Page fault in smtcfb_read

2022-02-26 Thread Zheyu Ma
I found a minor in the smtcfb_read() function of the driver sm712fb. This read function can not handle the case that the size of the buffer is 3 and does not check for it, which may cause a page fault. Here is a simple PoC: #include #include #include #include #include #include #include

[BUG] fbdev: sm712fb: Page fault in smtcfb_write()

2022-02-26 Thread Zheyu Ma
Hi, I found a minor in the smtcfb_write() function of the driver sm712fb. This write function can not handle the case that the size of the buffer is 3 and does not check for it, which may cause a page fault. Here is a simple PoC: #include #include #include #include #include #include

Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP

2022-02-26 Thread Luca Weiss
Hi, any feedback on this patch? On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation > fails: > > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' > > Add a dependency

[PATCH] gpu/amd: vega10_hwmgr: fix inappropriate private variable name

2022-02-26 Thread Meng Tang
In file vega10_hwmgr.c, the names of struct vega10_power_state * and struct pp_power_state * are confusingly used, which may lead to some confusion. Status quo is that variables of type struct vega10_power_state * are named "vega10_ps", "ps", "vega10_power_state". A more appropriate usage is that

Re: [PATCH] drm/exynos: fimd: add BGR support for exynos4/5

2022-02-26 Thread Martin Jücker
Hello Inki, On Fri, Feb 25, 2022 at 12:52:56PM +0900, Inki Dae wrote: > Hi Martin, > > 22. 2. 25. 08:27에 Martin Jücker 이(가) 쓴 글: > > Hello Inki, > > > > On Thu, Feb 24, 2022 at 10:41:04AM +0900, Inki Dae wrote: > >> Hi Martin. > >> > >> I found that exynos4 and 5 data sheet include documented

[PATCH v7 00/13] Add GuC Error Capture Support

2022-02-26 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global,