RE: [PATCH v2 4/7] vfio/mdev: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-23 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Saturday, April 23, 2022 2:00 AM > > On Fri, Apr 22, 2022 at 01:50:00AM +, Tian, Kevin wrote: > > > From: Jason Gunthorpe > > > Sent: Friday, April 22, 2022 12:29 AM > > > > > > Every caller has a readily available vfio_device pointer, use that instead > > >

[PATCH v2] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print rc, and return -EINVAL rather

[PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print irq, and return ERR_PTR(-EINVAL) --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++--- 1 file changed, 3

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-23 Thread Guenter Roeck
On 4/23/22 12:55, Arnd Bergmann wrote: On Sat, Apr 23, 2022 at 1:41 AM Guenter Roeck wrote: On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: On Fri, Apr 22, 2022 at 10:55 PM Guenter Roeck wrote: On 4/22/22 12:16, Arnd Bergmann wrote: On Fri, Apr 22, 2022 at 7:05 PM Guenter

Re: [PATCH v5 7/9] drm: vkms: Supports to the case where primary plane doesn't match the CRTC

2022-04-23 Thread Igor Torrente
Hi Pekka, On 4/20/22 10:13, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:13 -0300 Igor Torrente wrote: We will break the current assumption that the primary plane has the Hi, I'd say "remove" rather than "break". Breaking sounds bad but this is good. :-) Yeah, sure. :) same size

[PATCH] drm/radeon: change cac_weights_* to static

2022-04-23 Thread Tom Rix
Sparse reports these issues si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. Should it be static? si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. Should it be static? Both of these variables are only used in si_dpm.c. Single file variables

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-23 Thread Arnd Bergmann
On Sat, Apr 23, 2022 at 1:41 AM Guenter Roeck wrote: > > On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: > > On Fri, Apr 22, 2022 at 10:55 PM Guenter Roeck wrote: > > > On 4/22/22 12:16, Arnd Bergmann wrote: > > > > On Fri, Apr 22, 2022 at 7:05 PM Guenter Roeck > > > > wrote: >

Re: [PATCH] drm/panel: simple: Add missing bus flags for Innolux G070Y2-L01

2022-04-23 Thread Sam Ravnborg
On Wed, Apr 06, 2022 at 11:36:27AM +0200, Marek Vasut wrote: > The DE signal is active high on this display, fill in the missing bus_flags. > This aligns panel_desc with its display_timing . > > Fixes: a5d2ade627dca ("drm/panel: simple: Add support for Innolux G070Y2-L01") > Signed-off-by: Marek

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-23 Thread Igor Torrente
I forgot to respond some points from your review. On 4/23/22 13:04, Igor Torrente wrote: Hi Pekka, On 4/20/22 09:36, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:12 -0300 Igor Torrente wrote: Currently the blend function only accepts XRGB_ and ARGB_ as a color input. This patch

Re: [git pull] drm fixes for 5.18-rc4 (part 2)

2022-04-23 Thread pr-tracker-bot
The pull request you sent on Sat, 23 Apr 2022 15:18:43 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-04-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/13bc32bad7059d6c5671e9d037e6e3ed001cc0f4 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-23 Thread Igor Torrente
Hi Pekka, On 4/20/22 09:36, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:12 -0300 Igor Torrente wrote: Currently the blend function only accepts XRGB_ and ARGB_ as a color input. This patch refactors all the functions related to the plane composition to overcome this limitation.

Re: [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-23 Thread Abhinav Kumar
On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote: On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar wrote: On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: On 23/04/2022 02:45, Kuogee Hsieh wrote: Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected

Re: [PATCH v5 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-04-23 Thread Igor Torrente
Hi Pekka, On 4/20/22 08:23, Pekka Paalanen wrote: On Mon, 4 Apr 2022 17:45:11 -0300 Igor Torrente wrote: This commit is the groundwork to introduce new formats to the planes and writeback buffer. As part of it, a new buffer metadata field is added to `vkms_writeback_job`, this metadata is

[PATCH] drm/kmb: remove layer_irqs variable

2022-04-23 Thread Tom Rix
Sparse reports these issues kmb_plane.c:21:11: warning: symbol 'layer_irqs' was not declared. Should it be static? layer_irq in not used, so remove it. Signed-off-by: Tom Rix --- drivers/gpu/drm/kmb/kmb_plane.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH AUTOSEL 5.4 11/14] drm/msm: Stop using iommu_present()

2022-04-23 Thread Sasha Levin
On Tue, Apr 19, 2022 at 11:53:23AM -0700, Rob Clark wrote: You might want to drop this one, it seems to be causing some issues on older generations.. I'll be sending another PR shortly with a revert. https://patchwork.freedesktop.org/patch/482453 Dropped, thanks! -- Thanks, Sasha

Re: [PATCH] fbcon: change fbcon_*registered_fb variables to static

2022-04-23 Thread Sam Ravnborg
On Sat, Apr 23, 2022 at 08:56:18AM -0400, Tom Rix wrote: > Sparse reports these issues > fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. > Should it be static? > fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. > Should it be static? > > These

[PATCH] drm/radeon: change cik_default_state table from global to static

2022-04-23 Thread Tom Rix
Sparse reports these issues cik_blit_shaders.c:31:11: warning: symbol 'cik_default_state' was not declared. Should it be static? cik_blit_shaders.c:246:11: warning: symbol 'cik_default_size' was not declared. Should it be static? cik_default_state and cik_default_size are only used in cik.c.

[PATCH] fbcon: change fbcon_*registered_fb variables to static

2022-04-23 Thread Tom Rix
Sparse reports these issues fbcon.c:106:16: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static? fbcon.c:107:5: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static? These variables are only used in fbcon.c. Single file use variables should be

Re: [PATCH v2 3/7] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

2022-04-23 Thread Jason Gunthorpe
On Sat, Apr 23, 2022 at 07:15:52AM +0200, Christoph Hellwig wrote: > On Fri, Apr 22, 2022 at 05:56:51PM -0300, Jason Gunthorpe wrote: > > On Fri, Apr 22, 2022 at 08:22:32AM +0200, Christoph Hellwig wrote: > > > Nit: why do some of these patches that don't touch the mdev code > > > mdev in the

[PATCH] drm: rcar-du: Add setting to PnALPHAR register on Gen3

2022-04-23 Thread Biju Das
From: LUU HOAI In Gen3, when Alpha blend is enabled in the PnMR register, depending on the initial value of the PnALPHAR register, either channel of DU might be black screen. Therefore, this patch prevents the black screen by setting the PnALPHAR register to all 0. In addition, PnALPHAR

Re: [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-23 Thread Dmitry Baryshkov
On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar wrote: > > > > On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: > > On 23/04/2022 02:45, Kuogee Hsieh wrote: > >> Current DP driver implementation has adding safe mode done at > >> dp_hpd_plug_handle() which is expected to be executed under event > >>