Re: [PATCH] amd/display/dc:remove repeating expression

2023-06-13 Thread Ammar Faizi
On 6/14/23 10:49 AM, Wang Ming wrote: Identify issues that arise by using the tests/doubletest.cocci semantic patch.Need to remove duplicate expression in if statement. Signed-off-by: Wang Ming Reviewed-by: Ammar Faizi -- Ammar Faizi

Re: [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Thomas Zimmermann
Hi Am 14.06.23 um 04:06 schrieb Sui Jingfeng: On 2023/6/14 01:27, Sui Jingfeng wrote: Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the

Re: [PATCH] drm/fbdev-generic: Remove a redundant assignment clause

2023-06-13 Thread Thomas Zimmermann
Hi Am 14.06.23 um 03:30 schrieb Sui Jingfeng: The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() function is redundant because it has already been copied when the call to drm_client_buffer_vmap() is finished. Therefore, this patch saves a useless copy. No functional change.

Re: [PATCH v4 5/8] drm/mediatek: hdmi: add v2 support

2023-06-13 Thread 胡俊光

Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-13 Thread Hugh Dickins
On Tue, 13 Jun 2023, David Hildenbrand wrote: > On 13.06.23 10:26, Kasireddy, Vivek wrote: > >> On 12.06.23 09:10, Kasireddy, Vivek wrote: > >>> Sorry for the late reply; I just got back from vacation. > >>> If it is unsafe to directly use the subpages of a hugetlb page, then > >>> reverting > >>>

[PATCH v9 6/9] drm/etnaviv: Add driver support for the PCI devices

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng This patch adds PCI driver support on top of what we already have. Take the GC1000 in LS7A1000/LS2K1000 as the first instance of the PCI device driver. There is only one GPU core for the GC1000 in the LS7A1000 and LS2K1000. Therefore, component frameworks can be avoided. Cc:

[PATCH v9 9/9] drm/etnaviv: Clean up etnaviv_pdev_probe() function

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Add a dedicate function to do the DMA configuration to the virtual master. Also replace the >dev with dev. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 65 +++ 1 file changed, 36 insertions(+), 29 deletions(-) diff --git

[PATCH v9 5/9] drm/etnaviv: Allow bypass component framework

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Adding additional code path to allow bypass component frameworks, A platform with a single GPU core could probably try the non-component code path. This patch is for code sharing, no functional change. Cc: Lucas Stach Cc: Christian Gmeiner Cc: Philipp Zabel Cc: Bjorn

[PATCH v9 8/9] drm/etnaviv: Add a dedicated function to create the virtual master

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng After introducing the etnaviv_of_first_available_node() helper, the creation of the virtual master platform device can also be simplified. So, switch to etnaviv_create_virtual_master() function. Cc: Lucas Stach Cc: Christian Gmeiner Cc: Philipp Zabel Cc: Bjorn Helgaas Cc:

[PATCH v9 3/9] drm/etnaviv: Add dedicated functions to create and destroy platform device

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Also rename the virtual master platform device as etnaviv_platform_device, for better reflection that it is a platform device, not a DRM device. Another benefit is that we no longer need to call of_node_put() for three different cases, Instead, we only need to call it once.

[PATCH v9 4/9] drm/etnaviv: Add helpers for private data construction and destruction

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng struct etnaviv_drm_private contains a lot of common resources that are shared by all GPUs. This patch introduces two dedicated functions, which is for the construction and destruction of instances of this structure.      The idea is to avoid leaking its members outside. The

[PATCH v9 2/9] drm/etnaviv: Add a dedicated function to get various clocks

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Because it is also platform-dependent, there are environments where don't have CLK subsystem support, for example, discreted PCI GPUs. So don't rage quit if there is no CLK subsystem support. For the GPU in LS7A1000 and LS2K1000, the working frequency of the GPU is tuned by

[PATCH v9 7/9] drm/etnaviv: Add support for the dma coherent device

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Loongson CPUs maintain cache coherency by hardware, which means that the data in the CPU cache is identical to the data in main system memory. As for the peripheral device, most of Loongson chips chose to define the peripherals as DMA coherent by default, device drivers do not

[PATCH v9 0/9] drm/etnaviv: Add pci device driver support

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng There is a Vivante GC1000 (v5037) in LS2K1000 and LS7A1000, this GPU is a PCI device, and it has 2D and 3D cores in the same core. This series is trying to add PCI device driver support to etnaviv. v6: * Fix build issue on system without CONFIG_PCI enabled v7:

[PATCH v9 1/9] drm/etnaviv: Add a dedicated function to register an irq handler

2023-06-13 Thread Sui Jingfeng
From: Sui Jingfeng Because getting IRQ from a device is platform-dependent, PCI devices have different methods for getting an IRQ. This patch is a preparation patch to extend the driver for the PCI device support. Cc: Lucas Stach Cc: Christian Gmeiner Cc: Philipp Zabel Cc: Bjorn Helgaas Cc:

Re: [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-13 Thread Dixit, Ashutosh
On Fri, 09 Jun 2023 15:02:52 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > We were skipping when min_softlimit was equal to RPn. We need to apply > it rergardless as efficient frequency will push the SLPC min to RPe. regardless > This will break scenarios where user sets a min softlimit < RPe

Re: [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Sui Jingfeng
On 2023/6/14 01:27, Sui Jingfeng wrote: Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the code and resolves a long-standing TODO item.

[PATCH] drm/amdkfd: Switch over to memdup_user()

2023-06-13 Thread Jiapeng Chong
Use memdup_user() rather than duplicating its implementation. This is a little bit restricted to reduce false positives. ./drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c:2813:13-20: WARNING opportunity for memdup_user. Reported-by: Abaci Robot Closes:

[PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode

2023-06-13 Thread Jessica Zhang
DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send 48 bits of compressed data per pclk instead of 24. For all chipsets that support this mode, enable it whenever DSC is enabled as recommend by the hardware programming guide. Only enable this for command mode as we are

[PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-13 Thread Jessica Zhang
Add a DPU INTF op to set the DATABUS_WIDEN register to enable the databus-widen mode datapath. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12

[PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-13 Thread Jessica Zhang
DPU 5.x+ supports a databus widen mode that allows more data to be sent per pclk. Enable this feature flag on all relevant chipsets. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ 2 files changed, 4

[PATCH 0/3] Add support for databus widen mode

2023-06-13 Thread Jessica Zhang
DPU 5.x+ and DSI 6G 2.5.x+ support a databus-widen mode that allows for more compressed data to be transferred per pclk. This series adds support for enabling this feature for both DPU and DSI by doing the following: 1. Add a DPU_INTF_DATABUS_WIDEN feature flag 2. Add a DPU INTF op to set the

[PATCH] drm/fbdev-generic: Remove a redundant assignment clause

2023-06-13 Thread Sui Jingfeng
The assignment "dst = map;" in the drm_fbdev_generic_damage_blit() function is redundant because it has already been copied when the call to drm_client_buffer_vmap() is finished. Therefore, this patch saves a useless copy. No functional change. Signed-off-by: Sui Jingfeng ---

Re: [PATCH drm-next v4 14/14] drm/nouveau: debugfs: implement DRM GPU VA debugfs

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Provide the driver indirection iterating over all DRM GPU VA spaces to > enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces. > > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39

Re: [PATCH drm-next v4 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to request

Re: [PATCH v2 05/22] drm/msm/dpu: always use MSM_DP/DSI_CONTROLLER_n

2023-06-13 Thread Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: In several catalog entries we did not use existing MSM_DP_CONTROLLER_n constants. Fill them in. Also use freshly defined MSM_DSI_CONTROLLER_n for DSI interfaces. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 2/2] drm/msm/dpu: remove struct drm_dsc_config from struct msm_display_info

2023-06-13 Thread Abhinav Kumar
On 6/13/2023 3:19 PM, Kuogee Hsieh wrote: ince struct drm_dsc_config is stored at atomic_enable() instead S got cut off in since of display setup time during boot up, saving struct drm_dsc_config at struct msm_display_info is not necessary. Lets drop the dsc member from struct

Re: [PATCH v3 0/2] retrieve DSI DSC through priv-dsi[0]

2023-06-13 Thread Abhinav Kumar
On 6/13/2023 3:19 PM, Kuogee Hsieh wrote: moving retrieving struct drm_dsc_cofnig from setup_display to atomic_enable() and delete struct drm_dsc_config from struct msm_display_info. This needs re-wording. Currently, struct drm_dsc_config is retrieved from DSI driver in

Re: [PATCH v5] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-13 Thread Lyude Paul
Alright, managed to figure out my MST woes! Just tested with nouveau and I see no regressions :) Reviewed-by: Lyude Paul On Fri, 2023-06-09 at 18:49 +0800, Wayne Lin wrote: > [Why] > The sequence for collecting down_reply from source perspective should > be: > > Request_n->repeat (get partial

Re: [PATCH v4 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS

2023-06-13 Thread Bjorn Andersson
On Tue, 13 Jun 2023 09:30:11 +0200, Neil Armstrong wrote: > The DP output is shared with the USB3 SuperSpeed lanes and is > usually connected to an USB-C port which Altmode is controlled > by the PMIC Glink infrastructure. > > DT changes tying the DP controller to the USB-C port on the QRD >

Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-06-13 Thread Bjorn Andersson
On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote: > Convert TI LP855X backlight controller bindings from TXT to YAML and, > while we're at it, rework some of the code related to PWM handling. > Also correct existing DTS files to avoid introducing new dtb_check > errors. > > Signed-off-by:

[PATCH v3 0/2] retrieve DSI DSC through priv-dsi[0]

2023-06-13 Thread Kuogee Hsieh
moving retrieving struct drm_dsc_cofnig from setup_display to atomic_enable() and delete struct drm_dsc_config from struct msm_display_info. Kuogee Hsieh (2): drm/msm/dpu: retrieve DSI DSC struct through priv->dsi[0] drm/msm/dpu: remove struct drm_dsc_config from struct msm_display_info

[PATCH v3 2/2] drm/msm/dpu: remove struct drm_dsc_config from struct msm_display_info

2023-06-13 Thread Kuogee Hsieh
ince struct drm_dsc_config is stored at atomic_enable() instead of display setup time during boot up, saving struct drm_dsc_config at struct msm_display_info is not necessary. Lets drop the dsc member from struct msm_display_info. Signed-off-by: Kuogee Hsieh ---

[PATCH v3 1/2] drm/msm/dpu: retrieve DSI DSC struct through priv->dsi[0]

2023-06-13 Thread Kuogee Hsieh
Currently struct drm_dsc_config for DSI is populated at display setup during system boot up. This mechanism works fine with embedded display but not for pluggable displays as the struct drm_dsc_config will become stale once external display is unplugged. Move storing of DSI DSC struct to

Re: [PATCH v2 04/22] drm/msm: enumerate DSI interfaces

2023-06-13 Thread Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration. Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [PATCH v2 03/22] drm/msm/dpu: remove unused INTF_NONE interfaces

2023-06-13 Thread Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface definitions. And sm6375 as you are touching that too Signed-off-by: Dmitry Baryshkov --- You can fix that while applying. Reviewed-by: Abhinav Kumar

Re: [PATCH v2 02/22] drm/msm/dpu: correct MERGE_3D length

2023-06-13 Thread Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: Each MERGE_3D block has just two registers. Correct the block length accordingly. Fixes: 4369c93cf36b ("drm/msm/dpu: initial support for merge3D hardware block") Signed-off-by: Dmitry Baryshkov --- LGTM, Reviewed-by: Abhinav Kumar

Re: [PATCH v2 01/22] drm/msm/dpu: fix sc7280 and sc7180 PINGPONG done interrupts

2023-06-13 Thread Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote: During IRQ conversion we have lost the PP_DONE interrupts for sc7280 platform. This was left unnoticed, because this interrupt is only used for CMD outputs and probably no sc7[12]80 systems use DSI CMD panels. Fixes: 667e9985ee24 ("drm/msm/dpu:

Re: [PATCH] drm/nouveau/kms/nv50-: Fix drm_dp_remove_payload() invocation

2023-06-13 Thread Karol Herbst
On Tue, Jun 13, 2023 at 11:05 PM Lyude Paul wrote: > > We changed the semantics for this in: > > e761cc20946a ("drm/display/dp_mst: Handle old/new payload states in > drm_dp_remove_payload()") > > But I totally forgot to update this properly in nouveau. So, let's do that. > > Signed-off-by:

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-13 Thread Stephan Gerhold
[added Dmitry to Cc, since he suggested doing this in [1]] On Tue, Jun 13, 2023 at 12:36:52AM +0100, Caleb Connolly wrote: > The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE") > breaks panels which send DSI commands in their .unprepare callbacks. > Migrate to using .disable for

Re: [PATCH] dt-bindings: display: Add missing property types

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 02:11:14PM -0600, Rob Herring wrote: > A couple of display bridge properties are missing a type definition. Add > the types to them. > > Signed-off-by: Rob Herring Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

[PATCH] drm/nouveau/kms/nv50-: Fix drm_dp_remove_payload() invocation

2023-06-13 Thread Lyude Paul
We changed the semantics for this in: e761cc20946a ("drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()") But I totally forgot to update this properly in nouveau. So, let's do that. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++--

Re: [PATCH] dt-bindings: backlight: kinetic,ktz8866: Add missing type for "current-num-sinks"

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 02:10:22PM -0600, Rob Herring wrote: > "current-num-sinks" is missing a type, add it. > > Signed-off-by: Rob Herring Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH] nouveau_connector: add nv_encoder pointer check for NULL

2023-06-13 Thread Lyude Paul
Nice catch! Reviewed-by: Lyude Paul Will push upstream On Fri, 2023-05-12 at 13:33 +0300, Natalia Petrova wrote: > Pointer nv_encoder could be dereferenced at nouveau_connector.c > in case it's equal to NULL by jumping to goto label. > This patch adds a NULL-check to avoid it. > > Found by

Re: [PATCH] drm/msm/dp: Drop aux devices together with DP controller

2023-06-13 Thread Abhinav Kumar
Hi Doug On 6/13/2023 12:33 PM, Doug Anderson wrote: Hi, On Mon, Jun 12, 2023 at 3:40 PM Dmitry Baryshkov wrote: On 13/06/2023 01:01, Bjorn Andersson wrote: Using devres to depopulate the aux bus made sure that upon a probe deferral the EDP panel device would be destroyed and recreated upon

Re: [PATCH] drm/nouveau/dp: check for NULL nv_connector->native_mode

2023-06-13 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a bit On Fri, 2023-05-12 at 14:15 +0300, Natalia Petrova wrote: > Add checking for NULL before calling nouveau_connector_detect_depth() in > nouveau_connector_get_modes() function because nv_connector->native_mode > could be dereferenced there since

[PATCH] dt-bindings: display: Add missing property types

2023-06-13 Thread Rob Herring
A couple of display bridge properties are missing a type definition. Add the types to them. Signed-off-by: Rob Herring --- .../devicetree/bindings/display/bridge/analogix,dp.yaml | 1 + .../devicetree/bindings/display/bridge/nxp,tda998x.yaml | 1 + 2 files changed, 2

[PATCH] dt-bindings: backlight: kinetic, ktz8866: Add missing type for "current-num-sinks"

2023-06-13 Thread Rob Herring
"current-num-sinks" is missing a type, add it. Signed-off-by: Rob Herring --- .../devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml

Re: [PATCH] drm/msm/dp: Drop aux devices together with DP controller

2023-06-13 Thread Doug Anderson
Hi, On Mon, Jun 12, 2023 at 3:40 PM Dmitry Baryshkov wrote: > > On 13/06/2023 01:01, Bjorn Andersson wrote: > > Using devres to depopulate the aux bus made sure that upon a probe > > deferral the EDP panel device would be destroyed and recreated upon next > > attempt. > > > > But the struct

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi Wolfram, > > > > Thanks for the feedback. > > > > > Subject: Re:

Re: [syzbot] kernel BUG in vmf_insert_pfn_prot

2023-06-13 Thread syzbot
syzbot suspects this issue was fixed by commit: commit a5b44c4adb1699661d22e5152fb26885f30a2e4c Author: Thomas Zimmermann Date: Mon Mar 20 15:07:44 2023 + drm/fbdev-generic: Always use shadow buffering bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1025ee0728 start

[PATCH] drm/mediatek: Add valid modifier check

2023-06-13 Thread Justin Green
Add a check to mtk_drm_mode_fb_create() that rejects any modifier that is not the AFBC mode supported by MT8195's display overlays. Tested by booting ChromeOS and verifying the UI works, and by running the ChromeOS kms_addfb_basic binary, which has a test called "addfb25-bad-modifier" that

Re: [PATCH v6 4/6] drm/msm/dpu: Set DATA_COMPRESS on command mode for DCE/DSC 1.2

2023-06-13 Thread Marijn Suijten
On 2023-06-09 15:57:16, Jessica Zhang wrote: > Add a DPU INTF op to set the DCE_DATA_COMPRESS bit to enable the > DCE/DSC 1.2 datapath > > Note: For now, this op is called for command mode encoders only. Changes to > set DATA_COMPRESS for video mode encoders will be posted along with DSC > v1.2

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix auxiliary bus lifetime

2023-06-13 Thread Stephen Boyd
Quoting Douglas Anderson (2023-06-13 06:58:13) > Memory for the "struct device" for any given device isn't supposed to > be released until the device's release() is called. This is important > because someone might be holding a kobject reference to the "struct > device" and might try to access one

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

2023-06-13 Thread Krzysztof Kozlowski
On 13/06/2023 16:47, Sarah Walker wrote: > This patch series adds the initial DRM driver for Imagination Technologies > PowerVR > GPUs, starting with those based on our Rogue architecture. It's worth pointing > out that this is a new driver, written from the ground up, rather than a > refactored

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Krzysztof Kozlowski
On 13/06/2023 16:47, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > I don't see improvements. That's a NAK :( This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 09:04, Manikandan Muralidharan wrote: > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > > > Signed-off-by: Manikandan Muralidharan > > --- > >

Re: [PATCH v8 1/2] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

2023-06-13 Thread Krzysztof Kozlowski
On 08/06/2023 18:37, Aradhya Bhatia wrote: > The DSS controller on TI's AM625 SoC is an update from that on TI's > AM65X SoC. The former has an additional OLDI TX on its first video port > that helps output cloned video or WUXGA (1920x1200@60fps) resolution > video output over a dual-link mode to

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 12:34:18PM +0530, Manikandan Muralidharan wrote: > Add new compatible string for the XLCD controller on SAM9X7 SoC. You should probably indicate here why this is not compatible with the existing SoCs that are supported. To hazard a guess, it is the HLCDC IP (I forget the

Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller

2023-06-13 Thread Krzysztof Kozlowski
On 13/06/2023 09:04, Manikandan Muralidharan wrote: > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > Signed-off-by: Manikandan Muralidharan > --- > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 12:34:23PM +0530, Manikandan Muralidharan wrote: > - XLCDC in SAM9X7 has different sets of registers and additional > configuration bits when compared to previous HLCDC IP. Read/write > operation on the controller registers is now separated using the > XLCDC status flag. >

Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC

2023-06-13 Thread Conor Dooley
On Tue, Jun 13, 2023 at 12:34:22PM +0530, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > Add compatible string check to differentiate XLCDC and HLCDC code > within the atmel-hlcdc driver files. > > Signed-off-by: Durai Manickam KR > Signed-off-by: Manikandan Muralidharan > --- >

Re: [PATCH v3 05/17] drm/imagination: Get GPU resources

2023-06-13 Thread Andrew Davis
On 6/13/23 9:47 AM, Sarah Walker wrote: Acquire clock, regulator and register resources, and enable/map as appropriate. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_device.c | 271 +++

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-13 Thread Doug Anderson
Hi, On Thu, Jun 8, 2023 at 8:15 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 7, 2023 at 6:25 PM Su Hui wrote: > > > > Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. > > > > Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") > > Signed-off-by: Su Hui > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi everyone, > > > > > Perhaps we should first

Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-13 Thread David Hildenbrand
On 13.06.23 10:26, Kasireddy, Vivek wrote: Hi David, On 12.06.23 09:10, Kasireddy, Vivek wrote: Hi Mike, Hi Vivek, Sorry for the late reply; I just got back from vacation. If it is unsafe to directly use the subpages of a hugetlb page, then reverting this patch seems like the only

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Andrew Davis
On 6/13/23 9:47 AM, Sarah Walker wrote: Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ MAINTAINERS | 7 ++ 2

[PATCH] drm/virtio: conditionally allocate virtio_gpu_fence

2023-06-13 Thread Gurchetan Singh
We don't want to create a fence for every command submission. It's only necessary when userspace provides a waitable token for submission. This could be: 1) bo_handles, to be used with VIRTGPU_WAIT 2) out_fence_fd, to be used with dma_fence apis 3) a ring_idx provided with

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
On 2023/6/14 00:20, Sui Jingfeng wrote: We will remote this workaround at next version. remote -> remove

Re: [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Sui Jingfeng
Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the code and resolves a long-standing TODO item. Signed-off-by: Thomas Zimmermann Reviewed-by:

Re: [PATCH drm-next v4 02/14] maple_tree: split up MA_STATE() macro

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:31]: > Split up the MA_STATE() macro such that components using the maple tree > can easily inherit from struct ma_state and build custom tree walk > macros to hide their internals from users. > > Example: > > struct sample_iterator { > struct ma_state mas; >

Re: [PATCH v3 4/4] drm/stm: add an option to change FB bpp

2023-06-13 Thread Philippe CORNU
On 6/13/23 17:26, Raphael Gallais-Pou wrote: On 6/13/23 16:52, Michael Nazzareno Trimarchi wrote: Hi On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU wrote: On 6/9/23 08:20, Dario Binacchi wrote: Boards that use the STM32F{4,7} series have limited amounts of RAM. The added parameter

Re: drm/etnaviv: disable MLCG and pulse eater on GPU reset

2023-06-13 Thread Sui Jingfeng
Hi, Lucas I love your patch, perhaps something to improve: The MLCG stand for "Module Level Clock Gating", without reading the commit message, I guess there may have people don't know its meaning. There are still more thing in this patch can only be understand relay on guessing... :-)

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-13 Thread Christopher Braga
On 6/13/2023 4:23 AM, Pekka Paalanen wrote: On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: On 6/12/2023 5:21 AM, Pekka Paalanen wrote: On Fri, 9 Jun 2023 19:11:25 -0400 Christopher Braga wrote: On 6/9/2023 12:30 PM, Simon Ser wrote: Hi Christopher, On Friday, June

Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller

2023-06-13 Thread Sui Jingfeng
Hi, On 2023/5/21 20:21, WANG Xuerui wrote: + +static int __init loongson_module_init(void) +{ +    struct pci_dev *pdev = NULL; + +    if (video_firmware_drivers_only()) +    return -ENODEV; + +    /* Multiple video card workaround */ +    while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Tue, Jun 13, 2023 at 12:45 PM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API On Mon, Jun 12, 2023 at 10:43 PM

Re: [PATCH v2 00/10] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-06-13 Thread Doug Anderson
Hi, On Tue, Jun 13, 2023 at 5:06 AM Maxime Ripard wrote: > > > > What I'm trying to say is: could we just make it work by passing a bunch > > > of platform_data, 2-3 callbacks and a device registration from the panel > > > driver directly? > > > > I think I'm still confused about what you're

Re: [PATCH] drm/msm/dpu: Configure DP INTF/PHY selector

2023-06-13 Thread Bjorn Andersson
On Tue, Jun 13, 2023 at 01:31:40AM +0300, Dmitry Baryshkov wrote: > On 13/06/2023 01:10, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Some platforms provides a mechanism for configuring the mapping between > > (one or two) DisplayPort intfs and their PHYs. > > > > In particular

Re: linux-next: Tree for Jun 13 (drivers/gpu/drm/i915/display/)

2023-06-13 Thread Randy Dunlap
On 6/12/23 23:59, Stephen Rothwell wrote: > Hi all, > > Changes since 20230609: > In file included from : ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration

Re: [Intel-gfx] [PATCH] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-06-13 Thread Belgaumkar, Vinay
On 6/1/2023 8:59 AM, Alan Previn wrote: In the case of failed suspend flow or cases where the kernel does not go into full suspend but goes from suspend_prepare back to resume_complete, we get called for a pm_complete but without runtime_pm guaranteed. Thus, ensure we take the runtime_pm when

Re: [PATCH 2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Alex Deucher
On Tue, Jun 13, 2023 at 11:05 AM Thomas Zimmermann wrote: > > All drivers initialize this field with drm_gem_prime_mmap(). Call > the function directly and remove the field. Simplifies the code and > resolves a long-standing TODO item. > > Signed-off-by: Thomas Zimmermann Series is:

Re: [PATCH v3 4/4] drm/stm: add an option to change FB bpp

2023-06-13 Thread Raphael Gallais-Pou
On 6/13/23 16:52, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU > wrote: >> >> >> On 6/9/23 08:20, Dario Binacchi wrote: >>> Boards that use the STM32F{4,7} series have limited amounts of RAM. The >>> added parameter allows users to size, within

[PATCH v3 14/17] drm/imagination: Implement job submission and scheduling

2023-06-13 Thread Sarah Walker
Implement job submission ioctl. Job scheduling is implemented using drm_sched. Jobs are submitted in a stream format. This is intended to allow the UAPI data format to be independent of the actual FWIF structures in use, which vary depending on the GPU in use. The stream formats are documented

[PATCH v3 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

2023-06-13 Thread Sarah Walker
Add the Series AXE GPU node to the AM62 device tree. Signed-off-by: Sarah Walker --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index

[PATCH v3 04/17] drm/imagination: Add skeleton PowerVR driver

2023-06-13 Thread Sarah Walker
This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Signed-off-by: Sarah Walker --- MAINTAINERS | 1 + drivers/gpu/drm/Kconfig | 2 +

[PATCH v3 01/17] sizes.h: Add entries between 32G and 64T

2023-06-13 Thread Sarah Walker
From: Matt Coster Signed-off-by: Matt Coster --- include/linux/sizes.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/sizes.h b/include/linux/sizes.h index 84aa448d8bb3..c3a00b967d18 100644 --- a/include/linux/sizes.h +++ b/include/linux/sizes.h @@ -47,8 +47,17 @@

[PATCH v3 12/17] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-06-13 Thread Sarah Walker
Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile|

[PATCH v3 10/17] drm/imagination: Implement firmware infrastructure and META FW support

2023-06-13 Thread Sarah Walker
The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. This patch depends on:

[PATCH v3 03/17] drm/imagination/uapi: Add PowerVR driver UAPI

2023-06-13 Thread Sarah Walker
Add the UAPI implementation for the PowerVR driver. Signed-off-by: Sarah Walker --- MAINTAINERS|1 + include/uapi/drm/pvr_drm.h | 1333 2 files changed, 1334 insertions(+) create mode 100644 include/uapi/drm/pvr_drm.h diff --git

[PATCH v3 07/17] drm/imagination: Add GPU ID parsing and firmware loading

2023-06-13 Thread Sarah Walker
Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking at moving this

[PATCH v3 13/17] drm/imagination: Implement context creation/destruction ioctls

2023-06-13 Thread Sarah Walker
Implement ioctls for the creation and destruction of contexts. Contexts are used for job submission and each is associated with a particular job type. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 4 + drivers/gpu/drm/imagination/pvr_cccb.c| 230

[PATCH v3 15/17] drm/imagination: Add firmware trace to debugfs

2023-06-13 Thread Sarah Walker
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 4 + drivers/gpu/drm/imagination/pvr_debugfs.c | 53 +++

[PATCH v3 11/17] drm/imagination: Implement MIPS firmware processor and MMU support

2023-06-13 Thread Sarah Walker
Add support for the MIPS firmware processor, used in the Series AXE GPU. The MIPS firmware processor uses a separate MMU to the rest of the GPU, so this patch adds support for that as well. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 4 +-

[PATCH v3 16/17] drm/imagination: Add driver documentation

2023-06-13 Thread Sarah Walker
Add documentation for the UAPI and for the virtual memory design. Signed-off-by: Sarah Walker --- Documentation/gpu/drivers.rst | 2 + Documentation/gpu/imagination/index.rst | 14 + Documentation/gpu/imagination/uapi.rst| 174 +++

[PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

2023-06-13 Thread Sarah Walker
This patch series adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver

[PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Sarah Walker
Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ MAINTAINERS | 7 ++ 2 files changed, 78 insertions(+) create mode

[PATCH v3 09/17] drm/imagination: Implement power management

2023-06-13 Thread Sarah Walker
Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_device.c | 20 +-

[PATCH v3 05/17] drm/imagination: Get GPU resources

2023-06-13 Thread Sarah Walker
Acquire clock, regulator and register resources, and enable/map as appropriate. Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_device.c | 271 +++ drivers/gpu/drm/imagination/pvr_device.h | 214

[PATCH 2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-13 Thread Thomas Zimmermann
All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the code and resolves a long-standing TODO item. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 9 -

[PATCH 1/2] drm/msm: Initialize mmap offset after constructing the buffer object

2023-06-13 Thread Thomas Zimmermann
Only the msm driver provides its own implementation of gem_prime_mmap from struct drm_driver. All other drivers use the drm_gem_prime_mmap() helper. Initialize the mmap offset when constructing the buffer object in msm and reduce the gem_prime_mmap code to the generic helper. Prepares msm for the

  1   2   3   >