Re: [PATCH v2 04/17] drm/v3d: Simplify job refcount handling

2023-11-26 Thread Iago Toral
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió: > From: Melissa Wen > > Instead of checking if the job is NULL every time we call the > function, > check it inside the function. > > Signed-off-by: Melissa Wen > Signed-off-by: Maíra Canal > --- >  drivers/gpu/drm/v3d/v3d_submit.c |

Re: [PATCH v2 09/11] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01

2023-11-26 Thread Krzysztof Kozlowski
On 26/11/2023 16:45, Dario Binacchi wrote: > From: Michael Trimarchi > > Add Tianma TM041XDHG01 that utilizes an Ilitek ILI9805 controller chip, > so its compatible string should be added to ilitek,ili9805 file. > > Add the compatible string for it. > > Signed-off-by: Michael Trimarchi >

Re: [PATCH v2 07/11] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-11-26 Thread Krzysztof Kozlowski
On 26/11/2023 16:44, Dario Binacchi wrote: > From: Michael Trimarchi > > Add documentation for "ilitek,ili9805" panel. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi > > --- > > Changes in v2: > - Add $ref to panel-common.yaml > - Drop port, reset-gpios, and backlight

Re: [PATCH v2 05/11] dt-bindings: display: panel: Add synaptics r63353 panel controller

2023-11-26 Thread Krzysztof Kozlowski
On 26/11/2023 16:44, Dario Binacchi wrote: > From: Michael Trimarchi > > Add documentation for "synaptics,r63353" panel. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-26 Thread Krzysztof Kozlowski
On 26/11/2023 17:32, Tony Lindgren wrote: > The tc358765 is similar to tc358775 except for the stdby-gpios. > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 06/12] dt-bindings: firmware: qcom, scm: Allow interconnect for everyone

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > Every Qualcomm SoC physically has a "CRYPTO0<->DDR" interconnect lane. > Allow this property to be present, no matter the SoC. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 05/12] dt-bindings: interconnect: qcom, msm8998-bwmon: Add QCM2290 bwmon instance

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > QCM2290 has a single BWMONv4 intance for CPU. Document it. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 03/12] dt-bindings: display: msm: qcm2290-mdss: Allow 2 interconnects

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > In addition to MDP0, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are > other connection paths: > - a path that connects rotator block to the DDR. > - a path that needs to be handled to ensure MDSS register access > functions properly, namely the "reg

Re: [PATCH 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 > ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every > current SoC"), but the example hasn't been updated to reflect that. > > Fix that. > > Fixes:

RE: linux-next: build failure after merge of the drm-misc-fixes tree

2023-11-26 Thread Ying Liu
On Monday, November 27, 2023 5:32 AM, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > ERROR: modpost: "device_is_dependent" > [drivers/gpu/drm/drm_kms_helper.ko] undefined! I've sent a new

[PATCH 2/2] drm/panel: simple: Add BOE BP101WX1-100 panel

2023-11-26 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets from mz615 to mz617. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[PATCH 1/2] dt-bindings: display: simple: Add boe,bp101wx1-100 panel

2023-11-26 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets mz615 to mz617. Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

[PATCH v2 2/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-26 Thread Liu Ying
Some panel devices already depend on DRM device, like the panel in arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts, because DRM device is the ancestor of those panel devices. device_link_add() would fail by returning a NULL pointer for those panel devices because of the existing dependency.

[PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-26 Thread Liu Ying
Export device_is_dependent() since the drm_kms_helper module is starting to use it. Signed-off-by: Liu Ying --- v2: * Newly introduced as needed by patch 2. drivers/base/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index

[PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-26 Thread Liu Ying
Hi, This series aims to check panel device dependency upon DRM device before managing device link between them. It fixes eariler patches in v6.7-rc1 which tried to manage the link. Without this series, the link fails to be added for dependent panel devices and hence relevant panel bridges fail

Re: linux-next: build failure after merge of the drm-misc tree

2023-11-26 Thread Luben Tuikov
On 2023-11-26 18:38, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/nouveau/nouveau_sched.c:21:41: error: > 'DRM_SCHED_PRIORITY_MIN' undeclared here (not in a function); did you mean

[PATCH -next] drm/imagination: Remove unneeded semicolon

2023-11-26 Thread Yang Li
./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7635 Signed-off-by: Yang Li --- drivers/gpu/drm/imagination/pvr_free_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

linux-next: build failure after merge of the drm-misc tree

2023-11-26 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/nouveau/nouveau_sched.c:21:41: error: 'DRM_SCHED_PRIORITY_MIN' undeclared here (not in a function); did you mean 'DRM_SCHED_PRIORITY_LOW'? 21 |

Re: [PATCH] drm/sched: Fix compilation issues with DRM priority rename

2023-11-26 Thread Luben Tuikov
On 2023-11-25 14:22, Luben Tuikov wrote: > Fix compilation issues with DRM scheduler priority rename MIN to LOW. > > Signed-off-by: Luben Tuikov > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202311252109.wgbjsskg-...@intel.com/ > Cc: Danilo Krummrich > Cc:

[PATCH v2] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

2023-11-26 Thread Rahul Rameshbabu
Dump the iir value in hex when the interrupt is unexpected. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9652#note_2178501 Cc: Jani Nikula Signed-off-by: Rahul Rameshbabu Reviewed-by: Chaitanya Kumar Borah --- Notes: Changes: v1->v2: - Change format specifier

linux-next: build failure after merge of the drm-misc-fixes tree

2023-11-26 Thread Stephen Rothwell
Hi all, After merging the drm-misc-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "device_is_dependent" [drivers/gpu/drm/drm_kms_helper.ko] undefined! Caused by commit 39d5b6a64ace ("drm/bridge: panel: Check device dependency before managing

Re: [PATCH v9 04/12] dt-bindings: phy: amlogic,g12a-mipi-dphy-analog: drop unneeded reg property and example

2023-11-26 Thread Rob Herring
On Fri, 24 Nov 2023 09:41:15 +0100, Neil Armstrong wrote: > The amlogic,g12a-mipi-dphy-analog is a feature of the simple-mfd > amlogic,meson-axg-hhi-sysctrl system control register zone which is an > intermixed registers zone, thus it's very hard to define clear ranges for > each SoC controlled

[PATCH 6/6] drm/bridge: tc358775: Configure hs_rate and lp_rate

2023-11-26 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 5/6] drm/bridge: tc358775: Add support for tc358765

2023-11-26 Thread Tony Lindgren
Looks like tc358775 is pin compatible with earlier tc358765 according to the tc358774xbg_datasheet_en_20190118.pdf documentation. On tc358775, there is an extra GPIO for STBY pin added, and few other improvments. The tc358765 has a register bit for video event mode that we must set for the LCD

[PATCH 4/6] drm/bridge: tc358775: Add burst and low-power modes

2023-11-26 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c ---

[PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support

2023-11-26 Thread Tony Lindgren
The jeida-24 register values are the default hardware settings, but they not listed in the driver. Let's add them. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-26 Thread Alyssa Ross
Thomas Zimmermann writes: > Invoke drm_plane_helper_funcs.end_fb_access before > drm_atomic_helper_commit_hw_done(). The latter function hands over > ownership of the plane state to the following commit, which might > free it. Releasing resources in end_fb_access then operates on undefined >

[PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-26 Thread Tony Lindgren
The current code assume hardcoded dsi host endpoint 1, which may not be the case. Let's fix that and simplify the code by getting the dsi endpoint with of_graph_get_remote_endpoint() that does not assume any endpoint numbering. Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver")

Re: [GIT PULL] fbdev fixes and updates for v6.7-rc3

2023-11-26 Thread Helge Deller
On 11/26/23 17:29, Linus Torvalds wrote: On Sat, 25 Nov 2023 at 22:58, Helge Deller wrote: please pull some small fbdev fixes for 6.7-rc3. These all seem to be pure cleanups, not bug fixes. Well, at least: - fbdev: imxfb: fix left margin setting is a bug fix, and: - fbdev: fsl-diu-fb:

[PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-26 Thread Tony Lindgren
The tc358765 is similar to tc358775 except for the stdby-gpios. Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml| 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git

Re: [GIT PULL] fbdev fixes and updates for v6.7-rc3

2023-11-26 Thread Linus Torvalds
On Sat, 25 Nov 2023 at 22:58, Helge Deller wrote: > > please pull some small fbdev fixes for 6.7-rc3. These all seem to be pure cleanups, not bug fixes. Please resend during the merge window. Linus

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-11-26 Thread Michael Nazzareno Trimarchi
Hi Jagan On Sun, Nov 26, 2023 at 5:11 PM Jagan Teki wrote: > > On Mon, Nov 13, 2023 at 6:45 PM Jagan Teki wrote: > > > > On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson > > wrote: > > > > > > Hi Jagan > > > > > > My apologies for dropping the ball on this one, and thanks to Frieder > > > for

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-11-26 Thread Jagan Teki
On Mon, Nov 13, 2023 at 6:45 PM Jagan Teki wrote: > > On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson > wrote: > > > > Hi Jagan > > > > My apologies for dropping the ball on this one, and thanks to Frieder > > for the nudge. > > > > On Wed, 12 Apr 2023 at 07:25, Jagan Teki wrote: > > > > > > Hi

[PATCH v2 10/11] drm/panel: ilitek-ili9805: add support for Tianma TM041XDHG01 panel

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi Tianma TM041XDHG01 utilizes the Ilitek ILI9805 controller. Add this panel's initialzation sequence and timing to ILI9805 driver. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/panel/panel-ilitek-ili9805.c |

[PATCH v2 09/11] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi Add Tianma TM041XDHG01 that utilizes an Ilitek ILI9805 controller chip, so its compatible string should be added to ilitek,ili9805 file. Add the compatible string for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v2 03/11] drm: bridge: samsung-dsim: enter display mode in the enable() callback

2023-11-26 Thread Dario Binacchi
The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the

[PATCH v2 07/11] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "ilitek,ili9805" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace additionalProperties

[PATCH v2 08/11] drm/panel: Add Ilitek ILI9805 panel driver

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi The GPM1790A0 panel is based on the Ilitek ILI9805 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig

[PATCH v2 04/11] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2023-11-26 Thread Dario Binacchi
The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++- 1 file

[PATCH v2 05/11] dt-bindings: display: panel: Add synaptics r63353 panel controller

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace

[PATCH v2 01/11] drm/bridge: Fix bridge disable logic

2023-11-26 Thread Dario Binacchi
As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first"

[PATCH v2 06/11] drm/panel: Add Synaptics R63353 panel driver

2023-11-26 Thread Dario Binacchi
From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v2: - Adjust the timings of the panel reset MAINTAINERS | 6 +

[PATCH v2 02/11] drm/bridge: Fix a use case in the bridge disable logic

2023-11-26 Thread Dario Binacchi
The patch fixes the code for finding the next bridge with the "pre_enable_prev_first" flag set to false. In case this condition is not verified, i. e. there is no subsequent bridge with the flag set to false, the whole bridge list is traversed, invalidating the "next" variable. The use of a new

[PATCH v2 00/11] Add displays support for bsh-smm-s2/pro boards

2023-11-26 Thread Dario Binacchi
The series adds drivers for the displays used by bsh-smm-s2/pro boards. This required applying some patches to the samsung-dsim driver and the drm_bridge.c module. Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace

[PATCH] driver: gpu: Fix warning directly dereferencing a rcu pointer

2023-11-26 Thread Abhinav Singh
Fix a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer. To get a normal (non __rcu tagged pointer) from a __rcu tagged pointer we are

Re: [PATCH 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-26 Thread Bryan O'Donoghue
On 25/11/2023 14:17, Konrad Dybcio wrote: The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC"), but the example hasn't been updated to reflect that. Fix that. Fixes: 0c0f65c6dd44

Re: [PATCH RFC v3 22/37] drm/rockchip: inno_hdmi: Remove useless output format

2023-11-26 Thread Johan Jonker
Hi Maxime, In stead of further cripplingRockchip HDMI drivers one could also make it functional based  on EDID info. To start with the output could you turn RGB888 input and switch between RGB444, YCBCR444 and YCBCR422 output. Johan On 10/31/23 17:48, Maxime Ripard wrote: > Similarly to the

[PATCH v1 3/3] drm/rockchip: inno_hdmi: Remove unused drm device pointer

2023-11-26 Thread Johan Jonker
The drm_dev field in the inno_hdmi struct stores a pointer to the DRM device but is never used anywhere in the driver. Let's remove it. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v1 2/3] drm/rockchip: inno_hdmi: Switch encoder hooks to atomic

2023-11-26 Thread Johan Jonker
The inno_hdmi encoder still uses the non atomic variants of enable and disable. Convert to their atomic equivalents. In atomic mode there is no need to save the adjusted mode, so remove the mode_set function. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- Changed V1: Combined

[PATCH v1 1/3] drm/rockchip: inno_hdmi: Remove useless mode_fixup

2023-11-26 Thread Johan Jonker
The mode_fixup implementation doesn't do anything, so we can simply remove it. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/inno_hdmi.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c

[PATCH v1 0/3] Rockchip inno_hdmi update

2023-11-26 Thread Johan Jonker
Combined update for the Rockchip inno_hdmi driver in a somewhat similar way to what is proposed for the "Create HDMI Connector infrastructure patch serie". Keeping the inno_hdmi and rk3066_hdmi driver functions comparable makes maintanance easier. Maxime Ripard (3): drm/rockchip: inno_hdmi:

[PATCH] drm/etnaviv: Added error handling for dma_map_sgtable.

2023-11-26 Thread Danila Chernetsov
Added error handling for dma_map_sgtable. If an error occurs, the sgt table is freed. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 182354a526a0 ("drm: etnaviv: fix common struct sg_table related issues") Signed-off-by: Danila Chernetsov ---