Small Page NAND uses byte 6 for BBI and Large Page NAND uses first 2 bytes.
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers
The current code checks that the whole OOB area is erased.
This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will
fail due to the usable OOB bytes not being 0xff.
Correct this by only checking that the ECC aren't 0xff.
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd
-24
S3 25-37
ECC 38-40
S4 41-53
ECC 54-56
S5 57-63
Signed-off-by: Álvaro Fernández Rojas
---
v2: keep original comment and fix correctly skip byte 6 for small-page nand
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 34 +---
1 file changed, 18 insertions
-24
S3 25-37
ECC 38-40
S4 41-53
ECC 54-56
S5 57-63
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 28 +---
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b
First 2 bytes are used in large-page nand.
Signed-off-by: Álvaro Fernández Rojas
---
v2: extend original comment
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers/mtd/nand/raw
-24
S3 25-37
ECC 38-40
S4 41-53
ECC 54-56
S5 57-63
Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
Signed-off-by: Álvaro Fernández Rojas
---
v3: invert patch order
v2: keep original comment and fix correctly skip byte 6 for small-page nand
d
First 2 bytes are used in large-page nand.
Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
Cc: sta...@vger.kernel.org
Signed-off-by: Álvaro Fernández Rojas
---
v3: invert patch order
v2: extend original comment
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 11
: Add check for erased page bitflips")
Signed-off-by: Álvaro Fernández Rojas
---
v3: Fix commit log and merge nand_check_erased_ecc_chunk calls.
v2: Add Fixes tag
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/d
These patches improve the OOB hamming layout by reducing the number of oob
sections and correctly
v3: invert patch order.
v2: extend original comment and correctly skip byte 6 for small-page.
Álvaro Fernández Rojas (2):
mtd: rawnand: brcmnand: fix hamming oob layout
mtd: rawnand: brcmnand
These patches improve the OOB hamming layout by reducing the number of oob
sections and correctly reserving first two bytes for large page NANDs.
v4: clarify small/large pages comment.
v3: invert patch order.
v2: extend original comment and correctly skip byte 6 for small-page.
Álvaro Fernández
Hi Miquèl,
> El 12 may 2020, a las 9:19, Miquel Raynal
> escribió:
>
> Hi Álvaro,
>
> Álvaro Fernández Rojas wrote on Tue, 12 May 2020
> 09:12:10 +0200:
>
>> Hi Miquel,
>>
>> I also had a hard time understanding your email.
>> It was quit
Hi Miquèl,
El mar., 12 may. 2020 a las 9:34, Miquel Raynal
() escribió:
>
> Hi Álvaro,
>
> Álvaro Fernández Rojas wrote on Tue, 12 May 2020
> 09:24:32 +0200:
>
> > Hi Miquèl
> >
> > > El 12 may 2020, a las 9:16, Miquel Raynal
> > > escribió:
>
First 2 bytes are used in large-page nand.
Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
Cc: sta...@vger.kernel.org
Signed-off-by: Álvaro Fernández Rojas
---
v4: no changes
v3: invert patch order
v2: extend original comment
drivers/mtd/nand/raw/brcmnand/
Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible
strings to support brcmnand controllers v2.1 and v2.2.
Signed-off-by: Álvaro Fernández Rojas
---
v2: add new patch
Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git
Add support for v2.1 and v2.2 NAND controllers.
v2: introduce changes suggested by Miquèl.
Álvaro Fernández Rojas (5):
mtd: rawnand: brcmnand: rename v4 registers
mtd: rawnand: brcmnand: fix CS0 layout
mtd: rawnand: brcmnand: rename page sizes
dt: bindings: brcmnand: add v2.1 and v2.2
Hi Florian,
I added it on v2.
Best regards,
Álvaro.
> El 4 may 2020, a las 23:43, Florian Fainelli escribió:
>
>
>
> On 5/4/2020 2:29 AM, Álvaro Fernández Rojas wrote:
>> The current code checks that the whole OOB area is erased.
>> This is a problem when J
check for erased page bitflips")
Signed-off-by: Álvaro Fernández Rojas
---
v2: Add Fixes tag
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers/mtd/nand/ra
Only v3.3-v5.0 have a different CS0 layout.
v3.3- controllers use the same layout for every CS.
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b
These registers are also used on v3.3.
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index
Tested on Netgear DGND3700v2 (BCM6362 with v2.2 controller).
Signed-off-by: Álvaro Fernández Rojas
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 76 +---
1 file changed, 67 insertions(+), 9 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers/mtd
These registers are also used on v3.3.
Signed-off-by: Álvaro Fernández Rojas
Reviewed-by: Miquel Raynal
---
v2: fix commit title.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b
-24
S3 25-37
ECC 38-40
S4 41-53
ECC 54-56
S5 57-63
Signed-off-by: Álvaro Fernández Rojas
---
v4: clarify small/large pages comment
v3: invert patch order
v2: keep original comment and fix correctly skip byte 6 for small-page nand
drivers/mtd/nand/raw/brcmnand/brcmnand.c
Tested on Netgear DGND3700v2 (BCM6362 with v2.2 controller).
Signed-off-by: Álvaro Fernández Rojas
---
v2: split page sizes rename into a different patch.
name all block and page sizes versions.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 74 +---
1 file changed, 66
Hi Miquel,
I also had a hard time understanding your email.
It was quite misleading.
> El 12 may 2020, a las 9:08, Miquel Raynal
> escribió:
>
> Hi Álvaro,
>
> Álvaro Fernández Rojas wrote on Tue, 12 May 2020
> 08:00:23 +0200:
>
>> The current code generat
Only v3.3-v5.0 have a different CS0 layout.
Controllers before v3.3 use the same layout for every CS.
Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB
NAND controller")
Signed-off-by: Álvaro Fernández Rojas
---
v2: fix commit log.
drivers/m
Hi Miquèl
> El 12 may 2020, a las 9:16, Miquel Raynal
> escribió:
>
> Hi Álvaro,
>
> Álvaro Fernández Rojas wrote on Tue, 12 May 2020
> 08:51:11 +0200:
>
>> The current code checks that the whole OOB area is erased.
>> This is a problem when JFFS2 clea
Current pages sizes apply to controllers after v3.4
Signed-off-by: Álvaro Fernández Rojas
---
v2: add new patch.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b/drivers/mtd/nand/raw
: Add check for erased page bitflips")
Signed-off-by: Álvaro Fernández Rojas
---
v4: Use mtd_ooblayout_ecc function, rename oob to ecc_bytes and remove unused
sas variable.
v3: Fix commit log and merge nand_check_erased_ecc_chunk calls.
v2: Add Fixes tag
drivers/mtd/nand/raw/brcmnand/
Only v3.3-v5.0 have a different CS0 layout.
Controllers before v3.3 use the same layout for every CS.
Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB
NAND controller")
Signed-off-by: Álvaro Fernández Rojas
---
v4: no changes.
v3: no changes.
Add support for v2.1 and v2.2 NAND controllers.
v3: fix v2.1 page size shift
v2: introduce changes suggested by Miquèl.
Álvaro Fernández Rojas (5):
mtd: rawnand: brcmnand: rename v4 registers
mtd: rawnand: brcmnand: fix CS0 layout
mtd: rawnand: brcmnand: rename page sizes
dt: bindings
These registers are also used on v3.3.
Signed-off-by: Álvaro Fernández Rojas
Reviewed-by: Miquel Raynal
---
v3: no changes.
v2: fix commit title.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw
v2.1: tested on Netgear DGND3700v1 (BCM6368)
v2.2: tested on Netgear DGND3700v2 (BCM6362)
Signed-off-by: Álvaro Fernández Rojas
---
v4: use proper commit subject.
v3: fix page size shift for v2.1 controllers.
v2: split page sizes rename into a different patch.
name all block and page
v2.1: tested on Netgear DGND3700v1 (BCM6368)
v2.2: tested on Netgear DGND3700v2 (BCM6362)
Signed-off-by: Álvaro Fernández Rojas
---
v3: fix page size shift for v2.1 controllers.
v2: split page sizes rename into a different patch.
name all block and page sizes versions.
drivers/mtd/nand
Add support for v2.1 and v2.2 NAND controllers.
v4: fix commit subject.
v3: fix v2.1 page size shift
v2: introduce changes suggested by Miquèl.
Álvaro Fernández Rojas (5):
mtd: rawnand: brcmnand: rename v4 registers
mtd: rawnand: brcmnand: fix CS0 layout
mtd: rawnand: brcmnand: rename page
Only v3.3-v5.0 have a different CS0 layout.
Controllers before v3.3 use the same layout for every CS.
Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB
NAND controller")
Signed-off-by: Álvaro Fernández Rojas
---
v3: no changes.
v2: fix commit log
These registers are also used on v3.3.
Signed-off-by: Álvaro Fernández Rojas
Reviewed-by: Miquel Raynal
---
v4: no changes.
v3: no changes.
v2: fix commit title.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd
Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible
strings to support brcmnand controllers v2.1 and v2.2.
Signed-off-by: Álvaro Fernández Rojas
---
v3: no changes.
v2: add new patch.
Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 2 ++
1 file changed, 2
Current pages sizes apply to controllers after v3.4
Signed-off-by: Álvaro Fernández Rojas
---
v3: no changes.
v2: add new patch.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
b
Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible
strings to support brcmnand controllers v2.1 and v2.2.
Signed-off-by: Álvaro Fernández Rojas
---
v4: no changes.
v3: no changes.
v2: add new patch.
Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 2 ++
1 file
Hello Miquel,
No, nothing else changed.
I will change it again with the proper subject, sorry for that.
Best regards,
Álvaro.
> El 22 may 2020, a las 13:22, Miquel Raynal
> escribió:
>
>> v2.1: tested on Netgear DGND3700v1 (BCM6368)
___
dri-devel
Current pages sizes apply to controllers after v3.4
Signed-off-by: Álvaro Fernández Rojas
---
v4: no changes.
v3: no changes.
v2: add new patch.
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand
Enviado: Sunday, May 24, 2020 9:27:40 PM
Para: Álvaro Fernández Rojas ; computersforpe...@gmail.com
; kdasu.k...@gmail.com ;
miquel.ray...@bootlin.com ; rich...@nod.at
; vigne...@ti.com ; sumit.sem...@linaro.org
; linux-...@lists.infradead.org
; bcm-kernel-feedback-l...@broadcom.com
; linux-ker
Hi Kamal,
> El 13 jun 2020, a las 17:16, Kamal Dasu escribió:
>
> Alvaro,
>
>
> On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas
> wrote:
>>
>> Hi Kamal,
>>
>>> El 12 jun 2020, a las 20:47, Kamal Dasu escribió:
>>>
Hi Kamal,
> El 12 jun 2020, a las 20:47, Kamal Dasu escribió:
>
> On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas
> wrote:
>>
>> MTD_OPS_AUTO_OOB is writting OOB with ECC enabled, which changes all ECC
>> bytes
>> from an erased page to 0x00 when J
44 matches
Mail list logo
