[PATCH v3 1/2] drm/panel: Add support for Truly NT35597 panel

2018-05-23 Thread Abhinav Kumar
the documentation to cover the port information - Formatting fixes and changes in delays in panel sequences - Cleaned up probe function Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/panel/Kconfig

[PATCH v3 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-05-23 Thread Abhinav Kumar
Add the device tree bindings for Truly NT35597 panel. This panel supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- .../devicetree/bindings/display/truly,nt35597.txt | 69 +++

[PATCH v3 1/2] Add support for Truly NT35597 panel used in MSM reference platforms.

2018-05-23 Thread Abhinav Kumar
and changes in delays in panel sequences - Cleaned up probe function Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + dri

[PATCH v3 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-05-23 Thread Abhinav Kumar
Add the device tree bindings for Truly NT35597 panel. This panel supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- .../devicetree/bindings/display/truly,nt35597.txt | 69 +++

[PATCH v4 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-05-25 Thread Abhinav Kumar
Add the device tree bindings for Truly NT35597 panel. This panel supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v4: - None Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- .../devicetree/bindings/display/truly,nt35597.txt

[PATCH v4 1/2] drm/panel: Add support for Truly NT35597 panel

2018-05-25 Thread Abhinav Kumar
messages and return code Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-truly-nt3

[DPU PATCH v4] drm/msm: higher values of pclk can exceed 32 bits when multiplied by a factor.

2018-06-07 Thread Abhinav Kumar
Make the pclk_rate u64 to accommodate higher pixel clock rates. Changes in v4: - fixed commit message Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers

[DPU PATCH v4] drm/msm: higher values of pclk can exceed 32 bits when multiplied by a factor

2018-06-07 Thread Abhinav Kumar
Make the pclk_rate u64 to accommodate higher pixel clock rates. Changes in v4: - fixed commit message Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers

[DPU PATCH] drm/msm/dsi: add only dsi nodes with a valid device to list

2018-06-16 Thread Abhinav Kumar
in creation of redundant connectors. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 6 +- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm

[DPU PATCH] drm/msm/dsi: set encoder mode for DRM bridge explicitly

2018-06-15 Thread Abhinav Kumar
Currently, DRM bridge for DPU relies on the default video mode setting to set the encoder mode. Add an explicit call to set the encoder mode for bridges. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[DPU PATCH] drm/msm: remove support for seamless modes

2018-06-12 Thread Abhinav Kumar
://patchwork.freedesktop.org/series/44592/ Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 31 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 106 +--- drivers/gpu/drm/msm/msm_kms.h | 44 include/uapi/drm/drm_mode.h

[DPU PATCH] drm/msm/dsi: configure VCO rate for 10nm PLL driver

2018-06-14 Thread Abhinav Kumar
Currenty the VCO rate in the 10nm PLL driver relies on the parent rate which is not configured. Configure the VCO rate to 19.2 Mhz as required by the 10nm PLL driver. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 4 +++- 1 file changed, 3 insertions(+), 1

[DPU PATCH v2] drm/msm: make pclk_rate u64 to avoid truncation

2018-05-30 Thread Abhinav Kumar
Higher values of pclk can exceed 32 bits when multiplied by a factor. Make the pclk_rate u64 to accommodate higher pixel clock rates. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[DPU PATCH] drm/msm: make pclk_rate u64 to avoid truncation

2018-05-29 Thread Abhinav Kumar
Higher values of pclk can exceed 32 bits when multiplied by a factor. Make the pclk_rate u64 to accommodate higher pixel clock rates. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm

[DPU PATCH v3] Higher values of pclk can exceed 32 bits when multiplied by a factor.

2018-06-01 Thread Abhinav Kumar
Make the pclk_rate u64 to accommodate higher pixel clock rates. Changes in v3: - Rebased on top of https://patchwork.kernel.org/patch/10348865/ Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-02 Thread Abhinav Kumar
n - Remove truly_wqxga_panel_del and do necessary cleanup - Replace dev_err with DRM_DEV_ERROR Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-truly

[PATCH v5 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-08-02 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add the device tree bindings for Truly NT35597 panel. This panel supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v5: - None Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/tru

[PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-02 Thread Abhinav Kumar
n - Remove truly_wqxga_panel_del and do necessary cleanup - Replace dev_err with DRM_DEV_ERROR Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-truly

[PATCH v5 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-08-02 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add the device tree bindings for Truly NT35597 panel. This panel supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v5: - None Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/tru

[PATCH RESEND v6 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-08-28 Thread Abhinav Kumar
ence board and the panel - Remove the display timing node Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/truly,nt35597.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt diff --git a/Doc

[PATCH RESEND v6 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-08-28 Thread Abhinav Kumar
nel driver - Have a data member for each compatible string - Remove the panel commands split as its not required for the panel init functionality Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/pane

[PATCH v6 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-08-17 Thread Abhinav Kumar
ence board and the panel - Remove the display timing node Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/truly,nt35597.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt diff --git a/Doc

[PATCH v6 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-08-17 Thread Abhinav Kumar
nel driver - Have a data member for each compatible string - Remove the panel commands split as its not required for the panel init functionality Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/pane

Re: [PATCH RESEND v6 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-04 Thread Abhinav Kumar
et me know if there are any concerns with this. Thanks Abhinav On 2018-09-03 15:00, Linus Walleij wrote: On Mon, Sep 3, 2018 at 9:50 PM Bjorn Andersson wrote: On Tue 28 Aug 15:39 PDT 2018, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel d

[DPU PATCH 2/2] drm/panel: add backlight control support for truly panel

2018-04-07 Thread Abhinav Kumar
Register truly panel as a backlight led device and provide methods to control its backlight operation. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/panel/panel-truly-dual-dsi.c | 96 +++- 1 file changed, 94 insertions(+), 2 deletions(-)

[DPU PATCH 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-07 Thread Abhinav Kumar
Make sure the video mode engine is on before waiting for the video done interrupt. Otherwise it leads to silent timeouts increasing display turn ON time. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 ++ 1 file chang

[DPU PATCH 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-07 Thread Abhinav Kumar
Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

[DPU PATCH 1/2] drm/panel: Add Truly Dual DSI video mode panel

2018-04-07 Thread Abhinav Kumar
From: Archit Taneja <arch...@codeaurora.org> Add support for truly dual DSI video mode panel panel used in MSM reference platforms. Signed-off-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- .../bindings/display/tr

[DPU PATCH v2 1/2] drm/panel: Add Truly NT35597 panel

2018-04-14 Thread Abhinav Kumar
Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- .../devicetree/bindings/display/truly,nt35597.txt | 47 ++ drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm

[DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-14 Thread Abhinav Kumar
Register truly panel as a backlight led device and provide methods to control its backlight operation. Changes in v2: - Removed redundant NULL checks - Arranged headers alphabetically - Formatting fixes Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/panel/panel

[DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-10 Thread Abhinav Kumar
Make sure the video mode engine is on before waiting for the video done interrupt. Otherwise it leads to silent timeouts increasing display turn ON time. Changes in v2: - Replace pr_err with dev_err - Changed error message Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drive

[DPU PATCH v2 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-10 Thread Abhinav Kumar
Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Changes in v2: - None Reviewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar

[DPU PATCH v4 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-17 Thread Abhinav Kumar
anp...@chromium.org> Reviewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 109 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 2 + drivers/gpu/drm/msm/dsi/phy/ds

[DPU PATCH v4 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-17 Thread Abhinav Kumar
Make sure the video mode engine is on before waiting for the video done interrupt. Changes in v4: - Move setting enabled to false earlier Changes in v3: - Move the return value check to another patch Changes in v2: - Replace pr_err with dev_err - Changed error message Signed-off-by: Abhinav

[DPU PATCH v3 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-16 Thread Abhinav Kumar
Archit Taneja <arch...@codeaurora.org> Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 109 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 28 ---

[DPU PATCH v3 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-16 Thread Abhinav Kumar
Make sure the video mode engine is on before waiting for the video done interrupt. Changes in v2: - Replace pr_err with dev_err - Changed error message Changes in v3: - Move the return value check to another patch Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/d

[DPU PATCH] drm/msm/dsi: check return value for video done waits

2018-04-16 Thread Abhinav Kumar
Check for the return value of wait for video done waits and print appropriate error message. Signed-off-by: Abhinav Kumar <abhin...@codeaurora.org> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-05 Thread Abhinav Kumar
Hi Rob Had one question on below comment. Can you please help to clarify? Thanks Abhinav On 2018-10-04 12:42, Abhinav Kumar wrote: Hi Rob Thanks for the review. Will copy the DT list in the next patchset. Some comments inline. Thanks Abhinav On 2018-10-04 12:01, Rob Herring wrote

Re: [PATCH] drm/msm: validate display and event threads

2018-10-05 Thread Abhinav Kumar
On 2018-10-05 12:49, Jeykumar Sankaran wrote: While creating display and event threads per crtc, validate them before setting their priorities. Change-Id: I1dda805286df981c0f0e2b26507d089d3a21ff6c Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 49

[PATCH v2] drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

2018-10-11 Thread Abhinav Kumar
Fix the dsi clock names in the DSI 10nm PLL driver to match the names in the dispcc driver as those are according to the clock plan of the chipset. Changes in v2: - Update the clock diagram with the new clock name Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 8

Re: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1

2018-10-25 Thread Abhinav Kumar
t") > Signed-off-by: Douglas Anderson > Cc: Sandeep Panda > --- If Rob is onboard with this binding change, please feel free to add Reviewed-by: Abhinav Kumar > > drivers/gpu/drm/panel/panel-simple.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-

Re: [PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-04 Thread Abhinav Kumar
Abhinav Kumar wrote: Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI. By driver, you means drives panel timing signals or a Linux driver? The former is okay, the latter is not. Yes, I mean it driver panel timing signals

[PATCH v9 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-28 Thread Abhinav Kumar
Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v9: - None Reviewed-by: Linus Walleij Reviewed-by: Sean Paul Signed-off-by: Abhinav Kumar --- .../devicetree

[PATCH v9 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-28 Thread Abhinav Kumar
number of lines used by comments - Fix return value in probe - Fix driver name to use '-' instead of '_' Reviewed-by: Sean Paul Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile | 1

[PATCH] drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

2018-10-10 Thread Abhinav Kumar
Fix the dsi clock names in the DSI 10nm PLL driver to match the names in the dispcc driver as those are according to the clock plan of the chipset. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v10 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-10-05 Thread Abhinav Kumar
-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-truly-nt35597.c | 675 3 files changed, 683 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-truly

[PATCH v10 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-05 Thread Abhinav Kumar
fix a typo Reviewed-by: Linus Walleij Reviewed-by: Sean Paul Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/truly,nt35597.txt | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt

Re: [PATCH -next] drm/msm/dpu: remove duplicated include from dpu_hw_lm.c

2018-10-05 Thread Abhinav Kumar
On 2018-10-05 18:49, YueHaibing wrote: Remove duplicated include. Signed-off-by: YueHaibing Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1

Re: Question on 640x480 @ 72fps

2018-08-31 Thread Abhinav Kumar
Hi Sean/Ville Thanks for the comments. This mode 640x480 @ 72Hz comes directly from the VESA spec ( DMT Standards and Guidelines Summary ). Yes, I understand that the hardware will still be running at 72.8 Hz. The background behind the test is its actually testing out the EDID parser with

Re: [PATCH 1/3] drm/msm: dpu: Clear frame_busy_mask bit after trace

2018-09-19 Thread Abhinav Kumar
On 2018-09-19 11:33, Sean Paul wrote: From: Sean Paul We're printing the frame_busy_mask in a trace, but after it's been cleared. This, as it turns out, is pretty pointless. Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file

Re: [PATCH 2/3] drm/msm: dpu: Add extra_flush_bits to trigger_flush trace

2018-09-19 Thread Abhinav Kumar
On 2018-09-19 11:33, Sean Paul wrote: From: Sean Paul It's useful to know which bits of the flush come from "extra_flush_bits" Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_trac

Re: [PATCH 3/3] drm/msm: dpu: Don't store/deref pointers in trace ringbuffer

2018-09-19 Thread Abhinav Kumar
ter fixing the minor nit please add, Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 98 +-- 1 file changed, 55 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h index ae

[PATCH v8 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Abhinav Kumar
nd headers - Remove unused macros - Try to avoid multi-lines wherever possible - Fix comments locations and make it concise - Fix return points in probe function Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 7 + drivers/gpu/drm/pane

[PATCH v8 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-20 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add the device tree bindings for Truly NT35597 panel driver. This panel driver supports both single DSI and dual DSI. However, this patch series supports only dual DSI. Changes in v8: - None Signed-off-by: Abhinav Kumar --- .../devicetree/bindin

[PATCH v7 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-09-19 Thread Abhinav Kumar
ver string and the resolution - Indicate reset GPIO is ACTIVE_LOW Signed-off-by: Abhinav Kumar --- .../devicetree/bindings/display/truly,nt35597.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/truly,nt35597.txt

[PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-19 Thread Abhinav Kumar
Signed-off-by: Archit Taneja Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-truly-nt35597.c | 706 3 files changed, 715 insertions(+) create mode 100644 d

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Abhinav Kumar
Hi Sean Sure, I will address these in v8. Thanks Abhinav On 2018-09-20 08:52, Sean Paul wrote: On Wed, Sep 19, 2018 at 07:55:39PM -0700, Abhinav Kumar wrote: From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel driver used in MSM reference platforms. This pa

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Abhinav Kumar
Hi Bjorn Thanks for the comment. Yes, I will move of_node_put(dsi1) to right after of_find_mipi_dsi_host_by_node and remove it from err_dsi_device. Thanks Abhinav On 2018-09-20 09:54, Bjorn Andersson wrote: On Wed 19 Sep 19:55 PDT 2018, Abhinav Kumar wrote: +static int truly_nt35597_probe

Re: [PATCH v8 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-27 Thread Abhinav Kumar
Hi Thierry Thanks for the comments. I will fix these in v9. Thanks Abhinav On 2018-09-27 05:20, Thierry Reding wrote: On Thu, Sep 20, 2018 at 03:52:36PM -0700, Abhinav Kumar wrote: From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel driver used in MSM reference

Re: [PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Abhinav Kumar
On 2018-12-07 09:16, Sean Paul wrote: From: Sean Paul The irq_control function is called upon encoder enable/disable and turns on/off the vblank interrupts. Unfortunately, it enables them when the drm code is not expecting them to be on. As a result, we can get into nasty locking situations.

Re: [PATCH v5] arm64: dts: sdm845: Add display nodes to MTP dts

2018-12-07 Thread Abhinav Kumar
On 2018-12-07 12:59, Doug Anderson wrote: Hi, On Wed, Dec 5, 2018 at 7:35 PM Abhinav Kumar wrote: + { + status = "okay"; + qcom,dual-dsi-mode; + qcom,master-dsi; + qcom,sync-dual-dsi; + + vdda-supply = <_mipi_dsi0_1p2>; +

Re: [PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Abhinav Kumar
On 2018-12-07 13:50, Sean Paul wrote: On Fri, Dec 07, 2018 at 01:16:54PM -0800, Abhinav Kumar wrote: On 2018-12-07 09:16, Sean Paul wrote: > From: Sean Paul > > The irq_control function is called upon encoder enable/disable and turns > on/off the vblank interrupts. Unfortunately

[PATCH v5] arm64: dts: sdm845: Add display nodes to MTP dts

2018-12-05 Thread Abhinav Kumar
-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 118 1 file changed, 118 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts index d667eee..ee63783 100644 --- a/arch/arm64/boot/dts/qcom/sdm845

[PATCH] drm/msm/dsi: add protection against NULL dsi device

2019-03-06 Thread Abhinav Kumar
Hugo Tested-by: Jeffrey Hugo Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 80aa634..cc2569d 100644 --- a/drivers/gpu

Re: [PATCH] drm/msm/dsi: add protection against NULL dsi device

2019-03-07 Thread Abhinav Kumar
On 2019-03-07 13:59, Sean Paul wrote: On Wed, Mar 06, 2019 at 05:28:54PM -0800, Abhinav Kumar wrote: When panel probe happens after DSI probe, the DSI probe is deferred as per current design. In the probe defer path dsi device is destroyed. This NULL dsi device could be deferenced by the panel

[PATCH] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-02-11 Thread Abhinav Kumar
in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 18 ++ 1

Re: [PATCH 1/4] drm/msm: Use drm_mode_vrefresh instead of mode->vrefresh

2019-01-28 Thread Abhinav Kumar
On 2019-01-28 12:42, Sean Paul wrote: From: Sean Paul Use the drm_mode_vrefresh helper where we need refresh rate in case vrefresh is empty. Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- drivers/gpu/drm/msm/disp

Re: [PATCH 2/4] drm/msm: dpu: Simplify frame_done watchdog timeout calculation

2019-01-28 Thread Abhinav Kumar
-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index dd71cb6ba4f5c..83a4c47dbed2d 100644 --- a/drivers/gpu/drm/msm

Re: [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-24 Thread Abhinav Kumar
bug/dri// Reported-by: Stephen Boyd Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c in

Re: [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init

2019-05-24 Thread Abhinav Kumar
On 2019-05-24 10:32, Sean Paul wrote: From: Sean Paul Fold it into dpu_debugfs_init. Cc: Stephen Boyd Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v2] drm/msm/dsi: add protection against NULL dsi device

2019-05-31 Thread Abhinav Kumar
: - Add more comments on how this NULL pointer situation will be hit Reported-by: Jeffrey Hugo Tested-by: Jeffrey Hugo Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi

Re: [PATCH] drm/msm/dsi: add protection against NULL dsi device

2019-05-29 Thread Abhinav Kumar
On 2019-05-29 13:43, Jeffrey Hugo wrote: On 3/7/2019 3:02 PM, Abhinav Kumar wrote: On 2019-03-07 13:59, Sean Paul wrote: On Wed, Mar 06, 2019 at 05:28:54PM -0800, Abhinav Kumar wrote: When panel probe happens after DSI probe, the DSI probe is deferred as per current design. In the probe defer

Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Abhinav Kumar
On 2019-04-25 07:03, Nicholas Mc Guire wrote: wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise so checking for < makes no sense here. Signed-off-by: Nicholas Mc Guire Reviewed-by: Abhinav Kumar --- Problem located with an experimental coccinelle script Wh

[PATCH v2] drm: Parse Colorimetry data block from EDID

2020-01-27 Thread Abhinav Kumar
From: Uma Shankar CEA 861.3 spec adds colorimetry data block for HDMI. Parsing the block to get the colorimetry data from panel. This was posted by Uma Shankar at https://patchwork.kernel.org/patch/10861327/ Modified by Abhinav Kumar: - Use macros to distinguish the bit fields for clarity

[PATCH] drm: Parse Colorimetry data block from EDID

2020-01-23 Thread Abhinav Kumar
From: Uma Shankar CEA 861.3 spec adds colorimetry data block for HDMI. Parsing the block to get the colorimetry data from panel. This was posted by Uma Shankar at https://patchwork.kernel.org/patch/10861327/ Modified by Abhinav Kumar: - Use macros to distinguish the bit fields for clarity

[PATCH] drm: increase DRM_OBJECT_MAX_PROPERTY to 64

2020-04-17 Thread Abhinav Kumar
Increase DRM_OBJECT_MAX_PROPERTY to accommodate for additional DRM properties on MSM chipsets. Signed-off-by: Abhinav Kumar --- include/drm/drm_mode_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h index

[PATCH 1/4] drm/msm/dp: add debugfs support to DP driver

2020-09-03 Thread Abhinav Kumar
To prepare the MSM DP driver for running video pattern compliance tests introduce debugfs module for it. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile| 3 +- drivers/gpu/drm/msm/dp/dp_debug.c | 310 drivers/gpu/drm/msm/dp/dp_debug.h

[PATCH 0/4] Add support for video pattern DP CTS to MSM DP

2020-09-03 Thread Abhinav Kumar
/project/dri-devel/list/?series=339847 [2] https://patchwork.kernel.org/project/dri-devel/list/?series=339997 [3] https://patchwork.kernel.org/project/dri-devel/list/?series=341175 Abhinav Kumar (4): drm/msm/dp: add debugfs support to DP driver drm/msm/dp: move debugfs node to /sys/kernel/debug

[PATCH 3/4] drm/msm/dp: add debugfs nodes for video pattern tests

2020-09-03 Thread Abhinav Kumar
Add the debugfs nodes needed for the video pattern compliance tests to MSM DP driver. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 184 ++ drivers/gpu/drm/msm/dp/dp_link.h | 23 2 files changed, 207 insertions(+) diff --git a/drivers

[PATCH 4/4] drm/msm/dp: remove mode hard-coding in case of DP CTS

2020-09-03 Thread Abhinav Kumar
No need to fix the number of resolutions to one during the video pattern CTS test. The userspace test client will handle both the hotplug as well as picking the right resolution for the test. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 3 -- drivers/gpu/drm/msm/dp

[PATCH 2/4] drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/

2020-09-03 Thread Abhinav Kumar
Move the MSM DP debugfs node from /sys/kernel/debug/drm_dp to /sys/kernel/debug/dri/*/ as required for video pattern compliance test suite. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 + drivers/gpu/drm/msm/dp/dp_debug.c | 31

[PATCH v5 4/5] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-09-10 Thread Abhinav Kumar
of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 43e5240a87ad..59ffdb8a1636

[PATCH v5 1/5] drm/msm/dp: store dp_display in the driver data

2020-09-10 Thread Abhinav Kumar
Store the dp_display in the platform driver data instead of the dp_display_private. This is required to allow other sub-modules to reuse the platform driver data. Changes in v3: none Changes in v4: none Changes in v5: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c

[PATCH v5 0/5] Add audio support for MSM DisplayPort driver

2020-09-10 Thread Abhinav Kumar
of latest patchset of dependency changes in v5: - rebase on top of latest patchset of dependency - fix crash when trying to play audio in DP suspend state Abhinav Kumar (5): drm/msm/dp: store dp_display in the driver data drm/msm/dp: add audio support for Display Port on MSM drm/msm/dp

[PATCH v5 3/5] drm/msm/dp: add hook_plugged_cb hdmi-codec op for MSM DP driver

2020-09-10 Thread Abhinav Kumar
of dependency Changes in v5: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_audio.c | 25 - drivers/gpu/drm/msm/dp/dp_display.c | 24 drivers/gpu/drm/msm/dp/dp_display.h | 7 +++ 3

[PATCH v5 5/5] drm/msm/dp: wait for audio notification before disabling clocks

2020-09-10 Thread Abhinav Kumar
-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_audio.c | 32 +++ drivers/gpu/drm/msm/dp/dp_display.c | 40 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ 3 files changed, 70 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b

[PATCH v5 2/5] drm/msm/dp: add audio support for Display Port on MSM

2020-09-10 Thread Abhinav Kumar
branch Changes in v3: none Changes in v4: none Changes in v5: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile| 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 + drivers/gpu/drm/msm/dp/dp_audio.c | 583 drivers/gpu/drm/msm

[PATCH v6 1/5] drm/msm/dp: store dp_display in the driver data

2020-09-12 Thread Abhinav Kumar
-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index fa92b6cd6e3e..0defab6e2478 100644 --- a/drivers/gpu/drm/msm

[PATCH v6 2/5] drm/msm/dp: add audio support for Display Port on MSM

2020-09-12 Thread Abhinav Kumar
branch Changes in v3: none Changes in v4: none Changes in v5: none Changes in v6: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile| 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 + drivers/gpu/drm/msm/dp

[PATCH v6 4/5] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-09-12 Thread Abhinav Kumar
of latest patchset of dependency Changes in v6: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index

[PATCH v6 3/5] drm/msm/dp: add hook_plugged_cb hdmi-codec op for MSM DP driver

2020-09-12 Thread Abhinav Kumar
of dependency Changes in v5: rebase on top of latest patchset of dependency Changes in v6: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_audio.c | 25 - drivers/gpu/drm/msm/dp/dp_display.c | 24 drivers/gpu/drm/msm/dp

[PATCH v2 3/4] drm/msm/dp: add debugfs nodes for video pattern tests

2020-09-12 Thread Abhinav Kumar
Add the debugfs nodes needed for the video pattern compliance tests to MSM DP driver. Changes in v2: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 184 ++ drivers/gpu/drm/msm/dp/dp_link.h | 23

[PATCH v2 2/4] drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/

2020-09-12 Thread Abhinav Kumar
Move the MSM DP debugfs node from /sys/kernel/debug/drm_dp to /sys/kernel/debug/dri/*/ as required for video pattern compliance test suite. Changes in v2: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 + drivers

[PATCH v2 1/4] drm/msm/dp: add debugfs support to DP driver

2020-09-12 Thread Abhinav Kumar
To prepare the MSM DP driver for running video pattern compliance tests introduce debugfs module for it. Changes in v2: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile| 3 +- drivers/gpu/drm/msm/dp/dp_debug.c | 310

[PATCH v2 4/4] drm/msm/dp: remove mode hard-coding in case of DP CTS

2020-09-12 Thread Abhinav Kumar
No need to fix the number of resolutions to one during the video pattern CTS test. The userspace test client will handle both the hotplug as well as picking the right resolution for the test. Changes in v2: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers

[PATCH v2 0/4] Add support for video pattern DP CTS to MSM DP

2020-09-12 Thread Abhinav Kumar
/project/dri-devel/list/?series=339847 [2] https://patchwork.freedesktop.org/patch/390217/?series=79210=8 [3] https://patchwork.kernel.org/project/dri-devel/list/?series=347831 Changes in v2: rebase on top of latest patchset of dependencies Abhinav Kumar (4): drm/msm/dp: add debugfs support to DP

[PATCH v6 5/5] drm/msm/dp: wait for audio notification before disabling clocks

2020-09-12 Thread Abhinav Kumar
: - rebased on top of latest patchset of dependency Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_audio.c | 32 +++ drivers/gpu/drm/msm/dp/dp_display.c | 40 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ 3 files changed, 70 insertions(+), 5

[PATCH v6 0/5] Add audio support for MSM DisplayPort driver

2020-09-12 Thread Abhinav Kumar
shutdown changes in v4: - rebase on top of latest patchset of dependency changes in v5: - rebase on top of latest patchset of dependency - fix crash when trying to play audio in DP suspend state changes in v6: - rebase on top of latest patchset of dependency Abhinav Kumar (5

[PATCH v4 0/5] add audio support for Display Port on MSM

2020-08-31 Thread Abhinav Kumar
/11047883/ [2] https://patchwork.kernel.org/patch/11708677/ changes in v2: - fix up a compilation issue on drm-next branch changes in v3: - add support to synchronize DP driver and audio during shutdown changes in v4: - rebase on top of latest patchset of dependency Abhinav Kumar (5

[PATCH v4 4/5] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-08-31 Thread Abhinav Kumar
Signal the hotplug disconnect event to the audio side in the event handler so that they are notified earlier and have more time to process the disconnect event. Changes in v2: none Changes in v3: none Changes in v4: rebase on top of latest patchset of dependency Signed-off-by: Abhinav Kumar

  1   2   3   4   5   6   7   8   9   10   >