ation")
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 48c966375ffa..f42794cdd
On 10/5/2022 11:16 AM, Marijn Suijten wrote:
This exact same math is used to compute bytes_in_slice above in
dsi_update_dsc_timing(), also used to fill slice_chunk_size.
Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data")
Signed-off-by: Marijn Suijten
Reviewed-by: Abh
Hi Robert
Thanks for the review.
On 10/4/2022 8:55 AM, Robert Foss wrote:
On Mon, 29 Aug 2022 at 20:23, Abhinav Kumar wrote:
adv7533 bridge tries to dynamically switch lanes based on the
mode by detaching and attaching the mipi dsi device.
This approach is incorrect because this method
On 10/7/2022 6:56 AM, Robert Foss wrote:
On Thu, 6 Oct 2022 at 17:07, Abhinav Kumar wrote:
Hi Robert
Thanks for the review.
On 10/4/2022 8:55 AM, Robert Foss wrote:
On Mon, 29 Aug 2022 at 20:23, Abhinav Kumar wrote:
adv7533 bridge tries to dynamically switch lanes based on the
mode
hkov
Signed-off-by: Abhinav Kumar
Reviewed-by: Robert Foss
Link:
https://lore.kernel.org/r/1661797363-7564-1-git-send-email-quic_abhin...@quicinc.com
---
drivers/gpu/drm/bridge/adv7511/adv7511.h | 3 ++-
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 18 ++
drivers/gpu/drm/bridge/a
On 9/2/2022 12:05 PM, Dmitry Baryshkov wrote:
On Fri, 2 Sept 2022 at 21:07, Abhinav Kumar wrote:
On 9/1/2022 11:06 PM, Dmitry Baryshkov wrote:
On 2 September 2022 03:24:17 GMT+03:00, Abhinav Kumar
wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
To let the probe function
On 9/1/2022 11:06 PM, Dmitry Baryshkov wrote:
On 2 September 2022 03:24:17 GMT+03:00, Abhinav Kumar
wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
To let the probe function bail early if any of the resources is
unavailable, move resource allocattion from kms_init directly
On 10/4/2022 3:11 PM, Marijn Suijten wrote:
On 2022-10-04 10:03:07, Abhinav Kumar wrote:
On 10/1/2022 12:08 PM, Marijn Suijten wrote:
According to the comment this DPU register contains the bits per pixel
as a 6.4 fractional value, conveniently matching the contents of
bits_per_pixel
On 10/4/2022 3:39 PM, Marijn Suijten wrote:
On 2022-10-04 15:31:10, Abhinav Kumar wrote:
On 10/4/2022 2:57 PM, Marijn Suijten wrote:
[..]
Alas, as explained in the cover letter I opted to perform the masking in
the PPS packing code as the DSC block code also reads these values, and
would
t.
Signed-off-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
---
Changes in v3:
- Update commit message to point at the git hash of the regulator change.
Changes in v2:
- ("Use the new regulator bulk feature to specify the load") new for v2.
drivers/gpu/drm/msm/ds
n
Agree with Marijn's comment here:
https://patchwork.freedesktop.org/patch/496153/?series=106731=2#comment_894595
Will queue for -fixes with the fixes tag he has given
Reviewed-by: Abhinav Kumar
---
(no changes since v2)
Changes in v2:
- ("Fix number of regulators for SDM660") ne
On 8/2/2022 3:37 PM, Douglas Anderson wrote:
3 regulators are specified listed but the number 2 is specified. Fix
it.
Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg")
Signed-off-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
Will queue this for -fixes.
---
(
r.
Signed-off-by: Douglas Anderson
Yes, apart from Dmitry's suggestion of updating the commit text about
the return value change, this is:
Reviewed-by: Abhinav Kumar
---
Changes in v3:
- ("Improve dsi_phy_driver_probe() probe error handling") new for v3.
drivers/gpu/drm/msm/ds
o be noted that the regulator functions
regulator_bulk_enable() and regulator_set_load() already print error
messages when they encounter problems so while moving things around we
get rid of some extra error prints.
Signed-off-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
---
Changes in v3:
- Fix typo
kay with DSI and DSI PHY being in one patch,
Reviewed-by: Abhinav Kumar
---
Changes in v3:
- Do all the PHYs too.
- Get rid of error print after devm_regulator_bulk_get_const().
- Just directly call the bulk commands; get rid of the wrapper.
- Update commit message to point at the git hash of
On 8/10/2022 10:22 AM, Kuogee Hsieh wrote:
dp_bridge_disable() is the first step toward tearing down main link.
Its major function is to start transmitting idle pattern to replace
video stream. This patch will check hpd_state to make sure main link
is enabled before commit changes of main
Hi Stephen
On 8/10/2022 5:09 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-10 16:57:51)
On 8/10/2022 3:22 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-10 12:25:51)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index b36f8b6..678289a
LGTM as well, hence
Reviewed-by: Abhinav Kumar
---
Changes in v3:
- Drop the msm_shutdown_hw() wrapper and just call drm_atomic_helper_shutdown()
in both callbacks (Dmitry Baryshkov).
- Copy the comment in msm_drm_uninit() to msm_drv_shutdown() (Dmitry Baryshkov).
Changes in v2:
- Take the
Hi Laurent
Thanks for the response.
On 8/9/2022 12:40 PM, Laurent Pinchart wrote:
Hi Abhinav,
Thank you for the patch.
On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
adv7533 bridge tries to dynamically switch lanes based on the
mode by detaching and attaching the mipi dsi
On 8/9/2022 1:44 PM, Kuogee Hsieh wrote:
dp_bridge_disable() is the first step toward tearing down main link.
Its major function is to start transmitting idle pattern to replace
video stream. This patch will check hpd_state to make sure main link
is enabled before commit changes of main
4_sync+0x18c/0x190
Due to above reasons, remove the dynamic lane switching
code from adv7533 bridge chip and filter out the modes
which would need different number of lanes as compared
to the initialization time using the mode_valid callback.
Suggested-by: Dmitry Baryshkov
Signed-off-by: Abhinav
: add yaml schemas for DSI
PHY bindings")
Reviewed-by: Abhinav Kumar
---
Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
b/Documentation/devicetree/bindings/d
: msm: dsi: add yaml schemas for DSI
PHY bindings")
Reviewed-by: Abhinav Kumar
---
Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
b/Documentation/devicetre
sable back to
mdss")
Signed-off-by: Miaoqian Lin
Reviewed-by: Abhinav Kumar
---
changes in v2:
- move getting path1 after error check for path0.
---
drivers/gpu/drm/msm/msm_mdss.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/d
On 1/9/2023 7:00 PM, Dmitry Baryshkov wrote:
On 10/01/2023 04:56, Abhinav Kumar wrote:
On 1/9/2023 6:47 PM, Dmitry Baryshkov wrote:
On 10/01/2023 04:40, Abhinav Kumar wrote:
On 1/9/2023 5:19 PM, Dmitry Baryshkov wrote:
On 27/10/2022 20:36, Dmitry Baryshkov wrote:
On 22/09/2022 03:49
On 1/9/2023 6:25 PM, Dmitry Baryshkov wrote:
On 10/01/2023 04:21, Abhinav Kumar wrote:
On 1/9/2023 5:34 PM, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Re-arrange the dsi_calc_pclk method to two helpers, one to
compute the DSI byte clk and the other to compute
On 1/9/2023 5:19 PM, Dmitry Baryshkov wrote:
On 27/10/2022 20:36, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Currently there is no protection against a user trying to set
an unsupported mode on DSI. Implement a check based on the opp
table whether the byte clock
On 1/9/2023 6:16 PM, Jiasheng Jiang wrote:
Add check for the return value of alloc_ordered_workqueue as it may return
NULL pointer and cause NULL pointer dereference.
Signed-off-by: Jiasheng Jiang
Reviewed-by: Abhinav Kumar
---
Changelog:
v2 -> v3:
1. Simply return -ENOMEM inst
On 1/9/2023 6:47 PM, Dmitry Baryshkov wrote:
On 10/01/2023 04:40, Abhinav Kumar wrote:
On 1/9/2023 5:19 PM, Dmitry Baryshkov wrote:
On 27/10/2022 20:36, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Currently there is no protection against a user trying to set
On 1/9/2023 5:34 PM, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Re-arrange the dsi_calc_pclk method to two helpers, one to
compute the DSI byte clk and the other to compute the pclk.
This makes the separation of the two clean and also allows
clients to compute and use
On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote:
Fix another oops reproducible when rebooting the board with the Adreno
GPU wokring in the headless mode (e.g. iMX platforms).
wokring ---> working
Unable to handle kernel NULL pointer dereference at virtual address
when read
[]
b6e0e5f6
Code: 15922088 1184421c e153 1af8 (e5953000)
---[ end trace ]---
Fixes: 0a58d2ae572a ("drm/msm: Make .remove and .shutdown HW shutdown
consistent")
Reported-by: kernel test robot
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
Change
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
To simplify adding new platforms and to make settings more obvious,
rewrite the UBWC setup to use the data structure to pass platform config
rather than just calling the functions direcly.
Why not use the catalog to store this information rather
On 1/9/2023 12:17 PM, Dmitry Baryshkov wrote:
On 09/01/2023 21:53, Abhinav Kumar wrote:
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
To simplify adding new platforms and to make settings more obvious,
rewrite the UBWC setup to use the data structure to pass platform config
rather than
On 1/9/2023 1:11 PM, Dmitry Baryshkov wrote:
On 09/01/2023 22:32, Abhinav Kumar wrote:
On 1/9/2023 12:17 PM, Dmitry Baryshkov wrote:
On 09/01/2023 21:53, Abhinav Kumar wrote:
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
To simplify adding new platforms and to make settings more
this check otherwise it will break bootup on those devices.
changes in v2:
- drop dev_pm_opp_get_opp_table() usage
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/15
Reported-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 25
lines
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.h | 2 ++
drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++---
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h
index 2a96b4fe7839
this check otherwise it will break bootup on those devices.
changes in v2:
- drop dev_pm_opp_get_opp_table() usage
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/15
Reported-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 25
lines
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.h | 2 ++
drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++---
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h
index 2a96b4fe7839
lines
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi.h | 2 ++
drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++---
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h
index 2a96b4fe7839
this check otherwise it will break bootup on those devices.
changes in v3:
- make the comment shorter
- handle all errors except ENODEV
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/15
Reported-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi
On 1/11/2023 2:56 PM, Dmitry Baryshkov wrote:
On 12/01/2023 00:52, Abhinav Kumar wrote:
Currently there is no protection against a user trying to set
an unsupported mode on DSI. Implement a check based on the opp
table whether the byte clock for the mode can be supported by
validating
limit for each line.
With that fixed,
Reviewed-by: Abhinav Kumar
Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for
reset.")
Signed-off-by: Jiasheng Jiang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 -
1 file changed, 4 insertions(+),
On 12/5/2022 8:37 AM, Robert Foss wrote:
Add compatibles string, "qcom,sm8350-dpu", for the display processing unit
used on Qualcomm SM8350 platform.
Signed-off-by: Robert Foss
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +
1 file changed, 1
On 12/5/2022 8:37 AM, Robert Foss wrote:
Add compatibility for SM8350 display subsystem, including
required entries in DPU hw catalog.
Signed-off-by: Robert Foss
---
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 196 ++
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h|
On 12/12/2022 5:34 PM, Abhinav Kumar wrote:
On 12/10/2022 10:50 PM, Christophe JAILLET wrote:
If an error occurs after a successful msm_hdmi_get_phy() call, it must be
undone by a corresponding msm_hdmi_put_phy(), as already done in the
remove function.
Fixes: 437365464043 ("drm/msm
Hi Dmitry
On 12/12/2022 2:35 PM, Dmitry Baryshkov wrote:
On Mon, 12 Dec 2022 at 19:51, Kuogee Hsieh wrote:
On 12/8/2022 4:35 PM, Dmitry Baryshkov wrote:
On 09/12/2022 02:22, Kuogee Hsieh wrote:
On 12/8/2022 4:11 PM, Dmitry Baryshkov wrote:
On 09/12/2022 01:38, Kuogee Hsieh wrote:
On
probe()")
Signed-off-by: Christophe JAILLET
Reviewed-by: Abhinav Kumar
---
Not sure if the Fixes tag is correct. At least it is when the probe needs
to be fixed but the issue was maybe there elsewhere before.
Seems right to me.
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 12 ++-
On 12/15/2022 1:15 PM, Dmitry Baryshkov wrote:
On 15/12/2022 22:10, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-12-15 10:46:42)
On 15/12/2022 20:32, Kuogee Hsieh wrote:
if (!aux->cmd_busy)
return;
if (aux->native)
-
to only use a single slice per packet (and
strangely not the number of slices that could fit on the interface).
Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration")
Like others have said, with SOB,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c |
On 12/14/2022 5:08 PM, Dmitry Baryshkov wrote:
On 14/12/2022 21:30, Marijn Suijten wrote:
On 2022-12-14 20:43:29, Dmitry Baryshkov wrote:
On 14/12/2022 01:22, Marijn Suijten wrote:
Active CTLs have to configure what DSC block(s) have to be enabled, and
what DSC block(s) have to be flushed;
ation")
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index b83cf70b1adb..0686c35a6fd4 100644
--- a/d
On 12/13/2022 3:22 PM, Marijn Suijten wrote:
All V1 CTL blocks (active CTLs) explicitly bind the pixel output from a
DSC block to a PINGPONG block by setting the PINGPONG idx in a DSC
hardware register.
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm
On 12/13/2022 3:22 PM, Marijn Suijten wrote:
These blocks on CTL V1 support setting a PINGPONG idx to send pixel
output to.
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
.../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 23 ++-
1 file changed, 17
pport")
Signed-off-by: Kuogee Hsieh
There should be no empty lines between the tags.
Tested-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_aux.c | 87
+
1 file changed, 63 insertions(+), 24 deletions(-)
diff --git
is what this fix is doing.
Its not completing any interrupt, its just returning early if no aux
interrupt fired.
So based on the logs I have seen and given that its fixing this
stability issue.
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Reviewed-by: Abhinav Kumar
On 12/13/2022 5:13 AM, Krzysztof Kozlowski wrote:
On 13/12/2022 00:41, Abhinav Kumar wrote:
besides, i think i have to sent the whole series patches include this
one to address your new comments on other patch.
is this correct?
No. Please fix your system first, validate your patches
Hi Doug
On 12/14/2022 4:14 PM, Doug Anderson wrote:
Hi,
On Wed, Dec 14, 2022 at 3:46 PM Abhinav Kumar wrote:
Hi Doug
On 12/14/2022 2:29 PM, Doug Anderson wrote:
Hi,
On Wed, Dec 14, 2022 at 1:21 PM Kuogee Hsieh wrote:
There are 3 possible interrupt sources are handled by DP controller
Hi Stephen
On 12/14/2022 4:29 PM, Stephen Boyd wrote:
Quoting Doug Anderson (2022-12-14 16:14:42)
Hi,
On Wed, Dec 14, 2022 at 3:46 PM Abhinav Kumar wrote:
Hi Doug
On 12/14/2022 2:29 PM, Doug Anderson wrote:
Hi,
On Wed, Dec 14, 2022 at 1:21 PM Kuogee Hsieh wrote:
There are 3 possible
your lines are wrapped around too early, please use the full
character limit for the commit text.
With that fixed,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/g
:
Fixes: b93bdff44a85 ("dt-bindings: display/msm: add support for SM6115")
Fixes: 06097b13ef97 ("dt-bindings: display/msm: split dpu-qcm2290 into
DPU and MDSS parts")
Reviewed-by: Abhinav Kumar
We will pick this into msm-fixes during the next cycle.
Yes, we can with
quot;drm/msm/dpu: add the writeback connector layer")
Signed-off-by: Hui Tang
With that nit fixed,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
b/driver
Hi Dmitry
Sorry for the late response.
On 10/31/2022 5:20 PM, Dmitry Baryshkov wrote:
On 28/10/2022 01:22, Abhinav Kumar wrote:
On 10/27/2022 10:35 AM, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Re-arrange the dsi_calc_pclk method to two helpers, one to
compute
On 12/13/2022 2:11 PM, Dmitry Baryshkov wrote:
On 13 December 2022 23:53:48 EET, Abhinav Kumar
wrote:
On 12/1/2022 11:54 AM, Dmitry Baryshkov wrote:
On 30/11/2022 22:09, Adam Skladowski wrote:
Follow other YAMLs and replace mdss name into display-subystem.
Signed-off-by: Adam
in 'dpu_encoder_phys_wb_init'
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3067
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
writeback")
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm
On 11/16/2022 7:18 AM, Dmitry Baryshkov wrote:
On 16/11/2022 18:11, Abhinav Kumar wrote:
On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote:
On 16/11/2022 17:30, Kalyan Thota wrote:
Since DRM encoder type for few encoders can be similar
(like eDP and DP) find out if the interface supports HPD
On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote:
On 16/11/2022 17:30, Kalyan Thota wrote:
Since DRM encoder type for few encoders can be similar
(like eDP and DP) find out if the interface supports HPD
from encoder bridge to differentiate between builtin
and pluggable displays.
Changes in v1:
hdmi' (see line 119)
Fixes: 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function")
Signed-off-by: Dan Carpenter
Reviewed-by: Abhinav Kumar
---
v2: Add a Fixes tag. Re-work the commit message.
drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +--
1 file changed, 1 inser
On 11/25/2022 1:21 AM, Dmitry Baryshkov wrote:
On 25/11/2022 07:45, Abhinav Kumar wrote:
On 11/24/2022 4:02 PM, Dmitry Baryshkov wrote:
Since the commit commit c6122688f265 ("drm/msm/mdp5: stop overriding
drvdata") reading the MDP5 hw revision on db410c will crash the board
as the
On 11/16/2022 1:43 AM, Dmitry Baryshkov wrote:
On 16/11/2022 12:29, Abhinav Kumar wrote:
On 11/16/2022 1:18 AM, Dmitry Baryshkov wrote:
On 16/11/2022 11:30, Abhinav Kumar wrote:
On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote:
On 16/11/2022 10:50, Abhinav Kumar wrote:
On 11/4/2022 6
On 11/16/2022 1:18 AM, Dmitry Baryshkov wrote:
On 16/11/2022 11:30, Abhinav Kumar wrote:
On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote:
On 16/11/2022 10:50, Abhinav Kumar wrote:
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote:
On sm8450 a register block was removed from MDP TOP
concerned whether
this would impact SM8150 as that re-uses the IRQ_SDM845_MASK but even
SM8150 doesnt have INTF4.
A minor nit, the subject convention in this file seems to be drm/msm/dpu
and not drm/msm/dpu1.
Other than that,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
.c:141 msm_hdmi_init()
warn: variable dereferenced before check 'hdmi' (see line 119)
Signed-off-by: Dan Carpenter
Can you please add the fixes tag to point to the commit you have
referenced in the commit message?
LTGM,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +--
On 11/15/2022 5:30 AM, Robert Foss wrote:
The sc7280_pp declaration is not located by the other _pp
declarations, but rather hidden around the _merge_3d
declarations. Let's fix this to avoid confusion.
Signed-off-by: Robert Foss
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 11/22/2022 3:12 PM, Dmitry Baryshkov wrote:
On sm8450 a register block was removed from MDP TOP. Accessing it during
snapshotting results in NoC errors / immediate reboot. Skip accessing
these registers during snapshot.
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
Reviewed-by: Konrad
On 11/7/2022 3:02 PM, Dmitry Baryshkov wrote:
On 07/11/2022 07:27, Abhinav Kumar wrote:
On 9/22/2022 4:30 AM, Dmitry Baryshkov wrote:
SM8350 and SM8450 use 5nm DSI PHYs, which share register definitions
with 7nm DSI PHYs. Rather than duplicating the driver, handle 5nm
variants inside
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote:
Add support for DSI 2.6.0 (block used on sm8450).
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++
drivers/gpu/drm/msm/dsi/dsi_cfg.h
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote:
On sm8450 a register block was removed from MDP TOP. Accessing it during
snapshotting results in NoC errors / immediate reboot. Skip accessing
these registers during snapshot.
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
Signed-off-by: Dmitry
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote:
Add support for the MDSS block on SM8450 platform.
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_mdss.c | 5 +
1 file changed, 5 insertions
On 11/16/2022 12:19 AM, Dmitry Baryshkov wrote:
On 16/11/2022 10:50, Abhinav Kumar wrote:
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote:
On sm8450 a register block was removed from MDP TOP. Accessing it during
snapshotting results in NoC errors / immediate reboot. Skip accessing
On 11/23/2022 1:04 PM, Dmitry Baryshkov wrote:
On sm8450 a register block was removed from MDP TOP. Accessing it during
snapshotting results in NoC errors / immediate reboot. Skip accessing
these registers during snapshot.
Tested-by: Vinod Koul
Reviewed-by: Vinod Koul
Reviewed-by: Konrad
On 11/15/2022 5:33 AM, Konrad Dybcio wrote:
On 15/11/2022 14:30, Robert Foss wrote:
The sc7280_pp declaration is not located by the other _pp
declarations, but rather hidden around the _merge_3d
declarations. Let's fix this to avoid confusion.
Signed-off-by: Robert Foss
Reviewed-by:
On 11/24/2022 4:02 PM, Dmitry Baryshkov wrote:
Since the commit commit c6122688f265 ("drm/msm/mdp5: stop overriding
drvdata") reading the MDP5 hw revision on db410c will crash the board
as the MDSS_GDSC is not enabled. Revert a part of the offending commit
(moving rpm enablement) and set
full value here for easier
correlation instead of only adding the `irq_idx / 32` part.
Furthermore, make the dbgstr messages more consistent.
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 12 ++--
1 file changed, 6
On 12/7/2022 6:28 AM, Dmitry Baryshkov wrote:
Several small corrections for the UBWC setup and related data.
I am assuming this series will be dropped in favor of the RFC:
https://patchwork.freedesktop.org/series/111751/
Right?
Dmitry Baryshkov (3):
drm/msm/dpu: handle UBWC 1.0 in
On 1/2/2023 7:47 AM, Dmitry Baryshkov wrote:
The frame event callback is always set to dpu_crtc_frame_event_cb() (or
to NULL) and the data is always either the CRTC itself or NULL
(correpondingly). Thus drop the event callback registration, call the
dpu_crtc_frame_event_cb() directly and gate
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
According to the vendor DT, sm6115 has UBWC 1.0, not 2.0.
Can you please point me to which file you are referring to?
The internal docs I have are still showing 2.0.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/msm_mdss.c | 2
.
Reviewed-by: Abhinav Kumar
With a few minor comments below.
Also, I did a quick check if this would conflict with PSR but this
change wont, probably the next one will so this one should be okay.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17
On 1/11/2023 2:21 PM, Marijn Suijten wrote:
On 2023-01-11 17:11:03, Dmitry Baryshkov wrote:
On 11/01/2023 10:44, Marijn Suijten wrote:
On 2023-01-09 12:32:18, Abhinav Kumar wrote:
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
+struct msm_mdss_data {
+ u32 ubwc_version;
+ u32
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
Add platform data for sc8180xp based on sdmshrike-sde.dtsi.
Signed-off-by: Dmitry Baryshkov
This matches up the docs I have, hence,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_mdss.c | 8 +++-
1 file changed, 7 insertions
On 1/13/2023 1:16 PM, Dmitry Baryshkov wrote:
On Fri, 13 Jan 2023 at 21:47, Abhinav Kumar wrote:
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
According to the vendor DT, sm6115 has UBWC 1.0, not 2.0.
Can you please point me to which file you are referring to?
The internal docs I have
On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote:
Add the platform data for sdm845 platform.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_mdss.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm
current masks for it and just renaming,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1
to crtc->debugfs_entry,
effetively merging two debugfs dirs.
Signed-off-by: Dmitry Baryshkov
Makes sense to me and also verified it on my chromebook.
Reviewed-by: Abhinav Kumar
Tested-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 8 ++--
1 file changed
On 1/11/2023 7:38 PM, Jiapeng Chong wrote:
Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the
dpu_hw_catalog.c file, but not used elsewhere, so remove these unused
variables.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused
variable 'sc8280xp_regdma'.
On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
SC8280XP configuration missed the reg_dma configuration. We do not use
regdma for now, but let's put the correct pointer anyway.
Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP")
Signed-off-by: Dmitry Baryshkov
---
On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
Correct sm8350_dpu_cfg.dma_cfg to point to sm8350_regdma rather than
sm8250_regdma.
Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
1
On 1/17/2023 6:09 PM, Dmitry Baryshkov wrote:
On 18/01/2023 04:08, Abhinav Kumar wrote:
On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
SC8280XP configuration missed the reg_dma configuration. We do not use
regdma for now, but let's put the correct pointer anyway.
Fixes: 4a352c2fc15a (&quo
On 1/17/2023 6:09 PM, Abhinav Kumar wrote:
On 1/17/2023 6:04 PM, Dmitry Baryshkov wrote:
Correct sm8350_dpu_cfg.dma_cfg to point to sm8350_regdma rather than
sm8250_regdma.
Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog")
Signed-off-by: Dmitry Baryshkov
---
drive
On 1/17/2023 6:05 PM, Dmitry Baryshkov wrote:
Describe missing dpu_encoder_phys_wb_is_master() argument and struct
dpu_encoder_virt.wide_bus_en field.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 +
drivers
901 - 1000 of 2092 matches
Mail list logo
