Re: [PATCH next] drm/amdgpu: Fix unsigned comparison with zero in gmc_v9_0_process_interrupt()

2023-05-22 Thread Alex Deucher
Applied. Thanks! On Mon, May 22, 2023 at 3:30 AM Harshit Mogalapalli wrote: > > Smatch warns: > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:579: > unsigned 'xcc_id' is never less than zero. > > gfx_v9_4_3_ih_to_xcc_inst() returns negative numbers as well. > Fix this by changing type

Re: [PATCH][next] drm/amdgpu: Fix a couple of spelling mistakes in info and debug messages

2023-05-22 Thread Alex Deucher
Applied. Thanks! On Mon, May 22, 2023 at 5:02 AM Colin Ian King wrote: > > There are a couple of spelling mistakes, one in a dev_info message > and the other in a dev_debug message. Fix them. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- >

Re: [PATCH] drm/radeon: fix possible division-by-zero errors

2023-05-19 Thread Alex Deucher
In practice this should never happen. Applied with some minor coding style fixes. Alex On Fri, May 19, 2023 at 11:33 AM Nikita Zhandarovich wrote: > > Function rv740_get_decoded_reference_divider() may return 0 due to > unpredictable reference divider value calculated in >

Re: [PATCH] drm/radeon: stop including swiotlb.h

2023-05-19 Thread Alex Deucher
Applied. Thanks! On Thu, May 18, 2023 at 9:52 AM Christoph Hellwig wrote: > > radeon does not need swiotlb.h, so stop including it. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/radeon/radeon_ttm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] drm/amdgpu: stop including swiotlb.h

2023-05-19 Thread Alex Deucher
Applied. Thanks! On Thu, May 18, 2023 at 9:52 AM Christoph Hellwig wrote: > > amdgpu does not need swiotlb.h, so stop including it. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_can_queue()

2023-05-19 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Thu, May 18, 2023 at 9:03 AM Luben Tuikov wrote: > > On 2023-05-17 19:35, Luben Tuikov wrote: > > Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former > > is misleading, as it wakes up the GPU scheduler _only

Re: linux-next: build failure after merge of the amdgpu tree

2023-05-19 Thread Alex Deucher
On Thu, May 18, 2023 at 8:06 PM Stephen Rothwell wrote: > > Hi all, > > After merging the amdgpu tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c: In function 'amdgpu_ctx_init': > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c:348:26:

Re: [PATCH 1/2] amdgpu: validate drm_amdgpu_gem_va addrs for all ops

2023-05-18 Thread Alex Deucher
On Wed, May 17, 2023 at 5:27 PM Chia-I Wu wrote: > > On Tue, May 9, 2023 at 11:33 AM Chia-I Wu wrote: > > > > Extend the address and size validations to AMDGPU_VA_OP_UNMAP and > > AMDGPU_VA_OP_CLEAR by moving the validations to amdgpu_gem_va_ioctl. > > > > Internal users of amdgpu_vm_bo_map are

[pull] amdgpu drm-fixes-6.4

2023-05-18 Thread Alex Deucher
Alex Deucher (2): drm/amdgpu/gfx11: update gpu_clock_counter logic drm/amdgpu/gmc11: implement get_vbios_fb_size() Bas Nieuwenhuizen (1): drm/amdgpu/gfx10: Disable gfxoff before disabling powergating. Evan Quan (1): drm/amd/pm: fix possible power mode mismatch between driver

Re: [PATCH] drm/radeon: Remove unnecessary (void*) conversions

2023-05-17 Thread Alex Deucher
On Wed, May 17, 2023 at 3:08 AM Su Hui wrote: > > No need cast (void*) to (struct radeon_device *) > or (struct radeon_ring *). > > Signed-off-by: Su Hui Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/r100.c | 8 > drivers/gpu/drm/radeon/r300.c | 2 +- >

Re: [PATCH 2/2] drm/scheduler: avoid infinite loop if entity's dependency is a scheduled error fence

2023-05-17 Thread Alex Deucher
On Wed, May 17, 2023 at 11:02 AM Alex Deucher wrote: > > + dri-devel for scheduler > > On Tue, May 9, 2023 at 6:23 AM ZhenGuo Yin wrote: > > > > [Why] > > drm_sched_entity_add_dependency_cb ignores the scheduled fence and return > > false. > > If entit

Re: [PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Alex Deucher
because there are more jobs to clean, but whether we can queue > more jobs is irrelevant. > > Cc: Christian König > Cc: Alex Deucher > Signed-off-by: Luben Tuikov > --- > drivers/gpu/drm/scheduler/sched_entity.c | 4 ++-- > drivers/gpu/drm/scheduler/sched_main.c | 6 +++--- >

Re: [PATCH 1/2] drm/sched: Rename to drm_sched_can_queue()

2023-05-17 Thread Alex Deucher
On Wed, May 17, 2023 at 3:04 PM Luben Tuikov wrote: > > Rename drm_sched_ready() to drm_sched_can_queue(). "ready" can mean many > things and is thus meaningless in this context. Instead, rename to a name > which precisely conveys what is being checked. > > Cc: Christi

Re: [PATCH 2/2] drm/scheduler: avoid infinite loop if entity's dependency is a scheduled error fence

2023-05-17 Thread Alex Deucher
+ dri-devel for scheduler On Tue, May 9, 2023 at 6:23 AM ZhenGuo Yin wrote: > > [Why] > drm_sched_entity_add_dependency_cb ignores the scheduled fence and return > false. > If entity's dependency is a schedulerd error fence and drm_sched_stop is > called > due to TDR, drm_sched_entity_pop_job

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-05-16 Thread Alex Deucher
On Tue, May 16, 2023 at 4:05 AM Jani Nikula wrote: > > On Thu, 09 Mar 2023, Jani Nikula wrote: > > On Thu, 09 Mar 2023, Christian König wrote: > >> Am 09.03.23 um 13:37 schrieb Jani Nikula: > >>> Make the struct ttm_device_funcs pointers const so the data can be placed > >>> in rodata. > >>> >

Re: [PATCH] drm:amd:amdgpu: Fix missing buffer object unlock in failure path

2023-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 15, 2023 at 6:27 PM Sukrut Bellary wrote: > > > On 5/3/23 16:15, Sukrut Bellary wrote: > > smatch warning - > > 1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume() > > warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'. > > > > 2)

Re: [PATCH] drm/amdgpu: remove unnecessary (void*) conversions

2023-05-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 15, 2023 at 3:18 AM Su Hui wrote: > > No need cast (void*) to (struct amdgpu_device *). > > Signed-off-by: Su Hui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- >

Re: [PATCH] drm/amdgpu: remove unnecessary (void*) conversions

2023-05-15 Thread Alex Deucher
On Mon, May 15, 2023 at 3:17 AM Dan Carpenter wrote: > > On Mon, May 15, 2023 at 09:34:28AM +0800, Su Hui wrote: > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > index f60753f97ac5..c837e0bf2cfc 100644 > > ---

[pull] amdgpu drm-fixes-6.4

2023-05-11 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.4-2023-05-11 for you to

[PATCH 2/3] drm/amdgpu: Set TTM pools for memory partitions

2023-05-09 Thread Alex Deucher
to false for pool init) Reviewed-by: Felix Kuehling Acked-and-tested-by: Mukul Joshi Signed-off-by: Philip Yang Signed-off-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 61 - drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1

[PATCH 3/3] drm/amdkfd: Native mode memory partition support

2023-05-09 Thread Alex Deucher
ked-and-tested-by: Mukul Joshi Signed-off-by: Philip Yang Signed-off-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_tt

[PATCH 1/3] drm/ttm: export ttm_pool_fini for cleanup

2023-05-09 Thread Alex Deucher
From: Rajneesh Bhardwaj ttm_pool_init is exported and used outside of ttm subsystem with amdgpu_ttm interface, similarly export ttm_pool_fini for proper cleanup. Reviewed-by: Felix Kuehling Signed-off-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- drivers/gpu/drm/ttm/ttm_pool.c | 1

Re: [PATCH] drm/sched: Check scheduler work queue before calling timeout handling

2023-05-09 Thread Alex Deucher
+ dri-devel On Tue, May 9, 2023 at 5:43 PM wrote: > > From: Vitaly Prosyak > > During an IGT GPU reset test we see again oops despite of > commit 0c8c901aaaebc9bf8bf189ffc116e678f7a2dc16 > drm/sched: Check scheduler ready before calling timeout handling. > > It uses ready condition whether to

Re: [PATCH] drm/amdgpu: Remove the unused variable golden_settings_gc_9_4_3

2023-05-08 Thread Alex Deucher
Applied. Thanks! On Sat, May 6, 2023 at 4:11 AM Jiapeng Chong wrote: > > Variable golden_settings_gc_9_4_3 is not effectively used, so delete it. > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:48:38: warning: > ‘golden_settings_gc_9_4_3’ defined but not used. > > Reported-by: Abaci Robot > Link:

Re: [PATCH] drm/amdgpu: remove unneeded semicolon

2023-05-05 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 5, 2023 at 3:43 AM Jiapeng Chong wrote: > > No functional modification involved. > > ./drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c:146:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4871 >

Re: [PATCH V2] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-05 Thread Alex Deucher
On Fri, May 5, 2023 at 2:39 PM WANG Xuerui wrote: > > On 5/6/23 02:00, Alex Deucher wrote: > > On Fri, May 5, 2023 at 1:57 PM WANG Xuerui wrote: > >> > >> On a side note, I had to modprobe amdgpu with runpm=0, otherwise my > >> dmesg gets flooded with

Re: [PATCH V2] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-05 Thread Alex Deucher
On Fri, May 5, 2023 at 1:57 PM WANG Xuerui wrote: > > Hi, > > On 5/5/23 21:39, Hamza Mahfooz wrote: > > > > Hey Huacai, > > > > On 5/5/23 07:32, Huacai Chen wrote: > >> Now LoongArch provides kernel_fpu_begin() and kernel_fpu_end() in commit > >> 2b3bd32ea3a22ea2d ("LoongArch: Provide kernel fpu

[pull] amdgpu drm-fixes-6.4

2023-05-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit d893f39320e1248d1c97fde0d6e51e5ea008a76b: drm/amd/display: Lowering min Z8 residency time (2023-04-26 22:53:58 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 11:22 AM Timur Kristóf wrote: > > On Tue, 2023-05-02 at 09:45 -0400, Alex Deucher wrote: > > On Tue, May 2, 2023 at 9:35 AM Timur Kristóf > > wrote: > > > > > > Hi, > > > > > > On Tue, 2023-05-02 at 13:14 +0200, Chri

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:35 AM Timur Kristóf wrote: > > Hi, > > On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > > > Christian König ezt írta (időpont: 2023. > > > máj. 2., Ke 9:59): > > > > > > > Am 02.05.23 um 03:26

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:34 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 02.05.23 15:13, Alex Deucher wrote: > > On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > > > >> On 30.04.23 13:44, Felix Richter

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing the regression list, as it should be in the loop for regressions: > https://docs.kernel.org/admin-guide/reporting-regressions.html] > > [TLDR: I'm adding this report to the list of tracked Linux kernel

Re: [RFC PATCH 1/1] drm/amdgpu: Add interface to dump guilty IB on GPU hang

2023-05-01 Thread Alex Deucher
On Mon, May 1, 2023 at 2:58 PM André Almeida wrote: > > Add an interface to point out to userspace the guilty indirect buffer > when a GPU reset happens, so the usermode driver can dump just the right > IB for debug investigation. > > Signed-off-by: André Almeida > --- >

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-01 Thread Alex Deucher
On Mon, May 1, 2023 at 2:58 PM André Almeida wrote: > > Currently UMD hasn't much information on what went wrong during a GPU reset. > To > help with that, this patch proposes a new IOCTL that can be used to query > information about the resources that caused the hang. If we went with the

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-01 Thread Alex Deucher
On Mon, May 1, 2023 at 2:44 PM Felix Richter wrote: > > On 01.05.23 15:27, Alex Deucher wrote: > > On Mon, May 1, 2023 at 3:20 AM Felix Richter > > wrote: > >> Hi, > >> > >> I am running into an issue with the integrated GPU of the Ryzen 9 7950X.

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-01 Thread Alex Deucher
On Mon, May 1, 2023 at 3:20 AM Felix Richter wrote: > > Hi, > > I am running into an issue with the integrated GPU of the Ryzen 9 7950X. It > seems to be a regression from kernel version 6.1 to 6.2. > The bug materializes in from of my monitor blinking, meaning it turns full > white shortly.

Re: [PATCH v3 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-28 Thread Alex Deucher
these? https://patchwork.freedesktop.org/series/116699/ https://patchwork.freedesktop.org/series/116695/ On Thu, Apr 27, 2023 at 8:45 PM whitehat002 whitehat002 wrote: > > Alex,I have a question, why I don't see it on the > https://patchwork.freedesktop.org/ > > Alex Deucher 于202

Re: [PATCH v3] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-27 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 26, 2023 at 6:55 PM Chia-I Wu wrote: > > mgr->ctx_handles should be protected by mgr->lock. > > v2: improve commit message > v3: add a Fixes tag > > Signed-off-by: Chia-I Wu > Reviewed-by: Christian König > Fixes: 52c6a62c64fac ("drm/amdgpu: add interface

Re: [PATCH v3 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-27 Thread Alex Deucher
As per my prior reply, it has been applied. Thanks, Alex On Thu, Apr 27, 2023 at 8:39 AM whitehat002 whitehat002 wrote: > > hello > What is the current status of this patch, has it been applied? > > > hackyzh002 于2023年4月19日周三 20:23写道: > > > > The type of size is unsigned int, if size is

[pull] amdgpu drm-fixes-6.4

2023-04-26 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. A bit bigger than usual since it's two weeks worth. Mostly display fixes. The following changes since commit e82c98f2ca439356d5595ba8c9cd782f993f6f8c: Merge tag 'amd-drm-next-6.4-2023-04-14' of https://gitlab.freedesktop.org/agd5f/linux into drm-next

Re: [PATCH 2/2] modules/firmware: add a new option to denote a firmware group to choose one.

2023-04-26 Thread Alex Deucher
; > Cc: Luis Chamberlain > Cc: linux-modu...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Dave Airlie I think this is a very useful feature, Reviewed-by: Alex Deucher > --- > include/linux/module.h | 22 ++ > 1 file changed, 22 insert

Re: [PATCH] drm:amd:amdgpu: Fix missing bo unlock in failure path

2023-04-24 Thread Alex Deucher
On Mon, Apr 24, 2023 at 3:07 AM Christian König wrote: > > Am 24.04.23 um 07:59 schrieb Sukrut Bellary: > > smatch warning - inconsistent handling of buffer object reserve > > and unreserve. > > > > Signed-off-by: Sukrut Bellary > > For now that patch is Reviewed-by: Christian König > .

[pull] amdgpu drm-fixes-6.3

2023-04-19 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. The following changes since commit 6a8f57ae2eb07ab39a6f0ccad60c760743051026: Linux 6.3-rc7 (2023-04-16 15:23:53 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.3-2023-04-19 for you to

Re: [PATCH V3 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-04-19 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 19, 2023 at 8:24 AM Christian König wrote: > > Am 19.04.23 um 14:20 schrieb hackyzh002: > > The type of size is unsigned, if size is 0x4000, there will be an > > integer overflow, size will be zero after size *= sizeof(uint32_t), > > will cause

Re: [PATCH v2] radeon: avoid double free in ci_dpm_init()

2023-04-17 Thread Alex Deucher
Thanks. Applied! Alex On Thu, Apr 13, 2023 at 11:12 AM Nikita Zhandarovich wrote: > > Several calls to ci_dpm_fini() will attempt to free resources that > either have been freed before or haven't been allocated yet. This > may lead to undefined or dangerous behaviour. > > For instance, if

Re: [PATCH] drm/amd/display: remove unused variable oldest_index

2023-04-17 Thread Alex Deucher
Applied. Thanks! On Fri, Apr 14, 2023 at 11:08 AM Tom Rix wrote: > > cpp_check reports > drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: > Variable > 'oldest_index' is assigned a value that is never used. [unreadVariable] >oldest_index = 0; > ^ > >

Re: [PATCH][next] drm/amd/pm: Fix spelling mistake "aquire" -> "acquire"

2023-04-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Apr 17, 2023 at 1:42 PM Colin Ian King wrote: > > There is a spelling mistake in the smu_i2c_bus_access prototype. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amd/display: fix flickering caused by S/G mode

2023-04-17 Thread Alex Deucher
On Mon, Apr 17, 2023 at 1:59 AM Christian König wrote: > > Am 14.04.23 um 21:33 schrieb Hamza Mahfooz: > > Currently, we allow the framebuffer for a given plane to move between > > memory domains, however when that happens it causes the screen to > > flicker, it is even possible for the

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-17 Thread Alex Deucher
On Mon, Apr 17, 2023 at 9:43 AM Rob Clark wrote: > > On Mon, Apr 17, 2023 at 4:10 AM Tvrtko Ursulin > wrote: > > > > > > On 16/04/2023 08:48, Daniel Vetter wrote: > > > On Fri, Apr 14, 2023 at 06:40:27AM -0700, Rob Clark wrote: > > >> On Fri, Apr 14, 2023 at 1:57 AM Tvrtko Ursulin > > >> wrote:

Re: [PATCH] drm/amd/pm: change pmfw_decoded_link_width, speed variables to globals

2023-04-14 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 14, 2023 at 8:04 AM Tom Rix wrote: > > gcc with W=1 reports > In file included from > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0.c:36: > ./drivers/gpu/drm/amd/amdgpu/../pm/swsmu/inc/smu_v13_0.h:66:18: error: > ‘pmfw_decoded_link_width’ defined

[pull] amdgpu, amdkfd drm-next-6.4

2023-04-14 Thread Alex Deucher
- Sdma v6 invalidation fix for preemption - RAS fixes - S0ix fix - GC 9.4.3 updates amdkfd: - Fix user pointers with IOMMU - Fix coherency flag handling Aaron Liu (1): drm/amdgpu: skip kfd-iommu suspend/resume for S0ix Alex

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Alex Deucher
On Wed, Apr 12, 2023 at 10:42 AM Tvrtko Ursulin wrote: > > > On 11/04/2023 23:56, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: Do it in core > > > > Signed-off-by: Rob Clark > >

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Alex Deucher
+ Wayne On Thu, Apr 13, 2023 at 8:31 AM Jani Nikula wrote: > > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to

[pull] amdgpu drm-fixes-6.3

2023-04-12 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d: Linux 6.3-rc6 (2023-04-09 11:15:57 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.3-2023-04-12 for you to

Re: [Freedreno] [PATCH v2 0/2] drm: fdinfo memory stats

2023-04-12 Thread Alex Deucher
On Wed, Apr 12, 2023 at 4:10 PM Rob Clark wrote: > > On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote: > > > > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote: > > > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote: > > > > On 11/04/2023 21:28, Rob Clark wrote: >

Re: [PATCH] radeon: avoid double free in ci_dpm_init()

2023-04-12 Thread Alex Deucher
On Wed, Apr 12, 2023 at 8:39 AM Nikita Zhandarovich wrote: > > > > On 4/11/23 14:11, Deucher, Alexander wrote: > > [Public] > > > >> -Original Message- > >> From: Nikita Zhandarovich > >> Sent: Monday, April 3, 2023 2:28 PM > >> To: Deucher, Alexander > >> Cc: Nikita Zhandarovich ;

Re: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-11 Thread Alex Deucher
Applied. Thanks! On Sun, Apr 9, 2023 at 8:48 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: Tom Rix > > Sent: Saturday, April 1, 2023 12:41 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian > >

[pull] amdgpu, amdkfd, radeon drm-next-6.4

2023-03-31 Thread Alex Deucher
: - Convert to client-based fbdev emulation Alex Deucher (3): drm/amdgpu: drop the extra sign extension Revert "drm/amdgpu/display: change pipe policy for DCN 2.0" drm/amd/pm: enable TEMP_DEPENDENT_VMIN for na

Re: [PATCH] drm/ttm: add NUMA node id to the pool

2023-03-31 Thread Alex Deucher
> > Regards, >Felix > > > On 2023-03-31 15:17, Alex Deucher wrote: > > On Fri, Mar 31, 2023 at 2:54 AM Christian König > > wrote: > >> Should I push this to drm-misc-next or do we take it through > >> amd-staging-drm-next? > > I think either

Re: [PATCH] drm/ttm: add NUMA node id to the pool

2023-03-31 Thread Alex Deucher
e are any direct code dependencies, but you or Rajneesh can correct me if I'm wrong. Alex > > Christian. > > Am 30.03.23 um 21:50 schrieb Alex Deucher: > > From: Rajneesh Bhardwaj > > > > This allows backing ttm_tt structure with pages from different NUMA >

[PATCH] drm/ttm: add NUMA node id to the pool

2023-03-30 Thread Alex Deucher
From: Rajneesh Bhardwaj This allows backing ttm_tt structure with pages from different NUMA pools. Tested-by: Graham Sider Reviewed-by: Felix Kuehling Signed-off-by: Christian König Signed-off-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- drivers/gpu/drm/ttm/ttm_device.c | 2

[pull] amdgpu drm-fixes-6.3

2023-03-30 Thread Alex Deucher
Hi Dave, Daniel, A regression fix for 6.3. The following changes since commit 68dc1846c3a44d5e633be145c169ce2fd5420695: drm/amd/display: Take FEC Overhead into Timeslot Calculation (2023-03-29 17:21:06 -0400) are available in the Git repository at:

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-30 Thread Alex Deucher
On Wed, Mar 29, 2023 at 11:36 PM Kai-Heng Feng wrote: > > On Wed, Mar 29, 2023 at 9:23 PM Mario Limonciello > wrote: > > > > > > On 3/29/23 04:59, Kai-Heng Feng wrote: > > > When the power is lost due to ACPI power resources being turned off, the > > > driver should reset the GPU so it can work

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Alex Deucher
On Wed, Mar 29, 2023 at 8:49 PM Kai-Heng Feng wrote: > > On Wed, Mar 29, 2023 at 9:21 PM Alex Deucher wrote: > > > > On Wed, Mar 29, 2023 at 6:00 AM Kai-Heng Feng > > wrote: > > > > > > When the power is lost due to ACPI power resources being turned off

[pull] amdgpu drm-fixes-6.3

2023-03-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. The following changes since commit 197b6b60ae7bc51dd0814953c562833143b292aa: Linux 6.3-rc4 (2023-03-26 14:40:20 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.3-2023-03-29 for you to

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Alex Deucher
On Wed, Mar 29, 2023 at 6:00 AM Kai-Heng Feng wrote: > > When the power is lost due to ACPI power resources being turned off, the > driver should reset the GPU so it can work anew. > > First, _PR3 support of the hierarchy needs to be found correctly. Since > the GPU on some discrete GFX cards is

Re: [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank_size'

2023-03-27 Thread Alex Deucher
On Mon, Mar 27, 2023 at 7:36 PM Caio Novais wrote: > > Compiling AMD GPU drivers displays a warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c: > In function ‘dpcd_set_source_specific_data’: >

Re: [PATCH 09/12] drm/amd/display: Remove two unused variables 'is_pipe_split_expected' and 'state'

2023-03-27 Thread Alex Deucher
On Mon, Mar 27, 2023 at 7:35 PM Caio Novais wrote: > > Compiling AMD GPU drivers displays two warnings: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function > ‘dcn32_acquire_post_bldn_3dlut’: > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1614:31:

Re: [PATCH 02/12] drm/amd: Remove unused variable 'value0'

2023-03-27 Thread Alex Deucher
On Mon, Mar 27, 2023 at 7:34 PM Caio Novais wrote: > > Compiling AMD GPU drivers displays a warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c: In > function ‘dcn10_link_encoder_update_mst_stream_allocation_table’: >

Re: [PATCH 01/12] drm/amd: Remove unused variable 'r'

2023-03-27 Thread Alex Deucher
On Mon, Mar 27, 2023 at 7:34 PM Caio Novais wrote: > > Compiling AMD GPU drivers displays a warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function > ‘amdgpu_mes_ctx_alloc_meta_data’: > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set > but not used

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-27 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 24, 2023 at 5:44 PM Alex Deucher wrote: > > On Tue, Mar 21, 2023 at 5:33 AM Thomas Zimmermann wrote: > > > > Hi > > > > Am 20.03.23 um 16:23 schrieb Alex Deucher: > > > On Mon, Mar 20, 2023 at 11:19 AM Thomas Zim

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-24 Thread Alex Deucher
On Tue, Mar 21, 2023 at 5:33 AM Thomas Zimmermann wrote: > > Hi > > Am 20.03.23 um 16:23 schrieb Alex Deucher: > > On Mon, Mar 20, 2023 at 11:19 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 20.03.23 um 16:11 schrie

[pull] amdgpu drm-fixes-6.3

2023-03-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. The following changes since commit e8d018dd0257f744ca50a729e3d042cf2ec9da65: Linux 6.3-rc3 (2023-03-19 13:27:55 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.3-2023-03-23 for you to

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-20 Thread Alex Deucher
e time > or runtime just like userspace clients. I guess, we can have a bootup > screen and then switch to the console or the DRM logger. Or go from any > client to the logger on kernel panics (or something like that). There's > been occasional talk about userspace consoles, which would use suc

Re: [PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses

2023-03-17 Thread Alex Deucher
unction parameter or member 'link' not described in > 'dc_link_detect_connection_type' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter >

Re: [PATCH 35/37] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-03-17 Thread Alex Deucher
00 lines snipped for brevity] > > Fixes: ceb3cf476a441 ("drm/amd/display/dc/dce60/Makefile: Ignore > -Woverride-init warning") > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: &quo

Re: [PATCH 33/37] drm/amd/display/dc/link/protocols/link_dp_capability: Demote non-compliant kerneldoc

2023-03-17 Thread Alex Deucher
ink' not described in > 'dc_link_is_dp_sink_present' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedeskt

Re: [PATCH 32/37] drm/amd/display/dc/link/protocols/link_dp_capability: Remove unused variable and mark another as __maybe_unused

2023-03-17 Thread Alex Deucher
; drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:1296:32: > warning: variable ‘result_write_min_hblank’ set but not used > [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian K

Re: [PATCH 30/37] drm/amd/display/dc/link/protocols/link_dp_training: Remove set but unused variable 'result'

2023-03-17 Thread Alex Deucher
rs/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_training.c:1586:38: > warning: variable ‘result’ set but not used [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "

Re: [PATCH 29/37] drm/amd/display/dc/link/link_detection: Remove unused variable 'status'

2023-03-17 Thread Alex Deucher
k/link_detection.c:501:42: > warning: variable ‘status’ set but not used [-Wunused-but-set-variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc

Re: [PATCH 28/37] drm/amd/display/dc/core/dc_stat: Convert a couple of doc headers to kerneldoc format

2023-03-17 Thread Alex Deucher
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:76: warning: Cannot > understand > * > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "

Re: [PATCH 27/37] drm/amd/display/dc/dce/dmub_psr: Demote kerneldoc abuse

2023-03-17 Thread Alex Deucher
entation/doc-guide/kernel-doc.rst > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: David Zhang > Cc: amd-...@lists.fre

Re: [PATCH 26/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef

2023-03-17 Thread Alex Deucher
_DRM_AMD_DC_DCN was recently dropped so this patch is no longer relevant. Alex > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: am

Re: [PATCH 20/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move defines out to where they are actually used

2023-03-17 Thread Alex Deucher
TR_ID_2’ defined but not used > [-Wunused-const-variable=] > drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:132:22: > warning: ‘DP_SINK_DEVICE_STR_ID_1’ defined but not used > [-Wunused-const-variable=] > > [snip 400 similar lines brevity] > > Cc:

Re: [PATCH 19/37] drm/amd/pm/swsmu/smu11/vangogh_ppt: Provide a couple of missing parameter descriptions

2023-03-17 Thread Alex Deucher
' not described in > 'vangogh_get_gfxoff_residency' > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2399: warning: > Function parameter or member 'entrycount' not described in > 'vangogh_get_gfxoff_entrycount' > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian König" >

Re: [PATCH 18/37] drm/amd/amdgpu/amdgpu_vce: Provide description for amdgpu_vce_validate_bo()'s 'p' param

2023-03-17 Thread Alex Deucher
date_bo' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-me...@vger.kernel.or

Re: [PATCH 17/37] drm/amd/amdgpu/amdgpu_mes: Ensure amdgpu_bo_create_kernel()'s return value is checked

2023-03-17 Thread Alex Deucher
: variable ‘r’ set > but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: Jack Xiao > Cc: Hawking Zhang > Cc: amd-...@lis

Re: [PATCH 16/37] drm/amd/amdgpu/ih_v6_0: Repair misspelling and provide descriptions for 'ih'

2023-03-17 Thread Alex Deucher
dgpu/ih_v6_0.c:432: warning: Function parameter or > member 'ih' not described in 'ih_v6_0_irq_rearm' > drivers/gpu/drm/amd/amdgpu/ih_v6_0.c:458: warning: Function parameter or > member 'ih' not described in 'ih_v6_0_set_rptr' > > Cc: Alex Deucher > Cc: "Christian König"

Re: [PATCH 15/37] drm/amd/amdgpu/gmc_v11_0: Provide a few missing param descriptions relating to hubs and flushes

2023-03-17 Thread Alex Deucher
t; drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:322: warning: Function parameter or > member 'all_hub' not described in 'gmc_v11_0_flush_gpu_tlb_pasid' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter &g

Re: [PATCH 14/37] drm/amd/amdgpu/amdgpu_vm_pt: Supply description for amdgpu_vm_pt_free_dfs()'s unlocked param

2023-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:683: warning: Function parameter > or member 'unlocked' not described in 'amdgpu_vm_pt_free_dfs' >

Re: [PATCH 13/37] drm/amd/amdgpu/amdgpu_ucode: Remove unused function ‘amdgpu_ucode_print_imu_hdr’

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:22 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:129:6: warning: no previous > prototype for ‘amdgpu_ucode_print_imu_hdr’ [-Wmissing-prototypes] > > C

Re: [PATCH 03/37] drm/amd/amdgpu/amdgpu_device: Provide missing kerneldoc entry for 'reset_context'

2023-03-17 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 17, 2023 at 4:22 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:5152: >warning: Function parameter or member 'reset_context' not described in > 'amdgpu_device_gpu_rec

Re: [PATCH 01/37] drm/amd/display/dc/dc_hdmi_types: Move string definition to the only file it's used in

2023-03-17 Thread Alex Deucher
sed-const-variable=] > > [snipped 400 similar lines for brevity] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Wenjing Liu

[pull] amdgpu, amdkfd, radeon, UAPI drm-next-6.4

2023-03-17 Thread Alex Deucher
contexts and for RDMA P2P support. Proposed user mode changes: https://github.com/fxkamd/ROCT-Thunk-Interface/commits/fxkamd/dmabuf Agustin Gutierrez (1): drm/amd/display: Keep PHY active for dp config Alex Deucher (6

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-17 Thread Alex Deucher
On Thu, Mar 16, 2023 at 7:09 PM Stefano Stabellini wrote: > > On Thu, 16 Mar 2023, Juergen Gross wrote: > > On 16.03.23 14:53, Alex Deucher wrote: > > > On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > > > > > > > On 16.03.23 14:45, Alex Deuch

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Alex Deucher
On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > On 16.03.23 14:45, Alex Deucher wrote: > > On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: > >> > >> On 16.03.2023 00:25, Stefano Stabellini wrote: > >>> On Wed, 15 Mar 2023, Jan Beulich

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Alex Deucher
On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: > > On 16.03.2023 00:25, Stefano Stabellini wrote: > > On Wed, 15 Mar 2023, Jan Beulich wrote: > >> On 15.03.2023 01:52, Stefano Stabellini wrote: > >>> On Mon, 13 Mar 2023, Jan Beulich wrote: > On 12.03.2023 13:01, Huang Rui wrote: > >

[pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-15 Thread Alex Deucher
a possible double free - Fix potential use after free - Fix process cleanup on module exit Alex Deucher (1): drm/amdgpu/nv: fix codec array for SR_IOV Ayush Gupta (1): drm/amd/display: disconnect MPCC only on OTG change

Re: enhancing module info to allow grouping of firmwares

2023-03-15 Thread Alex Deucher
On Wed, Mar 15, 2023 at 4:35 PM Dave Airlie wrote: > > Hey moduly/firmware people, > > We are facing a problem in the future of NVIDIA providing giant > firmwares for their devices that are version locked with unstable > APIs. Even if they weren't version locked we'd likely have to support >

Re: [PATCH] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-14 Thread Alex Deucher
ODULE_FIRMWARE("amdgpu/vega10_gpu_info.bin"); > MODULE_FIRMWARE("amdgpu/vega12_gpu_info.bin"); > MODULE_FIRMWARE("amdgpu/raven_gpu_info.bin"); > @@ -1356,6 +1360,17 @@ bool amdgpu_device_should_use_aspm(struct > amdgpu_device *adev) > return pcie_as

<    1   2   3   4   5   6   7   8   9   10   >