On 08/02/2016 02:16 PM, Takashi Iwai wrote:
> This is a preliminary patch for building drm-mipi-dsi as a module.
> Add the module exit callback to unregister the bus properly.
>
> Suggested-by: Thierry Reding
> Signed-off-by: Takashi Iwai
For both patches:
Reviewed-by
On 02.11.2016 10:46, Shashank Sharma wrote:
> CEA-861-F specs defines new 4k video modes to be used with
> HDMI 2.0 EDIDs. These modes start at VIC=93 and go all the
> way till VIC=107.
>
> Our existing CEA modedb contains only 64 modes (VIC=1 to VIC=64). Now
> to be able to parse 4k modes using
On 02.11.2016 15:44, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 11/2/2016 7:58 PM, Andrzej Hajda wrote:
>> On 02.11.2016 10:46, Shashank Sharma wrote:
>>> CEA-861-F specs defines new 4k video modes to be used with
>>> HDMI 2.0 EDIDs. These mo
On 03.11.2016 13:53, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> All the VICs apart from 58 and 59 have the word "Hz" included in the
> comment. Include it for 59 and 59 as well.
>
> Cc: Shashank Sharma
> Cc: Andrzej Hajda
> Signed
On 07.11.2016 02:45, Inki Dae wrote:
>
> 2016ë
10ì 26ì¼ 21:36ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>> Use core helpers to generate infoframes and generate vendor frame if
>> necessary.
>>
>> Signed-off-by: Andrzej Hajda
>> ---
>>
Use core helpers to generate infoframes and generate vendor frame if necessary.
Signed-off-by: Andrzej Hajda
---
- changed 'ret >= 0' checks to '!ret'
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 141 ++-
drivers/gpu/drm/exynos/regs-hdmi.h | 2 +
2 fi
ch.
>
> Cc: Shashank Sharma
> Cc: Andrzej Hajda
> Cc: Adam Jackson
> Signed-off-by: Ville Syrjälä
I have checked against specification and it looks OK.
I have few nitpicks below regarding implementation, but this could be
matter of taste, so:
Reviewed-by: Andrzej Hajda
comment change
>
> Cc: Daniel Vetter
> Signed-off-by: Jani Nikula
Reviewed-by: Andrzej Hajda
Out of curiosity, why driver (i915) do not create connectors
just in proper order instead of sorting them later.
--
Regards
Andrzej
> ---
> drivers/gpu/drm/drm_modeset_helper.c
On 29.11.2016 22:12, Jyri Sarha wrote:
> Store the module that provides the bridge and adjust its refcount
> accordingly. The bridge module unload should not be allowed while the
> bridge is attached.
Module refcounting as a way of preventing driver from unbinding
is quite popular, but as other
On 30.11.2016 09:16, Laurent Pinchart wrote:
> Hi Andrzej,
>
> On Wednesday 30 Nov 2016 09:11:56 Andrzej Hajda wrote:
>> On 29.11.2016 22:12, Jyri Sarha wrote:
>>> Store the module that provides the bridge and adjust its refcount
>>> accordingly. The bridge mo
Hi Inki,
On 01/18/2016 10:54 AM, Inki Dae wrote:
>
> 2016ë
01ì 18ì¼ 08:45ì Krzysztof Kozlowski ì´(ê°) ì´ ê¸:
>> On 14.01.2016 19:49, Inki Dae wrote:
>>> + Rob Herring
>>>
>>> 2016ë
01ì 14ì¼ 19:36ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>>>
Hi Milo,
On 08/24/2016 04:25 AM, Milo Kim wrote:
> * Support HDMI display data channel
> I2C #2 is assigned for the HDMI DDC. It enables the EDID access.
>
> * GPIO for HDMI hot plug detect
> GPX3_7 is used. The HPD awareness is done when the GPIO is active high and
> single ended.
>
> *
n Park
> Cc: devicetree at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Milo Kim
I am not sure if this long Cc list is necessary.
Anyway:
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
On 08/24/2016 04:25 AM, Milo Kim wrote:
> Handle legacy and raw 'ddc' parsing in single function.
> And it also removes goto condition.
>
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: David Airlie
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Cc: Kyungmin Park
> Cc: Rob
On 08/24/2016 04:25 AM, Milo Kim wrote:
> Handle legacy and raw 'phy' parsing in single function.
> And it also removes goto condition.
>
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: David Airlie
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Cc: Kyungmin Park
> Cc: Rob
On 08/24/2016 03:07 PM, Milo Kim wrote:
> Paring DT properties and getting the I2C adapter in one function.
>
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: David Airlie
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Cc: Kyungmin Park
> Cc: Rob Herring
>
> Cc: Kyungmin Park
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Milo Kim
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
> ---
>
gt; Signed-off-by: Milo Kim
>
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
ger.kernel.org
> Signed-off-by: Milo Kim
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
Hi,
On 08/30/2016 12:50 AM, Randy Li wrote:
> It is actually a lvds panel connected through a rga-lvds bridge.
> But I really have no idea about what does a port mean in fimd node.
>
> Also how should I configure this panel size? I think the i2c found
> on the panel schematic, but it more likely
On 30.11.2016 10:39, Laurent Pinchart wrote:
> Hi Andrzej,
>
> On Wednesday 30 Nov 2016 10:26:24 Andrzej Hajda wrote:
>> On 30.11.2016 09:16, Laurent Pinchart wrote:
>>> On Wednesday 30 Nov 2016 09:11:56 Andrzej Hajda wrote:
>>>> On 29.11.2016 22:12, Jyri
On 30.11.2016 14:09, Daniel Vetter wrote:
> On Wed, Nov 30, 2016 at 01:03:20PM +0200, Laurent Pinchart wrote:
>> On Wednesday 30 Nov 2016 11:55:20 Daniel Vetter wrote:
>>> Why exactly do you want to hotplug encoders? Or bridges fwiw ... since at
>>> least only making those hotpluggable will make
On 01.12.2016 08:18, Daniel Vetter wrote:
> On Thu, Dec 01, 2016 at 08:07:29AM +0100, Andrzej Hajda wrote:
>> On 30.11.2016 14:09, Daniel Vetter wrote:
>>> On Wed, Nov 30, 2016 at 01:03:20PM +0200, Laurent Pinchart wrote:
>>>> On Wednesday 30 Nov 2016 11:55:20
On 01.12.2016 16:12, Daniel Vetter wrote:
> On Thu, Dec 01, 2016 at 02:22:18PM +0100, Andrzej Hajda wrote:
>> On 01.12.2016 08:18, Daniel Vetter wrote:
>>> On Thu, Dec 01, 2016 at 08:07:29AM +0100, Andrzej Hajda wrote:
>>>> On 30.11.2016 14:09, Daniel Vetter wrote:
&g
On 14.12.2016 07:04, Hoegeun Kwon wrote:
> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel
> driver. This panel has 1440x2560 resolution in 5.7-inch physical
> panel in the TM2 device.
>
> Signed-off-by: Donghwa Lee
> Signed-off-by: Hyungwon Hwang
> Signed-off-by: Hoegeun Kwon
Core provides generic helper to create DSI packet, use it instead of
custom code.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 69 +++--
1 file changed, 23 insertions(+), 46 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Include directories are provided by core already, adding them in driver
is redundand and causes warnings in case of out-of-tree build.
Signed-off-by: Andrzej Hajda
---
v2:
- fixed include in exynos_drm_iommu.c
- typo in commit message
drivers/gpu/drm/exynos/Makefile | 1
have put common MHL definitions into include/linux/mhl.h header file,
similarily to include/linux/hdmi.h.
The patchset is based on latest exynos-drm-next branch.
Regards
Andrzej
Andrzej Hajda (3):
video: add header file for Mobile High-Definition Link (MHL) interface
dt-bindings: add Silicon
This header adds definitions specific to MHL protocol.
Signed-off-by: Andrzej Hajda
---
include/linux/mhl.h | 292
1 file changed, 292 insertions(+)
create mode 100644 include/linux/mhl.h
diff --git a/include/linux/mhl.h b/include/linux
SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled
via I2C bus.
Signed-off-by: Andrzej Hajda
---
v2:
- changed specifier of INT pin from gpio to interrupt property,
- improved description.
---
.../bindings/video/bridge/sil-sii8620.txt | 33
interface to perform this operation.
Signed-off-by: Andrzej Hajda
---
v2:
- changed specifier of INT pin from gpio to interrupt property
---
drivers/gpu/drm/bridge/Kconfig |7 +
drivers/gpu/drm/bridge/Makefile |1 +
drivers/gpu/drm/bridge/sil-sii8620.c | 1560
Hi Inki,
Ping.
Regards
Andrzej
On 11/02/2015 02:16 PM, Andrzej Hajda wrote:
> Hi Inki, Krzysztof,
>
> This patchset adds support for Exynos 5433 HDMI.
> There are also few preparation/cleanup patches.
> All patches except one touch only exynos-drm.
> Sixth patch adds
os-drm-next.
Regards
Andrzej
>
> Thanks,
> Inki Dae
>
> 2016ë
01ì 14ì¼ 13:54ì Inki Dae ì´(ê°) ì´ ê¸:
>> Hi Andrzej,
>>
>> Really sorry for missing this.
>> I will merge them soon.
>>
>> Thanks,
>> Inki Dae
>>
>&
The function can return negative value so it should be assigned to signed
variable.
The problem has been detected using patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ++-
1 file changed, 2 insertions
Hi Inki,
It seems this patch and 04/10 did not get picked up yet.
Could you merge it?
Regards
Andrzej
On 10/26/2015 12:59 PM, Andrzej Hajda wrote:
> DECON-TV(Display and Enhancement Controller for TV) is a variation
> of DECON IP. Its main purpose is to produce video stream for H
On 03/30/2016 04:03 PM, Jani Nikula wrote:
> From: Deepak M
>
> Adding new DCS commands which are specified in the
> DCS 1.3 spec related to CABC.
>
> v2: Sorted the Macro`s by value (Andrzej)
>
> v3 by Jani: sort all of enum, refer to MIPI DCS 1.3
>
> Cc: Andrz
atch.
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
> ---
> drivers/gpu/drm/exynos/exynos_drm_dpi.c | 69
> +
> 1 file changed, 2 insertions(+), 67 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> b/drivers/gpu/drm/exynos/exyno
On 05/03/2016 03:47 PM, Philipp Zabel wrote:
> This allows to remove the local of_graph_get_port_by_reg(),
> of_graph_get_endpoint_by_reg(), and of_get_child_by_name_reg()
> functions.
>
> Signed-off-by: Philipp Zabel
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
> ---
Hi Inki,
It looks like this patch felt through the cracks.
It is a part of "drm/exynos: add pipeline clock support" patchset.
Other patches from the patchset were taken already.
Could you queue it to next pull request?
Regards
Andrzej
On 03/23/2016 02:25 PM, Andrzej Hajda wrote:
Hi Inki,
Gently ping.
Regards
Andrzej
On 03/24/2016 11:52 AM, Andrzej Hajda wrote:
> Driver code did not remove event from the list of pending events before
> destroy.
> As a result drm core tried later to inspect invalid memory location.
> The patch replaces removal code with
] [] fput+0xc/0x18
[ 10.454055] [] task_work_run+0x130/0x198
[ 10.459522] [] do_exit+0x700/0x2278
[ 10.464557] [] do_group_exit+0xe4/0x2c8
[ 10.469939] [] SyS_exit_group+0x1c/0x20
[ 10.475320] [] el0_svc_naked+0x24/0x28
Signed-off-by: Andrzej Hajda
---
v2: use exynos_crtc->event un
Hi Tobias, Daniel,
Little late, but maybe helpful anyway...
On 05/02/2016 11:00 PM, Daniel Vetter wrote:
> On Mon, May 2, 2016 at 10:30 PM, Tobias Jakobi
> wrote:
>>> drm_mode_set_crtcinfo() is meant to be used to fill in all the derived
>>> values. We might or might not want to have a default
On 05/05/2016 11:12 AM, Andrzej Hajda wrote:
>
> Regarding the initial question, mode->vrefresh is set in
> drm_helper_probe_single_connector_modes. I guess division by zero could
> be caused by lack of clock in timings provided by dts timing node.
> As I remember in the pas
the case in which the clock value
> should be zero. We then just default to the maximum
> clock divisor.
>
> Signed-off-by: Tobias Jakobi
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 9 -
> 1 file changed, 8 inse
Hi Tobias,
On 05/05/2016 07:27 PM, Tobias Jakobi wrote:
> Hello,
>
> here's another issue I experience when enabling FIMD on the ODROID-X2.
>
> I can trigger a IOMMU pagefault by starting X once, quitting, and
> restarting X again.
>
I have observed similar behavior on arm64 dev board which
uses
,
in such cases IOMMU can throw OOPS.
The patch instead of fixing the mechanism replaces it with drm core helper.
Signed-off-by: Andrzej Hajda
---
Hi Tobias,
This is a quick/dirty patch just for checking if it solves your issue.
Successfully tested on decon5433/dsi/i80 path.
Please verify if it helps
+CC: Inki
On 05/06/2016 09:48 AM, Tobias Jakobi wrote:
> Hello Andrzej,
>
>
> Andrzej Hajda wrote:
>> Hi Tobias,
>>
>> On 05/05/2016 07:27 PM, Tobias Jakobi wrote:
>>> Hello,
>>>
>>> here's another issue I experience when enabling FIMD
7c001
>
> I still need to test this with exynos-drm-next and [1].
OK, in case of page fault let me know which modification you have made
to dts / exynos_defconfig,
I will try to reproduce/investigate it on similar hw.
Regards
Andrzej
>
> With best wishes,
> Tobias
>
>
>
> Andrzej Haj
Hi Inki,
On 05/10/2016 07:31 AM, Inki Dae wrote:
> Hi Andrzej,
>
> 2016ë
04ì 29ì¼ 22:42ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>> It seems trigger cannot be configured too early, otherwise it does not work
>> in
>> case of panel. The patch fixes also trigger flag l
On 05/10/2016 08:24 AM, Inki Dae wrote:
> Hi Andrzej,
>
> 2016ë
05ì 10ì¼ 15:08ì Andrzej Hajda ì´(ê°) ì´ ê¸:
>> Hi Inki,
>>
>>
>> On 05/10/2016 07:31 AM, Inki Dae wrote:
>>> Hi Andrzej,
>>>
>>> 2016ë
04ì 29ì¼ 22:42ì
into include/linux/mhl.h header file,
similarily to include/linux/hdmi.h.
The patchset is based on latest exynos-drm-next branch.
Regards
Andrzej
Andrzej Hajda (3):
video: add header file for Mobile High-Definition Link (MHL) interface
dt-bindings: add Silicon Image SiI8620 bridge bindings
drm
This header adds definitions specific to MHL protocol.
Signed-off-by: Andrzej Hajda
---
include/linux/mhl.h | 292
1 file changed, 292 insertions(+)
create mode 100644 include/linux/mhl.h
diff --git a/include/linux/mhl.h b/include/linux
SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled
via I2C bus.
Signed-off-by: Andrzej Hajda
Acked-by: Rob Herring
---
.../bindings/video/bridge/sil-sii8620.txt | 33 ++
1 file changed, 33 insertions(+)
create mode 100644
Documentation
interface to perform this operation.
Signed-off-by: Andrzej Hajda
---
v2:
- changed specifier of INT pin from gpio to interrupt property
v3:
- improved gpio handling
sii8620: improve gpio_reset handling
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/bridge/Kconfig |7 +
drivers/gpu/drm
Hi Hoegeun Kwon,
Thanks for the patch.
On 27.12.2016 10:05, Hoegeun Kwon wrote:
> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel
> driver. This panel has 1440x2560 resolution in 5.7-inch physical
> panel in the TM2 device.
>
> Signed-off-by: Donghwa Lee
> Signed-off-by: Hyungwon
In case of HW trigger mode, sysreg register should be configured to
enable TE functionality. The patch refactors also trigger setup function.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 40 +--
1 file changed, 32 insertions(+), 8
le, the exynos5422 uses sw reset like
> previous chips.
>
> Cc: Inki Dae
> Cc: Joonyoung Shim
> Cc: Seung-Woo Kim
> Signed-off-by: Chanho Park
Reviewed-by: Andrzej Hajda
--
Regards
Andrzej
> ---
> .../bindings/display/exynos/exynos_dsim.txt| 1 +
Decon requires that clocks should be disabled in reverse order. Otherwise
system hangs.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers
Hi Inki,
This set of small fixes and improvements is based on exynos-drm-next,
except patch 'drm/exynos/dsi: constify read only structures', which
requires '[PATCH] drm/exynos: support exynos5422 mipi-dsi' which you
have just picked up :)
Regards
Andrzej
Andrzej Hajda (5):
drm/exynos/dsi
Include directories are provided by core already, adding them in driver
is redundand and causes warnings in cause of out-of-tree build.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/Makefile | 1 -
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 -
2 files changed, 2
All global variables are read only.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
Functions are preferred over macros as more type-safe.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 108 +---
1 file changed, 57 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm
The function is used only locally.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 98615e2
The variable is unused for long time.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 9ec3ab1..c702efc 100644
--- a/drivers/gpu/drm
Hi Emil,
On 02/08/2016 12:14 PM, Emil Velikov wrote:
> Hi Marek,
>
> On 3 February 2016 at 12:42, Marek Szyprowski
> wrote:
>> Hello all,
>>
>> This patch series is a set of various fixes to get Exynos DRM working on
>> Exynos 5433 SoCs and 64bit ARM64 architecture.
>>
> As you mentioned
struct exynos_drm_panel_info is not used anymore, except exynos_dp,
which can integrate useful fields directly into its context.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 -
drivers/gpu/drm/exynos/exynos_dp_core.c| 7 ++-
drivers/gpu/drm/exynos
Hi Inki,
This small cleanup series is based on exynos-drm-next.
Regards
Andrzej
Andrzej Hajda (4):
drm/exynos: remove struct exynos_drm_panel_info
drm/exynos/fimc: remove unused camera interface polarization code
drm/exynos: remove platform data structures and
include/drm
User API structs should not use types which size/alignment/padding depends
on architecture. The patch fixes it for all structures except
drm_exynos_g2d_userptr, as g2d related stuff seems to be more complicated
and will be reviewed/adjusted later.
Signed-off-by: Andrzej Hajda
---
include/uapi
Polarization was never configured for DRM-FIMC device, so fimc_set_polarity
function did nothing. In fact DRM does not use camera interface so there
is no point in configuring it.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 28
1 file
Platform data structures are not used for long time so the whole header
file can be safely removed.
Signed-off-by: Andrzej Hajda
---
include/drm/exynos_drm.h | 86
1 file changed, 86 deletions(-)
delete mode 100644 include/drm/exynos_drm.h
diff
On 03/01/2016 04:20 PM, Inki Dae wrote:
> Fixed trivial one related to following warning,
> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1188:2: warning: format '%ld'
> expects argument of type 'long int', but argument 5 has type 'size_t'
> [-Wformat]
Thanks.
Regards
Andrzej
exynos_plane_mode_set should use adjusted_mode from the same atomic state as
plane state. Otherwise it will result in incorrect behavior in case
crtc mode changes.
The patch fixes bug with black console framebuffer in case of command mode
panels.
Signed-off-by: Andrzej Hajda
---
drivers/gpu
Fbdev code should be compiled only if CONFIG_DRM_FBDEV_EMULATION option
is enabled. The patch fixes exynos-drm code trying to manipulate
fbdev data which is not initialized in case CONFIG_DRM_FBDEV_EMULATION
is disabled.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/Makefile
DRM core provide helper to access crtc state.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/drm_atomic_helper.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index 2b430b0..e1cbba6
DRM core provide helper to access crtc state.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
son HDMI path on 5433
works only with IOMMU enabled),
- latest exynos-drm-next patches.
[1]: http://permalink.gmane.org/gmane.comp.video.dri.devel/140109
Regards
Andrzej
Andrzej Hajda (7):
drm/exynos/hdmi: fix PHY configuration sequence
drm/exynos/hdmi: add PHY power off signal handling
HDMI registry dump unnecessary spoils console and is not very helpful.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 263 ---
1 file changed, 263 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
To ensure HDMI-PHY reprogramming will not affect
HDMI the latter should be reset.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
decon_atomic_begin and decon_atomic_flush protects all windows already.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos
Resetting IP at starting ensures that DECON will be in known state
regardless of changes by bootloader.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers
HDMI-PHY power off bit defaults to 0 in older HDMI versions.
In case of Exynos5433 it defaults to 1. To make code
consistent across all versions this bit is always unset/set in
power on/off sequences.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 4
1 file changed
DECON should be updated after un-protecting windows and after changing
output parameters, otherwise image is not displayed in case of HDMI path.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions
Proper PHY configuration should be as follow:
1. set HDMI clock parents to OSCCLK.
2. reconfigure PHY.
3. set HDMI clock parents to PHY.
4. wait for PLL stabilization.
The patch fixes it and consolidates the code.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 22
solution for such problem
than currently present clock_enable callback. More details in particular
patches. The patchset is based on recently sent patchset with HDMI/DECON
path fixes[1].
[1]: http://permalink.gmane.org/gmane.comp.video.dri.devel/149714
Regards
Andrzej
Andrzej Hajda (6):
drm
The helper abstracts out conversion from pipeline
to crtc. Currently it is used in two places, but
there will be more uses in next patches.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c | 10 --
drivers/gpu/drm/exynos/exynos_drm_drv.h | 8
2 files
s more generic solution allowing to register
pipeline clock during initialization in exynos_drm_crtc structure.
This way the clock will be easily accessible from both components.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 12
1 file changed, 12 inse
clock_enable callback is used only by FIMD->DP pipeline. Similar but more
universal functionality provides pipeline clock.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 8 ++--
drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 -
drivers/gpu/drm/exy
According to documentation and tests HDMI-PHY must be on prior
to MIXER configuration.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
b/drivers/gpu/drm/exynos
HDMI-PHY clock should be accessible from other components in the pipeline.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 67 ++--
1 file changed, 48 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b
According to documentation HDMI-PHY must be on prior to MIXER configuration.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_mixer.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index
] [] fput+0xc/0x18
[ 10.454055] [] task_work_run+0x130/0x198
[ 10.459522] [] do_exit+0x700/0x2278
[ 10.464557] [] do_group_exit+0xe4/0x2c8
[ 10.469939] [] SyS_exit_group+0x1c/0x20
[ 10.475320] [] el0_svc_naked+0x24/0x28
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos
On 03/24/2016 10:18 AM, Deepak M wrote:
> Adding new DCS commands which are specified in the
> DCS 1.3 spec related to CABC.
>
> Cc: Thierry Reding
> Cc: David Airlie
> Cc: Ville Syrjälä
> Cc: Daniel Vetter
> Suggested-by: Jani Nikula
> Signed-off-by: Deepak M
> ---
>
STANDALONE_UPDATE_F should be set if something changed in plane configurations,
including plane disable.
The patch fixes page-faults bugs, caused by decon still using framebuffers
of disabled planes.
Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
---
v2: fixed clear-bit code (Thx
STANDALONE_UPDATE_F should be set if something changed in plane configurations,
including plane disable.
The patch fixes page-faults bugs, caused by decon still using framebuffers
of disabled planes.
Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
Tested-by: Joonyoung Shim <
STANDALONE_UPDATE_F should be set if something changed in plane configurations,
including plane disable.
The patch fixes page-faults bugs, caused by decon still using framebuffers
of disabled planes.
Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
---
drivers/gpu/drm/
On 13.01.2017 09:37, Joonyoung Shim wrote:
>
> There is no code to clear BIT_REQUEST_UPDATE, is it right?
Marek has already pointed it out, v2 sent.
Regards
Andrzej
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
On ipp subsystem removal list of ipp drivers is traversed
and their members are deleted. To do it properly safe version
of list_for_each* should be used.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Since components have their own cleanup routines calling
drm_mode_config_cleanup before component_unbind_all causes errors
due to double free of KMS objects. The patch fixes it by changing
de-initialization order. Now it is exactly opposite to init order.
Signed-off-by: Andrzej Hajda
This set of patches contains fixes of initialization and deinitialization
code of exynos_drm core and components.
It is based on exynos-drm-next branch.
Patchset has been tested on trats and universal_c210 platforms.
Regards
Andrzej
Andrzej Hajda (9):
drm/exynos/ipp: traverse ipp drivers
exynos_gem_obj is used by exynos_drm_fbdev_destroy so it cannot be destroyed
before calling the latter. exynos_gem_obj will be destroyed anyway by
exynos_drm_fbdev_destroy->...->exynos_drm_fb_destroy.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 3 ---
201 - 300 of 2434 matches
Mail list logo