[PATCH 3/4] phy: mediatek: phy-mtk-hdmi: Reorder and stop implicit header inclusion

2022-01-03 Thread AngeloGioacchino Del Regno
. For this reason, move the inclusions to each file and remove unused ones. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 5 + drivers/phy/mediatek/phy-mtk-hdmi-mt8173.c | 5 + drivers/phy/mediatek/phy-mtk-hdmi.c| 8 drivers

[PATCH 4/4] phy: mediatek: phy-mtk-hdmi: Simplify with dev_err_probe()

2022-01-03 Thread AngeloGioacchino Del Regno
Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno --- drivers/phy/mediatek/phy-mtk-hdmi.c | 50 +++-- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b

[PATCH v2] drm/bridge: parade-ps8640: Link device to ensure suspend/resume order

2022-01-05 Thread AngeloGioacchino Del Regno
and solving the unability to correctly resume bridge operation in the first mentioned example. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 27 -- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge

Re: [PATCH v10] drm/bridge: add it6505 driver

2022-01-05 Thread AngeloGioacchino Del Regno
Il 14/10/21 05:30, allen ha scritto: This adds support for the iTE IT6505. This device can convert DPI signal to DP output. From: Allen Chen Tested-by: Hsin-yi Wang Signed-off-by: Hermes Wu Signed-off-by: Allen Chen --- This patch depends on

[PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-04 Thread AngeloGioacchino Del Regno
() fails!), so also move that one to the dsi host attach function (and remove it in detach). Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/mediatek/mtk_dsi.c | 167 +++-- 1 file changed, 84 insertions(+), 83 deletions(-) diff

Re: [PATCH] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-04 Thread AngeloGioacchino Del Regno
Il 10/12/21 12:36, AngeloGioacchino Del Regno ha scritto: DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to let the bridge to probe: this recently started producing an endless -EPROBE_DEFER loop on some machines

Re: [PATCH v4] drm/mediatek: Fix mtk_cec_mask()

2022-01-04 Thread AngeloGioacchino Del Regno
: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Cc: Zhiqiang Lin Cc: CK Hu Cc: Matthias Brugger Signed-off-by: Miles Chen Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- Change since v1: add Fixes tag Change since v2: add explanation of mtk_cec_mask() Chang

Re: [PATCH v3, 02/13] media: mtk-vcodec: Using firmware type to separate different firmware architecture

2022-01-04 Thread AngeloGioacchino Del Regno
a v4 with the requested removal? so, for v4... Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-12-22 Thread AngeloGioacchino Del Regno
Il 11/12/21 22:57, Marijn Suijten ha scritto: On 2021-12-12 00:49:09, Dmitry Baryshkov wrote: On Sun, 12 Dec 2021 at 00:35, Marijn Suijten wrote: [..] On this note, does it perhaps make more sense to call the "internal" _dpu_encoder_phys_cmd_wait_for_idle function directly, instead of going

Re: [PATCH] drm/msm/devfreq: Insert missing null check in msm_devfreq_idle

2021-11-17 Thread AngeloGioacchino Del Regno
if the devfreq instance is not NULL before proceeding. Fixes: 658f4c829688 ("drm/msm/devfreq: Add 1ms delay before clamping freq") Reviewed-by: Konrad Dybcio Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 2/3] drm/bridge: parade-ps8640: Move real poweroff action to new function

2021-11-19 Thread AngeloGioacchino Del Regno
Il 19/11/21 14:19, Robert Foss ha scritto: Hey Angelo, On Wed, 10 Nov 2021 at 13:46, AngeloGioacchino Del Regno wrote: Il 10/11/21 13:44, Dafna Hirschfeld ha scritto: On 02.11.21 11:36, AngeloGioacchino Del Regno wrote: In preparation for varying the poweron error handling in function

Re: [PATCH v2 2/3] drm/bridge: parade-ps8640: Move real poweroff action to new function

2021-11-10 Thread AngeloGioacchino Del Regno
Il 10/11/21 13:44, Dafna Hirschfeld ha scritto: On 02.11.21 11:36, AngeloGioacchino Del Regno wrote: In preparation for varying the poweron error handling in function ps8640_bridge_poweron(), move function ps8640_bridge_poweroff() up and also move the actual logic to power off the chip

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-11-29 Thread AngeloGioacchino Del Regno
Il 29/11/21 03:20, Dmitry Baryshkov ha scritto: Hi, On 25/11/2021 18:09, AngeloGioacchino Del Regno wrote: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components becaus

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-11-29 Thread AngeloGioacchino Del Regno
Il 29/11/21 15:53, Dmitry Baryshkov ha scritto: Hi, On Mon, 29 Nov 2021 at 17:15, AngeloGioacchino Del Regno wrote: Il 29/11/21 03:20, Dmitry Baryshkov ha scritto: Hi, On 25/11/2021 18:09, AngeloGioacchino Del Regno wrote: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe

Re: [PATCH v6 5/7] drm/mediatek: dpi: Add dpintf support

2021-11-26 Thread AngeloGioacchino Del Regno
give you a R-b on patches 6 and 7, since this code should *really* make use of phy_get(), like suggested by Vinod. In any case, for this patch: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v6 5/7] drm/mediatek: dpi: Add dpintf support

2021-11-26 Thread AngeloGioacchino Del Regno
cannot give you a R-b on patches 6 and 7, since this code should *really* make use of phy_get(), like suggested by Vinod. In any case, for this patch: Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-11-26 Thread AngeloGioacchino Del Regno
Il 26/11/21 01:06, Dmitry Baryshkov ha scritto: On 25/11/2021 18:09, AngeloGioacchino Del Regno wrote: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they

Re: [RFC 08/13] soc: mediatek: apu: Add apusys rv driver

2021-11-26 Thread AngeloGioacchino Del Regno
Il 26/11/21 10:25, Flora.Fu ha scritto: On Tue, 2021-10-26 at 17:21 +0200, AngeloGioacchino Del Regno wrote: Il 23/10/21 13:14, Flora Fu ha scritto: Add driver for control APU tinysys APU integrated subsystem having MD32RV33 (MD32) that runs tinysys The tinsys is running on a micro processor

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-11-26 Thread AngeloGioacchino Del Regno
Il 26/11/21 01:06, Dmitry Baryshkov ha scritto: On 25/11/2021 18:09, AngeloGioacchino Del Regno wrote: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they

[PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-11-25 Thread AngeloGioacchino Del Regno
e the devm variant of kzalloc(). Fixes: 8f59ee9a570c ("drm/msm/dsi: Adjust probe order") Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/msm_drv.c | 81 --- 1 file changed, 38 insertions(+), 43 deletions(-) diff --git a/drivers/gpu

Re: [PATCH 3/3] dt-bindings: display: msm: Add binding for msm8998 dpu

2021-11-25 Thread AngeloGioacchino Del Regno
Il 25/11/21 12:53, Dmitry Baryshkov ha scritto: On 07/09/2021 21:37, Rob Herring wrote: On Wed, Sep 01, 2021 at 08:11:38PM +0200, AngeloGioacchino Del Regno wrote: Add yaml binding for msm8998 dpu1 support. Signed-off-by: AngeloGioacchino Del Regno ---   .../bindings/display/msm/dpu

[PATCH v2 2/3] drm/bridge: parade-ps8640: Move real poweroff action to new function

2021-11-02 Thread AngeloGioacchino Del Regno
In preparation for varying the poweron error handling in function ps8640_bridge_poweron(), move function ps8640_bridge_poweroff() up and also move the actual logic to power off the chip to a new __ps8640_bridge_poweroff() function. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm

[PATCH v2 3/3] drm/bridge: parade-ps8640: Perform full poweroff if poweron fails

2021-11-02 Thread AngeloGioacchino Del Regno
it was chosen to call the poweroff function instead of adding code to revert the GPIO changes to the poweron one to avoid duplicating code, as we would be doing exactly what the poweroff function does. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 11

[PATCH v2 1/3] drm/bridge: parade-ps8640: Don't try to enable VDO if poweron fails

2021-11-02 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 4b36e4dc78f1..8c5402947b3c 100644 --- a/drivers/gpu/drm

[PATCH] drm/bridge: parade-ps8640: Link device to ensure suspend/resume order

2021-11-02 Thread AngeloGioacchino Del Regno
and solving the unability to correctly resume bridge operation in the first mentioned example. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge

Re: [RFC 12/13] arm64: dts: mt8192: Add apu tinysys

2021-10-26 Thread AngeloGioacchino Del Regno
Il 23/10/21 13:14, Flora Fu ha scritto: Add node for APU tinysys. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

Re: [RFC 04/13] iommu/mediatek: Add APU iommu support

2021-10-26 Thread AngeloGioacchino Del Regno
Il 23/10/21 13:14, Flora Fu ha scritto: APU IOMMU is a new iommu HW. it use a new pagetable. Add support for mt8192 apu iommu. Signed-off-by: Yong Wu Signed-off-by: Flora Fu --- drivers/iommu/mtk_iommu.c | 57 +++

Re: [RFC 06/13] soc: mediatek: apu: Add apu core driver

2021-10-26 Thread AngeloGioacchino Del Regno
Il 23/10/21 13:14, Flora Fu ha scritto: Add apu core driver. The core driver will init the reset part of apu functions. Signed-off-by: Flora Fu --- drivers/soc/mediatek/Kconfig | 18 + drivers/soc/mediatek/apusys/Makefile | 3 + drivers/soc/mediatek/apusys/apu-core.c | 91

Re: [RFC 08/13] soc: mediatek: apu: Add apusys rv driver

2021-10-26 Thread AngeloGioacchino Del Regno
Il 23/10/21 13:14, Flora Fu ha scritto: Add driver for control APU tinysys APU integrated subsystem having MD32RV33 (MD32) that runs tinysys The tinsys is running on a micro processor in APU. Its firmware is load and boot from Kernel side. Kernel and tinysys use IPI to tx/rx messages.

[PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-10-28 Thread AngeloGioacchino Del Regno
mi: Add optional limit on maximal HDMI mode clock") Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdm

[PATCH 2/3] drm/bridge: parade-ps8640: Move real poweroff action to new function

2021-10-29 Thread AngeloGioacchino Del Regno
In preparation for varying the poweron error handling in function ps8640_bridge_poweron(), move function ps8640_bridge_poweroff() up and also move the actual logic to power off the chip to a new __ps8640_bridge_poweroff() function. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm

[PATCH 1/3] drm/bridge: parade-ps8640: Don't try to enable VDO if poweron fails

2021-10-29 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 4b36e4dc78f1..8c5402947b3c 100644 --- a/drivers/gpu/drm

[PATCH 3/3] drm/bridge: parade-ps8640: Perform full poweroff if poweron fails

2021-10-29 Thread AngeloGioacchino Del Regno
it was chosen to call the poweroff function instead of adding code to revert the GPIO changes to the poweron one to avoid duplicating code, as we would be doing exactly what the poweroff function does. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 11

[PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel

2021-11-04 Thread AngeloGioacchino Del Regno
As it was done with other bridge drivers and to solve a warning coming from drm_dp_aux_register(), add a backpointer to drm_device in the drm_dp_aux that we're registering. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 1 + 1 file changed, 1 insertion

Re: [PATCH v11,14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-01 Thread AngeloGioacchino Del Regno
, it depends on the dma-ranges property of vdec dtsi node. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong ---

Re: [PATCH v11, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-01 Thread AngeloGioacchino Del Regno
#include "mtk_vcodec_util.h" @@ -81,25 +84,60 @@ void mtk_vcodec_mem_free(struct mtk_vcodec_ctx *data, } EXPORT_SYMBOL(mtk_vcodec_mem_free); -void mtk_vcodec_set_curr_ctx(struct mtk_vcodec_dev *dev, - struct mtk_vcodec_ctx *ctx) +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx) { - unsigned long flags; + if (hw_idx >= MTK_VDEC_HW_MAX || hw_idx < 0 || + !dev->subdev_dev[hw_idx]) { Please don't break this line. 83 columns is fine. Apart from that, Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-01 Thread AngeloGioacchino Del Regno
message to "hw arch %d not supported"? Apart from that, Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-01 Thread AngeloGioacchino Del Regno
++-- .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h| 3 +-- 4 files changed, 15 insertions(+), 17 deletions(-) Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-01 Thread AngeloGioacchino Del Regno
/mtk_vcodec_enc_pm.h | 3 +-- 3 files changed, 8 insertions(+), 13 deletions(-) Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: Register each hardware as platform device, need to call pm functions to open/close power and clock from module mtk-vcodec-dec, export these functions. Signed-off-by: Yunfei Dong Reviewed-by: Benjamin Gaignard Reviewed-by: AngeloGioacchino Del

Re: [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread AngeloGioacchino Del Regno
Il 29/11/21 04:41, Yunfei Dong ha scritto: From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 0/2] drm/msm: Fix dsi/bridge probe

2021-11-30 Thread AngeloGioacchino Del Regno
Il 30/11/21 15:10, AngeloGioacchino Del Regno ha scritto: Context, from patch 2/2: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unability to probe the entire stack of components because they all depend on interru

Re: [PATCH v2 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-12-09 Thread AngeloGioacchino Del Regno
Il 02/10/21 00:33, Dmitry Baryshkov ha scritto: On 11/09/2021 19:39, AngeloGioacchino Del Regno wrote: In function dpu_encoder_phys_cmd_wait_for_commit_done we are always checking if the relative CTL is started by waiting for an interrupt to fire: it is fine to do that, but then sometimes we

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-12-10 Thread AngeloGioacchino Del Regno
Il 10/11/21 14:06, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC and a according phy driver mediatek-dp-phy. It supports both functional units on the mt8195, the embedded DisplayPort as well as the external

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread AngeloGioacchino Del Regno
Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() in order to address possible issues on MT8167; moreover, with commit c91026a9

Re: [PATCH v15, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-16 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-12-03 Thread AngeloGioacchino Del Regno
("drm/msm/dsi: Adjust probe order") Co-Developed-By: AngeloGioacchino Del Regno Signed-off-by: Dmitry Baryshkov --- When checking your patch, I noticed that IRQ domain is created before respective MDSS clocks are enabled. This does not look like causing any issues at this time, but it d

Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time

2021-12-03 Thread AngeloGioacchino Del Regno
Il 03/12/21 14:14, Dmitry Baryshkov ha scritto: On 03/12/2021 13:43, AngeloGioacchino Del Regno wrote: Il 01/12/21 21:20, Dmitry Baryshkov ha scritto: Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the DSI host gets initialized earlier, but this caused unabilit

Re: [PATCH v14, 00/19] Support multi hardware decode using of_platform_populate

2021-12-15 Thread AngeloGioacchino Del Regno
Il 15/12/21 07:15, Yunfei Dong ha scritto: This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware

[PATCH] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2021-12-10 Thread AngeloGioacchino Del Regno
() fails!), so also move that one to the dsi host attach function (and remove it in detach). Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 167 +++-- 1 file changed, 84 insertions(+), 83 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 0/2] drm/msm: Fix dsi/bridge probe

2021-11-30 Thread AngeloGioacchino Del Regno
. Instead of actually fixing that patch, I went for "simplifying" the approach by not initializing the entire MDSS, but just the interrupt controller, which still untangles the infinite probe deferrals, but actually doesn't even touch most of the already present logic in place. AngeloGioacchino

[PATCH v2 1/2] drm/msm: Allocate msm_drm_private early and pass it as driver data

2021-11-30 Thread AngeloGioacchino Del Regno
some bind/unbind functions around drm/msm, as some of them are using drm_device just to grab a pointer to the msm_drm_private structure, which we now retrieve in one call. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/adreno_device.c | 16 +++- drivers/gpu/drm/msm

[PATCH v2 2/2] drm/msm: Initialize MDSS irq domain at probe time

2021-11-30 Thread AngeloGioacchino Del Regno
irq domain is registered everytime we call bind() on msm_pdev, add a new *remove function pointer to msm_mdss_funcs, used to remove the irq domain only at msm_pdev_remove() time. Fixes: 8f59ee9a570c ("drm/msm/dsi: Adjust probe order") Signed-off-by: AngeloGioacchino Del Regno --- drivers/g

Re: [PATCH] drm/bridge: parade-ps8640: Link device to ensure suspend/resume order

2022-01-04 Thread AngeloGioacchino Del Regno
Il 04/01/22 15:22, Robert Foss ha scritto: Hey AngeloGioacchino, On Tue, 2 Nov 2021 at 14:08, AngeloGioacchino Del Regno wrote: Entering suspend while the display attached to this bridge is still on makes the resume sequence to resume the bridge first, display last: when this happens, we get

Re: [PATCH 3/3] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-01-07 Thread AngeloGioacchino Del Regno
Il 06/01/22 10:13, Chunfeng Yun ha scritto: On Mon, 2022-01-03 at 15:53 +0100, AngeloGioacchino Del Regno wrote: Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: AngeloGioacchino Del Regno < angelogioacchino.delre...@collabora.com> --- drive

Re: [PATCH v11 05/22] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: Add mt8195 vdosys1 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2022-01-13 Thread AngeloGioacchino Del Regno
allocates and registers the drm device to drm core. Each crtc path is created with the corresponding drm driver data. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: Add driver data of mt8195 vdosys1 to mediatek-drm. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 20/22] drm/mediatek: add drm ovl_adaptor sub driver for MT8195

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if the component exists in the path. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 06/22] soc: mediatek: add mtk-mmsys config API for mt8195 vdosys1

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: Add mmsys config API. The config API is used for config mmsys reg. Some mmsys regs need to be setting according to the HW engine binding to the mmsys simultaneously. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 07/22] soc: mediatek: add cmdq support of mtk-mmsys config API for mt8195 vdosys1

2022-01-13 Thread AngeloGioacchino Del Regno
he "stream done event" to coming and then starts flushing all the HW settings. This can guarantee all the settings flush in the same vblanking. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 09/22] soc: mediatek: change the mutex defines and the mutex_mod type

2022-01-13 Thread AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 10/22] soc: mediatek: add mtk-mutex support for mt8195 vdosys1

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: Add mtk-mutex support for mt8195 vdosys1. The vdosys1 path component contains ovl_adaptor, merge5, and dp_intf1. Ovl_adaptor is composed of several sub-elements. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v11 08/22] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1

2022-01-13 Thread AngeloGioacchino Del Regno
Il 10/01/22 09:46, Nancy.Lin ha scritto: MT8195 vdosys1 has more than 32 reset bits and a different reset base than other chips. Modify mmsys for support 64 bit and different reset base. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 11/15] media: mtk-vcodec: dec: Remove mtk_vcodec_release_dec_pm

2022-01-11 Thread AngeloGioacchino Del Regno
for the clocks, rename it from the _pm to _clk. No functional change. CC: Tiffany Lin CC: Yunfei Dong Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 08/15] drm/mediatek: Add pm runtime support for ovl and rdma

2022-01-11 Thread AngeloGioacchino Del Regno
n display could help pm_runtime_get for smi via ovl or rdma device. CC: CK Hu Signed-off-by: Yongqiang Niu Signed-off-by: Yong Wu (Yong: Use pm_runtime_resume_and_get instead of pm_runtime_get_sync) Acked-by: Chun-Kuang Hu Tested-by: Frank Wunderlich # BPI-R2/MT7623 Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 06/15] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
, then mtk_jpeg_clk_init is also unnecessary. Remove it too. CC: Rick Chang CC: Xia Jiang Signed-off-by: Yong Wu Reviewed-by: Evan Green Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld Tested-by: Frank Wunderlich # BPI-R2/MT7623 Acked-by: AngeloGioacchino Del Regno

Re: [PATCH v9 07/15] media: mtk-mdp: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
-by: Yong Wu Reviewed-by: Evan Green Reviewed-by: Houlong Wei Reviewed-by: Dafna Hirschfeld Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 12/15] media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm

2022-01-11 Thread AngeloGioacchino Del Regno
Lin CC: Irui Wang Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 10/15] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
-by: Yong Wu Reviewed-by: Evan Green Acked-by: Tiffany Lin Reviewed-by: Dafna Hirschfeld Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 13/15] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Green Acked-by: Krzysztof Kozlowski Acked-by: Matthias Brugger Reviewed-by: Dafna Hirschfeld Tested-by: Frank Wunderlich # BPI-R2/MT7623 Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 15/15] arm64: dts: mediatek: Get rid of mediatek, larb for MM nodes

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: After adding device_link between the IOMMU consumer and smi, the mediatek,larb is unnecessary now. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 01/15] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2022-01-11 Thread AngeloGioacchino Del Regno
. And IOMMU also know which larb this consumer connects with from iommu id in the "iommus=" property. Signed-off-by: Yong Wu Reviewed-by: Rob Herring Reviewed-by: Evan Green Acked-by: AngeloGioacchino Del Regno

Re: [PATCH v9 04/15] iommu/mediatek: Add probe_defer for smi-larb

2022-01-11 Thread AngeloGioacchino Del Regno
. device_is_bound may be more elegant here. but it is not allowed to EXPORT from https://lore.kernel.org/patchwork/patch/1334670/. Signed-off-by: Yong Wu Tested-by: Frank Wunderlich # BPI-R2/MT7623 Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 05/15] iommu/mediatek: Add device_link between the consumer and the larb devices

2022-01-11 Thread AngeloGioacchino Del Regno
int the error log. [1] https://lore.kernel.org/linux-mediatek/1564213888.22908.4.camel@mhfsdcap03/ [2] https://lore.kernel.org/patchwork/patch/1086569/ Suggested-by: Tomasz Figa Signed-off-by: Yong Wu Tested-by: Frank Wunderlich # BPI-R2/MT7623 Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 02/15] iommu/mediatek-v1: Free the existed fwspec if the master dev already has

2022-01-11 Thread AngeloGioacchino Del Regno
Reported-by: Frank Wunderlich Tested-by: Frank Wunderlich # BPI-R2/MT7623 Signed-off-by: Yong Wu Acked-by: AngeloGioacchino Del Regno

Re: [PATCH v9 09/15] drm/mediatek: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Reviewed-by: Evan Green Acked-by: Chun-Kuang Hu Reviewed-by: Dafna Hirschfeld Tested-by: Frank Wunderlich # BPI-R2/MT7623 Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 03/15] iommu/mediatek: Return ENODEV if the device is NULL

2022-01-11 Thread AngeloGioacchino Del Regno
NODEV. Currently we don't get the fail case. It's a minor fix, no need add fixes tags. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-11 Thread AngeloGioacchino Del Regno
Il 06/01/22 06:22, CK Hu ha scritto: Hi, Angelo: On Tue, 2022-01-04 at 10:59 +0100, AngeloGioacchino Del Regno wrote: DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to let the bridge to probe: this recently started

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-17 Thread AngeloGioacchino Del Regno
Il 17/01/22 08:04, Yong Wu ha scritto: MediaTek IOMMU block diagram always like below: M4U | smi-common | - | | ... | | larb1 larb2 | | vdec venc All the consumer connect with smi-larb, then connect

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-07 Thread AngeloGioacchino Del Regno
we could just return -EBUSY in this case, but that has the disadvantage of causing system suspend to fail. Signed-off-by: Rob Clark Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/panfrost: Dynamically allocate pm_domains

2022-02-15 Thread AngeloGioacchino Del Regno
n-MediaTek devices, this saves a small amount of memory. Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Alyssa Rosenzweig --- drivers/gpu/drm/panfrost/panfrost_device.c | 14 ++ drivers/gpu/drm/panfrost/panfrost_device.h | 5 ++--- 2 files changed, 12 insertions(+), 7

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-07 Thread AngeloGioacchino Del Regno
Il 07/03/22 03:33, Nancy.Lin ha scritto: Hi Angelo, Thanks for the review. On Wed, 2022-03-02 at 11:13 +0100, AngeloGioacchino Del Regno wrote: Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display

Re: [PATCH 1/3] drm/msm/gpu: Rename runtime suspend/resume functions

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 00:46, Rob Clark ha scritto: From: Rob Clark Hey Rob, looks like you've somehow lost the commit description on this one! Cheers, Angelo Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v15 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 02:54, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation

Re: [PATCH v15 00/22] Add MediaTek SoC DRM (vdosys1) support for mt8195

2022-03-11 Thread AngeloGioacchino Del Regno
Il 11/03/22 02:54, Nancy.Lin ha scritto: The hardware path of vdosys1 with DPTx output need to go through by several modules, such as, OVL_ADAPTOR and MERGE. Add DRM and these modules support by the patches below: Hello maintainers, I have tested this series (and its dependencies - where

Re: [RESEND v13 07/22] soc: mediatek: mmsys: specify 64BIT dependency for MTK_MMSYS

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Because mtk-mutex change to use unsigned long mutex module type, it should depend 64BIT. This is a preparation for adding support for mt8195 vdosys1 mutex. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/Kconfig | 1 + 1 file changed, 1

Re: [RESEND v13 22/22] arm64: dts: mt8195: add display node for vdosys1

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:30, Nancy.Lin ha scritto: Add display node for vdosys1. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 223 +++ 1 file changed, 223 insertions(+)

Re: [RESEND v13 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-03-08 Thread AngeloGioacchino Del Regno
Il 08/03/22 10:29, Nancy.Lin ha scritto: Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation

Re: [PATCH V7 4/5] dt-bindings: display: mediatek: add MT8186 SoC binding

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: Add MT8186 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MUTEX, OVL, POSTMASK and RDMA. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek

Re: [PATCH V7 2/5] dt-bindings: display: mediatek: revise enum to const

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: There won't be more than 1 fallback for these bindings, so we modify them to use const instead of enum. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek

Re: [PATCH V7 3/5] dt-bindings: display: mediatek: change to use enum for mutex

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: All single entry cases in mutex can be merged as a single enum. Signed-off-by: Rex-BC Chen Reviewed-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,mutex.yaml | 24 +++ 1 file

Re: [PATCH V7 1/5] dt-bindings: display: mediatek: add aal binding for MT8183

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: Add aal binding for MT8183. Signed-off-by: Rex-BC Chen Acked-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH V7 5/5] drm/mediatek: add display support for MT8186

2022-03-14 Thread AngeloGioacchino Del Regno
Il 14/03/22 10:00, Rex-BC Chen ha scritto: From: Yongqiang Niu Add mmsys driver data and compatible for MT8186 in mtk_drm_drv.c. Signed-off-by: Yongqiang Niu Signed-off-by: Rex-BC Chen Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-03-16 Thread AngeloGioacchino Del Regno
Il 25/01/22 17:36, Chun-Kuang Hu ha scritto: Hi, AngeloGioacchino: AngeloGioacchino Del Regno 於 2022年1月18日 週二 下午9:38寫道: There is no need to zero out the newly allocated memory because we are duplicating all members of struct mtk_plane_state: switch to kmalloc to save some overhead

Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe()

2022-03-17 Thread AngeloGioacchino Del Regno
. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Lu Wei Reviewed-by: AngeloGioacchino Del Regno Thanks! --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH v14 14/22] drm/mediatek: add display merge async reset control

2022-03-10 Thread AngeloGioacchino Del Regno
-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH v14 15/22] drm/mediatek: add ETHDR support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
, output the required HDR or SDR signal to the subsequent display path. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + drivers/gpu/drm/mediatek

Re: [PATCH v14 10/22] drm/mediatek: add display MDP RDMA support for MT8195

2022-03-10 Thread AngeloGioacchino Del Regno
Il 10/03/22 04:55, Nancy.Lin ha scritto: Add MDP_RDMA driver for MT8195. MDP_RDMA is the DMA engine of the ovl_adaptor component. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers

<    1   2   3   4   5   6   7   8   9   10   >