Re: [Intel-gfx] [PATCH v2 2/5] drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS

2020-02-13 Thread Anshuman Gupta
yte) (((byte) & 0xC0) >> 6) LGTM, verified wrt Table 5.1 HDCP HDMI specs page 64. Reviewed-by: Anshuman Gupta > > struct hdcp_srm_header { > u8 srm_id; > -- > 2.20.1 > > ___ > Intel-gfx mail

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: dont retry stream management at seq_num_m roll over

2020-02-13 Thread Anshuman Gupta
if (!ret || connector->hdcp.seq_num_m > HDCP_2_2_SEQ_NUM_MAX) { > + if (connector->hdcp.seq_num_m > HDCP_2_2_SEQ_NUM_MAX) > + drm_dbg_kms(>drm, "seq_num_m roll > over.\n"); > break; >

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: terminate reauth at stream management failure

2020-02-13 Thread Anshuman Gupta
int ret, i, tries = 3; > > for (i = 0; i < tries; i++) { > ret = hdcp2_authenticate_sink(connector); > - if (!ret) > - break; > + if (!ret) { > + ret = hdcp2_propagate_stream_managem

Re: [PATCH v2 2/2] drm/i915/dc3co: Avoid full modeset when EXITLINE needs to be changed

2020-01-22 Thread Anshuman Gupta
d, so we switch to PSR1, so > the previous code would compute dc3co_exitline=0 causing a full > modeset that would shutdown pipe, enable and train link. > > v2: only programming EXTLINE when DC3CO is enabled > > BSpec: 49196 > Cc: Imre Deak > Cc: Anshuman Gupta > Signed-o

Re: [PATCH] drm/i915/hdcp: Avoid duplicate HDCP enables

2020-05-21 Thread Anshuman Gupta
dy ENABLED. AFAIU may below patch also solves above issue implicitly. https://patchwork.freedesktop.org/patch/365758/?series=72251=4 Besides that +1 for below Ram comment, it would be better if such type of duplicate enable request should filter by drm_atomic_connector_set_property(). Thanks, Ans

[RFC] drm/hdcp: Max MST content streams

2020-10-19 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/drm

Re: [Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Anshuman Gupta
On 2020-10-20 at 11:31:37 +0300, Jani Nikula wrote: > On Mon, 19 Oct 2020, Anshuman Gupta wrote: > > Add support for multiple mst stream in hdcp port data > > which will be used by RepeaterAuthStreamManage msg and > > HDCP 2.2 security f/w for m' validation. > > >

Re: [Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Anshuman Gupta
On 2020-10-20 at 12:39:04 +0300, Jani Nikula wrote: > On Tue, 20 Oct 2020, Anshuman Gupta wrote: > > On 2020-10-20 at 11:31:37 +0300, Jani Nikula wrote: > >> On Mon, 19 Oct 2020, Anshuman Gupta wrote: > >> > Add support for multiple mst stream in hdcp port

[PATCH v2 00/15] HDCP 2.2 DP MST Support

2020-10-20 Thread Anshuman Gupta
DP MST support (https://patchwork.freedesktop.org/series/81289/) and HDCP over MST misc series. (https://patchwork.freedesktop.org/series/82605/) Anshuman Gupta (15): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hotplug: Handle CP_IRQ for DP-MST drm/i915/hdcp: DP MST transcoder

[PATCH v2 01/15] drm/i915/hdcp: Update CP property in update_pipe

2020-10-20 Thread Anshuman Gupta
LED. This caught with DP MST setup, when disabling HDCP on a connector sets the crtc state need_modeset to true for all crtc driving the other DP-MST topology connectors. Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C Signed-off-by: A

[PATCH v2 06/15] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-20 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. This also enable the stream encryption support for older generations, which was missing earlier. v2: - Added debug print for stream encryption. - Disable the hdcp on port after disabling last stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman

[PATCH v2 05/15] drm/i915/hdcp: HDCP stream encryption support

2020-10-20 Thread Anshuman Gupta
that link in order to enable/disable the stream encryption. Both of above requirement are same for all Gen with respect to B.Spec Documentation. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h

[PATCH v2 03/15] drm/i915/hdcp: DP MST transcoder for link and stream

2020-10-20 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display

[PATCH v2 08/15] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-10-20 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 5

[PATCH v2 11/15] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display

[PATCH v2 15/15] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-10-20 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 46 ++- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display

[PATCH v2 13/15] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-20 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[PATCH v2 09/15] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-20 Thread Anshuman Gupta
Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. It is based upon the actual number of MST streams and size of wired_cmd_repeater_auth_stream_req_in. Excluding the size of hdcp_cmd_header. Cc: Tomas Winkler Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/misc/mei

[PATCH v2 14/15] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-10-20 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915

[PATCH v2 10/15] drm/hdcp: Max MST content streams

2020-10-20 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH v2 07/15] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-10-20 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 ++-- drivers/gpu/drm/i915/display/intel_hdcp.c| 12

[PATCH v2 04/15] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-10-20 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 9 - drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +

[PATCH v2 02/15] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-10-20 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++

[PATCH v2 12/15] drm/i915/hdcp: Pass connector to check_2_2_link

2020-10-20 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915

[PATCH v3 11/16] drm/hdcp: Max MST content streams

2020-10-23 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH v3 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-10-23 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++

[PATCH v3 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-10-23 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display

[PATCH v3 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-10-23 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Signed-off-by

[PATCH v3 00/16] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-10-23 Thread Anshuman Gupta
-intel. [PATCH v3 11/16] drm/hdcp: Max MST content streams has an Ack from drm-misc maintainer to merge it via dm-intel. Test-with: 20201023100709.5211-2-karthik@intel.com Anshuman Gupta (16): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hdcp: Get conn while content_type

[PATCH v3 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-23 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

[PATCH v3 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-23 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. This also enable the stream encryption support for older generations, which was missing earlier. v2: - Added debug print for stream encryption. - Disable the hdcp on port after disabling last stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman

[PATCH v3 09/16] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-10-23 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2

[PATCH v3 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-10-23 Thread Anshuman Gupta
that link in order to enable/disable the stream encryption. Both of above requirement are same for all Gen with respect to B.Spec Documentation. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h

[PATCH v3 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-10-23 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display

[PATCH v3 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-10-23 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 ++-- drivers/gpu/drm/i915/display/intel_hdcp.c| 12

[PATCH v3 16/16] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-10-23 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 46 ++- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display

[PATCH v3 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-10-23 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915

[PATCH v3 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-10-23 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915

[PATCH v3 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-23 Thread Anshuman Gupta
Acked-by: Tomas Winkler Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index 9ae9669e46ea..3506a3534294 100644 --- a/drivers/misc/mei/hdcp

[PATCH v3 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-10-23 Thread Anshuman Gupta
: Update CP as per the kernel internal state") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c in

[PATCH v3 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-10-23 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 9 - drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +

[PATCH v3 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-22 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. This also enable the stream encryption support for older generations, which was missing earlier. v2: - Added debug print for stream encryption. - Disable the hdcp on port after disabling last stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman

[PATCH v3 09/16] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-10-22 Thread Anshuman Gupta
hdcp_port_data is specific to a port on which HDCP encryption is getting enabled, so encapsulate it to intel_digital_port. This will be required to enable HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2

[PATCH v3 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-10-22 Thread Anshuman Gupta
: Update CP as per the kernel internal state") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c in

[PATCH v3 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-10-22 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display

[PATCH v3 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-22 Thread Anshuman Gupta
Acked-by: Tomas Winkler Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index 9ae9669e46ea..3506a3534294 100644 --- a/drivers/misc/mei/hdcp

[PATCH v3 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-10-22 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++

[PATCH v3 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-10-22 Thread Anshuman Gupta
Get DRM connector reference count while scheduling a prop work to avoid any possible destroy of DRM connector when it is in DRM_CONNECTOR_REGISTERED state. Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing connectors") Cc: Sean Paul Cc: Ramalingam C Signed-off-by

[PATCH v3 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-10-22 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change") Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 9 - drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +

[PATCH v3 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-10-22 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 ++-- drivers/gpu/drm/i915/display/intel_hdcp.c| 12

[PATCH v3 11/16] drm/hdcp: Max MST content streams

2020-10-22 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH v3 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-10-22 Thread Anshuman Gupta
This requires for HDCP 2.2 MST check link. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915

[PATCH v3 16/16] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-10-22 Thread Anshuman Gupta
Enable HDCP 2.2 over DP MST. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 46 ++- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display

[PATCH v3 15/16] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-10-22 Thread Anshuman Gupta
Add support for HDCP 2.2 DP MST shim callback. This adds existing DP HDCP shim callback for Link Authentication and Encryption and HDCP 2.2 stream encryption callback. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915

[PATCH v3 00/16] HDCP 2.2 DP MST Support

2020-10-22 Thread Anshuman Gupta
://patchwork.freedesktop.org/series/82605/) Anshuman Gupta (16): drm/i915/hdcp: Update CP property in update_pipe drm/i915/hdcp: Get conn while content_type changed drm/i915/hotplug: Handle CP_IRQ for DP-MST drm/i915/hdcp: DP MST transcoder for link and stream drm/i915/hdcp: Move HDCP enc status timeout

[PATCH v3 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-10-22 Thread Anshuman Gupta
that link in order to enable/disable the stream encryption. Both of above requirement are same for all Gen with respect to B.Spec Documentation. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h

[PATCH v3 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-10-22 Thread Anshuman Gupta
Add support for multiple mst stream in hdcp port data which will be used by RepeaterAuthStreamManage msg and HDCP 2.2 security f/w for m' validation. v2: Init the hdcp port data k for HDMI/DP SST strem. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- .../drm/i915/display

[PATCH v3 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-22 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b

Re: [PATCH v3 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-10-26 Thread Anshuman Gupta
On 2020-10-27 at 11:04:17 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [PATCH v3 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 11:59:14 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [PATCH v3 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 11:02:26 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [PATCH v3 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 11:59:14 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [PATCH v3 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 11:50:13 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [PATCH v3 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-10-27 Thread Anshuman Gupta
On 2020-10-27 at 12:41:41 +0530, Shankar, Uma wrote: > > > > -Original Message- > > From: Anshuman Gupta > > Sent: Friday, October 23, 2020 5:51 PM > > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: seanp...@chromium.o

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-08-12 Thread Anshuman Gupta
On 2020-08-11 at 13:28:46 -0400, Sean Paul wrote: > On Thu, Jul 9, 2020 at 8:40 AM Anshuman Gupta > wrote: > > > > \snip > > > > > +static int > > > > +intel_dp_mst_hdcp_toggle_signalling(struct intel_digital_port > > > > *int

Re: [Intel-gfx] [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-08-12 Thread Anshuman Gupta
On 2020-08-11 at 13:21:38 -0400, Sean Paul wrote: > On Thu, Jul 9, 2020 at 9:09 AM Anshuman Gupta > wrote: > > > > On 2020-07-02 at 20:07:36 +0530, Anshuman Gupta wrote: > > > On 2020-06-30 at 12:48:34 -0400, Sean Paul wrote: > > > > On Tue, Jun 30, 2020 at

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-08-13 Thread Anshuman Gupta
On 2020-08-12 at 13:21:51 -0400, Sean Paul wrote: > On Wed, Aug 12, 2020 at 3:15 AM Anshuman Gupta > wrote: > > > > On 2020-08-11 at 13:28:46 -0400, Sean Paul wrote: > > > On Thu, Jul 9, 2020 at 8:40 AM Anshuman Gupta > > > wrote: > > > >

Re: [Intel-gfx] [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-07-02 Thread Anshuman Gupta
On 2020-06-30 at 12:48:34 -0400, Sean Paul wrote: > On Tue, Jun 30, 2020 at 10:21 AM Anshuman Gupta > wrote: > > > > On 2020-06-23 at 21:29:05 +0530, Sean Paul wrote: > > Hi Sean, > > I am new to DP MST stuff, I am looking to DP MST spec DP v1.2a. > > I have l

Re: [Intel-gfx] [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-06-30 Thread Anshuman Gupta
for DP MST stream encryption. Thanks, Anshuman Gupta. > From: Sean Paul > > Used to query whether an MST stream is encrypted or not. > > Signed-off-by: Sean Paul > > Link: > https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-14-s...@poorly.run

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-07-09 Thread Anshuman Gupta
t; > + if (!enable) > > + usleep_range(6, 60); /* Bspec says >= 6us */ > > + > > + ret = intel_ddi_toggle_hdcp_signalling(_dig_port->base, > > + cpu_transcoder, enable); > Sean, > > This function toggles

Re: [Intel-gfx] [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-07-09 Thread Anshuman Gupta
On 2020-07-02 at 20:07:36 +0530, Anshuman Gupta wrote: > On 2020-06-30 at 12:48:34 -0400, Sean Paul wrote: > > On Tue, Jun 30, 2020 at 10:21 AM Anshuman Gupta > > wrote: > > > > > > On 2020-06-23 at 21:29:05 +0530, Sean Paul wrote: > > > Hi Sean, > >

Re: [Intel-gfx] [PATCH v7 14/17] drm/i915: Add connector to hdcp_shim->check_link()

2020-07-03 Thread Anshuman Gupta
dds > connector to the check_link() arguments so we have it when we need it. > > Signed-off-by: Sean Paul Looks good to me, this require a rebase on latest drm-tip Reviewed-by: Anshuman Gupta > Link: > https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-13-s...@poor

Re: [Intel-gfx] [PATCH v7 13/17] drm/i915: Plumb port through hdcp init

2020-07-03 Thread Anshuman Gupta
On 2020-06-23 at 21:29:03 +0530, Sean Paul wrote: > From: Sean Paul > > This patch plumbs port through hdcp init instead of relying on > intel_attached_encoder() to return a non-NULL encoder which won't work > for MST connectors. Looks good to me, Reviewed-by: Anshuman Gupta

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-07-03 Thread Anshuman Gupta
On 2020-07-03 at 16:48:27 +0530, Anshuman Gupta wrote: > On 2020-06-23 at 21:29:07 +0530, Sean Paul wrote: > > From: Sean Paul > > > > Now that all the groundwork has been laid, we can turn on HDCP 1.4 over > > MST. Everything except for toggling the HDCP signalli

Re: [Intel-gfx] [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors

2020-07-03 Thread Anshuman Gupta
d */ > + if (conn_state->content_protection == > + DRM_MODE_CONTENT_PROTECTION_DESIRED) > + intel_hdcp_enable(to_intel_connector(conn_state->connector), > + pipe_config->cpu_transcoder, > + (u8)co

Re: [Intel-gfx] [PATCH v7 08/17] drm/i915: Clean up intel_hdcp_disable

2020-07-03 Thread Anshuman Gupta
On 2020-06-23 at 21:28:58 +0530, Sean Paul wrote: > From: Sean Paul > > Add an out label and un-indent hdcp disable in preparation for > hdcp_mutex. No functional changes LGTM Reviewed-by: Anshuman Gupta > > Signed-off-by: Sean Paul > Link: > https://patchwork.fre

Re: [Intel-gfx] [PATCH] drm/i915: Avoid modeset when content protection changes

2020-07-30 Thread Anshuman Gupta
nged = true; > + to_intel_crtc_state(crtc_state)->update_pipe = true; IMHO intel_crtc_check_fastset() make sure that every crtc_state->mode_changed will not turn up to a modeset. It seems it is already being taken care. Thanks, Anshuman Gupta. > } >

[PATCH v6 14/18] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-25 Thread Anshuman Gupta
: Ramalingam C Reviewed-by: Uma Shankar Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 113 +++--- 2 files changed, 102 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[PATCH v6 17/18] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-11-25 Thread Anshuman Gupta
redundant link check. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 89 +-- 2 files changed, 85 insertions(+), 8 deletions

[PATCH v6 18/18] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-11-25 Thread Anshuman Gupta
: Ramalingam C Reviewed-by: Uma Shankar Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 53 ++- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display

[PATCH v6 08/18] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-25 Thread Anshuman Gupta
for connector detail in DMESG. [Ram] - comments improvement. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 38 +++ 1 file changed, 25 insertions(+), 13 deletions(-) diff --git

[PATCH v6 12/18] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-25 Thread Anshuman Gupta
Acked-by: Tomas Winkler Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp

[PATCH v6 06/18] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-25 Thread Anshuman Gupta
. It will be used by both HDCP{1.x,2.x} stream status timeout. Related: 'commit 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt status change")' Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_

[PATCH v6 05/18] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-25 Thread Anshuman Gupta
and HDCP 2.2 over DP MST on Gen12. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- .../gpu/drm/i915/display/intel_display_types.h| 2 ++ drivers/gpu/drm

[PATCH v6 07/18] drm/i915/hdcp: HDCP stream encryption support

2020-11-25 Thread Anshuman Gupta
C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- drivers/gpu/drm/i915/display/intel_ddi.h | 6 +- .../drm/i915/display/intel_display_types.h| 4 + drivers/gpu/drm

[PATCH v6 00/18] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support

2020-11-25 Thread Anshuman Gupta
] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len has an Ack from Tomas to merge it via drm-intel. [PATCH v6 13/18] drm/hdcp: Max MST content streams has an Ack from drm-misc maintainer to merge it via drm-intel. Test-with: 20201126050320.2434-2-karthik@intel.com Anshuman Gupta (18): drm

[PATCH v6 01/18] drm/i915/hdcp: Update CP property in update_pipe

2020-11-25 Thread Anshuman Gupta
ion_state == DRM_CONNECTOR_REGISTERED) v3: - Commit log improvement. [Uma] - Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Sign

[PATCH v6 09/18] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-25 Thread Anshuman Gupta
Enable HDCP 1.4 over DP MST for Gen12. v2: - Enable HDCP for <= Gen12 platforms. [Ram] Cc: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v6 10/18] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-25 Thread Anshuman Gupta
Pass dig_port as an argument to intel_hdcp_init() and intel_hdcp2_init(). This will be required for HDCP 2.2 stream encryption. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display

[PATCH v6 11/18] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-11-25 Thread Anshuman Gupta
Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 + .../drm/i915/display/intel_display_types.h| 5 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 56 +++ 3 files changed, 39 insertions(+), 24 deletions(-) diff

[PATCH v6 13/18] drm/hdcp: Max MST content streams

2020-11-25 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Acked-by: Maarten Lankhorst Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta

[PATCH v6 16/18] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-11-25 Thread Anshuman Gupta
Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS and HDCP2_AUTH_STREAM register in i915_reg header. Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/i915_reg.h | 30 ++ 1 file

[PATCH v6 15/18] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-25 Thread Anshuman Gupta
-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c

[PATCH v6 02/18] drm/i915/hdcp: Get conn while content_type changed

2020-11-25 Thread Anshuman Gupta
ma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index ee

[PATCH v6 03/18] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-11-25 Thread Anshuman Gupta
Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST topology. Cc: "Ville Syrjälä" Cc: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Ramalingam C Tested-by: Karthik B S Signed-off-by

[PATCH v6 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-11-25 Thread Anshuman Gupta
There can be situation when DP MST connector is created without mst modeset being done, in those cases connector->encoder will be NULL. MST connector->encoder initializes after modeset. Don't enable HDCP in such cases to prevent any crash. Cc: Ramalingam C Cc: Juston Li Signed-off-by: An

Re: [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-24 Thread Anshuman Gupta
On 2020-11-24 at 19:44:59 +0530, Ramalingam C wrote: > On 2020-11-11 at 11:50:41 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 DP MST stream encryption. > > > > Enable stream encryption once encryption is enabled on > > the DP transport driving the link for each str

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Anshuman Gupta
On 2020-11-24 at 21:47:19 +0530, Ramalingam C wrote: > On 2020-11-24 at 20:32:43 +0530, Anshuman Gupta wrote: > > On 2020-11-24 at 19:50:17 +0530, Ramalingam C wrote: > > > On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > > > > Enable HDCP 1.4 over DP MST

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Anshuman Gupta
On 2020-11-24 at 19:50:17 +0530, Ramalingam C wrote: > On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 over DP MST for Gen12. > > > > Cc: Ramalingam C > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/displa

[PATCH v7 08/18] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-12-09 Thread Anshuman Gupta
for connector detail in DMESG. [Ram] - comments improvement. [Ram] Cc: Ramalingam C Reviewed-by: Uma Shankar Tested-by: Karthik B S Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_hdcp.c | 38 +++ 1 file changed, 25 insertions(+), 13 deletions(-) diff --git

  1   2   3   >