Re: [PATCH 07/10] video: fbdev: use resource_size

- (ptr.end - ptr.start + 1) > + resource_size() > > > Signed-off-by: Julia Lawall Patch queued for v5.6 (with patch summary modified slightly to reflect that this a change for cg14fb fbdev driver), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electroni

Re: [PATCH] video: fbdev: arcfb: add missed free_irq

*)info->screen_base); > framebuffer_release(info); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/6] video: fbdev: controlfb: remove function prototypes part #2

Reorder code a bit and then remove no longer needed function prototypes. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 410 +++- 1 file changed, 198 insertions(+), 212 deletions(-) diff --git a/drivers/video/fbdev/controlfb.c b

[PATCH 3/6] video: fbdev: controlfb: add COMPILE_TEST support

Add COMPILE_TEST support to controlfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig | 2 +- drivers/video/fbdev/controlfb.c | 21 +++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git

[PATCH] video: fbdev: arcfb: add COMPILE_TEST support

Add COMPILE_TEST support to arcfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH 2/6] video: fbdev: controlfb: remove obsolete module support

CONFIG_FB_CONTROL is bool, hence the Apple "control" frame buffer driver cannot be built as a module. Replace module_init() by device_initcall(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 25 + 1 file changed, 1 insert

[PATCH 4/6] video: fbdev: controlfb: remove function prototypes part #1

Reorder code a bit and then remove no longer needed function prototypes. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 41 +++-- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/drivers/video/fbdev/controlfb.c b/drivers

[PATCH 6/6] video: fbdev: controlfb: remove function prototypes part #3

Reorder code a bit and then remove no longer needed function prototypes. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 306 +++- 1 file changed, 147 insertions(+), 159 deletions(-) diff --git a/drivers/video/fbdev/controlfb.c b

[PATCH 0/6] video: fbdev: controlfb: small cleanup

Hi, Small cleanup for controlfb driver: - fix sparse warnings - remove not working module support - add COMPILE_TEST support - remove redundant function prototypes Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (6): video

[PATCH 2/2] video: fbdev: wm8505fb: add COMPILE_TEST support

Add COMPILE_TEST support to wm8505fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

Use ->screen_buffer instead of ->screen_base to fix sparse warnings. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Signed-off-by: Bartlomiej Zolnierkiewicz --- Resend with Tony & linux-arm ML added to Cc:. drivers/vi

[PATCH 2/2] video: fbdev: w100fb: add COMPILE_TEST support

Add COMPILE_TEST support to w100fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH 1/2] video: fbdev: w100fb: fix sparse warnings

* Add missing __iomem annotations where needed. * Make w100fb_probe() static. * Return NULL pointer (instead of using plain integer) in w100_get_xtal_tabl(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/w100fb.c | 18 ++ 1 file changed, 10 insertions

[PATCH 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

Force le32_to_cpup() argument to be of proper type (const __le32 *). Also add missing inline keyword to control_par_to_var() definition (to match function prototype). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 1/2] video: fbdev: sh_mobile_lcdcfb: fix sparse warnings about using incorrect types

Use ->screen_buffer instead of ->screen_base to fix sparse warnings. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/sh_mobile_lcdcfb.c |4 ++-- 1 file chang

[PATCH 2/2] video: fbdev: sh_mobile_lcdcfb: add COMPILE_TEST support

Add COMPILE_TEST support to sh_mobile_lcdcfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

Use ->screen_buffer instead of ->screen_base to fix sparse warnings. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/wm8505fb.c |2 +- 1 file changed, 1

Re: [PATCH] fbdev: wait for references go away

loaded. > Fix this by trying to wait until all references are gone. Don't wait > forever though given that userspace might keep the file handle open. Where does the 1s maximum delay come from? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] fbdev: wait for references go away

On 1/20/20 6:51 PM, Bartlomiej Zolnierkiewicz wrote: > do_unregister_framebuffer() doesn't guarantee that fb_info is freed after > function's return (it only drops the kernel reference on fb_info). s/kernel/fbdev device driver/ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Ins

Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code

>> > Acked-by: Jingoo Han Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics >> --- >> drivers/video/fbdev/s3c-fb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletio

Re: [PATCH 3/3] video: fbdev: mmp: fix sparse warnings about using incorrect types

On 8/20/19 1:07 PM, Andrzej Hajda wrote: > On 27.06.2019 16:08, Bartlomiej Zolnierkiewicz wrote: >> Use ->screen_buffer instead of ->screen_base in mmpfb driver. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer&quo

Re: [PATCH 1/3] video: fbdev: mmp: remove duplicated MMP_DISP dependency

On 8/20/19 11:55 AM, Andrzej Hajda wrote: > On 27.06.2019 16:07, Bartlomiej Zolnierkiewicz wrote: >> This dependency is already present in higher level Kconfig file >> (drivers/video/fbdev/mmp/Kconfig). >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > >

Re: [PATCH 2/3] video: fbdev: mmp: add COMPILE_TEST support

On 8/20/19 11:56 AM, Andrzej Hajda wrote: > On 27.06.2019 16:07, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to mmp display subsystem for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > > Reviewed-by:

Re: [PATCH v3 2/3] fbdev: fbmem: allow overriding the number of bootup logos

On 8/27/19 1:09 PM, Peter Rosin wrote: > Probably most useful if you want no logo at all, or if you only want one > logo regardless of how many CPU cores you have. > > Signed-off-by: Peter Rosin Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -

Re: [PATCH v3 1/3] fbdev: fix numbering of fbcon options

e documentation") > Signed-off-by: Peter Rosin Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Documentation/fb/fbcon.rst | 8 > 1 file changed, 4 in

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

ix") comes from framebuffer_alloc() (which is called by fbdev device drivers prior to registering "info" with register_framebuffer()). framebuffer_alloc() does kzalloc() on "info". Therefore shouldn't memcpy() (as suggested by Jeo Perches) be enough? Best regards, -- B

Re: [PATCH -next] fbdev/sa1100fb: use devm_platform_ioremap_resource() to simplify code

On 9/4/19 1:57 PM, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks, patch queued for v5.6 (also sorry for the delay). Best regards

Re: [PATCH] video: fbdev: fsl-diu-fb: mark expected switch fall-throughs

t; Signed-off-by: Gustavo A. R. Silva Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/fsl-diu-fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dr

Re: [PATCH v6 47/57] video: Remove dev_err() usage after platform_get_irq()

his patch changes handling of -EPROBE_DEFER in the modified drivers (most don't support it and error message will no longer be printed). I cannot apply it as it is (seems that -EPROBE_DEFER handling should be audited/fixed in the affected drivers first). Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path

f LCD display controller on >> pxa168/910 (base layer)") >> Signed-off-by: Christophe JAILLET > > Reviewed-by: Lubomir Rintel Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung

Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

nclude/linux/fb.h? Sounds like a good idea. > Feels like that could be done later, after these other cleanups you mention, > so that the new file has a few more things to declare. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video/fbdev/68328fb: Remove dead code

On 9/2/19 2:49 PM, Souptick Joarder wrote: > This is dead code since 3.15. If their is no plan to > use it further, these can be removed forever. > > Signed-off-by: Souptick Joarder Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH] video: pxafb: Use devm_platform_ioremap_resource() in pxafb_probe()

Markus Elfring Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/pxafb.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git

Re: [PATCH] video: ocfb: Use devm_platform_ioremap_resource() in ocfb_probe()

Markus Elfring Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ocfb.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/dri

Re: [PATCH] omapfb: reduce stack usage

ccessing dsi->irq_stats directly before cleaning it (we would also need to extend coverage of spinlock but the code is debug only so this should not be a problem). Care to try this approach? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > memse

Re: [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code

rm_get_resource() and devm_ioremap_resource() together. Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Signed-off-by: Sekhar Nori Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/da8xx-fb

Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code

On 9/4/19 1:54 PM, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks, patch queued for v5.6 (also sorry for the delay). Best regards

Re: [PATCH] fbdev: matrox: make array wtst_xlat static const, makes object smaller

t[] = { 0, 1, 5, 6, 7, 5, 2, 3 }; >> +static const u_int32_t wtst_xlat[] = { >> +0, 1, 5, 6, 7, 5, 2, 3 > > All of those would easily fit in u8 as well. Good idea, I've converted the table to u8 while applying

Re: [PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

On 3/24/20 9:45 PM, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 02:45:03PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Use in_le32() instead of le32_to_cpup() to fix sparse warning about >> improper type of the argument. >> >> Also add missing inline keyword to cont

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

chenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ssd1307fb.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb

Re: [PATCH v1 4/5] video: ssd1307fb: Convert to atomic PWM API

e also make use of the pwm_set_relative_duty_cycle() helper to ease > relative to absolute duty_cycle conversion. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > driver

Re: [PATCH v2 0/6] video: fbdev: controlfb: small cleanup

On 3/24/20 2:45 PM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > Small cleanup for controlfb driver: > > - fix sparse warnings > - remove not working module support > - add COMPILE_TEST support > - remove redundant function prototypes > > Changes since v1 &

Re: [PATCH v1 2/5] video: ssd1307fb: Introduce temporary variable to increase readability

[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Introduce temporary variable to increase readability of the code. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8 (w/ few lines over 80 characters fixed), thanks. Best regards, -- Bartlomiej Zolni

Re: [PATCH -next] omapfb/dss: remove unused varible 'venc_config_pal_bdghi'

ig_pal_bdghi = { > ^ > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Patch queued for v5.8 (w/ typo in the patch summary fixed), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland > --- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 43 -

Re: [PATCH v1 5/5] video: ssd1307fb: Remove redundant forward declaration

[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > There is no need to have forward declaration of struct ssd1307fb_par. > Drop it for good. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH] video: fbdev: imxfb: ensure balanced regulator usage

> unbalanced disables for lcd supply > > which can be triggered by doing > > echo 4 > /sys/class/lcd/imxfb-lcd/lcd_power > > twice. > > Signed-off-by: Uwe Kleine-König Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH v1 3/5] video: ssd1307fb: Make use of device properties

ued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ssd1307fb.c | 40 - > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/drivers/video/fbdev/

Re: [PATCH] video: vt8500lcdfb: fix fallthrough warning

89408 ("fbdev: Implement simple blanking in pseudocolor modes > for vt8500lcdfb") > Cc: Alexey Charkov > Cc: Paul Mundt > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Cc: # v2.6.38+ Patch queued for v5.8, thanks

Re: [PATCH] video: fbdev: aty128fb: remove unused 'sdr_64'

> > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/aty128fb.c | 14 -- > 1 file changed, 14 deletion

Re: [PATCH v3] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

; > Signed-off-by: Chuhong Yuan Patch queued for v5.8 (w/ extra newline removed), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v3: > - Fix code style. > - Set __s1d13xxxfb_remove() to return void. >

Re: [PATCH v2 RESEND] ARM/fbdev: sa11x0: Switch to use GPIO descriptors

[ added dri-devel ML to Cc: ] On 4/15/20 6:50 PM, Linus Walleij wrote: > This converts the SA11x0 frame buffer driver to use > GPIO descriptors. Get the GPIO optional and register > a look-up table specifically for the Shannon machine. > > Cc: Russell King > Cc: Bartlom

Re: [PATCH v4] video: fbdev: arcfb: add missed free_irq and fix the order of request_irq

g Yuan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v4: > - Use info->par->irq instead of par->irq to avoid dereferencing NULL > pointer. > > drivers/video/fbdev/arcfb.c | 10

Re: [PATCH v4] video: fbdev: vesafb: add missed release_region

er request_region() succeeds. > Then only call release_region() when "region" is not null. > > Signed-off-by: Chuhong Yuan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v4:

Re: framebuffer bug (Re: general protection fault in do_syscall_64)

ime to time so any help in fixing this and other syzbot reports is welcomed. PS fbdev is maintained through drm-misc tree so patches can also be handled by other drm-misc maintainers in case I'm not available. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronic

Re: [PATCH 0/3] video: Use scnprintf() for avoiding potential buffer overflow

On 3/27/20 9:25 AM, Takashi Iwai wrote: > On Fri, 20 Mar 2020 14:42:51 +0100, > Bartlomiej Zolnierkiewicz wrote: >> >> >> On 3/19/20 4:49 PM, Takashi Iwai wrote: >>> On Wed, 11 Mar 2020 10:32:27 +0100, >>> Takashi Iwai wrote: >>>> >&

Re: [PATCH v2 2/2] powerpc: Remove Xilinx PPC405/PPC440 support

delete mode 100644 arch/powerpc/platforms/40x/virtex.c > delete mode 100644 arch/powerpc/platforms/44x/virtex.c > delete mode 100644 arch/powerpc/platforms/44x/virtex_ml510.c > delete mode 100644 arch/powerpc/sysdev/xilinx_intc.c > delete mode 100644 arch/powerpc/sysdev/xilinx_pci.

Re: INFO: trying to register non-static key in try_to_wake_up

; > +fbdev maintainers Thank you for the report. fbdev is in the maintenance mode and no new features or drivers are being added so syzbot reports are not for a new bugs (regressions) and are not a priority (at least to me). I have only resources to review/merge pending fbdev patches from time

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

On 4/23/20 5:05 PM, Andy Shevchenko wrote: > On Thu, Apr 23, 2020 at 5:55 PM Bartlomiej Zolnierkiewicz > wrote: > >>> + if (err) >>> + iounmap((void *)npregs); >> >> Looks OK but while you are at it, could you please also add m

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

= do_take_over_console(_con, 0, MAX_NR_CONSOLES - 1, 1); console_unlock(); return err; } static void newport_remove(struct gio_device *dev) { give_up_console(_con); iounmap((void *)npregs); } ? > return err; > } > Best regards, -- Bartlomiej Zolnie

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

ect solution but at the cost of 2 ifdefs it allows controlfb driver to be compile tested on any arch. Being able to compile test fbdev device drivers is really useful for me and saves me a lot of time when doing fbdev maintainer duties. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Inst

[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c |

Re: linux-next: build failure after merge of the drm-misc tree

ill appears to have not been addressed. Sorry for the delay, I've just posted a patch (also included below): "[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n" which should fix it. Please verify it, thank you! Best regards, -- Bartlomiej Zo

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

On 4/29/20 1:54 PM, Sam Ravnborg wrote: > Hi Bartlomiej. > > On Wed, Apr 29, 2020 at 12:48:24PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> powerpc allyesconfig fails like this: >> >> drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': >>

Re: linux-next: build failure after merge of the drm-misc tree

On 4/29/20 10:09 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi Stephen, > > On 4/29/20 12:33 AM, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 20 Apr 2020 13:01:18 +1000 Stephen Rothwell >> wrote: >>> >>> After merging the drm-misc tr

[PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: fix implicit btext_update_di

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

ing of fbdev patches posted too late for v5.7 has been postponed after v5.7-rc1 release. LGTM after quick look. I'll review it properly / apply later this week (hopefully tomorrow). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics >>&g

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

short on features and overall below par >>> >>> Users are encouraged to switch to the nouveau drm driver instead. >>> >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej) >>> >>> Cc: Antonino Daplas >>> Cc: Bartlomiej Zolni

Re: [PATCH] fbdev: annotate rivafb/nvidiafb as obsolete

> Considering nouveau supports all that hardware (modulo nv03) just mark > these as obsolete/broken, referring to nouveau in the help text. > > Cc: Antonino Daplas > Cc: Bartlomiej Zolnierkiewicz > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Sign

Re: [PATCH] omapfb: Remove unused writeback code

On 3/13/20 1:24 PM, Tomi Valkeinen wrote: > Remove unused writeback code. This code will never be used, as omapfb is > being deprecated. > > Signed-off-by: Tomi Valkeinen Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung

Re: fbdev: fix -Wextra build warnings

|8 > drivers/video/fbdev/savage/savagefb.h |2 +- > drivers/video/fbdev/via/debug.h|6 -- > drivers/video/fbdev/via/viafbdev.c |2 +- > 8 files changed, 14 insertions(+), 12 deletions(-) Patches #1-6 queued for v5.7, t

Re: [PATCH 0/3] video: Use scnprintf() for avoiding potential buffer overflow

> > Just a gentle ping about those patches. > Let me know if any further changes needed. Patches #1-3 queued for v5.7, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] video: fbdev: arcfb: add missed free_irq and fix the order of request_irq

ble (it is used only once), why not simply use info->par->irq in free_irq() call below? > if (info) { > unregister_framebuffer(info); > + if (irq) > + free_irq(par->irq, info); > vfree((void __force *)info->scre

Re: [PATCH v3] video: fbdev: vesafb: add missed release_region

; arch_phys_wc_del(par->wc_cookie); > if (info->screen_base) > @@ -481,6 +483,7 @@ static int vesafb_remove(struct platform_device *pdev) > struct fb_info *info = platform_get_drvdata(pdev); > > unregister_framebuffer(info); > + release_region(0x3c0, 32); &g

Re: [PATCH v2] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

> struct s1d13xxxfb_par *default_par; > @@ -895,7 +906,7 @@ static int s1d13xxxfb_probe(struct platform_device *pdev) > return 0; > > bail: > - s1d13xxxfb_remove(pdev); > + __s1d13xxxfb_remove(pdev); > return ret; > > } > Best regards

Re: [PATCH] Fix off by one in nvidia driver strncpy size arg

Signed-off-by: Random J Developer using your real name (sorry, no pseudonyms or anonymous contributions.) ... Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > > Notes: > The bug could also be fixed by changing the size argume

Re: [PATCH v3] video: fbdev: vesafb: add missed release_region

On 3/24/20 2:35 PM, Chuhong Yuan wrote: > On Fri, Mar 20, 2020 at 8:01 PM Bartlomiej Zolnierkiewicz > wrote: >> >> >> On 3/10/20 3:35 AM, Chuhong Yuan wrote: >>> The driver forgets to free the I/O region in remove and probe >>> failure. >>>

[PATCH v2 4/6] video: fbdev: controlfb: remove function prototypes part #1

Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 41 +++-- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/drivers/video

[PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

Use in_le32() instead of le32_to_cpup() to fix sparse warning about improper type of the argument. Also add missing inline keyword to control_par_to_var() definition (to match function prototype). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev

[PATCH v2 0/6] video: fbdev: controlfb: small cleanup

of le32_to_cpup() - use eieio() and dcbf() helpers - add invalid_vram_cache() helper - add more dummy CONFIG_PPC_PMAC=n helpers to avoid ifdefs - add ACKs from Sam Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (6): video: fbdev

[PATCH v2 3/6] video: fbdev: controlfb: remove obsolete module support

CONFIG_FB_CONTROL is bool, hence the Apple "control" frame buffer driver cannot be built as a module. Replace module_init() by device_initcall(). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 25 + 1 fi

[PATCH v2 6/6] video: fbdev: controlfb: remove function prototypes part #3

Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 302 +++- 1 file changed, 145 insertions(+), 157 deletions(-) diff --git a/drivers/video

[PATCH v2 5/6] video: fbdev: controlfb: remove function prototypes part #2

Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 410 +++- 1 file changed, 198 insertions(+), 212 deletions(-) diff --git a/drivers/video

[PATCH v2 2/6] video: fbdev: controlfb: add COMPILE_TEST support

Add COMPILE_TEST support to controlfb driver for better compile testing coverage. While at it: - convert driver to use eieio() and dcbf() helpers instead of open-coding them - add invalid_vram_cache() helper to avoid code duplication Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej

Re: [PATCH] fbdev: remove mbx framebuffer driver

ere is no > point to keep the obsolete framebuffer driver. > > Signed-off-by: Mike Rapoport Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > .../userspace-api/ioctl/ioctl-number.rst

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

gt; video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container > fbdev: radeonfb:use generic power management > > drivers/video/fbdev/aty/radeon_base.c | 10 --- > drivers/video/fbdev/aty/radeon_pm.c | 38 --- > drivers/video/fbdev/aty/rad

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

t; CC: Denis Efremov > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > > tree: https://git.kernel.org/pub/scm/linu

Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

eon_kick_out_firmware_fb(pdev); >> if (ret) >> - return ret; >> + goto err_release_fb; > > Good catch ! Thanks > > Reviewed-by: Mathieu Malaterre Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH] video: fbdev: replace spurious snprintf() with sprintf()

On 8/24/20 7:44 PM, Alex Dewar wrote: > par->vgapass is a u8, so if we are assuming that buf is at least > PAGE_SIZE then the extra checking is pointless. > > Signed-off-by: Alex Dewar Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH v4] video: fbdev: ssd1307fb: Added support to Column offset

, 7 insertions(+), 2 deletions(-) >> > > Acked-by: Rob Herring Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing

Re: [PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

lated code. Very > little is now left.") > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/vga16fb.c | 14 +++---

Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe

d to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/fbdev/sm712fb.

Re: [PATCH 1/1] fbmem: add margin check to fb_check_caps()

o validate xres and yres settings. >> >> Signed-off-by: George Kennedy >> Suggested-by: Dan Carpenter > > Suggested-by is perhaps a bit strong. Let's change that to: > > Reviewed-by: Dan Carpenter Applied to drm-misc-next tree, thanks and sorry for the delay. Best reg

Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings

@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n&qu

Re: [PATCH] video: fbdev: sis: fix null ptr dereference

gt; queuedata is not set in the else block > > Reviewing the old code, the arrays FQBQData730 and FQBQData were > used directly. > > So hoist the setting of queuedata out of the if-else block. > > Fixes: 544393fe584d ("[PATCH] sisfb update") > > Signed-off-by:

Re: [PATCH] omapfb: fix spelling mistake "propert" -> "property"

On 8/5/20 12:28 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_err message. Fix it. > > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Sams

Re: [PATCH v3 00/12] video: fbdev: use generic power management

drivers/video/fbdev/vt8623fb.c | 41 ++--- > include/linux/via-core.h | 2 - > 17 files changed, 267 insertions(+), 256 deletions(-) Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Ele

Re: [PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

Device Drivers->Graphics Support-> > Console display driver support->Framebuffer Console Support. > > Correcting it in the docs. > > Signed-off-by: Bilal Wasim Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Polan

Re: [PATCH] video: fbdev: remove set but not used 'ulBestVCO'

’ set but not used [-Wunused-but-set-variable] > 123 | u32 ulBestVCO = 0, ulBestClk = 0, ulBestScore = 0; > | ^ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sam

Re: [PATCH 22/29] video: fbdev: Avoid comma separated statements

On 8/25/20 6:56 AM, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/tgafb.c | 12 ++

Re: [PATCH] video: fbdev: remove set but not used 'ulCoreClock'

’ set but not used [-Wunused-but-set-variable] // yanaijie > fixed > 247 | u32 ulCoreClock; > | ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institut

<    1   2   3   4   5   6   7   >