Re: [PATCH -next] nouveau: fix acpi_lid_open undefined

2010-05-24 Thread Ben Skeggs
to `acpi_lid_open' Signed-off-by: Randy Dunlap randy.dun...@oracle.com Acked-by: Ben Skeggs bske...@redhat.com Cc: David Airlie airl...@linux.ie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/nouveau/nouveau_connector.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux

Re: [patch] drm/nouveau: off by one in init_i2c_device_find()

2010-06-02 Thread Ben Skeggs
On Tue, 2010-05-25 at 11:52 +0200, Dan Carpenter wrote: dcb-i2c[] has DCB_MAX_NUM_I2C_ENTRIES entries. Signed-off-by: Dan Carpenter erro...@gmail.com Thanks, picked this up in the nouveau tree. diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c

[PATCH] drm: disable encoder rather than dpms off in drm_crtc_prepare_encoders()

2010-07-01 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Original behaviour will be preserved for drivers that don't implement disable() hooks for an encoder. Signed-off-by: Ben Skeggs bske...@redhat.com --- drivers/gpu/drm/drm_crtc_helper.c | 22 ++ 1 files changed, 14 insertions(+), 8

Re: deadlock possiblity introduced by drm/nouveau: use drm_mm in preference to custom code doing the same thing

2010-07-10 Thread Ben Skeggs
On Sun, 2010-07-11 at 01:24 +0200, Marcin Slusarz wrote: Hi Patch drm/nouveau: use drm_mm in preference to custom code doing the same thing in nouveau tree introduced new deadlock possibility, for which lockdep complains loudly: [ 1541.070202] [drm] nouveau :02:00.0: Allocating

[PATCH 2/2] drm/ttm: restructure to allow driver to plug in alternate memory manager

2010-08-05 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Nouveau will need this on GeForce 8 and up to account for the GPU reordering physical VRAM for some memory types. Signed-off-by: Ben Skeggs bske...@redhat.com --- drivers/gpu/drm/nouveau/nouveau_bo.c | 12 ++- drivers/gpu/drm/nouveau/nouveau_channel.c

Re: question regarding nvc0_instmem_suspend()

2010-08-16 Thread Ben Skeggs
On Fri, 2010-08-13 at 23:59 +0200, Luca Tettamanti wrote: On Fri, Aug 13, 2010 at 11:39 PM, Dan Carpenter erro...@gmail.com wrote: Smatch thinks there is a buffer overflow in nvc0_instmem_suspend() and I've looked at it, but I don't understand the code.

Re: PROBLEM: oops in nouveau driver in 2.6.36-rc*

2010-08-24 Thread Ben Skeggs
On Mon, 2010-08-23 at 17:35 +0200, Stephane Casset wrote: Hi, Hi, Since 2.6.36-rc1 I have an oops when loading the nouveau driver. The system woks ok expect for the nouveau driver and the console gets corrupted :( I attach relevant informations in attached files : o dmesg output for

Re: nouveau/ttm: BUG in ttm_bo_release_list

2010-09-17 Thread Ben Skeggs
On Fri, 2010-09-17 at 19:43 +0200, Marcin Slusarz wrote: Hi Since upgrade from 2.6.35 to 2.6.36-rc3 (nouveau tree) I'm hitting this bug a couple of times a day: [ 2869.618504] [ cut here ] [ 2869.618532] kernel BUG at drivers/gpu/drm/ttm/ttm_bo.c:153! [

Re: idr_remove called for id=0 which is not allocated

2010-09-23 Thread Ben Skeggs
On Wed, 2010-09-22 at 22:56 -0700, Andrew Morton wrote: On Wed, 22 Sep 2010 23:10:10 +0200 Alessandro Guido a...@alessandroguido.name wrote: I have this traces in my logs (full dmesg attached). idr_remove called for id=0 which is not allocated. Pid: 1136, comm: Xorg Not tainted

Re: [PATCH v2 1/1] nouveau: ratelimit IRQ messages

2010-10-04 Thread Ben Skeggs
(git.freedesktop.org/git/nouveau/linux-2.6), I'll push it. Thanks, Ben. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Ben Skeggs bske...@redhat.com Cc: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_irq.c | 23 +-- 1 files changed, 13 insertions

Re: GEM - radeon cs ioctl deadlock

2010-10-13 Thread Ben Skeggs
On Thu, 2010-10-14 at 08:14 +1000, Dave Airlie wrote: On Wed, 2010-10-13 at 17:57 -0400, Jerome Glisse wrote: So we are facing a deadlock with the radeon cs ioctl. When a buffer is given a name (with flink) we could endup with 2 handle pointing to the same object (flink object and open it

Re: [Intel-gfx] [PATCH 1/4] drm/edid: add helper function to detect monitor audio capability

2010-10-19 Thread Ben Skeggs
On Sun, 2010-09-19 at 15:56 +0800, Zhenyu Wang wrote: On 2010.09.19 08:38:07 +0100, Chris Wilson wrote: This should be cc'ed for Adam Jackson's attention as well. yep, I think I cc-ed ajax in git-send-mail command line...I'll amend the commit. +bool drm_detect_monitor_audio(struct

[PATCH 1/2] drm/ttm: ensure ttm_mem_io_free is called on bo destruction

2010-11-03 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Nouveau will start to use ttm_mem_io_reserve to allocate BAR VM space for VRAM mappings, and without this call GPU address space gets leaked. Signed-off-by: Ben Skeggs bske...@redhat.com --- drivers/gpu/drm/ttm/ttm_bo.c |1 + 1 files changed, 1 insertions

[PATCH 2/2] drm/ttm: track kmap io_reserve(), only unreserve on unmap where needed

2010-11-03 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com If the driver kmaps an object userspace is expecting to be mapped, the unmap would have called down into the drivers io_unreserve() function and potentially unmapped the pages from its BARs (for example) and they'd no longer be accessible for the userspace

Re: [PATCH 2/2] drm/ttm: track kmap io_reserve(), only unreserve on unmap where needed

2010-11-08 Thread Ben Skeggs
pointer calls. Thomas, Thanks for that :) It looks good to me, and appears to work as it should. Ben. Patch is only compile-tested /Thomas On 11/04/2010 02:08 PM, Thomas Hellstrom wrote: On 11/04/2010 01:03 AM, Ben Skeggs wrote: From: Ben Skeggsbske...@redhat.com If the driver

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Ben Skeggs
On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: The old code generated an interrupt storm bad enough to completely take down my system. This only fixes the bits that are defined nouveau_regs.h. Newer hardware uses another register that isn't described, and I don't have that

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Ben Skeggs
On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs bske...@redhat.com wrote: On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: The old code generated an interrupt storm bad enough to completely take down my system. This only

Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half

2010-11-10 Thread Ben Skeggs
On Wed, 2010-11-10 at 17:51 -0500, Andrew Lutomirski wrote: On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs bske...@redhat.com wrote: On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs bske...@redhat.com wrote: On Wed, 2010-11-10 at 16:32

Re: [PATCH 0/1][RFC] drm/ttm Improved io_mem_reserve / io_mem_free_calling

2010-11-11 Thread Ben Skeggs
On Thu, 2010-11-11 at 17:50 +0100, Thomas Hellstrom wrote: On 11/11/2010 04:27 PM, Jerome Glisse wrote: On Thu, Nov 11, 2010 at 3:41 AM, Thomas Hellstromthellst...@vmware.com wrote: The following patch is really intended for the next merge window. RFC: 1) Are there any

Re: [PATCH v2 0/2] Fix nouveau-related freezes

2010-11-16 Thread Ben Skeggs
On Tue, 2010-11-16 at 17:19 -0500, Andrew Lutomirski wrote: On Wed, Nov 10, 2010 at 6:04 PM, Andy Lutomirski l...@mit.edu wrote: Nouveau takes down my system quite reliably when any hotplug event occurs. The bug happens because the IRQ handler didn't acknowledge the hotplug state until the

Re: [00/66] 2.6.36.1-stable review

2010-12-07 Thread Ben Skeggs
. Acked-by: Ben Skeggs bske...@redhat.com Can you ack this for 2.6.36, please? I suspect that 2.6.35 needs it as well, but I won't be able to test on my NV50 machine for two weeks (I'll be out of town, and I don't have fancy enough remote control over that box to boot suspected-bad kernels

Re: [PATCH] drm/ttm: delay freeing of old node during move_memcpy until after iounmap

2010-12-09 Thread Ben Skeggs
On Thu, 2010-12-09 at 08:21 +0100, Thomas Hellstrom wrote: On 12/09/2010 03:26 AM, skeg...@gmail.com wrote: From: Ben Skeggsbske...@redhat.com Drivers using their own implementation of io_mem_reserve/io_mem_free are likely to store the tracking information for the map in mem.mm_node, so

Re: smatch: nouveau: bogus compare against zero

2010-12-20 Thread Ben Skeggs
On Mon, 2010-12-20 at 09:48 +0300, Dan Carpenter wrote: Hi Ben, This is a new Smatch warning in linux-next. It comes from: a11c3198c drm/nv50: import new vm code Thanks, fix queued in my tree. Will get to Dave eventually :) Ben. drivers/gpu/drm/nouveau/nv50_vm.c +104 nv50_vm_map(13)

Re: [patch -next] nouveua: sizeof() vs ARRAY_SIZE()

2010-12-20 Thread Ben Skeggs
On Mon, 2010-12-20 at 12:26 +0300, Dan Carpenter wrote: ARRAY_SIZE() was intended here, sizeof() is too large. Thanks, I've queued this patch. Ben. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/gpu/drm/nouveau/nv50_vram.c b/drivers/gpu/drm/nouveau/nv50_vram.c index

Re: [PATCH 08/32] drm/nouveau: use system_wq instead of dev_priv-wq

2011-01-04 Thread Ben Skeggs
On Mon, 2011-01-03 at 14:49 +0100, Tejun Heo wrote: With cmwq, there's no reason for nouveau to use a dedicated workqueue. Drop dev_priv-wq and use system_wq instead. Because nouveau_irq_uninstall() may be called from unsleepable context, the work items can't be flushed from there. Instead,

Re: [PATCH 08/32] drm/nouveau: use system_wq instead of dev_priv-wq

2011-01-04 Thread Ben Skeggs
On Wed, 2011-01-05 at 11:07 +1000, Ben Skeggs wrote: On Mon, 2011-01-03 at 14:49 +0100, Tejun Heo wrote: With cmwq, there's no reason for nouveau to use a dedicated workqueue. Drop dev_priv-wq and use system_wq instead. Because nouveau_irq_uninstall() may be called from unsleepable

Re: Please revert nouveau.

2011-01-16 Thread Ben Skeggs
On Sun, 2011-01-16 at 12:10 -0800, Linus Torvalds wrote: On Sun, Jan 16, 2011 at 12:00 PM, Anca Emanuel anca.eman...@gmail.com wrote: In 2.6.37-git5 with the revert, the boot screen is changing the resolution. With this version, it don't. So, can you make a nice report of that - along

Re: Please revert nouveau.

2011-01-16 Thread Ben Skeggs
On Sun, 2011-01-16 at 15:48 -0800, Linus Torvalds wrote: On Sun, Jan 16, 2011 at 3:44 PM, Ben Skeggs bske...@redhat.com wrote: I've tested a bit here, current git with the revert does appear to work fine for me. So Anca has a 8800GT - is that what you're testing? I don't have an 8800

[PATCH] drm/ttm: call driver move_notify() when doing system-tt bo moves

2011-02-01 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Nouveau doesn't have enough information at ttm_backend_func.bind() time to implement things like tiled GART, or to keep a buffer at a constant address in the GPU virtual address space no matter where in physical memory it's placed. To resolve this, nouveau

Re: [PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv-wq

2011-02-03 Thread Ben Skeggs
On Tue, 2011-02-01 at 11:41 +0100, Tejun Heo wrote: On Wed, Jan 26, 2011 at 05:49:18PM +0100, Tejun Heo wrote: With cmwq, there's no reason for nouveau to use a dedicated workqueue. Drop dev_priv-wq and use system_wq instead. Each work item is sync flushed when the containing structure is

Re: [PATCH 01/11] drm/nouveau: don't munge in drm_mm internals

2011-02-20 Thread Ben Skeggs
On Fri, 2011-02-18 at 17:59 +0100, Daniel Vetter wrote: Nouveau was checking drm_mm internals on teardown to see whether the memory manager was initialized. Hide these internals in a small inline helper function. Cc: Ben Skeggs bske...@redhat.com Signed-off-by: Daniel Vetter daniel.vet

Re: [PATCH] gpu: drm: nouveau: Remove unused variable to prevent compile warning.

2011-02-20 Thread Ben Skeggs
On Sun, 2011-02-20 at 18:58 +0100, Ralf Thielow wrote: Remove unused variable dev_priv in function nv50_vm_map_pgt to prevent compile warning. Thanks for this, however, it has already been fixed in the nouveau tree. Ben. Signed-off-by: Ralf Thielow ralf.thie...@googlemail.com ---

[PATCH] drm/core: add ioctl to query device/driver capabilities

2011-02-20 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com We're coming to see a need to have a set of generic capability checks in the core DRM, in addition to the driver-specific ioctls that already exist. This patch defines an ioctl to do as such, but does not yet define any capabilities. Signed-off-by: Ben Skeggs

[PATCH] Implement drmGetCap() to query device/driver capabilities

2011-02-20 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Signed-off-by: Ben Skeggs bske...@redhat.com --- include/drm/drm.h |7 +++ xf86drm.c |9 + xf86drm.h |1 + 3 files changed, 17 insertions(+), 0 deletions(-) diff --git a/include/drm/drm.h b/include/drm/drm.h index

Re: [git pull] drm fixes

2011-03-25 Thread Ben Skeggs
On 25/03/2011, at 10:55, Jerome Glisse j.gli...@gmail.com wrote: On Thu, Mar 24, 2011 at 8:17 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Thu, Mar 24, 2011 at 5:07 PM, Dave Airlie airl...@gmail.com wrote: Like seriously you really think VFS locking rework wasn't under

Re: Problems caused by commit 6803ed69994a14824081adbf1b58fd21a9966215 to 2.6.38-rc5

2011-04-17 Thread Ben Skeggs
On Sun, 2011-04-17 at 15:40 -0400, Bob Gleitsmann wrote: Good day, night, or whatever, Hey, I've pushed a fix for this (solution 2 that you mentioned) to nouveau's git tree. I'll get it to Dave with the next batch of fixes for .39-rc. Ben. The above mentioned commit which changed the flags

Re: 2.6.39-rc1 nouveau(?) regression (bisected)

2011-04-19 Thread Ben Skeggs
On Tue, 2011-04-19 at 23:47 +0200, Marcin Slusarz wrote: On Mon, Apr 18, 2011 at 01:27:10PM -0700, Linus Torvalds wrote: On Mon, Apr 18, 2011 at 1:02 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: It's some nasty corruption: Looks like something wrote 0x to free'd

Re: [Nouveau] [PATCH] drm/nouveau: release vga_ram allocation before tearing down mm's

2011-05-08 Thread Ben Skeggs
On Sat, 2011-05-07 at 18:03 +0200, Daniel Vetter wrote: Otherwise we have a use-after free. Tested-and-Reported-by: Bruno Prémont bonb...@linux-vserver.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Ah, we actually have a patch in the nouveau git tree fixing this already. I'll get

Re: [PATCH] drm/gem: add hooks to notify driver when object handle is created/destroyed

2011-06-08 Thread Ben Skeggs
On Thu, 2011-06-09 at 10:24 +1000, skeg...@gmail.com wrote: From: Ben Skeggs bske...@redhat.com Nouveau is going to use these hooks to map/unmap objects from a client's private GPU address space. Forgot the v2 notes.. inlined below.. Signed-off-by: Ben Skeggs bske...@redhat.com

Re: [patch] nouveau: free the memory in nouveau_gart_manager_del()

2011-06-25 Thread Ben Skeggs
On Sat, 2011-06-25 at 08:53 +0300, Dan Carpenter wrote: In the original code the kfree() doesn't do anything because mem-mm_node has been set to NULL. This was introduced in d2f9c56a drm/nouveau: create temp vmas for both src and dst of bo moves Already fixed in nouveau git, I'll get the

Re: [patch] nouveau: error paths leak in nvc0_graph_construct_context()

2011-06-25 Thread Ben Skeggs
On Sat, 2011-06-25 at 08:54 +0300, Dan Carpenter wrote: Two of these error paths returned without freeing ctx. Applied to nouveau git, thanks! Ben. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/gpu/drm/nouveau/nvc0_graph.c b/drivers/gpu/drm/nouveau/nvc0_graph.c

Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Ben Skeggs
On Mon, Jul 4, 2011 at 12:39 AM, Marcin Slusarz marcin.slus...@gmail.com wrote: On Sun, Jul 03, 2011 at 01:21:55PM +0200, Jesper Juhl wrote: From: Jesper Juhl j...@chaosbits.net Subject: [PATCH] nouveau: Do not leak in nv20_graph_create If we return due to an unknown chipset in

Re: [PATCH 1/2] drm/nouveau: fixup init/fini sequence to deal with no CRTCs

2011-07-03 Thread Ben Skeggs
On Mon, Jul 4, 2011 at 1:15 PM, skeg...@gmail.com wrote: From: Ben Skeggs bske...@redhat.com Signed-off-by: Ben Skeggs bske...@redhat.com Please ignore this, was a git-send-email accident :) ---  drivers/gpu/drm/nouveau/nouveau_object.c |    4 +-  drivers/gpu/drm/nouveau/nouveau_state.c

Re: [PATCH] drm: make sure drm_vblank_init() has been called before touching vbl_lock

2011-07-06 Thread Ben Skeggs
On Wed, 2011-07-06 at 09:38 +0200, Michel Dänzer wrote: On Mon, 2011-07-04 at 13:16 +1000, skeg...@gmail.com wrote: From: Ben Skeggs bske...@redhat.com Signed-off-by: Ben Skeggs bske...@redhat.com --- drivers/gpu/drm/drm_irq.c | 15 +-- 1 files changed, 9 insertions

Re: [patch] drm/nva3: checking the wrong variable

2011-10-11 Thread Ben Skeggs
On Tue, 2011-10-11 at 17:34 +0300, Dan Carpenter wrote: id is unsigned here and it's never less than zero. I believe the intent was to check the return value from nva3_pm_pll_offset(). Also I've changed it to pass on the -ENOENT error code from the lower levels instead of returning -EINVAL.

Re: [patch] drm/nouveau: testing the wrong variable

2011-10-18 Thread Ben Skeggs
On Tue, 2011-10-18 at 09:07 +0300, Dan Carpenter wrote: memtimings is a valid pointer here, the intent was to test for kcalloc() failure. I've queued it, thanks! Ben. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/gpu/drm/nouveau/nouveau_perf.c

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Ben Skeggs
On Tue, 2011-10-25 at 14:15 +0200, Francisco Jerez wrote: Maarten Maathuis madman2...@gmail.com writes: 2011/10/25 chris wwzbw...@163.com: Can anyone give a suggestion, is wait-vblank fully implemented in page_flip() for nouveau drm driver? It's intentionally not implemented. The

Re: [PATCH 1/2] drm: add plane support v2

2011-11-14 Thread Ben Skeggs
On Mon, 2011-11-14 at 12:21 -0800, Jesse Barnes wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Out of curiosity, lets say you have a *really* stupid hardware overlay that can't do

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

2011-11-18 Thread Ben Skeggs
On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like this change for the following reasons -snip- One can take advantage of move notify

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

2011-11-18 Thread Ben Skeggs
On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

2011-11-19 Thread Ben Skeggs
On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: On 11/19/2011 01:26 AM, Ben Skeggs wrote: On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote

Re: [PATCH] drm/edid: Try harder to fix up broken headers

2011-12-21 Thread Ben Skeggs
On Tue, 2011-12-20 at 15:09 -0500, Adam Jackson wrote: On 12/7/11 6:26 PM, Adam Jackson wrote: There's no reason to force the first byte to be correct if we're already scoring how correct the header is. Don't use this. The 00 check is needed to make sure we only attempt the header fixup

Re: [PATCH] drm/nouveau: fix ttm move notify callback

2012-01-05 Thread Ben Skeggs
On Thu, 2012-01-05 at 13:31 -0500, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com ttm might call the move notify with null new mem placement, properly handle this case inside nouveau move notify callback. This has been fixed already in a -next tree I sent to Dave. Ben.

Re: [PATCH] drm/nouveau: fix ttm move notify callback

2012-01-09 Thread Ben Skeggs
On Fri, 2012-01-06 at 16:00 -0500, Jerome Glisse wrote: On Fri, Jan 06, 2012 at 02:52:49PM -0500, Konrad Rzeszutek Wilk wrote: Still having difficulty to reproduce can you reproduce with the attached printk debuging patch and provide the log (only few printk preceding the oops or

Re: i2c handling in nouveau driver

2012-01-11 Thread Ben Skeggs
On Wed, 2012-01-11 at 11:17 +0100, Jean Delvare wrote: Hi Ben, Hi Jean, I see in commit f553b79c03f0dbd52f6f03abe8233a2bef8cbd0d that you just changed the nouveau driver to use an internal i2c bit-banging implementation instead of i2c-algo-bit. Let me say here publicly that I disapprove

Re: [PATCH] drm/nouveau: Fix module parameter description formats

2012-01-11 Thread Ben Skeggs
...@suse.de Cc: David Airlie airl...@linux.ie Cc: Ben Skeggs bske...@redhat.com --- drivers/gpu/drm/nouveau/nouveau_drv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) (...) David, Ben, can either of you please pick this patch now? It's pretty trivial and has

[PATCH] drm/ttm: fix two regressions since move_notify changes

2012-01-24 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com Both changes in dc97b3409a790d2a21aac6e5cdb99558b5944119 cause serious regressions in the nouveau driver. move_notify() was originally able to presume that bo-mem is the old node, and new_mem is the new node. The above commit moves the call to move_notify

Re: [PATCH] drm/ttm: fix two regressions since move_notify changes

2012-01-25 Thread Ben Skeggs
On Wed, 2012-01-25 at 08:43 +0100, Thomas Hellstrom wrote: On 01/25/2012 06:34 AM, Ben Skeggs wrote: From: Ben Skeggsbske...@redhat.com Both changes in dc97b3409a790d2a21aac6e5cdb99558b5944119 cause serious regressions in the nouveau driver. move_notify() was originally able

Re: [PATCH] drm/ttm: fix two regressions since move_notify changes

2012-01-25 Thread Ben Skeggs
On Wed, 2012-01-25 at 08:24 +, Dave Airlie wrote: On Wed, Jan 25, 2012 at 5:34 AM, Ben Skeggs skeg...@gmail.com wrote: From: Ben Skeggs bske...@redhat.com Both changes in dc97b3409a790d2a21aac6e5cdb99558b5944119 cause serious regressions in the nouveau driver. move_notify

Re: [PATCH] drm/ttm: fix two regressions since move_notify changes

2012-01-25 Thread Ben Skeggs
On Wed, 2012-01-25 at 09:39 +0100, Thomas Hellstrom wrote: On 01/25/2012 09:05 AM, Ben Skeggs wrote: On Wed, 2012-01-25 at 08:43 +0100, Thomas Hellstrom wrote: On 01/25/2012 06:34 AM, Ben Skeggs wrote: From: Ben Skeggsbske...@redhat.com Both changes

Re: [PATCH] drm/ttm: fix two regressions since move_notify changes

2012-01-25 Thread Ben Skeggs
On Wed, 2012-01-25 at 15:33 +0100, Thomas Hellstrom wrote: On 01/25/2012 10:41 AM, Ben Skeggs wrote: My main concern is that we blindly and unnecessarily set up GPU bindings and end up with unnecessary code in TTM, and furthermore that we communicate that bad practice to future driver

Re: [PATCH 2/2] nouveau: implement precise vblank timestamping

2012-02-15 Thread Ben Skeggs
On Wed, 2012-02-15 at 23:55 +0100, Mario Kleiner wrote: From: Lucas Stach d...@lynxeye.de This patch implements the drivers hooks needed for precise vblank timestamping. This is a complementary patch to Mario Kleiner's patches to improve swap scheduling. With the complete patchset applied

Re: Linux 3.4-rc4

2012-04-22 Thread Ben Skeggs
On Sun, 2012-04-22 at 08:26 +0100, Dave Airlie wrote: On Sun, Apr 22, 2012 at 5:51 AM, Linus Torvalds torva...@linux-foundation.org wrote: David co, any ideas? I've been asking Ben about this, I might have to use a bit more pressure, I unfortunately haven't yet had any ideas which could be

Re: [Nouveau] [PATCH 2/5] drm/nouveau: base fence timeout on time of emission

2012-04-23 Thread Ben Skeggs
On Mon, 2012-04-23 at 00:18 +0200, Marcin Slusarz wrote: Wait loop can be interrupted by signal, so if signals are raised periodically (e.g. SIGALRM) this loop may never finish. Use emission time as a base for fence timeout. Ah, thanks for tackling this issue. It's been long on my list of

Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-24 Thread Ben Skeggs
On Tue, 2012-04-24 at 21:31 +0200, Marcin Slusarz wrote: On Mon, Apr 23, 2012 at 06:56:44PM +0200, Martin Peres wrote: Le 23/04/2012 18:32, Marcin Slusarz a écrit : Just run piglit. Even quick tests can cause ~5 lockups (it eventually messes up DDX channel, but this patchset can't

Re: Linux 3.4-rc4

2012-04-24 Thread Ben Skeggs
managed to produce bootable kernels the entire time. The bisection pinpointed the following commit as the culprit: commit a0b25635515ef5049f93b032a1e37f18b16e0f6f Author: Ben Skeggs bske...@redhat.com Date: Mon Nov 21 16:41:48 2011 +1000 drm/nouveau/gpio: reimplement as nouveau_gpio.c

Re: [Nouveau] [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-04-26 Thread Ben Skeggs
On Wed, 2012-04-25 at 23:20 +0200, Marcin Slusarz wrote: Overall idea: Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, handle them at ioctl level, reset the GPU and repeat last ioctl. GPU reset is done by doing suspend / resume cycle with few tweaks: - CPU-only bo

Re: Linux 3.4-rc4

2012-04-26 Thread Ben Skeggs
On Wed, 2012-04-25 at 12:56 +1000, Ben Skeggs wrote: On Tue, 2012-04-24 at 21:35 -0400, Nick Bowler wrote: On 2012-04-23 21:03 -0400, Nick Bowler wrote: On 2012-04-22 22:45 -0400, Konrad Rzeszutek Wilk wrote: On Sun, Apr 22, 2012 at 08:05:54PM -0400, Nick Bowler wrote: Following up

Re: [PATCH] drm/nouveau/hdmi: Fix chipset check for HDMI sound

2012-04-29 Thread Ben Skeggs
On Sun, 2012-04-29 at 20:12 +0200, Alexander Stein wrote: NVIDIA Corporation C77 [GeForce 8300] (rev a2) has chipset 0xaa which supports HDMI Audio. This was fixed in nouveau git already a few days ago:

Re: Linux 3.4-rc4

2012-05-02 Thread Ben Skeggs
too low... As I read the code, it is actually using a 6 us delay. This is fast but reasonable, especially when the code handles clock stretching Ben Skeggs (Cc'd) rewrote the I2C handling code in the nouveau driver completely in kernel 3.3: commit f553b79c03f0dbd52f6f03abe8233a2bef8cbd0d

Re: Linux 3.4-rc4

2012-05-03 Thread Ben Skeggs
On Wed, 2012-05-02 at 21:31 +1000, Ben Skeggs wrote: On Wed, 2012-05-02 at 09:54 +0200, Jean Delvare wrote: Hi Luca, Maarten, On Monday 30 April 2012 01:01:30 pm Luca Tettamanti wrote: On Mon, Apr 30, 2012 at 11:07 AM, Maarten Maathuis madman2...@gmail.com wrote: On Mon, Apr 30

Re: 3.4-rc7 backlight regression on Dell XPS M1710

2012-05-16 Thread Ben Skeggs
Am Mittwoch, den 16.05.2012, 12:17 -0600 schrieb Tim Gardner: commit b99da31ed8521eb78d5d6930f3128f8ecdb75fae causes the backlight in my Dell XPS M1710 to stop working. Symptoms are dim display and won't respond to key brightness events. I bisected and confirmed that reverting this single

Re: 3.4-rc7 backlight regression on Dell XPS M1710

2012-05-17 Thread Ben Skeggs
On Thu, May 17, 2012 at 10:30 AM, Ben Skeggs bske...@redhat.com wrote: Am Mittwoch, den 16.05.2012, 12:17 -0600 schrieb Tim Gardner: commit b99da31ed8521eb78d5d6930f3128f8ecdb75fae causes the backlight in my Dell XPS M1710 to stop working. Symptoms are dim display and won't respond to key

Re: [PATCH] nouveau: nouveau_set_bo_placement takes TTM flags

2012-05-21 Thread Ben Skeggs
On Fri, May 18, 2012 at 03:32:02PM +0100, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This seems to be wrong to me, spotted while thinking about dma-buf. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Ben Skeggs bske...@redhat.com Cc: sta...@vger.kernel.org

[PATCH] drm/nouveau/fbcon: using nv_two_heads is not a good idea

2012-06-25 Thread Ben Skeggs
From: Ben Skeggs bske...@redhat.com nv_two_heads() was never meant to be used outside of pre-nv50 code. The code checks for = NV_10 for 2 CRTCs, then downgrades a few specific chipsets to 1 CRTC based on (pci_device 0x0ff0). The breakage example seen is on GTX 560Ti, with a pciid of 0x1200

Re: [REGRESSION] nouveau: Memory corruption using nva3 engine for 0xaf

2012-07-05 Thread Ben Skeggs
) in the MacBookAir3,1. This patch omits creating the engine for the specific chipset, falling back to M2MF, which kills the symptoms. --- Signed-off-by: Ben Skeggs bske...@redhat.com drivers/gpu/drm/nouveau/nouveau_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau

Re: [Nouveau] [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset

2012-08-04 Thread Ben Skeggs
On Sat, Aug 04, 2012 at 08:00:45AM +0200, Henrik Rydberg wrote: The nva3 copy engine exhibits random memory corruption in at least one case, the GeForce 320M (nv50, 0xaf) in the MacBookAir3,1. This patch omits creating the engine for the specific chipset, falling back to M2MF, which kills the

Re: [bisected] nouveau: Failed to idle channel x after resume

2012-08-08 Thread Ben Skeggs
On Mon, Aug 06, 2012 at 11:38:04PM +0300, Maxim Levitsky wrote: On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote: On Thu, Jul 5, 2012 at 11:24 PM, Martin Nyhus martin.ny...@gmx.com wrote: On Mon, 11 Jun 2012

Re: [bisected] nouveau: Failed to idle channel x after resume

2012-08-08 Thread Ben Skeggs
On Wed, Aug 08, 2012 at 08:00:21AM +0200, Sven Joachim wrote: On 2012-08-08 07:37 +0200, Ben Skeggs wrote: On Mon, Aug 06, 2012 at 11:38:04PM +0300, Maxim Levitsky wrote: On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote

Re: -next queue and EDID stuff

2012-08-27 Thread Ben Skeggs
On Mon, Aug 27, 2012 at 04:24:02PM -0400, Adam Jackson wrote: On 8/23/12 7:50 PM, Dave Airlie wrote: Hi guys (but mainly ajax) I have a bunch of EDID and quirk stuff outstanding, I've made a bundle on patchwork for it https://patchwork.kernel.org/bundle/airlied/edid-review/

Re: [PATCH] drm/nouveau: fix booting with plymouth + dumb support

2012-09-13 Thread Ben Skeggs
On Fri, Sep 14, 2012 at 01:29:55PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com We noticed a plymouth bug on Fedora 18, and I then noticed this stupid thinko, fixing it fixed the problem with plymouth. Signed-off-by: Dave Airlie airl...@redhat.com Signed-off-by: Ben

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Ben Skeggs
On Sun, 2012-10-21 at 00:19 +0200, Marcin Slusarz wrote: On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: On 20.10.2012, Marcin Slusarz wrote: Try this one. It works, now I can boot again. However, nouveau seems to be dead now. The dmesg output with your patch on top

Re: Nouveau regression between 3.6 and 3.7-rc3: driver stuck at running init tables

2012-10-30 Thread Ben Skeggs
On Tue, 2012-10-30 at 00:32 +0100, Mathieu Chouquet-Stringer wrote: Hi again, On Tue, Oct 30, 2012 at 09:15:59AM +1000, Ben Skeggs wrote: Are you able to go back to the current master, and get me a log/screenshot with nouveau.debug=trace appended to your kernel options? Hmmm I

Re: nouveau, linux3.7-rc3: BUG: unable to handle kernel paging request at fffffffffffffff8

2012-10-30 Thread Ben Skeggs
On Mon, 2012-10-29 at 23:16 +0100, Antonio Ospite wrote: Hi, I am experiencing a bug with nouveau with linux-3.7-rc3 (and since rc1), my video adapter is the one integrated on the MSI M3N78-VM motherboard (hence x86_64): 02:00.0 VGA compatible controller: NVIDIA Corporation C77 [GeForce

Re: [PATCH 1/1] drm/nouveau: remove duplicate inclusion of nouveau_ttm.h

2012-11-26 Thread Ben Skeggs
On Tue, 2012-11-27 at 09:04 +0530, Sachin Kamat wrote: ping On 20 November 2012 11:23, Sachin Kamat sachin.ka...@linaro.org wrote: nouveau_ttm.h was included twice. I've queued it in my tree, thanks! Ben. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org ---

Re: [PATCH] nouveau: add support for setting engine on nve0

2013-01-13 Thread Ben Skeggs
On Fri, 2013-01-11 at 16:04 +0100, Maarten Lankhorst wrote: When a specific engine is needed that's not GR, struct nve0_fifo should be used, and the engine member should be used to select the engine. This will fail on kernels before 3.8, since no support for such engines has been added

Re: nouveau, linux3.8-rc5: BUG: unable to handle kernel paging request at fffffffffffffff8

2013-01-26 Thread Ben Skeggs
On Sat, 2013-01-26 at 11:53 +0100, Antonio Ospite wrote: Hi, I am experiencing a bug with nouveau with linux-3.8-rc5, my video adapter is the one integrated on the MSI M3N78-VM motherboard (hence x86_64): 02:00.0 VGA compatible controller: NVIDIA Corporation C77 [GeForce 8200] (rev a2)

Re: [PATCH] drm/nouveau: add lockdep annotations

2013-02-05 Thread Ben Skeggs
On Mon, Feb 04, 2013 at 10:59:28PM +0100, Maarten Lankhorst wrote: Op 04-02-13 22:30, Marcin Slusarz schreef: 1) Lockdep thinks all nouveau subdevs belong to the same class and can be locked in arbitrary order, which is not true (at least in general case). Tell it to distinguish subdevs by

Re: resume fails to light display on Macbook Pro Retina on 3.8-rc1

2013-02-27 Thread Ben Skeggs
On Tue, 2013-02-26 at 20:02 -0800, Greg KH wrote: On Tue, Feb 26, 2013 at 09:35:14AM -0800, Greg KH wrote: On Mon, Feb 25, 2013 at 07:45:45PM -0800, Greg KH wrote: On Mon, Feb 25, 2013 at 02:32:43PM -0800, Greg KH wrote: On Mon, Feb 25, 2013 at 04:06:02PM +1000, Dave Airlie wrote:

Re: [Nouveau] [PATCH v2] drm/nouveau: wait for vblank on page flipping

2013-03-28 Thread Ben Skeggs
On Fri, Mar 29, 2013 at 7:33 AM, Peter Hurley pe...@hurleysoftware.com wrote: On Thu, 2013-03-28 at 16:16 +0100, Maarten Lankhorst wrote: Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- Oops, fixed to apply this time.. diff --git

Re: [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Ben Skeggs
On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Seems to make suspend slightly more reliable on my system. NACK. Seems to, and slightly don't make a very good argument for this. Likely all you've done is change the timing of certain things happening.

Re: [PATCH] drm/nouveau/nv84: Fix HDMI audio regression

2013-05-20 Thread Ben Skeggs
On Mon, 2013-05-20 at 19:14 +0200, Alexander Stein wrote: Code refactoring in commit 8e9e3d2deacc460fbb8a4691140318f6e85e6891 (drm/nv84/disp: move hdmi control into core) disabled HDMI audio on my nv84 by removing too much old code without adding it in the new one. This patch adds the missing

Re: [REGRESSION] system does not resume from ram due to commit drm/nv50/fifo: prevent races between clients updating playlists

2013-06-02 Thread Ben Skeggs
On Fri, May 31, 2013 at 11:05 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Tue, May 28, 2013 at 08:55:29PM +0200, Sven Joachim wrote: On 2013-05-26 23:09 +0200, Maarten Maathuis wrote: My NV96 does not resume from suspend to ram (the screen stays black, magic sysrq keys

Re: [PATCH] nouveau: Load firmware for BSP/VP engines on NV84-NV96, NVA0

2013-06-10 Thread Ben Skeggs
On Wed, Jun 5, 2013 at 5:16 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Jun 5, 2013 at 3:05 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Hey, Op 04-06-13 20:38, Ilia Mirkin schreef: On Mon, Jun 3, 2013 at 5:02 AM, Ilia Mirkin imir...@alum.mit.edu wrote: These

Re: [PATCH] drm/nouveau: perform a bar flush when flushing vm

2013-06-11 Thread Ben Skeggs
On Tue, Jun 11, 2013 at 10:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Appears to fix the regression from drm/nvc0/vm: handle bar tlb flushes internally. nvidia always seems to do this flush after writing values. Thanks, patch applied. Signed-off-by: Maarten Lankhorst

Re: [PATCH] drm/nouveau: remove limit on gart

2013-06-17 Thread Ben Skeggs
On Mon, Jun 17, 2013 at 11:09 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Most graphics cards nowadays have a multiple of this limit as their vram, so limiting GART doesn't seem to make much sense. Pushed, thanks :) Signed-off-by: Maarten Lnkhorst

Re: [PATCH] drm/nouveau: kill nouveau_ttm_fault_reserve_notify handler to prevent useless buffer moves

2013-07-15 Thread Ben Skeggs
On Fri, Jul 12, 2013 at 10:45 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I have no idea what this bogus restriction on placement is, but it breaks decoding 1080p VDPAU at boot speed. With this patch applied I only need to bump the vdec clock to get real-time 1080p

Re: [PATCH 1/3] drm/nouveau: fix vblank interrupt being called before event is setup

2013-07-29 Thread Ben Skeggs
On Tue, Jul 23, 2013 at 11:43 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Sort of fixes mmiotrace for me again, I could sear I sent a similar patch before the rework to event interface, so I guess it got reintroduced. I don't know how/why you think this fixes anything. The

Re: [PATCH 1/3] drm/nouveau: fix vblank interrupt being called before event is setup

2013-07-30 Thread Ben Skeggs
On Tue, Jul 30, 2013 at 4:10 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 30-07-13 04:42, Ben Skeggs schreef: On Tue, Jul 23, 2013 at 11:43 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Sort of fixes mmiotrace for me again, I could sear I sent a similar patch

Re: [Nouveau] [PATCH] drm/nouveau: mark last megabyte as usable

2013-08-11 Thread Ben Skeggs
On Thu, Aug 8, 2013 at 1:24 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: It's my megabyte, I want to use it! At this point in init vbios is copied over already, so there's no reason it cannot used to hold other data now. I believe there's areas in here where the SBIOS/VBIOS can

  1   2   3   4   5   6   7   >