Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

| 5 ++-- > drivers/gpu/drm/arm/hdlcd_crtc.c| 5 ++-- > drivers/gpu/drm/arm/malidp_crtc.c | 5 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 ++-- For atmel-hlcdc: Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com&g

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Thu, 7 Sep 2017 15:06:13 +0530 Archit Taneja <arch...@codeaurora.org> wrote: > Hi, > > On 08/31/2017 09:25 PM, Boris Brezillon wrote: > > Add a driver for Cadence DPI -> DSI bridge. > > > > This driver only support a subset of Cadence DSI bridge

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Tue, 19 Sep 2017 16:38:31 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: >  > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 19/09/17 16:25, Boris Brezillon wrote: > > O

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Tue, 19 Sep 2017 15:59:20 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > Hi Boris, > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 31/08/17 18:55, Boris Brezil

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Wed, 20 Sep 2017 14:55:02 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: > Hi Boris, > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 31/08/17 18:55, Boris Brezil

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Tue, 19 Sep 2017 17:25:29 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: >  > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 19/09/17 16:48, Boris Brezillon wrote: > > O

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Wed, 20 Sep 2017 15:42:50 +0300 Tomi Valkeinen <tomi.valkei...@ti.com> wrote: >  > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 20/09/17 15:32, Boris Brezillon wrote: > > O

Re: [PATCH] drm/gem-cma-helper: Change the level of the allocation failure message

On Thu, 5 Oct 2017 09:48:24 +0100 Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Wednesday, 2017-10-04 22:28:54 +, Eric Anholt wrote: > > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > > > drm_gem_cma_create() prints an err

[PATCH v2] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

they are marked back as unpurgeable, which can be expensive. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hello, Updates to libdrm, mesa and igt making use of this kernel feature can be found on my github repos [1][2][3]. There's currently no debugfs hook to manually

[PATCH] cma: Take __GFP_NOWARN into account in cma_alloc()

cma_alloc() unconditionally prints an INFO message when the CMA allocation fails. Make this message conditional on the non-presence of __GFP_NOWARN in gfp_mask. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hello, This patch aims at removing INFO me

[PATCH] drm/gem-cma-helper: Change the level of the allocation failure message

specifier to make sure all callers are checking the return value. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hello, This problem happens with the VC4 driver which can flush its internal cache if case of CMA allocation failures. We should only complain if the la

Re: [PATCH v2] drm/gem-cma-helper: Change the level of the allocation failure message

On Thu, 5 Oct 2017 13:29:17 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > drm_gem_cma_create() prints an error message when dma_alloc_wc() fails to > allocate the amount of memory we requested. This can lead to annoying > error messages when CMA is only one

[PATCH v2] drm/gem-cma-helper: Change the level of the allocation failure message

drm_gem_cma_create() prints an error message when dma_alloc_wc() fails to allocate the amount of memory we requested. This can lead to annoying error messages when CMA is only one possible source of memory for the BO allocation. Turn this error message into a debug one. Signed-off-by: Boris

[PATCH v3] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

they are marked back as unpurgeable, which can be expensive. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hello, Updates to libdrm, mesa and igt making use of this kernel feature can be found on my github repos [1][2][3]. There's currently no debugfs hook to manually

Re: [PATCH v2] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

the top > half. > > As a solution, use an interrupt thread so that all our writes happen > when sleeping is is allowed. > > v2: Use IRQF_ONESHOT (suggested by Boris) > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-elec

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

Hi Archit, On Thu, 7 Sep 2017 15:06:13 +0530 Archit Taneja wrote: > > > + > > +static void cdns_dsi_bridge_disable(struct drm_bridge *bridge) > > +{ > > + struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge); > > + struct cdns_dsi *dsi =

Re: [PATCH v6 1/5] drm/vc4: Move the DSI clock divider workaround closer to the clock call.

On Tue, 15 Aug 2017 16:47:18 -0700 Eric Anholt <e...@anholt.net> wrote: > We want the adjusted_mode->clock to be the actual clock we're > expecting to program, so that consumers see the right values for clock > and vrefresh. > > Signed-off-by: Eric Anholt <e...@anho

Re: [PATCH v6 2/5] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

padded. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_

Re: [PATCH] drm/vc4: Fix pitch setup for T-format scanout.

u32 tile_h_shift = 5; Maybe you should explain where those _shift values come from in the above comment (tile size is 4K hence tile_size_shift = 12 and a tile is a 32x32 pixels element, hence tile_h_shift = 5). Other than that, Reviewed-by: Boris Brezillon <boris.brezil...@free-elect

Re: [PATCH 06/15] mtd: make device_type const

Le Sat, 19 Aug 2017 13:52:17 +0530, Bhumika Goyal a écrit : > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > Applied to l2-mtd/master. Thanks, Boris > Signed-off-by: Bhumika Goyal

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

On Fri, 01 Sep 2017 09:51:59 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > On 31.08.2017 17:55, Boris Brezillon wrote: > > Add a driver for Cadence DPI -> DSI bridge. > > > > This driver only support a subset of Cadence DSI bridge capabilities. > &g

[PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v3: - replace magic values by real timing calculation. The DPHY PLL clock is still hardcoded since we don't have a working DPHY block yet, and this is the piece of HW we need to dynamically configure the PLL r

[PATCH v3 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

Document the bindings used for the Cadence DSI bridge. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes in v3: - Fix clock names in the example - Document how to represent DSI devices that are controller through an external bus like I2C or SPI Changes

Re: [PATCH v3 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

Hi Andrzej, On Fri, 01 Sep 2017 08:28:13 +0200 Andrzej Hajda <a.ha...@samsung.com> wrote: > On 31.08.2017 17:55, Boris Brezillon wrote: > > Document the bindings used for the Cadence DSI bridge. > > > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.

Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

Hi Eric, On Thu, 31 Aug 2017 10:03:23 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > Add a driver for Cadence DPI -> DSI bridge. > > > > This driver only support a subset of Cadence DSI bri

Re: [PATCH] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

On Thu, 17 Aug 2017 14:04:55 -0700 Eric Anholt wrote: > VC4's DSI1 has a bug where the AXI connection is broken for 32-bit > writes from the CPU, so we use the DMA engine to DMA 32-bit values > into registers instead. That sleeps, so we can't do it from the top > half. > > As

Re: [PATCH v6 3/5] drm/vc4: Set up the DSI host at pdev probe time, not component bind.

by > moving the DSI host creation outside of the component bind loop, and > the panel/bridge lookup/attach into the component bind process. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Boris Brezillon <boris.brezil...@f

[PATCH] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

they are marked back as unpurgeable, which can be expensive. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hello, Updates to libdrm, mesa and igt making use of this kernel feature can be found on my github repos [1][2][3]. There's currently no debugfs hook to manually

Re: [PATCH v3] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

On Tue, 17 Oct 2017 17:16:29 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > This ioctl will allow us to purge inactive userspace buffers when the > > system is running out of contiguous memory. &g

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

Hi Kees, On Sat, 25 Nov 2017 12:57:04 -0800 Kees Cook <keesc...@chromium.org> wrote: > On Wed, Nov 22, 2017 at 11:57 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > > On Wed, Nov 22, 2017 at 07:21:00PM +0100, Boris Brezillon wrote: > >> On Wed, 22 Nov 2017 19:13:09

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

On Wed, 22 Nov 2017 16:13:31 -0800 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > On Wed, 22 Nov 2017 13:16:08 -0800 > > Eric Anholt <e...@anholt.net> wrote: > > > >> Boris Br

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

Hi Stefan, On Wed, 22 Nov 2017 17:43:35 +0100 (CET) Stefan Wahren wrote: > Hi Boris, > if i boot Raspberry Pi 3 (ARM64, defconfig, linux-next-20171122) with > sufficient CMA memory (32 MB), i'll get this warning during boot: > > [7.623510] vc4-drm soc:gpu: bound

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

On Wed, 22 Nov 2017 19:13:09 +0100 Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Nov 22, 2017 at 6:51 PM, Boris Brezillon > <boris.brezil...@free-electrons.com> wrote: > > Hi Stefan, > > > > On Wed, 22 Nov 2017 17:43:35 +0100 (CET) > > St

[PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

ees that the counter does not change between the refcount_inc_not_zero() and refcount_set() calls. Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") Reported-by: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Boris Brezillon <boris.brezil...@free-elect

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

On Wed, 22 Nov 2017 13:16:08 -0800 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > > passed a refcount object that has its co

Re: [PATCH 05/22] drm/atmel-hlcdc: Use drm_fb_cma_fbdev_init/fini()

e to keep track of that. > Also use the drm_fb_helper functions directly. > > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > Signed-off-by: Noralf Trønnes <nor...@tronnes.org> > --- >

[PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields and should be printed with a %zd specifier. Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/gp

Re: [PATCH] drm/vc4: use %z format string for size_t

Hi Arnd, On Thu, 2 Nov 2017 12:20:43 +0100 Arnd Bergmann wrote: > Printing a size_t variable needs to use the %z format string modifier > rather than %l, otherwise we get this warning on 64-bit architectures: > > drivers/gpu/drm/vc4/vc4_bo.c: In function 'vc4_bo_stats_debugfs':

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

On Wed, 1 Nov 2017 10:57:31 +0100 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. Applied to drm-misc-next. > > Fixes: b9f

[PATCH 2/2] drm/vc4: Expose performance counters to userspace

valid on the file descriptor it has been allocated from. A perfmance monitor can be attached to a CL submission and the driver will enable HW counters for this request and update the performance monitor values at the end of the job. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.

[PATCH 0/2] drm/vc4: Expose HW perf counters

to reset the values of a perfmon, just destroy it and create a new one. Note that the first patch is not directly related to perfmon itself, but will allow us to easily extend what is passed to a SUBMIT_CL request without having to add new ioctls. Regards, Boris --- Boris Brezillon (2): drm/vc4

[PATCH 1/2] drm/vc4: Add a mechanism to easily extend CL submissions

The number of attributes/objects you can pass to the DRM_IOCTL_VC4_SUBMIT_CL ioctl is limited by the drm_vc4_submit_cl struct size. Add a mechanism to easily pass extra attributes when submitting a CL to the V3D engine. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

On Thu, 7 Dec 2017 13:31:34 +0100 Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi Daniel, > > > Am 24.11.2017 um 15:52 schrieb Daniel Vetter: > > On Thu, Nov 23, 2017 at 09:24:11AM +0100, Boris Brezillon wrote: > >> On Wed, 22 Nov 2017 16:13:31 -0800

Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails

On Fri, 4 May 2018 16:24:04 +0200 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > On Fri, 4 May 2018 16:20:17 +0200 > Daniel Vetter <dan...@ffwll.ch> wrote: > > > On Fri, May 04, 2018 at 02:17:49PM +0200, Boris Brezillon wrote: > > > On Fri, 4 M

Re: [BUG] drm/vc4: vblank wait timed out

On Sun, 6 May 2018 01:56:36 +0200 (CEST) Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Boris Brezillon <boris.brezil...@bootlin.com> hat am 5. Mai 2018 um 20:00 > > geschrieben: > > > > > > On Sat, 5 May 2018 19:44:57 +0200 (CEST) > &

Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails

On Fri, 4 May 2018 14:29:27 -0500 Rob Herring <robh...@kernel.org> wrote: > On Fri, May 4, 2018 at 9:20 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > > On Fri, May 04, 2018 at 02:17:49PM +0200, Boris Brezillon wrote: > >> On Fri, 4 May 2018 11:47:48 +0200 &g

Re: [BUG] drm/vc4: vblank wait timed out

On Sat, 5 May 2018 13:47:25 +0200 (CEST) Stefan Wahren wrote: > Hi, > > after submit of the latest bcm2835 clock fixes, i thought this issue has been > fixed. But i've seen this issue with current mainline 4.17-rc3 > (bcm2835_defconfig) on Raspberry Pi 1 B (using

[PATCH] drm/vc4: Fix scaling of uni-planar formats

When using uni-planar formats (like RGB), the scaling parameters are stored in plane 0, not plane 1. Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") Cc: sta...@vger.kernel.org Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpu/drm/vc4/vc4_p

Re: [PATCH v2 1/6] drm/tegra: Fix a device_node leak when the DRM panel is not found

On Fri, 4 May 2018 11:50:16 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Thu, May 03, 2018 at 06:40:04PM +0200, Boris Brezillon wrote: > > of_node_put(panel) is not called when of_drm_find_panel(panel) returns > > NULL, thus leaking the reference we hold on

[PATCH 0/3] drm/connector: Provide generic support for underscan

ris Boris Brezillon (3): drm/connector: Add generic underscan properties drm/vc4: Take underscan setup into account when updating planes drm/vc4: Attach underscan props to the HDMI connector drivers/gpu/drm/drm_atomic.c| 12 drivers/gpu/drm/drm_connector.c |

[PATCH 1/3] drm/connector: Add generic underscan properties

the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan properties to its connector through the drm_connector_attach_underscan_properties() helper, and can check/apply the underscan setup based on the drm_connector_state->underscan fields. Signed-off-

[PATCH 2/3] drm/vc4: Take underscan setup into account when updating planes

are ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpu/drm/vc4/vc4_plane.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_pla

[PATCH 3/3] drm/vc4: Attach underscan props to the HDMI connector

,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drive

Re: [PATCH 0/3] drm/connector: Provide generic support for underscan

Hi, On Mon, 7 May 2018 16:44:31 +0200 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > Hello, > > This is an attempt at providing generic support for underscan connector > props. We already have 3 drivers defining the same underscan, underscan > vborder and undersc

Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats

On Mon, 7 May 2018 14:13:03 +0200 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > When using uni-planar formats (like RGB), the scaling parameters are > stored in plane 0, not plane 1. > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > Cc:

Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats

On Mon, 7 May 2018 18:11:02 +0200 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > On Mon, 07 May 2018 08:56:14 -0700 > Eric Anholt <e...@anholt.net> wrote: > > > Boris Brezillon <boris.brezil...@bootlin.com> writes: > > > > > When

Re: [PATCH 3/3] drm/vc4: Attach underscan props to the HDMI connector

On Mon, 7 May 2018 17:24:08 +0200 Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, May 07, 2018 at 04:44:34PM +0200, Boris Brezillon wrote: > > Now that the plane code takes the underscan setup into account, we can > > safely attach the underscan props to the HDMI connector.

[PATCH v3 2/4] drm/panel: Let of_drm_find_panel() return -ENODEV when the panel is disabled

DT nodes might be present in the DT but with a status property set to "disabled" or "fail". In this case, we should not return -EPROBE_DEFER when the caller asks for a drm_panel instance. Return -ENODEV instead. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.co

[PATCH v3 4/4] drm/vc4: Support the case where the DSI device is disabled

SI encoder/connector when it happens. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v3: - None Changes in v2: - New commit --- drivers/gpu/drm/vc4/vc4_dsi.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi

[PATCH v3 1/4] drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL

l)' one. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v3: - Rework error handling in a few drivers as suggested by Thierry - Return -ENODEV when CONFIG_OF or CONFIG_DRM_PANEL are not enabled Changes in v2: - New commit --- drivers/gpu/drm/bridge/cdns-dsi.c

[PATCH v3 3/4] drm/of: Make drm_of_find_panel_or_bridge() fail when the device is disabled

There's no point searching for a drm_bridge or drm_panel if the OF node we're pointing has a status property that is not "okay" or "ok". Just return -ENODEV in this case. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> Reviewed-by: Thierry Reding

[PATCH v3 0/4] drm/panel: Handle the "panel is missing" case properly

2017-November/157688.html [2]https://www.spinics.net/lists/dri-devel/msg174808.html *** BLURB HERE *** Boris Brezillon (4): drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL drm/panel: Let of_drm_find_panel() return -ENODEV when the panel is disabled drm/of: Make dr

[PATCH v2 0/4] drm/connector: Provide generic support for underscan

in the core and add ->underscan fields to drm_connector_state. In this v2, I also converted the nouveau driver to the generic approach. The amdgpu and radeon ones can't be converted since they're still not converted to the atomic interface. Regards, Boris Boris Brezillon (4): drm/connec

[PATCH v2 1/4] drm/connector: Add generic underscan properties

the property parsing logic can be shared by all DRM drivers. A driver can now attach underscan properties to its connector through the drm_connector_attach_underscan_properties() helper, and can check/apply the underscan setup based on the drm_connector_state->underscan fields. Signed-off-

[PATCH v2 4/4] drm/nouveau: Switch to the generic underscan props

Now that underscan props can be parsed by the core and assigned to conn_state->underscan.xxx, we can rely on this implementation and get rid of the nouveau-specific underscan props. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- drivers/gpu/drm/nouveau/nouveau_connect

[PATCH v2 3/4] drm/vc4: Attach underscan props to the HDMI connector

,right,top,bottom} properties defined in config.txt and parsed by the VC4 firmware. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v2: - none --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/g

[PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

are ready to attach underscan properties to the HDMI connector. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Changes in v2: - Take changes on hborder/vborder meaning into account --- drivers/gpu/drm/vc4/vc4_plane.c | 49 - 1 file chang

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

On Fri, 11 May 2018 18:34:50 +0300 Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, May 11, 2018 at 04:59:17PM +0200, Boris Brezillon wrote: > > Applying an underscan setup is just a matter of scaling all planes > > appropriately and adjusting the CRTC

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

On Mon, 7 May 2018 17:25:30 +0200 Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, May 07, 2018 at 05:15:33PM +0200, Daniel Vetter wrote: > > On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > > > We have 3 drivers defining the "u

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

On Tue, 8 May 2018 10:18:10 +1000 Ben Skeggs <skeg...@gmail.com> wrote: > On 8 May 2018 at 04:26, Harry Wentland <harry.wentl...@amd.com> wrote: > > > > > > On 2018-05-07 12:19 PM, Boris Brezillon wrote: > >> On Mon, 7 May 2018 18:01:44 +0300 > &g

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

On Fri, 11 May 2018 19:54:02 +0300 Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, May 11, 2018 at 05:52:56PM +0200, Boris Brezillon wrote: > > On Fri, 11 May 2018 18:34:50 +0300 > > Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > > &g

Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes

On Fri, 11 May 2018 20:29:48 +0300 Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, May 11, 2018 at 07:12:21PM +0200, Boris Brezillon wrote: > > On Fri, 11 May 2018 19:54:02 +0300 > > Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > > &g

Re: [BUG] drm/vc4: vblank wait timed out

On Sat, 5 May 2018 19:44:57 +0200 (CEST) Stefan Wahren wrote: > Hi Stefan, > > > Stefan Schake hat am 5. Mai 2018 um 19:29 > > geschrieben: > > > > > > On Sat, May 5, 2018 at 1:47 PM, Stefan Wahren > > wrote: > > > Hi, >

Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats

On Mon, 07 May 2018 08:56:14 -0700 Eric Anholt <e...@anholt.net> wrote: > Boris Brezillon <boris.brezil...@bootlin.com> writes: > > > When using uni-planar formats (like RGB), the scaling parameters are > > stored in plane 0, not plane 1. > > > >

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

On Mon, 7 May 2018 18:01:44 +0300 Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: > > We have 3 drivers defining the "underscan", "underscan hborder" and > > "underscan vborde

Re: [PATCH v2 5/6] drm/vc4: Support the case where the DSI device is disabled

On Fri, 4 May 2018 12:28:33 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Thu, May 03, 2018 at 06:40:08PM +0200, Boris Brezillon wrote: > > Having a device with a status property != "okay" in the DT is a valid > > use case, and we should not prev

Re: [PATCH v2 5/6] drm/vc4: Support the case where the DSI device is disabled

On Fri, 4 May 2018 12:30:25 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Thu, May 03, 2018 at 06:40:08PM +0200, Boris Brezillon wrote: > > Having a device with a status property != "okay" in the DT is a valid > > use case, and we should not prev

Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails

On Fri, 4 May 2018 11:47:48 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Fri, May 04, 2018 at 10:06:53AM +0200, Boris Brezillon wrote: > > Hi Rob, > > > > On Thu, 3 May 2018 12:12:39 -0500 > > Rob Herring <robh...@kernel.org> wrote: >

Re: [PATCH v2 2/6] drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL

Hi Thierry, On Fri, 4 May 2018 12:18:52 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Thu, May 03, 2018 at 06:40:05PM +0200, Boris Brezillon wrote: > > Right now, the DRM panel logic returns NULL when a panel pointing to > > the passed OF node is no

Re: [PATCH v2 5/6] drm/vc4: Support the case where the DSI device is disabled

On Fri, 4 May 2018 15:29:15 +0200 Thierry Reding <thierry.red...@gmail.com> wrote: > On Fri, May 04, 2018 at 02:05:25PM +0200, Boris Brezillon wrote: > > On Fri, 4 May 2018 12:28:33 +0200 > > Thierry Reding <thierry.red...@gmail.com> wrote: > > > > >

Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails

Hi Rob, On Thu, 3 May 2018 12:12:39 -0500 Rob Herring <robh...@kernel.org> wrote: > On Thu, May 3, 2018 at 11:40 AM, Boris Brezillon > <boris.brezil...@bootlin.com> wrote: > > The device might be described in the device tree but not connected to > > the I2C bus.

Re: [PATCH v2 6/6] drm/panel: rpi-touchscreen: Set status to "fail" when ->probe() fails

On Fri, 4 May 2018 16:20:17 +0200 Daniel Vetter <dan...@ffwll.ch> wrote: > On Fri, May 04, 2018 at 02:17:49PM +0200, Boris Brezillon wrote: > > On Fri, 4 May 2018 11:47:48 +0200 > > Thierry Reding <thierry.red...@gmail.com> wrote: > > > > > On Fr

Re: [PATCH v2] drm/atmel-hlcdc: check stride values in the first plane

On Sun, 17 Jun 2018 10:48:22 +0200 Stefan Agner wrote: > The statement always evaluates to true since the struct fields > are arrays. This has shown up as a warning when compiling with > clang: > warning: address of array 'desc->layout.xstride' will always > evaluate to 'true'

Re: [PATCH] drm/atmel-hlcdc: remove unnecessary if statement

On Sun, 17 Jun 2018 01:34:34 +0200 Stefan Agner wrote: > Boris, Maxime, > > On 07.08.2017 08:26, Stefan Agner wrote: > > The statement always evaluates to true since the struct fields > > are arrays. This has shown up as a warning when compiling with > > clang: > > warning: address of array

Re: [PATCH v2] drm/atmel-hlcdc: check stride values in the first plane

On Sun, 17 Jun 2018 10:48:22 +0200 Stefan Agner wrote: > The statement always evaluates to true since the struct fields > are arrays. This has shown up as a warning when compiling with > clang: > warning: address of array 'desc->layout.xstride' will always > evaluate to 'true'

Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused

+Thierry Hi Arnd, On Fri, 25 May 2018 17:50:15 +0200 Arnd Bergmann wrote: > These two functions are unused in some configurations, and using > __maybe_unused > is the easiest way to shut up the harmless warnings: > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error:

Re: [PATCH v2 7/8] drm/vc4: Add support for the transposer block

Hi Eric, On Fri, 29 Jun 2018 13:35:04 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > From: Boris Brezillon > > > > The transposer block is providing support for mem-to-mem composition, > > which is exposed as a drm_writeback connector in DRM. &

Re: [PATCH v2 0/8] drm/vc4: Add support for the transposer IP

On Fri, 29 Jun 2018 12:40:45 +0100 Liviu Dudau wrote: > On Fri, Jun 29, 2018 at 01:17:22PM +0200, Boris Brezillon wrote: > > Hello, > > > > This is the second version of this series adding writeback support > > to the VC4 display engine. > > > >

Re: [PATCH v2 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit()

On Mon, 2 Jul 2018 12:14:20 +0100 Liviu Dudau wrote: > On Mon, Jul 02, 2018 at 11:49:11AM +0200, Boris Brezillon wrote: > > On Mon, 2 Jul 2018 09:51:46 +0200 > > Daniel Vetter wrote: > > > > > On Fri, Jun 29, 2018 at 12:37:10PM +0100, Liviu Dudau wrote: >

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

On Mon, 2 Jul 2018 09:54:32 +0200 Daniel Vetter wrote: > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > > Now that we have a way to fake VBLANK events when requested by the CRTC > > hook it up to the generic commit_tail() helpers. > > > > Sig

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

On Mon, 2 Jul 2018 09:57:30 +0200 Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 09:54:32AM +0200, Daniel Vetter wrote: > > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > > > Now that we have a way to fake VBLANK events when requested by the CRT

Re: [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events

On Mon, 2 Jul 2018 10:02:52 +0200 Daniel Vetter wrote: > On Fri, Jun 29, 2018 at 01:17:17PM +0200, Boris Brezillon wrote: > > In some cases CRTCs are active but are not able to generating events, at > > least not at every frame at it's expected to. > > This is typically t

Re: [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events

On Mon, 2 Jul 2018 10:40:54 +0200 Daniel Vetter wrote: > > > > > > > + * Note that, even when no_blank is set to true, the CRTC driver > > > > can still > > > > + * steal the _crtc_state.event object and send the event on > > > > its own. > > > > + * That's usually what happens

Re: [PATCH v2 4/8] drm/crtc: Add a generic infrastructure to fake VBLANK events

On Mon, 2 Jul 2018 10:37:22 +0200 Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 10:14:51AM +0200, Boris Brezillon wrote: > > On Mon, 2 Jul 2018 10:02:52 +0200 > > Daniel Vetter wrote: > > > > > On Fri, Jun 29, 2018 at 01:17:17PM +0200, Boris Brezillon wrote:

Re: [PATCH v2 2/8] drm/connector: Pass a drm_connector_state to ->atomic_commit()

On Mon, 2 Jul 2018 09:51:46 +0200 Daniel Vetter wrote: > On Fri, Jun 29, 2018 at 12:37:10PM +0100, Liviu Dudau wrote: > > On Fri, Jun 29, 2018 at 01:17:15PM +0200, Boris Brezillon wrote: > > > Other atomic hooks are passed state objects, let's change this one to &

[PATCH v3 8/9] drm/vc4: Add support for the transposer block

From: Boris Brezillon The transposer block is providing support for mem-to-mem composition, which is exposed as a drm_writeback connector in DRM. Add a driver to support this feature. Signed-off-by: Boris Brezillon --- Changes in v3: - Add Eric's R-b - Fix the code updating ->no_blank

[PATCH v3 7/9] drm/vc4: Call drm_atomic_helper_fake_vblank() in the commit path

Mimic what is done in drm_atomic_commit_tail() and call drm_atomic_helper_fake_vblank() so that VBLANK events are faked when the drm_crtc_state.no_vblank is true. Will be needed when we'll add support for the transposer block. Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt --- Changes

[PATCH v3 5/9] drm/crtc: Add a generic infrastructure to fake VBLANK events

ore drm_atomic_helper_fake_vblank() helper can then be used to fake VBLANKs at commit time. Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Daniel Vetter --- Changes in v3: - Use inline doc for @no_vblank - Fix drm_atomic_helper_fake_vblank() to only check new_crtc_st

[PATCH v3 4/9] drm/vc4: Use wait_for_flip_done() instead of wait_for_vblanks()

the only thing we want to check when calling drm_atomic_helper_wait_for_vblanks() from vc4_atomic_complete_commit() is that new FBs are in use and the old ones can be safely released. Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Eric Anholt --- Changes in v3: - Add Eric's

[PATCH v3 9/9] ARM: dts: bcm283x: Add Transposer block

From: Boris Brezillon The transposer block is allowing one to write the result of the VC4 composition back to memory instead of displaying it on a screen. Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Eric Anholt --- Changes in v3: - Add R-b tags Changes in v2: - None

<    3   4   5   6   7   8   9   10   11   12   >