() which presumably does the right
thing. But the warning is correct that "handle" can be uninitialized
here.
2607 if (out_fence)
2608 *out_fence = fence;
2609 else
2610 vmw_fence_obj_unreference(&f
The of_drm_find_panel() function returns error pointers and never NULL
but we the driver assumes that ->panel is NULL when it's not present.
Fixes: 6afb7721e2a0 ("drm/exynos: move connector creation to attach callback")
Signed-off-by: Dan Carpenter
diff --git a/driv
The msm_gpu_open() function should free "show_priv" on error or it
causes static checker warnings.
Fixes: 4f776f4511c7 ("drm/msm/gpu: Convert the GPU show function to use the GPU
state")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/msm/msm_debugfs.c | 15 +++
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.21-wip
head: 6af94a9d0e185f48bef5cc1372f3ada89d003858
commit: 15296db70619984157e60666da5da8994a66870e [10/27] drm/amdgpu/vcn:Add
ring W/R PTR check for VCN DPG mode stop
smatch warnings:
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1174
}
58 }
59
60 if (div && half) {
61 *div = best_m;
62 *half = is_double;
^^
This is either true or uninitialized.
63 }
64
65
On Mon, Oct 08, 2018 at 12:49:07PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On 08/31/2018 10:09 AM, Dan Carpenter wrote:
> > The "index + count" addition can overflow. Both come directly from the
> > user. This bug leads to an information leak.
> >
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.21-wip
head: 6830ffcb15a5bae3f031734b75b11a5f489a52bf
commit: 6459eb8ee95150ffbdfcd0c9325945be80f98cf8 [113/125] drm/amd/display:
Expand dc to use 16.16 bit backlight
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/d
The nvkm_engine_ref() function returns error pointers, not NULL on
error. I fixed that but I also had to reverse some of the checks so it
didn't become too convoluted.
Fixes: c5c9127b25b2 ("drm/nouveau/device: implement a generic method to query
device-specific properties")
Sig
plane->index);
492
493 layer_state->uses_frontend = true;
494 num_frontend_planes++;
495 } else {
496 layer_state->uses_frontend = false;
497 }
regards,
dan carpenter
_
cec_read() returns a u8 so "val" can't be negative. If there is an
error in cec_read() then it returns zero.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index 6ebd8842dbcc..86e3aee44686 100644
--- a/driv
t; @@ -206,7 +206,7 @@ void intel_guc_fini(struct intel_guc *guc)
> static u32 get_log_control_flags(void)
> {
> u32 level = i915_modparams.guc_log_level;
> - u32 flags = 0;
> + s32 flags = 0;
>
> GEM_BUG_ON(level < 0);
Only insane people use &quo
prime_attach->sgt = sgt;
324 prime_attach->dir = dir;
325 }
326 }
327
328 return sgt;
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
the replacement IS_ERR was one of items.
> >
> > IMHO it is still better to modify those two functions,
> > drm_gem_cma_prime_get_sg_table and xen_drm_front_gem_get_sg_table.
> >
> > Thank you.
> > Best regards YJ
> >
> >
> > On Thu, 14 J
mber of GPUs in the system. The
> maximum number of GPUs supported due to device minor limit in DRM is 128.
>
128 is sort of a magic number. Is there a MAX_GPU define or something?
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-4.15
head: 9556f93f18f7923978fb90f860c107fed9ca7f57
commit: c756d628b20a12f50c43df1cfbe24fd72b5a47b4 [1135/1759] drm/amd/amdgpu:
adapt dgma to the new vam_mgr
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1422 amd
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-4.15
head: 9556f93f18f7923978fb90f860c107fed9ca7f57
commit: 265083076187e619aa9176aeb05ad630013429b4 [1231/1759] drm/amd/display:
Hookup color management functions
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/amdg
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head: 92fb37464bd2b759d74f33c3b90a27575601745d
commit: cb2bd409128cdf4b6ac7779e55876956271be9f3 [201/261] drm/amd/powerplay:
add control gfxoff enabling in late init
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../powerplay/
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head: 92fb37464bd2b759d74f33c3b90a27575601745d
commit: c5eb46b78b52a40bc91421f667130fa7f328e97a [260/261] drm/amd/powerplay:
add specific changes for VEGAM in smu7_hwmgr.c
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../
Hi Kiran,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on backlight/for-backlight-next]
[also build test WARNING on v4.17-rc3 next-20180504]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://git
drm_dev_alloc() returns error pointers, it never returns NULL.
Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c
b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..86
The xen_drm_front_shbuf_alloc() function was returning a mix of error
pointers and NULL and the the caller wasn't checking correctly. I've
changed it to always return error pointer consistently.
Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend"
If the loop times out then we want to exit with "to" set to zero, but in
the current code it's set to -1.
Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/xen/xen_drm_front
se of how we picked args->width that means cpp < UINT_MAX / 4.
Signed-off-by: Dan Carpenter
---
Btw, DIV_ROUND_UP() integer overflows have been a recurring source of
bugs so I have an unreleased static checker warning specific for that.
This line triggers three warnings for me on my unr
X / 8 and
because of how we picked args->width that means cpp < UINT_MAX / 4.
Signed-off-by: Dan Carpenter
---
v2: correct a typo in the commit message
diff --git a/drivers/gpu/drm/drm_dumb_buffers.c
b/drivers/gpu/drm/drm_dumb_buffers.c
index 39ac15ce4702..45b0b5bbb5f8 100644
--- a/driv
On Wed, May 09, 2018 at 09:18:57AM +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2018-05-09 09:12:54)
> > There is a comment here which says that DIV_ROUND_UP() can overflow and
> > that's where the problem comes from. Say you pick:
> >
> >
se of how we picked args->width that means cpp < UINT_MAX / 4.
I've fixed it by preventing the integer overflow in DIV_ROUND_UP(). I
removed the check for !cpp because it's not possible after this change.
I also changed all the 0xU references to U32_MAX.
Signed-off-by: Dan
On Wed, May 16, 2018 at 03:26:07PM +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2018-05-16 15:00:26)
> > There is a comment here which says that DIV_ROUND_UP() and that's where
> > the problem comes from. Say you pick:
> >
> > args->bpp = UINT_M
On Wed, May 16, 2018 at 03:56:55PM +0100, Chris Wilson wrote:
> Quoting Dan Carpenter (2018-05-16 15:52:57)
> > On Wed, May 16, 2018 at 03:26:07PM +0100, Chris Wilson wrote:
> > > Quoting Dan Carpenter (2018-05-16 15:00:26)
> > > > There is a comment here which says
Btw, I've looked at this some more and I'm 99% sure there is no way to
exploit it. The "if (PAGE_ALIGN(size) == 0)" prevents the integer
overflow in __vgem_gem_create() that I was worried about.
regards,
dan carpenter
___
dri-de
ning '(-22)'
drivers/gpu/drm/exynos/exynos_drm_scaler.c
399
400 static inline bool scaler_task_done(u32 val)
401 {
402 return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL;
^^^
403 }
404
_vbios() error: uninitialized symbol 'max_vddc'.
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:1588
vegam_populate_clock_stretcher_data_table() error: uninitialized symbol 'efuse'.
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam
"id" needs to be signed for the error handling to work.
Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 4dfbfc
The v3d_fence_create() only returns error pointers on error. It never
returns NULL.
Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D
V3.x+")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c
index b0
e checks as well in the same patch. Otherwise it breaks
`git bisect`.
(I don't know this code well. But it just feels like it has to be
breaking git bisect just from from glancing at the patches. Perhaps I
have misunderstood).
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
I'm not sure why the code assumes that only the first put_user() needs
an access_ok() check. I have made all the put_user() and get_user()
calls checked.
Signed-off-by: Dan Carpenter
diff --git a/drivers/video/fbdev/sbuslib.c b/drivers/video/fbdev/sbuslib.c
index a436d44f1b7f..90c5133
The "index + count" addition can overflow. Both come directly from the
user. This bug leads to an information leak.
Signed-off-by: Dan Carpenter
---
Btw, commit 250c6c49e3b6 ("fbdev: Fixing arbitrary kernel leak in case
FBIOGETCMAP_SPARC in sbusfb_ioctl_helper().") doesn&
If dma_get_sgtable() fails then we return NULL.
Fix that and it should be good.
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
think we've applied this? Can't you just resend the original?
> I missed this driver, sorry for the noise. Patch is not even compile
> tested.
>
Please put that sort of information under the --- cut off because it
doesn't really belong in the final git log.
>
[ The bot has a bug where it doesn't copy the error messages so I just
guess what the issue is. - dan ]
Hi Ramalingam,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Ramalingam-C/drm-i915-Implement-HDCP2-2/20180627-174219
base: git:/
Hi Ville,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180629-014202
base: git://people.freedesktop.org/~airlied/linux.git drm-next
smatch warnings:
drivers/g
The "mem" buffer has "size" bytes. The ">" should be ">=" to prevent
reading one character beyond the end of the array.
Signed-off-by: Dan Carpenter
---
Not tested.
diff --git a/drivers/video/fbdev/metronomefb.c
b/drivers/video/fbdev/metronomefb.c
If page_offset is == num_pages then we end up reading beyond the end of
obj->pages[].
Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
Signed-off-by: Dan Carpenter
---
Static analysis. Not tested
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vg
If vertex->idx == dma->buf_count then we end up reading one element
beyond the end of the dma->buflist[] array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c
index 576a417690d4..3b378936f575 100644
--- a/drivers/gpu
The ARRAY_SIZE() macro is type size_t. If s6e8aa0_dcs_read() returns a
negative error code, then "ret < ARRAY_SIZE(id)" is false because the
negative error code is type promoted to a high positive value.
Fixes: 02051ca06371 ("drm/panel: add S6E8AA0 driver")
Signed-off-b
ne element beyond the end of the
vgdev->capsets[] array.
Fixes: 62fb7a5e1096 ("virtio-gpu: add 3d/virgl support")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c
b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 020070d483d3..4735bd1c7321 100644
--- a/drivers/gpu/d
The ->info[] array has DAL_IRQ_SOURCES_NUMBER elements so this condition
should be >= instead of > or we could read one element beyond the end of
the array.
Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu
The > should be >= here so that we don't read beyond the end of the
dma->buflist[] array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/savage/savage_state.c
b/drivers/gpu/drm/savage/savage_state.c
index 2db89bed52e8..7559a820bd43 100644
--- a/drivers/gpu/drm/savage/
Smatch complains that "value" can be uninitialized when kstrtol()
returns -ERANGE.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
index 44178b4c3599..08a1ab6b150d 100644
--- a/drivers/gpu/drm/nouveau/nouve
^^
Freed here
288 err_free:
289 kfree(buffer);
^^
Double free
290
291 return ERR_PTR(ret);
292 }
293
regards,
dan carpenter
___
dri-devel mailing list
dri
On Thu, Jul 12, 2018 at 02:58:00PM +0300, Oleksandr Andrushchenko wrote:
> On 06/18/2018 03:32 PM, Oleksandr Andrushchenko wrote:
> > On 06/18/2018 03:29 PM, Dan Carpenter wrote:
> > > On Mon, Jun 18, 2018 at 09:07:09AM +0300, Oleksandr Andrushchenko wrote:
>
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.21
head: 22666cc1481ae3814d9c7718418cc4a3aa7d90c3
commit: eb3dc8978596a045f469f13bb13271a707623ecb [64/142] drm/amd/display: Use
private obj helpers for dm_atomic_state
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/am
failure.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/ati_pcigart.c | 7 ---
drivers/gpu/drm/r128/r128_cce.c | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/ati_pcigart.c b/drivers/gpu/drm/ati_pcigart.c
index 6c4d4b6eba80..2362f07fe1fc 100644
--- a
The drm_mode_create_tile_group() is only called from
drm_parse_tiled_block() and the caller expects it to return a NULL on
error. In other words, this function should match
drm_mode_get_tile_group().
Signed-off-by: Dan Carpenter
---
I sent a version of this patch last year which updated
uninitialized variable warning. Just to spell it out a little more,
the error code won't be printed for "if (ret)" because negatives are a
subset of non-zero.
Of course, if you do it consistently there won't be a warning message.
I never see the consistent subsystems, so I don't know if they exist.
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
omeone then uses and unsigned type the error case would return as
> success while the < 0 would be detected at compile time (or other static
> code checkers).
If the function returns int but ret is an unsigned int and we do
"if (ret)", then ye
We accidentally forgot to set "ret" on this error path so it means we
return NULL instead of an error pointer. The caller checks for NULL and
changes it to an error pointer so it doesn't cause an issue at run time.
Signed-off-by: Dan Carpenter
diff --git a/drivers/dma-buf/udma
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next-pco
head: bbab57a341c90ed6e32de8edf4e89dc5c55cddac
commit: 5c777a51926dd6bbbf82dc5bddd980a408f0f618 [299/339] drm/amdgpu/gmc9:
Adjust GART and AGP location with xgmi offset
smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfx
Hi Lyude,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-legacy-DPMS-changes-with-MST/20180919-203434
base: git://anongit.freedesktop.org/drm-intel for-linux-next
smatch warnings:
drivers/gpu/drm/drm_dp_mst_topology.c:314
The debugfs_create_file() returns error pointers if DEBUGFS isn't
enabled. But here, we know that it is enabled so it returns NULL on
error which could lead to a NULL dereference a few lines later.
Signed-off-by: Dan Carpenter
---
If someone wanted to delete the error handling as well
Why are you resending this? It's because you added some more patches
on the end? Just send those as a new series...
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinf
^^
Unpossible to be an error pointer!
559 struct drm_panel *panel = tcon->panel;
560 struct drm_connector *connector = panel->connector;
561 struct drm_display_info displ
kthread_init_worker(&priv->event_thread[i].worker);
570 priv->event_thread[i].dev = ddev;
571 priv->event_thread[i].thread =
572 kthread_run(kthread_worker_fn,
573 &a
On Mon, Oct 01, 2018 at 12:38:56PM +0300, Dan Carpenter wrote:
> Hello Jeykumar Sankaran,
>
> The patch 25fdd5933e4c: "drm/msm: Add SDM845 DPU support" from Jun
> 27, 2018, leads to the following static checker warning:
>
> drivers/gpu/drm/msm/msm_drv.c:562
We can free "omap_connector" until the end of the function.
Fixes: 949ea2ef3fed ("drm/omap: Don't call HPD registration operations
recursively")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c
b/drivers/gpu/drm/omapdrm/omap_conne
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> should be >= or we are one element beyond the end of the array.
Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/video/fbdev/omap/omapfb_m
tructure to query perf counter")
Signed-off-by: Dan Carpenter
---
Not tested.
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
index 9980d81a26e3..4227a4006c34 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
+++ b/drivers
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> should be >= or we are one element beyond the end of the array.
Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/video/fbdev/omap/omapfb_m
The > should be >= so that we don't read one page beyond the end of the
obj->pages[] array.
Fixes: 559e50fd34d1 ("drm/vkms: Add dumb operations")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index c7e383686
This can't be true.
376 DRM_DEBUG("Not enough free contexts.\n");
377 /* Should this return -EBUSY instead? */
378 return -ENOMEM;
379 }
regards,
dan carpenter
_
The xen_drm_front_gem_get_sg_table() function is supposed to return
error pointer. The current code, would trigger a NULL dereference in
drm_gem_map_dma_buf().
Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by: Dan Carpenter
diff --git a/d
This funciton is only called from drm_gem_map_dma_buf(). It's supposed
to return error pointers on failure and returning a NULL pointer will
lead to a NULL dereference.
Fixes: 78467dc5f70f ("drm/cma: add low-level hook functions to use prime
helpers")
Signed-off-by: Dan Carpenter
ese earlier. After a while these
things all look the same. I once accidentally wrote and sent the same
patch three times without realizing.
Yeah. Please resend a v3.
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.
Oleksandr sent this patch already. Please disregard mine.
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.19-wip
head: 73b1f7132d9ad442b24d70d8769a4642302d6b49
commit: ce7577a2194b58bf7faf303612a24b7cd5210afc [101/128] drm/amdgpu/pp: split
out common smumgr smu9 code
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega1
annel_reply(aux_engine, size,
675 buffer,
reply,
676
&status);
677
678 break;
regards,
dan carpenter
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sam,
I love your patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Sam-Ravnborg/dt-bindings-add-parallel-data-bus-pardata/20180803-090135
smatch warnings:
drivers/gpu/drm/tinydrm/wg160160.c:145 write_buf() warn: right shifting more
than type allows 8 vs 8
We sometimes call i915_vma_unbind() inside the loop and that can free
the vma.
Signed-off-by: Dan Carpenter
---
Static checker stuff. Untested.
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 9b3b5f8..5249735 100644
--- a/drivers/gpu
This often frees the "vma".
144
145 list_del_init(&vma->exec_list);
^^^
Dereference.
146 drm_gem_object_unreference(&vma->obj->base);
147 }
regards,
dan carpenter
We're taking the sizeof() the wrong thing so it doesn't clear the whole
buffer.
Signed-off-by: Dan Carpenter
---
I can't compile this.
diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index 9b794c9..acf6678 100644
--- a/drivers/
n overflow as well, but I think it's still safe because we check
both "num_cmdbufs" and "num_relocs" again in this test.
Signed-off-by: Dan Carpenter
---
This is something I spotted in code review. I can't actually compile
this code. I assume this overflow test
There is a mistake here so it returns PTR_ERR(NULL) which is success
instead of -ENOMEM.
Signed-off-by: Dan Carpenter
---
I can't compile this.
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
index cc80766..6cf41da 100644
--- a/drivers/gpu/host1x/job.c
+++ b/drivers/gpu/h
There is a typo so deadlocks on error instead of unlocking.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 7ae2bfc..276d470 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -552,7 +552,7 @@ fail
pe_from_flags then mem_type can be TTM_PL_PRIV5 (8)
but the bdev->man[] array only has TTM_NUM_MEM_TYPES (8) elements so we
are one space beyond the end of the array.
regards,
dan carpenter
eue, 3 * DRM_HZ,
248 (((cur_irq_sequence =
249 atomic_read(&cur_irq->irq_received)) -
250*sequence) <= (1 << 23)));
251 }
regards,
dan carpenter
On Tue, Aug 20, 2024 at 10:39:09AM -0400, Alex Deucher wrote:
> Otherwise we can fail to drop the software mutex when
> we fail to take the hardware mutex.
>
> Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore")
> Reported-by: Dan Carpenter
>
These tabs were deleted accidentally in commit d07722e1fc74 ("drm/amd/display:
DML2.1 Reintegration for Various Fixes"). Add them back.
Signed-off-by: Dan Carpenter
---
.../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletion
in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202408291101.waf552sw-...@intel.com/
smatch warnings:
drivers/dma-buf/udmabuf.c:467
sure all registers are flushed to hardware */
654 wmb();
655
656 return 0;
657 }
regards,
dan carpenter
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202309060644.uwp5zw4i-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/intel_dp.c:3779 intel_dp_vsc_sdp_pack() warn: was
&& intended here instead of ||?
vim +3779 drivers/gpu/drm/i915
tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202309070814.jygjojzy-...@intel.com/
smatch warnings:
drivers/gpu/drm/drm_gem_shmem_helper.c:733 drm_gem_shmem_fault() error: we
previously assumed 'shmem->pages' could be null
Move the check for "if (IS_ERR(obj))" in front of the call to
i915_gem_object_set_cache_coherency() which dereferences "obj".
Otherwise it will lead to a crash.
Fixes: 43aa755eae2c ("drm/i915/mtl: Update cache coherency setting for context
structure")
Signed-off-b
about this code in v3
but it looks good now. I'm not a DRM dev so I'm not sure my review
counts for much. You should always just assume that if I'm quiet
then I'm happy. :)
regards,
dan carpenter
/20240310/202403101225.7ahejhzj-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes
Thanks!
Acked-by: Dan Carpenter
regards,
dan carpenter
advantage to making this const?
regards,
dan carpenter
aging/fbtft/fb_ssd1351.c | 4 +---
> drivers/staging/fbtft/fbtft-core.c | 5 ++---
Reviewed-by: Dan Carpenter
regards,
dan carpenter
ent/implements/.
regards,
dan carpenter
I was only going to comment on the staging bits but, heck, I reviewed
the whole series.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
as been around for over a year. I don't care about which
> patches go in as long as they remove the dependency on . I saw
> that Dan has already r-b'ed the current patchset, but if you prefer I'll
> adopt yours.
I hadn't seen Sam's patch. It's a little bit more daring, but it's
really nice code and I trust him.
regards,
dan carpenter
801 - 900 of 1506 matches
Mail list logo
