[PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-17 Thread Dmitry Osipenko
by: Matt Merhar # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 352 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegr

Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-18 Thread Dmitry Osipenko
18.03.2021 12:31, Michał Mirosław пишет: >> static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = { >> @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info >> tegra194_dc_soc_info = { >> .has_nvdisplay = true, >> .wgrps = tegra194_dc_wgrps, >> .num_wgrps = ARRAY_SI

Re: [PATCH] drm/tegra: dc: Restore coupling of display controllers

2021-03-19 Thread Dmitry Osipenko
runtime PM was > removed. > > Restore this functionality by reusing the hierarchical host1x client > suspend/resume infrastructure that's similar to runtime PM and which > perfectly fits this use-case. > > Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM&qu

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Dmitry Osipenko
22.03.2021 17:46, Thierry Reding пишет: > On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: >> To avoid false lockdep warnings, give each client lock a different >> lock class, passed from the initialization site by macro. >> >> Signed-off-by: Mikko Perttunen >> --- >> drivers/gpu/

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-22 Thread Dmitry Osipenko
22.03.2021 18:19, Mikko Perttunen пишет: > On 22.3.2021 16.48, Dmitry Osipenko wrote: >> 22.03.2021 17:46, Thierry Reding пишет: >>> On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: >>>> To avoid false lockdep warnings, give each client lock a differen

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-23 Thread Dmitry Osipenko
23.03.2021 13:20, Thierry Reding пишет: > On Mon, Mar 22, 2021 at 07:01:34PM +0300, Dmitry Osipenko wrote: >> 22.03.2021 18:19, Mikko Perttunen пишет: >>> On 22.3.2021 16.48, Dmitry Osipenko wrote: >>>> 22.03.2021 17:46, Thierry Reding пишет: >>>>> On

Re: [PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-03-23 Thread Dmitry Osipenko
23.03.2021 15:30, Thierry Reding пишет: > On Thu, Jan 14, 2021 at 12:34:22PM +0200, Mikko Perttunen wrote: >> On 1/14/21 10:36 AM, Dmitry Osipenko wrote: >>> 13.01.2021 21:56, Mikko Perttunen пишет: >>>> On 1/13/21 8:14 PM, Dmitry Osipenko wrote: >>>>

Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI

2021-03-23 Thread Dmitry Osipenko
23.03.2021 17:43, Mikko Perttunen пишет: >> >> FWIW, I would've been fine with stashing all of this into drm.c as well >> since the rest of the UAPI is in that already. The churn in this patch >> is reasonably small, but it would've been even less if this was just all >> in drm.c. > > I think we s

Re: [PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-03-23 Thread Dmitry Osipenko
23.03.2021 19:44, Thierry Reding пишет: > On Tue, Mar 23, 2021 at 05:00:30PM +0300, Dmitry Osipenko wrote: >> 23.03.2021 15:30, Thierry Reding пишет: >>> On Thu, Jan 14, 2021 at 12:34:22PM +0200, Mikko Perttunen wrote: >>>> On 1/14/21 10:36 AM, Dmitry Osipenko wrote:

Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Dmitry Osipenko
23.03.2021 18:54, Thierry Reding пишет: > @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct drm_plane > *plane, > value = tegra_dc_readl(dc, DC_DISP_BLEND_CURSOR_CONTROL); > value &= ~CURSOR_DST_BLEND_MASK; > value &= ~CURSOR_SRC_BLEND_MASK; > - value |= CUR

Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Dmitry Osipenko
23.03.2021 21:24, Thierry Reding пишет: > On Tue, Mar 23, 2021 at 08:57:42PM +0300, Dmitry Osipenko wrote: >> 23.03.2021 18:54, Thierry Reding пишет: >>> @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct >>> drm_plane *plane, >&g

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 21:21, Thierry Reding пишет: > On Sat, Feb 27, 2021 at 02:19:39PM +0300, Dmitry Osipenko wrote: >> 03.02.2021 14:18, Mikko Perttunen пишет: >> ... >>>> I'll need more time to think about it. >>>> >>> >>> How about someth

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 22:57, Dmitry Osipenko пишет: > 23.03.2021 21:21, Thierry Reding пишет: >> On Sat, Feb 27, 2021 at 02:19:39PM +0300, Dmitry Osipenko wrote: >>> 03.02.2021 14:18, Mikko Perttunen пишет: >>> ... >>>>> I'll need more time to think about it

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
23.03.2021 18:54, Thierry Reding пишет: > From: Thierry Reding > > Clarify when a fixed IOV address can be used and when a buffer has to > be mapped before the IOVA can be used. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/tegra/plane.c | 8 > 1 file changed, 8 insertions

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
24.03.2021 18:02, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: >> 23.03.2021 18:54, Thierry Reding пишет: >>> From: Thierry Reding >>> >>> Clarify when a fixed IOV address can be used and when a buffer has to >&

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
24.03.2021 19:42, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 06:45:30PM +0300, Dmitry Osipenko wrote: >> 24.03.2021 18:02, Thierry Reding пишет: >>> On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: >>>> 23.03.2021 18:54, Thierry Reding пиш

Re: [PATCH v2 05/10] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-26 Thread Dmitry Osipenko
> } > > @@ -982,8 +1020,13 @@ static struct drm_plane > *tegra_dc_cursor_plane_create(struct drm_device *drm, > plane->index = 6; > plane->dc = dc; > > - num_formats = ARRAY_SIZE(tegra_cursor_plane_formats); > - formats = tegra_cursor_plane_formats; > +

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-26 Thread Dmitry Osipenko
26.03.2021 17:54, Mikko Perttunen пишет: > > Lockdep doesn't seem to be liking dev_name() for the name, and I think > allocating a string for this purpose seems a bit overkill, so I'll keep > the lock name as is if there are no objections. What does "liking" mean?

Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client

2021-03-26 Thread Dmitry Osipenko
26.03.2021 22:10, Mikko Perttunen пишет: > On 3/26/21 8:31 PM, Dmitry Osipenko wrote: >> 26.03.2021 17:54, Mikko Perttunen пишет: >>> >>> Lockdep doesn't seem to be liking dev_name() for the name, and I think >>> allocating a string for this purpose seems

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-28 Thread Dmitry Osipenko
26.03.2021 19:37, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 07:50:01PM +0300, Dmitry Osipenko wrote: >> 24.03.2021 19:42, Thierry Reding пишет: >>> On Wed, Mar 24, 2021 at 06:45:30PM +0300, Dmitry Osipenko wrote: >>>> 24.03.2021 18:02, Thierry Reding пишет: &g

[PATCH v1 2/2] drm/tegra: Add back arm_iommu_detach_device()

2021-03-28 Thread Dmitry Osipenko
The case of CONFIG_ARM_DMA_USE_IOMMU=y was found to be broken for DRM driver. Add back the workaround using arm_iommu_detach_device() as a temporary solution. Cc: sta...@vger.kernel.org Fixes: fa6661b7aa0b ("drm/tegra: Optionally attach clients to the IOMMU") Signed-off-by: Dmitr

[PATCH v1 1/2] gpu: host1x: Add back arm_iommu_detach_device()

2021-03-28 Thread Dmitry Osipenko
The case of CONFIG_ARM_DMA_USE_IOMMU=y was found to be broken for host1x driver. Add back the workaround using arm_iommu_detach_device() as a temporary solution. Cc: sta...@vger.kernel.org Fixes: af1cbfb9bf0f ("gpu: host1x: Support DMA mapping of buffers" Signed-off-by: Dmitr

Re: [PATCH v6 04/10] gpu: host1x: Remove cancelled waiters immediately

2021-03-29 Thread Dmitry Osipenko
29.03.2021 16:38, Mikko Perttunen пишет: > Before this patch, cancelled waiters would only be cleaned up > once their threshold value was reached. Make host1x_intr_put_ref > process the cancellation immediately to fix this. > > Signed-off-by: Mikko Perttunen > --- > v6: > * Call schedule instead

Re: [PATCH v6 04/10] gpu: host1x: Remove cancelled waiters immediately

2021-03-29 Thread Dmitry Osipenko
30.03.2021 00:36, Mikko Perttunen пишет: > On 3/29/21 11:27 PM, Dmitry Osipenko wrote: >> 29.03.2021 16:38, Mikko Perttunen пишет: >>> Before this patch, cancelled waiters would only be cleaned up >>> once their threshold value was reached. Make host1x_intr_put_ref &

Re: [PATCH v6 06/10] gpu: host1x: Cleanup and refcounting for syncpoints

2021-03-30 Thread Dmitry Osipenko
a/drivers/staging/media/tegra-video/vi.c > +++ b/drivers/staging/media/tegra-video/vi.c > @@ -1131,8 +1131,8 @@ static void tegra_channel_host1x_syncpts_free(struct > tegra_vi_channel *chan) > int i; > > for (i = 0; i < chan->numgangports; i++) { > - host1x_syncpt_free(chan->mw_ack_sp[i]); > - host1x_syncpt_free(chan->frame_start_sp[i]); > + host1x_syncpt_put(chan->mw_ack_sp[i]); > + host1x_syncpt_put(chan->frame_start_sp[i]); > } > } > > diff --git a/include/linux/host1x.h b/include/linux/host1x.h > index 7137ce0e35d4..107aea29bccb 100644 > --- a/include/linux/host1x.h > +++ b/include/linux/host1x.h > @@ -142,7 +142,9 @@ struct host1x_syncpt_base; > struct host1x_syncpt; > struct host1x; > > -struct host1x_syncpt *host1x_syncpt_get(struct host1x *host, u32 id); > +struct host1x_syncpt *host1x_syncpt_get_by_id(struct host1x *host, u32 id); > +struct host1x_syncpt *host1x_syncpt_get_by_id_noref(struct host1x *host, u32 > id); > +struct host1x_syncpt *host1x_syncpt_get(struct host1x_syncpt *sp); > u32 host1x_syncpt_id(struct host1x_syncpt *sp); > u32 host1x_syncpt_read_min(struct host1x_syncpt *sp); > u32 host1x_syncpt_read_max(struct host1x_syncpt *sp); > @@ -153,7 +155,7 @@ int host1x_syncpt_wait(struct host1x_syncpt *sp, u32 > thresh, long timeout, > u32 *value); > struct host1x_syncpt *host1x_syncpt_request(struct host1x_client *client, > unsigned long flags); > -void host1x_syncpt_free(struct host1x_syncpt *sp); > +void host1x_syncpt_put(struct host1x_syncpt *sp); > struct host1x_syncpt *host1x_syncpt_alloc(struct host1x *host, > unsigned long flags, > const char *name); > @@ -221,7 +223,7 @@ struct host1x_job { > dma_addr_t *reloc_addr_phys; > > /* Sync point id, number of increments and end related to the submit */ > - u32 syncpt_id; > + struct host1x_syncpt *syncpt; > u32 syncpt_incrs; > u32 syncpt_end; > > Tested-by: Dmitry Osipenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 05/10] gpu: host1x: Use HW-equivalent syncpoint expiration check

2021-03-30 Thread Dmitry Osipenko
t; - * > - * If future valueis zero, we have a client managed sync point. In that > - * case we do a direct comparison. > - */ > - if (!host1x_syncpt_client_managed(sp)) > - return future_val - thresh >= current_val - thresh; > -

Re: [PATCH v6 03/10] gpu: host1x: Show number of pending waiters in debugfs

2021-03-30 Thread Dmitry Osipenko
x); > + host1x_debug_output(o, > + "id %u (%s) min %d max %d (%d waiters)\n", > + i, m->syncpt[i].name, min, max, waiters); > } > > for (i = 0; i < host1x_syncpt_nb_bases(m); i++) { > Tested-by: Dmitry Osipenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs

2021-04-02 Thread Dmitry Osipenko
02.04.2021 00:19, Michał Mirosław пишет: > On Fri, Mar 26, 2021 at 04:34:13PM +0200, Mikko Perttunen wrote: >> On 3/23/21 12:16 PM, Thierry Reding wrote: >>> On Mon, Jan 11, 2021 at 03:00:01PM +0200, Mikko Perttunen wrote: Show the number of pending waiters in the debugfs status file. Thi

Re: [PATCH v5 04/21] gpu: host1x: Remove cancelled waiters immediately

2021-01-14 Thread Dmitry Osipenko
13.01.2021 01:20, Mikko Perttunen пишет: > On 1/13/21 12:07 AM, Dmitry Osipenko wrote: >> 11.01.2021 16:00, Mikko Perttunen пишет: >>> -void host1x_intr_put_ref(struct host1x *host, unsigned int id, void >>> *ref) >>> +void host1x_intr_put_ref(struct host1x *

Re: [PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-01-14 Thread Dmitry Osipenko
13.01.2021 21:56, Mikko Perttunen пишет: > On 1/13/21 8:14 PM, Dmitry Osipenko wrote: >> 11.01.2021 16:00, Mikko Perttunen пишет: >>> +struct drm_tegra_submit_buf { >>> +    /** >>> + * @mapping_id: [in] >>> + * >>> +   

Re: [PATCH v5 15/21] drm/tegra: Add new UAPI to header

2021-01-14 Thread Dmitry Osipenko
11.01.2021 16:00, Mikko Perttunen пишет: > +struct drm_tegra_submit_buf { > + /** > + * @mapping_id: [in] > + * > + * Identifier of the mapping to use in the submission. > + */ > + __u32 mapping_id; I'm now in process of trying out the UAPI using grate drivers and this

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-21 Thread Dmitry Osipenko
11.01.2021 15:59, Mikko Perttunen пишет: > Hi all, > > here's the fifth revision of the Host1x/TegraDRM UAPI proposal, > containing primarily small bug fixes. It has also been > rebased on top of recent linux-next. > > vaapi-tegra-driver has been updated to support the new UAPI > as well as Tegra

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:54, Yangtao Li пишет: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. Hello Yangtao, Thank you for y

Re: [PATCH 03/31] opp: Add devres wrapper for dev_pm_opp_set_supported_hw

2021-01-21 Thread Dmitry Osipenko
gt; 2 files changed, 46 insertions(+) Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 04/31] opp: Add devres wrapper for dev_pm_opp_of_add_table

2021-01-21 Thread Dmitry Osipenko
s changed, 42 insertions(+) Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 02/31] opp: Add devres wrapper for dev_pm_opp_set_regulators and dev_pm_opp_put_regulators

2021-01-21 Thread Dmitry Osipenko
e/linux/pm_opp.h | 9 > 2 files changed, 59 insertions(+) Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 24/31] memory: tegra20: convert to use devm_pm_opp_* API

2021-01-21 Thread Dmitry Osipenko
01.01.2021 19:55, Yangtao Li пишет: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra20-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) There are also tegra30-emc.c and tegra124-emc.c with a si

Re: [PATCH v12 4/5] drm/tegra: dc: Support memory bandwidth management

2021-01-26 Thread Dmitry Osipenko
28.12.2020 18:49, Dmitry Osipenko пишет: > Display controller (DC) performs isochronous memory transfers, and thus, > has a requirement for a minimum memory bandwidth that shall be fulfilled, > otherwise framebuffer data can't be fetched fast enough and this results > in a DC'

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-28 Thread Dmitry Osipenko
26.01.2021 05:45, Mikko Perttunen пишет: >> 5. The hardware state of sync points should be reset when sync point is >> requested, not when host1x driver is initialized. > > This may be doable, but I don't think it is critical for this UAPI, so > let's consider it after this series. > > The usersp

Re: [PATCH v5 00/21] sync_file API is not very suitable for DRM

2021-01-28 Thread Dmitry Osipenko
26.01.2021 05:45, Mikko Perttunen пишет: >> 4. Sync file shouldn't be needed for the part of DRM API which doesn't >> interact with external non-DRM devices.  We should use DRM syncobj for >> everything related to DRM, it's a superior API over sync file, it's >> suitable for DRM scheduler. > > Con

Re: [PATCH v5 00/21] support option where all commands are collected into a single,dedicated cmdstream

2021-01-28 Thread Dmitry Osipenko
26.01.2021 05:45, Mikko Perttunen пишет: >> 6. We will need to allocate a host1x BO for a job's cmdstream and add a >> restart command to the end of the job's stream.  CDMA will jump into the >> job's stream from push buffer. >> >> We could add a flag for that to drm_tegra_submit_cmd_gather, saying

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-28 Thread Dmitry Osipenko
28.01.2021 00:57, Mikko Perttunen пишет: > > > On 1/27/21 11:26 PM, Dmitry Osipenko wrote: >> 26.01.2021 05:45, Mikko Perttunen пишет: >>>> 5. The hardware state of sync points should be reset when sync point is >>>> requested, not when host1x driver is

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-01-28 Thread Dmitry Osipenko
26.01.2021 05:45, Mikko Perttunen пишет: >> 2. We will probably need a dedicated drm_tegra_submit_cmd for sync point >> increments.  The job's sync point will be allocated dynamically when job >> is submitted.  We will need a fag for the sync_incr and wait_syncpt >> commands, saying "it's a job's s

Re: [PATCH v5 00/21] sync_file API is not very suitable for DRM

2021-01-28 Thread Dmitry Osipenko
28.01.2021 00:53, Mikko Perttunen пишет: > On 1/27/21 11:35 PM, Dmitry Osipenko wrote: >> 26.01.2021 05:45, Mikko Perttunen пишет: >>>> 4. Sync file shouldn't be needed for the part of DRM API which doesn't >>>> interact with external non-DRM devices.  We

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-01-30 Thread Dmitry Osipenko
28.01.2021 19:58, Thierry Reding пишет: > On Thu, Jan 28, 2021 at 01:08:54PM +0200, Mikko Perttunen wrote: >> On 1/27/21 11:20 PM, Dmitry Osipenko wrote: >>> 26.01.2021 05:45, Mikko Perttunen пишет: >>>>> 2. We will probably need a dedicated drm_tegra_submit_cm

Re: [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs

2021-02-27 Thread Dmitry Osipenko
03.02.2021 14:18, Mikko Perttunen пишет: ... >> I'll need more time to think about it. >> > > How about something like this: > > Turn the syncpt_incr field back into an array of structs like > > #define DRM_TEGRA_SUBMIT_SYNCPT_INCR_REPLACE_SYNCOBJ    (1<<0) > #define DRM_TEGRA_SUBMIT_SYNCPT_

[PATCH v13 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-02 Thread Dmitry Osipenko
series that added ICC support to the memory drivers, but the DRM patches were left out unreviewed and unapplied. Hence I'm re-sending the DRM changes in this new standalone series. Changelog: v13: - No code changes. Patches missed v5.12, re-sending them for v5.13. Dmitry Osipenko (2): drm/

[PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-02 Thread Dmitry Osipenko
by: Matt Merhar # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 349 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegr

[PATCH v13 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-03-02 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by:

[PATCH v1] drm/tegra: dc: Don't set PLL clock to 0Hz

2021-03-02 Thread Dmitry Osipenko
put. Don't touch DC clock if pclk=0 in order to fix the problem. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 1399e4032701..4ecda4cdf345

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-03-02 Thread Dmitry Osipenko
20.01.2021 19:01, Dmitry Osipenko пишет: > 01.01.2021 19:54, Yangtao Li пишет: >> Hi, >> >> This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, >> devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, >> devm_pm_opp_set_supported

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-03-03 Thread Dmitry Osipenko
03.03.2021 07:01, Viresh Kumar пишет: > On 02-03-21, 16:40, Dmitry Osipenko wrote: >> 20.01.2021 19:01, Dmitry Osipenko пишет: >>> 01.01.2021 19:54, Yangtao Li пишет: >>>> Hi, >>>> >>>> This patchset add devm_pm_opp_set_clkname, de

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-04 Thread Dmitry Osipenko
04.03.2021 02:08, Michał Mirosław пишет: > On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: >> Display controller (DC) performs isochronous memory transfers, and thus, >> has a requirement for a minimum memory bandwidth that shall be fulfilled, >> otherwise f

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-08 Thread Dmitry Osipenko
06.03.2021 02:02, Michał Mirosław пишет: > On Fri, Mar 05, 2021 at 12:45:51AM +0300, Dmitry Osipenko wrote: >> 04.03.2021 02:08, Michał Mirosław пишет: >>> On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: >>>> Display controller (DC) performs isochron

[PATCH v14 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
the plane index and fixed out-of-bounds access which happened on T124 due to the cursor plane index. v13: - No code changes. Patches missed v5.12, re-sending them for v5.13. Dmitry Osipenko (2): drm/tegra: dc: Support memory bandwidth management drm/tegra: dc: Extend debug stats

[PATCH v14 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-03-11 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by:

[PATCH v14 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
by: Matt Merhar # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 352 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegr

Re: [PATCH v14 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
11.03.2021 20:06, Dmitry Osipenko пишет: > This series adds memory bandwidth management to the NVIDIA Tegra DRM driver, > which is done using interconnect framework. It fixes display corruption that > happens due to insufficient memory bandwidth. > > Changelog: > > v14: - M

Re: [PATCH v14 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
11.03.2021 20:06, Dmitry Osipenko пишет: > +static const char * const tegra_plane_icc_names[TEGRA_DC_LEGACY_PLANES_NUM] > = { > + "wina", "winb", "winc", "", "", "", "cursor", > +}; > + > +int te

[PATCH v15 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-03-11 Thread Dmitry Osipenko
nding them for v5.13. Dmitry Osipenko (2): drm/tegra: dc: Support memory bandwidth management drm/tegra: dc: Extend debug stats with total number of events drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 362 ++ drivers/gpu/drm/tegra/dc.h|

[PATCH v15 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-03-11 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by:

[PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-11 Thread Dmitry Osipenko
by: Matt Merhar # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 352 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegr

[PATCH v2 00/14] Introduce devm_pm_opp_* API

2021-03-11 Thread Dmitry Osipenko
This series adds resource-managed OPP API helpers and makes drivers to use them. Changelog: v2: - This is a continuation of the work that was started by Yangtao Li. Apparently Yangtao doesn't have time to finish it, so I (Dmitry Osipenko) picked up the effort since these patche

[PATCH v2 01/14] opp: Add devres wrapper for dev_pm_opp_set_clkname

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Add devres wrapper for dev_pm_opp_set_clkname() to simplify drivers code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 36 include/linux/pm_opp.h | 6 ++ 2 files changed, 42 insertions

[PATCH v2 02/14] opp: Add devres wrapper for dev_pm_opp_set_regulators

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Add devres wrapper for dev_pm_opp_set_regulators() to simplify drivers code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 39 +++ include/linux/pm_opp.h | 8 2 files changed, 47 insertions

[PATCH v2 04/14] opp: Add devres wrapper for dev_pm_opp_of_add_table

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Add devres wrapper for dev_pm_opp_of_add_table() to simplify driver code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/opp/of.c | 36 include/linux/pm_opp.h | 6 ++ 2 files changed, 42 insertions

[PATCH v2 03/14] opp: Add devres wrapper for dev_pm_opp_set_supported_hw

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Add devres wrapper for dev_pm_opp_set_supported_hw() to simplify driver code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 38 ++ include/linux/pm_opp.h | 8 2 files changed, 46 insertions

[PATCH v2 05/14] opp: Add devres wrapper for dev_pm_opp_register_notifier

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Add devres wrapper for dev_pm_opp_register_notifier() to simplify driver code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/opp/core.c | 38 ++ include/linux/pm_opp.h | 6 ++ 2 files changed, 44 insertions

[PATCH v2 06/14] serial: qcom_geni_serial: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/tty/serial/qcom_geni_serial.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial

[PATCH v2 07/14] spi: spi-geni-qcom: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Acked-by: Mark brown Signed-off-by: Dmitry Osipenko --- drivers/spi/spi-geni-qcom.c | 17 +++-- include/linux/qcom-geni-se.h | 2 -- 2 files changed, 7 insertions(+), 12 deletions

[PATCH v2 08/14] spi: spi-qcom-qspi: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Acked-by: Mark Brown Signed-off-by: Dmitry Osipenko --- drivers/spi/spi-qcom-qspi.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c

[PATCH v2 09/14] mmc: sdhci-msm: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/mmc/host/sdhci-msm.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host

[PATCH v2 10/14] drm/msm: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm

[PATCH v2 11/14] drm/lima: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/lima/lima_devfreq.c | 43 - drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 11 insertions(+), 34 deletions

[PATCH v2 13/14] media: venus: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Signed-off-by: Dmitry Osipenko --- drivers/media/platform/qcom/venus/pm_helpers.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom

[PATCH v2 12/14] drm/panfrost: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed OPP API to simplify code. Signed-off-by: Yangtao Li Reviewed-by: Steven Price Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 33 + drivers/gpu/drm/panfrost/panfrost_devfreq.h | 1 - 2 files changed

[PATCH v2 14/14] memory: samsung: exynos5422-dmc: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
From: Yangtao Li Use resource-managed API to simplify code. Signed-off-by: Yangtao Li Reviewed-by: Krzysztof Kozlowski Signed-off-by: Dmitry Osipenko --- drivers/memory/samsung/exynos5422-dmc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/memory

Re: [PATCH v2 07/14] spi: spi-geni-qcom: Convert to use resource-managed OPP API

2021-03-11 Thread Dmitry Osipenko
11.03.2021 22:44, Mark Brown пишет: > On Thu, Mar 11, 2021 at 10:20:58PM +0300, Dmitry Osipenko wrote: > >> Acked-by: Mark brown > > Typo there. > Good catch! Although, that should be a patchwork fault since it auto-added acks when I downloaded v1 patches and I haven

Re: [PATCH v2 05/14] opp: Add devres wrapper for dev_pm_opp_register_notifier

2021-03-12 Thread Dmitry Osipenko
12.03.2021 08:26, Viresh Kumar пишет: > On 11-03-21, 22:20, Dmitry Osipenko wrote: >> From: Yangtao Li >> >> Add devres wrapper for dev_pm_opp_register_notifier() to simplify driver >> code. >> >> Signed-off-by: Yangtao Li >> Signed-off-by: Dmitry Osi

Re: [PATCH v2 01/14] opp: Add devres wrapper for dev_pm_opp_set_clkname

2021-03-12 Thread Dmitry Osipenko
12.03.2021 13:36, Ulf Hansson пишет: > On Fri, 12 Mar 2021 at 06:33, Viresh Kumar wrote: >> >> On 11-03-21, 22:20, Dmitry Osipenko wrote: >>> +struct opp_table *devm_pm_opp_set_clkname(struct device *dev, const char >>> *name) >>> +{ >>> +

[PATCH v17 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver

2021-05-10 Thread Dmitry Osipenko
which happened on T124 due to the cursor plane index. v13: - No code changes. Patches missed v5.12, re-sending them for v5.13. Dmitry Osipenko (2): drm/tegra: dc: Support memory bandwidth management drm/tegra: dc: Extend debug stats with total number of events drivers/gpu/drm/tegra/Kconfig |

[PATCH v17 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-05-10 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- driver

[PATCH v17 1/2] drm/tegra: dc: Support memory bandwidth management

2021-05-10 Thread Dmitry Osipenko
by: Matt Merhar # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 352 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegr

Re: [PATCH v10 03/19] memory: tegra30: Support interconnect framework

2020-11-24 Thread Dmitry Osipenko
23.11.2020 09:32, Georgi Djakov пишет: > Hi Dmitry, > > On 23.11.20 2:27, Dmitry Osipenko wrote: >> Now Internal and External memory controllers are memory interconnection >> providers. This allows us to use interconnect API for tuning of memory >> configuration. EMC d

Re: [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-11-24 Thread Dmitry Osipenko
23.11.2020 09:17, Viresh Kumar пишет: > On 23-11-20, 03:27, Dmitry Osipenko wrote: >> This series brings initial support for memory interconnect to Tegra20, >> Tegra30 and Tegra124 SoCs. >> >> For the starter only display controllers and devfreq devices are getting

Re: [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-24 Thread Dmitry Osipenko
23.11.2020 10:02, Chanwoo Choi пишет: > Hi Dmitry, > > On 11/23/20 9:27 AM, Dmitry Osipenko wrote: >> This patch moves ACTMON driver away from generating OPP table by itself, >> transitioning it to use the table which comes from device-tree. This >> change breaks comp

Re: [PATCH v10 01/19] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property

2020-12-01 Thread Dmitry Osipenko
30.11.2020 21:23, Krzysztof Kozlowski пишет: > On Mon, Nov 30, 2020 at 11:48:18AM +0200, Georgi Djakov wrote: >> On 23.11.20 2:27, Dmitry Osipenko wrote: >>> Document opp-supported-hw property, which is not strictly necessary to >>> have on Tegra20, but it's ver

Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees

2020-12-01 Thread Dmitry Osipenko
01.12.2020 00:17, Jon Hunter пишет: > Hi Dmitry, > > On 23/11/2020 00:27, Dmitry Osipenko wrote: >> Add EMC OPP DVFS tables and update board device-trees by removing >> unsupported OPPs. >> >> Signed-off-by: Dmitry Osipenko > This change is generating the

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-02 Thread Dmitry Osipenko
01.12.2020 16:57, Mark Brown пишет: > On Thu, 5 Nov 2020 02:43:57 +0300, Dmitry Osipenko wrote: >> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces >> power consumption and heating of the Tegra chips. Tegra SoC has multiple >> hardware units which b

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-02 Thread Dmitry Osipenko
01.12.2020 17:34, Mark Brown пишет: > On Tue, Dec 01, 2020 at 05:17:20PM +0300, Dmitry Osipenko wrote: >> 01.12.2020 16:57, Mark Brown пишет: > >>> [1/1] regulator: Allow skipping disabled regulators in >>> regulator_check_consumers() >>> (no comm

[PATCH v11 08/10] drm/tegra: dc: Extend debug stats with total number of events

2020-12-04 Thread Dmitry Osipenko
It's useful to know the total number of underflow events and currently the debug stats are getting reset each time CRTC is being disabled. Let's account the overall number of events that doesn't get a reset. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Signed-off-by:

[PATCH v11 09/10] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-12-04 Thread Dmitry Osipenko
Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra30-devfreq.c | 79 +++ 1 file changed, 37 insertions(+), 42 deletions(-) diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 38cc0d014738..145ef91ae092 100644 --- a/drivers/devfreq

[PATCH v11 07/10] drm/tegra: dc: Support memory bandwidth management

2020-12-04 Thread Dmitry Osipenko
Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/Kconfig | 1 + drivers/gpu/drm/tegra/dc.c| 349 ++ drivers/gpu/drm/tegra/dc.h| 14 ++ drivers/gpu/drm/tegra/drm.c | 14 ++ drivers/gpu/drm/tegra/hub.c | 3 + drivers/gpu/drm/tegr

[PATCH v11 02/10] memory: tegra20: Support hardware versioning and clean up OPP table initialization

2020-12-04 Thread Dmitry Osipenko
stead of a raw regulator. This puts Tegra20 EMC OPP preparation on par with the Tegra30/124 EMC drivers. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra20-emc.c | 48 +- 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/drivers/memory/

[PATCH v11 01/10] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property

2020-12-04 Thread Dmitry Osipenko
Document opp-supported-hw property, which is not strictly necessary to have on Tegra20, but it's very convenient to have because all other SoC core devices will use hardware versioning, and thus, it's good to maintain the consistency. Signed-off-by: Dmitry Osipenko --- .../bindi

[PATCH v11 04/10] memory: tegra124-emc: Make driver modular

2020-12-04 Thread Dmitry Osipenko
callbacks. similarly to what is done for the Tegra20/30 EMC drivers. Tested-by: Nicolas Chauvet Signed-off-by: Dmitry Osipenko --- drivers/clk/tegra/Kconfig| 3 ++ drivers/clk/tegra/Makefile | 2 +- drivers/clk/tegra/clk-tegra124-emc.c | 41

[PATCH v11 03/10] memory: tegra30: Support interconnect framework

2020-12-04 Thread Dmitry Osipenko
clients, like a Display client for example. Tested-by: Peter Geis Acked-by: Georgi Djakov Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/Kconfig | 1 + drivers/memory/tegra/tegra30-emc.c | 344 +++-- drivers/memory/tegra/tegra30.c | 173

[PATCH v11 10/10] PM / devfreq: tegra30: Separate configurations per-SoC generation

2020-12-04 Thread Dmitry Osipenko
aggressive boosting. Add a separate ACTMON driver configuration that is specific to Tegra30. Tested-by: Peter Geis Tested-by: Nicolas Chauvet Acked-by: Chanwoo Choi Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra30-devfreq.c | 68 --- 1 file changed, 54 insertions

[PATCH v11 06/10] memory: tegra124: Support interconnect framework

2020-12-04 Thread Dmitry Osipenko
Now Internal and External memory controllers are memory interconnection providers. This allows us to use interconnect API for tuning of memory configuration. EMC driver now supports OPPs and DVFS. Tested-by: Nicolas Chauvet Acked-by: Georgi Djakov Signed-off-by: Dmitry Osipenko --- drivers

[PATCH v11 05/10] memory: tegra124-emc: Continue probing if timings are missing in device-tree

2020-12-04 Thread Dmitry Osipenko
-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra124-emc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index edfbf6d6d357..8fb8c1af25c9 100644 --- a/drivers/memory

<    1   2   3   4   5   6   7   8   9   10   >