[XDC 2012] Conference Update #1

2012-08-05 Thread Egbert Eich
We are still 1 1/2 month into XDC 2012 so it's time to give a status update and beat the drums some more: - Registration Reminder: So far we have 24 registered participants: there's plenty of room for more - so if you haven't done so: register! If you are in need for travel sponsorship

[XDC 2012] Conference Update #2

2012-08-23 Thread Egbert Eich
We are a little less than one month into XDC 2012 so here's some update: Registration: - So far we have 32 registered participants - which is pretty good. If you plan to come and haven't added yourself to the participants list at http://wiki.x.org/wiki/Events/XDC2012/Attendees,

[XDC 2012] Conference Update #3

2012-09-13 Thread Egbert Eich
We are now less than a week into the conference so here's an update with the latest infos: Registration We have close to 50 registered participants now. If you haven't registered yourself please take a minute to go to http://wiki.x.org/wiki/Events/XDC2012/Attendees to put

[XDC 2012] Conference Update #4

2012-09-17 Thread Egbert Eich
Hi Folks! This is just a quick update regarding some last minute stuff that came to our minds: Attendees List == If you haven't added yourself to the attendees list, please take a second to add yourself to http://wiki.x.org/wiki/Events/XDC2012/Attendees. If you want you can

[XDC 2012] Conference Update #5

2012-09-17 Thread Egbert Eich
Just a very brief update: Conference Warm-Up == All of those who are in Nuernberg Tuesday evening already: we've reserved some tables at Barfüßer, Das kleine Brauhaus Hallplatz 2, 90402 Nürnberg (For map please check: http://goo.gl/maps/QXBZB) for 19:00 (ie

[PATCH] DRM/KMS: Add Bail-Out Conditions for Loop.

2012-10-13 Thread Egbert Eich
this function prints out debugging information over a slow (ie serial) line. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_irq.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 3a3d0ce..580cdeb

[PATCH] drm/radeon: Don't destroy I2C Bus Rec in radeon_ext_tmds_enc_destroy().

2012-10-15 Thread Egbert Eich
free resulting in a kernel panic when unloading the radeon driver. Removing destroy code from radeon_ext_tmds_enc_destroy() fixes this problem. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c |5 + 1 files changed, 1 insertions(+), 4 deletions

[PATCH] DRM/Radeon: Fix TV DAC Load Detection for single CRTC chips.

2012-10-24 Thread Egbert Eich
TV DAC load detection did not take into account that there are chips with a single CRTC when attempted to enable the 2nd CRTC. This fix adds support for single CRTC chips and cleans up handling of different chipset generations. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/radeon

[PATCH] DRM/Radeon: Fix Load Detection on legacy primary DAC.

2012-10-24 Thread Egbert Eich
An uninitialized variable led to broken load detection. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon

[PATCH] DRM/Radeon: Fix primary DAC Load Detection for RV100 chips.

2012-10-24 Thread Egbert Eich
For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value works better on ES1000 (RV100) chips, too, as it doesn't produce any false positives on any cards I have tested. Therefore let's assume that this value is good for all RV100 and RV200 chipset generations. Signed-off-by: Egbert

[PATCH] DRM/Radeon: Set depth on low mem Radeon cards to 16 instead of 8.

2012-10-24 Thread Egbert Eich
to 16 when memory is 24MB or lower and to 8 only if 8MB or less VRAM is found. This should be a reasonable compromise for us. This patch will most likely not ever make it upstream. This works around ugly modes on crappy IPMI cards using ES1000. Signed-off-by: Egbert Eich e...@suse.de --- drivers

Re: [PATCH] DRM/Radeon: Set depth on low mem Radeon cards to 16 instead of 8.

2012-10-25 Thread Egbert Eich
Dave Airlie writes: On Thu, Oct 25, 2012 at 3:07 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Oct 24, 2012 at 12:33 PM, Egbert Eich e...@suse.de wrote: The Radeon driver reduces the framebuffer resolution to 8bpp if a device with less than 32 Mb VRAM is found. This causes

[PATCH 0/3] DRM/radeon: Clean up and fix Load Detection on the TV DAC for single CRTC GPUs.

2012-10-29 Thread Egbert Eich
DAC on those GPUs and adds code to handle R200 GPUs. This basically separates the different items in: DRM/Radeon: Fix TV DAC Load Detection for single CRTC chips. Egbert Eich (3): DRM/Radeon: Clean up code in TV DAC load detection. DRM/Radeon: Add Handling for R200 to TV DAC Load Detection

[PATCH 1/3] DRM/Radeon: Clean up code in TV DAC load detection.

2012-10-29 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c index a13ad9d

[PATCH 3/3] DRM/Radeon: Fix TV DAC Load Detection for single CRTC chips.

2012-10-29 Thread Egbert Eich
The RN50 has a TV DAC but only a single CRTC. For load detection this DAC is controlled by the primary CRTC. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 80 +- 1 files changed, 47 insertions(+), 33 deletions(-) diff --git

[PATCH] DRM/radeon: For single CRTC GPUs move handling of CRTC_CRT_ON to crtc_dpms().

2012-10-29 Thread Egbert Eich
. Therefore we set it here. This avoids an elaborate on/off state tracking since both primary_dac_dpms() and tv_dac_dpms() functions would have to touch this bit. On single CRTC GPUs with just one DAC it's irrelevant where this bit is handled. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu

Re: [PATCH] drm/radeon: add load detection support for ext DAC on R200 (v2)

2012-10-31 Thread Egbert Eich
alexdeuc...@gmail.com writes: From: Alex Deucher alexander.deuc...@amd.com The R200 asics use an external DAC for the secondary DAC. The current KMS code tries to use code for the integrated TV DAC for R200 which leads to unpredictable results since R200 does not have an integrated TV

[PATCH 03/17] DRM/KMS/EDID: Return Base EDID block if reading EEDID Blocks fails.

2012-11-19 Thread Egbert Eich
If I2C readout fails for an extension block but we have read a valid base block, don't fail completely but at least return the base block. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 01/17] DRM/KMS/EDID: Mask out Segment Bits when calculating Offset.

2012-11-19 Thread Egbert Eich
This patch is a bit cosmetic as the variable size will truncate the start address anyway but for readability it should be made explicite that the lowest bit in the EDID block number determines the I2C start address. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c |2

[PATCH 00/17] DRM/KMS/EDID: Various EDID handling related fixes.

2012-11-19 Thread Egbert Eich
it for those errors which have been seen also on the previous DDC read cycle. 6. Move EDID-related functions to drm_edid.h The handling of EDID related DRM functions seemed to be a bit arbitrary: although drm_edid.h had been created, new functions were often added to drm_crtc.h Egbert Eich (17

[PATCH 04/17] DRM/KMS/EDID: Test EDDC if EDID announces more than one Extension Block.

2012-11-19 Thread Egbert Eich
address is not taken into account, this block will be identical to the base block in which case we stop reading further EEDID blocks, correct the extension flag and just return the base block. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c | 13 + 1 files changed

[PATCH 06/17] DRM/exynos: Fix Memory Leak: free EDID blcok returned by drm_get_edid().

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2c115f8..bc87bca 100644 --- a/drivers/gpu/drm/exynos

[PATCH 05/17] DRM/KMS/EDID: Fix up EEDID Map Blocks if Extension block count has changed.

2012-11-19 Thread Egbert Eich
as this is less time consuming. For v1.3 we scrap any exsisting map blocks and recreate them from scratch. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c | 105 +-- 1 files changed, 100 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 07/17] DRM/KMS/EDID: Move drm_edid_load.o to drm.ko

2012-11-19 Thread Egbert Eich
. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 2ff5cef..76ca269 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -16,11

[PATCH 09/17] DRM/KMS/EDID: Feed 'firmware' supplied EDID blocks whenever the EDID is read.

2012-11-19 Thread Egbert Eich
for detecting the presence of a device thru EDID). Also it does so not on the helper level any more, the possibility for EDID loading now happens on the DRM KMS core level. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_crtc_helper.c |6 +- drivers/gpu/drm/drm_edid.c|7

[PATCH 08/17] DRM/KMS/EDID: Use Extension Block Fixup Code also for 'firmware' EDID.

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c | 77 --- drivers/gpu/drm/drm_edid_load.c | 54 ++- include/drm/drm_edid.h |1 + 3 files changed, 77 insertions(+), 55 deletions(-) diff --git

[PATCH 11/17] DRM/KMS/EDID: Avoid failing on krealloc on EDID blocks.

2012-11-19 Thread Egbert Eich
is larger than one page and the kernel is not able to find consecutive pages to allocate. In this case it is still better to return what we already have (in most cases the base block) and correct the extension block flag and the checksum accordingly than to fail completely. Signed-off-by: Egbert

[PATCH 10/17] DRM/KMS/EDID: Cache EDID blobs with extensions.

2012-11-19 Thread Egbert Eich
consuming a considerable amount on CPU time for just that. This patch caches the EDID block if it contains at least one extension. To determine if the blocks match we only tranfer the base block, on a match we use the cached data. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_crtc.c

[PATCH 12/17] DRM/KMS/EDID: Consolidate EDID Error Handling.

2012-11-19 Thread Egbert Eich
the monitor is changed but still prevents permanent EDID errors from piling up the the kernel logs. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid.c | 101 +--- drivers/gpu/drm/radeon/radeon_connectors.c |2 +- include/drm/drm_crtc.h

[PATCH 13/17] DRM/KMS/EDID: Allow for multiple Connectors when specifying 'firmware'-EDID Files.

2012-11-19 Thread Egbert Eich
the different connector sections. The option now looks like this: edid_firmware=[connector_0:]edid_file_0[;connector_n:edid_file_1]... Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/drm_edid_load.c | 45 ++ 1 files changed, 31 insertions(+), 14

[PATCH 14/17] DRM/KMS/ast: Include drm_edid.h in file using drm_get_edid().

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/ast/ast_mode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 7fc9f72..c27aa8d 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu

[PATCH 15/17] DRM/KMS/gma500: Include drm_edid.h in file using drm_get_edid().

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/gma500/cdv_intel_dp.c|1 + drivers/gpu/drm/gma500/oaktrail_lvds.c |1 + drivers/gpu/drm/gma500/psb_intel_modes.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c

[PATCH 17/17] DRM/KMS/EDID: Move EDID related Functions to drm_edid.h.

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- include/drm/drm_crtc.h |8 include/drm/drm_edid.h |9 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 171aa33..06254bc 100644 --- a/include/drm/drm_crtc.h

[PATCH 16/17] DRM/KMS/mgag200: Include drm_edid.h in file using drm_get_edid().

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_mode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index d3d99a2..f89a0c1 100644 --- a/drivers/gpu/drm/mgag200

[PATCH] drm/exynos: fix memory leak: free EDID block

2012-11-20 Thread Egbert Eich
drm_get_edid() returns a pointer to an EDID block. The caller is responsible to free this pointer itself. Here the pointer gets assigned to the local variable raw_edid. Therefore it should be freed before the variable goes out of scope. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm

Re: [PATCH] drm/exynos: fix memory leak: free EDID block

2012-11-20 Thread Egbert Eich
Sean Paul writes: On Tue, Nov 20, 2012 at 4:30 AM, Egbert Eich e...@suse.de wrote: drm_get_edid() returns a pointer to an EDID block. The caller is responsible to free this pointer itself. Here the pointer gets assigned to the local variable raw_edid. Therefore it should be freed

[PATCH v2 00/18] DRM/KMS/EDID: Various EDID handling related fixes.

2012-11-22 Thread Egbert Eich
The patches have been reordered and the changes suggested by Takashi Iwai have been worked in. Egbert Eich (18): 1. Make error handling of EDID extension blocks a bit more fault tolorant: * Don't fail when EDID extension blocks cannot be read or memory cannot be allocated. * Don't

[PATCH v2 04/18] DRM/KMS/EDID: Don't fail when failing to allocate memory for EDID extensions.

2012-11-22 Thread Egbert Eich
When we fail to allocate space for EDID extensions we should just warn, fix up the EDID block count and return the base block instead of failing. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v2 05/18] DRM/KMS/EDID: Test EDDC if EDID announces more than one Extension Block (v2)

2012-11-22 Thread Egbert Eich
address is not taken into account, this block will be identical to the base block in which case we stop reading further EEDID blocks, correct the extension flag and just return the base block. v2: Split up EDID fixup code into separate commit. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu

[PATCH v2 08/18] DRM/KMS/EDID: Fix up EEDID Map Blogs if Extension Block Count has changed (v2)

2012-11-22 Thread Egbert Eich
as this is less time consuming. For v1.3 we scrap any exsisting map blocks and recreate them from scratch. v2: Fixed conflits due to reordering of commits. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 89 1 files changed, 89

[PATCH v2 07/18] DRM/KMS/EDID: Don't reallocate EDID blob when size has shrunk.

2012-11-22 Thread Egbert Eich
the same block. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index da2f7fa..0fe61fb 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu

[PATCH v2 15/18] DRM/KMS/ast: Include drm_edid.h in file using drm_get_edid().

2012-11-22 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/ast/ast_mode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 7fc9f72..c27aa8d 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu

[PATCH v2 14/18] DRM/KMS/EDID: Consolidate EDID Error Handling (v2)

2012-11-22 Thread Egbert Eich
the monitor is changed but still prevents permanent EDID errors from piling up the the kernel logs. v2: Fixed conflits due to reordering of commits. Set error state where missing. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 115

[PATCH v2 17/18] DRM/KMS/mgag200: Include drm_edid.h in file using drm_get_edid().

2012-11-22 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_mode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index d3d99a2..f89a0c1 100644 --- a/drivers/gpu/drm/mgag200

[PATCH v2 16/18] DRM/KMS/gma500: Include drm_edid.h in file using drm_get_edid().

2012-11-22 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/gma500/cdv_intel_dp.c|1 + drivers/gpu/drm/gma500/oaktrail_lvds.c |1 + drivers/gpu/drm/gma500/psb_intel_modes.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH v2 09/18] DRM/KMS/EDID: Move drm_edid_load.o to drm.ko (v2)

2012-11-22 Thread Egbert Eich
. v2: a. Also adapt Kconfig b. Add missing 'select FW_LOADER' Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/Kconfig |3 ++- drivers/gpu/drm/Makefile |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig

[PATCH v2 02/18] DRM/KMS/EDID: 0x7e - EDID_EXTENSION_FLAG_OFFSET (v2)

2012-11-22 Thread Egbert Eich
v2: Use offsetof(). Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 049fa52..9e64069 100644 --- a/drivers/gpu/drm

[PATCH v2 13/18] DRM/KMS/EDID: Cache EDID blobs with extensions (v2)

2012-11-22 Thread Egbert Eich
when reading a 'firmware'-supplied EDID or on error. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_crtc.c |1 + drivers/gpu/drm/drm_edid.c | 57 +-- include/drm/drm_crtc.h |1 + include/drm/drm_edid.h |1 + 4 files

[PATCH v2 11/18] DRM/KMS/EDID: Allow for multiple Connectors when specifying 'firmware'-EDID Files (v2)

2012-11-22 Thread Egbert Eich
the different connector sections. The option now looks like this: edid_firmware=[connector_0:]edid_file_0[;connector_n:edid_file_1]... v2: Check for edidname != NULL before entering loop. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid_load.c | 45

[PATCH v2 18/18] DRM/KMS/EDID: Move EDID related Functions to drm_edid.h.

2012-11-22 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.com --- include/drm/drm_crtc.h |8 include/drm/drm_edid.h |9 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index d402b3b..7eed9bd 100644 --- a/include/drm/drm_crtc.h

[PATCH v2 01/18] DRM/KMS/EDID: Mask out Segment Bits when calculating Offset.

2012-11-22 Thread Egbert Eich
This patch is a bit cosmetic as the variable size will truncate the start address anyway but for readability it should be made explicite that the lowest bit in the EDID block number determines the I2C start address. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c |2

[PATCH v2 10/18] DRM/KMS/EDID: Feed 'firmware' supplied EDID blocks whenever the EDID is read (v2)

2012-11-22 Thread Egbert Eich
for detecting the presence of a device thru EDID). Also it does so not on the helper level any more, the possibility for EDID loading now happens on the DRM KMS core level. v2: Fixed formatting and conflicts due to reordering of commits. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm

[PATCH v2 03/18] DRM/KMS/EDID: Return Base EDID block if reading EEDID Blocks fails (v2)

2012-11-22 Thread Egbert Eich
If I2C readout fails for an extension block but we have read a valid base block, don't fail completely but at least return the base block. v2: Make goto target names more telling. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c |7 +-- 1 files changed, 5

[PATCH v2 12/18] DRM/KMS/EDID: Use Extension Block Fixup Code also for 'firmware' EDID (v2)

2012-11-22 Thread Egbert Eich
-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 64 +++ drivers/gpu/drm/drm_edid_load.c | 54 +++- include/drm/drm_edid.h |1 + 3 files changed, 71 insertions(+), 48 deletions(-) diff --git a/drivers

Re: [PATCH v2 05/18] DRM/KMS/EDID: Test EDDC if EDID announces more than one Extension Block (v2)

2012-11-22 Thread Egbert Eich
Ville Syrj?l? writes: Me neither. I just figured it might reduce the chance of false positives. But if you say that can't happen, I'll take your word for it. Regarding memcmp() you are definitely right, I will change the code. Also the comment is somehow misleading.

Re: [PATCH v2 13/18] DRM/KMS/EDID: Cache EDID blobs with extensions (v2)

2012-11-22 Thread Egbert Eich
Ville Syrj?l? writes: On Thu, Nov 22, 2012 at 05:23:03AM -0500, Egbert Eich wrote: - /* if there's no extensions, we're done */ + /* if there are no extensions, we're done - don't bother caching */ if (block[EDID_EXTENSION_FLAG_OFFSET] == 0) return block

[PATCH v3] DRM/KMS/EDID: Test EDDC if EDID announces more than one Extension Block (v3)

2012-11-22 Thread Egbert Eich
...@linux.intel.com: Reworded comment, Used memcmp(), Compared entire base block instead of signature only. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3] DRM/KMS/EDID: Cache EDID blobs with extensions (v3)

2012-11-22 Thread Egbert Eich
when reading a 'firmware'-supplied EDID or on error. V3: Uncache when only one extension block is found. This chunk had accidentally gone into the next patch of the series. Found by Ville Syrjälä ville.syrj...@linux.intel.com. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm

[PATCH v3] DRM/KMS/EDID: Consolidate EDID Error Handling (v3)

2012-11-22 Thread Egbert Eich
the monitor is changed but still prevents permanent EDID errors from piling up the the kernel logs. v2: Fixed conflits due to reordering of commits. Set error state where missing. v3: Don't update cache when returning block from cache. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm

Re: [PATCH v3] DRM/KMS/EDID: Consolidate EDID Error Handling (v3)

2012-11-22 Thread Egbert Eich
Ville Syrj?l? writes: diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index dd0df60..aa9b34d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -157,6 +157,17 @@ int drm_edid_header_is_valid(const u8 *raw_edid) }

[PATCH v4] DRM/KMS/EDID: Consolidate EDID Error Handling (v4)

2012-11-22 Thread Egbert Eich
. Included results of extension block checking in the overall error state. Removed drm_edid_block_valid() as there is noone using it. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 136 drivers/gpu/drm/radeon

[PATCH v4] DRM/KMS/EDID: Move EDID related Functions to drm_edid.h (v2)

2012-11-22 Thread Egbert Eich
v2: Adjusted to apply cleanly. Signed-off-by: Egbert Eich e...@suse.com --- include/drm/drm_crtc.h |8 include/drm/drm_edid.h |9 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 7a3ccbf..7eed9bd

Re: [PATCH v3] DRM/KMS/EDID: Consolidate EDID Error Handling (v3)

2012-11-22 Thread Egbert Eich
Ville Syrj?l? writes: On Thu, Nov 22, 2012 at 07:28:44PM +0100, Egbert Eich wrote: Something similar should be done for drm_edid_is_valid() - even if the driver doesn't bother (for instance because this function is only called once when the device structures are initialized

[PATCH v5] DRM/KMS/EDID: Consolidate EDID Error Handling (v5)

2012-11-22 Thread Egbert Eich
drm_edid_is_valid() to return the actual error state. Included results of extension block checking in the overall error state. Removed drm_edid_block_valid() as there is noone using it. v5: Added missing radeon/radeon_combios.c. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm

[PATCH] drm/edid: Don't print messages regarding stereo or csync by default

2013-06-13 Thread Egbert Eich
debugging is enabled. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e8d17ee..2dc1a60 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers

[PATCH 00/16] drm/mgag200: Fixes and enhancements for the MGAG200 KMS driver

2013-07-17 Thread Egbert Eich
This set of patches contains several fixes and enhancements for the MGAG200 KMS driver. Egbert Eich (15): drm/mgag200: Fix memleaks in error path in mgag200_fb_create() drm/mgag200: Fix memleak in error path in mgag200_bo_create() drm/mgag200: Free container instead of member

[PATCH 01/16] drm/mgag200: Fix memleaks in error path in mgag200_fb_create()

2013-07-17 Thread Egbert Eich
Some mmemory allocated in mgag200fb_create() was not properly freed before the function returned with an error. This patch takes care of this. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_fb.c | 21 - 1 file changed, 16 insertions(+), 5

[PATCH 13/16] drm/mgag200: Fix framebuffer pitch calculation

2013-07-17 Thread Egbert Eich
From: Takashi Iwai ti...@suse.com The framebuffer pitch calculation needs to be done differently for bpp == 24 - check xf86-video-mga for reference. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 11/16] drm/mgag200: Initialize data needed to map fbdev memory

2013-07-17 Thread Egbert Eich
Due to a missing initialization there was no way to map fbdev memory. Thus for example using the Xserver with the fbdev driver failed. This fix adds initialization for fix.smem_start and fix.smem_len in the fb_info structure, which fixes this problem. Signed-off-by: Egbert Eich e...@suse.de

[PATCH 03/16] drm/mgag200: Free container instead of member in mga_user_framebuffer_destroy()

2013-07-17 Thread Egbert Eich
Technically freeing mga_fb-base is the same as freeing mga_fb as 'base' the first member of the data structure. Still this makes it cleaner. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/16] drm/mgag200: Add an crtc_disable callback to the crtc helper funcs

2013-07-17 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_mode.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index 251784a..2fe1f64 100644 --- a/drivers/gpu/drm/mgag200

[PATCH 02/16] drm/mgag200: Fix memleak in error path in mgag200_bo_create()

2013-07-17 Thread Egbert Eich
The allocated struct mgag200_bo was not freed in all error paths. This patch consolidates error handling and fixes this. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[PATCH 06/16] drm/mgag200: Fix logic in mgag200_bo_pin()

2013-07-17 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200/mgag200_ttm.c index 6461fd2..2606031 100644 --- a/drivers

[PATCH 07/16] drm/mgag200: Make local function mgag200_gem_init_object() static

2013-07-17 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index d51096c..fe8ed66 100644 --- a/drivers/gpu/drm/mgag200

[PATCH 14/16] drm/mgag200: Fix LUT programming for 16bpp

2013-07-17 Thread Egbert Eich
Since there are only 32 (64) distinct color values for each color in 16bpp Matrox hardware expects those in a 'dense' manner, ie in the first 32 (64) entries of the respective color. Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_mode.c | 23

[PATCH 04/16] drm/mgag200: Don't unreference when handle creation failed

2013-07-17 Thread Egbert Eich
drm_gem_handle_create() should not have referenced an object when it's creation has failed for some reason. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200

[PATCH 10/16] drm/mgag200: Invalidate page tables when pinning a BO

2013-07-17 Thread Egbert Eich
of this BO. When user space accesses this memory again we will receive a page fault and are able to set up the page tables to point to the correct physical memory. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 08/16] drm/mgag200: Simplify function mgag200_bo_unpin()

2013-07-17 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@suse.de --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200/mgag200_ttm.c index 2606031..3a2e5e2 100644 --- a/drivers/gpu/drm/mgag200

[PATCH 16/16] drm/mgag200: Add doublescan and interlace support

2013-07-17 Thread Egbert Eich
This code was ported from the xorg mga driver. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_mode.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index

[PATCH V2] drm/mgag200: Invalidate page tables when pinning a BO

2013-07-17 Thread Egbert Eich
() called from ttm_bo_handle_move_mem() will take care of this. v2: Don't call ttm_bo_unmap_virtual() in mgag200_bo_pin(), fix comment. Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200

Re: [PATCH 04/16] drm/mgag200: Don't unreference when handle creation failed

2013-07-17 Thread Egbert Eich
Chris Wilson writes: On Wed, Jul 17, 2013 at 03:07:17PM +0200, Egbert Eich wrote: drm_gem_handle_create() should not have referenced an object when it's creation has failed for some reason. Signed-off-by: Egbert Eich e...@suse.com Nak. The unreference here is to free

[PATCH 06/16 v2] drm/mgag200: Fix logic in mgag200_bo_pin() (v2)

2013-07-23 Thread Egbert Eich
Add missing 'return 0;'. v2: Simplified patch as suggested by Dave Airlie airl...@redhat.com Signed-off-by: Egbert Eich e...@suse.com --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200

Re: [PATCH 00/16] drm/mgag200: Fixes and enhancements for the MGAG200 KMS driver

2013-07-23 Thread Egbert Eich
Hi Dave, Dave Airlie writes: On Wed, Jul 17, 2013 at 11:07 PM, Egbert Eich e...@suse.com wrote: This set of patches contains several fixes and enhancements for the MGAG200 KMS driver. Hi Egbert, I've pushed some of these into a branch in my repo, mgag200-queue, I'll try

[PATCH 1/2] drm/ast: open key before detect chips

2014-09-10 Thread Egbert Eich
> { > struct ast_private *ast = dev->dev_private; > uint32_t data, jreg; > +ast_open_key(ast); > > if (dev->pdev->device == PCI_CHIP_AST1180) { > ast->chip = AST1100; > -- > 1.8.3.1 > Reviewed-by: Egbert Eich

[PATCH 2/2] drm/ast: AST2000 cannot be detected correctly

2014-09-10 Thread Egbert Eich
} > ast->vga2_clone = false; > } else { > -ast->chip = 2000; > +ast->chip = AST2000; > DRM_INFO("AST 2000 detected\n"); > } > } > -- > 1.8.3.1 > Reviewed-by: Egbert Eich

[PATCH] Fixed 1600x900 Display Issue

2014-08-21 Thread Egbert Eich
On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote: > From: "Y.C. Chen" > > --- > drivers/gpu/drm/ast/ast_mode.c | 27 +- > drivers/gpu/drm/ast/ast_tables.h | 42 > ++-- > 2 files changed, 41 insertions(+), 28 deletions(-) >

[PATCH] Fixed 1600x900 Display Issue

2014-08-21 Thread Egbert Eich
Just noticed two other things: On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote: > --- a/drivers/gpu/drm/ast/ast_tables.h > +++ b/drivers/gpu/drm/ast/ast_tables.h > @@ -72,6 +72,7 @@ > static struct ast_vbios_dclk_info dclk_table[] = { > {0x2C, 0xE7, 0x03},

[PATCH 1/2] drm/ast: Add missing entry to dclk_table[]

2014-08-22 Thread Egbert Eich
/* 19: > VCLK97_75*/ > }; > > static struct ast_vbios_stdtable vbios_stdtable[] = { > -- > 1.8.3.1 > Reviewed-by: Egbert Eich

[PATCH 2/2] drm/ast: Add reduced/non-reduced mode parsing for wide screen mode

2014-08-22 Thread Egbert Eich
Hi YC, Y.C. Chen writes: > From: "Y.C. Chen" > > Signed-off-by: Y.C. Chen > --- > drivers/gpu/drm/ast/ast_mode.c | 32 +++--- > drivers/gpu/drm/ast/ast_tables.h | 42 > > 2 files changed, 50 insertions(+), 24

[PATCH 2/2] drm/ast: Add reduced/non-reduced mode parsing for wide screen mode

2014-08-22 Thread Egbert Eich
Hi YC, Y.C. Chen writes: > From: "Y.C. Chen" > > Signed-off-by: Y.C. Chen > --- > drivers/gpu/drm/ast/ast_mode.c | 32 +++--- > drivers/gpu/drm/ast/ast_tables.h | 42 > > 2 files changed, 50 insertions(+), 24

[PATCH v2] drm/ast: Improve mode matching

2014-08-27 Thread Egbert Eich
: > From: "Y.C. Chen" > > Signed-off-by: Egbert Eich > Signed-off-by: Y.C. Chen > > v2: Add two pass mode selection, first try to match sync polarities and > refresh > if this fails, try matching refresh only. Suggested by: Egbert Eich >

[PATCH 03/17] DRM/KMS/EDID: Return Base EDID block if reading EEDID Blocks fails.

2012-11-19 Thread Egbert Eich
If I2C readout fails for an extension block but we have read a valid base block, don't fail completely but at least return the base block. Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_edid.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 01/17] DRM/KMS/EDID: Mask out Segment Bits when calculating Offset.

2012-11-19 Thread Egbert Eich
This patch is a bit cosmetic as the variable size will truncate the start address anyway but for readability it should be made explicite that the lowest bit in the EDID block number determines the I2C start address. Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_edid.c |2 +- 1 files

[PATCH 04/17] DRM/KMS/EDID: Test EDDC if EDID announces more than one Extension Block.

2012-11-19 Thread Egbert Eich
address is not taken into account, this block will be identical to the base block in which case we stop reading further EEDID blocks, correct the extension flag and just return the base block. Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_edid.c | 13 + 1 files changed, 13 insertions

[PATCH 06/17] DRM/exynos: Fix Memory Leak: free EDID blcok returned by drm_get_edid().

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich --- drivers/gpu/drm/exynos/exynos_hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 2c115f8..bc87bca 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b

[PATCH 05/17] DRM/KMS/EDID: Fix up EEDID Map Blocks if Extension block count has changed.

2012-11-19 Thread Egbert Eich
as this is less time consuming. For v1.3 we scrap any exsisting map blocks and recreate them from scratch. Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_edid.c | 105 +-- 1 files changed, 100 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 07/17] DRM/KMS/EDID: Move drm_edid_load.o to drm.ko

2012-11-19 Thread Egbert Eich
. Signed-off-by: Egbert Eich --- drivers/gpu/drm/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 2ff5cef..76ca269 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -16,11 +16,11 @@ drm

[PATCH 09/17] DRM/KMS/EDID: Feed 'firmware' supplied EDID blocks whenever the EDID is read.

2012-11-19 Thread Egbert Eich
for detecting the presence of a device thru EDID). Also it does so not on the helper level any more, the possibility for EDID loading now happens on the DRM KMS core level. Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_crtc_helper.c |6 +- drivers/gpu/drm/drm_edid.c|7

[PATCH 08/17] DRM/KMS/EDID: Use Extension Block Fixup Code also for 'firmware' EDID.

2012-11-19 Thread Egbert Eich
Signed-off-by: Egbert Eich --- drivers/gpu/drm/drm_edid.c | 77 --- drivers/gpu/drm/drm_edid_load.c | 54 ++- include/drm/drm_edid.h |1 + 3 files changed, 77 insertions(+), 55 deletions(-) diff --git a/drivers

[PATCH 11/17] DRM/KMS/EDID: Avoid failing on krealloc on EDID blocks.

2012-11-19 Thread Egbert Eich
is larger than one page and the kernel is not able to find consecutive pages to allocate. In this case it is still better to return what we already have (in most cases the base block) and correct the extension block flag and the checksum accordingly than to fail completely. Signed-off-by: Egbert

  1   2   >