[Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

Daniel, Thanks a lot for the quick reply! On 20 Apr 01:34 PM, Daniel Vetter wrote: > On Tue, Apr 19, 2016 at 02:31:13PM -0300, Ezequiel Garcia wrote: > > Currently, our implementation of drm_connector_funcs.detect is > > based on getting a valid EDID. > > > > This r

[Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

On 22 Apr 10:15 AM, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > > Daniel, > > > > Thanks a lot for the quick reply! > > > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > > On Tue, Apr 19, 2016

[Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

On 22 April 2016 at 14:02, Daniel Vetter wrote: > On Fri, Apr 22, 2016 at 12:18:07PM -0300, Ezequiel Garcia wrote: >> On 22 Apr 10:15 AM, Daniel Vetter wrote: >> > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: >> > > Daniel, >> > &g

Kernel stability on baytrail machines

er too. Also, do we know which CPUs are affect by this issue? and which are NOT affected :) - would be quite relevant in picking a CPU for a product. [1] https://bugzilla.kernel.org/show_bug.cgi?id=109051 -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar

[PATCH] drm/i915/hdmi: Fix weak connector detection

. However, this would be more invasive and thus more error-prone. The current commit is an attempt to get some uninvasive fix, and allow for easier backporting. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/i915/intel_hdmi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support

Dave, On 03 Sep 08:08 AM, Johannes Pointner wrote: > 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia : > > Dave, > > > > I'm resending this, hoping it can be pushed for v3.18. The patchset was > > ready for v3.17, but it got no maintainer feedback or review. Maybe it

[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support

On 15 Sep 05:59 PM, Dave Airlie wrote: > On 15 September 2014 17:50, Ezequiel Garcia > wrote: > > Dave, > > > > On 03 Sep 08:08 AM, Johannes Pointner wrote: > >> 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia >> vanguardiasur.com.ar>: > >> >

[PATCH 0/8] tilcdc-panel: Backlight and GPIO devicetree support

of drm-next branch which contains the latest tilcdc pushed by Guido. If at all possible, I'd like to get this merged for v3.17. If a pull request is needed, don't hesitate to ask and I'll prepare one. Comments and tests welcome! Ezequiel Garcia (8): drm/tilcdc: Fix the error path in tilcdc_load

[PATCH 3/8] drm/tilcdc: panel: Remove unused variable

Just a trivial cleanup to remove the variable. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index d581c53..8f88bfd 100644 --- a/drivers

[PATCH 4/8] drm/tilcdc: panel: Spurious whitespace removal

Just a cosmetic cleanup. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 8f88bfd..4b36e68 100644 --- a/drivers/gpu/drm/tilcdc

[PATCH 7/8] drm/tilcdc: panel: Set return value explicitly

Instead of setting an initial value for the return code, set it explicitly on each error path. This is just a cosmetic cleanup, as preparation for the enable GPIO support. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 8/8] drm/tilcdc: panel: Add support for enable GPIO

e optional properties. Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/drm/tilcdc/panel.txt | 2 ++ drivers/gpu/drm/tilcdc/tilcdc_panel.c | 37 +++--- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/

[PATCH 1/8] drm/tilcdc: Fix the error path in tilcdc_load()

function, and release only the resources actually allocated. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 60 ++--- 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm

[PATCH 5/8] drm/tilcdc: panel: Use devm_kzalloc to simplify the error path

Using the managed variant to allocate the resource makes the code simpler and less error-prone. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu

[PATCH 6/8] drm/tilcdc: panel: Fix backlight devicetree support

and is not even documented. Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/drm/tilcdc/panel.txt | 5 + drivers/gpu/drm/tilcdc/tilcdc_panel.c | 23 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree

[PATCH 2/8] drm/tilcdc: panel: Add missing of_node_put

This commit adds the missing calls to of_node_put to release the node that's currently held by the of_get_child_by_name() call in the panel info parsing code. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 8/8] drm/tilcdc: panel: Add support for enable GPIO

Hello Fabio, On 11 Jul 12:08 PM, Fabio Estevam wrote: > On Fri, Jul 11, 2014 at 11:18 AM, Ezequiel Garcia > wrote: > > In order to support the "enable GPIO" available in many panel devices, > > this commit adds a proper devicetree binding. > > > > By pr

[PATCH 0/8] tilcdc-panel: Backlight and GPIO devicetree support

On 11 Jul 11:18 AM, Ezequiel Garcia wrote: > Hello all, > > This patchset adds the required changes to support an optional backlight > and GPIO for the tilcdc panel driver. > > There was some code to support a backlight, but it was somewhat broken > and undocumented. I

[PATCH 0/8] tilcdc-panel: Backlight and GPIO devicetree support

On 24 Jul 04:25 PM, Darren Etheridge wrote: > On 07/11/2014 09:18 AM, Ezequiel Garcia wrote: > >Hello all, > > > >This patchset adds the required changes to support an optional backlight > >and GPIO for the tilcdc panel driver. > > > >There was some code to s

[PATCH] drm: Change link order to load modules first

Given panels and I2C-connected encoders are required by DRM drivers, we need to change the link order so these are probed first. This commit moves all the i2c, panel and bridge helper drivers so they are probed before the DRM drivers. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/Makefile

[PATCH] drm: Change link order to load modules first

Hi Thierry, Thanks for looking at this. On 23 Jun 04:58 PM, Thierry Reding wrote: > On Sun, Jun 22, 2014 at 10:14:36PM -0300, Ezequiel Garcia wrote: > > Given panels and I2C-connected encoders are required by DRM drivers, > > we need to change the link order so these a

[PATCH] drm: Change link order to load modules first

On 27 Jun 07:14 AM, Thierry Reding wrote: > On Mon, Jun 23, 2014 at 12:29:09PM -0300, Ezequiel Garcia wrote: > > > > > > No. We don't need to change the link order. > > > > Could you clarify why? I guess you have some case in mind where changing > >

[PATCH 6/9] ARM: dts: am33xx: Add external clock provider

On 06 Aug 04:47 PM, Jyri Sarha wrote: > Add external clock provaider for am33xx devices. Typo: s/provaider/provider -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com

[PATCH 0/9] Beaglebone-Black HDMI audio

ches over half a year ago. > To my surprise, this worked out of the box. Did some simple tests with mpg123 and mplayer. Tested-by: Ezequiel Garcia Thanks a lot! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com

[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support

with such capability. Also here, I've followed panel-simple which looks correct. In addition to this there are very minor cosmetic cleanups and a larger fix for the error path in tilcdc's DRM driver .load error path. Ezequiel Garcia (8): drm/tilcdc: Fix the error path in tilcdc_load() drm/tilcdc

[PATCH/RESEND 1/8] drm/tilcdc: Fix the error path in tilcdc_load()

function, and release only the resources actually allocated. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 60 ++--- 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tilcdc

[PATCH/RESEND 2/8] drm/tilcdc: panel: Add missing of_node_put

This commit adds the missing calls to of_node_put to release the node that's currently held by the of_get_child_by_name() call in the panel info parsing code. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 3 +++ 1 file changed, 3

[PATCH/RESEND 3/8] drm/tilcdc: panel: Remove unused variable

Just a trivial cleanup to remove the variable. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index d581c53

[PATCH/RESEND 4/8] drm/tilcdc: panel: Spurious whitespace removal

Just a cosmetic cleanup. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 8f88bfd..4b36e68 100644

[PATCH/RESEND 5/8] drm/tilcdc: panel: Use devm_kzalloc to simplify the error path

Using the managed variant to allocate the resource makes the code simpler and less error-prone. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tilcdc

[PATCH/RESEND 6/8] drm/tilcdc: panel: Fix backlight devicetree support

and is not even documented. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/drm/tilcdc/panel.txt | 5 + drivers/gpu/drm/tilcdc/tilcdc_panel.c | 23 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git

[PATCH/RESEND 7/8] drm/tilcdc: panel: Set return value explicitly

Instead of setting an initial value for the return code, set it explicitly on each error path. This is just a cosmetic cleanup, as preparation for the enable GPIO support. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 +++- 1 file

[PATCH/RESEND 8/8] drm/tilcdc: panel: Add support for enable GPIO

e optional properties. Tested-by: Darren Etheridge Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/drm/tilcdc/panel.txt | 2 ++ drivers/gpu/drm/tilcdc/tilcdc_panel.c | 37 +++--- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/Doc

[PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support

On 3 September 2014 03:08, Johannes Pointner wrote: [..] > > I tested the series with 3.16.1 (with additonal patches from Guido and > Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for > me without an issue. I tried it with and without the backlight > addition in the dts file.

[PATCH] drm/i915/hdmi: Fix weak connector detection

El abr. 1, 2016 11:47 AM, "Ville Syrjälä" escribió: > > On Thu, Mar 31, 2016 at 05:55:03PM -0300, Ezequiel Garcia wrote: > > Currently, our implementation of drm_connector_funcs.detect is > > based on getting a valid EDID. > > > > This requirement m

[PATCH] drm/i915/hdmi: Fix weak connector detection

On 01 Apr 06:46 PM, Ville Syrjälä wrote: > On Fri, Apr 01, 2016 at 12:38:11PM -0300, Ezequiel Garcia wrote: > > El abr. 1, 2016 11:47 AM, "Ville Syrjälä" > linux.intel.com> > > escribió: > > > > > > On Thu, Mar 31, 2016 at 05:55:03PM -03

[PATCH] drm/i915/hdmi: Fix weak connector detection

(Adding Jani again, who got dropped for some reason) On 1 April 2016 at 16:50, Ezequiel Garcia wrote: > On 01 Apr 06:46 PM, Ville Syrjälä wrote: >> On Fri, Apr 01, 2016 at 12:38:11PM -0300, Ezequiel Garcia wrote: >> > El abr. 1, 2016 11:47 AM, "Ville Syrjäl

[PATCH] drm/i915/hdmi: Fix weak connector detection

On 5 April 2016 at 11:54, Ezequiel Garcia wrote: > (Adding Jani again, who got dropped for some reason) > > On 1 April 2016 at 16:50, Ezequiel Garcia > wrote: >> On 01 Apr 06:46 PM, Ville Syrjälä wrote: >>> On Fri, Apr 01, 2016 at 12:38:11PM -0300, Ezequiel Ga

[PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

to provide a valid EDID will be reported as disconnected (unless the state is forced) and thus the kernel won't allow to use such device with any mode, either builtin, user-provided, or the 1024x768 noedid fallback. Signed-off-by: Ezequiel Garcia --- This patch supersedes: "drm/i915/hdmi

[PATCH] drm: probe_helper: Hide ugly ifdef

Push the ifdef to the drm_edid.h and create a stub, for the DRM_LOAD_EDID_FIRMWARE=n case. This removes some clutter in the code, making it more readable. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/drm_probe_helper.c | 2 -- include/drm/drm_edid.h | 8 2 files

[PATCH] drm: Make drm.debug parameter description more helpful

Let's be user-friendly and print an actually helpful parameter description. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/drm_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 167c8d3d4a31

[PATCH] drm: Make drm.debug parameter description more helpful

(Adding Dave again) On 20 April 2016 at 06:21, Jani Nikula wrote: > On Tue, 19 Apr 2016, Ezequiel Garcia wrote: >> Let's be user-friendly and print an actually helpful parameter >> description. >> >> Signed-off-by: Ezequiel Garcia >> --- >> drivers/gpu

[PATCH v2] drm: Make drm.debug parameter description more helpful

) Bit 5 (0x20) will enable VBL messages (vblank code) (int) Signed-off-by: Ezequiel Garcia -- Changes from v1: * Fixed s/PRMIE/PRIME typo. * Add ATOMIC and VBL debug parameter documentation. * Prefix the continuation lines with two tabs and removed the last new line. * Remove spurious

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

On Mon, 2018-05-14 at 18:48 +0200, Daniel Vetter wrote: > On Fri, May 11, 2018 at 08:27:41AM +0100, Chris Wilson wrote: > > Quoting Ezequiel Garcia (2018-05-09 21:14:49) > > > Change how dma_fence_add_callback() behaves, when the fence > > > has error-signaled by the

Re: [PATCH v2] drm: Allow CAP_DUMB_BUFFERS on !MODESET

Hey Daniel, On Tue, 2018-05-08 at 09:55 +0200, Daniel Vetter wrote: > On Tue, May 08, 2018 at 01:52:01AM -0300, Ezequiel Garcia wrote: > > It's perfectly possible to get dumb buffers out of drivers > > that don't support modeset. This is the case of vgem, > > which can be

[PATCH v2] drm: Allow CAP_DUMB_BUFFERS on !MODESET

UPP when called for KMS cap with a non-KMS driver") Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- Changes from v1: * Drop the bitwise-OR assignment op drivers/gpu/drm/drm_ioctl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm: Allow CAP_DUMB_BUFFERS on !MODESET

On Mon, 2018-05-07 at 11:36 +0200, Maarten Lankhorst wrote: > Op 04-05-18 om 16:25 schreef Ezequiel Garcia: > > It's perfectly possible to get dumb buffers out of drivers > > that don't support modeset. This is the case of vgem, > > which can be used to export dmabuf

[PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

Change how dma_fence_add_callback() behaves, when the fence has error-signaled by the time it is being add. After this commit, dma_fence_add_callback() returns the fence error, if it has error-signaled before dma_fence_add_callback() is called. Signed-off-by: Ezequiel Garcia <ez

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

On Wed, 2018-05-09 at 19:42 -0300, Gustavo Padovan wrote: > Hi Ezequiel, > > On Wed, 2018-05-09 at 17:14 -0300, Ezequiel Garcia wrote: > > Change how dma_fence_add_callback() behaves, when the fence > > has error-signaled by the time it is being add. After this commit, >

[PATCH] drm: Allow CAP_DUMB_BUFFERS on !MODESET

Allow CAP_PRIME on !MODESET"). Fixes: d5264ed3823a ("drm: Return -ENOTSUPP when called for KMS cap with a non-KMS driver") Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/gpu/drm/drm_ioctl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) di

[PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces

The sync_debug.h header is internal, and only used by sw_sync.c. Therefore, SW_SYNC is always defined and there is no need for the stubs. Remove them and make the code simpler. Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/dma-buf/sync_debug.h | 10 --

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

On Wed, 2018-05-16 at 12:26 +0200, Lucas Stach wrote: > Am Mittwoch, den 16.05.2018, 11:42 +0200 schrieb Daniel Vetter: > > On Tue, May 15, 2018 at 01:16:30PM +0100, Chris Wilson wrote: > > > Quoting Ezequiel Garcia (2018-05-14 22:28:31) > > > > On Mon, 2018-05-14

Re: [PATCH v8 03/14] iommu/rockchip: Request irqs in rk_iommu_probe()

Hey Jeffy, Robin: Some odd issues to report here. On 23 March 2018 at 04:38, Jeffy Chen wrote: > Move request_irq to the end of rk_iommu_probe(). > > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > Acked-by:

Re: [PATCH v2 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

On Mon, 2018-05-28 at 15:20 +0200, Heiko Stuebner wrote: > This still tries to address the hang seen by Ezequiel Garcia on rk3288. > > As Tomasz noted, trying to count enablement can run into concurrency > issues, so instead we'll just check if the vop is runtime-enabled > to

Re: [PATCH v6 24/30] drm/rockchip: Disable PSR on input events

On Thu, 2018-04-05 at 11:49 +0200, Enric Balletbo i Serra wrote: > From: "Kristian H. Kristensen" > > To improve PSR exit latency, we speculatively start exiting when we > receive input events. Occasionally, this may lead to false positives, > but most of the time we get a

Re: [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel

On 25 April 2018 at 01:29, Doug Anderson <diand...@chromium.org> wrote: > Hi, > > On Tue, Apr 24, 2018 at 7:31 AM, Ezequiel Garcia > <ezequ...@vanguardiasur.com.ar> wrote: >> Hi Doug, Sean: >> >> I would like to move this forward. >> >&

Re: [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel

Hi Doug, Sean: I would like to move this forward. On 26 February 2018 at 15:23, Doug Anderson wrote: > Hi, > > On Thu, Feb 8, 2018 at 9:48 AM, Sean Paul wrote: >> This patch adds an override mode for kevin devices. The mode increases >> both back

[PATCH libdrm] tests/util: Add support for sun4i-drm driver

This is the DRM driver for all Allwinner (sunxi) platforms. Signed-off-by: Ezequiel Garcia --- tests/util/kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/kms.c b/tests/util/kms.c index a2d1d7ba2431..5af8bf20a8c9 100644 --- a/tests/util/kms.c +++ b/tests/util/kms.c @@ -145,6

[PATCH 2/3] virtio: Rework virtio_gpu_object_kmap()

. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio/virtgpu_drv.h| 2 +- drivers/gpu/drm/virtio/virtgpu_fb.c | 10 ++ drivers/gpu/drm/virtio/virtgpu_object.c | 11 +++ 3 files changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 3/3] virtio: Support prime objects vmap/vunmap

to take care of it in the driver. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio/virtgpu_prime.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c b/drivers/gpu/drm/virtio/virtgpu_prime.c index d27a1688714f

[PATCH 0/3] virtio: add vmap support for prime objects

the TTM object destroy path. This function will be used to unmap prime objects. The second patch reworks virtio_gpu_object_kmap(), so it's balanced with virtio_gpu_object_kunmap. Finally, the third patch uses virtio_gpu_object_k{map,unmap} to support prime v{map,unmap}. Please review! Ezequiel

[PATCH 1/3] virtio: Add virtio_gpu_object_kunmap()

Implement a virtio_gpu_object_kunmap() to unmap the kernel mapping, and use it in the TTM object destroy path. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 + drivers/gpu/drm/virtio/virtgpu_object.c | 8 2 files changed, 9 insertions(+) diff --git

Re: [PATCH] drm/virtio: switch to generic fbdev emulation

a more verbose history is useful. The patch looks good: Reviewed-by: Ezequiel Garcia > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 14 --- > drivers/gpu/drm/virtio/virtgpu_display.c | 1 - > drivers/gpu/drm/virtio/virtgpu_drv.c | 9 +-

[PATCH] drm/virtio: Add missing virtqueue reset

As per the VirtIO spec, the virtqueues must be reset during cleanup (see "3.3.1 Driver Requirements: Device Cleanup"). Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/d

[PATCH] drm/virtio: Remove incorrect kfree()

The virtio_gpu_output is a member of struct virtio_gpu_device and is not a dynamically-allocated chunk, so it's wrong to kfree() it. Removing it fixes a memory corruption BUG() that can be triggered when the virtio-gpu driver is removed. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio

Re: [PATCH 05/10] drm/virtio: use struct to pass params to virtio_gpu_object_create()

On Wed, 2018-12-19 at 13:27 +0100, Gerd Hoffmann wrote: > Create virtio_gpu_object_params, use that to pass object parameters to > virtio_gpu_object_create. Also drop unused "kernel" parameter (unused, > always false). > > Signed-off-by: Gerd Hoffmann > --- >

Re: [PATCH 03/10] drm/virtio: drop virtio_gpu_fence_cleanup()

rtgpu_plane.c > @@ -169,8 +169,10 @@ static void virtio_gpu_cursor_cleanup_fb(struct > drm_plane *plane, > return; > > vgfb = to_virtio_gpu_framebuffer(plane->state->fb); > - if (vgfb->fence) > - virtio_gpu_fence_cleanup(vgfb->

Re: [PATCH 02/10] drm/virtio: fix pageflip flush

;state->src_x >> 16, > + plane->state->src_y >> 16, > + plane->state->src_w >> 16, > + plane->state->src_h >> 16); > } > > static int virtio_gp

[PATCH v2] drm/rockchip: Fix YUV buffers color rendering

to HDMI monitor): $ modetest 39@32:1920x1080@NV12 $ gst-launch-1.0 videotestrc ! video/x-raw,format=NV12 ! kmssink Signed-off-by: Daniele Castagna [ezequiel: rebase on linux-next and massage commit log] Signed-off-by: Ezequiel Garcia --- v2: * Addressed feedback from Sean Paul * Rebased

Re: [PATCH 04/10] arm: implement DMA_ATTR_NON_CONSISTENT

On Sat, 2018-12-08 at 09:36 -0800, Christoph Hellwig wrote: > For the iommu ops we can just use the implementaton for DMA coherent > devices. For the regular ops we need mix and match a bit so that > we either use the CMA allocator without remapping, but with a special > error handling case for

[PATCH v3] drm/rockchip: Fix YUV buffers color rendering

connected to HDMI monitor): $ modetest 39@32:1920x1080@NV12 $ gst-launch-1.0 videotestrc ! video/x-raw,format=NV12 ! kmssink Signed-off-by: Daniele Castagna [ezequiel: rebase on linux-next and massage commit log] Signed-off-by: Ezequiel Garcia --- v3: Add a check for non-null win_yuv2yuv

Re: [PATCH v2] drm/rockchip: Fix YUV buffers color rendering

On Mon, 2019-01-07 at 14:26 +0100, Heiko Stuebner wrote: > Hi, > > sorry, only now got to test this on actual hardware, > > Am Freitag, 14. Dezember 2018, 17:29:20 CET schrieb Ezequiel Garcia: > > From: Daniele Castagna > > > > Currently, YUV hardware ov

Re: [PATCH] drm/virtio: Drop deprecated load/unload initialization

On Tue, 2019-01-08 at 11:43 +0100, Gerd Hoffmann wrote: > On Thu, Jan 03, 2019 at 01:16:00PM -0300, Ezequiel Garcia wrote: > > Move the code around so the driver is probed the bus > > .probe and removed from the bus .remove callbacks. > > This commit is just a cleanup

[PATCH v2] drm/virtio: Drop deprecated load/unload initialization

Move the code around so the driver is probed the bus .probe and removed from the bus .remove callbacks. This commit is just a cleanup and shouldn't affect functionality. Signed-off-by: Ezequiel Garcia --- v2: rebased on drm-misc-next drivers/gpu/drm/virtio/Makefile | 2 +- drivers

Re: [PATCH v2] drm/rockchip: Fix YUV buffers color rendering

On Mon, 2019-01-07 at 17:07 -0300, Ezequiel Garcia wrote: > On Mon, 2019-01-07 at 14:26 +0100, Heiko Stuebner wrote: > > Hi, > > > > sorry, only now got to test this on actual hardware, > > > > Am Freitag, 14. Dezember 2018, 17:29:20 CET schrieb Ezequiel Gar

Re: [PATCH v2] drm/rockchip: Fix YUV buffers color rendering

On Fri, 2018-12-14 at 13:29 -0300, Ezequiel Garcia wrote: > From: Daniele Castagna > > Currently, YUV hardware overlays are converted to RGB using > a color space conversion different than BT.601. > > The result is that colors of e.g. NV12 buffers don't match > colors of

Re: [PATCH v2] drm/amdgpu_vm: fix boolean expressions

Hey Gustavo, On Thu, 3 Jan 2019 at 17:25, Gustavo A. R. Silva wrote: > > Fix boolean expressions by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: 9a4b7d4c769e ("drm/amdgpu: Add vm context module param") >

[PATCH] drm/virtio: Drop deprecated load/unload initialization

Move the code around so the driver is probed the bus .probe and removed from the bus .remove callbacks. This commit is just a cleanup and shouldn't affect functionality. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/virtio/Makefile | 2 +- drivers/gpu/drm/virtio

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

Hi Liviu, On Mon, 2018-12-03 at 11:31 +, Ayan Halder wrote: > From: Brian Starkey > > AFBC is a flexible, proprietary, lossless compression protocol and > format, with a number of defined DRM format modifiers. To facilitate > consistency and compatibility between different AFBC producers

[PATCH 1/3] drm/rockchip: Fix typo in VOP macros argument

lting code shouldn't change. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 7ad906

[PATCH 0/3] Support reflect-x/y on RK3328, RK3368, and RK3399

by Daniele. I just cleaned up the implementation a it, and ported the code to upstream. This series is based on drm-misc-next plus https://patchwork.kernel.org/patch/10752893/. Daniele Castagna (1): drm/rockchip: Add reflection properties Ezequiel Garcia (2): drm/rockchip: Fix typo in VOP macros

[PATCH 3/3] drm/rockchip: Add reflection properties

@33:1920x1080@XR24 -w 30:rotation:33 XY mirror: modetest -s 43@33:1920x1080@XR24 -w 30:rotation:49 Signed-off-by: Daniele Castagna Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2

[PATCH 2/3] drm/rockchip: Separate RK3288 from RK3368 win01 registers

This commit splits the registers for RK3288 from those for RK3328, RK3368 and RK3399. It seems RK3288 does not support plane x-y-mirroring, and so in order to support this for the other SoCs, we need to have separate set of registers for win0 and win1. Signed-off-by: Ezequiel Garcia --- drivers

Re: [PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

vop_win->yuv2yuv_data = _data->win_yuv2yuv[i]; > } > } > Ugh, another one of these. Reviewed-by: Ezequiel Garcia Thanks, Eze ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 1/7] dt-bindings: Add panel-timing subnode to simple-panel

On Thu, 2019-03-28 at 10:17 -0700, Douglas Anderson wrote: > From: Sean Paul > > This patch adds a new subnode to simple-panel allowing us to override > the typical timing expressed in the panel's display_timing. > > Changes in v2: > - Split out the binding into a new patch (Rob) > -

Re: [5.2][PATCH 0/3] Ingenic JZ47xx KMS driver

On Thu, 2019-02-28 at 19:07 -0300, Paul Cercueil wrote: > Hi, > > This is a first attempt at a KMS driver for the JZ47xx MIPS SoCs by > Ingenic. It is aimed to replace the aging jz4740-fb driver. > > The driver will later be updated with new features (overlays, TV-out > etc.), that's why I

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

Hi everyone, Dante: please avoid top-posting. In other words, put your replies in-line, like I'm gonna do now. See below (and see how discussion goes on other threads). On Mon, 11 Mar 2019 at 17:34, DANTE JAVIER PAZ wrote: > > Hello Sam, thank you very much for your comments, > As I told Dan

Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver

On Mon, 28 Jan 2019 at 12:59, Thierry Reding wrote: > > On Thu, Jan 24, 2019 at 12:51:36PM -0500, Sean Paul wrote: > > On Thu, Jan 24, 2019 at 05:18:12PM +0100, Thierry Reding wrote: > > > On Thu, Jan 24, 2019 at 12:01:55PM -0300, Ezequiel Garcia wrote: > > > >

Re: [PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver

On Tue, 2018-10-30 at 10:15 +0100, Heiko Stuebner wrote: > From: Nickey Yang > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > it is a MIPI dual-DSI panel. > > v4-resend: > - Thierry noted missing dt-bindings for v4 but forgot that he > already had applied them one kernel

Re: [5.2][PATCH 0/3] Ingenic JZ47xx KMS driver

On Mon, 2019-03-11 at 12:45 +0100, Paul Cercueil wrote: > Hi Ezequiel, > > On Mon, Mar 11, 2019 at 1:02 AM, Ezequiel Garcia > wrote: > > On Thu, 2019-02-28 at 19:07 -0300, Paul Cercueil wrote: > > > Hi, > > > > > > This is a first att

Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems

On Mon, 11 Mar 2019 at 18:40, Sam Ravnborg wrote: > > Hi Eze > > > > Why is this driver still here? I thought we migrated everyhing to > > tinydrm already. > Some have been ported, some are waiting for a user to do the port. > If you looks at tinydrm you will see: > ili9225.c ili9341.c > > And

[PATCH] drm/panfrost: Select devfreq

Currently, there is some logic for the driver to work without devfreq. However, the driver actually fails to probe if !CONFIG_PM_DEVFREQ. Fix this by selecting devfreq, and drop the additional checks for devfreq. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/panfrost/Kconfig

Re: [PATCH] drm/panfrost: make devfreq optional again

On Fri, 2019-05-31 at 14:37 +0200, Neil Armstrong wrote: > Devfreq runtime usage was made mandatory, thus making panfrost fail to probe > on Amlogic S912 SoCs missin the "operating-points-v2" property. > Make it optional again, leaving PM_DEVFREQ is selected by default. > > Fixes: f3617b449d

[PATCH] drm/panfrost: Require the simple_ondemand governor

Panfrost depends on the simple_ondemand governor, and therefore it's a required configuration. Select it. Fixes: f3617b449d ("drm/panfrost: Select devfreq") Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/panfrost/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

Re: [PATCH v2] drm/panfrost: make devfreq optional again

; Fixes: f3617b449d ("drm/panfrost: Select devfreq") > Signed-off-by: Neil Armstrong Reviewed-by: Ezequiel Garcia Thanks for the fix, Eze > --- > Changes since v1: > - fixed else/if logic in panfrost_devfreq_init > > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 13

Re: [PATCH] drm/panfrost: make devfreq optional again

On Fri, 2019-05-31 at 14:37 +0200, Neil Armstrong wrote: > Devfreq runtime usage was made mandatory, thus making panfrost fail to probe > on Amlogic S912 SoCs missin the "operating-points-v2" property. > Make it optional again, leaving PM_DEVFREQ is selected by default. > > Fixes: f3617b449d

Re: [v7 00/16] Add Plane Color Properties

On Thu, 28 Mar 2019 at 16:50, Uma Shankar wrote: > > This is how a typical display color hardware pipeline looks like: > +---+ > |RAM| > | +--++-++-+ | > | | FB 1 || FB 2 |

Re: [v7 00/16] Add Plane Color Properties

(+ Boris, + Sean) On Fri, 2019-06-14 at 13:17 -0300, Ezequiel Garcia wrote: > On Thu, 28 Mar 2019 at 16:50, Uma Shankar wrote: > > This is how a typical display color hardware pipeline looks like: > > +---+ > >

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

On Tue, Jun 11, 2019, 1:01 PM Anders Roxell wrote: > On Tue, 11 Jun 2019 at 10:21, Hans Verkuil wrote: > > > > On 6/11/19 10:15 AM, Philipp Zabel wrote: > > > Hi, > > > > > > On Mon, 2019-06-10 at 13:14 +, Matt Redfearn wrote: > > >> > > >> On 10/06/2019 14:03, Anders Roxell wrote: > > >>>

Re: [RFC/WIP] drm/rockchip: Support CRTC gamma LUT

On Tue, 2019-06-18 at 02:15 -0300, Ezequiel Garcia wrote: > On Mon, 2019-06-17 at 12:06 +0200, Jacopo Mondi wrote: > > Hi Ezequiel, > >one small question, as I'm working on supporting gamma LUT for > > rcar-du as well, and there's one point not totally clear to me > &g

  1   2   3   >