reg.h file.
Signed-off-by: Flavio Suligoi
---
drivers/gpu/drm/i915/i915_reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9d6536afc94b..c2153364724a 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++
reg.h file.
Signed-off-by: Flavio Suligoi
Reviewed-by: Chris Wilson
---
v1: add "Reviewed-by: Chris Wilson "
drivers/gpu/drm/i915/i915_reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index
Hi Krzysztof,
...
> >>> +
> >>> + reg:
> >>> +maxItems: 1
> >>> +
> >>> + mps,dimming-mode:
> >>> +description: The dimming mode (PWM or analog by I2C commands).
> >>> +$ref: '/schemas/types.yaml#/definitions/string'
> >>
> >> Drop quotes, you should see warnings for this.
> >>
>
HI Daniel,
> -Original Message-
> From: Daniel Thompson
> Sent: Tuesday, August 29, 2023 6:28 PM
> To: Flavio Suligoi
> Cc: Lee Jones ; Jingoo Han ; Helge
> Deller ; Pavel Machek ; Rob Herring
> ; Krzysztof Kozlowski
> ; Conor Dooley ;
> dri-devel@lis
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
MAINTAINERS | 6 +
drivers/video/backlig
Hi Krzysztof,
Thanks for your quick replay and corrections!
Just some questions about some of your remarks:
> > @@ -0,0 +1,202 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
>
> > +
> > + reg:
> > +maxItems: 1
> > +
> > + mps,dimming-mode:
> > +
For device driver details, please refer to:
- drivers/video/backlight/mp3309c_bl.c
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
.../bindings/leds/backlight/mps,mp3309c.yaml | 202 ++
1 file changed, 202 insertions(
Both files pwm-backlight.yaml and led-backlight.yaml contain properties
in common with each other, regarding the brightness levels:
- brightness-levels
- default-brightness-level
These properties can then be moved to backlight/common.yaml.
Signed-off-by: Flavio Suligoi
---
.../bindings/leds
Hi Rob,
just a question about led-backlight.yaml and pwm-backlight.yaml
common properties.
...
> > +
> > + brightness-levels:
> > +description:
> > + Array of distinct brightness levels, in PWM dimming mode.
> > + Typically these are in the range from 0 to 255, but any range
> >
, removing the "max-brightness" and introducing the
"brightess-levels" property
NOTE: the "brightess-levels" property is present in the last version of the
common.yaml file, so it is not decalared here.
For this last version of common.yaml file, see my patch:
uot;backlight" kernel repository.
No developer may have used it.
Other changes:
- improve the backlight working mode description, in the "description"
section
- update the example, removing the "max-brightness" and introducing the
"brightess-levels" prop
Hi Conor,
...
> > > > > > The two properties:
> > > > > >
> > > > > > - max-brightness
> > > > > > - default brightness
> > > > > >
> > > > > > are not really required, so they can be removed from the "required"
> > > > > > section.
> > > > >
> > > > > Why are they not required? You need to
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
v2:
- fix dependecies in Kconfig
- fix Kconfig MP3309C entry order
For device driver details, please refer to:
- drivers/video/backlight/mp3309c_bl.c
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
v2:
- remove useless properties (dimming-mode, pinctrl-names, pinctrl-0,
switch-on-delay-ms, switch
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
---
v3:
- fix SPDX obsolet
For device driver details, please refer to:
- drivers/video/backlight/mp3309c_bl.c
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
Reviewed-by: Rob Herring
---
v3:
- add default value for mps,overvoltage-protection-microvolt prope
Hi Daniel,
...
> > > > +required:
> > > > + - compatible
> > > > + - reg
> > > > + - max-brightness
> > >
> > > Why is this mandatory?
> > >
> > > There's no point in setting max-brightness when running in I2C mode
> > > (max- brightness should default to 31 in that case).
> > >
> > >
> > > >
Hi Daniel,
...
> ...
> > > > > +required:
> > > > > + - compatible
> > > > > + - reg
> > > > > + - max-brightness
> > > >
> > > > Why is this mandatory?
> > > >
> > > > There's no point in setting max-brightness when running in I2C
> > > > mode
> > > > (max- brightness should default to 31 in
Hi Daniel,
...
> > +static int mp3309c_bl_update_status(struct backlight_device *bl) {
> > + struct mp3309c_chip *chip = bl_get_data(bl);
> > + int brightness = backlight_get_brightness(bl);
> > + struct pwm_state pwmstate;
> > + unsigned int analog_val, bits_val;
> > + int i, ret;
> >
Hi Daniel,
...
> > +required:
> > + - compatible
> > + - reg
> > + - max-brightness
>
> Why is this mandatory?
>
> There's no point in setting max-brightness when running in I2C mode (max-
> brightness should default to 31 in that case).
>
>
> > + - default-brightness
>
> Again. I'm not
Hi Conor,
...
> On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote:
> > The Monolithic Power (MPS) MP3309C is a WLED step-up converter,
> > featuring a programmable switching frequency to optimize efficiency.
> > The brightness can be controlled either by
HI Rob,
...
> Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C
>
...
> > +
> > + mps,overvoltage-protection-microvolt:
> > +description: Overvoltage protection (13.5V, 24V or 35.5V). If missing,
> > the
> > + hardware default of 35.5V is used.
>
> default:
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
v4:
- add brightness-levels property
- force fixed 32 brightness lev
For device driver details, please refer to:
- drivers/video/backlight/mp3309c_bl.c
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
v4:
- remove not more used allOf keyword
- add brightness-levels and default-brightness properties
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
v5:
- checked and resend for updated kernel 6.6.0-rc1
v4:
- add
the "max-brightness" and introducing the
"brightess-levels" property
Signed-off-by: Flavio Suligoi
---
.../bindings/leds/backlight/mps,mp3309c.yaml | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/bac
rightness-levels related common
properties
commit: d5272d39995f4150062a67e6f2cef556edece740
Flavio Suligoi (1):
dt-bindings: backlight: mp3309c: remove two required properties
.../bindings/leds/backlight/mps,mp3309c.yaml | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
--
2.34.1
Hi Conor,
...
> On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote:
> > The two properties:
> >
> > - max-brightness
> > - default brightness
> >
> > are not really required, so they can be removed from the "required"
> > secti
Hi Conor,
...
> Subject: Re: [PATCH v5] backlight: mp3309c: Add support for MPS MP3309C
>
> On Fri, Oct 20, 2023 at 03:54:34PM +0200, Flavio Suligoi wrote:
> > The Monolithic Power (MPS) MP3309C is a WLED step-up converter,
> > featuring a programmable switching frequency t
HI Daniel,
...
> > ...
> > > ...
> > > > > > > +required:
> > > > > > > + - compatible
> > > > > > > + - reg
> > > > > > > + - max-brightness
> > > > > >
> > > > > > Why is this mandatory?
> > > > > >
> > > > > > There's no point in setting max-brightness when running in I2C
> > > > > > mode
>
Hi Conor,
...
> On Mon, Oct 23, 2023 at 09:28:03AM +0000, Flavio Suligoi wrote:
> > > On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote:
> > > > The two properties:
> > > >
> > > > - max-brightness
> > > > - default bri
leds/backlight/mps,mp3309c.yam
> > +++ l
> > @@ -0,0 +1,82 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/mps,mp3309c.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.
to provid --> to provide
Signed-off-by: Flavio Suligoi
---
v2:
- fix typo in subject
drivers/i2c/busses/i2c-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index e9e2db68b9fb..78fb1a4274a6 100
Hi Daniel,
...
> Subject: Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device
> properties
> > +++ b/drivers/video/backlight/mp3309c.c
> > @@ -15,6 +15,8 @@
> > #include
> > #include
> > #include
> > +#include
> > +#include
> > #include
> > #include
> >
> > @@ -202,15 +204,12
drivers/video/backlight/mp3309c.c | 38 ---
> 1 file changed, 15 insertions(+), 23 deletions(-)
Hi Andy,
I tested the patch in both pwm and analog-ic dimming-mode and everything is ok.
Thanks for the optimizations!
Tested-by: Flavio Suligoi
eo/backlight/mp3309c.c | 38 +--
> 1 file changed, 16 insertions(+), 22 deletions(-)
>
Hi Andy,
I tested the patch in both pwm and analog-ic dimming-mode and everything is ok.
Thanks for the optimizations!
Tested-by: Flavio Suligoi
vers/video/backlight/mp3309c.c:279 pm3309c_parse_dt_node() error:
uninitialized symbol 'prop_levels'.
To avoid any problem in case of undefined behavior, we need to initialize
it to "NULL".
For consistency, I also initialize the other similar variable
"prop_pwms" in the same way.
Sig
a58c ("backlight: mp3309c: Add support for MPS MP3309C")
Signed-off-by: Flavio Suligoi
---
v2:
- remove redundant initialization of "prop_pwms" variable
- remove "thanks to Dan Carpenter for the report"
- add "Reported-by: Dan Carpenter " tag
- add "
Hi Dan,
Thanks for the report, I'll fix the bug as soon as possible.
Regards,
Flavio
> -Original Message-
> From: Dan Carpenter
> Sent: Tuesday, November 28, 2023 8:20 AM
> To: Flavio Suligoi
> Cc: dri-devel@lists.freedesktop.org
> Subject: [bug report] backlight: mp
Hi Dan,
Can I add the "Reported-by" tag, with your name, in my 2nd vers of
the commit to fix this bug?
Thanks and regards,
Flavio
> -Original Message-
> From: Flavio Suligoi
> Sent: Tuesday, November 28, 2023 9:24 AM
> To: Dan Carpenter
> Cc: dri-de
Hi Andy,
> Replace dev_err() with dev_err_probe().
>
> This helps in simplifing code and standardizing the error output.
>
> Signed-off-by: Andy Shevchenko
Tested-by: Flavio Suligoi
Flavio
Hi Andy,
...
> Subject: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF
> platforms
>
> Allow to use driver on non-OF platforms and other cleanups.
>
> Changelog v2:
> - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel)
> - add tags (Daniel, Flavio)
> - new patch 2
>
wm_apply_might_sleep()"). This is the final user in the
> tree.
>
> Signed-off-by: Sean Young
> ---
Tested-by: Flavio Suligoi
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
---
MAINTAINERS | 7 +
drivers/video/backlig
it.
Other changes:
- improve the backlight working mode description, in the "description"
section
- update the example, removing the "max-brightness" and introducing the
"brightess-levels" property
Signed-off-by: Flavio Suligoi
---
.../bindings/leds/backlight/mps
used it.
Flavio Suligoi (2):
dt-bindings: backlight: mp3309c: remove two required properties
backlight: mp3309c: Add support for MPS MP3309C
.../bindings/leds/backlight/mps,mp3309c.yaml | 10 +-
MAINTAINERS | 7 +
drivers/video/backlight/Kconfig
ay have used it.
Other changes:
- improve the backlight working mode description, in the "description"
section
- update the example, removing the "max-brightness" and introducing the
"brightess-levels" property
Signed-off-by: Flavio Suligoi
Acked-by: Cono
s.
For DT configuration details, please refer to:
- Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html
Signed-off-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
---
v7:
- add missed patch history
-
ent
v6.7.0-rc1 kernel version.
No developer may have used it.
Flavio Suligoi (2):
dt-bindings: backlight: mp3309c: remove two required properties
backlight: mp3309c: Add support for MPS MP3309C
.../bindings/leds/backlight/mps,mp3309c.yaml | 10 +-
MAINTAINERS
Hi Daniel,
> On Wed, Oct 25, 2023 at 05:50:57PM +0200, Flavio Suligoi wrote:
> > NOTE: there are no compatibility problems with the previous version,
> > since the device driver has not yet been included in any kernel.
> > Only this dt-binding yaml fil
es: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
> Signed-off-by: Dan Carpenter
I've just tested on my board with the mp3309c chip, all is ok.
Thanks!
Tested-by: Flavio Suligoi
l = devm_backlight_device_register(chip->dev, "mp3309c",
> chip->dev, chip,
> _bl_ops, );
...
I've just tested your change with my board with the mp3309c backlight and all
is ok.
Thanks and best regards
Flavio
Tested-by: Flavio Suligoi
field.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Flavio Suligoi
> Cc: Nicolas Ferre
> Cc: Alexandre Belloni
> Cc: Claudiu Beznea
> Tested-by: Flavio Suligoi
> Reviewed-by: Daniel Thompson
> Reviewed-by: Dan Carpenter
...
Can you explain what are the differences between the version 1 and version 2 of
the patch?
Thanks,
Flavio
the
> >> fb_blank code from core and drivers and rely on the state field.
> >>
> >> Signed-off-by: Thomas Zimmermann
> >> Cc: Flavio Suligoi
> >> Cc: Nicolas Ferre
> >> Cc: Alexandre Belloni
> >> Cc: Claudiu Beznea
> >> Tested-by: Flav
mode, every read operation on the eeprom caused a backlight flickering.
This is why I made this device driver modification.
Flavio Suligoi (1):
backlight: mp3309c: fix leds flickering in pwm mode
drivers/video/backlight/mp3309c.c | 5 -
1 file changed, 5 deletions(-)
--
2.34.1
existing device-tree configuration.
Signed-off-by: Flavio Suligoi
---
drivers/video/backlight/mp3309c.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/video/backlight/mp3309c.c
b/drivers/video/backlight/mp3309c.c
index 016c1296841c..a28036c964af 100644
--- a/drivers/video/backlight
Hi Lee,
...
> Subject: Re: EXTERNAL: Re: (subset) [PATCH v1 1/1] backlight: mp3309c:
> fix leds flickering in pwm mode
>
> On Fri, 03 May 2024, FLAVIO SULIGOI wrote:
>
> > Hi Lee,
> >
> > ...
> >
> > > Subject: EXTERNAL: Re: (subset) [PATCH v1 1/
Hi Lee,
...
> Subject: EXTERNAL: Re: (subset) [PATCH v1 1/1] backlight: mp3309c: fix
> leds flickering in pwm mode
>
> [Use caution with links & attachments]
>
>
>
> On Thu, 02 May 2024, Lee Jones wrote:
>
> > On Wed, 17 Apr 2024 17:31:05 +0200, Flavi
58 matches
Mail list logo
