Re: [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6

2017-11-24 Thread Fabio Estevam
Hi Jan, On Thu, Nov 23, 2017 at 1:18 PM, Türk, Jan wrote: > Hi Fabio, > > I've used git send-email and tested the patches by checkpatch.pl before > without any problems. > So it might have been touched by the mail server, so can you send me your > checkpatch.pl log

Re: [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6

2017-11-23 Thread Fabio Estevam
t on emtrion Avari based development kits. > > Signed-off-by: Jan Tuerk <jan.tu...@emtrion.com> Please run ./scripts/checkpatch.pl on your patch. Currently it gives: total: 18 errors, 13 warnings, 39 lines checked Please fix and resend. Also, you could try git send-email in the next

[PATCH 3/7] drm/rockchip: dsi: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Heiko Stübner <he...@sntech.de> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/g

[PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- driv

[PATCH 4/7] drm/rockchip: inno_hdmi: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Heiko Stübner <he...@sntech.de> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- driver

[PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Inki Dae <inki@samsung.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- driv

[PATCH 6/7] drm/stm: ltdc: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Philippe Cornu <philippe.co...@st.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- d

[PATCH 7/7] drm/tegra: vic: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Thierry Reding <thierry.red...@gmail.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- dri

[PATCH 5/7] drm/stm: dsi: Remove unnecessary platform_get_resource() error check

2017-12-18 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Philippe Cornu <philippe.co...@st.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- d

Re: [PATCH v2 RESEND] display: panel: Add AUO g070vvn01 display support (800x480)

2018-05-09 Thread Fabio Estevam
Hi Lukasz, On Wed, May 9, 2018 at 12:39 PM, Lukasz Majewski wrote: > +Example device-tree definition when connected to iMX6Q based board > + > + lcd_panel: lcd-panel { > + compatible = "auo,g070vvn01"; > + backlight = <_lcd>; > +

[PATCH v2] MAINTAINERS: drm: fsl-dcu: Update to Alison's NXP email address

2018-05-20 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> The freescale.com email domain is not valid anymore, so use the nxp.com domain instead. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- Changes since v1: - State that the fsl.com is not a valid domain anymore. MAINTAINERS |

[PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier

2018-05-20 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

Re: [PATCH] drm/mxsfb: rename driver to mxsfb-drm

2018-06-12 Thread Fabio Estevam
Agner Yes, this driver name collision is annoying: Reviewed-by: Fabio Estevam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/mxsfb: rename driver to mxsfb-drm

2018-06-13 Thread Fabio Estevam
On Wed, Jun 13, 2018 at 9:38 AM, Stefan Agner wrote: > It seems to me a rather extreme measure though, given we could fix the > situation rather easily. There are dtb's using the fbdev mxsfb driver like for example: arch/arm/boot/dts/imx28-evk.dts If we kill the fbdev mxsfb driver then the

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-06-15 Thread Fabio Estevam
On Fri, Jun 15, 2018 at 5:58 PM, Leonard Crestez wrote: > In that thread there is a proposal for removing the old fbdev/mxsfb > driver entirely. > > That would break old DTBs, isn't this generally considered bad? Also, > are we sure the removal of fbdev/mxsfb wouldn't lose any features? Yes, I

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-06-15 Thread Fabio Estevam
Hi Leonard, On Fri, Jun 15, 2018 at 4:43 PM, Leonard Crestez wrote: > The FBDEV driver uses the same name and both can't be registered at the > same time. Fix this by renaming the drm driver to mxsfb-drm > > Signed-off-by: Leonard Crestez Stefan sent the same patch a few days ago:

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-06-15 Thread Fabio Estevam
On Fri, Jun 15, 2018 at 6:36 PM, Marek Vasut wrote: > Having two drivers in the kernel with different set of bugs is always bad. Sure, but breaking dtb's is also bad. Can the mxsfb driver be modified to handle the old style bindings? The IPU drm driver is capable of handling both the old

[PATCH v4 1/2] drm/etnaviv: Check for platform_device_register_simple() failure

2018-06-27 Thread Fabio Estevam
From: Fabio Estevam platform_device_register_simple() may fail, so we should better check its return value and propagate it in the case of error. Cc: Fixes: 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node") Signed-off-by: Fabio Estevam --- Changes since v3:

[PATCH v4 2/2] drm/etnaviv: Fix driver unregistering

2018-06-27 Thread Fabio Estevam
From: Fabio Estevam Russell King reported: "When removing and reloading the etnaviv module, the following splat occurs: sysfs: cannot create duplicate filename '/devices/platform/etnaviv' CPU: 0 PID: 1471 Comm: modprobe Not tainted 4.17.0+ #1608 Hardware name: Marvell Dove (Cubox) Back

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

2018-06-27 Thread Fabio Estevam
Hi Lucas, On Wed, Jun 27, 2018 at 11:34 AM, Lucas Stach wrote: > When the hangcheck handler was replaced by the DRM scheduler timeout > handling we dropped the forward progress check, as this might allow > clients to hog the GPU for a long time with a big job. > > It turns out that even

Re: [PATCH v2] drm/etnaviv: Fix driver unregistering

2018-06-25 Thread Fabio Estevam
Hi Philipp, On Mon, Jun 25, 2018 at 5:02 AM, Philipp Zabel wrote: >> +static struct platform_device *etnaviv_drm; >> + >> static int __init etnaviv_init(void) >> { >> int ret; >> @@ -654,7 +656,8 @@ static int __init etnaviv_init(void) >> if (!of_device_is_available(np))

[PATCH v3 2/2] drm/etnaviv: Fix driver unregistering

2018-06-25 Thread Fabio Estevam
From: Fabio Estevam Russell King reported: "When removing and reloading the etnaviv module, the following splat occurs: sysfs: cannot create duplicate filename '/devices/platform/etnaviv' CPU: 0 PID: 1471 Comm: modprobe Not tainted 4.17.0+ #1608 Hardware name: Marvell Dove (Cubox) Back

[PATCH v3 1/2] drm/etnaviv: Check for platform_device_register_simple() failure

2018-06-25 Thread Fabio Estevam
From: Fabio Estevam platform_device_register_simple() may fail, so we should better check its return value and propagate it in the case of error. Cc: Fixes: 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node") Signed-off-by: Fabio Estevam --- Changes since v

Re: [BUG 4.17] reloading etnaviv module causes kernel warning

2018-06-23 Thread Fabio Estevam
Hi Russell, On Thu, Jun 21, 2018 at 7:23 AM, Russell King - ARM Linux wrote: > When removing and reloading the etnaviv module, the following splat > occurs: We are missing to call platform_device_unregister() in etnaviv_exit(). Calling platform_device_unregister() like in the patch from the

[PATCH] drm/etnaviv: Fix driver unregistering

2018-06-23 Thread Fabio Estevam
From: Fabio Estevam Russell King reported: "When removing and reloading the etnaviv module, the following splat occurs: sysfs: cannot create duplicate filename '/devices/platform/etnaviv' CPU: 0 PID: 1471 Comm: modprobe Not tainted 4.17.0+ #1608 Hardware name: Marvell Dove (Cubox) Back

Re: [BUG 4.17] reloading etnaviv module causes kernel warning

2018-06-23 Thread Fabio Estevam
On Sat, Jun 23, 2018 at 6:20 PM, Fabio Estevam wrote: > Hi Russell, > > On Thu, Jun 21, 2018 at 7:23 AM, Russell King - ARM Linux > wrote: >> When removing and reloading the etnaviv module, the following splat >> occurs: > > We are missing to call platform_devic

[PATCH v2] drm/etnaviv: Fix driver unregistering

2018-06-24 Thread Fabio Estevam
From: Fabio Estevam Russell King reported: "When removing and reloading the etnaviv module, the following splat occurs: sysfs: cannot create duplicate filename '/devices/platform/etnaviv' CPU: 0 PID: 1471 Comm: modprobe Not tainted 4.17.0+ #1608 Hardware name: Marvell Dove (Cubox) Back

Re: [PATCH] Add SPDX idenitifier and clarify license

2018-05-03 Thread Fabio Estevam
On Thu, May 3, 2018 at 12:48 PM, Dirk Hohndel wrote: > But if you do the same analysis for header files... > > hohndel@rrmbpvm:~/src/linux[VMware-license-cleanup] > $ git grep SPDX | grep \.h: | cut -d: -f2 | sort | grep ^// | wc > 5491098 14823 >

Re: [PATCH] Add SPDX idenitifier and clarify license

2018-05-03 Thread Fabio Estevam
On Wed, May 2, 2018 at 10:46 AM, Thomas Hellstrom wrote: > diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c > b/drivers/gpu/drm/ttm/ttm_agp_backend.c > index 7c2485fe88d8..ea4d59eb8966 100644 > --- a/drivers/gpu/drm/ttm/ttm_agp_backend.c > +++

[PATCH] drm/etnaviv: etnaviv_sched: Staticize functions when possible

2018-02-13 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> etnaviv_sched_dependency() and etnaviv_sched_run_job() are only used in this file, so make them static. This fixes the following sparse warnings: drivers/gpu/drm/etnaviv/etnaviv_sched.c:30:18: warning: symbol 'etnaviv_sched_depe

[PATCH 1/2] drm/imx: ipuv3-plane: Make functions static when possible

2018-02-13 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> ipu_plane_state_reset(), ipu_plane_duplicate_state() and ipu_plane_destroy_state() are only used in this file, so make them static. This fixes the following sparse warnings: drivers/gpu/drm/imx/ipuv3-plane.c:275:6: warning:

[PATCH 2/2] drm/imx: ipuv3-plane: Include "imx-drm.h" header file

2018-02-13 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> ipu_planes_assign_pre() prototype is in "imx-drm.h" header file, so include it to fix the following sparse warning: drivers/gpu/drm/imx/ipuv3-plane.c:729:5: warning: symbol 'ipu_planes_assign_pre' was not declared. Should it be sta

[PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-02-16 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> The cable_plugin member never receives an assignment, so it is always false, which causes hdmi_enable_overflow_interrupts() to never be called as per the logic below: if (hdmi->cable_plugin && h

[PATCH 2/2] drm/panel: seiko-43wvf1g: Add missing ">" character in author's email

2018-07-25 Thread Fabio Estevam
From: Fabio Estevam There is a missing ">" character in Marco's email. Fix it. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/

[PATCH 1/2] drm/panel: seiko-43wvf1g: Switch to SPDX identifier

2018-07-25 Thread Fabio Estevam
From: Fabio Estevam Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c

Re: [RFC] clk: imx6: Mark imx_clk_mux as glitchy by default

2018-08-21 Thread Fabio Estevam
s up to pll5 > * possibly glitchy muxing > * ipu_di_disable disables ipu1_di0 (and parents, up to pll5) Have you seen such glitch issue in practice with the LDB clocks? We have already taken care of it in these commits: commit 5d283b083800867dc329e6433576664bf0fc18d5 Author: Fabio Esteva

Re: [PATCH 1/2] drm/panel: Add support for Armadeus ST0700 Adapt

2018-07-17 Thread Fabio Estevam
+- compatible: "armadeus,st0700-adapt" Shouldn't this be named "santek,st0700i5y" instead? Santek is the vendor of the panel and st0700i5y is the model. Then you could add a "santek" entry in Documentation/devicetree/bindings/vendor-prefixes.txt. Regards, F

Re: [PATCH v2] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-15 Thread Fabio Estevam
ed. > > Signed-off-by: Leonard Crestez > Reviewed-by: Lucas Stach Reviewed-by: Fabio Estevam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/imx: Switch to SPDX identifier

2018-07-25 Thread Fabio Estevam
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 5 + drivers/gpu/drm/imx/imx-drm-core.c | 11 +-- drivers/gpu/drm/imx/imx-ldb.c | 10 +- drivers/gpu/drm

[PATCH RESEND 1/2] drm/panel: seiko-43wvf1g: Switch to SPDX identifier

2018-09-05 Thread Fabio Estevam
From: Fabio Estevam Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c

[PATCH RESEND 2/2] drm/panel: seiko-43wvf1g: Add missing ">" character in author's email

2018-09-05 Thread Fabio Estevam
From: Fabio Estevam There is a missing ">" character in Marco's email. Fix it. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/

Re: [PATCH] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-12 Thread Fabio Estevam
Hi Leonard, On Thu, Jul 12, 2018 at 10:37 AM, Leonard Crestez wrote: > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index a6bc21433839..49a56b4fd393 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -130,10 +130,30 @@ >

[PATCH] drm: dw-hdmi-i2s: Remove owner assignment from platform_driver

2018-03-15 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> platform_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/gp

Re: [PATCH] drm/etnaviv: init DMA ops for virtual master device

2018-03-09 Thread Fabio Estevam
Hi Russell, On Fri, Mar 9, 2018 at 8:34 AM, Russell King - ARM Linux wrote: > On Fri, Mar 09, 2018 at 12:20:59PM +0100, Lucas Stach wrote: >> All the DRM GEM dma-buf import/export operations are done through the >> virtual DRM master device. As this isn't instanciated from

Re: [PATCH] drm/bridge: dw-hdmi: Remove unused hdmi_enable_overflow_interrupts()

2018-03-14 Thread Fabio Estevam
Hi Laurent, On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Fabio, > > Thank you for the patch. > > On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote: >> From: Fabio Estevam <fabio.este...@nxp.com> &g

Re: [PATCH] drm: dw-hdmi-i2s: Remove owner assignment from platform_driver

2018-04-22 Thread Fabio Estevam
Andrzej/Archit, Any comments? On Thu, Mar 15, 2018 at 3:04 PM, Fabio Estevam <feste...@gmail.com> wrote: > From: Fabio Estevam <fabio.este...@nxp.com> > > platform_driver does not need to set the owner field, as this will > be populated by the driver core. > > Gener

Re: [PATCH] MAINTAINERS: drm: fsl-dcu: Update to NXP email address

2018-04-23 Thread Fabio Estevam
Hi Stefan, On Fri, Mar 30, 2018 at 2:10 PM, Fabio Estevam <feste...@gmail.com> wrote: > From: Fabio Estevam <fabio.este...@nxp.com> > > The freescale.com domain will stop working soon, so use > the nxp.com domain instead. > > Signed-off-by: Fabio

[PATCH] MAINTAINERS: drm: fsl-dcu: Update to NXP email address

2018-03-30 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> The freescale.com domain will stop working soon, so use the nxp.com domain instead. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

Re: [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc

2018-04-03 Thread Fabio Estevam
54 ("drm: imx: remove struct imx_drm_crtc and > imx_drm_crtc_helper_funcs") > > Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> ___ dri-devel mailing list dri-devel

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

2018-03-19 Thread Fabio Estevam
Hi Hans, On Mon, Mar 19, 2018 at 8:43 AM, Hans Verkuil wrote: > From: Hans Verkuil It seems the Subject line is missing some content? ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH v1 3/4] ARM: imx_v6_v7_defconfig: Select TOUCHSCREEN_GOODIX

2018-10-25 Thread Fabio Estevam
-by: Alex Gonzalez Reviewed-by: Fabio Estevam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 4/4] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller

2018-10-25 Thread Fabio Estevam
off-by: Alex Gonzalez Reviewed-by: Fabio Estevam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 2/4] ARM: dts: ccimx6ulsbcpro: Enable AUO G101EVN010 lcdif panel

2018-10-25 Thread Fabio Estevam
; @@ -24,6 +24,18 @@ > status = "okay"; > }; > > + panel { > + compatible = "auo,g101evn010", "simple-panel"; The "simple-panel" string could be dropped. Reviewed-by: Fabio Estevam > +

[PATCH] drm/imx: Switch to SPDX identifier

2018-09-28 Thread Fabio Estevam
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 5 + drivers/gpu/drm/imx/imx-drm-core.c | 11 +-- drivers/gpu/drm/imx/imx-ldb.c | 10 +- drivers/gpu/drm

Re: [PATCH] qcom-scm: Include header

2018-12-29 Thread Fabio Estevam
Hi Bjorn, On Fri, Dec 28, 2018 at 10:27 PM Bjorn Andersson wrote: > Sorry about that, I forgot that the header file is not covered by the > MAINTAINERS file. > > Your second patch looks good, but I'm hoping we can merge the upcoming > v3 of Amit's patch right after the merge window. It fixes

Re: [PATCH] qcom-scm: Include header

2019-01-14 Thread Fabio Estevam
Hi Chris, On Mon, Jan 14, 2019 at 5:54 PM Chris Healy wrote: > > Perhaps I am confused but it appears that this patch has already > landed upstream and got included in 5.0-rc2: The patch that Amit is referring is the following entry in MAINTAINERS file: +F: include/linux/qcom* so that the

[PATCH] qcom-scm: Include header

2018-12-26 Thread Fabio Estevam
x5") Signed-off-by: Fabio Estevam --- include/linux/qcom_scm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h index 06996ad4f2bc..ce5a476fd733 100644 --- a/include/linux/qcom_scm.h +++ b/include/linux/qcom_scm.h @@ -13,6 +13,7 @@ #ifndef _

Re: [PATCH 3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

2018-12-16 Thread Fabio Estevam
Hi Thierry, On Tue, Dec 4, 2018 at 2:57 PM Fabio Estevam wrote: > > Add support for the VXT VL050-8048NT-C01 800x480 panel to the > panel-simple driver. > > This panel is used on some boards manufactured by TechNexion, such as > imx7d-pico. > > Signed-off-by: Fabi

[PATCH 3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

2018-12-04 Thread Fabio Estevam
Add support for the VXT VL050-8048NT-C01 800x480 panel to the panel-simple driver. This panel is used on some boards manufactured by TechNexion, such as imx7d-pico. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27

[PATCH 2/3] dt-bindings: Add VXT VL050-8048NT-C01 panel bindings

2018-12-04 Thread Fabio Estevam
The VXT VL050-8048NT-C01 is a TFT LCD panel with a 800x480 resolution connected via 24 width parallel interface. Signed-off-by: Fabio Estevam --- .../devicetree/bindings/display/panel/vl050_8048nt_c01.txt | 12 1 file changed, 12 insertions(+) create mode 100644 Documentation

[PATCH 1/3] dt-bindings: Add vendor prefix for VXT Ltd

2018-12-04 Thread Fabio Estevam
VXT Ltd is a manufacturer of projected capacitive touch panel and display solutions: http://www.vxt.com.tw/ Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor

Re: [PATCH 08/10] drm/mxsfb: Update mxsfb to support LCD reset

2019-01-10 Thread Fabio Estevam
Hi Robert, On Thu, Jan 10, 2019 at 6:34 AM Robert Chiras wrote: > > The eLCDIF controller has control pin for the external LCD reset pin. > Add support for it and assert this pin in enable and de-assert it in > disable. > Also, correct the pm_runtime_enable call, since it was made too early in >

Re: [PATCH] qcom-scm: Include header

2018-12-28 Thread Fabio Estevam
On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam wrote: > > Andy, please pick up for inclusion in -rc > > Yes, it would be really nice if we could get this fix into 4.20-rc1 so > that imx_v6_v7_defconfig could be built. Ops, I meant 4.21-rc1 :-)

Re: [PATCH] qcom-scm: Include header

2018-12-28 Thread Fabio Estevam
Hi Bjorn, On Fri, Dec 28, 2018 at 5:31 PM Bjorn Andersson wrote: > > On Wed 26 Dec 04:06 PST 2018, Fabio Estevam wrote: > > > Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") > > the DRM_MSM symbol can be selected by SOC_IMX5 causing the fo

Re: [PATCH] qcom-scm: Include header

2018-12-28 Thread Fabio Estevam
Hi Bjorn, On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam wrote: > By the way, I just ran get_maintainers in this patch and linux-arm-msm > is not listed. Would you like to me to submit a patch like this to fix this problem? diff --git a/MAINTAINERS b/MAINTAINERS index 7a9804

Re: [PATCH] qcom-scm: Include header

2018-12-28 Thread Fabio Estevam
On Fri, Dec 28, 2018 at 5:56 PM Fabio Estevam wrote: > > Hi Bjorn, > > On Fri, Dec 28, 2018 at 5:52 PM Fabio Estevam wrote: > > > By the way, I just ran get_maintainers in this patch and linux-arm-msm > > is not listed. > > Would you like to me to submit a pa

Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-01-28 Thread Fabio Estevam
Hi Guido, On Fri, Jan 25, 2019 at 8:15 AM Guido Günther wrote: > +config PHY_MIXEL_MIPI_DPHY > + bool > + depends on OF > + select GENERIC_PHY > + select GENERIC_PHY_MIPI_DPHY > + default ARCH_MXC && ARM64 No need to force this selection for all i.MX8M boards, as

Re: [PATCH v4 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings

2019-03-25 Thread Fabio Estevam
On Mon, Mar 25, 2019 at 11:06 AM Guido Günther wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt > @@ -0,0 +1,18 @@ > +Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel > + > +Required properties: > +- compatible: should be

Re: [PATCH v2 3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

2019-04-01 Thread Fabio Estevam
Hi Thierry, On Mon, Feb 18, 2019 at 9:27 PM Fabio Estevam wrote: > > Add support for the VXT VL050-8048NT-C01 800x480 panel to the > panel-simple driver. > > This panel is used on some boards manufactured by TechNexion, such as > imx7d-pico. > > Reviewed-by: Otavio Salv

[PATCH v2 3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

2019-02-18 Thread Fabio Estevam
Add support for the VXT VL050-8048NT-C01 800x480 panel to the panel-simple driver. This panel is used on some boards manufactured by TechNexion, such as imx7d-pico. Reviewed-by: Otavio Salvador Reviewed-by: Sam Ravnborg Signed-off-by: Fabio Estevam --- Changes since v1: - Pass .flags

[PATCH v2 2/3] dt-bindings: Add VXT VL050-8048NT-C01 panel bindings

2019-02-18 Thread Fabio Estevam
The VXT VL050-8048NT-C01 is a TFT LCD panel with a 800x480 resolution connected via 24 width parallel interface. Reviewed-by: Otavio Salvador Reviewed-by: Rob Herring --- Changes since v1: - None .../bindings/display/panel/vl050_8048nt_c01.txt | 12 1 file changed, 12

[PATCH v2 1/3] dt-bindings: Add vendor prefix for VXT Ltd

2019-02-18 Thread Fabio Estevam
VXT Ltd is a manufacturer of projected capacitive touch panel and display solutions: http://www.vxt.com.tw/ Reviewed-by: Otavio Salvador Reviewed-by: Rob Herring Signed-off-by: Fabio Estevam --- Changes since v1: - None Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file

Re: [PATCH 3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

2019-01-24 Thread Fabio Estevam
Ping On Sun, Dec 16, 2018 at 10:39 PM Fabio Estevam wrote: > > Hi Thierry, > > On Tue, Dec 4, 2018 at 2:57 PM Fabio Estevam wrote: > > > > Add support for the VXT VL050-8048NT-C01 800x480 panel to the > > panel-simple driver. > > > > This panel is used

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-01 Thread Fabio Estevam
Hi Guido, Thanks for the respin. It looks better :-) On Fri, Feb 1, 2019 at 6:50 AM Guido Günther wrote: > +config PHY_MIXEL_MIPI_DPHY > + tristate "Mixel MIPI DSI PHY support" > + depends on OF > + select GENERIC_PHY > + select GENERIC_PHY_MIPI_DPHY Since you

[PATCH] drm/syncobj: Include the header

2019-05-27 Thread Fabio Estevam
The prototype for 'drm_timeout_abs_to_jiffies' is provided by the header. Include this header to fix the following sparse warning: drivers/gpu/drm/drm_syncobj.c:937:13: warning: symbol 'drm_timeout_abs_to_jiffies' was not declared. Should it be static? Signed-off-by: Fabio Estevam

[PATCH] drm/damage-helper: Use NULL instead of 0

2019-05-27 Thread Fabio Estevam
The 'clips' member is a pointer, so assign NULL instead of 0. This fixes the following sparse warning: drivers/gpu/drm/drm_damage_helper.c:289:31: warning: Using plain integer as NULL pointer Signed-off-by: Fabio Estevam --- drivers/gpu/drm/drm_damage_helper.c | 2 +- 1 file changed, 1

[PATCH] drm/etnaviv: Use devm_platform_ioremap_resource()

2019-06-05 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index

Re: dpms mode change with wayland on iMX.6

2019-06-05 Thread Fabio Estevam
On Mon, May 27, 2019 at 10:53 AM Pintu Agarwal wrote: > One more point: > Although it is having Kernel 3.10, but the DRM modules were upgraded > to Kernel 4.9.xx from mainline. > So, latest DRM changes are already applied. Please don't do this: just use a recent mainline kernel instead of

Re: [PATCH 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-14 Thread Fabio Estevam
On Fri, Jun 14, 2019 at 8:53 AM Robert Chiras wrote: > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > Signed-off-by: Robert Chiras > --- > .../bindings/display/panel/raydium,rm67191.txt | 42 > ++ > 1 file changed, 42 insertions(+) > create mode

Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-14 Thread Fabio Estevam
Hi Robert, On Fri, Jun 14, 2019 at 8:52 AM Robert Chiras wrote: > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > @@ -0,0 +1,730 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * i.MX drm driver - Raydium MIPI-DSI panel driver > + * > + * Copyright (C) 2017 NXP > + * >

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-14 Thread Fabio Estevam
On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras wrote: > The GPIO is active high, and the above sequence was received from the > panel vendor in the following form: > SET_RESET_PIN(1); > MDELAY(10); > SET_RESET_PIN(0); > MDELAY(5); > SET_RESET_PIN(1); >

[PATCH] drm/etnaviv: Use dev_info() instead of pr_info()

2019-06-11 Thread Fabio Estevam
dev_info() is more appropriate for printing error messages inside drivers, so switch to dev_info(). Signed-off-by: Fabio Estevam --- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv

[PATCH v2] drm/etnaviv: Use dev_info() instead of pr_info()

2019-06-11 Thread Fabio Estevam
dev_info() is more appropriate for printing _info level messages inside drivers, so switch to dev_info(). Signed-off-by: Fabio Estevam --- Changes since v1: - Adjust commit log to say "_info level" instead of "error" drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 14 +++---

Re: [PATCH v4 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-25 Thread Fabio Estevam
Hi Robert, On Tue, Jun 25, 2019 at 4:28 AM Robert Chiras wrote: > +static int rad_bl_get_brightness(struct backlight_device *bl) > +{ > + struct mipi_dsi_device *dsi = bl_get_data(bl); > + struct rad_panel *rad = mipi_dsi_get_drvdata(dsi); > + struct device *dev = >dev; > +

etnaviv: Possible circular lockingon i.MX6QP

2019-06-12 Thread Fabio Estevam
Hi, On a imx6qp-wandboard I get the warning below about a possible circular locking dependency running 5.1.9 built from imx_v6_v7_defconfig. Such warning does not happen on the imx6q or imx6solo variants of wandboard though. Any ideas? Thanks, Fabio Estevam ** (matchbox-panel:708): WARNING

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-19 Thread Fabio Estevam
Hi Robert, On Tue, Jun 18, 2019 at 10:33 AM Robert Chiras wrote: > +Optional properties: > +- reset-gpios: a GPIO spec for the RST_B GPIO pin > +- pinctrl-0phandle to the pin settings for the reset pin > +- width-mm:physical panel width [mm] > +- height-mm:

Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-19 Thread Fabio Estevam
On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras wrote: > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > @@ -0,0 +1,709 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * i.MX drm driver - Raydium MIPI-DSI panel driver Please remove the "i.MX drm driver" as there is

Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-19 Thread Fabio Estevam
Hi Robert, On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras wrote: > +static const struct display_timing rad_default_timing = { > + .pixelclock = { 6600, 13200, 13200 }, > + .hactive = { 1080, 1080, 1080 }, > + .hfront_porch = { 20, 20, 20 }, > + .hsync_len = {

Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-21 Thread Fabio Estevam
Hi Robert, On Thu, Jun 20, 2019 at 10:31 AM Robert Chiras wrote: > +fail: > + if (rad->reset) > + gpiod_set_value_cansleep(rad->reset, 1); gpiod_set_value_cansleep() can handle NULL, so no need for the if() check. > +static const struct display_timing rad_default_timing =

Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-21 Thread Fabio Estevam
Hi Robert, On Thu, Jun 20, 2019 at 10:32 AM Robert Chiras wrote: > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > Signed-off-by: Robert Chiras > Reviewed-by: Sam Ravnborg > --- > .../bindings/display/panel/raydium,rm67191.txt | 39 > ++ > 1 file

Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-21 Thread Fabio Estevam
Hi Robert, On Fri, Jun 21, 2019 at 11:16 AM Robert Chiras wrote: > From what I've seen in the schematics, the power lines on the DSI port > on all the i.MX8 cores are coming from a PMIC providing power for all > the peripherals. Since I didn't find a way to cut the power on a single >

Re: [EXT] Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-24 Thread Fabio Estevam
Hi Robert, On Mon, Jun 24, 2019 at 4:44 AM Robert Chiras wrote: > > You did not handle the "power" regulator. > There is no need for a power regulator. I am sure the panel requires power to be applied so that it can work :-) > > Can't you simply remove them? > The reset gpio pin is shared

Re: [PATCH] drm: etnaviv: avoid DMA API warning when importing buffers

2019-05-18 Thread Fabio Estevam
Hi Russell, On Sat, May 18, 2019 at 2:51 PM Russell King - ARM Linux admin wrote: > > Ping. This patch is present in Lucas' pull request: https://lists.freedesktop.org/archives/etnaviv/2019-May/002490.html ___ dri-devel mailing list

Re: [PATCH v11 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs

2019-05-24 Thread Fabio Estevam
PHY > driver. > > The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be > added once the necessary system controller bits are in via > mixel_dphy_devdata. > > Signed-off-by: Guido Günther > Co-developed-by: Robert Chiras > Signed-off-by: Robert Chiras &

[PATCH] video: fbdev: mxsfb: Remove driver

2019-05-20 Thread Fabio Estevam
There is a DRM version of the mxsfb driver for quite some time at drivers/gpu/drm/mxsfb/, so there is no need to keep maintaining the fbdev version any longer. Remove the fbdev mxsfb driver in favour of the DRM version. Signed-off-by: Fabio Estevam --- drivers/video/fbdev/Kconfig | 13

Re: [PATCH v2 1/3] dt-bindings: Add vendor prefix for VXT Ltd

2019-05-20 Thread Fabio Estevam
On Tue, Apr 23, 2019 at 8:03 AM Thierry Reding wrote: > > On Mon, Feb 18, 2019 at 09:27:04PM -0300, Fabio Estevam wrote: > > VXT Ltd is a manufacturer of projected capacitive touch panel > > and display solutions: http://www.vxt.com.tw/ > > > > Reviewed-by: Otavio

Re: [PATCH v9 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs

2019-04-30 Thread Fabio Estevam
Hi Guido, On Tue, Apr 30, 2019 at 11:40 AM Guido Günther wrote: > > This adds support for the Mixel DPHY as found on i.MX8 CPUs but since > this is an IP core it will likely be found on others in the future. So > instead of adding this to the nwl host driver make it a generic PHY > driver. > >

Re: [PATCH v10 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs

2019-05-07 Thread Fabio Estevam
> > The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be > added once the necessary system controller bits are in via > mixel_dphy_devdata. > > Signed-off-by: Guido Günther > Co-developed-by: Robert Chiras > Signed-off-by: Rob

Re: [PATCH v10 1/2] dt-bindings: phy: Add documentation for mixel dphy

2019-05-07 Thread Fabio Estevam
On Tue, May 7, 2019 at 4:47 AM Guido Günther wrote: > > Add support for the MIXEL DPHY IP as found on NXP's i.MX8MQ SoCs. > > Signed-off-by: Guido Günther > Reviewed-by: Sam Ravnborg > Reviewed-by: Rob Herring Reviewed-by: Fabio Estevam _

Re: [PATCH RE-RESEND 2/2] ARM: dts: opos6uldev: use OF graph to describe the display

2019-05-07 Thread Fabio Estevam
is not the case here. With such tag removed: Reviewed-by: Fabio Estevam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

<    1   2   3   4   5   6   >