Re: [PATCH v8 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-11-06 Thread Faith Ekstrand
Add SUBMIT_JOB_FRAG_CMD_DISABLE_PIXELMERGE flag > > Changes from v4: > - Remove CREATE_ZEROED flag for BO creation (all buffers are now > zeroed) Latest API is Reviewed-by: Faith Ekstrand I think we're good to begin the upstreaming process. ~Faith > Co-developed-by: Frank Binn

Re: [PATCH 3/3] drm/nouveau: exec: report max pushs through getparam

2023-09-27 Thread Faith Ekstrand
to report the maximum number of IBs > that can be pushed with a single DRM_IOCTL_NOUVEAU_EXEC implies that > all channels of a given device have the same ring size. There's a bunch of nouveau kernel details I don't know here but the interface looks good and I prefer it to a #define in the hea

Re: [PATCH 3/3] drm/nouveau: exec: report max pushs through getparam

2023-09-27 Thread Faith Ekstrand
On Thu, 2023-09-28 at 11:12 +1000, Dave Airlie wrote: > On Thu, 28 Sept 2023 at 07:55, Faith Ekstrand > wrote: > > > > On Wed, 2023-09-27 at 03:22 +0200, Danilo Krummrich wrote: > > > Report the maximum number of IBs that can be pushed with a single > >

Re: [PATCH v5 03/17] drm/imagination/uapi: Add PowerVR driver UAPI

2023-08-17 Thread Faith Ekstrand
On Wed, Aug 16, 2023 at 3:26 AM Sarah Walker wrote: > Add the UAPI implementation for the PowerVR driver. > > Changes from v4 : > - Remove CREATE_ZEROED flag for BO creation (all buffers are now zeroed) > > Co-developed-by: Frank Binns > Signed-off-by: Frank Binns > Co-developed-by: Boris

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Faith Ekstrand
On Mon, Aug 21, 2023 at 1:13 PM Christian König wrote: > Am 21.08.23 um 20:01 schrieb Danilo Krummrich: > > On 8/21/23 16:07, Christian König wrote: > >> Am 18.08.23 um 13:58 schrieb Danilo Krummrich: > >>> [SNIP] > I only see two possible outcomes: > 1. You return -EBUSY (or similar)

Re: [PATCH drm-misc-next] drm/nouveau: uapi: don't pass NO_PREFETCH flag implicitly

2023-08-22 Thread Faith Ekstrand
ma_push(chan, p->va, p->va_len, prefetch); > } > > ret = nouveau_fence_emit(fence, chan); > @@ -223,7 +225,14 @@ nouveau_exec_job_init(struct nouveau_exec_job **pjob, > { > struct nouveau_exec_job *job; > struct nouveau_job_args args =

Re: [PATCH drm-misc-next v2] drm/nouveau: uapi: don't pass NO_PREFETCH flag implicitly

2023-08-23 Thread Faith Ekstrand
icate the bit shift. > > While at it, fix up nv50_dma_push() as well, such that the caller > doesn't need to encode the NO_PREFETCH flag into the length parameter. > > Signed-off-by: Danilo Krummrich > Still Reviewed-by: Faith Ekstrand > --- > Changes in v2: > - dma:

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-22 Thread Faith Ekstrand
On Tue, Aug 22, 2023 at 4:51 AM Christian König wrote: > Am 21.08.23 um 21:46 schrieb Faith Ekstrand: > > On Mon, Aug 21, 2023 at 1:13 PM Christian König > wrote: > >> [SNIP] >> So as long as nobody from userspace comes and says we absolutely need to >> opti

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Faith Ekstrand
On Thu, 2023-03-09 at 15:04 +0900, Asahi Lina wrote: > On 08/03/2023 02.34, Björn Roy Baron wrote: > > > +    // SAFETY: This is just the ioctl > > > argument, which hopefully has the right type > > > +    // (we've done our best checking the > > >

Re: [PATCH RFC 03/18] rust: drm: file: Add File abstraction

2023-03-09 Thread Faith Ekstrand
On Tue, 2023-03-07 at 23:25 +0900, Asahi Lina wrote: > A DRM File is the DRM counterpart to a kernel file structure, > representing an open DRM file descriptor. Add a Rust abstraction to > allow drivers to implement their own File types that implement the > DriverFile trait. > > Signed-off-by:

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Faith Ekstrand
Jumping in here quick... (Sorry, I was out yesterday and was ignoring my e-mail on Tuesday so I could finally type some compiler code.) On Thu, 2023-03-09 at 18:14 +0900, Asahi Lina wrote: > On 09/03/2023 17.05, Christian König wrote: > > Am 09.03.23 um 07:30 schrieb Asahi Lina: > > > On

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-09 Thread Faith Ekstrand
On Thu, 2023-03-09 at 18:43 +0900, Asahi Lina wrote: > On 09/03/2023 17.42, Christian König wrote: > > Am 08.03.23 um 20:37 schrieb Asahi Lina: > > > On 09/03/2023 03.12, Christian König wrote: > > > > Am 08.03.23 um 18:32 schrieb Asahi Lina: > > > > > [SNIP] > > > > > Yes but... none of this

Re: [Intel-gfx] [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-19 Thread Faith Ekstrand
On Wed, Mar 8, 2023 at 9:54 AM Rob Clark wrote: > From: Rob Clark > > Add a new flag to let userspace provide a deadline as a hint for syncobj > and timeline waits. This gives a hint to the driver signaling the > backing fences about how soon userspace needs it to compete work, so it > can

Re: [PATCH RFC 03/18] rust: drm: file: Add File abstraction

2023-03-13 Thread Faith Ekstrand
On Fri, 2023-03-10 at 07:16 +0900, Asahi Lina wrote: > On 10/03/2023 06.16, Faith Ekstrand wrote: > > On Tue, 2023-03-07 at 23:25 +0900, Asahi Lina wrote: > > > A DRM File is the DRM counterpart to a kernel file structure, > > > representing an open DRM file descrip

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-13 Thread Faith Ekstrand
On Fri, 2023-03-10 at 18:58 +0900, Asahi Lina wrote: > On 10/03/2023 04.59, Faith Ekstrand wrote: > > On Thu, 2023-03-09 at 18:43 +0900, Asahi Lina wrote: > > > On 09/03/2023 17.42, Christian König wrote: > > > > Long story short: Don't do this! This is wh

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-31 Thread Faith Ekstrand
On Sun, Jul 30, 2023 at 10:30 PM Faith Ekstrand wrote: > > On Tue, Jul 25, 2023 at 5:48 PM Danilo Krummrich wrote: > >> On 7/25/23 18:43, Danilo Krummrich wrote: >> > On 7/25/23 18:16, Faith Ekstrand wrote: >> >> Thanks for the detailed write-up! That wou

Re: [PATCH] drm/nouveau: fixup the uapi header file.

2023-08-01 Thread Faith Ekstrand
On Tue, Aug 1, 2023 at 4:37 AM Karol Herbst wrote: > On Mon, Jul 31, 2023 at 9:16 PM Dave Airlie wrote: > > > > From: Dave Airlie > > > > nouveau > 10 years ago had a plan for new multiplexer inside a > multiplexer > > API using nvif. It never fully reached fruition, fast forward 10 years, > >

Re: [PATCH drm-misc-next v8 03/12] drm/nouveau: new VM_BIND uapi interfaces

2023-07-25 Thread Faith Ekstrand
On Mon, Jul 24, 2023 at 9:04 PM Danilo Krummrich wrote: > > > On 7/22/23 00:58, Faith Ekstrand wrote: > > > > On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich > <mailto:d...@redhat.com>> wrote: > > > > This commit provides the interfaces for the

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-25 Thread Faith Ekstrand
On Mon, Jul 24, 2023 at 9:04 PM Danilo Krummrich wrote: > On 7/22/23 17:12, Faith Ekstrand wrote: > > On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich > <mailto:d...@redhat.com>> wrote: > > > > This commit provides the implementation for the new uapi motiva

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-30 Thread Faith Ekstrand
On Tue, Jul 25, 2023 at 5:48 PM Danilo Krummrich wrote: > On 7/25/23 18:43, Danilo Krummrich wrote: > > On 7/25/23 18:16, Faith Ekstrand wrote: > >> Thanks for the detailed write-up! That would definitely explain it. If > >> I remember, I'll try to do a single-t

Re: [PATCH drm-misc-next v8 03/12] drm/nouveau: new VM_BIND uapi interfaces

2023-07-21 Thread Faith Ekstrand
On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich wrote: > This commit provides the interfaces for the new UAPI motivated by the > Vulkan API. It allows user mode drivers (UMDs) to: > > 1) Initialize a GPU virtual address (VA) space via the new >DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs can

Re: [PATCH drm-misc-next] drm/nouveau: sched: avoid job races between entities

2023-08-11 Thread Faith Ekstrand
U > +* scheduler instance, but a different scheduler entity, the GPU > + * scheduler does only wait for the particular job to be scheduled, > s/does only wait/only waits/ Reviewed-by: Faith Ekstrand +* rather than for the job to fully complete. This is due to the GPU &g

Re: [PATCH] nouveau: find the smallest page allocation to cover a buffer alloc.

2023-08-12 Thread Faith Ekstrand
tions from 2MB to 64k in lots of places. > > Fixes dEQP-VK.memory.allocation.basic.size_8KiB.forward.count_4000 > on my ampere/gsp system. > > Signed-off-by: Dave Airlie > Reviewed-by: Faith Ekstrand > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 5 +++-- > 1 file c

Re: [PATCH drm-misc-next v9 00/11] Nouveau VM_BIND UAPI & DRM GPUVA Manager (merged)

2023-08-03 Thread Faith Ekstrand
On Thu, Aug 3, 2023 at 4:45 PM Dave Airlie wrote: > On Fri, 4 Aug 2023 at 02:52, Danilo Krummrich wrote: > > > > This patch series provides a new UAPI for the Nouveau driver in order to > > support Vulkan features, such as sparse bindings and sparse residency. > > > > Now that Faith has

Re: [PATCH] drm/nouveau: fixup the uapi header file.

2023-08-03 Thread Faith Ekstrand
and calling ioctls, and > these 3 ioctls, getparam, channel alloc + free don't seem to be things > we'd want to use nvif for. > > Undeprecate and put them into the uapi header so we can just copy it > into mesa later. > > v2: use uapi types. > > Signed-off-by: Dave Airlie >

Re: [PATCH drm-misc-next v9 02/11] drm/nouveau: new VM_BIND uapi interfaces

2023-08-03 Thread Faith Ekstrand
_EXEC support > asynchronous processing with DRM syncobjs as synchronization mechanism. > > The default DRM_IOCTL_NOUVEAU_VM_BIND is synchronous processing, > DRM_IOCTL_NOUVEAU_EXEC supports asynchronous processing only. > > Co-authored-by: Dave Airlie > Signed-off-by: Danilo K

[PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()

2023-08-07 Thread Faith Ekstrand
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What we actually want is 0 flags which tells it to just try to find the fence and then return without waiting. Signed-off-by: Faith Ekstrand Fi

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-11 Thread Faith Ekstrand
On Mon, 2023-12-11 at 09:52 +0100, Boris Brezillon wrote: > Hi, > > On Sun, 10 Dec 2023 13:58:51 +0900 > Tatsuyuki Ishi wrote: > > > > On Dec 5, 2023, at 2:32, Boris Brezillon > > > wrote: > > > > > > Hello, > > > > > > This is the 3rd version of the kernel driver for Mali CSF-based > > >

Re: [PATCH v3] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-08 Thread Faith Ekstrand
On Wed, May 8, 2024 at 6:06 PM Mohamed Ahmed < mohamedahmedegypt2...@gmail.com> wrote: > Allows PTE kind and tile mode on BO create with VM_BIND, > and adds a GETPARAM to indicate this change. This is needed to support > modifiers in NVK and ensure correctness when dealing with the nouveau > GL

Re: [PATCH v4] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-05-09 Thread Faith Ekstrand
he nouveau > GL driver. > > The userspace modifiers implementation this is for can be found here: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24795 > > Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI") > Signed-off-by: Mohamed Ahmed >