Hi Liu,
On Tue, Jun 21, 2022 at 5:47 PM Liu Ying wrote:
> On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote:
> > The various Freescale i.MX8MP display bridges are only present on
> > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent
> >
93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel combiner
support")
Signed-off-by: Geert Uytterhoeven
---
Probably the remaining i.MX bridge drivers in
drivers/gpu/drm/bridge/Kconfig (e.g. DRM_FSL_LDB) should be moved here,
too?
---
drivers/gpu/drm/bridge/imx/Kconfig | 4
1 f
-bus-width"
> properties values.
>
> Note the DW APB SSI/AHB SSI driver currently doesn't support the
> enhanced SPI modes. So I am not sure whether the multi-lines Rx/Tx SPI
> bus indeed works for Canaan K210 AHB SSI controller. AFAICS from the
> DW APB SSI v4.01a manual the
operties:
> +"^.*@[0-9a-f]+$":
> + type: object
> + properties:
> +reg:
> + minimum: 0
> + maximum: 3
> +
> +spi-rx-bus-width:
> + const: 1
> +
> +spi-tx-bus-width:
> + const: 1
>
&g
initmem_freed was removed in v2.1.124, and the underlying issue was
fixed for good in commit 92b004d1aa9f367c ("video/logo: prevent use of
logos after they have been freed").
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/core/fbcon.c | 1 -
1 file changed, 1 deletion(-)
Hi Linus,
On Tue, Jun 7, 2022 at 8:15 PM Linus Torvalds
wrote:
> On Tue, Jun 7, 2022 at 3:23 AM Geert Uytterhoeven
> wrote:
> > These header files are heavy users of large constants lacking the "U"
> > suffix e.g.:
> >
> > #define NB_ADAPTER_ID__SUBS
tps://lore.kernel.org/r/cak8p3a0qrihbr_2fq7uz5w2jmljv7czfrrarcmmjohvndj3...@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talkin
Hi Thomas,
On Mon, May 30, 2022 at 9:47 AM Thomas Zimmermann wrote:
> first of all, thanks for looking at the patch.
Thank you, your patch series helped a lot.
> Am 28.05.22 um 22:17 schrieb Geert Uytterhoeven:
> > On Mon, Oct 14, 2019 at 4:05 PM Thomas Zimmermann
> > wrote
her way?
Thanks!
> + if (ret < 0)
> + return false;
> +
> + drm_mode_update_from_fb_var_screeninfo(adjusted_mode, _var);
> +
> return true;
> }
> EXPORT_SYMBOL(drm_fbconv_simple_display_pipe_mode_fixup);
igned-off-by: Tom Rix
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I
With sparse ("make C=2"), lots of
error: return expression in void function
messages are seen.
Fix this by removing the return statements to propagate void return
values.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
drivers/gpu/drm/
On Fri, May 20, 2022 at 2:40 PM Geert Uytterhoeven wrote:
> On Thu, May 19, 2022 at 8:48 AM Guenter Roeck wrote:
> > On 5/18/22 17:55, kernel test robot wrote:
> > > tree/branch:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g
PE ==
ISA_TYPE_ENEC) ? isa_rom_outb((val), (port)) : isa_outb((val),
(port)))
where isa_rom_outb() leads to rom_out_8() returning u8, while
isa_outb() leads to the out_8() that includes the cast to void.
So the best solution seems to be to add more "(void)" casts, to e.g.
rom_out_8()
able an entry for that device.
>
> Fixes: d1d511d516f7 ("drm: tiny: st7735r: Add support for Okaya RH128128T")
> Signed-off-by: Javier Martinez Canillas
Thanks for your patch!
We really need to fix this at the subsystem level.
Reviewed-by: Geert Uytterhoeven
> --- a/d
Convert the Silicon Image sii902x HDMI bridge Device Tree binding
documentation to json-schema.
Add missing sil,sii9022-cpi and sil,sii9022-tpi compatible values.
Signed-off-by: Geert Uytterhoeven
---
v3:
- Add comments clarifying CPI/TPI,
- Improve wording,
- Drop port@2,
- Add port
amp; MMU && PPC
>
> Does this build with !PCI?
>
> The driver uses some PCI functions, so it might possibly break with
> randconfig. I don't think there are practical !PCI PPC configurations.
IIRC, the first PowerMacs didn't have PCI.
Gr{oetje,eeting}s,
LDB bridge")
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index da3441830d46a584..146ab069838fe97a 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drive
kes (as seen in rcar_du_vsp.c) without any added value. Drop it.
>
> Reported-by: Biju Das
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux be
description: DSI 0
> > > > > + required:
> > > > > +- port@0
> > > > > +
> > > > > + - if:
> > > > > + properties:
> > > > > +compatible:
> > > > > +
cs Corporation
> *
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something
t; >
> > Having different port numbers for the common DSI0 output indeed complicates
> > matters ;-)
>
> But we could delete as per [1] for RZ/G2LC where it supports only DSI and [2]
> for RZ/G2UL where it supports only DPI, right?
>
> [1]
> https://github.com/renesas-rz/rz_linux-cip/blob/rz-5.10-cip1/arch/arm64/boot/dts/renesas/r9a07g044c2.dtsi#L24
>
> [2]
> https://github.com/renesas-rz/rz_linux-cip/blob/rz-5.10-cip1/arch/arm64/boot/dts/renesas/r9a07g043.dtsi#L1000
Yes we can. But as the internal hardware is the same, I think we
should keep the port numbers the same on RZ/G2L and RZ/G2LC.
For RZ/V2L, you probably want to treat it exactly the same as RZ/G2L,
i.e., the same port numbering.
For RZ/G2UL, you can use a different numbering, assuming no
family-specific compatible value is introduced.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
ports:
> + properties:
> +port@0:
> + description: DPAD 0
> +port@1:
> + description: DSI 0
> + required:
> +- port@0
> +- port@1
Having different port numbers for the common D
o four data lanes.
> +
> +allOf:
> + - $ref: /schemas/display/dsi-controller.yaml#
> +
> +properties:
> + compatible:
> +enum:
> + - renesas,rzg2l-mipi-dsi # RZ/G2L and RZ/V2L
Do you want to define SoC-specific compatible values, or can the
IP revision be read from
uot;, SSD1307_ID },
> + { "ssd1309", SSD1309_ID },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, ssd130x_spi_table);
I'm not sure about the need for this part, but as Mark provided his
Ac-ed--by, I assume it's correct.
The rest LGTM, so
Reviewe
Hi Javier,
On Wed, Apr 13, 2022 at 11:44 AM Javier Martinez Canillas
wrote:
> On 4/13/22 10:04, Geert Uytterhoeven wrote:
> > On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas
> > wrote:
> >> The Solomon SSD130x OLED displays can either have an I2C or
-by: Mark Brown
> Reviewed-by: Geert Uytterhoeven
> ---
>
> Changes in v3:
> - Add a comment to the properties required for SPI (Geert Uytterhoeven)
Thanks for the update!
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation
t; + - renesas,du-r9a07g044l # for RZ/G2L compatible DU
"renesas,du-r9a07g044"? Both RZ/G2L and RZ/G2LC have an LCDC.
I believe the lack of parallel data support on RZ/G2LC is just a
limitation of the package?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven
Hi Javier,
On Tue, Apr 12, 2022 at 10:01 AM Javier Martinez Canillas
wrote:
> On 4/12/22 09:16, Geert Uytterhoeven wrote:
> > On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas
> > wrote:
> >> The Solomon SSD130x OLED displays can either have an I2C or
Failed to allocate SPI transport
> data\n");
> +
> + t->spi = spi;
> +
> + t->dc = ssd130x_spi_get_dc(>dev);
> + if (IS_ERR(t->dc))
> + return PTR_ERR(t->dc);
This can be simplified (no need for the PTR_ERR(ERR_PTR(...) dance)
"Invalid SSD130x variant\n"));
> +
> + ssd130x->device_info = _variants[variant];
>
> if (ssd130x->device_info->page_mode_only)
> ssd130x->page_address_mode = 1;
With the above fixed:
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
stem or bus used to interface the devices.
>
> Signed-off-by: Javier Martinez Canillas
> Acked-by: Mark Brown
> ---
>
> (no changes since v1)
That's not really true ;-)
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- T
-by: Mark Brown
> ---
>
> Changes in v2:
> - Don't add compatible strings with an "-spi" suffix (Geert Uytterhoeven).
Thanks for the update!
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/displ
e device and can be matched by both I2C and SPI
> DRM drivers.
>
> Signed-off-by: Javier Martinez Canillas
> Acked-by: Mark Brown
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge.
Signed-off-by: YueHaibing
> > ---
>
> Indeed. All the DRM drivers that select DRM_GEM_SHMEM_HELPER depend on MMU.
That's very unfortunate. Is there no way around this?
Else fbdev can never be deprecated in favor of DRM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytt
- solomon,ssd1307fb-i2c
> + - solomon,ssd1309fb-i2c
Please drop the "-i2c" suffixes, too.
We already have plenty of IIO sensors and audio codecs using the
same compatible value for spi and i2c, cfr.
'git grep compatible -- "*-[si][p2][ic].c"'
Gr{oetje
to more deprecated
compatible values soon...
Oops, this is already commit 97a40c23cda5d64a ("dt-bindings:
display: ssd1307fb: Add entry for SINO WEALTH SH1106") in
drm-misc/for-linux-next...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux b
As of commit 0fe66f327c464943 ("fbdev/sh_mobile: remove
sh_mobile_lcdc_display_notify"), there is no longer a need for a foward
declaration of sh_mobile_lcdc_check_var().
Signed-off-by: Geert Uytterhoeven
---
drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 ---
1 file changed, 3 deletion
w if you think that makes sense and I can attempt to write a fix.
>
> I still think unregistering the platform_dev properly makes the most
That doesn't sound very driver-model-aware to me. The device is what
the driver binds to; it does not cease to exist.
> sense, and feels like the most
Hi Helge,
On Tue, Apr 5, 2022 at 8:34 AM Helge Deller wrote:
> On 4/4/22 13:46, Geert Uytterhoeven wrote:
> > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote:
> >> On 4/3/22 13:26, Zheyu Ma wrote:
> >>> I found a bug in the function i740fb_set_par().
> &g
Hi Kalle,
On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote:
> Geert Uytterhoeven writes:
> >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:
> >> error: case label does not reduce to an integer constant: => 3798:2,
> >> 3809:2
> &
;
> + if (!var->pixclock)
> + return -EINVAL;
> +
When passed an invalid value, .check_var() is supposed to
round up the invalid value to a valid value, if possible.
> /* Find appropriate format */
> rv = svga_match_format (s3fb_formats, var, N
/* Find appropriate format */
> rv = svga_match_format (arkfb_formats, var, NULL);
> if (rv < 0)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I
valid to a valid value, if possible.
> /* Find appropriate format */
> rv = svga_match_format (vt8623fb_formats, var, NULL);
> if (rv < 0)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m
2d4b8ea178f7fd038965e3cac7f30c3f09 ?
When passed an invalid value, .check_var() is supposed to
round up the invalid to a valid value, if possible.
Commit b36b242d4b8ea178 ("video: fbdev: asiliantfb: Error out if
'pixclock' equals zero") does not do that.
Gr{oetje,eeting}s,
On Mon, 4 Apr 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v5.18-rc1[1] compared to v5.17[2].
Summarized:
- build errors: +36/-15
- build warnings: +5/-38
Happy fixing! ;-)
Thanks to the linux-next team for providing the build service
() helper instead of open-coding the
same operation.
Update the comments accordingly.
Fixes: bcf8b616deb87941 ("drm/format-helper: Add
drm_fb_xrgb_to_mono_reversed()")
Signed-off-by: Geert Uytterhoeven
Acked-by: Javier Martinez Canillas
Reviewed-by: Andy Shevchenko
---
v2:
-
epaper driver, where this function originated.
Hence make this clear by renaming drm_fb_xrgb_to_mono_reversed() to
drm_fb_xrgb_to_mono(), and documenting the black/white pixel
mapping.
Fixes: bcf8b616deb87941 ("drm/format-helper: Add
drm_fb_xrgb_to_mono_reversed()")
Signed-off
a text console with 4x6, 7x14 and 8x8 fonts.
Thanks!
Geert Uytterhoeven (5):
drm/format-helper: Rename drm_fb_xrgb_to_mono_reversed()
drm/format-helper: Fix XRGB888 to monochrome conversion
drm/ssd130x: Fix rectangle updates
drm/ssd130x: Reduce temporary buffer sizes
drm/repaper
As the temporary buffer is no longer used to store 8-bit grayscale data,
its size can be reduced to the size needed to store the monochrome
bitmap data.
Fixes: 24c6bedefbe71de9 ("drm/repaper: Use format helper for xrgb to
monochrome conversion")
Signed-off-by: Geert Uytterhoeven
is aligned.
Fixes: a61732e808672cfa ("drm: Add driver for Solomon SSD130x OLED displays")
Signed-off-by: Geert Uytterhoeven
Acked-by: Javier Martinez Canillas
---
v2:
- Add Acked-by.
Note that instead of calling drm_fb_xrgb_to_mono() and transposing
the bitmap, the image data could be
for the part that is to be updated.
Pass dst_pitch to drm_fb_xrgb_to_mono(), as we have already
calculated it anyway.
Fixes: a61732e808672cfa ("drm: Add driver for Solomon SSD130x OLED displays")
Signed-off-by: Geert Uytterhoeven
Acked-by: Javier Martinez Canillas
---
v2:
- Add Acked
= HZ;
> +
> + /* initialize all the page lists one time */
> + for (i = 0; i < info->fix.smem_len; i += PAGE_SIZE) {
> + page = fb_deferred_io_page(info, i);
> + INIT_LIST_HEAD(>lru);
> + }
> }
> EXPORT_SYMBOL_GPL(fb_deferred_io_
Hi Andy,
On Tue, Mar 15, 2022 at 2:50 PM Andy Shevchenko
wrote:
> On Tue, Mar 15, 2022 at 12:07:06PM +0100, Geert Uytterhoeven wrote:
> > ssd130x_clear_screen() allocates a temporary buffer sized to hold one
> > byte per pixel, while it only needs to hold on
Hi Andy,
On Tue, Mar 15, 2022 at 2:33 PM Andy Shevchenko
wrote:
> On Tue, Mar 15, 2022 at 12:07:03PM +0100, Geert Uytterhoeven wrote:
> > There is no "reversed" handling in drm_fb_xrgb_to_mono_reversed():
> > the function just converts from color to grayscale, a
Hi Javier,
On Tue, Mar 15, 2022 at 1:32 PM Javier Martinez Canillas
wrote:
> On 3/15/22 12:07, Geert Uytterhoeven wrote:
> > ssd130x_clear_screen() allocates a temporary buffer sized to hold one
> > byte per pixel, while it only needs to hold one bit per pixel.
> >
>
Hi Javier,
On Tue, Mar 15, 2022 at 1:18 PM Javier Martinez Canillas
wrote:
> On 3/15/22 12:07, Geert Uytterhoeven wrote:
> > The conversion functions drm_fb_xrgb_to_mono() and
> > drm_fb_gray8_to_mono_line() do not behave correctly when the
> > horizontal boundaries
epaper driver, where this function originated.
Hence make this clear by renaming drm_fb_xrgb_to_mono_reversed() to
drm_fb_xrgb_to_mono(), and documenting the black/white pixel
mapping.
Fixes: bcf8b616deb87941 ("drm/format-helper: Add
drm_fb_xrgb_to_mono_reversed()")
Sig
for the part that is to be updated.
Pass dst_pitch to drm_fb_xrgb_to_mono_reversed(), as we have already
calculated it anyway.
Fixes: a61732e808672cfa ("drm: Add driver for Solomon SSD130x OLED displays")
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/solomon/ssd130x.c | 9 ++-
a text console with 7x14 and 8x8 fonts.
Thanks for your comments!
Geert Uytterhoeven (5):
drm/format-helper: Rename drm_fb_xrgb_to_mono_reversed()
drm/format-helper: Fix XRGB888 to monochrome conversion
drm: ssd130x: Fix rectangle updates
drm: ssd130x: Reduce temporary buffer sizes
is aligned.
Fixes: a61732e808672cfa ("drm: Add driver for Solomon SSD130x OLED displays")
Signed-off-by: Geert Uytterhoeven
---
Note that instead of calling drm_fb_xrgb_to_mono() and transposing
the bitmap, the image data could be converted to the transposed format
directly. However,
() helper instead of open-coding the
same operation.
Update the comments accordingly.
Fixes: bcf8b616deb87941 ("drm/format-helper: Add
drm_fb_xrgb_to_mono_reversed()")
Signed-off-by: Geert Uytterhoeven
---
I tried hard to fix this in small steps, but everything was no
in
As the temporary buffer is no longer used to store 8-bit grayscale data,
its size can be reduced to the size needed to store the monochrome
bitmap data.
Fixes: 24c6bedefbe71de9 ("drm/repaper: Use format helper for xrgb to
monochrome conversion")
Signed-off-by: Geert Uy
Hi Pekka,
On Tue, Mar 15, 2022 at 9:46 AM Pekka Paalanen wrote:
> On Tue, 15 Mar 2022 08:51:31 +0100
> Geert Uytterhoeven wrote:
> > On Tue, Mar 15, 2022 at 8:33 AM Pekka Paalanen wrote:
> > > On Tue, 15 Mar 2022 09:15:08 +1100 (AEDT)
> > > Finn Thain wrote:
>
On Tue, Mar 15, 2022 at 8:51 AM Geert Uytterhoeven wrote:
> > Also, when drm_fourcc.h is describing pixel formats, it needs to
> > consider only how a little-endian CPU accesses them. That's how pixel
> > data in memory is described. Display hardware plays no part in that.
>
Hi Pekka,
On Tue, Mar 15, 2022 at 8:33 AM Pekka Paalanen wrote:
> On Tue, 15 Mar 2022 09:15:08 +1100 (AEDT)
> Finn Thain wrote:
> > On Mon, 14 Mar 2022, Geert Uytterhoeven wrote:
> > > On Mon, Mar 14, 2022 at 4:05 PM Pekka Paalanen
> > > wrote:
> > &g
h line
> separately. The performance improvements in the original commit do not
> regress by this change.
>
> Signed-off-by: Thomas Zimmermann
Thanks for fixing! This was very valuable for hammering the bugs
out of ssd130xdrm and the xrgb888-to-mono conversion...
Tested-by: Geert U
Hi Pekka,
On Mon, Mar 14, 2022 at 4:05 PM Pekka Paalanen wrote:
> On Mon, 14 Mar 2022 14:30:18 +0100
> Geert Uytterhoeven wrote:
> > On Mon, Mar 7, 2022 at 9:53 PM Geert Uytterhoeven
> > wrote:
> > > Introduce fourcc codes for color-indexed frame buffer f
Hi Ilia,
On Mon, Mar 14, 2022 at 3:39 PM Ilia Mirkin wrote:
> On Mon, Mar 14, 2022 at 10:06 AM Geert Uytterhoeven
> wrote:
> > On Mon, Mar 14, 2022 at 2:44 PM Ilia Mirkin wrote:
> > > On Mon, Mar 14, 2022 at 9:07 AM Geert Uytterhoeven
> > > wrote:
> > >
Hi Ilia,
On Mon, Mar 14, 2022 at 2:44 PM Ilia Mirkin wrote:
> On Mon, Mar 14, 2022 at 9:07 AM Geert Uytterhoeven
> wrote:
> > On Tue, Mar 8, 2022 at 8:57 AM Geert Uytterhoeven
> > wrote:
> > > On Mon, Mar 7, 2022 at 10:23 PM Ilia Mirkin wrote:
> > > &g
;
> + if (gray8[y * width + x] >> 7)
> + byte |= BIT(7);
> + }
> + *mono++ = byte;
> + }
> +}
Gr{oetje,eeting}s,
Ge
On Mon, Mar 7, 2022 at 9:53 PM Geert Uytterhoeven wrote:
> Introduce fourcc codes for color-indexed frame buffer formats with two,
> four, and sixteen colors, and provide a mapping from bit per pixel and
> depth to fourcc codes.
>
> As the number of bits per pixel is less than ei
Hi Ilia,
On Tue, Mar 8, 2022 at 8:57 AM Geert Uytterhoeven wrote:
> On Mon, Mar 7, 2022 at 10:23 PM Ilia Mirkin wrote:
> > On Mon, Mar 7, 2022 at 3:53 PM Geert Uytterhoeven
> > wrote:
> > > diff --git a/tests/util/pattern.c b/tests/util/pattern.c
> > > index 9
Hi Thomas,
On Thu, Mar 10, 2022 at 8:22 PM Thomas Zimmermann wrote:
> Am 09.03.22 um 11:39 schrieb Geert Uytterhoeven:
> > On Wed, Mar 9, 2022 at 10:22 AM Marek Szyprowski
> > wrote:
> >> On 09.03.2022 09:22, Thomas Zimmermann wrote:
> >>> Am 08.03.
struct drm_rect *rect)
> +{
> + struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev);
> + void *vmap = map->vaddr; /* TODO: Use mapping abstraction properly */
> + int ret = 0;
> + u8 *buf = NULL;
> +
> + buf = kcalloc(fb->width, fb->height, GFP_KERNEL);
This bu
Hi Javier,
On Wed, Mar 9, 2022 at 2:10 PM Javier Martinez Canillas
wrote:
> On 3/7/22 21:52, Geert Uytterhoeven wrote:
> > Add support for color-indexed frame buffer formats with two, four, and
> > sixteen colors to the DRM framebuffer helper functions:
> > 1. Add support
Hi Javier,
On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas
wrote:
> On 3/8/22 17:30, Geert Uytterhoeven wrote:
> > Unfortunately a regression was introduced since your v3: printed
> > text is mirrored upside-down. I.e. "E" is rendered correctly, but "L&qu
display on my Adafruit
FeatherWing 128x32 OLED.
Tested-by: Geert Uytterhoeven
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people
640x480x32, linelength=2560
> 8<--- cut here ---
> Unable to handle kernel paging request at virtual address f0aac000
So support for images with offsets or widths that are not a multiple
of 8 got broken in cfb_imageblit(). Oops...
BTW, the various drawing routines used to set a bitmask i
On Tue, Mar 8, 2022 at 10:16 PM Lad Prabhakar
wrote:
> The Renesas RZ/V2L SoC (a.k.a R9A07G054) has a Bifrost Mali-G31 GPU,
> add a compatible string for it.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Biju Das
Reviewed-by: Geert Uytterhoeven
Gr
correctly, but "L"
turns into "Γ" (Greek Gamma).
I suspect something went wrong with the display initialization
sequence.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversation
start_offset = clip->x1 % 8;
> + end_len = clip->x2 % 8;
> +
> + vaddr += clip_offset(clip, fb->pitches[0], cpp);
> + for (y = 0; y < lines; y++) {
> + src32 = memcpy(src32, vaddr, len_src32);
> + drm_fb_xrgb_to_gray8_line(gray8, src
Hi Ilia,
On Mon, Mar 7, 2022 at 10:23 PM Ilia Mirkin wrote:
> On Mon, Mar 7, 2022 at 3:53 PM Geert Uytterhoeven
> wrote:
> > diff --git a/tests/util/pattern.c b/tests/util/pattern.c
> > index 953bf95492ee150c..42d75d700700dc3d 100644
> > --- a/tests/util/patter
refer to [1] for more information.
Thanks for your comments!
[1] "[PATCH v2 00/10] drm: Add support for low-color frame buffer formats"
https://lore.kernel.org/r/cover.1646683502.git.ge...@linux-m68k.org
Geert Uytterhoeven (2):
intel: Improve checks for big-endian
util: Fix 32 bp
not define __BIG_ENDIAN__, but does define
__mc68000__, so add a check for the latter,
- hppa{,64}-linux-gnu-gcc defines __BIG_ENDIAN__, and thus should work
out-of-the-box.
Signed-off-by: Geert Uytterhoeven
---
Untested due to lack of hardware.
---
intel/uthash.h | 2 +-
1 file changed, 1
fill
functions for 32-bit formats.
Signed-off-by: Geert Uytterhoeven
---
Works now with Linux' drm_fb_xrgb_to_rgb332_line(), which uses
le32_to_cpu() to read pixel values from memory.
---
tests/util/pattern.c | 30 +-
1 file changed, 21 insertions(+), 9 deletions
Traditionally, the first channel has been called the "red" channel, but
the fourcc values for single-channel "red" formats can also be used for
other light-on-dark displays, like grayscale.
Signed-off-by: Geert Uytterhoeven
---
RFC, as I have no immediate need for these f
Introduce fourcc codes for single-channel light-on-dark frame buffer
formats with two, four, and sixteen intensity levels.
As the number of bits per pixel is less than eight, these rely on proper
block handling for the calculation of bits per pixel and pitch.
Signed-off-by: Geert Uytterhoeven
than eight, some of these
formats rely on proper block handling for the calculation of bits per
pixel and pitch.
Signed-off-by: Geert Uytterhoeven
---
RFC, as I have no immediate need for these formats.
v2:
- Add rationale for adding new formats,
- Improve pixel descriptions,
- Add D[248
502.git.ge...@linux-m68k.org
Geert Uytterhoeven (3):
util: Optimize C8 SMPTE color LUT
drm_fourcc: Add DRM_FORMAT_C[124]
util: Add SMPTE pattern support for C4 format
include/drm/drm_fourcc.h | 5 ++-
tests/modetest/buffers.c | 15 +++
tests/modetest/modetest.c | 13 --
tests/uti
Add a helper to retrieve the actual number of bits per pixel for a
plane, taking into account the number of characters and pixels per
block for tiled formats.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Move up.
---
drivers/gpu/drm/drm_fourcc.c | 19 +++
include/drm
and pitch.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Improve pixel descriptions,
- Require depth to match bpp in drm_mode_legacy_fb_format(),
- Set .is_color_indexed flag.
---
drivers/gpu/drm/drm_fourcc.c | 21 +
include/uapi/drm/drm_fourcc.h | 5 -
2 files changed
Add a flag to struct drm_format_info to indicate if a format is
color-indexed, similar to the existing .is_yuv flag.
This way generic code and drivers can just check this flag, instead of
checking against a list of fourcc formats.
Signed-off-by: Geert Uytterhoeven
---
v2:
- New.
---
drivers
When userspace queries the properties of a frame buffer, the number of
bits per pixel is derived from the deprecated drm_format_info.cpp[]
field, which does not take into account block sizes.
Fix this by using the actual number of bits per pixel instead.
Signed-off-by: Geert Uytterhoeven
---
v2
-by: Geert Uytterhoeven
---
The linuxdoc comments say userspace can query the gamma size:
* drm_mode_gamma_set_ioctl - set the gamma table
*
* Set the gamma table of a CRTC to the one passed in by the user. Userspace can
* inquire the required gamma table size through drm_mode_gamma_get_ioctl
() accordingly.
Signed-off-by: Geert Uytterhoeven
---
tests/modetest/modetest.c | 2 +-
tests/util/pattern.c | 51 +--
tests/util/pattern.h | 2 +-
3 files changed, 29 insertions(+), 26 deletions(-)
diff --git a/tests/modetest/modetest.c b/tests/modetest
Add fourcc codes for color-indexed frame buffer formats with two, four,
and sixteen colors. Add support for creating buffers using these
formats.
Signed-off-by: Geert Uytterhoeven
---
include/drm/drm_fourcc.h | 5 -
tests/modetest/buffers.c | 15 +++
tests/util/format.c
to FB_VISUAL_PSEUDOCOLOR for all color-indexed
modes.
Signed-off-by: Geert Uytterhoeven
---
v2:
- Use drm_format_info_bpp() helper instead of deprecated .depth field
or format-dependent calculations,
- Use new .is_color_indexed field instead of checking against a list
of formats
The AFBC helpers derive the number of bits per pixel from the deprecated
drm_format_info.cpp[] field, which does not take into account block
sizes.
Fix this by using the actual number of bits per pixel instead.
Signed-off-by: Geert Uytterhoeven
---
RFC, as this code path was untested.
v2
re.kernel.org/r/cover.1646683737.git.ge...@linux-m68k.org
[3] "[PATCH RFC libdrm 0/2] Big-endian fixes"
https://lore.kernel.org/r/cover.1646684158.git.ge...@linux-m68k.org
Geert Uytterhoeven (10):
drm/fourcc: Add drm_format_info_bpp() helper
drm/fourcc: Add drm_format_info.is_color_i
pixel
instead.
Signed-off-by: Geert Uytterhoeven
Acked-by: Thomas Zimmermann
---
v2:
- Add Acked-by.
---
drivers/gpu/drm/drm_client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index ce45e380f4a2028f
901 - 1000 of 1755 matches
Mail list logo
