Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Hans Verkuil
On 05/04/2024 12:18, Wolfram Sang wrote: > Hello Easwar, > > On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Hans Verkuil
On 29/02/2024 20:47, Sebastian Wick wrote: > On Thu, Feb 22, 2024 at 07:14:07PM +0100, Maxime Ripard wrote: >> The i915 driver has a property to force the RGB range of an HDMI output. >> The vc4 driver then implemented the same property with the same >> semantics. KWin has support for it, and a PR

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-29 Thread Hans Verkuil
On 2/29/24 12:33, Paweł Anikiel wrote: > On Thu, Feb 29, 2024 at 9:02 AM Hans Verkuil wrote: >> >> On 28/02/2024 16:34, Paweł Anikiel wrote: >>> On Wed, Feb 28, 2024 at 12:25 PM Hans Verkuil >>> wrote: >>>> >>>> Hi Paweł, >>&g

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-29 Thread Hans Verkuil
On 28/02/2024 16:34, Paweł Anikiel wrote: > On Wed, Feb 28, 2024 at 12:25 PM Hans Verkuil > wrote: >> >> Hi Paweł, >> >> On 21/02/2024 17:02, Paweł Anikiel wrote: >>> Currently, .query_dv_timings() is defined as a video callback without >>> a pad

Re: [PATCH v2 2/9] media: Add Chameleon v3 framebuffer driver

2024-02-28 Thread Hans Verkuil
On 28/02/2024 16:08, Paweł Anikiel wrote: > Hi Hans, thanks for the review! > > On Wed, Feb 28, 2024 at 12:24 PM Hans Verkuil > wrote: >> >> Hi Paweł, >> >> On 21/02/2024 17:02, Paweł Anikiel wrote: >>> Add v4l2 driver for the Google Chameleon v3 f

Re: [PATCH v2 6/9] media: intel: Add Displayport RX IP driver

2024-02-28 Thread Hans Verkuil
On 21/02/2024 17:02, Paweł Anikiel wrote: > Add driver for the Intel DisplayPort RX FPGA IP > > Signed-off-by: Paweł Anikiel > --- > drivers/media/platform/intel/Kconfig | 12 + > drivers/media/platform/intel/Makefile |1 + > drivers/media/platform/intel/intel-dprx.c | 2176

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-28 Thread Hans Verkuil
Hi Paweł, On 21/02/2024 17:02, Paweł Anikiel wrote: > Currently, .query_dv_timings() is defined as a video callback without > a pad argument. This is a problem if the subdevice can have different > dv timings for each pad (e.g. a DisplayPort receiver with multiple > virtual channels). > > To

Re: [PATCH v2 2/9] media: Add Chameleon v3 framebuffer driver

2024-02-28 Thread Hans Verkuil
Hi Paweł, On 21/02/2024 17:02, Paweł Anikiel wrote: > Add v4l2 driver for the Google Chameleon v3 framebuffer device. This is just a video capture device, right? A framebuffer device is something that lives in drivers/video/fbdev. It is *very* confusing to see the term 'framebuffer' used in a

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-12 Thread Hans Verkuil
On 12/02/2024 16:49, Ville Syrjälä wrote: > On Mon, Feb 12, 2024 at 11:01:07AM +0100, Maxime Ripard wrote: >> On Fri, Feb 09, 2024 at 09:34:35PM +0100, Sebastian Wick wrote: >>> On Mon, Feb 05, 2024 at 10:39:38AM +0100, Maxime Ripard wrote: On Fri, Feb 02, 2024 at 06:37:52PM +0200, Ville

Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint()

2024-02-07 Thread Hans Verkuil
On 07/02/2024 14:51, Laurent Pinchart wrote: > On Wed, Feb 07, 2024 at 02:14:33PM +0100, Krzysztof Hałasa wrote: >> Hans, >> >> Hans Verkuil writes: >> >>> Ideally someone would have to actually test this, perhaps with one of those >>> Renesas boards

Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint()

2024-02-06 Thread Hans Verkuil
On 2/6/24 14:41, Laurent Pinchart wrote: > Hi Morimoto-san, > > (Adding Krzysztof Hałasa) > > Thank you for the patch. > > On Tue, Feb 06, 2024 at 02:55:27AM +, Kuninori Morimoto wrote: >> From DT point of view, in general, drivers should be asking for a >> specific port number because

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Hans Verkuil
On 02/02/2024 12:04, Jani Nikula wrote: > On Mon, 15 Jan 2024, Sebastian Wick wrote: >> On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: >>> The i915 driver has a property to force the RGB range of an HDMI output. >>> The vc4 driver then implemented the same property with the same

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-08 Thread Hans Verkuil
On 04/01/2024 21:05, Jeffrey Kardatzke wrote: > On Mon, Dec 11, 2023 at 3:05 AM Hans Verkuil wrote: >> >> On 06/12/2023 09:15, Yunfei Dong wrote: >>> From: Jeffrey Kardatzke >>> >>> Adds documentation for V4L2_MEMORY_FLAG_SECURE. >>> &

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2023-12-11 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Adds documentation for V4L2_MEMORY_FLAG_SECURE. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > --- > Documentation/userspace-api/media/v4l/buffer.rst | 8 +++- > 1 file changed, 7 insertions(+), 1

Re: [PATCH v3,03/21] v4l2: verify secure dmabufs are used in secure queue

2023-12-11 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Verfies in the dmabuf implementations that if the secure memory flag is Verfies -> Verifies > set for a queue that the dmabuf submitted to the queue is unmappable. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by:

Re: [PATCH v3,02/21] v4l2: handle secure memory flags in queue setup

2023-12-11 Thread Hans Verkuil
Hi Yunfei, Jeffrey, Some comments below: On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Validates the secure memory flags when setting up a queue and ensures > the queue has the proper capability. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > ---

Re: [PATCH v3,16/21] media: medkatek: vcodec: support one plane capture buffer

2023-12-06 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > The capture buffer has two planes for format MM21, but user space only > allocate secure memory for plane[0], and the size is Y data + uv data. > The driver need to support one plane decoder for svp mode. For a future v4: note the typo in the Subject

Re: [PATCH v4 00/45] drm/connector: Create HDMI Connector infrastructure

2023-11-28 Thread Hans Verkuil
ment > multiple output) and required more churn to cast between the > drm_connector and its subclass. The decision was thus to provide a set > of helper and to store the required variables in drm_connector and > drm_connector_state. This what has been implemented now. > >

Re: [PATCH 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-20 Thread Hans Verkuil
hat do not use these functions. > > Set the callbacks via macros. No functional changes. Makes sense, shall I pick up this patch? If you prefer to take it, then you can add: Reviewed-by: Hans Verkuil Regards, Hans > > Signed-off-by: Thomas Zimmermann > Cc: Andy Walls

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-06 Thread Hans Verkuil
On 06/11/2023 15:44, Maxime Ripard wrote: > Hi Hans, > > On Fri, Nov 03, 2023 at 10:05:18AM +0100, Hans Verkuil wrote: >> Hi Maxime, >> >> Thank you for posting v3, this time it runs fine on my RPi 4, thank you for >> fixing that. >> >&g

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-03 Thread Hans Verkuil
Hi Maxime, Thank you for posting v3, this time it runs fine on my RPi 4, thank you for fixing that. I'll start working on a conformity checker for this. I have a few remarks: On 31/10/2023 17:48, Maxime Ripard wrote: > There has been some discussions recently about the infoframes sent by >

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-19 Thread Hans Verkuil
Hi Maxime, On 19/10/2023 10:02, Maxime Ripard wrote: > Hi, > > On Wed, Oct 11, 2023 at 03:23:18PM +0200, Daniel Vetter wrote: >> On Mon, 6 Mar 2023 at 11:49, Maxime Ripard wrote: >>> >>> From: Dave Stevenson >>> >>> Copy Intel's "Broadcast RGB" property semantics to add manual override >>> of

Re: [PATCH RFC v2 00/37] drm/connector: Create HDMI Connector infrastructure

2023-09-21 Thread Hans Verkuil
can implement > multiple output) and required more churn to cast between the > drm_connector and its subclass. The decision was thus to provide a set > of helper and to store the required variables in drm_connector and > drm_connector_state. This what has been implemented now. > >

Re: [PATCH v5 00/14] add support MDP3 on MT8195 platform

2023-09-15 Thread Hans Verkuil
Hi Moudy, On 12/09/2023 09:57, Moudy Ho wrote: > Changes since v4: > - Rebase on v6.6-rc1 > - Remove any unnecessary DTS settings. > - Adjust the usage of MOD and clock in blending components. > > Changes since v3: > - Depend on : > [1]

Re: [PATCH v5 00/14] add support MDP3 on MT8195 platform

2023-09-15 Thread Hans Verkuil
On 12/09/2023 12:28, Chen-Yu Tsai wrote: > On Tue, Sep 12, 2023 at 5:43 PM AngeloGioacchino Del Regno > wrote: >> >> Il 12/09/23 11:37, Chen-Yu Tsai ha scritto: >>> On Tue, Sep 12, 2023 at 5:00 PM AngeloGioacchino Del Regno >>> wrote: Il 12/09/23 09:57, Moudy Ho ha scritto: >

Re: [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Hans Verkuil
k for merging via > drm-intel? That's fine, it makes sense to do that. If you need it, for this series: Acked-by: Hans Verkuil Regards, Hans > > Thanks, > Jani. > > >> >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++--- >>

Re: [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Hans Verkuil
On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-30 Thread Hans Verkuil
a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > v2: Fix the embarrashing build failures > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verkuil Regar

Re: [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [PATCH 5/6] drm/i915/cec: switch to setting physical address directly

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > Avoid parsing the EDID again for source physical address. Also gets rids > of a few remaining raw EDID usages. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verkuil Rega

Re: [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-30 Thread Hans Verkuil
's no need to pass the EDID at all, so aim for attach/detach going > forward. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++--- > include/drm/display/drm_dp_he

Re: [PATCH 3/6] drm/edid: parse source physical address

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > CEC needs the source physical address. Parsing it is trivial with the > existing EDID CEA DB infrastructure. > > Default to CEC_PHYS_ADDR_INVALID (0x) instead of 0 to cater for > easier CEC usage. > > Cc: Hans Ve

Re: [PATCH RFC 00/13] drm/connector: Create HDMI Connector infrastructure

2023-08-16 Thread Hans Verkuil
stored in a state (current bpc, format, RGB range selection, > etc.). > > Thus, I decided to create some generic subclass of drm_connector to > address HDMI connectors, with a bunch of helpers that will take care of > all the "HDMI Spec" related code. Scrambler setup is mi

Re: [v3] media: mediatek: vcodec: fix AV1 decoding on MT8188

2023-08-07 Thread Hans Verkuil
FYI: the v2 patch has already been merged, so I dropped this v3. On 03/08/2023 13:10, Xiaoyong Lu wrote: > Fix AV1 decoding failure when the iova is 36bit. > > Before this fix, the decoder was accessing incorrect addresses with 36bit > iova tile buffer, leading to iommu faults. > > Fixes:

Re: [PATCH v2 01/47] media/vivid: Use fbdev I/O helpers

2023-08-02 Thread Hans Verkuil
On 01/08/2023 18:54, Thomas Zimmermann wrote: > Hi > > Am 01.08.23 um 13:22 schrieb Hans Verkuil: >> On 01/08/2023 12:13, Thomas Zimmermann wrote: >>> Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer >>> for I/O memory. Sets the callbacks

Re: [PATCH v2 01/47] media/vivid: Use fbdev I/O helpers

2023-08-01 Thread Hans Verkuil
t the currently selected values, so there is > no functional change. > > v2: > * updated to use _IOMEM_ tokens > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Sam Ravnborg > Acked-by: Helge Deller > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > --- >

Re: [PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-18 Thread Hans Verkuil
up all occurrences of FBINFO_DEFAULT, the token will be removed. > > v2: > * fix commit message (Miguel) > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > --- > drivers/media/pc

Re: [v10] media: mediatek: vcodec: support stateless AV1 decoder

2023-05-26 Thread Hans Verkuil
On 14/04/2023 10:30, Xiaoyong Lu wrote: > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > > Signed-off-by: Xiaoyong Lu > Tested-by: Nicolas Dufresne > Reviewed-by: Nicolas Dufresne > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-05-26 Thread Hans Verkuil
Hi Arnaud, My apologies for the long delay in replying, it's been very, very busy lately. I hope I'll be able to be more responsive going forward. On 21/04/2023 18:58, Arnaud Vrac wrote: > Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit > : >> >> Hi Arnaud, >> >&

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-23 Thread Hans Verkuil
| 3 +- > include/linux/i2c.h | 3 +- > 5 files changed, 69 insertions(+), 37 deletions(-) For the media and adv7511 bits: Reviewed-by: Hans Verkuil Regards, Hans > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-21 Thread Hans Verkuil
Hi Arnaud, Some review comments below... On 4/18/23 20:10, Arnaud Vrac wrote: > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > and MSM8998. The hardware block can handle a single CEC logical address > and broadcast messages. > > Port the CEC driver from downstream

Re: [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: Add property for disabling CEC

2023-04-21 Thread Hans Verkuil
On 18/04/2023 23:41, Rob Herring wrote: > On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: >> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC >> implementation, some boards might prefer not to use it or even use >> software implementation instead. >> >> Add

Re: [PATCH v5 14/20] staging: media: tegra-video: move MIPI calibration calls from VI to CSI

2023-04-18 Thread Hans Verkuil
On 18/04/2023 10:07, Luca Ceresoli wrote: > Hi Hans, > > On Fri, 14 Apr 2023 17:51:34 +0200 > Hans Verkuil wrote: > >> Hi Luca, >> >> I just encountered an error in this patch, so I have rejected the PR I made. >> >> See below for the details: &

Re: [PATCH v5 14/20] staging: media: tegra-video: move MIPI calibration calls from VI to CSI

2023-04-14 Thread Hans Verkuil
Hi Luca, I just encountered an error in this patch, so I have rejected the PR I made. See below for the details: On 07/04/2023 15:38, Luca Ceresoli wrote: > The CSI module does not handle all the MIPI lane calibration procedure, > leaving a small part of it to the VI module. In doing this, >

Re: [PATCH v2 1/7] media: videobuf2: Don't assert held reservation lock for dma-buf mmapping

2023-04-12 Thread Hans Verkuil
Velikov > Signed-off-by: Dmitry Osipenko Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 --- > drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 --- > drivers/media/common/videobuf2/videobuf2-vmal

Re: [v9] media: mediatek: vcodec: support stateless AV1 decoder

2023-04-12 Thread Hans Verkuil
On 12/04/2023 14:22, Hans Verkuil wrote: > On 12/04/2023 05:30, Xiaoyong Lu wrote: >> Add mediatek av1 decoder linux driver which use the stateless API in >> MT8195. >> >> Signed-off-by: Xiaoyong Lu >> Tested-by: Nicolas Dufresne >> Reviewed-by: Nicolas D

Re: [v9] media: mediatek: vcodec: support stateless AV1 decoder

2023-04-12 Thread Hans Verkuil
On 12/04/2023 05:30, Xiaoyong Lu wrote: > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > > Signed-off-by: Xiaoyong Lu > Tested-by: Nicolas Dufresne > Reviewed-by: Nicolas Dufresne > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del

Re: [PATCH v5 00/20] Add Tegra20 parallel video input capture

2023-04-12 Thread Hans Verkuil
a-video: add a per-soc enable/disable op >>16. staging: media: tegra-video: move syncpt init/free to a per-soc op >>17. staging: media: tegra-video: add syncpts for Tegra20 to struct >> tegra_vi >>18. staging: media: tegra-video: add hooks for planar YUV and H/V flip >>

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Hans Verkuil
On 05/04/2023 10:31, Luca Ceresoli wrote: > Hi Laurent, > > On Wed, 5 Apr 2023 05:30:48 +0300 > Laurent Pinchart wrote: > >> Hi Luca, >> >> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: >>> On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verku

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, On 29/03/2023 13:16, Hans Verkuil wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this > patch. > The list of supported formats really has to be the intersection of what the > tegra > supports and what the sensor support

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, I finally found the time to test this series. It looks OK, except for this patch. The list of supported formats really has to be the intersection of what the tegra supports and what the sensor supports. Otherwise you would advertise pixelformats that cannot be used, and the

Re: [PATCH 01/12] gpu: host1x: Make host1x_client_unregister() return void

2023-03-27 Thread Hans Verkuil
-video/vi.c | 8 +--- > include/linux/host1x.h | 2 +- > 13 files changed, 15 insertions(+), 81 deletions(-) Acked-by: Hans Verkuil Regards, Hans > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index a67453cee883..bd108159

Re: [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture

2023-03-22 Thread Hans Verkuil
On 22/03/2023 10:14, Luca Ceresoli wrote: > Hello, > > On Thu, 9 Mar 2023 15:42:59 +0100 > Luca Ceresoli wrote: > >> TL;DR: Resending this series with Rob's review tag added. Now all DT >> patches have at least a reviewed-by tag from Rob or Krzysztof, all the >> driver patches have one from

Re: [PATCH v2 1/9] drm/vc4: Switch to container_of_const

2023-02-21 Thread Hans Verkuil
On 2/21/23 12:38, Maxime Ripard wrote: > Hi Hans, > > On Sat, Feb 18, 2023 at 11:45:04AM +0100, Hans Verkuil wrote: >>> diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c >>> index 86d629e45307..d0a00ed42cb0 100644 >>> --- a/drivers/gpu/dr

Re: [PATCH v2 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-02-21 Thread Hans Verkuil
On 2/20/23 16:23, Dave Stevenson wrote: > Hi Hans > > On Sat, 18 Feb 2023 at 11:33, Hans Verkuil wrote: >> >> Hi Maxime, Dave, >> >> On 26/01/2023 14:46, Maxime Ripard wrote: >>> From: Dave Stevenson >>> >>> Copy Intel's "Broadca

Re: [PATCH v2 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-02-18 Thread Hans Verkuil
Hi Maxime, Dave, On 26/01/2023 14:46, Maxime Ripard wrote: > From: Dave Stevenson > > Copy Intel's "Broadcast RGB" property semantics to add manual override > of the HDMI pixel range for monitors that don't abide by the content > of the AVI Infoframe. Do we have to copy that property as-is?

Re: [PATCH v2 1/9] drm/vc4: Switch to container_of_const

2023-02-18 Thread Hans Verkuil
Hi Maxime, On 26/01/2023 14:46, Maxime Ripard wrote: > container_of_const() allows to preserve the pointer constness and is > thus more flexible than inline functions. > > Let's switch all our instances of container_of() to > container_of_const(). > > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-02-18 Thread Hans Verkuil
On 07/02/2023 13:47, Pekka Paalanen wrote: > On Fri, 13 Jan 2023 11:24:07 -0500 > Harry Wentland wrote: > >> This patchset enables the DP and HDMI infoframe properties >> in amdgpu. >> >> The first two patches are not completely related to the rest. The >> first patch allows for

Re: [PATCH] drm/vc4: hdmi: make CEC adapter name unique

2023-01-23 Thread Hans Verkuil
On 20/01/2023 20:13, Maxime Ripard wrote: > Hi Hans, > > On Thu, Jan 19, 2023 at 10:02:19AM +0100, Hans Verkuil wrote: >> The bcm2711 has two HDMI outputs, each with their own CEC adapter. >> The CEC adapter name has to be unique, but it is currently >> hardcoded to &qu

Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-20 Thread Hans Verkuil
RGB format names to match the DRM's format names > - Updated RPF register field macros according to the comments For this series: Acked-by: Hans Verkuil Thanks, Hans > > Tomi > > Tomi Valkeinen (7): > media: Add 2-10-10-10 RGB formats > media: Add Y210,

[PATCH] drm/vc4: hdmi: make CEC adapter name unique

2023-01-19 Thread Hans Verkuil
The bcm2711 has two HDMI outputs, each with their own CEC adapter. The CEC adapter name has to be unique, but it is currently hardcoded to "vc4" for both outputs. Change this to use the card_name from the variant information in order to make the adapter name unique. Signed-off-by: Ha

Re: [PATCH 20/22] media: remove sh_vou

2023-01-13 Thread Hans Verkuil
corresponding MAINTAINERS entry dropped, > > Reviewed-by: Laurent Pinchart And with that you can also add my Ack: Acked-by: Hans Verkuil Regards, Hans > >> 3 files changed, 1385 deletions(-) >> delete mode 100644 drivers/media/platform/renesas/sh_vou.c >

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-20 Thread Hans Verkuil
On 20/12/2022 10:18, Laurent Pinchart wrote: > Hello, > > On Tue, Dec 20, 2022 at 10:01:04AM +0100, Hans Verkuil wrote: >> On 19/12/2022 22:47, Laurent Pinchart wrote: >>> Hi Tomi, >>> >>> (CC'ing Sakari and Hans) >>> >>> Thank you for

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-20 Thread Hans Verkuil
On 20/12/2022 10:09, Geert Uytterhoeven wrote: > Hi Hans, > > On Tue, Dec 20, 2022 at 10:01 AM Hans Verkuil > wrote: >> On 19/12/2022 22:47, Laurent Pinchart wrote: >>> (CC'ing Sakari and Hans) >>> >>> Thank you for the patch. >>> >&g

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-20 Thread Hans Verkuil
On 19/12/2022 22:47, Laurent Pinchart wrote: > Hi Tomi, > > (CC'ing Sakari and Hans) > > Thank you for the patch. > > On Mon, Dec 19, 2022 at 04:01:39PM +0200, Tomi Valkeinen wrote: >> Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010 and Y210. >> >> Signed-off-by: Tomi Valkeinen >>

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-29 Thread Hans Verkuil
On 29/11/2022 09:48, David Hildenbrand wrote: > On 28.11.22 23:59, Andrew Morton wrote: >> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand >> wrote: >> Less chances of things going wrong that way. Just mention in the v2 cover letter that the first patch was added to make

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-28 Thread Hans Verkuil
On 28/11/2022 09:18, David Hildenbrand wrote: > On 28.11.22 09:17, Hans Verkuil wrote: >> Hi David, >> >> On 27/11/2022 11:35, David Hildenbrand wrote: >>> On 16.11.22 11:26, David Hildenbrand wrote: >>>> FOLL_FORCE is really only for ptrace access. Acc

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-28 Thread Hans Verkuil
ble"). Let's just remove it. >> >> Once the read-only buffer issue has been resolved, FOLL_WRITE could >> again be set depending on the DMA direction. >> >> Cc: Hans Verkuil >> Cc: Marek Szyprowski >> Cc: Tomasz Figa >> Cc: Marek Sz

Re: [RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-11-24 Thread Hans Verkuil
b\ :sub:`0` > +* .. _MEDIA_BUS_FMT_RGB565_1X24_CPADHI: > + > + - MEDIA_BUS_FMT_RGB565_1X24_CPADHI > + - 0x101e Given the latest media tree this is now 0x1022. Otherwise: Acked-by: Hans Verkuil It's an old series by now, but as far as I am concerned this can go through t

Re: [RESEND 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-11-24 Thread Hans Verkuil
this 0x1022, based on the latest media tree. > #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005 > #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 Otherwise: Acked-by: Hans Verkuil It's an old series by now, but as far

Re: [PATCH 00/23] Add Tegra20 parallel video input capture

2022-11-24 Thread Hans Verkuil
Hi Luca, On 09/11/2022 15:18, luca.ceres...@bootlin.com wrote: > From: Luca Ceresoli > > Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can > receive from either MIPI CSI-2 or parallel video (called respectively "CSI" > and "VIP" in the documentation). The kernel currently

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-23 Thread Hans Verkuil
On 23/11/2022 14:26, Hans Verkuil wrote: > Hi David, Tomasz, > > On 16/11/2022 11:26, David Hildenbrand wrote: >> FOLL_FORCE is really only for ptrace access. According to commit >> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >&

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-23 Thread Hans Verkuil
gacy leftover as it predates > commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are > always writable"). Let's just remove it. > > Once the read-only buffer issue has been resolved, FOLL_WRITE could > again be set depending on the DMA direction. > >

Re: [PATCH mm-unstable v1 15/20] media: pci/ivtv: remove FOLL_FORCE usage

2022-11-23 Thread Hans Verkuil
reason to allow arbitrary drivers to R/O pin pages in a PROT_NONE > VMA. Most probably, FOLL_FORCE usage is just some legacy leftover. I'm pretty sure about that as well, so: Acked-by: Hans Verkuil Regards, Hans > > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Si

Re: [PATCH mm-unstable v1 13/20] media: videobuf-dma-sg: remove FOLL_FORCE usage

2022-11-23 Thread Hans Verkuil
; > Cc: Mauro Carvalho Chehab > Signed-off-by: David Hildenbrand Acked-by: Hans Verkuil Looks good! Hans > --- > drivers/media/v4l2-core/videobuf-dma-sg.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/v4l2-

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
On 11/22/22 13:38, David Hildenbrand wrote: > On 22.11.22 13:25, Hans Verkuil wrote: >> Hi Tomasz, David, >> >> On 11/8/22 05:45, Tomasz Figa wrote: >>> Hi David, >>> >>> On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: >>>> &

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
rt > read-only pages as hardware input after. That said, FOLL_FORCE doesn't > sound like the right thing even in that case, but I don't know the > background behind it being added here in the first place. +Hans > Verkuil +Marek Szyprowski do you happen to remember anything about it? I tracked

Re: [PATCH 3/3] media: videobuf2: set dma_coherent flag for DMA-buf

2022-11-04 Thread Hans Verkuil
into coherency problems. Looks reasonable. For this series: Acked-by: Hans Verkuil Regards, Hans > > Signed-off-by: Christian König > --- > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 2 ++ > drivers/media/common/videobuf2/videobuf2-dma-sg.c

Re: [PATCH v5] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-11-04 Thread Hans Verkuil
Hi Mingjia, What are the changes since v4? You didn't mentioned that. Yunfei, can you review this v5? I prefer to have your Acked/Reviewed-by before merging. Regards, Hans On 25/10/2022 03:46, Mingjia Zhang wrote: > Enable VP9 inner racing mode > We send lat trans buffer to the core

Re: [PATCH v7 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare V4L2 memory allocators to the common dynamic dma-buf locking > convention by starting to use the unlocked versions of dma-buf API > functions. > > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Thanks! Hans > A

Re: [PATCH v7 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare Tegra video decoder driver to the common dynamic dma-buf > locking convention by starting to use the unlocked versions of dma-buf > API functions. > > Acked-by: Christian König Acked-by: Hans Verkuil Thanks! Han

Re: [PATCH, v2] media: mediatek: vcodec: Add to support VP9 inner racing mode

2022-08-24 Thread Hans Verkuil
Hi Mingjia, On 27/07/2022 08:13, Mingjia Zhang wrote: > In order to reduce decoder latency, enable VP9 inner racing mode. > Send lat trans buffer information to core when trigger lat to work, > need not to wait until lat decode done. > > Signed-off-by: mingjia zhang I'm getting this compile

Re: [PATCH v3 8/9] media: videobuf2: Stop using internal dma-buf lock

2022-08-24 Thread Hans Verkuil
Nice! Acked-by: Hans Verkuil Regards, Hans On 24/08/2022 12:22, Dmitry Osipenko wrote: > All drivers that use dma-bufs have been moved to the updated locking > specification and now dma-buf reservation is guaranteed to be locked > by importers during the mapping o

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Hans Verkuil
; > Signed-off-by: Uwe Kleine-König For all drivers under drivers/media and drivers/staging/media: Reviewed-by: Hans Verkuil Nice change! I like it. Hans > --- > Documentation/i2c/writing-clients.rst | 2 +- > arch/arm/mach-davinci/board-dm644x-evm.c

Re: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-06-29 Thread Hans Verkuil
ocate_buffer(fd_heap, DNN_CONF_BIN_ALLOC_SIZE); > fd_src = allocate_buffer(fd_heap, INPUT_IMG_ALLOC_SIZE); > fd_dst = allocate_buffer(fd_heap, OUTPUT_IMG_ALLOC_SIZE); > fd_temp = allocate_buffer(fd_heap, TEMP_BUF_ALLOC_SIZE); > > /* fill in input image and con

Re: [PATCH 1/4] media: mediatek: vcodec: Fix decoder v4l2 bus_info not correctly

2022-06-09 Thread Hans Verkuil
Hi Yunfei Dong, On 5/26/22 11:57, Yunfei Dong wrote: > Fix v4l2 capability bus_info value with correct chip name according to > compatible. > > Signed-off-by: Yunfei Dong > --- > .../platform/mediatek/vcodec/mtk_vcodec_dec.c | 23 ++- > 1 file changed, 22 insertions(+), 1

Re: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-05-20 Thread Hans Verkuil
here in Documentation. The first step is to have a better understanding of the Visconti image hardware and to see what the best subsystem would be to support that hardware. Regards, Hans > > Thanks, > Yuji Ishikawa > >> -----Original Message- >> From: Hans Ver

Re: [PATCH v6, 6/7] media: mediatek: vcodec: prevent kernel crash when scp ipi timeout

2022-05-18 Thread Hans Verkuil
On 5/18/22 13:29, yunfei.d...@mediatek.com wrote: > Dear Hans, > > Thanks for your review. > On Wed, 2022-05-18 at 11:37 +0200, Hans Verkuil wrote: >> Hi Yunfei, >> >> On 5/13/22 11:25, Yunfei Dong wrote: >>> When SCP timeout during playing video, kernel

Re: [PATCH v6, 6/7] media: mediatek: vcodec: prevent kernel crash when scp ipi timeout

2022-05-18 Thread Hans Verkuil
Hi Yunfei, On 5/13/22 11:25, Yunfei Dong wrote: > When SCP timeout during playing video, kernel crashes with following > message. It's caused by accessing NULL pointer in vpu_dec_ipi_handler. > This patch doesn't solve the root cause of NULL pointer, but merely > prevent kernel crashed when

Re: [PATCH v2 3/4] soc: visconti: Add Toshiba Visconti AFFINE image processing accelerator

2022-05-12 Thread Hans Verkuil
On 4/27/22 15:23, Yuji Ishikawa wrote: > Adds support to AFFINE image processing accelerator on Toshiba Visconti ARM > SoCs. > This accelerator supoorts affine transform, lens undistortion and LUT > transform. > > Signed-off-by: Yuji Ishikawa > Reviewed-by: Nobuhiro Iwamatsu > --- > v1 -> v2:

Re: [PATCH 0/4] Add Toshiba Visconti DNN image processing accelerator driver

2022-05-12 Thread Hans Verkuil
Hi Yuji, On 4/28/22 15:11, Yuji Ishikawa wrote: > This series is the DNN image processing accelerator driver for Toshiba's ARM > SoC, Visconti[0]. > This provides DT binding documentation, device driver, MAINTAINER files. > > The second patch "soc: visconti: Add Toshiba Visconti image

Re: [DKIM] [PATCH v12, 13/17] media: mediatek: vcodec: Extract H264 common code

2022-05-12 Thread Hans Verkuil
Hi Yunfei, On 5/12/22 04:19, Yunfei Dong wrote: > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. > > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas Dufresne > --- > .../media/platform/mediatek/vcodec/Makefile | 1 + >

Re: [PATCH v11, 13/17] media: mediatek: vcodec: Extract H264 common code

2022-05-09 Thread Hans Verkuil
Hi Yunfei, On 5/6/22 11:28, Yunfei Dong wrote: > Mt8192 can use some of common code with mt8183. Moves them to > a new file in order to reuse. > > Signed-off-by: Yunfei Dong > Reviewed-by: Nicolas Dufresne > --- > .../media/platform/mediatek/vcodec/Makefile | 1 + >

Re: [DKIM] [PATCH v10, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-29 Thread Hans Verkuil
Hi Yunfei, On 26/04/2022 12:08, Yunfei Dong wrote: > This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, > refactor > power/clock/interrupt interfaces for mt8192 is lat and core architecture. > > Secondly, add new functions to get frame buffer size and resolution

Re: [PATCH] media: mediatek: vcodec: Fix v4l2 compliance decoder cmd test fail

2022-04-21 Thread Hans Verkuil
On 06/04/2022 03:20, Yunfei Dong wrote: > Will return -EINVAL using standard framework api when test stateless > decoder with cmd VIDIOC_(TRY)DECODER_CMD. > > Using another return value to adjust v4l2 compliance test for user > driver(GStreamer/Chrome) won't use decoder cmd. > > Fixes:

Re: [PATCH 5/5] spi: make remove callback a void function

2022-02-19 Thread Hans Verkuil
; drivers/leds/leds-spi-byte.c | 4 +--- > drivers/media/spi/cxd2880-spi.c | 4 +--- > drivers/media/spi/gs1662.c| 4 +--- > drivers/media/tuners/msi001.c | 3 +-- A bit late, but for drivers/media: Acked-by: Hans Verkuil Thanks! Hans

Re: [PATCH v4] dma-buf-map: Rename to iosys-map

2022-02-08 Thread Hans Verkuil
| 6 +- > drivers/gpu/drm/vkms/vkms_plane.c | 2 +- > drivers/gpu/drm/vkms/vkms_writeback.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 7 +- > drivers/gpu/drm/xen/xen_drm_front_gem.h | 6 +- For these three: > .../common/videobuf2/videobuf2-dma-contig.c | 8 +- > .../media/common/videobuf2/videobuf2-dma-sg.c | 9 +- > .../common/videobuf2/videobuf2-vmalloc.c | 11 +- Acked-by: Hans Verkuil Regards, Hans

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-31 Thread Hans Verkuil
On 1/17/22 12:49, Matthias Brugger wrote: > > > On 17/01/2022 11:27, AngeloGioacchino Del Regno wrote: >> Il 17/01/22 08:04, Yong Wu ha scritto: >>> MediaTek IOMMU block diagram always like below: >>> >>> M4U >>>   | >>> smi-common >>>   | >>>    -

Re: [PATCH v9 12/15] media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm

2022-01-21 Thread Hans Verkuil
Hi Matthias, On 1/13/22 17:10, Matthias Brugger wrote: > Hi Hans, > > On 13/01/2022 11:15, Hans Verkuil wrote: >> On 13/01/2022 11:11, AngeloGioacchino Del Regno wrote: >>> Il 11/01/22 11:57, AngeloGioacchino Del Regno ha scritto: >>>> Il 12/11/21 11

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-17 Thread Hans Verkuil
Hi Matthias, On 1/17/22 12:49, Matthias Brugger wrote: > > > On 17/01/2022 11:27, AngeloGioacchino Del Regno wrote: >> Il 17/01/22 08:04, Yong Wu ha scritto: >>> MediaTek IOMMU block diagram always like below: >>> >>> M4U >>>   | >>> smi-common >>>   | >>>   

  1   2   3   4   5   6   7   8   9   10   >