[PATCH 24/29] drm/amd/dal: Add display core

display HW - dc_interrupt_set/ack - set and ack interrupts - etc. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/Makefile | 28 + drivers/gpu/drm/amd/dal/dc/core/dc.c | 932 +++ drivers/gpu/drm/amd/dal/dc/core

[PATCH 27/29] drm/amd/dal: Correctly interpret rotation as bit set

For sure. Thanks, Oded. I'll send out squashed patches later today. Harry On 2016-02-11 04:00 PM, Oded Gabbay wrote: > On Thu, Feb 11, 2016 at 7:20 PM, Harry Wentland > wrote: >> Signed-off-by: Harry Wentland >> Reviewed-by: Mykola Lysenko >> --- >> dri

[PATCH v2 00/26] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

of display dongles - Timing synchronization between DP and HDMI This patch series is based on Alex Deucher's drm-next-4.6-wip tree. Harry Wentland (26): drm/amd/dal: Add dal headers drm/amd/dal: Add DAL Basic Types and Logger drm/amd/dal: Fixed point arithmetic drm/amd/dal: Asic Capabilities drm

[PATCH v2 02/26] drm/amd/dal: Add DAL Basic Types and Logger

- Logging functionality This patch adds Kconfig options to enable the DAL display driver. - DRM_AMD_DAL - DRM_AMD_DAL_VBIOS_PRESENT - DRM_AMD_DAL_DCE11_0 - DRM_AMD_DAL_DCE10_0 - DEBUG_KERNEL_DAL Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/Kconfig

[PATCH v2 03/26] drm/amd/dal: Fixed point arithmetic

Arithmetic operations on real numbers represented as fixed-point numbers. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/basics/Makefile | 2 +- drivers/gpu/drm/amd/dal/dc/basics/fixpt31_32.c | 692 + drivers/gpu/drm/amd/dal

[PATCH v2 04/26] drm/amd/dal: Asic Capabilities

Add a generic way to manage display HW capabilities for different ASICs and implement it for Carrizo. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- .../gpu/drm/amd/dal/dc/asic_capability/Makefile| 35 .../amd/dal/dc/asic_capability/asic_capability.c | 190

[PATCH v2 05/26] drm/amd/dal: GPIO (General Purpose IO)

Manages all DCE GPIO pins. The pins are represented as generic IO handles as well as handles dedicated for certain functions, such as DDC, HPD, and DVO. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/gpio/Makefile | 32 + .../gpu/drm/amd/dal

[PATCH v2 08/26] drm/amd/dal: I2C Aux Manager

Implements low-level communication layer over I2C and Aux lines using GPIO handles. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/i2caux/Makefile | 33 + drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.c | 567 drivers/gpu/drm/amd

[PATCH v2 06/26] drm/amd/dal: Adapter Service

Provides information about ASIC features and capabilities. Also provides access to ASIC resources such as VBIOS, GPIO and I2cAux Manager Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/adapter/Makefile| 24 + .../gpu/drm/amd/dal/dc/adapter

[PATCH v2 09/26] drm/amd/dal: IRQ Service

Interface to set and ack DCE interrupts. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/irq/Makefile| 21 ++ .../drm/amd/dal/dc/irq/dce110/irq_service_dce110.c | 389 + .../drm/amd/dal/dc/irq/dce110/irq_service_dce110.h

[PATCH v2 10/26] drm/amd/dal: GPU

Encapsulates programming for HW blocks which are shared between display paths, such as clock sources. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/gpu/Makefile| 22 + .../gpu/drm/amd/dal/dc/gpu/dc_clock_generator.c| 92 ++ .../gpu/drm

[PATCH v2 11/26] drm/amd/dal: Audio

Responsible for programming the audio encoder in the display path. Signed-off-by: Harry Wentland Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/dal/dc/audio/Makefile | 22 + drivers/gpu/drm/amd/dal/dc/audio/audio.h | 195 ++ drivers/gpu/drm/amd/dal/dc/audio

[PATCH 2/2] drm/dp/mst: save vcpi with payloads

This makes it possibly for drivers to find the associated mst_port by looking at the payload allocation table. Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH 1/2] drm/dp/mst: reply with ACK for UP reqs

From: Mykola Lysenko Currently we reply with NACK to UP requests which might confuse receivers. We haven't seen any actual issues with this but should still respond to UP requests correctly. Signed-off-by: Mykola Lysenko --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-

[PATCH 0/2] Two small patches for MST

Two minor patches for MST here. We were replying NACK to UP requests when we intended to ACK them. We were also not filling in the vcpi field for mst_mgr->payloads although it's defined. Saving the vcpi simplifies the new amdgpu MST implementation that we currently work on. Harry Wentland

[PATCH] drm: Print pid in drm log

From: Andrey Grodzovsky Add task ids to all DRM prints so it is easier to resolve concurency issues and understand the logic. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/drm_drv.c | 16 +--- include/drm/drmP.h| 6 -- 2 files

[PATCH 0/2] Fix MST with downstream branches

Two MST patches that we discovered during MST bringup with two daisy-chained MST displays. Mykola Lysenko (2): drm/dp/mst: process broadcast messages correctly drm/dp/mst: always send reply for UP request drivers/gpu/drm/drm_dp_mst_topology.c | 125 ++

[PATCH 1/2] drm/dp/mst: process broadcast messages correctly

From: Mykola Lysenko In case broadcast message received in UP request, RAD cannot be used to identify message originator. Message should be parsed, originator should be found by GUID from parsed message. Also reply with broadcast in case broadcast message received (for

[PATCH 2/2] drm/dp/mst: always send reply for UP request

From: Mykola Lysenko We should always send reply for UP request in order to make downstream device clean-up resources appropriately. Issue was that reply for UP request was sent only once. Signed-off-by: Mykola Lysenko --- drivers/gpu/drm/drm_dp_mst_topology.c | 30

[PATCH 5/7] [RFC] drm/amdgpu: drop DVO encoders support.

DVO was mainly used for crossfire pre-DCE 8, and possibly on some DCE 8 (Tonga) SKUs as well. On newer ASICs crossfire uses XDMA so there's no longer a need for DVO. It's probably safe to drop it for amdgpu. Radeon driver might still want to keep it if there's support for it. Harry On

[PATCH] drm/dp/mst: Restore primary hub guid on resume

Patch makes sense to me. It looks like when the receiver detects an upstream disconnect it will reset its internal state, at least somewhat. We've seen that happen when system enters S3 and GPU loses power. Reviewed-by: Harry Wentland Harry On 2016-04-13 04:50 PM, Lyude wrote: > Some h

drm/amdgpu: start using graphics object ids from DAL.

Makes sense to me. Reviewed-by: Harry Wentland Harry On 2016-04-14 04:25 AM, Christian König wrote: > Am 14.04.2016 um 04:56 schrieb Dave Airlie: >> DAL has a concept of storing the graphics object ids in a special >> small struct, and adding type safety to them. >

Funky new vblank counter regressions in Linux 4.4-rc1

Hi Mario, when we've had issues with this on amdgpu Christian fixed it by enabling page flip irq all the time, rather than turning it on when usermode request a flip and turning it back off after we handled it. I believe that fix exists on radeon already. Michel should have more info on that.

Re: [PATCH] drm: simplify the locking in the GETCRTC ioctl

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-03-28 03:01 AM, Daniel Vetter wrote: No need to grab both plane and crtc locks at the same time, we can do them one after the other. If userspace races it'll get what it deserves either way. This removes anothe

Re: [PATCH 01/19] drm: Wire up proper acquire ctx for plane functions

On 2017-03-28 03:02 AM, Daniel Vetter wrote: On Tue, Mar 28, 2017 at 08:23:53AM +0200, Daniel Vetter wrote: On Mon, Mar 27, 2017 at 04:12:05PM -0400, Harry Wentland wrote: On Wednesday, March 22, 2017 10:50:40 PM EDT Daniel Vetter wrote: This is just prep work to get an acquire ctx

Re: [PATCH 01/19] drm: Wire up proper acquire ctx for plane functions

On Wednesday, March 22, 2017 10:50:40 PM EDT Daniel Vetter wrote: > This is just prep work to get an acquire ctx into every place where we > call ->update_plane or ->disable_plane. > > v2: Keep the hidden acquire_ctx pointers valid while transitioning. > > Signed-off-by: Daniel Vetter

Re: [PATCH 3/3] drm: document the all the atomic iterators

Patches 1-3 are Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-03-28 11:53 AM, Daniel Vetter wrote: Mostly because I want the links from the newly-added @state functions to work. But I think explaining when they're useful and that the implicit one is deprecated i

Re: [PATCH] drm: Clear e after kfree in drm_mode_page_flip_ioctl

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> On 2017-03-30 09:32 AM, Daniel Vetter wrote: With the explicit retry loop static analyzers get confused by the control flow and believe that e could be accessed after kfree. That's not possible, but it's non-obvious, so let's clear it t

Re: [PATCH] drm: Fix locking gotcha in page_flip ioctl

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-03-30 04:48 PM, Daniel Vetter wrote: We want to lock the primary plane, not the cursor (which might be optional). Real bad case of copy-paste fail, unfortunately our CI didn't catch that because i915 does have a cursor

Re: [PATCH] drm: Fixup failure paths in drm_atomic_helper_set_config

Of course. I totally missed that. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-03-29 01:41 PM, Daniel Vetter wrote: I've screwed this up when removing the legacy backoff hack. Fixes: 38b6441e4e75 ("drm/atomic-helper: Remove the backoff hack from set_config&

Re: [PATCH 13/19] drm: simplify the locking in the GETCRTC ioctl

On Wednesday, March 22, 2017 10:50:52 PM EDT Daniel Vetter wrote: > No need to grab both plane and crtc locks at the same time, we can do > them one after the other. If userspace races it'll get what it > deserves either way. > > This removes another user of drm_modeset_lock_crtc. There's only

Re: [PATCH 00/19] wire acquire ctx through legacy modeset paths

Patches 2-5, 9-12, 14-19: Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Patches 1,13: Questions in response to those patches Patches 6-8: Acked-by: Harry Wentland <harry.wentl...@amd.com> Looks like a nice cleanup. Harry On Wednesday, March 22, 2017 10:50:39 PM EDT Daniel

Re: [PATCH] drm: add check for plane functions

On 2017-03-17 03:55 AM, Shirish S wrote: update_plane() and disable_plane() functions assoiciated with setting plane are called without any check, causing kernel panic. This patch adds the required check to avoid it. Change-Id: I0d6792608b33e674c217388aa57c4b7d680d9bc7 Signed-off-by: Shirish S

Re: [PATCH libdrm] libdrm/amdgpu: add interface for kernel semaphores

On 2017-03-14 06:04 AM, zhoucm1 wrote: On 2017年03月14日 17:20, Christian König wrote: Am 14.03.2017 um 09:54 schrieb Daniel Vetter: On Tue, Mar 14, 2017 at 11:30:40AM +0800, zhoucm1 wrote: On 2017年03月14日 10:52, Dave Airlie wrote: On 14 March 2017 at 12:00, zhoucm1

Re: [PATCH] drm: Document code of conduct

d <kei...@keithp.com> Cc: tfh...@err.no Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry --- Documentation/gpu/introduction.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation

Re: Static inline DRM functions calling into GPL-only code

On 2017-04-11 11:15 AM, James Jones wrote: On 04/10/2017 11:20 PM, Daniel Vetter wrote: On Tue, Apr 11, 2017 at 7:52 AM, Daniel Vetter wrote: On Tue, Apr 11, 2017 at 6:14 AM, Nikhil Mahale wrote: My name is Nikhil Mahale, and I work at NVIDIA in the

Re: Static inline DRM functions calling into GPL-only code

On 2017-04-11 12:37 PM, James Jones wrote: On 04/11/2017 09:09 AM, Harry Wentland wrote: On 2017-04-11 11:15 AM, James Jones wrote: On 04/10/2017 11:20 PM, Daniel Vetter wrote: On Tue, Apr 11, 2017 at 7:52 AM, Daniel Vetter <dan...@ffwll.ch> wrote: On Tue, Apr 11, 2017 at 6:14 AM,

Re: [PATCH] drm/amdgpu: Fix a NULL deref in amdgpu_vm_add_prt_cb()

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-04-03 02:41 PM, Dan Carpenter wrote: We accidentally dereference "cb" if the kmalloc() fails. Fixes: 451bc8eb8fe6 ("drm/amdgpu: fix PRT teardown on VM fini v3") Signed-off-by: Dan Carpenter <da

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

Thanks, Christian for adding me. On 2017-04-21 09:27 AM, Christian König wrote: Adding Harry to this mail thread as well, cause is one of the people really affected by this. Christian. Am 21.04.2017 um 15:21 schrieb Christian König: Am 21.04.2017 um 15:12 schrieb Gerd Hoffmann: Hi,

Re: [PATCH] drm/edid: Add 10 bpc quirk for LGD 764 panel in HP zBook 17 G2

to get the full 10 bpc. Cc: sta...@vger.kernel.org Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_edid

Re: Pageflip fixes for the amd dal/dc staging tree.

, but that in a separate mail. Thanks for your extensive testing and the fixes. I'll let Andrey review this more thoroughly as he's spent quite a bit of time trying to get our flip/vblank model right. This series looks quite sensible to me, though, so feel free to add my Acked-by: Harry Wentland

Re: [PATCH] drm: add check for plane functions

On 2017-03-20 05:42 AM, Shirish S wrote: On Mon, Mar 20, 2017 at 1:51 PM, Daniel Vetter wrote: On Mon, Mar 20, 2017 at 09:58:01AM +0530, Shirish S wrote: First of all, thanks for your comments/insights. On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote:

Re: [PATCH v7 0/4] Adding driver-private objects to atomic state

Patches 1-3: Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Patch 4: Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-04-21 01:51 AM, Dhinakaran Pandiyan wrote: Changes in this version: Used connector->atomic_check() to release vcpi slots instead of the

Re: [PATCH v2 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

a Response Timeout period of 300us. > > This state is useful in a MST dock + MST monitor configuration that > doesn't wake up from D3 state. > > v2: Use spaces instead of tabs (Jani) > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by:

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland <harry.wentl...@amd.com> > wrote: > >> >> This is used and needed by the DC display driver. See >> display/amdgpu_dm/amdgpu_dm_services.c

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 09:35 AM, Ricardo Ribalda Delgado wrote: > amd_powerplay_display_configuration_change is never called. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 - >

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

by another one during suspend), > no hotplug event will be triggered so the change will not be caught at > resume time. Detecting that the EDID changed allows detecting it. > This makes sense and could be used by other drivers. Acked-by: Harry Wentland <harry.wentl...@amd.com>

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-26 09:47 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > > On Mon, Jul 24, 2017 at 5:45 PM, Harry Wentland <harry.wentl...@amd.com> > wrote: >> On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: >>> Hi Harry >>> On Mon, Jul 24, 20

Re: [PATCH 13/13] drm/atomic-helper: Realign function parameters

t; Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/drm_atomic_helper.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/driver

Re: Planned Vega support in Linux

Hi David, upstream kernels currently have only headless support. We're still working on getting our display driver accepted upstream but in the meantime you can compile it yourself from https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-4.12. With this you should have no issues booting to

Re: [PATCH] drm/amd/display: put commit when -ERESTARTSYS received

On 2017-08-16 01:22 PM, Daniel Vetter wrote: > On Wed, Aug 16, 2017 at 7:12 PM, Alex Deucher wrote: >> On Wed, Aug 16, 2017 at 10:22 AM, Jerry Zuo wrote: >>> During page flip atomic_check and atomic_commit can return >>> -ERESTARTSYS to restart the

Soliciting DRM feedback on latest DC rework

Hi all, Over the last few months we (mostly Andrey and myself) have taken and addressed some of the feedback received from December's DC RFC. A lot of our work so far centers around atomic. We were able to take a whole bunch of the areas where we rolled our own solution and use DRM atomic

Re: Soliciting DRM feedback on latest DC rework

objects to drm objects has been very eye-opening, to say the least. Daniel, do you think you'll find time to take a look at this this week or next? Harry -Daniel Regards, Christian. Am 03.05.2017 um 16:13 schrieb Harry Wentland: Hi all, Over the last few months we (mostly Andrey and myself

Re: [PATCH v2 0/3] drm/amd/display: add HDMI Stereo 3D support

Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-05-08 12:35 PM, Jeff Smith wrote: Changes: I have broken one patch into three. Note: this only covers the display (not amdgpu) portion and does not include the code to make it work over the card's DVI po

Re: Soliciting DRM feedback on latest DC rework

On 2017-05-09 04:24 AM, Daniel Vetter wrote: On Mon, May 08, 2017 at 02:54:22PM -0400, Harry Wentland wrote: Hi Daniel, Thanks for taking the time to look at DC. I had a couple more questions/comments in regard to the patch you posted on IRC: http://paste.debian.net/plain/930704 My

Re: [PATCH v2 0/3] drm/amd/display: add HDMI Stereo 3D support

On 2017-05-08 12:35 PM, Jeff Smith wrote: Changes: I have broken one patch into three. Note: this only covers the display (not amdgpu) portion and does not include the code to make it work over the card's DVI port. I only have one Stereo-3D-capable display to test this on, an LG TV from

Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

gt; > Fix: Protect against this issue by failing atomic_commit early in > drm_mode_atomic_commit where such probelm can be identified. > > v2: > Fix typos and extra newlines. > > Change-Id: I3ee28ffae35fd1e8bfe553146c44da53da02e6f8 > Signed-off-by: Andrey Grodzovsky <a

Re: [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

On 2017-06-09 05:30 PM, Andrey Grodzovsky wrote: > Problem: > While running IGT kms_atomic_transition test suite i encountered > a hang in drmHandleEvent immidietly follwoing an atomic_commit. s/immidietly/immediately/g s/follwoing/following/g > After dumping the atomic state I relized that in

Re: [kbuild-all] [radeon-alex:amd-staging-4.11 1061/1085] sparc64-linux-gnu-gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?

On 2017-05-16 05:56 AM, Christian König wrote: Am 16.05.2017 um 11:16 schrieb Michel Dänzer: [ Dropping build robot aliases, adding amd-gfx and DC folks ] On 16/05/17 05:18 PM, Philip Li wrote: On Tue, May 16, 2017 at 10:04:32AM +0200, Christian König wrote: Am 16.05.2017 um 07:20 schrieb

Re: Soliciting DRM feedback on latest DC rework

or(state, crtc, true); action = get_dm_commit_action(crtc_state); Good point. This code is still a bit of a mess. Harry On 2017-05-03 03:12 PM, Harry Wentland wrote: On 2017-05-03 11:02 AM, Daniel Vetter wrote: On Wed, May 03, 2017 at 04:26:51PM +0200, Christian König wrote: Hi Harry, whi

Re: Soliciting DRM feedback on latest DC rework

On 2017-05-08 03:07 PM, Dave Airlie wrote: On 9 May 2017 at 04:54, Harry Wentland <harry.wentl...@amd.com> wrote: Hi Daniel, Thanks for taking the time to look at DC. I had a couple more questions/comments in regard to the patch you posted on IRC: http://paste.debian.net/plain/9307

Re: [PATCH 2/6] drm/amd/display: Use new DRM API where possible

On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" > > To conform to DRM's new API, we should not be accessing a DRM object's > internal state directly. Rather, the DRM for_each_old/new_* iterators, > and drm_atomic_get_old/new_* interface should be

Re: [PATCH 0/6] Use new DRM API where possible, and cleanups.

Patches 3-6 are Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> > > Hi Dave, > > This series reworks the previous patch. Patch 1 is a v2 of t

Re: [PATCH v3 1/6] drm/amd/display: Use DRM new-style object iterators.

a new patch. > > v3: Say "functions considered" instead of "affected functions". The > latter implies that changes are made to each. > > Signed-off-by: Leo (Sunpeng) Li <sunpeng...@amd.com> Patches 1-2 (v3) are also Reviewed-by: Harry Wentland <har

Re: [PATCH 2/6] drm/amd/display: Use new DRM API where possible

On 2017-10-13 01:26 PM, Andrey Grodzovsky wrote: > > > On 10/13/2017 12:18 PM, Harry Wentland wrote: >> On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote: >>> From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> >>> >>> To conform to DRM's new A

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

rm/amd/dc: Add dc display driver (v2)") > CC: Harry Wentland <harry.wentl...@amd.com> > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > > gpio_service.c |2 +- > 1 file cha

Re: [PATCH] drm/amd/display: fix ifnullfree.cocci warnings

/coccinelle/free/ifnullfree.cocci > > Fixes: f09cd1f46388 ("drm/amd/display: Use kernel alloc/free") > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > > gpio_service.c |6 ++ >

Re: [PATCH] drm/amd: DC pull request review

On 2017-09-27 12:48 PM, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote: >> Any chance we can address the i2c/gpio [re-]implementations as well? > > It's already on the list. Part of this is code that's probably dead, > the other is a bit too much

Re: [PATCH] drm/amd: DC pull request review

On 2017-09-27 02:12 PM, Harry Wentland wrote: > On 2017-09-27 12:48 PM, Daniel Vetter wrote: >> On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul <seanp...@chromium.org> wrote: >>> Any chance we can address the i2c/gpio [re-]implementations as well? >> >> It's alrea

[PATCH 0/3] DC pull request cleanup

Patches to make DC use kzalloc/krealloc/kfree directly. Also updating the TODO list after a closer look at I2C in DC. Harry Wentland (3): drm/amd/display: Use kernel alloc/free drm/amd/display: Remove alloc/free macros drm/amd/display: DC I2C review drivers/gpu/drm/amd/display/TODO

[PATCH 1/3] drm/amd/display: Use kernel alloc/free

Abstractions are frowned upon. Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 --- drivers/gpu/drm/amd/display/dc/basics/vector.c | 19 +++ drivers/g

[PATCH 2/3] drm/amd/display: Remove alloc/free macros

Now that we don't abstract kernel alloc interfaces we don't need those anymore. Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/dc/dm_services.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h b/d

[PATCH 3/3] drm/amd/display: DC I2C review

functionality in DRM. If not we can propose something. 4) HDMI retimer programming Some boards have an HDMI retimer that we need to program to pass PHY compliance. 1 & 3 might be a good exercise if someone is looking for things to do. Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --

[PATCH] drm/amd/display: Remove DWB

It's not in a good shape and currently completely unused. Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/dc/core/dc.c | 9 - drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dwb.c

[PATCH v2] drm/amd/display: DC I2C review

functionality in DRM. If not we can propose something. 4) HDMI retimer programming Some boards have an HDMI retimer that we need to program to pass PHY compliance. 1 & 3 might be a good exercise if someone is looking for things to do. v2: Merge dp_dual_mode_adaptor TODO Signed-off-by: Harry Went

[PATCH v2] drm/amd/display: Use kernel alloc/free

) + kfree(ptr) v2: use GFP_KERNEL, not GFP_ATOMIC. add cocci script Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 --- drivers/gpu/drm/amd/display/dc/basics/ve

Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree

On 2017-08-29 09:12 AM, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd

Re: [PATCH] amdgpu/dc: Use DRM new-style object iterators.

On 2017-10-11 03:46 PM, Maarten Lankhorst wrote: > Op 11-10-17 om 20:55 schreef Leo: >> >> >> On 2017-10-11 10:30 AM, Maarten Lankhorst wrote: >>> Op 11-10-17 om 16:24 schreef sunpeng...@amd.com: From: "Leo (Sunpeng) Li" Use the correct for_each_new/old_*

Re: [PATCH] drm/amd: DC pull request review

to kernel coding style standards. But that's the point, > they're essentially gospel from hw engineers that happens to be > parseable by gcc. > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Thanks for the feedback, ack and help along the way. This patch is Reviewed-

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On 2017-10-18 04:10 AM, Daniel Vetter wrote: > On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote: >> On 17.10.2017 19:16, Daniel Vetter wrote: >>> On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: > On Tue,

Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

->base.state); > + if (!disconnected_acrtc) > + return; > > - if (!disconnected_acrtc || !acrtc_state->stream) > + acrtc_state = to_dm_crtc_state(disconnected_acrtc->base.state); > + if (

Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

driver (v2)") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. I got the same patch but was too slow to post. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 12 +++- >

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-04 08:08 AM, Arnd Bergmann wrote: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > >

Re: [PATCH] drm/amd/display: remove redundant null check of array 'data'

369 ("Array compared against 0") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 d

Re: [PATCH 2/4] drm: amd: Fix line continuation formats

> - "%s: Link Training Error, could not \ > - get CR after %d tries. \ > - Possibly voltage swing issue", __func__, > + "%s: Link Training Error, could not get CR after %d > tries. Possi

Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and_rotation

; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28 > +++--- > 1 file changed, 8 insertions(+), 20 deletions(-) > &

Re: [PATCH] drm/amd/display/dc/core/dc_resource: use swap macro in rect_swap_helper

; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/dri

Re: [PATCH] drm/amdgpu/virt: don't dereference undefined 'module' struct

e> Looks like 'str' isn't even used here. Either way, this change by itself is correct and Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/

Re: AMD, please run Smatch on your driver

Thanks, Dan, for bringing this to our attention. We (the display guys here) weren't aware of smatch and will give it a spin and try to address some of the remaining items (after your, Dave's, and Ernst's patches). Harry On 2017-11-06 06:34 AM, Dan Carpenter wrote: > Linux-next was offline for

Re: [PATCH 3/3] drm/amdgpu/display: fix integer arithmetic problem

arking the constant as explicitly unsigned makes it work fine everywhere > without warnings. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for these fixes. Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/dis

Re: [PATCH v2] drm/amdgpu/display: provide ASSERT macros unconditionally

ed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 4 > 1 file changed, 4 deletions(-) > > v2: remove accidtental comment change. > > diff --git a/drive

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-05 07:05 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 9:34 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >> On 2017-12-04 08:08 AM, Arnd Bergmann wrote: >>> Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y >>> and

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

On 2018-05-07 12:19 PM, Boris Brezillon wrote: > On Mon, 7 May 2018 18:01:44 +0300 > Ville Syrjälä wrote: > >> On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: >>> We have 3 drivers defining the "underscan", "underscan hborder" and >>> "underscan

Re: [PATCH v2 2/4] drm/dsc: Define Display Stream Compression PPS infoframe

On 2018-05-14 10:05 PM, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS infoframe syntax

Re: [PATCH v2 3/4] drm/dsc: Define VESA Display Stream Compression Capabilities

On 2018-05-14 10:05 PM, Manasi Navare wrote: > From: Gaurav K Singh > > This defines all the DSC parameters as per the VESA DSC spec > that will be required for DSC encoder/decoder > > v2: Define this struct in DRM (From Manasi) > * Changed the data types to u8/u16

Re: [PATCH v2 0/4] DRM helpers for Display Stream Compression PPS infoframes

l@lists.freedesktop.org > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> With my comments for patch 2 and 3 addressed patches 1-3 are Reviewed-by: Harry Wentland <har

Re: [PATCH 1/2] amdgpu: display: use modern ktime accessors

On 2018-06-18 11:35 AM, Arnd Bergmann wrote: > getrawmonotonic64() is deprecated because of the nonstandard naming. > > The replacement functions ktime_get_raw_ns() also simplifies the callers. > > Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH 2/3] drm: Print bad user modes

On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print out the modeline when we reject a bad user mode. Avoids having to > guess why it was rejected. > > Signed-off-by: Ville Syrjälä Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/

Re: [PATCH 1/3] drm/atomic: Improve debug messages

On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print the id/name of the object we're dealing with. Makes it easier to > figure out what's going on. Also toss in a few extra debug prints that > might be useful. > > Signed-off-by: Ville Syrjälä

Re: [PATCH] drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()

is painfully obvious from the fact that we missed that with the DC driver. That said, from a cursory look at runtime_pm.txt, this looks right. Reviewed-by: Harry Wentland I'll pull this in through the amd-stg tree. > --- > As a note, I'm not entirely happy with this fix and I wouldn'

<    1   2   3   4   5   6   7   8   9   10   >