Re: [PATCH] drm: actually remove the newline for CRC source name.

chen Zhang wrote: > 'n-1' is the index to replace the newline character of CRC source name. > Add here: v2: Update patch subject (Sam) > Cc: Leo Li > Cc: Harry Wentland > Signed-off-by: Dingchen Zhang > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file cha

Re: [PATCH 0/2] drm/amd/display: Add HDR output metadata support for amdgpu

ince that's all the > DRM interface supports. It requires a modeset for entering and exiting HDR > but the metadata can be changed without one. > > Cc: Harry Wentland > Series is Reviewed-by: Harry Wentland Harry > Nicholas Kazlauskas (2): > drm/amd/display: Expo

[PATCH] drm/amd/display: Use msleep instead of udelay for 8ms wait

arm32's udelay only allows values up to 2000 microseconds. msleep does the trick for us here as there is no problem if this isn't microsecond accurate and takes a tad longer. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

blems for Rockchip with the Analogix bridge. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_debugfs_crc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c > b/drivers/gpu/drm/drm_debugfs_crc.c > index e20adef9d6

2019 Xorg Election Results

this into account and forced voters to rank every candidate. Due to the lack of controversy about the candidates we don't expect this to have had any impact on the final results. Thanks, Harry Wentland, On behalf of the Xorg Elections Committee

Re: [PATCH] drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode

> Fixes: b5b1f4554904 ("drm/amd/display: Enable type C hotplug") > Reported-by: Randy Dunlap > Signed-off-by: Nathan Chancellor Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

On 2019-08-26 2:05 p.m., David Francis wrote: > Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not > support virtual DPCD registers, but do support DSC. > The DSC caps can be read from the physical aux, > like in SST DSC. These hubs have many different > DEVICE_IDs. Add a new quirk to detect this

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

every > device we care about and none we don't > - If a future Synaptics device supports virtual DPCD properly, we will check > for that first and never resort to the workaround (see patch 6/6) > - We don't know any of the properties of any hypothetical future Synaptics > hardware,

Re: [PATCH v8 1/6] drm/dp_mst: Add PBN calculation for DSC modes

xel, but > 1/16 of a bit per pixel > > v2: Don't add separate function for this > > Cc: amd-...@lists.freedesktop.org > Cc: nouv...@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org > Reviewed-by: Manasi Navare > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentla

Re: [PATCH v8 2/6] drm/dp_mst: Parse FEC capability on MST ports

2.11.9.4 of DP standard, > v1.4) > > That value is needed for FEC and DSC support > > Store it on drm_dp_mst_port > > Signed-off-by: David Francis > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++

Re: [PATCH v4 0/5] MST DSC support in drm-mst

On 2019-08-26 3:50 p.m., Dave Airlie wrote: > On Sat, 24 Aug 2019 at 06:24, Francis, David wrote: >> >> Adding DSC functionality to drm_dp_mst_atomic_check() is a good idea. >> However, until amdgpu switches over to that system, I wouldn't be able >> to test those changes. Making that switch is

Re: [PATCH v8 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

ix spacing > v3: Dump dpcd access on MST read/writes > > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > Signed-off-by: David Francis > --- > drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- > drivers/gpu/drm/drm_dp_helper.c | 30 --

Re: [PATCH v8 4/6] drm/dp_mst: Fill branch->num_ports

t; > v2: remember to decrement on port removal > v3: don't explicitly init to 0 > > Signed-off-by: David Francis > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ > 1 file changed, 2 inser

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

On 2019-08-26 2:05 p.m., David Francis wrote: > Add drm_dp_mst_dsc_aux_for_port. To enable DSC, the DSC_ENABLED > register might have to be written on the leaf port's DPCD, > its parent's DPCD, or the MST manager's DPCD. This function > finds the correct aux for the job. > > As part of this, add

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

On 2019-08-27 3:09 a.m., YueHaibing wrote: > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > there is no caller in tree. > > Reported-by: Hulk Robot Signed-off-by: YueHaibing > Reviewed-by: Harry Wentland Harry > --- > .../drm/

Re: [PATCH RESEND 03/14] drm/amdgpu: Provide ddc symlink in dm connector's sysfs directory

On 2019-08-26 3:25 p.m., Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- > 1 file changed,

Re: [PATCH V3] drm: Add LTTPR defines for DP 1.4a

> - Reorder LTTPR according to register offset > Changes since V1: > - Adjusts registers names to be aligned with spec and the rest of the > file > - Update spec comment from 1.4 to 1.4a > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Cc: Jani Nikula

Re: [PATCH] drm/drm_connector: add additional aspect ratio values

rm_aspect_ratio_enum_list. > Thereafter, one can specify the aspect ratio to "64:27" or "256:135" > after creating aspect ratio property.> > Change-Id: Ifc9df54e8e8f78e70960fcd737a3a57e49c81152 > Signed-off-by: Wayne Lin Drop the Change-Id. With that

Re: [PATCH V2] drm: Add LTTPR defines for DP 1.4a

ts registers names to be aligned with spec and the rest of the > file > - Update spec comment from 1.4 to 1.4a > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Signed-off-by: Rodrigo Siqueira > Signed-off-by: Abdoulaye Berthe Reviewed-by: Harry Wentland Harry

Re: [PATCH -next] drm/amdgpu/display: fix build error without CONFIG_DRM_AMD_DC_DSC_SUPPORT

> Use CONFIG_DRM_AMD_DC_DSC_SUPPORT to guard this. > > Reported-by: Hulk Robot > Fixes: 8a31820b1218 ("drm/amd/display: Make init_hw and init_pipes generic > for seamless boot") > Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry > --- > drivers/gp

Re: [PATCH][drm-next] drm/amd/display: fix a potential null pointer dereference

orming dereference after it is null checked. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 9adc8050bf3c ("drm/amd/display: make firmware info only load once > during dc_bios create") > Signed-off-by: Colin Ian King Reviewed-by: Harry Went

Re: [PATCH] drm: Add LTTPR defines for DP 1.4

On 2019-08-22 6:46 p.m., Siqueira, Rodrigo wrote: > DP 1.4 specification defines Link Training Tunable PHY Repeater (LTTPR) > which is required to add support for systems with Thunderbolt or other > repeater devices. > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc:

Re: linux-next: Tree for Sep 4 (amd/display/)

On 2019-09-04 4:58 p.m., Randy Dunlap wrote: > On 9/4/19 6:34 AM, Stephen Rothwell wrote: >> Hi all, >> >> News: this will be the last linux-next I will release until Sept 30. >> >> Changes since 20190903: >> > > on x86_64: > > In file included from >

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

V2: >> - Drop the kernel-doc comment >> - Reorder LTTPR according to register offset >> Changes since V1: >> - Adjusts registers names to be aligned with spec and the rest of the >> file >> - Update spec comment from 1.4 to 1.4a >> >> Cc: Abdou

Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration

/core/dc.c:75:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski Reviewed-by: Harry Wentland Harry > --- > Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com > > drivers/gpu/drm/amd/d

Re: [PATCH v2 1/3] drm/amd: be quiet when no SAD block is found

_bug.cgi?id=107825 > > Signed-off-by: Jean Delvare > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Harry Wentland > Cc: Leo Li Reviewed-by: Harry Wentland Harry > --

Re: [PATCH v7 04/11] drm: revocation check at drm subsystem

Adding a couple AMD guys. I know this is already merged but I have a few questions after some internal discussions. On 2019-05-07 12:27 p.m., Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > According to section 5 of

Re: HDCP Content Type Interface

On 2019-09-12 3:47 a.m., Ramalingam C wrote: > On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >> Hi all, >> >> This is regarding the recent hdcp content type patch that was merged into >> drm-misc. >> (https://patchwork.freedesktop.org/patch/320958/?series=57233=11) >> >> There are

Re: [PATCH v7 04/11] drm: revocation check at drm subsystem

On 2019-09-12 2:54 a.m., Ramalingam C wrote: > On 2019-09-12 at 00:15:32 +0000, Harry Wentland wrote: >> Adding a couple AMD guys. >> >> I know this is already merged but I have a few questions after some >> internal discussions. >> >> On 2019-05-07 12:27

Re: HDCP Content Type Interface

On 2019-09-12 10:49 a.m., Ramalingam C wrote: > On 2019-09-12 at 14:23:05 +0000, Harry Wentland wrote: >> On 2019-09-12 3:47 a.m., Ramalingam C wrote: >>> On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >>>> Hi all, >>>> >>>>

Re: HDCP Content Type Interface

On 2019-09-12 10:57 a.m., Jani Nikula wrote: > On Thu, 12 Sep 2019, Harry Wentland wrote: >> On 2019-09-12 3:47 a.m., Ramalingam C wrote: >>> On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >>>> Hi all, >>>> >>>> This is regard

Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config

+Manasi, Gaurav On 2019-09-09 9:52 a.m., Benjamin Gaignard wrote: > Change scale_increment_interval and nfl_bpg_offset fields to > u32 to avoid W=1 warnings because we are testing them against > 65535. > > Signed-off-by: Benjamin Gaignard > --- > include/drm/drm_dsc.h | 6 -- > 1 file

Re: [PATCH] drm: fix warnings in DSC

On 2019-09-11 4:47 a.m., Benjamin Gaignard wrote: > Remove always false comparisons due to limited range of nfl_bpg_offset > and scale_increment_interval fields. > Warnings detected when compiling with W=1. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Harry W

[PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

From: Nikola Cornij [why] Number of slices per line was mistakenly left out Cc: Hariprasad Kelam Signed-off-by: Nikola Cornij Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland --- Thanks, Hariprasad, for your patch. The second condition should actually check for num_slices_h

Re: [PATCH] drm/amd/display: hide an unused variable

in an #ifdef like its only users. > > Fixes: 14b2584636c6 ("drm/amd/display: add functionality to grab DPRX CRC > entries.") > Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ &

Re: [PATCH 1/6] drm/amdgpu/dm/mst: Don't create MST topology managers for eDP ports

On 2019-09-26 6:51 p.m., Lyude Paul wrote: > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd

Re: [PATCH 3/6] drm/amdgpu/dm/mst: Use ->atomic_best_encoder

On 2019-09-26 6:51 p.m., Lyude Paul wrote: > We are supposed to be atomic after all. We'll need this in a moment for > the next commit. > > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 10 ++

Re: drm/amd/display: Add HDCP module - static analysis bug report

On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: >> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet >> wrote: >>> >>> I misunderstood and was talking about the ksv validation specifically >>> (usage of drm_hdcp_check_ksvs_revoked()). >> >>

Re: [PATCH v2 1/2] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

On 2019-11-01 3:38 p.m., Jerry (Fangzhi) Zuo wrote: > DP 1.4 edid corruption test requires source DUT to write calculated > CRC, not the corrupted CRC from reference sink. > > Return the calculated CRC back, and initiate the required sequence. > > -v2: Have separate routine for returning real

Re: [PATCH] drm/amd/display: remove redundant null pointer check before kfree

On 2019-10-29 9:57 p.m., zhong jiang wrote: > kfree has taken null pointer into account. hence it is safe to remove > the unnecessary check. > > Signed-off-by: zhong jiang Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 4 +--- &g

Re: [PATCH 0/4] drm/amd/display: remove some set but not used variables

bios_parser.c > drm/amd/display: remove set but not used variable 'min_content' > These would be fine as a single patch as well but I don't have a strong preference either way. Patches are: Reviewed-by: Harry Wentland Harry > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio

40 > References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found") > Signed-off-by: Chris Wilson Reviewed-by: Harry Wentland Harry > Cc: Harry Wentland > Cc: Jean Delvare > Cc: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_h

Re: [PATCH -next] drm/amd/display: Fix old-style declaration

On 2019-11-11 7:28 a.m., YueHaibing wrote: > Fix a build warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: > warning: 'static' is not at beginning of declaration > [-Wold-style-declaration] > > Signed-off-by: YueHaibing Reviewed-by: H

Re: [PATCH -next] drm/amd/display: Fix old-style declaration

On 2019-11-12 2:51 a.m., Yuehaibing wrote: > On 2019/11/12 10:39, Joe Perches wrote: >> On Mon, 2019-11-11 at 20:28 +0800, YueHaibing wrote: >>> Fix a build warning: >>> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: >>> warning: 'static' is not at beginning of declaration >>>

Re: drm/amd/display: Add HDCP module - static analysis bug report

On 2019-11-05 9:23 a.m., Daniel Vetter wrote: > On Tue, Nov 5, 2019 at 3:17 PM Harry Wentland wrote: >> >> >> >> On 2019-11-05 8:14 a.m., Daniel Vetter wrote: >>> On Tue, Nov 5, 2019 at 1:52 PM Alex Deucher wrote: >>>> >>&

Re: drm/amd/display: Add HDCP module - static analysis bug report

Nov 4, 2019 at 11:55 AM Daniel Vetter wrote: >>>>> >>>>> On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote: >>>>>> On 2019-11-04 5:53 a.m., Daniel Vetter wrote: >>>>>>> On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote

Re: [PATCH v8 12/17] drm/dp_mst: Add branch bandwidth validation to MST atomic check

eds doesn't exceed available bandwidth. > The funtion is called in drm_dp_mst_atomic_check after > drm_dp_mst_atomic_check_topology_state to fully verify that > the proposed topology is supported. > > Cc: Jerry Zuo > Cc: Harry Wentland > Cc: Lyude Paul > Signed-off-b

Re: [PATCH v8 04/17] drm/dp_mst: Fill branch->num_ports

removed from the list, decrement num_ports. > > v2: remember to decrement on port removal > v3: don't explicitly init to 0 > > Reviewed-by: Lyude Paul > Reviewed-by: Harry Wentland > Signed-off-by: David Francis > Signed-off-by: Mikita Lipski > --- > drivers/gpu/dr

Re: [PATCH 1/2] drm: add dp helper to initialize remote aux channel.

t of the remote > aux, hooke crc work queue to 'drm_dp_aux_crc_work'. Then call this > helper in DP MST port initialization. > > > Cc: Leo Li > Cc: Harry Wentland > Signed-off-by: David (Dingchen) Zhang > --- > drivers/gpu/drm/drm_dp_helper.c | 13 +++

Re: [PATCH 1/2] drm: add dp helper to initialize remote aux channel.

On 2019-12-06 10:30 a.m., Harry Wentland wrote: > On 2019-12-05 11:55 a.m., David (Dingchen) Zhang wrote: >> [why] >> We need to minimally initialize the remote aux channel, e.g. the >> crc work struct of remote aux to dump the sink's DPRX CRCs in MST >> setup. >>

Re: [PATCH] drm/amd/display: Remove unneeded semicolon

On 2019-12-14 4:12 a.m., zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: Unneeded > semicolon > > Reported-by: Hulk Robot > Signed-off-by: zhengbin Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH v2] drm: add dp helper to initialize remote aux channel.

t of the remote > aux, hooke crc work queue to 'drm_dp_aux_crc_work'. Then call this > helper in DP MST port initialization. > This, plus David Francis' patch [1], fix the issue of MST remote > aux DPCD CRCs read. > > [1] https://patchwork.kernel.org/patch/11217941/ > > C

Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

definitions. > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrjälä > Signed-off-by: Abdoulaye Berthe > Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Harry > --- > include/drm/

Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition

fication. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Nikola Cornij > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrjälä > Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support) > Signed-off-by: Rodrigo Siqueira Rev

Re: [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

> This part of the code is stripped out of amdgpu's function > amdgpu_dm_update_freesync_caps() to make it generic and be used > across all DRM drivers > Please CC Nick on these as well. Added him now. Would it be possible to add a patch to update amdgpu to call this function? Harry > Cc:

Re: [PATCH 1/3] drm: Introduce scaling filter mode property

On 2019-10-22 8:20 a.m., Ville Syrjälä wrote: > On Tue, Oct 22, 2019 at 03:29:44PM +0530, Shashank Sharma wrote: >> This patch adds a scaling filter mode porperty >> to allow: >> - A driver/HW to showcase it's scaling filter capabilities. >> - A userspace to pick a desired effect while scaling.

Re: [PATCH] dc.c:use kzalloc without test

On 2019-10-23 4:32 a.m., zhongshiqi wrote: > dc.c:583:null check is needed after using kzalloc function > > Signed-off-by: zhongshiqi Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH] drm/amd/amdgpu: correct length misspelling

ch. You can do that by providing a range to "git format-patch". I usually call git format-patch with the -o parameter to put all my patches in a directory. Then I can send it with "git send-email *" in that directory. Reviewed-by: Harry Wentland This won't apply cleanly witho

Re: [PATCH] drm/radeon: remove assignment for return value

e; > -return ret; > > Signed-off-by: Wambui Karuga Thanks for your patch. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/radeon/cik.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/driver

Re: [PATCH] drm/amd/amdgpu: make undeclared variables static

On 2019-10-19 3:24 a.m., Wambui Karuga wrote: > Make the `amdgpu_lockup_timeout` and `amdgpu_exp_hw_support` variables > static to remove the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:103:19: warning: symbol > 'amdgpu_lockup_timeout' was not declared. Should it be

Re: [PATCH v4] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

On 2019-11-25 4:36 p.m., Zuo, Jerry wrote: > Please kindly give a review on my latest revision. Thanks a lot. > Both patches are Reviewed-by: Harry Wentland Harry > Regards, > Jerry > > -Original Message- > From: Jerry (Fangzhi) Zuo > Sent: November 5, 2019

Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field

"drm/amd/display: Add PSP block to verify HDCP2.2 steps") > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH] drm/amd/display: Use NULL for pointer assignment in copy_stream_update_to_stream

296409sdata=6HK3wWYMoILbiBisjoHkFwopV%2BuJYUh8wCDhMSvRQQ8%3Dreserved=0 > Signed-off-by: Nathan Chancellor Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/driver

Re: [PATCH] drm/edid: Add modes from CTA-861-G

+Bhawan who has been looking at this from our side. Harry On 2019-11-23 12:50 a.m., Thomas Anderson wrote: > The new modes are needed for exotic displays such as 8K. Verified that > modes like 8K60 and 4K120 are properly obtained from a Samsung Q900R. > > Signed-off-by: Thomas Anderson > --- >

Re: [PATCH 0/4] drm/amd/display: Remove unneeded semicolon

Series is Reviewed-by: Harry Wentland Harry On 2019-11-27 9:31 p.m., zhengbin wrote: > zhengbin (4): > drm/amd/display: Remove unneeded semicolon in bios_parser.c > drm/amd/display: Remove unneeded semicolon in bios_parser2.c > drm/amd/display: Remove unneeded semicolon in hd

Re: [PATCH] drm/amd/display: prevent memory leak

On 2019-09-25 12:23 a.m., Navid Emamdoost wrote: > In dcn*_create_resource_pool the allocated memory should be released if > construct pool fails. > > Signed-off-by: Navid Emamdoost Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dce100/dce

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

:24: > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync > module") > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry

Re: [PATCH] drm/amd/display: Fix typo in some comments

On 2019-10-05 7:32 a.m., Christophe JAILLET wrote: > p and g are switched in 'amdpgu_dm' > > Signed-off-by: Christophe JAILLET Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH 0/5] drm/amd/display: some fixes for gcc warning

Series is Reviewed-by: Harry Wentland Harry On 2019-10-04 10:44 p.m., zhengbin wrote: > zhengbin (5): > drm/amd/display: Make function wait_for_alt_mode static > drm/amd/display: Remove set but not used variable 'source_bpp' > drm/amd/display: Remove set but not us

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-07 5:58 p.m., Colin King wrote: > From: Colin Ian King > > Don't populate the arrays on the stack but instead make them > static. Makes the object code smaller by 158 bytes. > > Before: >text data bss dec hex filename > 32468 2072 0 34540

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-08 10:00 a.m., Joe Perches wrote: > On Tue, 2019-10-08 at 13:56 +0000, Harry Wentland wrote: > [] >>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >>> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >> [] >>> @@ -

Re: [PATCH 0/3] drm/amd/display/dc/dce: remove some not used variables

Thanks for the patches. I think for all of them we should just drop the REG_READ calls completely. They look like leftovers from when we had a different register update scheme that would read the register, then update or get the field value. Now we just use the REG_ macros that will combine the

Re: [PATCH next] drm/amd/display: make non-global functions static

c_resource.c:975:6: > warning: symbol 'restore_border_left_from_dst' was not declared. Should > it be static? > > Fixes: 89d07b662f5e (drm/amd/display: fix 270 degree rotation for mixed-SLS > mode) > Reported-by: Hulk Robot > Signed-off-by: Chen Zhou Reviewed-by: Harry

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

finition. All patches should compile on their own. Thanks, Harry > Cc: Harry Wentland > Cc: Alex Deucher > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

On 2019-12-18 11:13 a.m., Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: >> On 2019-12-18 10:13 a.m., Animesh Manna wrote: >>> [Why]: >>> Aligh with DP spec wanted to follow same naming convention. >>> >>> [How]: >

Re: [PATCH next] drm/amd/display: make some symbols static

eclared. Should > it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:768:6: > warning: symbol 'dce110_clock_source_destroy' was not declared. Should > it be static? > > Reported-by: Hulk Robot > Signed-off-by: Chen Zhou

Re: [PATCH 13/15] drm/amdgpu/display: split dp connector registration (v3)

On 2020-02-07 4:17 p.m., Alex Deucher wrote: > Split into init and register functions to avoid a segfault > in some configs when the load/unload callbacks are removed. > Looks like MST is completely broken with this change with a NULL pointer dereference in drm_dp_aux_register. > v2: > - add

Re: [PATCH] drm/amdgpu: Stop using the DRIVER debugging flag for vblank debugging messages

r debug flag to be a little less spammy with our > debug output. > > Signed-off-by: Lyude Paul Thanks. Great change. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-)

Re: [PATCH] drm/amd/dm/mst: Ignore payload update failures on disable

7b > RDX: 7ffd045f90a0 RSI: c06864a2 RDI: 000b > RBP: 7ffd045f90a0 R08: R09: 55dbd2985d10 > R10: 55dbd2196280 R11: 0246 R12: c06864a2 > R13: 000b R14: 0000 R15: 55dbd2196280 > ---[

Re: [PATCH V5] drm: Add support for DP 1.4 Compliance edid corruption test

for returning real CRC. > > Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_dp_helper.c | 35 + > drivers/gpu/drm/drm_edid.c | 23 ++ > include/drm/drm_connector.h |

Re: [PATCH 6/6] drm/amd/display: REFERENCE for srm interface patches

Thanks for providing more documentation and this reference. The patch set (1-5) is Reviewed-by: Harry Wentland Harry On 2020-01-22 4:05 p.m., Bhawanpreet Lakha wrote: > This is just a reference for the patches. not to be merged > > Signed-off-by: Bhawanpreet Lakha > --- >

Re: [PATCH 00/14] amdgpu: remove load and unload callbacks

Patches 10-12 are Reviewed-by: Harry Wentland Harry On 2020-02-04 10:48 p.m., Alex Deucher wrote: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > Alex Deucher (14): > drm

Re: [PATCH V6] drm: Add support for DP 1.4 Compliance edid corruption test

On 2020-02-05 10:22 a.m., Jerry (Fangzhi) Zuo wrote: > Unlike DP 1.2 edid corruption test, DP 1.4 requires to calculate > real CRC value of the last edid data block, and write it back. > Current edid CRC calculates routine adds the last CRC byte, > and check if non-zero. > > This behavior is

Re: [PATCH 2/2] drm/amd/display: Allow current eDP link settings to override verified ones.

On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > If the current eDP link settings, as read from hw, provide a higher > bandwidth than the verified_link_cap ones (= reported_link_cap), then > override verified_link_cap with current settings. > > These initial current eDP link settings have been

Re: [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read.

n Leung Reviewed-by: Harry Wentland This also fixes our assumption that retrieve_link_cap is the first DPCD reads we perform during detection. Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH] drm/amdgpu/display: Use u64 divide macro for round up division

; Signed-off-by: Mikita Lipski Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > b/drivers/gpu

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

and be used >>> across all DRM drivers >>> >>> v2: >>> * Change vmin and vmax to use u8 (Ville) >>> * Dont store pixel clock since that is just a max dotclock >>> and not related to VRR mode (Manasi) >>> >>> Cc: Ville Syrjälä &g

Re: [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

On 2020-01-09 4:04 p.m., Mario Kleiner wrote: > On Thu, Jan 9, 2020 at 8:49 PM Alex Deucher > wrote: > > On Thu, Jan 9, 2020 at 11:47 AM Mario Kleiner > mailto:mario.kleiner...@gmail.com>> > wrote: > > > > On Thu, Jan 9, 2020 at 4:40 PM Alex

Re: [PATCH 2/2] drm/amd/display: Allow current eDP link settings to override verified ones.

On 2020-01-09 4:13 p.m., Mario Kleiner wrote: > On Thu, Jan 9, 2020 at 7:44 PM Harry Wentland <mailto:hwent...@amd.com>> wrote: > > On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > > If the current eDP link settings, as read from hw, provide a highe

Re: [PATCH v2] drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded

late response. Thanks for getting high-res modes working on HDMI. This change is Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 45 ++- > 1 file changed, 23 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH v3] drm: Set crc->opened to false before setting crc source to NULL.

spin_lock around entire crc->opened use (Daniel) > > Cc: Daniel Vetter > Cc: Harry Wentland > Cc: Nick Kazlauskas > Signed-off-by: Dingchen Zhang Looks like we dropped the ball on this and the other CRC patch. I'll merge them now. Reviewed-by: Harry Wentland Harry >

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

ue of NO_STOP_BIT for DP_REMOTE_I2C_READ case in > drm_dp_encode_sideband_req(). > > Changes since v1:(https://patchwork.kernel.org/patch/11312667/) > * Add more descriptions in commit and cc to stable > > Fixes: ad7f8a1f9ce (drm/helper: add Displayport multi-stream helper (v0.6)) >

Re: [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

On 2019-12-23 12:03 p.m., Animesh Manna wrote: > [Why]: > Aligh with DP spec wanted to follow same naming convention. > > [How]: > Changed the macro name of the dpcd address used for getting requested > test-pattern. > > Cc: Harry Wentland > Cc: Alex Deucher >

Re: [PATCH v3 2/9] drm/dp: get/set phy compliance pattern

On 2019-12-23 12:03 p.m., Animesh Manna wrote: > During phy compliance auto test mode source need to read > requested test pattern from sink through DPCD. After processing > the request source need to set the pattern. So set/get method > added in drm layer as it is DP protocol. > > v2: As per

Re: [PATCH] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

ases and > environment. > However, this bit might affect the I2C signal generated by I2C master, I will > mention more > in the commit message. > Thanks. Was just curious if you saw any real issues. Good find nevertheless and good patch. You can add my Reviewed-by: Harry Wentland

Re: [PATCH] drm/amd/display: Fix error returned by program_hpd_filter

On 2019-11-17 12:22 p.m., Aditya Pakki wrote: > program_hpd_filter() currently fails to check for the errors > returned in construct(). This patch returns error in > case of failure. > > Signed-off-by: Aditya Pakki > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +-- > 1 file changed,

Re: [PATCH v3 2/9] drm/dp: get/set phy compliance pattern

On 2019-12-30 11:05 a.m., Manna, Animesh wrote: > On 24-12-2019 01:23, Harry Wentland wrote: >> >> On 2019-12-23 12:03 p.m., Animesh Manna wrote: >>> During phy compliance auto test mode source need to read >>> requested test pattern from sink through DPCD.

Re: [PATCH] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

On 2019-12-30 2:05 a.m., Wayne Lin wrote: > [Why] > According to DP spec, it should shift left 4 digits for NO_STOP_BIT > in REMOTE_I2C_READ message. Not 5 digits. > > [How] > Correct the shifting value of NO_STOP_BIT for DP_REMOTE_I2C_READ case in > drm_dp_encode_sideband_req(). > >

Re: Variable Refresh Rate & flickering screens

On 2020-03-12 7:25 a.m., Simon Ser wrote: > On Thursday, March 12, 2020 11:45 AM, Michel Dänzer > wrote: > >> On 2020-03-11 9:09 p.m., Simon Ser wrote: >> >>> Hi all, >>> I've been working on adding VRR support to Sway [1] (a Wayland >>> compositor). The compositor just sets the VRR_ENABLED

Re: [PATCH] drm: amd: display: fix kernel-doc struct warning

ixes: 52704fcaf74b ("drm/amd/display: Initialize HDCP work queue") > Signed-off-by: Randy Dunlap > Cc: Bhawanpreet Lakha > Cc: Harry Wentland > Cc: Alex Deucher > Cc: Leo Li > Cc: amd-...@lists.freedesktop.org Reviewed-by: Harry Wentland Harry > --- > driv

<    1   2   3   4   5   6   7   8   9   10   >