Re: KMS backlight ABI proposition

2017-02-20 Thread Jasper St. Pierre
I don't work on this anymore, but, even disregarding the mess that is ACPI backlight: I think when people start interfacing with the Backlight API, they wonder why it's not normalized. And then you start implementing it, and you realize that some writes don't do anything. And that when you read ba

Re: KMS backlight ABI proposition

2017-02-22 Thread Jasper St. Pierre
017 at 6:00 AM, Jani Nikula wrote: > On Tue, 21 Feb 2017, "Jasper St. Pierre" wrote: > > Instead of normalizing to 100, I think we should expose a max level, and > > specify that's max brightness. Every single step in the range should > have a > > visible d

Re: KMS backlight ABI proposition

2017-02-23 Thread Jasper St. Pierre
On Thu, Feb 23, 2017 at 12:40 AM, Jani Nikula wrote: > On Wed, 22 Feb 2017, Stéphane Marchesin > wrote: > > On Fri, Feb 17, 2017 at 4:58 AM, Martin Peres > > wrote: > >> If the KMS property exposes a fixed number of steps (say 100), it > becomes > >> easy for the userspace to express the wanted

[PATCH] drm_atomic_helper: Copy/paste fix for calling already disabled planes

2014-11-20 Thread Jasper St. Pierre
This code was in drm_plane_helper, but missing from drm_atomic_helper, causing various crashes when the plane was already disabled. Just copy over the quick return there to prevent a crash. Signed-off-by: Jasper St. Pierre Reviewed-by: Rob Clark Cc: Daniel Vetter --- drivers/gpu/drm

[PATCH] modetest: Use threads for cursors instead of SIGALRM

2014-11-21 Thread Jasper St. Pierre
This fixes an issue when trying to use -v and -C together. When trying to read the page flip event, we are interrupted by the SIGALRM that comes in, and so we think we timed out when we simply got EINTR. While we could just loop checking for EINTR, SIGALRM is just bad idea to begin with, so just re

[PATCH] drm/atomic-helper: Skip vblank waits for unchanged fbs

2014-11-24 Thread Jasper St. Pierre
With the oops fix: Reviewed-by: Jasper St. Pierre Tested-by: Jasper St. Pierre On Mon, Nov 24, 2014 at 12:42 PM, Daniel Vetter wrote: > Especially with legacy cursor ioctls existing userspace assumes that > you can pile up lots of updates in one go. The super-proper way to > sup

[PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-24 Thread Jasper St. Pierre
eed to dodge the oops and look at the global > acquire ctx. > > v2: Actually fix the oops for real and don't just move it two lines > down. That requires that we pass a drm_device pointer for the cases > where crtc could be NULL. > > Reported-by: "Jasper St. Pierre&q