Re: [PATCH] drm/bridge: analogix dp: Fix runtime PM state on driver bind

2017-01-24 Thread Javier Martinez Canillas
Hello Archit, On 01/23/2017 11:40 PM, Archit Taneja wrote: > Hi, > > On 01/23/2017 10:58 PM, Javier Martinez Canillas wrote: >> Hello Archit, >> >> On 01/09/2017 06:47 AM, Archit Taneja wrote: >>> >>> >>> On 01/05/2017 01:01 PM, Sean P

Re: [PATCH] Gpu: drm: exynos - Fix possible NULL derefrence.

2017-01-30 Thread Javier Martinez Canillas
struct of_device_id in the table have a .data and so this can't be NULL in this driver. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: analogix dp: Fix runtime PM state on driver bind

2017-01-23 Thread Javier Martinez Canillas
os_defconfig/lab-collabora/boot-exynos5250-snow.html > Thanks, > Archit > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 5/6] ARM: dts: Add NextThing GR8 dtsi

2016-09-07 Thread Javier Martinez Canillas
Hello Maxime, On Wed, Aug 31, 2016 at 10:18 AM, Maxime Ripard wrote: [snip] > + > +#include "skeleton.dtsi" > + The skeleton.dtsi has been deprecated and shouldn't be used in new DTS files: http://www.spinics.net/lists/arm-kernel/msg528080.html Best regards, Javier

[PATCH] dt-bindings: video: exynos7-decon: Remove obsolete samsung,power-domain property

2016-10-21 Thread Javier Martinez Canillas
with generic one. >> >> Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Sylwester Nawrocki > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 2/3] drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency

2016-04-21 Thread Javier Martinez Canillas
Hello Inki, On 03/28/2016 09:28 PM, Javier Martinez Canillas wrote: > Commit aeefb36832e5 ("drm/exynos: gsc: add device tree support and remove > usage of static mappings") made the DRM_EXYNOS_GSC Kconfig symbol to only > be selectable if the exynos-gsc V4L2 driver isn't enab

[PATCH] drm/exynos/hdmi: Don't print error on deferral due to regulators

2016-04-21 Thread Javier Martinez Canillas
and confuse users. This patch prevents the following misleading messages to be printed: [1.443638] [drm:hdmi_probe] *ERROR* failed to get regulators [1.449326] [drm:hdmi_probe] *ERROR* hdmi_resources_init failed Reported-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas

[PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-04 Thread Javier Martinez Canillas
e able to > use them instead of duplicating them. > > Signed-off-by: Tomeu Vizoso > Cc: Javier Martinez Canillas > Cc: Mika Kahola > Cc: Yakir Yang > Cc: Daniel Vetter > --- I tested this patch on an Exynos5800 Peach Pi Chromebook and display is still working correctl

[PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear

2016-08-10 Thread Javier Martinez Canillas
uous GEM memory is not supported.\n"); > return -EINVAL; > } > > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH] exynos-drm: Fix error messages to print flags and size

2016-08-10 Thread Javier Martinez Canillas
Hello Shuah, On Wed, Aug 10, 2016 at 1:30 PM, Shuah Khan wrote: > Fix exynos_drm_gem_create() error messages to include flags and size when > flags and size are invalid. > > Signed-off-by: Shuah Khan > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Javier Martinez Canillas
start. > + */ > + if (!is_drm_iommu_supported(dev) && > + (args->flags & EXYNOS_BO_NONCONTIG)) { > + args->flags &= ~EXYNOS_BO_NONCONTIG; > + args->flags |= EXYNOS_BO_CONTIG; > + } > + I'm not a

[PATCH v2 0/10] Add RK3399 eDP support and fix some bugs to analogix_dp driver.

2016-05-31 Thread Javier Martinez Canillas
Hello Yakir, On 05/27/2016 02:16 AM, Yakir Yang wrote: > Hi Javier, > > On 05/26/2016 08:48 PM, Javier Martinez Canillas wrote: >> Hello Yakir, >> >> On 05/26/2016 05:34 AM, Yakir Yang wrote: >>> Hi Javier, >>> >>> On 05/24/2016 01:01 PM, Yak

[PATCH] drm/exynos: gsc: fix spelling mistakes

2016-11-02 Thread Javier Martinez Canillas
Hello Colin, On 11/01/2016 11:23 PM, Colin King wrote: > From: Colin Ian King > > Trivial fixes to spelling mistakes "precalser" to "prescaler" > in dev_err messages > > Signed-off-by: Colin Ian King > --- Reviewed-by: Javier Martinez Canillas B

[RESEND PATCH] drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency

2016-11-29 Thread Javier Martinez Canillas
is enabled as a module, which isn't what we want since otherwise 2 drivers could attempt to use the hardware at the same time. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig

[PATCH 2/3] drm/exynos: fimd: add HW trigger support

2016-06-01 Thread Javier Martinez Canillas
Hello Inki, On 06/01/2016 01:56 AM, Inki Dae wrote: > Hi Javier, > > 2016년 05월 31일 07:58에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> On 04/05/2016 04:27 AM, Inki Dae wrote: >>> This patch adds HW trigger support on i80 mode

[PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-02 Thread Javier Martinez Canillas
and use SW trigger as it was before the mentioned commit. Signed-off-by: Javier Martinez Canillas --- Hello Inki, Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be picked to make sure that v4.7 is released with the display working for the Exynos5420 based Chromebook

[PATCH] drm/exynos: fimd: fix trigger mode change regression

2016-06-06 Thread Javier Martinez Canillas
(kthread+0xdc/0xf4) [4.631512] [] (kthread) from [] (ret_from_fork+0x14/0x3c) [4.639239] Code: e10f7000 f10c0080 e2845004 f595f000 (e1953f9f) [4.645845] ---[ end trace 3bfc770b9638a54b ]--- Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v14.1 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory

2016-06-07 Thread Javier Martinez Canillas
k+0x124/0x338) [4.615144] [] (process_one_work) from [] (worker_thread+0x38/0x4d4) [4.623764] [] (worker_thread) from [] (kthread+0xdc/0xf4) [4.631512] [] (kthread) from [] (ret_from_fork+0x14/0x3c) [4.639239] Code: e10f7000 f10c0080 e2845004 f595f000 (e1953f9f) [4.645845] ---[ end trace 3bfc770b9638a54b ]--- Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH] drm/exynos: dp: Fix NULL pointer dereference due uninitialized connector

2016-06-08 Thread Javier Martinez Canillas
44 ("drm: bridge: analogix/dp: split exynos dp driver to bridge directory") Reported-by: Marc Zyngier Signed-off-by: Yakir Yang [javier: wrote commit message] Signed-off-by: Javier Martinez Canillas Tested-by: Marc Zyngier --- Hello Inki, This is a regression introduced in v4.7-rc1, s

[PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-08 Thread Javier Martinez Canillas
Hello Inki, Thanks for your feedback. On 06/08/2016 07:09 PM, Inki Dae wrote: > Hi Javier, > > 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: >> Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added >> hardware trigger

[PATCH v14.1 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory

2016-06-08 Thread Javier Martinez Canillas
On 06/08/2016 06:53 AM, Yakir Yang wrote: > Marc, Javier > > On 06/08/2016 03:44 PM, Marc Zyngier wrote: >> On Wed, 8 Jun 2016 09:28:32 +0800 >> Yakir Yang wrote: >> >>> Hi Javier, >>> >>> On 06/08/2016 01:06 AM, Javier Martinez Canillas wro

[PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800

2016-06-09 Thread Javier Martinez Canillas
Hello Inki, On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote: [snip] >> I know that removing .trg_type is enough but I also removed those lines >> because the fields are not used if .trg_type != I80_HW_TRG. So there is >> no point to leave a set for unused fields. >> >> We can latter add those

[PATCH V2 3/5] Documentation/devicetree/bindings: b850v3_lvds_dp

2016-06-10 Thread Javier Martinez Canillas
Hello Peter, On Thu, Jun 9, 2016 at 12:25 PM, Peter Senna Tschudin wrote: > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ > display bridge. > > Cc: Enric Balletbo i Serra > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Fabio Estevam > Signed-off-by: Peter Senna Tschudin > --- >

[PATCH] drm/exynos: dp: Fix panel and bridge lookup logic

2016-01-29 Thread Javier Martinez Canillas
ROBE_DEFER if a panel is not found, check if there's a bridge and only do a probe deferral if both aren't found. Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support for panel") Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/e

Exynos Snow board display regression

2016-01-29 Thread Javier Martinez Canillas
noticed the same and posted a fix some hours ago: https://lkml.org/lkml/2016/1/29/355 > Thanks > > Michal > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[RESEND PATCH] drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency

2016-07-11 Thread Javier Martinez Canillas
is enabled as a module, which is not what we want. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index d814b3048ee5..ec2dcc5e4962 100644 --- a/d

[PATCH 3/4] drm/exynos: use generic code for managing zpos plane property

2016-05-11 Thread Javier Martinez Canillas
On Wed, May 11, 2016 at 8:16 AM, Krzysztof Kozlowski wrote: > On 05/11/2016 02:09 PM, Benjamin Gaignard wrote: >> I haven't double check but I had to do changes into the original patch >> so I guess that "from" field comes the new commit. >> >> I will manually edit the commit for v2, > > Git

[PATCH 1/4] drm: add generic zpos property

2016-05-12 Thread Javier Martinez Canillas
> > And please update the subject as well to include the version number. You can > use > > $ git format-patch --cover --subject-prefix 'PATCH vX' > And git even has a -v option now, so this could just be: $ git format-patch --cover -vX Best regards, Javier

[PATCH v2 0/10] Add RK3399 eDP support and fix some bugs to analogix_dp driver.

2016-05-26 Thread Javier Martinez Canillas
o i would be very grateful about that. > Of course, I' ll test. Could you please provide me a branch that I can pull directly to avoid cherry-picking all the patches from the list? > Thanks, > - Yakir >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 2/3] drm/exynos: fimd: add HW trigger support

2016-05-30 Thread Javier Martinez Canillas
.lcdblk_mic_bypass_shift = 11, - .trg_type = I80_HW_TRG, .has_shadowcon = 1, .has_vidoutcon = 1, .has_vtsel = 1, Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH] drm/exynos: fimd: don't set .has_hw_trigger in s3c6400 driver data

2016-05-30 Thread Javier Martinez Canillas
The field value is only checked in fimd_setup_trigger() if .trg_type is I80_HW_TRG so there's no point in setting this field for the s3c6400 if is never going to be used since .trg_type is not set. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - 1

[PATCH] drm/exynos: dp: Fix panel and bridge lookup logic

2016-02-08 Thread Javier Martinez Canillas
Hello Inki, On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote: > Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support > for panel") made the Exynos DP DT binding more consistent since the OF > graph could be used to lookup either a panel or a bridge devi

[PATCH] drm/exynos: dp: Fix panel and bridge lookup logic

2016-02-08 Thread Javier Martinez Canillas
Hello Marek, On 02/08/2016 09:38 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2016-02-08 13:03, Javier Martinez Canillas wrote: >> Hello Inki, >> >> On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote: >>> Commit a9fa852886fd ("drm/exynos: dp: add

[PATCH] fence: add missing descriptions for fence

2016-03-19 Thread Javier Martinez Canillas
gt; 'active_list' > > Thanks :) > Luis > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier

[PATCH v14 0/17] Add Analogix Core Display Port Driver

2016-03-22 Thread Javier Martinez Canillas
1 month old with no > major comments. > Same here, this is the second time I tested this series (first time was v6 on October 25 [2]) and I think that has been out there for too long. > Tested-by: Douglas Anderson > Tested-by: Javier Martinez Canillas > > -Doug > [0]: git:

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-28 Thread Javier Martinez Canillas
Martinez Canillas (3): drm/exynos: Use VIDEO_SAMSUNG_S5P_G2D=n as G2D Kconfig dependency drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency drm/exynos: Make DRM_EXYNOS_FIMC depend on VIDEO_S5P_FIMC=n drivers/gpu/drm/exynos/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 1/3] drm/exynos: Use VIDEO_SAMSUNG_S5P_G2D=n as G2D Kconfig dependency

2016-03-28 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index f17d39279596..baddf33fb475 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/

[PATCH 2/3] drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency

2016-03-28 Thread Javier Martinez Canillas
is enabled as a module, which is not what we want. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index baddf33fb475..8c27037787fc 100644 --- a/d

[PATCH 3/3] drm/exynos: Make DRM_EXYNOS_FIMC depend on VIDEO_S5P_FIMC=n

2016-03-28 Thread Javier Martinez Canillas
driver. Suggested-by: Tobias Jakobi Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 8c27037787fc..f9b92c3825ea 100644

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-28 Thread Javier Martinez Canillas
Hello Seung-Woo, Thanks a lot for your feedback. On 03/28/2016 09:46 PM, Seung-Woo Kim wrote: > Hi Javier, > > On 2016년 03월 29일 10:28, Javier Martinez Canillas wrote: >> Hello Inki, >> >> This patch series contains some fixes for the Kconfig symbol dependencies

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-29 Thread Javier Martinez Canillas
Hello Seung-Woo, On 03/29/2016 12:25 AM, Seung-Woo Kim wrote: > Hello Javier, > > On 2016년 03월 29일 11:41, Javier Martinez Canillas wrote: >> Hello Seung-Woo, >> >> Thanks a lot for your feedback. >> >> On 03/28/2016 09:46 PM, Seung-Woo Kim wrote: >

[PATCH V7 00/12] drm/exynos: few patches to enhance bridge chip support

2014-09-16 Thread Javier Martinez Canillas
> I have tested this after adding few DT changes for exynos5250-snow and > exynos5420-peach-pit boards. > > The V4 series of this particular patchset was also tested by: > Rahul Sharma > Javier Martinez Canillas > > Changes since V2: > -- Address commen

[PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-09-20 Thread Javier Martinez Canillas
[adding Kukjin as cc] Hello Ajay, On Sat, Sep 20, 2014 at 1:22 PM, Ajay kumar wrote: >> Generally speaking, I sense that we have different views of how display >> devices and drivers are structured. You say "If some XYZ platform wishes >> to pick the DT node via a different method, they are

[PATCH V4 04/10] drm/panel: Add driver for lvds/edp based panels

2014-06-23 Thread Javier Martinez Canillas
Hello Ajay, Not an extensive review since I'm not familiar with the graphics stack but a few things I noticed are commented below. On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar wrote: > This patch adds a simple driver to handle all the LCD and LED > powerup/down routines needed to support

[PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Javier Martinez Canillas
ard. > Otherwise, can anyone give me tested-by? and I'd happy to give me > reviewed-by so that I can pick this patch series up. > > Thanks, > Inki Dae > I've also tested this series on an Exynos5420 Peach pit board and LVDS display was working for me. Tested-by: Javier M

[PATCH V4 09/10] drm/bridge: Add ps8622/ps8625 bridge driver

2014-06-23 Thread Javier Martinez Canillas
Hello Ajay, On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar wrote: > From: Vincent Palatin > > This patch adds drm_bridge driver for parade DisplayPort > to LVDS bridge chip. > > Signed-off-by: Vincent Palatin > Signed-off-by: Andrew Bresticker > Signed-off-by: Sean Paul > Signed-off-by: Rahul

[PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-18 Thread Javier Martinez Canillas
Hello Andrzej, On Tue, Nov 18, 2014 at 11:48 AM, Andrzej Hajda wrote: >> So we have two issues here and your patch is only a workaround for the later. > > This is the same issue Krzysztof reported two weeks ago and I answered > him with my diagnosis[1]. > > [1]:

[PATCH] drm/exynos: fix infinite loop issue incurred by no pair

2014-11-18 Thread Javier Martinez Canillas
Hello Inki, > Right, but at least, we could avoid kernel booting failure which is very > critical. Please know that this patch is temporary to avoid the kernel > booting failure although deferred probe request of Exynos drm could be > broken. For this, I will look into dd core to find out more

[BUG] blocked task after exynos_drm_init

2014-11-18 Thread Javier Martinez Canillas
[adding Kevin to cc list] Hello Inki, On Tue, Nov 18, 2014 at 11:52 AM, Inki Dae wrote: > On 2014년 11월 18일 19:42, Andrzej Hajda wrote: >> On 11/06/2014 10:06 AM, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> On last next (next-20141104, next-20141105) booting locks after >>> initializing

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-18 Thread Javier Martinez Canillas
gistration to exynos_drm_init(). Suggested-by: Andrzej Hajda Signed-off-by: Javier Martinez Canillas --- This issue was reported by both Krzysztof Kozlowski [0] and Kevin Hilman [1]. Inki Dae said that he will fix it property by separating the Exynos DRM driver in different sub-modules but I post this patch as R

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-19 Thread Javier Martinez Canillas
Hello Kevin, On 11/18/2014 11:46 PM, Kevin Hilman wrote: >>> Is anyone at Samsung testing linux-next? If so, on what platforms? It >>> would really be nice if your linux-next work was tested on these >>> publically-available 542x/5800 platforms (peach-pi, peach-pit, >>> odroid-xu3) which would

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-11-19 Thread Javier Martinez Canillas
now. Thanks for the pointer! If someone else is interested, I've pushed a branch [0] with 3.18-rc5 + all the needed patches. Ajay, feel free to add to your series: Tested-by: Javier Martinez Canillas Best regards, Javier [0]: git://git.collabora.co.uk/git/user/javier/linux.git wip/exynos/dp-integ

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-11-19 Thread Javier Martinez Canillas
Hello Ajay, On 11/18/2014 07:20 AM, Ajay kumar wrote: > On Sat, Nov 15, 2014 at 3:24 PM, Ajay Kumar > wrote: >> This series is based on master branch of Linus tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git I applied your series on top of 3.18-rc5 + linux-next's

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-11-19 Thread Javier Martinez Canillas
Hello Ajay, On 11/19/2014 10:38 AM, Ajay kumar wrote: > Hi Javier, > > In the cover letter, I have mentioned that it is tested on Linus tree: > > "This series is based on master branch of Linus tree at: > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" > > Kindly test the

[PATCH v2 2/2] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-19 Thread Javier Martinez Canillas
ame to dp-phy >> node. >> >> Signed-off-by: Vivek Gautam >> Cc: Jingoo Han > > Reviewed-by: Jingoo Han > Tested-by: Javier Martinez Canillas Kukjin, This patch is -rc material and is needed to have display working in 3.18 again since commit a5ec598 ("phy:

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-19 Thread Javier Martinez Canillas
[adding Paolo and Vivek as cc] Hello, On 11/18/2014 07:41 PM, Kevin Hilman wrote: > > It fixes the DRM deadlock, issue for me on exynos5800-peach-pi, but then > it proceeds to panic in the workqueue code called by the asoc max98090 > codec[1]. > > If I then disable CONFIG_SND_SOC_SNOW, I can

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-11-19 Thread Javier Martinez Canillas
Hello Paolo, On 11/19/2014 05:22 PM, Paolo Pisati wrote: > On Wed, Nov 19, 2014 at 12:20:53PM +0100, Javier Martinez Canillas wrote: >> >> If someone else is interested, I've pushed a branch [0] with 3.18-rc5 + all >> the needed patches. >> >> Ajay

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Vivek, On 11/20/2014 08:51 AM, Vivek Gautam wrote: >> >> I tested linux-next on Exynos5800 peach-pi board with linux-next and and the >> two >> patches $Subject and [0]. >> >> Below is my git hash: >> 4d9e6ee drm/exynos: Move platform drivers registration to module init >> 4545ed4 POSTED:

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2014 03:07 PM, Inki Dae wrote: > Could you re-base this patch on top of exynos-drm-next? I tried to > separate sub drivers into independent drivers but it seems that we need > more times. So I will merge your patch. > Sure, I'll rebase on top of exynos-drm-next and re-post

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2014 04:06 PM, Inki Dae wrote: >> BTW, it would be great if exynos-drm-next is pulled in linux-next. That is >> what most people use to test integration issues so you can catch earlier any >> regression that may arise. >> >> You have to email Stephen Rothwell and point to

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello Paolo, On 11/20/2014 04:57 PM, Paolo Pisati wrote: > On Thu, Nov 20, 2014 at 03:22:23PM +0530, Vivek Gautam wrote: >> >> On linux-samsung tree the only patch that's missing apart from dptx-phy >> patches >> is the syscon patch from Pankaj Dubey: >> b784b98 mfd: syscon: Decouple syscon

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-21 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2014 06:01 PM, Inki Dae wrote: > Ah, sorry. There was my misunderstanding. drm-next already is merged > to linux-next so I think we can do the integration test if > exynos-drm-next is merged to drm-next earlier. Anyway, I will try to > consider your opinion. > Cool, having

[RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers

2014-11-20 Thread Javier Martinez Canillas
Hello Inki, On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae wrote: >> If you try to build exynosdrm as module you will receive errors due to >> multiple definitions of init_module, ie module_init/module_*_driver >> macros can be used once per module. > > Ah, right. we had ever tried same way before

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-20 Thread Javier Martinez Canillas
Hello, For completeness I'll comment what we talked with Kevin on IRC since probably this is the same issue that Paolo is facing. On 11/20/2014 05:41 PM, Kevin Hilman wrote: > Peach # setenv preboot "usb start; sleep 1"setenv bootargs console=tty1 > console=ttySAC3,115200 debug earlyprintk rw

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-21 Thread Javier Martinez Canillas
Hello Ajay, On 11/21/2014 06:32 PM, Ajay kumar wrote: > Hi, > > I have rebased my bridge series on top of linux-next. > > This is my git log: > 4b38a6f Revert "Revert "ARM: exynos_defconfig: Enable options for > display panel support"" > 6fb39a7 ARM: dts: peach-pit: represent the connection

[PATCH v2 2/2] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-22 Thread Javier Martinez Canillas
Hello Vivek On Wed, Nov 19, 2014 at 1:03 PM, Vivek Gautam wrote: >> >> Tested-by: Javier Martinez Canillas > > Thanks for testing. > You are welcome >> >> Kukjin, > > Sorry for not adding Kukjin to the list and thereby for the delay > about

[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

2014-11-24 Thread Javier Martinez Canillas
Hello Ajay, On 11/21/2014 09:57 PM, Javier Martinez Canillas wrote: > On 11/21/2014 06:32 PM, Ajay kumar wrote: >> Hi, >> >> I have rebased my bridge series on top of linux-next. >> >> This is my git log: >> 4b38a6f Revert "Revert "ARM: exyn

[PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-24 Thread Javier Martinez Canillas
Hello Vivek, Thierry, On 11/24/2014 12:29 PM, Vivek Gautam wrote: >> Yes. Back at the time a decision was made that device trees need to be >> stable ABI because eventually they'd be shipped with the device rather >> than the distribution. As such it may not at all be possible to update >> them

[PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-12-12 Thread Javier Martinez Canillas
[adding arm-soc maintainers to cc] Hello Kukjin, On 12/02/2014 09:39 AM, Jingoo Han wrote: > On Tuesday, December 02, 2014 5:17 PM, Javier Martinez Canillas wrote: >> On Mon, Nov 24, 2014 at 6:41 AM, Vivek Gautam >> wrote: >> > DP PHY now require pmu-system-controlle

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-12-12 Thread Javier Martinez Canillas
Hello, On 11/18/2014 07:20 AM, Ajay kumar wrote: > On Sat, Nov 15, 2014 at 3:24 PM, Ajay Kumar > wrote: >> This series is based on master branch of Linus tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> This series has been in the mailing lists for months and

[PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support

2014-12-17 Thread Javier Martinez Canillas
Hello Laurent and Tomi, On 12/16/2014 12:37 AM, Laurent Pinchart wrote: > Hi Javier, >> Tomi and Laurent, >> >> You asked Ajay to change his series to use the video port and enpoints DT >> bindings instead of phandles, could you please review his latest version? >> >> I guess is now too late

[PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-08-23 Thread Javier Martinez Canillas
Hello Ajay, On Thu, Jul 31, 2014 at 12:58 PM, Thierry Reding wrote: > On Wed, Jul 30, 2014 at 09:33:28PM +0530, Ajay kumar wrote: >> On Wed, Jul 30, 2014 at 8:38 PM, Thierry Reding > gmail.com> wrote: > [...] >> > I think it should even be possible to do this in more separate steps. >> > For

[PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-08-25 Thread Javier Martinez Canillas
Hello Ajay, On Mon, Aug 25, 2014 at 8:11 AM, Ajay kumar wrote: >> >> Do you plan to address Thierry's concerns and re-spin this patch? >> >> Same question for patches: >> >> "drm/bridge: Add i2c based driver for ptn3460 bridge" >> "drm/bridge: Add i2c based driver for ps8622/ps8625 bridge" >

[PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-12-02 Thread Javier Martinez Canillas
Hello Kukjin, On Mon, Nov 24, 2014 at 6:41 AM, Vivek Gautam wrote: > DP PHY now require pmu-system-controller to handle PMU register > to control PHY's power isolation. Adding the same to dp-phy > node. > > Signed-off-by: Vivek Gautam > Reviewed-by: Jingoo Han > Teste

[RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-04-30 Thread Javier Martinez Canillas
Hello Olof, On 04/30/2015 05:57 PM, Olof Johansson wrote: > On Thu, Apr 30, 2015 at 8:44 AM, Kevin Hilman wrote: >> Krzysztof Kozlowski writes: > > This should fix issue reported by Javier [1][2]. > > Tested on Chromebook Snow (Exynos 5250). More testing would be great, >

[PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-28 Thread Javier Martinez Canillas
Hello Ajay, On Thu, Oct 16, 2014 at 11:04 AM, Laurent Pinchart wrote: >> >> Right. It would be great if you guys come to agreement ASAP! > > I don't think we'll agree any time soon, so I believe it's up to you to decide > which option is best based on all arguments that have been presented. >

[PATCH 1/2] dma-buf: fix trivial typo error

2014-04-10 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- drivers/base/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index ea77701..840c7fa 100644 --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c @@ -491,7 +491,7

[PATCH 2/2] dma-buf: update exp_name when using dma_buf_export()

2014-04-10 Thread Javier Martinez Canillas
ng since talks about the interface used by importers. Signed-off-by: Javier Martinez Canillas --- Documentation/dma-buf-sharing.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt index 505

[PATCH v2 2/2] drm/exynos: dp: fix wrong return type

2015-12-02 Thread Javier Martinez Canillas
error > type so that the deferred probe isn't triggered. > > Changelog v2: > - return -EINVAL if getting a port node failed. > > Signed-off-by: Inki Dae > --- Reviewed-by: Javier Martinez Canillas Best regards -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-02 Thread Javier Martinez Canillas
ay/exynos/exynos_dp.txt > i.e., > The dts file for Exynos5800 based peach pi board > has a panel property so we need to keep the backward compatibility. > How did you test this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-03 Thread Javier Martinez Canillas
Hello Inki, On 12/02/2015 11:11 PM, Inki Dae wrote: > Hi Javier, > > 2015년 12월 03일 00:04에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> On 12/02/2015 08:57 AM, Inki Dae wrote: >>> This patch adds of_graph dt binding support

[PATCH] drm/exynos: dsi: modify a error type when getting a node failed

2015-12-03 Thread Javier Martinez Canillas
ode = of_graph_get_remote_port_parent(ep); > if (!dsi->bridge_node) { > - ret = -ENXIO; > + ret = -EINVAL; > goto end; > } > end: > Yes, I also think that -EINVAL is a better error code in this case. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 3/3] dt-bindings: exynos-dp: update ports node binding for panel

2015-12-03 Thread Javier Martinez Canillas
reg = <0>; > + ... > + port { > + dp_in: endpoint { > + remote-endpoint = <_out>; > }; > }; > }; > The rest looks good to me so with the two changes feel free to add: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-03 Thread Javier Martinez Canillas
oint) { > bridge_node = of_graph_get_remote_port_parent(endpoint); > @@ -1423,6 +1441,7 @@ static int exynos_dp_probe(struct platform_device *pdev) > return -EPROBE_DEFER; > } > > +out: > pm_runtime_enable(dev); > > ret = comp

[PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Javier Martinez Canillas
Hello Inki, On 12/04/2015 06:00 AM, Inki Dae wrote: > Hi Javier, > > 2015년 12월 03일 22:55에 Javier Martinez Canillas 이(가) 쓴 글: >> Hello Inki, >> >> I found that v2 of this patch is alredy in your exynos-drm for-next branch so >> so I had to revert i

[PATCH v3 1/3] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-04 Thread Javier Martinez Canillas
Hello Inki, On 12/04/2015 11:57 AM, Inki Dae wrote: > Hi Javier, > > 2015-12-04 21:38 GMT+09:00 Javier Martinez Canillas osg.samsung.com>: >> Hello Inki, >> >> On 12/04/2015 06:00 AM, Inki Dae wrote: >>> Hi Javier, >>> >>> 2015년 12ì

[PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

2015-12-07 Thread Javier Martinez Canillas
[adding Krzysztof and Kukjin to cc list] Hello Inki, On 12/06/2015 01:25 PM, Inki Dae wrote: > Hi Javier, > > 2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas osg.samsung.com>: >> >> Hello Inki, >> >> On 12/02/2015 11:11 PM, Inki Dae wrote: >>>

[PATCH] drm/exynos: decon: remove unused variables

2015-12-07 Thread Javier Martinez Canillas
ctx) > static void decon_enable(struct exynos_drm_crtc *crtc) > { > struct decon_context *ctx = crtc->ctx; > - int ret; > - int i; > > if (!test_and_clear_bit(BIT_SUSPENDED, >flags)) > return; > Reviewed-by: Javier Martinez

[PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Inki, On 12/07/2015 09:52 AM, Inki Dae wrote: > From: Javier Martinez Canillas > Thanks a lot for posting this patch. > The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent > since it uses a phandle to describe the connection between the DP port and &

[PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote: > On 07.12.2015 21:52, Inki Dae wrote: >> From: Javier Martinez Canillas >> >> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent >> since it uses a phandle to describe the con

[PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi

2015-12-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/07/2015 09:48 PM, Krzysztof Kozlowski wrote: > On 08.12.2015 00:36, Inki Dae wrote: >> Hi Javier, >> >> 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas > osg.samsung.com>: >>> Hello Inki, >>> >>> On 12/07/201

[PATCH] drm/exynos: atomic check only enabled crtc states

2015-12-09 Thread Javier Martinez Canillas
Hello Inki, On 11/27/2015 10:00 AM, Javier Martinez Canillas wrote: > Hello Andrzej, > > On 11/27/2015 03:57 AM, Andrzej Hajda wrote: >> Since atomic check is called also for disabled crtcs it should skip >> mode checking as it can be uninitialized. The patch fixes

[PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-07 Thread Javier Martinez Canillas
Hello Yakir, On 10/07/2015 08:25 AM, Yakir Yang wrote: > Hi all, > > Friendly ping. :) > > > Best regards, > - Yakir > > Do you have a tree that I can use to test these patches? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-07 Thread Javier Martinez Canillas
Hello Yakir, On 10/07/2015 01:05 PM, Yakir Yang wrote: > Hi Javier, > > On 10/07/2015 05:26 PM, Javier Martinez Canillas wrote: >> Hello Yakir, >> >> On 10/07/2015 11:02 AM, Yakir Yang wrote: >>> Hi Javier, >>> >>> On 10/07/2015 04:4

[PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-07 Thread Javier Martinez Canillas
Hello Yakir, On 10/07/2015 11:02 AM, Yakir Yang wrote: > Hi Javier, > > On 10/07/2015 04:46 PM, Javier Martinez Canillas wrote: >> Hello Yakir, >> >> On 10/07/2015 08:25 AM, Yakir Yang wrote: >>> Hi all, >>> >>> Friendly ping. :) >&g

[PATCH] drm/i915/irq: Fix kernel-doc warnings

2015-10-08 Thread Javier Martinez Canillas
: No description found for parameter 'dev' Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 8ca772deabdb..0344a9181dac 100644 --- a/drivers/gpu/drm/i915

[PATCH] drm/i915/irq: Fix misspelled word register in kernel-doc

2015-10-08 Thread Javier Martinez Canillas
There is a typo in the function i915_handle_error() kernel-doc and the word register is spelled wrongly. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu

[PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-13 Thread Javier Martinez Canillas
e->funcs = _dp_bridge_funcs; > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -151,7 +151,7 @@ > samsung,color-depth = <1>; > samsung,link-rate = <0x06>; > samsung,lane-count = <2>; > - hpd-gpio = < 6 0>; > + hpd-gpios = < 6 0>; > > ports { > port at 0 { > > > Anyway I'm going to send the v6 series, thanks for your good idea. > Great, I'll try to test your latest series on my Peach Pi today. > - Yakir > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-14 Thread Javier Martinez Canillas
Hello Yakir, On 10/13/2015 03:50 PM, Yakir Yang wrote: > On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote: > [snip] >>> And it's better to enable pstore function on mainline kernel, so we can >>> analysis the last log when >>> the mainline kernel

[PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-19 Thread Javier Martinez Canillas
est this series, I suggest you applied this > series on tag-20150918, just need to fix some light conflicts with the 01 & 02 > patches (or just email me, I can send you directly). > > Thanks, Do you have a branch that I can use to test this series? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

  1   2   3   4   5   6   7   8   9   10   >