Re: [Intel-gfx] [PATCH 2/7] drm/i915: Remove link_status field from intel_dp structure

2011-11-02 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:25 -0700 Keith Packard kei...@keithp.com wrote: No persistent data was ever stored here, so link_status is instead allocated on the stack as needed. Signed-off-by: Keith Packard kei...@keithp.com --- I like this cleanup. Reviewed-by: Jesse Barnes jbar

[PATCH] DRM planes

2011-11-02 Thread Jesse Barnes
In response to feedback, I've adjusted the new addfb2 ioctl to take per component pitch and offset args. Generally, the offset[0] field will be 0, but it's conceivable that some metadata could be stored at the start of a given buffer, and an offset[0] allows the client to skip past that.

[PATCH 3/5] drm/i915: rename existing overlay support to legacy

2011-11-02 Thread Jesse Barnes
The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- drivers/gpu

[PATCH 5/5] drm/i915: add destination color key support

2011-11-02 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

[PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-02 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-02 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 236 +++- drivers

Re: [PATCH 1/5] drm: add plane support

2011-11-02 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Accidentally left out the -destroy hook in this one. The drm

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 15:11:55 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Nov 02, 2011 at 01:03:18PM -0700, Jesse Barnes wrote: In response to feedback, I've adjusted the new addfb2 ioctl to take per component pitch and offset args. Generally, the offset[0] field will be 0, but it's

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
fourcc vs rolling our own surface definitions? Thanks, -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 15:33:04 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:20 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc

Re: [PATCH 3/5] drm/i915: rename existing overlay support to legacy

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:21 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. This one has been dropped. I'm

Re: [PATCH 4/5] drm/i915: add SNB and IVB video sprite support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:22 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes jbar

Re: [PATCH 5/5] drm/i915: add destination color key support

2011-11-03 Thread Jesse Barnes
On Wed, 2 Nov 2011 13:03:23 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top

Re: [Intel-gfx] [PATCH] drm/i915: add SNB video sprite support

2011-11-03 Thread Jesse Barnes
in the top level function now. But take a look and see if I'm missing one of the cases you cover here. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 13:55:50 -0500 Rob Clark rob.cl...@linaro.org wrote: On Thu, Nov 3, 2011 at 12:36 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 3 Nov 2011 18:29:14 +0100 Daniel Vetter dan...@ffwll.ch wrote: Hi all, I've discussed this a bit on irc and consensus seems

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job

2011-11-03 Thread Jesse Barnes
register until it shows the correct values. Modulo what we already discussed on irc about the PP_READY bit, and the CodingStyle nitpicks (newlines before {? come on, this isn't X :), Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms

2011-11-03 Thread Jesse Barnes
)) + ironlake_edp_pll_off(encoder); But here it looks like you're shutting it off, then downing the link? Should this be reordered? -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Try harder during dp pattern 1 link training

2011-11-03 Thread Jesse Barnes
, and the DP compliance test should catch any grievous errors, so aside from the bug fix hunk which should be split out: Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Remove trailing white space

2011-11-03 Thread Jesse Barnes
PANEL_LIGHT_ON_DELAY_MASK) PANEL_LIGHT_ON_DELAY_SHIFT; - + cur.t9 = (pp_off PANEL_LIGHT_OFF_DELAY_MASK) PANEL_LIGHT_OFF_DELAY_SHIFT; Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology

Re: [PATCH] DRM planes

2011-11-03 Thread Jesse Barnes
stuff? -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms

2011-11-03 Thread Jesse Barnes
On Thu, 03 Nov 2011 15:30:57 -0700 Keith Packard kei...@keithp.com wrote: On Thu, 3 Nov 2011 13:00:11 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: A few comments on this one (also, is it strictly required to fix your bug)? I think so; the panel definitely was not happy when I

Re: [PATCH 1/5] drm: add plane support

2011-11-03 Thread Jesse Barnes
On Thu, 3 Nov 2011 11:21:18 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 15:33:04 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 2 Nov 2011 13:03:19 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-04 Thread Jesse Barnes
detect it. Oh that's a mistake on my part. RGB24 is generally bpp=32. I'll fix that. This is just a compatibility function, so it only needs to handle cases used by current code. I expect future code to use the fourcc values directly. Thanks, -- Jesse Barnes, Intel Open Source Technology

Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
component seems like a good idea. Also, for planar formats packed into a single buffer object handle (through driver specific multiplexing or non-zero offsets), individual pitches and offsets may be required. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

[PATCH] DRM planes

2011-11-07 Thread Jesse Barnes
Ok this one includes all the minor feedback from last week, and should satisfy Daniel and Jakob enough to get their Reviewed-bys. You can ignore the final patch in the series; it's a WIP power saving feature, but the other ones are working well here. Thanks, Jesse

[PATCH 1/5] drm: add plane support

2011-11-07 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 251 +++- drivers

[PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-07 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core sprite support functions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915

[PATCH 5/5] drm/i915: track sprite coverage and disable primary plane if possible

2011-11-07 Thread Jesse Barnes
To save power when the sprite is full screen, we can disable the primary plane on the same pipe. Track the sprite status and enable/disable the primary opportunistically. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_drv.h|1 + drivers/gpu/drm/i915/intel_sprite.c | 19

[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

2011-11-07 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 4/5] drm/i915: add destination color key support

2011-11-07 Thread Jesse Barnes
Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value in the primary plane before blending the overlay on top. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

[PATCH 1/4] drm: try to restore previous CRTC config if mode set fails

2011-11-07 Thread Jesse Barnes
We restore the CRTC, encoder, and connector configurations, but if the mode set failed, the attached display may have been turned off, so we need to try set_config again to restore things to the way they were. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm

Misc. cleanups

2011-11-07 Thread Jesse Barnes
Just some cleanups for unused fields in drm_crtc.h and some comment corrections. I also removed a few DRM_ERRORs from drm_crtc.c (things actually weren't as bad as I feared). Next step is to remove a whole slew of DRM_DEBUG calls unless people are really attached to them. I find them to just

[PATCH 01/12] drm: remove unused connector_count field from drm_display_mode

2011-11-07 Thread Jesse Barnes
Doesn't really belong here anyway. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8020798..b0df23a 100644 --- a/include/drm/drm_crtc.h

[PATCH 02/12] drm: remove unused save/restore functions from drm_crtc_funcs fix comments

2011-11-07 Thread Jesse Barnes
Remove two unused fields from this struct and cleanup/correct the comments. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 18 -- 1 files changed, 4 insertions(+), 14 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h

[PATCH 03/12] drm: fix comments for drm_crtc struct

2011-11-07 Thread Jesse Barnes
Remove stale entries and update with the latest stuff. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index a960020..ad2a605 100644

[PATCH 04/12] drm: remove unused save/restore fields from drm_connector fix comments

2011-11-07 Thread Jesse Barnes
Also fix up the wrapping to 80 columns. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 20 +++- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index ad2a605..6ab20f8 100644

[PATCH 06/12] drm: add drm_encoder comments

2011-11-07 Thread Jesse Barnes
Just some basic comments about the place and function of the structure and fields. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h

[PATCH 05/12] drm: add comments for drm_encoder_funcs

2011-11-07 Thread Jesse Barnes
Just basic verbiage. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 6ab20f8..a1583d8 100644 --- a/include/drm/drm_crtc.h +++ b

[PATCH 07/12] drm: remove unused fields in drm_connector and document the rest

2011-11-07 Thread Jesse Barnes
We never used initial_x/y or the force_encoder_id, so drop those fields and proide a basic description of the others. Really, the ELD bits belong in drm_display_info rather than directly in the connector, but that's a separate cleanup. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 09/12] drm: document and cleanup drm_mode_config_funcs

2011-11-07 Thread Jesse Barnes
Just fix the wrapping mostly. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index b33713b..a0c7dc6 100644 --- a/include/drm

[PATCH 10/12] drm: document the drm_mode_group structure

2011-11-07 Thread Jesse Barnes
This is actually a core structure with a big future ahead of it. Make it a little less mysterious. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b

[PATCH 11/12] drm: document the drm_mode_config structure

2011-11-07 Thread Jesse Barnes
Including a comment about what the locks are for. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 003cba2

Re: [PATCH 04/12] drm: remove unused save/restore fields from drm_connector fix comments

2011-11-07 Thread Jesse Barnes
On Mon, 07 Nov 2011 20:26:59 + Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 7 Nov 2011 12:03:15 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: Also fix up the wrapping to 80 columns. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/drm_crtc.h

Re: [Intel-gfx] [PATCH 1/5] drm: add plane support

2011-11-08 Thread Jesse Barnes
On Tue, 8 Nov 2011 15:20:37 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 07, 2011 at 10:02:52AM -0800, Jesse Barnes wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code

[PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-08 Thread Jesse Barnes
mode_fb_cmd2 using helpers where the old bpp/depth values are needed. Acked-by: Alan Cox a...@lxorguk.ukuu.org.uk Reviewed-by: Rob Clark rob.cl...@linaro.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c| 112 +++- drivers/gpu

Re: [PATCH 1/2] drm: add plane support

2011-11-08 Thread Jesse Barnes
On Tue, 08 Nov 2011 17:50:51 + Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 8 Nov 2011 09:38:52 -0800, Jesse Barnes jbar...@virtuousgeek.org wrote: +int drm_mode_getplane(struct drm_device *dev, void *data, + struct drm_file *file_priv) +{ + struct

[PATCH 1/2] drm: add plane support

2011-11-08 Thread Jesse Barnes
-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 257 +++- drivers/gpu/drm/drm_drv.c |3 + include/drm/drm.h |3 + include/drm/drm_crtc.h | 75 +- include/drm/drm_mode.h | 33 ++ 5

[PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-08 Thread Jesse Barnes
mode_fb_cmd2 using helpers where the old bpp/depth values are needed. Acked-by: Alan Cox a...@lxorguk.ukuu.org.uk Reviewed-by: Rob Clark rob.cl...@linaro.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c| 108 +++- drivers/gpu

Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Jesse Barnes
. + ret = i915_gem_object_finish_gpu(intel_plane-obj); + if (ret) + goto out_unlock; What's the reason for that finish_gpu here? Slavish emulation of some other teardown code paths. If we ever do flipping on the sprites, I think we'll want it. Thanks, -- Jesse Barnes

Re: [PATCH 4/5] drm/i915: add destination color key support

2011-11-08 Thread Jesse Barnes
On Tue, 8 Nov 2011 23:06:57 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 07, 2011 at 10:02:55AM -0800, Jesse Barnes wrote: Add new ioctls for getting and setting the current destination color key. This allows for simple overlay display control by matching a color key value

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

2011-11-11 Thread Jesse Barnes
On Fri, 11 Nov 2011 10:50:00 + Dave Airlie airl...@gmail.com wrote: On Fri, Nov 11, 2011 at 10:47 AM, Dave Airlie airl...@gmail.com wrote: On Tue, Nov 8, 2011 at 9:18 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: To properly support the various plane formats supported by different

Re: [PATCH 2/7] drm: plane: Fix size of formats memcpy()

2011-11-11 Thread Jesse Barnes
; } - memcpy(plane-format_types, formats, format_count); + memcpy(plane-format_types, formats, sizeof(uint32_t) * format_count); plane-format_count = format_count; plane-possible_crtcs = possible_crtcs; Duh thank you. -- Jesse Barnes, Intel Open Source Technology Center signature.asc

Re: [PATCH 4/7] drm: plane: Check source coordinates

2011-11-11 Thread Jesse Barnes
, plane_req-crtc_w, plane_req-crtc_h, Good sanity check (saves the drivers from having to do it), but I wonder if we can use a better return value like ENOSPC or something to make it easier for userspace to figure out. -- Jesse Barnes, Intel Open Source

Re: [PATCH 6/7] drm: plane: Make 'formats' parameter to drm_plane_init() const

2011-11-11 Thread Jesse Barnes
void drm_encoder_cleanup(struct drm_encoder *encoder); Yeah good fix. I made the structure const at ickle's request (once I stopped assigning it directly) but didn't update the prototype. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [PATCH 7/7] drm: plane: Check that the fb pixel format is supported by the plane

2011-11-11 Thread Jesse Barnes
); + ret = -EINVAL; + goto out; + } + fb_width = fb-width 16; fb_height = fb-height 16; Yeah it's reasonable to hoist this up into generic code. Thanks, -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [PATCH 1/7] drm: Zero initialize drm_mode_fb_cmd2 in legacy addfb ioctl handler

2011-11-11 Thread Jesse Barnes
-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/7] drm: plane: Clear plane.crtc and plane.fb after disable_plane()

2011-11-11 Thread Jesse Barnes
, but this doesn't hurt. Acked-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH 5/7] drm: plane: Check crtc coodrinates against integer overflows in setplane ioctl

2011-11-11 Thread Jesse Barnes
will have to validate the target CRTC rect against the actual pipe dimensions anyway. But it doesn't hurt either, so: Acked-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [PATCH 4/7] drm: plane: Check source coordinates

2011-11-11 Thread Jesse Barnes
On Fri, 11 Nov 2011 19:18:52 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Nov 11, 2011 at 08:24:18AM -0800, Jesse Barnes wrote: On Fri, 11 Nov 2011 18:04:04 +0200 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Make sure

Re: [PATCH 5/7] drm: plane: Check crtc coodrinates against integer overflows in setplane ioctl

2011-11-11 Thread Jesse Barnes
On Fri, 11 Nov 2011 19:11:39 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Fri, Nov 11, 2011 at 09:01:46AM -0800, Jesse Barnes wrote: On Fri, 11 Nov 2011 18:04:05 +0200 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Help

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v2

2011-11-14 Thread Jesse Barnes
On Mon, 14 Nov 2011 11:47:07 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc

Re: [PATCH 1/2] drm: add plane support v2

2011-11-14 Thread Jesse Barnes
On Mon, 14 Nov 2011 11:47:06 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. v2: fix ABI of get_plane - move format_type_ptr to the end

[PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-14 Thread Jesse Barnes
-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c| 111 +++-- drivers/gpu/drm/drm_crtc_helper.c | 51 - drivers/gpu/drm/drm_drv.c |1 + drivers/gpu/drm/i915/intel_display.c | 39

Re: DRM KMS Modesetting

2011-11-14 Thread Jesse Barnes
to modify the resolution the test was searching for to 1920x1200 instead of 1024x600 since I tested on a DP attached monitor, and fix the connector id, but other than that it seemed to work fine. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-14 Thread Jesse Barnes
On Mon, 14 Nov 2011 23:16:44 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 14, 2011 at 12:21:55PM -0800, Jesse Barnes wrote: +#define fourcc_code(a,b,c,d) ((u32)(a) | ((u32)(b) 8) | \ + ((u32)(c) 16) | ((u32)(d) 24)) + +/* RGB codes

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-14 Thread Jesse Barnes
On Mon, 14 Nov 2011 23:24:55 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 14, 2011 at 12:21:55PM -0800, Jesse Barnes wrote: +struct drm_mode_fb_cmd2 { + __u32 fb_id; + __u32 width, height; + __u32 pixel_format; /* fourcc code from videodev2.h

[PATCH 1/2] drm: add plane support v3

2011-11-14 Thread Jesse Barnes
a...@lxorguk.ukuu.org.uk Reviewed-by: Rob Clark rob.cl...@linaro.org Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 257 +++- drivers/gpu/drm/drm_drv.c |3 + include/drm

[PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v5

2011-11-14 Thread Jesse Barnes
a...@lxorguk.ukuu.org.uk Reviewed-by: Rob Clark rob.cl...@linaro.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c| 111 +++-- drivers/gpu/drm/drm_crtc_helper.c | 51 - drivers/gpu/drm/drm_drv.c |1

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-14 Thread Jesse Barnes
On Tue, 15 Nov 2011 00:37:47 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 14, 2011 at 01:35:57PM -0800, Jesse Barnes wrote: On Mon, 14 Nov 2011 23:24:55 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 14, 2011 at 12:21:55PM -0800, Jesse

Re: DRM KMS Modesetting

2011-11-14 Thread Jesse Barnes
? Is it possible to query the EGLImage for width/height? Ok maybe the gen3 vs gen4 EGL image code isn't calculating the width/stride correctly somewhere then. You'd have to walk through the gbm_dri2.c and egl_dri2.c code and see where the width is going off into the weeds. -- Jesse Barnes, Intel Open

Re: [PATCH 1/2] drm: add plane support v2

2011-11-15 Thread Jesse Barnes
On Tue, 15 Nov 2011 13:42:40 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Nov 15, 2011 at 12:40:43PM +1000, Ben Skeggs wrote: On Mon, 2011-11-14 at 12:21 -0800, Jesse Barnes wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-15 Thread Jesse Barnes
... /* [31:0] Cb:Y1:Cr:Y0 8:8:8:8, little endian */ DRM_FOURCC_VYUY... /* [31:0] Y1:Cb:Y0:Cr 8:8:8:8, little endian */ That leaves no room for guesswork. Looks great. Want to send Dave an incremental patch? I'll apply the final version to libdrm for use by userland code. Thanks, -- Jesse

[PATCH] drm/fb: don't call driver set_config if display isn't panned

2011-11-15 Thread Jesse Barnes
to the current crtc config to avoid unnecessary set_config calls. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f7c6854..4dd81f3 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v4

2011-11-15 Thread Jesse Barnes
On Tue, 15 Nov 2011 22:30:36 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Nov 15, 2011 at 08:16:04AM -0800, Jesse Barnes wrote: On Tue, 15 Nov 2011 14:57:02 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: I'm fine with fourccs as long as the defines are named

Re: drm pixel formats update

2011-11-16 Thread Jesse Barnes
plane, we can make do with just one format definition. Don't you still need to know the order? I.e. what's in handle[1], U or V? -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri

Re: [PATCH 2/2] drop planar YUV format with Y Cr Cb plane ordering

2011-11-17 Thread Jesse Barnes
this or not, but dropping these wouldn't remove any functionality. What if your surfaces are packed into a single bo? It would be a pain to move them around in that case... -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: drm pixel formats update

2011-11-17 Thread Jesse Barnes
On Thu, 17 Nov 2011 00:20:44 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Nov 16, 2011 at 01:23:01PM -0800, Jesse Barnes wrote: On Wed, 16 Nov 2011 23:19:38 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: Oh and one extra detail just occured to me regarding

Re: [PATCH 2/2] drop planar YUV format with Y Cr Cb plane ordering

2011-11-17 Thread Jesse Barnes
On Thu, 17 Nov 2011 19:14:07 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Nov 17, 2011 at 09:05:54AM -0800, Jesse Barnes wrote: On Thu, 17 Nov 2011 18:05:14 +0200 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Swapping

Re: DRM KMS Modesetting

2011-11-18 Thread Jesse Barnes
On Fri, 18 Nov 2011 22:35:13 +0100 David Herrmann dh.herrm...@googlemail.com wrote: 2011/11/15 Kristian Høgsberg k...@bitplanet.net: 2011/11/15 David Herrmann dh.herrm...@googlemail.com: 2011/11/15 Kristian Høgsberg k...@bitplanet.net: On Mon, Nov 14, 2011 at 5:54 PM, Jesse Barnes jbar

[PATCH 1/2] libdrm: update drm headers from kernel, including new overlay ioctls structs

2011-12-06 Thread Jesse Barnes
Add structs and functions necessary for the new plane and fb handling code, including a new header, drm_fourcc.h, that includes the surface formats supported by various DRM drivers. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- include/drm/Makefile.am |1 + include/drm/drm.h

Re: [PATCH 1/2] libdrm: update drm headers from kernel, including new overlay ioctls structs

2011-12-06 Thread Jesse Barnes
On Tue, 6 Dec 2011 15:23:57 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: Add structs and functions necessary for the new plane and fb handling code, including a new header, drm_fourcc.h, that includes the surface formats supported by various DRM drivers. Signed-off-by: Jesse Barnes

[PATCH] libdrm: plane addfb2 support

2011-12-07 Thread Jesse Barnes
Import the current kernel bits into libdrm for client code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org diff --git a/include/drm/Makefile.am b/include/drm/Makefile.am index 43695bd..2923ab4 100644 --- a/include/drm/Makefile.am +++ b/include/drm/Makefile.am @@ -26,6 +26,7

Re: [PATCH v2 5/5] drm/exynos: Add plane support with fimd

2011-12-14 Thread Jesse Barnes
pretty good; the only thing that jumped out was that you don't seem to be validating the zpos ioctl parameters for sanity. Not sure if there's much to do, but it may be worth checking for a max zpos or something... -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH 2/2] drm: add support for private planes

2012-01-05 Thread Jesse Barnes
Ok no problem. I think Keith just queued up the i915 bits, but I don't think they've made their way to Dave yet. Jesse On Wed, 4 Jan 2012 22:55:31 -0600 Rob Clark r...@ti.com wrote: note: looks like I need to rebase this patch after exynos drm driver was pulled to drm-next.. if there are

Re: [Intel-gfx] [PULL] drm-intel-next

2012-01-05 Thread Jesse Barnes
and testing, and should have been in -next for many months now (in previous releases!). What can we do to improve the process to get trees updated more regularly and get fixes integrated faster? Thanks, -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-06 Thread Jesse Barnes
functionality. -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required

2012-01-25 Thread Jesse Barnes
requirements for say 16 or 8bpp modes. I see you have another patch to address some of this, but I wonder if we have enough info to calculate the bpp at prepare time so it's set early on for use by both the crtc and encoder code? -- Jesse Barnes, Intel Open Source Technology Center signature.asc

[PATCH] drm: take global drm mutex around sysfs files

2012-02-09 Thread Jesse Barnes
This prevents a race between module init and sysfs access (usually only seen at module reload time, or if somehow your userspace starts fast enough and pokes at /sys/class/drm while the drivers are still initializing). Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm

[RFC] drm: atomic mode set API

2012-02-15 Thread Jesse Barnes
Many of us really want (and need) a way to set the whole display configuration atomically, as well as test a global config. In talking with Rob and Alex here at ELC a bit, I think this may be enough: diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 2a2acda..2864b02 100644 ---

Re: [RFC] drm: atomic mode set API

2012-02-15 Thread Jesse Barnes
On Wed, 15 Feb 2012 17:59:45 -0500 Adam Jackson a...@redhat.com wrote: On 2/15/12 5:42 PM, Jesse Barnes wrote: +#define DRM_SET_CONFIG_TEST (10) /* don't change the config, just test it for validity */ + +struct drm_mode_set_config { + __u64 crtcs; + __u64 crtc_fbs

Re: [RFC] drm: atomic mode set API

2012-02-15 Thread Jesse Barnes
On Thu, 16 Feb 2012 00:12:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Feb 15, 2012 at 05:59:45PM -0500, Adam Jackson wrote: On 2/15/12 5:42 PM, Jesse Barnes wrote: +#define DRM_SET_CONFIG_TEST (10) /* don't change the config, just test it for validity */ + +struct

Re: [RFC] drm: atomic mode set API

2012-02-16 Thread Jesse Barnes
On Thu, 16 Feb 2012 04:46:39 -0800 (PST) Jakob Bornecrantz ja...@vmware.com wrote: - Original Message - Many of us really want (and need) a way to set the whole display configuration atomically, as well as test a global config. In talking with Rob and Alex here at ELC a bit, I

[git pull] Intel drm fixes

2012-02-21 Thread Jesse Barnes
changed, 37 insertions(+), 2 deletions(-) Thanks, -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri

[git pull] Intel drm fixes

2012-02-27 Thread Jesse Barnes
to avoid divide by zero if xpos0 drivers/gpu/drm/i915/intel_display.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri

Re: [git pull] drm fixes

2012-02-27 Thread Jesse Barnes
intended, though at the cost of higher power consumption. Fix just sent to Dave anyway. -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [git pull] drm fixes

2012-02-27 Thread Jesse Barnes
On Mon, 27 Feb 2012 13:33:53 -0300 Eugeni Dodonov eug...@dodonov.net wrote: On Mon, Feb 27, 2012 at 13:09, Jesse Barnes jbar...@virtuousgeek.orgwrote: On Thu, 23 Feb 2012 21:19:20 +0100 Torsten Kaiser just.for.l...@googlemail.com wrote: On Wed, Feb 22, 2012 at 8:56 PM, Dave Airlie

Re: [git pull] Intel drm fixes

2012-02-27 Thread Jesse Barnes
On Mon, 27 Feb 2012 08:08:13 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: The following changes since commit 3ac0eb6d62fde0a60a6c5c61e562af1db8fbf712: drm/radeon/kms/atom: dpms bios scratch reg updates (2012-02-22 10:30:06 +) are available in the git repository at: git

Re: [PATCH resend 1/2] drm: Fix EDID color fromat parsing

2012-02-28 Thread Jesse Barnes
DRM_EDID_FEATURE_RGB_YCRCB422) + info-color_formats |= DRM_COLOR_FORMAT_YCRCB422; /* Get data from CEA blocks if present */ edid_ext = drm_find_cea_extension(edid); Ah that's better. Do you have a TV that reports these feature bits? If so, which model? Reviewed-by: Jesse Barnes jbar

<    1   2   3   4   5   6   7   8   9   >