Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_sman.c |4 +---
drivers/gpu/drm/i915/i915_dma.c |3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_sman.c b/drivers/gpu/drm/drm_sman.c
index 463aed9..3466458 100644
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/radeon/radeon_ttm.c |2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/radeon/radeon_ttm.c |2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c |2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon
Resend removal of remaining casts of private_data
Joe Perches (13):
drivers/gpu/drm: Remove unnecessary casts of private_data
drivers/infiniband: Remove unnecessary casts of private_data
drivers/net/wireless/iwlwifi: Remove unnecessary casts of private_data
drivers/s390: Remove
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/ttm/ttm_page_alloc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c
b/drivers/gpu/drm/ttm/ttm_page_alloc.c
index ca90479..578ea3b 100644
--- a/drivers/gpu/drm/ttm
Convert the uses that should be const of
char *foo[] = {bar, baz};
to
const char * const foo[] = {bar, baz};
or
static const char * const foo[] = {bar, baz};
Joe Perches (16):
arch/alpha: Use static const char * const where possible
arch/ia64: Use static const char
On Mon, 2010-09-27 at 11:10 -0400, John W. Linville wrote:
On Sun, Sep 26, 2010 at 11:31:15AM -0700, Justin P. Mattock wrote:
Below is an updated patch from the original fixing broken web addresses in
the kernel.
Thanks for all the help and info on this to everybody..
Hopefully I didnt
On Wed, 2010-10-20 at 13:51 +0800, Lee, Chun-Yi wrote:
Currently, there have no GMA500(Poulsbo) native video driver to support
intel opregion. So, use this stub driver to enable the acpi backlight
control sysfs entry files by requrest acpi_video_register.
[]
diff --git
Joe Perches (9):
drivers/ata: typo fix of faild to failed
drivers/gpu: typo fix of faild to failed
drivers/net: typo fix of faild to failed
drivers/rtc: typo fix of faild to failed
drivers/video: typo fix of faild to failed
fs/exofs: typo fix of faild to failed
fs/jfs: typo fix
Coalesce long formats.
Align arguments.
Add missing newlines.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_crtc_helper.c |2 +-
drivers/gpu/drm/i915/i915_gem.c |3 +--
drivers/gpu/drm/radeon/evergreen.c|2 +-
drivers/gpu/drm/radeon/r100.c
output
Remove any KERN_level from WARN uses
Coalesce formats
Align WARN arguments
Add some missing newlines to WARN uses
Add some missing first test argument (1, fmt, args) to WARN uses
Joe Perches (39):
include/asm-generic/bug.h: Update WARN macros
arch/alpha: Update WARN uses
arch/arm: Update
Joe Perches (4):
drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments
drivers/scsi/pmcraid.c: Fix k.alloc switched arguments
drivers/staging/udlfb/udlfb.c: Fix k.alloc switched arguments
scripts/checkpatch.pl: Add check for k.alloc GFP as first argument
drivers/gpu/drm/vmwgfx
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
index
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/via/via_dmablit.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/via/via_dmablit.c
b/drivers/gpu/drm/via/via_dmablit.c
index 9b5b4d9..3e038a3 100644
--- a/drivers/gpu/drm/via
Converted vmalloc/memset and vmalloc_node/memset to
vzalloc or vzalloc_node using a cocci script and some editing
Reduces text a little bit.
Compiled x86 only.
There are still vmalloc_32 with memset calls still around.
Broken out to multiple patches to cc appropriate maintainers.
Joe Perches
Using %pV reduces the number of printk calls and
eliminates any possible message interleaving from
other printk calls.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_stub.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm
On Tue, 2010-11-09 at 21:16 -0500, Kristian Høgsberg wrote:
On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches j...@perches.com wrote:
Using %pV reduces the number of printk calls and
eliminates any possible message interleaving from
other printk calls.
Wouldn't it be easier and more convenient
On Wed, 2010-11-10 at 14:48 -0800, Luis R. Rodriguez wrote:
When was this added upstream BTW? I ask for backport considerations.
commit 7db6f5fb65a82af03229eef104dc9899c5eecf33
Author: Joe Perches j...@perches.com
Date: Sun Jun 27 01:02:33 2010 +
vsprintf: Recursive vsnprintf: Add %pV
IS_ERR already uses unlikely, remove unlikely from the call sites.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/ttm/ttm_tt.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index af789dc
((unsigned long)ptr);
}
Sending directly to maintainers for now, will resend in a month
or so only to trivial if not picked up.
Joe Perches (15):
drm: Remove duplicate unlikely from IS_ERR
stmmac: Remove duplicate unlikely from IS_ERR
rtc: Remove duplicate unlikely from IS_ERR
s390
On Thu, 2010-12-09 at 12:03 -0800, Joe Perches wrote:
Tobias Klauser tklau...@distanz.ch sent a patch to remove
an unnecessary unlikely from drivers/misc/c2port/core.c,
https://lkml.org/lkml/2010/12/9/199
It seems that Tobias did send all the appropriate patches,
not as a series
kzalloc'd memory doesn't need a memset to 0.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
index 10ca97e
256 375335 5ba27 drivers/gpu/drm/built-in.o.old
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_stub.c | 21 +
include/drm/drmP.h | 21 +++--
2 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm
Add __attribute__((format (printf, 4, 5))) to drm_ut_debug_printk
and fix fallout.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_irq.c |9 +
drivers/gpu/drm/i915/intel_bios.c |6 +++---
drivers/gpu/drm/i915/intel_display.c|8
Reduce the text space required and verify debug arguments.
Joe Perches (2):
drm: Create and use drm_err
drm: Verify debug message arguments
drivers/gpu/drm/drm_irq.c |9 +
drivers/gpu/drm/drm_stub.c | 21 +
drivers/gpu/drm/i915
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote:
I believe that DRM_NAME is a define, and drm_stub.c is in common code.
As a result, won't this change cause something different to get logged?
Nope. DRM_NAME is #defined only once.
include/drm/drm.h:#define DRM_NAME drm
The only
On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
@@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
i915_lvds_downclock) {
dev_priv-lvds_downclock_avail = 1;
dev_priv-lvds_downclock = temp_downclock;
-
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote:
On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
- DRM_DEBUG_KMS(LVDS downclock is found in VBT. ,
- Normal Clock %dKHz
Just neatening.
Joe Perches (5):
drbd: Use angle brackets for system includes
drm: Use angle brackets for system includes
aix94xx: Use angle brackets for system includes
ALSA: asihpi: Use angle brackets for system includes
staging: msm: Use angle brackets for system includes
drivers
Use the normal include style.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/drm_ioctl.c |2 +-
drivers/gpu/drm/i915/i915_gem_tiling.c|4 ++--
drivers/gpu/drm/nouveau/nouveau_drv.h | 10 +-
drivers/gpu/drm/ttm/ttm_agp_backend.c
hex filename
743693 20203 174552 938448 e51d0 drivers/gpu/drm/nouveau/built-in.o.new
777371 20203 181936 979510 ef236 drivers/gpu/drm/nouveau/built-in.o.old
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/nouveau/nouveau_drv.c | 20 ++
drivers/gpu/drm
hex filename
781185 25499 176860 983544 f01f8 drivers/gpu/drm/nouveau/built-in.o.new
820650 25499 184356 1030505 fb969 drivers/gpu/drm/nouveau/built-in.o.old
Signed-off-by: Joe Perches j...@perches.com
---
Modified resend of https://lkml.org/lkml/2011/6/28/505
drivers/gpu/drm
Use a more current logging style. Ensure that appropriate
logging messages are prefixed with i915: .
Convert printks to pr_level. Align arguments.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/i915/i915_dma.c |6 ++-
drivers/gpu/drm/i915/i915_irq.c | 70
Use the more current logging style.
Add pr_fmt and remove the TTM_PFX uses.
Coalesce formats and align arguments.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/ttm/ttm_agp_backend.c|4 +-
drivers/gpu/drm/ttm/ttm_bo.c | 72
Use a more current logging style. Ensure that appropriate
logging messages are prefixed with i915: .
Convert printks to pr_level. Align arguments.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/i915/i915_dma.c |6 ++-
drivers/gpu/drm/i915/i915_irq.c | 70
dev_level create smaller objects than dev_printk(KERN_LEVEL.
Convert non-debug calls to this form.
Joe Perches (16):
tile: Convert dev_printk(KERN_LEVEL to dev_level(
ata: Convert dev_printk(KERN_LEVEL to dev_level(
drivers: base: Convert dev_printk(KERN_LEVEL to dev_level(
block: Convert
dev_level calls take less code than dev_printk(KERN_LEVEL
and reducing object size is good.
Coalesce multiline formats for easier grep.
Coalesce unnecessarily segmented formats on a single line too.
Remove trailing space after newline in a format.
Signed-off-by: Joe Perches j...@perches.com
On Sun, 2012-10-28 at 14:54 +0400, Sergei Shtylyov wrote:
Hello.
Hi Sergei.
On 28-10-2012 12:05, Joe Perches wrote:
dev_level create smaller objects than dev_printk(KERN_LEVEL.
Convert non-debug calls to this form.
Joe Perches (16):
tile: Convert dev_printk(KERN_LEVEL
On Wed, 2012-11-28 at 12:10 +0100, Thierry Reding wrote:
Add myself as the maintainer of the NVIDIA Tegra DRM driver.
diff --git a/MAINTAINERS b/MAINTAINERS
[]
@@ -2504,6 +2504,14 @@ S: Supported
F: drivers/gpu/drm/exynos
F: include/drm/exynos*
+NVIDIA TEGRA DRM DRIVER
On Thu, 2012-12-13 at 16:04 +0200, Terje Bergstrom wrote:
Add support for host1x debugging. Adds debugfs entries, and dumps
channel state to UART in case of stuck job.
trivial note:
[]
diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
[]
+void host1x_debug_output(struct
On Mon, 2012-12-17 at 16:01 +0200, Terje Bergström wrote:
Considering the amount of feedback I've received from the patches, they
must be top notch quality!
Maybe.
Maybe no one else has the hardware.
___
dri-devel mailing list
On Sun, 2012-12-23 at 11:01 +, Andy Furniss wrote:
Borislav Petkov wrote:
[ 28.191072] radeon: `0' invalid for parameter `wb'
although the whole driver blubber didn't appear on the console fterwards
aso something got turned off allright.
Then, I went and tried radeon.no_wb
On Wed, 2013-03-06 at 12:31 -0700, Stephen Warren wrote:
On 03/06/2013 12:14 PM, Marcin Slusarz wrote:
On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote:
On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote:
Dropping Tegra ML, it's not the place where Nouveau mails
On Wed, 2013-03-06 at 16:36 -0700, Stephen Warren wrote:
From: Stephen Warren swar...@nvidia.com
Create a new N: entry type in MAINTAINERS which performs a regex match
against filenames; either those extracted from patch +++ or --- lines,
or those specified on the command-line using the -f
On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote:
From: Stephen Warren swar...@nvidia.com
This reverts most of eb90d08 get_maintainer: allow keywords to match
filenames; all except the parts that are required to implement the new
N: entry type.
Just combine patches 1 and 3 into a
On Wed, 2013-03-06 at 17:34 -0700, Stephen Warren wrote:
On 03/06/2013 05:30 PM, Joe Perches wrote:
On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote:
From: Stephen Warren swar...@nvidia.com
This reverts most of eb90d08 get_maintainer: allow keywords to match
filenames; all except
On Wed, 2013-03-06 at 23:47 -0700, Stephen Warren wrote:
On 03/06/2013 05:40 PM, Joe Perches wrote:
Which is why I showed the whole thing in a single patch.
No worries if it's simply to increase the patch count...
I'm not sure what showed refers to?
The changes I posted
On Mon, 2013-03-11 at 22:39 +0200, Alexandru Gheorghiu wrote:
Replaced calls to kmalloc followed by memcpy with a single call to kmemdup.
Also removed a now redundant if statement.
[]
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
[]
@@ -2335,11 +2335,8 @@
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote:
On 2013年04月07日 11:49, Greg KH wrote:
On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote:
Hello Greg KH:
when you have time, can you help to check this patch whether OK ?
No.
Why ? does it also need a test ??
Greg's not the
On Sat, 2013-07-27 at 23:18 +0530, santosh.anbu wrote:
From: santosh.anbu asantosh.k...@gmail.com
[]
diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
index cfb9288..e88529c 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
Just a few cleanups to use zalloc style calls and reduce
the uses of __GFP_ZERO for kmem_cache_alloc[_node] uses.
Use the more kernel normal zalloc style.
Joe Perches (6):
slab/block: Add and use kmem_cache_zalloc_node
block: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc
The helper exists, might as well use it instead of __GFP_ZERO.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 8a0eb96
On Mon, 2013-09-16 at 08:46 -0700, Olof Johansson wrote:
On Mon, Sep 16, 2013 at 8:17 AM, Thierry Reding
thierry.red...@gmail.com wrote:
On Wed, Sep 11, 2013 at 09:41:49PM -0700, Olof Johansson wrote:
This removes two warnings where dma_addr_t variables were printed using
%x when built
On Tue, 2017-02-21 at 11:02 +0200, Jani Nikula wrote:
> On Tue, 21 Feb 2017, Joe Perches <j...@perches.com> wrote:
> > On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote:
> > > You know how this stuff works, please split it up to get the stuff
> > > mer
On Mon, 2017-02-20 at 12:17 +, Eric Engestrom wrote:
> On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote:
> > drm_printf does not currently use the compiler to verify
> > format and arguments. Make it do so.
> >
> > Miscellanea:
> >
> > o Add
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/gpu
Prior to this patch, there were 15 uses of pr_warning and
20 uses of pr_warn in drivers/gpu
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote:
> On 23 February 2017 at 17:18, Joe Perches <j...@perches.com> wrote:
> > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <j...@perches.com> wrote
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <j...@perches.com> wrote:
> > There are ~4300 uses of pr_warn and ~250 uses of the older
> > pr_warning in the kernel source tree.
> >
> > Make the use of pr_
On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote:
> You know how this stuff works, please split it up to get the stuff
> merged.
Quite well actually.
Fix it as you think appropriate.
But in any case, fix it.
___
dri-devel mailing list
drm_printf does not currently use the compiler to verify
format and arguments. Make it do so.
Miscellanea:
o Add appropriate #include files for __printf and struct va_format
o Convert dev_printk to dev_info
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/drm_print
with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
Miscellanea:
o Coalesce formats and realign arguments
Some files not compiled - no cross-compilers
Joe Perches (35):
alpha: Convert remaining uses of pr_warning to pr_warn
ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn
ix types in a section.
Signed-off-by: Joe Perches
---
 scripts/get_maintainer.pl | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index aed4511f0304..633f2dd3de27 100755
--- a/scripts/get_maintainer.pl
+++ b/scri
On Mon, 2016-10-24 at 23:30 +0100, Colin King wrote:
> From: Colin Ian King
>
> Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
> printk messages.
trivia:
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
> b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
[]
On Thu, 2016-09-22 at 19:46 +0200, SF Markus Elfring wrote:
> The local variable "n" was not modified after it was initialized with
> a few text strings.
> Thus express this detail also by the data type qualifier "const".
[]
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>
On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote:
> These patches fix cases where the documentation above a function definition
> is not consistent with the function header. Issues are detected using the
> semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic
> patch
Joe Perches (2):
drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE
drm: Simplify drm_printk to reduce object size quite a bit
drivers/gpu/drm/drm_drv.c | 5 +--
drivers/gpu/drm/i915/intel_guc_loader.c | 22 +++--
include/drm/drmP.h | 56
Use a bit more consistent style with kernel loglevels without
using macro argument concatenation.
Miscellanea:
o Single statement macros don't need do {} while (0)
Signed-off-by: Joe Perches
---
drivers/gpu/drm/i915/intel_guc_loader.c | 22 --
include/drm/drmP.h
sed and not
worth conversion
Signed-off-by: Joe Perches
---
drivers/gpu/drm/drm_drv.c | 5 +++--
include/drm/drmP.h| 30 ++
2 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 80c
On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote:
> > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote:
> > Use a bit more consistent style with kernel loglevels
> > I'm not convinced this is worth doing if we're going to keep the
> WARN/WARNING discrepancy, and I
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote:
> On 27 September 2016 at 17:04, Joe Perches wrote:
> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote:
> > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote:
> > > > Use a bit more consistent style w
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote:
> On 27 September 2016 at 17:04, Joe Perches wrote:
> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote:
> > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote:
> > > > Use a bit more consistent style w
Joe Perches (2):
drm: Use pr_cont where appropriate
gpu: drm: Convert printk(KERN_ to pr_
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 +-
drivers/gpu/drm/amd
Use a more common logging style.
Miscellanea:
o Coalesce formats and realign arguments
o Neaten a few macros now using pr_
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c
rary const char * instead of multiple printks
o Remove trailing space from logging by using a leading space instead
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 70
drivers/gpu/drm/radeon/r600_
Use a more common logging style.
Miscellanea:
o Coalesce formats and realign arguments
o Neaten a few macros now using pr_
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 9 -
drivers/gpu/drm/gma500/oaktrail_lvds.c
Broken up for Daniel Vetter
Joe Perches (3):
gpu: drm: amd/radeon: Convert printk(KERN_ to pr_
gpu: drm: core: Convert printk(KERN_ to pr_
gpu: drm: drivers: Convert printk(KERN_ to pr_
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c
Use a more common logging style.
Miscellanea:
o Coalesce formats and realign arguments
o Neaten a few macros now using pr_
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c
Use a more common logging style.
Miscellanea:
o Coalesce formats and realign arguments
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/gpu/drm/drm_cache.c | 12 ++--
drivers/gpu/drm/drm_edid.c | 4 ++--
drivers/gpu/drm/drm_ioc32.c | 3 +--
3 files changed, 9 inse
On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote:
> 2016-04-26 Lucas Stach :
> > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan:
> > > From: Gustavo Padovan
> > >
> > > This function had copies in 3 different files. Unify them in ke
On Fri, 2016-08-05 at 20:30 -0400, Lyude wrote:
> There's a couple of places where this would be useful for drivers (such
> as reporting DP aux transaction timeouts).
Maybe a single static _rs or one for each type would
be better than an individual _rs per callsite.
On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
> In an if block for (running == 0) running cannot be non-zero.
This code could also be better unindented by one level
(all of the block would fit 80 columns) by changing:
if (running == 0) {
[code...]
On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote:
> Components m1, m2, p2, dot, vco of variable clock should be
> initialized to avoid bytes from the kernel stack to be
> exposed.
How was this found? visual code inspection?
And isn't this true for mrst_lvds_find_best_pll as well?
>
On Sun, 2016-08-21 at 20:45 +0200, Heinrich Schuchardt wrote:
> On 08/21/2016 08:29 PM, Joe Perches wrote:
> > On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
> > > In an if block for (running == 0) running cannot be non-zero.
> > This code could also be
On Sun, 2016-08-21 at 21:35 +0200, Heinrich Schuchardt wrote:
> On 08/21/2016 08:46 PM, Joe Perches wrote:
> > On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote:
> > > Components m1, m2, p2, dot, vco of variable clock should be
> > > initialized to avoid
On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote:
> It does not make sense to check if table is NULL
> and afterwards to dereference it without
> considering the result.
This makes no sense.
> The inconsistency was indicated by cppcheck.
Perhaps this is a defect in cppcheck?
> An
On Sun, 2016-08-21 at 23:20 +0200, Heinrich Schuchardt wrote:
> On 08/21/2016 11:06 PM, Joe Perches wrote:
> > On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote:
> > >
> > > It does not make sense to check if table is NULL
> > > and
On Thu, 2016-11-03 at 10:07 +0100, Paul Bolle wrote:
> On Mon, 2016-10-24 at 11:05 -0700, Joe Perches wrote:
> > Jani Nikula proposes patches to add a few new letter prefixes
> > for "B:" bug reporting and "C:" maintainer chatting to the
> > various sectio
On Mon, 2016-06-20 at 12:53 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Fix paths in the comments.
Why is it useful to have the path or filename embedded
in the file at
all?
On Fri, 2016-01-15 at 12:55 -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> This patch series de-stage the sync framework, and in order to accomplish that
> a bunch of cleanups/improvements on the sync and fence were made.
Perhaps add/update a MAINTAINERS entry too?
On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> This series introduces a family of generic string case conversion
> functions. This kind of functionality is needed in several places in
> the kernel. Right now, everybody seems to be implementing their own
> copy of this functionality.
>
>
On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote:
> On 5 July 2016 at 15:14, Joe Perches wrote:
> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> > > This series introduces a family of generic string case conversion
> > > functions. This kind of functio
.c and .h source files should not be executable, change
the permissions to 0644.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_d.h | 0
drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_sh_mask.h | 0
drivers/gpu/drm/amd/include/cgs_common.h
.c and .h source files should not be executable, change
the permissions to 0644.
Signed-off-by: Joe Perches
Acked-by: David Howells
---
Linus, Andrew Morton suggested privately that you apply this
directly as his toolchain doesn't support
rename/permission only patches.
Apparently, Andrew
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.
This is only used by gpu/drm.
I think this is a poor name for a generic function
that would be in kernel.h.
Isn't there an include file in linux/drm that's
On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> 2016-03-17 Gustavo Padovan :
> > 2016-03-17 Joe Perches :
> > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > >
> > > > This function had copies in 3 different files. Unify th
On Thu, 2016-03-17 at 16:33 -0400, Rob Clark wrote:
> On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote:
> > On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> > > 2016-03-17 Gustavo Padovan :
> > > > 2016-03-17 Joe Perches :
> > > > > On Th
On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
[]
> > It's a name that seems like it should be a straightforward
> > cast of a kernel pointer to a __user pointer like:
> >
> > static inline void __user *to_user
On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote:
> 2016-03-17 Joe Perches :
> > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
> > []
> > > > It's a name that seems like it should be a stra
On Fri, 2016-03-18 at 10:27 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> This function had copies in 3 different files. Unify them in
> kernel.h.
This function might be used more in drm files
in a separate patch too:
$ git grep -n -E "__user.*\(\s*uintptr_t\s*\)" drivers/gpu/drm
Use the newly added u64_to_user_pointer a bit more frequently.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/armada/armada_gem.c| 2 +-
drivers/gpu/drm/nouveau/nouveau_gem.c | 7 ---
drivers/gpu/drm/tegra/drm.c| 15 ---
drivers/gpu/drm/vc4/vc4_bo.c
1 - 100 of 486 matches
Mail list logo
