objtool warning: "duplicate frame pointer save"

2016-05-25 Thread Josh Poimboeuf
On Wed, May 25, 2016 at 10:14:24AM -0700, Linus Torvalds wrote: > Josh, > my current git version (with gcc 5.3.1) makes objtool warn about > "duplicate frame pointer save" in drivers/gpu/drm/vmwgfx/vmwgfx_msg.c > for both vmw_send_msg() and vmw_host_get_guestinfo(). > > The reason is that

[PATCH] drm/vmwgfx: fix "duplicate frame pointer save" warning

2016-05-26 Thread Josh Poimboeuf
On Wed, May 25, 2016 at 04:51:21PM -0700, Linus Torvalds wrote: > On Wed, May 25, 2016 at 10:56 AM, Josh Poimboeuf > wrote: > > > > I used to have a STACKTOOL_IGNORE_INSN macro that would tell the tool to > > skip warnings for specific instructions in inline asm: &

[PATCH] drm/radeon: refactor CIK tiling table initialization

2016-03-07 Thread Josh Poimboeuf
ialization is still being written would be greatly appreciated! ] Reported-by: kbuild test robot Signed-off-by: Josh Poimboeuf --- Based on linux-next. drivers/gpu/drm/radeon/cik.c | 1352 ++ 1 file changed, 325 insertions(+), 1027 deletions(-) diff --git a/d

[PATCH] drm/radeon: refactor CIK tiling table initialization

2016-03-09 Thread Josh Poimboeuf
On Mon, Mar 07, 2016 at 11:45:36PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Josh Poimboeuf [mailto:jpoimboe at redhat.com] > > Sent: Monday, March 07, 2016 6:10 PM > > To: Deucher, Alexander; Koenig, Christian > > Cc: dri-devel a

[PATCH v2 1/2] drm/radeon: refactor CIK tiling table initialization

2016-03-11 Thread Josh Poimboeuf
Simplify the control flow of cik_tiling_mode_table_init() similar to how it was done in gfx_v7_0.c and gfx_v8_0.c. Signed-off-by: Josh Poimboeuf --- drivers/gpu/drm/radeon/cik.c | 1691 +- 1 file changed, 666 insertions(+), 1025 deletions(-) diff --git

[PATCH v2 2/2] drm/radeon: refactor SI tiling table initialization

2016-03-11 Thread Josh Poimboeuf
Simplify the control flow of si_tiling_mode_table_init() similar to how it was done in gfx_v7_0.c and gfx_v8_0.c. Signed-off-by: Josh Poimboeuf --- drivers/gpu/drm/radeon/si.c | 925 +--- 1 file changed, 439 insertions(+), 486 deletions(-) diff --git

Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335

2017-07-14 Thread Josh Poimboeuf
On Fri, Jul 14, 2017 at 06:33:01PM +0200, Mike Galbraith wrote: > On Fri, 2017-07-14 at 18:10 +0200, Peter Zijlstra wrote: > > On Fri, Jul 14, 2017 at 05:58:18PM +0200, Mike Galbraith wrote: > > > On Fri, 2017-07-14 at 17:50 +0200, Peter Zijlstra wrote: > > > > > > Urgh, is for some mysterious

Re: [patch V2 01/29] tracing: Cleanup stack trace code

2019-04-18 Thread Josh Poimboeuf
On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote: > - Remove the extra array member of stack_dump_trace[]. It's not required as > the stack tracer stores at max array size - 1 entries so there is still > an empty slot. What is the empty slot used for? -- Josh

Re: [patch V2 28/29] stacktrace: Provide common infrastructure

2019-04-18 Thread Josh Poimboeuf
On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote: > All architectures which support stacktrace carry duplicated code and > do the stack storage and filtering at the architecture side. > > Provide a consolidated interface with a callback function for consuming the > stack entries

Re: [patch V2 28/29] stacktrace: Provide common infrastructure

2019-04-19 Thread Josh Poimboeuf
On Fri, Apr 19, 2019 at 09:02:11AM +0200, Peter Zijlstra wrote: > On Thu, Apr 18, 2019 at 05:42:55PM +0200, Thomas Gleixner wrote: > > On Thu, 18 Apr 2019, Josh Poimboeuf wrote: > > > > Another idea I had (but never got a chance to work on) was to extend the > > &g

Re: [patch V2 28/29] stacktrace: Provide common infrastructure

2019-04-19 Thread Josh Poimboeuf
On Fri, Apr 19, 2019 at 11:07:17AM +0200, Peter Zijlstra wrote: > On Fri, Apr 19, 2019 at 10:32:30AM +0200, Thomas Gleixner wrote: > > On Fri, 19 Apr 2019, Peter Zijlstra wrote: > > > On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote: > > > > > > > +typedef bool

Re: [patch V3 21/29] tracing: Use percpu stack trace buffer more intelligently

2019-04-25 Thread Josh Poimboeuf
On Thu, Apr 25, 2019 at 11:45:14AM +0200, Thomas Gleixner wrote: > @@ -2788,29 +2798,32 @@ static void __ftrace_trace_stack(struct >*/ > preempt_disable_notrace(); > > - use_stack = __this_cpu_inc_return(ftrace_stack_reserve); > + stackidx =

Re: [patch V3 24/29] tracing: Remove the last struct stack_trace usage

2019-04-25 Thread Josh Poimboeuf
On Thu, Apr 25, 2019 at 11:45:17AM +0200, Thomas Gleixner wrote: > Simplify the stack retrieval code by using the storage array based > interface. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Steven Rostedt (VMware) > --- > kernel/trace/trace_stack.c | 37

Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage

2019-04-25 Thread Josh Poimboeuf
- Removed the '-1' oddity from the tracer > > - Restricted the tracer nesting to 4 > > - Restored the lockdep magic to prevent redundant stack traces > > - Addressed the small nitpicks here and there > > - Picked up Acked/Reviewed tags Other than the 2

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-06 Thread Josh Poimboeuf
; > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > > > > > > > Objtool reports: > > > > > > >

[PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Josh Poimboeuf
;i915: fix missing user_access_end() in page fault exception case") Reported-by: Thomas Gleixner Reported-by: Sedat Dilek Acked-by: Peter Zijlstra (Intel) Tested-by: Nick Desaulniers Tested-by: Sedat Dilek Link: https://github.com/ClangBuiltLinux/linux/issues/617 Signed-off-by: Josh

Re: [PATCH v7 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-07-09 Thread Josh Poimboeuf
to objtool's noreturn list. > > Reported-by: kbuild test robot > Signed-off-by: Brendan Higgins > Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html > Cc: Josh Poimboeuf > Cc: Peter Zijlstra > --- > tools/objtool/check.c | 1 + > 1 file changed, 1 insert

Re: [PATCH 04/13] livepatch: move klp_find_object_module to module.c

2021-01-21 Thread Josh Poimboeuf
On Thu, Jan 21, 2021 at 08:49:50AM +0100, Christoph Hellwig wrote: > @@ -820,14 +796,25 @@ static int klp_init_object(struct klp_patch *patch, > struct klp_object *obj) > const char *name; > > obj->patched = false; > - obj->mod = NULL; Why was this line removed? > if

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-12-12 Thread Josh Poimboeuf
On Mon, Dec 11, 2023 at 11:12:42PM -0800, Christoph Hellwig wrote: > On Thu, Dec 07, 2023 at 10:49:53PM -0600, Samuel Holland wrote: > > Actually tracking all possibly-FPU-tainted functions and their call sites is > > probably possible, but a much larger task. > > I think objtool should be able

[tip:core/urgent] objtool, drm/vmwgfx: Fix "duplicate frame pointer save" warning

2016-06-08 Thread tip-bot for Josh Poimboeuf
Commit-ID: 0b0d81e3b7334897da9b2e3ffee860c2046f7bc0 Gitweb: http://git.kernel.org/tip/0b0d81e3b7334897da9b2e3ffee860c2046f7bc0 Author: Josh Poimboeuf AuthorDate: Thu, 26 May 2016 13:43:43 -0500 Committer: Ingo Molnar CommitDate: Wed, 8 Jun 2016 15:36:18 +0200 objtool, drm/vmwgfx: Fix