[PATCH RFC 1/3] drm/drm_bridge: adjust bridge module's refcount

2016-12-01 Thread Jyri Sarha
the bridges. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/drm_bridge.c | 78 +++- include/drm/drm_bridge.h | 10 +- 2 files changed, 78 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index

[PATCH RFC 2/3] drm/bridge: ti-tfp410: Adapt to bridge object and module refcounting

2016-12-01 Thread Jyri Sarha
Signed-off-by: Jyri Sarha --- drivers/gpu/drm/bridge/ti-tfp410.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index b054ea3..f0c81dd 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c

[PATCH RFC 3/3] drm/tilcdc: Adapt to bridge object refcounting

2016-12-01 Thread Jyri Sarha
Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_external.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c index 80184f0..31c6092 100644 --- a/drivers/gpu/drm

[bug report] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-12-07 Thread Jyri Sarha
On 12/06/16 15:28, Dan Carpenter wrote: > Hello Jyri Sarha, > > The patch dc55ac3b52e6: "drm/bridge: Add ti-tfp410 DVI transmitter > driver" from Oct 31, 2016, leads to the following static checker > warning: > > drivers/gpu/drm/bridge/ti-tfp410

[bug report] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-12-07 Thread Jyri Sarha
On 12/07/16 16:46, Daniel Vetter wrote: >> > This implementation is a hack in the first place. The code will be >> > removed when DRM has a proper generic connector support. > Hm, what's this generic drm connector thing you talk about? What's it for? > Asking since I haven't seen that yet nor

[PATCH RFC 0/3] drm/bridge: adjust bridge module's refcount and more

2016-12-08 Thread Jyri Sarha
There has been no comments to these patches, so I guess there are no major objections. I can go forward with this, and I think a similar job should be done for drm_panel too. But I wonder if this should be done for 4.10 any more? Best regards, Jyri On 12/01/16 17:52, Jyri Sarha wrote: > N

tilcdc: vblank wait timed out

2016-12-12 Thread Jyri Sarha
On 12/05/16 19:07, Bartosz Golaszewski wrote: > 2016-12-05 12:01 GMT+01:00 Bartosz Golaszewski : >> Hi Jyri, >> >> I pulled your recent tilcdc pull request on top of v4.9 and Sekhar's >> davinci branch (+ vga dac DT)[1]. >> >> I'm getting "vblank wait timed out" errors when running simple

[PATCH v4 3/5] drm: bridge: Link encoder and bridge in core code

2016-12-16 Thread Jyri Sarha
and optional previous bridge to perform that task, > update all the callers. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> > Acked-by: Stefan Agner # For DCU > Acked-by: Boris Brezillon # For > atmel-hlcdc > Acked-by: Vincent

[PATCH RFC v5 0/8] Implement generic ASoC HDMI codec and use it in tda998x

2016-02-17 Thread Jyri Sarha
tp://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/095596.html Best regards, Jyri Jean-Francois Moine (1): drm/i2c: tda998x: Add support of a DT graph of ports Jyri Sarha (7): ALSA: pcm: add IEC958 channel status helper for hw_params ASoC: hdmi-codec: Add hdmi-codec for external HDM

[PATCH RFC v5 1/8] ALSA: pcm: add IEC958 channel status helper for hw_params

2016-02-17 Thread Jyri Sarha
Add IEC958 channel status helper that gets the audio properties from snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to produce the channel status bits already in audio stream configuration phase. Signed-off-by: Jyri Sarha --- include/sound/pcm_iec958.h | 2 ++ sound/core

[PATCH RFC v5 2/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2016-02-17 Thread Jyri Sarha
of similar structures in ASoC headers. This is on purpose to avoid direct dependencies to ASoC structures in video side driver. Signed-off-by: Jyri Sarha --- include/sound/hdmi-codec.h| 100 +++ sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc

[PATCH RFC v5 3/8] ASoC: hdmi-codec: Add audio abort() callback for video side to use

2016-02-17 Thread Jyri Sarha
Add audio abort() callback, that is provided at audio stream start, for video side. This is for video side to use in case there is a pressing need to tear down the audio playback for some reason. Signed-off-by: Jyri Sarha --- include/sound/hdmi-codec.h| 8 ++-- sound/soc/codecs/hdmi

[PATCH RFC v5 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2016-02-17 Thread Jyri Sarha
slave encoder. The new file include/sound/tda998x.h prepares to the definition of a tda998x CODEC. Signed-off-by: Jean-Francois Moine Signed-off-by: Jyri Sarha --- .../devicetree/bindings/display/bridge/tda998x.txt | 51 drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH RFC v5 5/8] drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing

2016-02-17 Thread Jyri Sarha
Move struct tda998x_audio definition to tda998x_drv.c and remove include/sound/tda998x.h. There is no external use for struct tda998x_audio. Fix graph parsing to allow ports to be inside a separate "ports"-node as specified in Documentation/devicetree/bindings/graph.txt. Signed-of

[PATCH RFC v5 6/8] drm/i2c: tda998x: Improve tda998x_configure_audio() audio related pdata

2016-02-17 Thread Jyri Sarha
Declare struct tda998x_audio_params in include/drm/i2c/tda998x.h and use it in pdata and for tda998x_configure_audio() parameters. Also updates tda998x_write_aif() to take struct hdmi_audio_infoframe * directly as a parameter. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH RFC v5 7/8] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2016-02-17 Thread Jyri Sarha
for available sample-rates. Implementation of audio_startup for hdmi_codec_ops would enable tda998x driver to abort ongoing playback if the HDMI cable is unplugged or re-plugged to a device without audio capability. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/i2c/Kconfig | 1 + drivers/gpu

[PATCH RFC v5 8/8] ARM: dts: am335x-boneblack: Add HDMI audio support

2016-02-17 Thread Jyri Sarha
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/am335x-boneblack.dts | 90 -- 1 file changed, 86 insertions(+), 4

[PATCH v3 00/22] drm/ticdc: Accumulated fixes over the past couple of years

2016-02-23 Thread Jyri Sarha
drm/tilcdc: adopt pinctrl support Grygorii Strashko (1): drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha (8): drm/tilcdc: Implement dma-buf support for tilcdc drm/tilcdc: Allocate register storage based on the actual number registers drm/tilcdc: Fix interrupt enable/di

[PATCH v3 01/22] drm/tilcdc: rewrite pixel clock calculation

2016-02-23 Thread Jyri Sarha
clock rate of pixelclock*2, as the LCD controller has an internal divider which we set to 2. Signed-off-by: Darren Etheridge [Rewrapped description] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 +-- d

[PATCH v3 02/22] drm/tilcdc: verify fb pitch

2016-02-23 Thread Jyri Sarha
using libdrm's modetest tool with non-32 bpp modes. As modetest always allocated 4 bytes per pixel, it implies a bigger pitch for 16 or 24 bpp modes. This patch adds a check to reject pitches the hardware cannot support. Signed-off-by: Tomi Valkeinen Signed-off-by: Darren Etheridge Signed-off-by: Jyri

[PATCH v3 03/22] drm/tilcdc: adopt pinctrl support

2016-02-23 Thread Jyri Sarha
s and thus save power, - prevent the IP from driving pins output in an uncontrolled manner, which may happen if the power domain drops the domain regulator. Signed-off-by: Dave Gerlach Signed-off-by: Darren Etheridge Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 ++

[PATCH v3 07/22] drm/tilcdc: Implement dma-buf support for tilcdc

2016-02-23 Thread Jyri Sarha
There is nothing special about tilcdc HW when the video memory is concerned. Just using the standard drm helpers for implementation is enough. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v3 04/22] drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected

2016-02-23 Thread Jyri Sarha
s enabled, and then only restores the registers on resume if they were saved off during suspend. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Acked-by: Felipe Balbi Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 23 +-- drivers/gpu/drm/tilcdc/tilcdc_d

[PATCH v3 05/22] drm/tilcdc: make frame_done interrupt active at all times

2016-02-23 Thread Jyri Sarha
vsync interrupts are not always enabled during these operations. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_dr

[PATCH v3 13/22] drm/tilcdc: remove broken error handling

2016-02-23 Thread Jyri Sarha
fired at once before handling the error looks weird. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crt

[PATCH v3 08/22] drm/tilcdc: fix build error when !CONFIG_CPU_FREQ

2016-02-23 Thread Jyri Sarha
ut_clk: ^ Signed-off-by: Grygorii Strashko Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index c204359..977c843 100644 --- a/drivers/gpu/drm/

[PATCH v3 09/22] drm/tilcdc: Allocate register storage based on the actual number registers

2016-02-23 Thread Jyri Sarha
Allocate suspend/resume register storage based on the actual number registers the driver is aware of. The static allocation for register storage had fallen behind badly. Reported-by: Michael Bode Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 21

[PATCH v3 10/22] drm/tilcdc: cleanup runtime PM handling

2016-02-23 Thread Jyri Sarha
patch the DPMS code does not have pm_runtime_forbid/allow calls any more and pm_runtime_irq_safe() is not set anymore. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 19 +++ drivers/gpu/drm/

[PATCH v3 11/22] drm/tilcdc: disable crtc on unload

2016-02-23 Thread Jyri Sarha
From: Tomi Valkeinen <tomi.valkei...@ti.com> Disable crtc on unload. Call tilcdc_crtc_dpms() with DRM_MODE_DPMS_OFF in the beginning of unload function. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2

[PATCH v3 15/22] drm/tilcdc: Get rid of complex ping-pong mechanism

2016-02-23 Thread Jyri Sarha
er dma address on the fly. There are two registers defining the framebuffer dma area and things may break if the dma address is fetched in while the registers are are being updated. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/

[PATCH v3 12/22] drm/tilcdc: split reset to a separate function

2016-02-23 Thread Jyri Sarha
ed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 08b1e03..e62a950 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_

[PATCH v3 16/22] drm/tilcdc: Do not update the next frame buffer close to vertical blank

2016-02-23 Thread Jyri Sarha
iption to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 61 +++- 1 file changed, 53 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 32572285..b1df046

[PATCH v3 18/22] drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[]

2016-02-23 Thread Jyri Sarha
Removes the duplicate LCDC_INT_ENABLE_SET_REG-entry in registers array. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index

[PATCH v3 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data

2016-02-23 Thread Jyri Sarha
Use devm_kzalloc() and devm_kcalloc() for private data allocation at driver load time. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c| 19 +++ drivers/gpu/drm/tilcdc/tilcdc_panel.c | 20

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
e initialized for drm_of_find_possible_crtcs() to work. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 248e3ea..1eb4e0e 100644 --- a/drivers/g

[PATCH v3 06/22] drm/tilcdc: disable the lcd controller/dma engine when suspend invoked

2016-02-23 Thread Jyri Sarha
ending DMA transactions to complete as part of the suspend handler for this driver. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 +-- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ drivers/gpu/drm/tilcdc/tilcdc_drv.

[PATCH v3 14/22] drm/tilcdc: cleanup irq handling

2016-02-23 Thread Jyri Sarha
From: Tomi Valkeinen <tomi.valkei...@ti.com> Cleanup irq handling. Clear the irq status unconditionally and restructure the status bit conditions. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +-

[PATCH v3 17/22] drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc

2016-02-23 Thread Jyri Sarha
and writing 0 does not have any effect. The "bug" that is fixed here does not really do any harm since the interrupts are enabled only once in the power up and disabled before power down. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 ++- 1 file changed, 6

[PATCH v3 19/22] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts

2016-02-23 Thread Jyri Sarha
Add ratelimited prints on sync lost and FIFO underrun interrupts. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c

[PATCH v3 20/22] drm/tilcdc: Disable sync lost interrupt if it fires on every frame

2016-02-23 Thread Jyri Sarha
Disable the sync lost interrupt if it fires on every frame for 50 consecutive frames in a row. This is relatively sure sign of the sync lost interrupt being stuck and firing on every frame even if the display otherwise appears to work OK. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
On 02/23/16 17:19, Tomi Valkeinen wrote: > > > On 23/02/16 17:03, Jyri Sarha wrote: >> Initialize port device node pointer in the tilcdc crtc. Fixes "Falling >> back to first CRTC" warning from tda998x driver. >> >> The tda998x encoder driver calls dr

[PATCH v3 21/22] drm/tilcdc: Initialize crtc->port

2016-02-23 Thread Jyri Sarha
On 02/23/16 17:32, Tomi Valkeinen wrote: > On 23/02/16 17:26, Jyri Sarha wrote: > >>> You didn't comment on why this is not an error? Why should the driver >>> continue even if crtc->port is missing? >>> >> >> At least for the time being if the d

[PATCH v3 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data

2016-02-24 Thread Jyri Sarha
On 02/24/16 14:38, Tomi Valkeinen wrote: > > On 23/02/16 17:03, Jyri Sarha wrote: >> Use devm_kzalloc() and devm_kcalloc() for private data allocation at >> driver load time. >> >> Signed-off-by: Jyri Sarha >> --- >> drivers/gpu/drm/tilcdc/tilcdc_crtc

[PATCH v4 00/22] drm/ticdc: Accumulated fixes over the past couple of years

2016-02-24 Thread Jyri Sarha
te pixel clock calculation drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected drm/tilcdc: make frame_done interrupt active at all times drm/tilcdc: disable the lcd controller/dma engine when suspend invoked Dave Gerlach (1): drm/tilcdc: adopt pinctrl support Grygorii Strash

[PATCH v4 01/22] drm/tilcdc: rewrite pixel clock calculation

2016-02-24 Thread Jyri Sarha
clock rate of pixelclock*2, as the LCD controller has an internal divider which we set to 2. Signed-off-by: Darren Etheridge [Rewrapped description] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 +-- d

[PATCH v4 02/22] drm/tilcdc: verify fb pitch

2016-02-24 Thread Jyri Sarha
using libdrm's modetest tool with non-32 bpp modes. As modetest always allocated 4 bytes per pixel, it implies a bigger pitch for 16 or 24 bpp modes. This patch adds a check to reject pitches the hardware cannot support. Signed-off-by: Tomi Valkeinen Signed-off-by: Darren Etheridge Signed-off-by: Jyri

[PATCH v4 03/22] drm/tilcdc: adopt pinctrl support

2016-02-24 Thread Jyri Sarha
s and thus save power, - prevent the IP from driving pins output in an uncontrolled manner, which may happen if the power domain drops the domain regulator. Signed-off-by: Dave Gerlach Signed-off-by: Darren Etheridge Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 ++

[PATCH v4 04/22] drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected

2016-02-24 Thread Jyri Sarha
s enabled, and then only restores the registers on resume if they were saved off during suspend. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Acked-by: Felipe Balbi Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 23 +-- drivers/gpu/drm/tilcdc/tilcdc_d

[PATCH v4 05/22] drm/tilcdc: make frame_done interrupt active at all times

2016-02-24 Thread Jyri Sarha
vsync interrupts are not always enabled during these operations. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_dr

[PATCH v4 06/22] drm/tilcdc: disable the lcd controller/dma engine when suspend invoked

2016-02-24 Thread Jyri Sarha
ending DMA transactions to complete as part of the suspend handler for this driver. Signed-off-by: Darren Etheridge Tested-by: Dave Gerlach Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 +-- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ drivers/gpu/drm/tilcdc/tilcdc_drv.

[PATCH v4 07/22] drm/tilcdc: Implement dma-buf support for tilcdc

2016-02-24 Thread Jyri Sarha
There is nothing special about tilcdc HW when the video memory is concerned. Just using the standard drm helpers for implementation is enough. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v4 09/22] drm/tilcdc: Allocate register storage based on the actual number registers

2016-02-24 Thread Jyri Sarha
Allocate suspend/resume register storage based on the actual number registers the driver is aware of. The static allocation for register storage had fallen behind badly. Reported-by: Michael Bode Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 21

[PATCH v4 08/22] drm/tilcdc: fix build error when !CONFIG_CPU_FREQ

2016-02-24 Thread Jyri Sarha
ut_clk: ^ Signed-off-by: Grygorii Strashko Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index c204359..977c843 100644 --- a/drivers/gpu/drm/

[PATCH v4 10/22] drm/tilcdc: cleanup runtime PM handling

2016-02-24 Thread Jyri Sarha
patch the DPMS code does not have pm_runtime_forbid/allow calls any more and pm_runtime_irq_safe() is not set anymore. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 19 +++ drivers/gpu/drm/

[PATCH v4 11/22] drm/tilcdc: disable crtc on unload

2016-02-24 Thread Jyri Sarha
From: Tomi Valkeinen <tomi.valkei...@ti.com> Disable crtc on unload. Call tilcdc_crtc_dpms() with DRM_MODE_DPMS_OFF in the beginning of unload function. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2

[PATCH v4 12/22] drm/tilcdc: split reset to a separate function

2016-02-24 Thread Jyri Sarha
ed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 08b1e03..e62a950 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_

[PATCH v4 13/22] drm/tilcdc: remove broken error handling

2016-02-24 Thread Jyri Sarha
fired at once before handling the error looks weird. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crt

[PATCH v4 14/22] drm/tilcdc: cleanup irq handling

2016-02-24 Thread Jyri Sarha
From: Tomi Valkeinen <tomi.valkei...@ti.com> Cleanup irq handling. Clear the irq status unconditionally and restructure the status bit conditions. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +-

[PATCH v4 15/22] drm/tilcdc: Get rid of complex ping-pong mechanism

2016-02-24 Thread Jyri Sarha
er dma address on the fly. There are two registers defining the framebuffer dma area and things may break if the dma address is fetched in while the registers are are being updated. Signed-off-by: Tomi Valkeinen [Added description to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/

[PATCH v4 16/22] drm/tilcdc: Do not update the next frame buffer close to vertical blank

2016-02-24 Thread Jyri Sarha
iption to the patch] Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 61 +++- 1 file changed, 53 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 32572285..b1df046

[PATCH v4 17/22] drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc

2016-02-24 Thread Jyri Sarha
and writing 0 does not have any effect. The "bug" that is fixed here does not really do any harm since the interrupts are enabled only once in the power up and disabled before power down. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 ++- 1 file changed, 6

[PATCH v4 18/22] drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[]

2016-02-24 Thread Jyri Sarha
Removes the duplicate LCDC_INT_ENABLE_SET_REG-entry in registers array. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index

[PATCH v4 19/22] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts

2016-02-24 Thread Jyri Sarha
Add ratelimited prints on sync lost and FIFO underrun interrupts. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c

[PATCH v4 20/22] drm/tilcdc: Disable sync lost interrupt if it fires on every frame

2016-02-24 Thread Jyri Sarha
Disable the sync lost interrupt if it fires on every frame for 50 consecutive frames in a row. This is relatively sure sign of the sync lost interrupt being stuck and firing on every frame even if the display otherwise appears to work OK. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc

[PATCH v4 21/22] drm/tilcdc: Initialize crtc->port

2016-02-24 Thread Jyri Sarha
e initialized for drm_of_find_possible_crtcs() to work. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 248e3ea..5f4da8c 100644 --- a/drivers/g

[PATCH v4 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data

2016-02-24 Thread Jyri Sarha
Use devm_kzalloc() and devm_kcalloc() for private data allocation at driver load time. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c| 19 +++ drivers/gpu/drm/tilcdc/tilcdc_panel.c | 20

[PATCH] drm/i2c: tda998x: Choose between atomic or non atomic dpms helper

2016-02-25 Thread Jyri Sarha
s a > driver specific connector dpms helper that calls > drm_atomic_helper_connector_dpms() if driver supports DRIVER_ATOMIC > and otherwise it calls the legacy drm_helper_connector_dpms(). > > Fixes commit 9736e988d328 ("drm/i2c: tda998x: Add support for atomic > modesetti

[PATCH RFC v5 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2016-02-25 Thread Jyri Sarha
On 02/18/16 16:35, Rob Herring wrote: > On Wed, Feb 17, 2016 at 04:49:05PM +0200, Jyri Sarha wrote: >> From: Jean-Francois Moine >> >> Two kinds of ports may be declared in a DT graph of ports: video and audio. >> This patch accepts the port value from a v

[GIT PULL] drm/tilcdc: Accumulated fixes over the past couple of years

2016-02-25 Thread Jyri Sarha
engine when suspend invoked Dave Gerlach (1): drm/tilcdc: adopt pinctrl support Grygorii Strashko (1): drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha (8): drm/tilcdc: Implement dma-buf support for tilcdc drm/tilcdc: Allocate register storage based on the actual number

[PATCH RFC v5 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2016-02-26 Thread Jyri Sarha
On 02/26/16 02:43, Russell King - ARM Linux wrote: > On Thu, Feb 25, 2016 at 03:42:50PM +0200, Jyri Sarha wrote: >> On 02/18/16 16:35, Rob Herring wrote: >>> This should be implied from the port unit address. In other words, >>> port at 0 is defined to be the rg

[PATCH RFC v5 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2016-02-29 Thread Jyri Sarha
On 02/26/16 13:21, Russell King - ARM Linux wrote: > On Fri, Feb 26, 2016 at 12:14:44PM +0200, Jyri Sarha wrote: >> On 02/26/16 02:43, Russell King - ARM Linux wrote: >>> On Thu, Feb 25, 2016 at 03:42:50PM +0200, Jyri Sarha wrote: >>>> On 02/18/16 16:35, Rob He

[PATCH RFC] drm/i2c: tda998x: Only set atomic funcs if bound to atomic drm driver

2016-01-15 Thread Jyri Sarha
a crash with a driver that does not have atomic state initialized. Fixes commit 9736e988d328 ("drm/i2c: tda998x: Add support for atomic modesetting"). Signed-off-by: Jyri Sarha --- I am not sure if this is the best way to fix the issue, but after 9736e988d328 Beaglebone-Black HDMI is tota

[PATCH v9 0/7] Implement generic ASoC HDMI codec and use it in tda998x

2016-03-31 Thread Jyri Sarha
members to be more descriptive - Require audio configuration trough ASoC hdmi-codec if HDMI audio is configured trough DT binding. DTS: - Increase McASP fifo usage form 1 to 32 Jyri Sarha (7): ALSA: pcm: add IEC958 channel status helper for hw_params ALSA: pcm: Allow 32 bit samp

[PATCH v9 1/7] ALSA: pcm: add IEC958 channel status helper for hw_params

2016-03-31 Thread Jyri Sarha
Add IEC958 channel status helper that gets the audio properties from snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to produce the channel status bits already in audio stream configuration phase. Signed-off-by: Jyri Sarha --- include/sound/pcm_iec958.h | 2 ++ sound/core

[PATCH v9 4/7] ASoC: hdmi-codec: Add audio abort() callback for video side to use

2016-03-31 Thread Jyri Sarha
Add audio abort() callback, that is provided at audio stream start, for video side. This is for video side to use in case there is a pressing need to tear down the audio playback for some reason. Signed-off-by: Jyri Sarha --- include/sound/hdmi-codec.h| 8 ++-- sound/soc/codecs/hdmi

[PATCH v9 5/7] drm/i2c: tda998x: Improve tda998x_configure_audio() audio related pdata

2016-03-31 Thread Jyri Sarha
Define struct tda998x_audio_params in include/drm/i2c/tda998x.h and use it in pdata and for tda998x_configure_audio() parameters. Also updates tda998x_write_aif() to take struct hdmi_audio_infoframe * directly as a parameter. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/i2c/tda998x_drv.c | 77

[PATCH v9 2/7] ALSA: pcm: Allow 32 bit sample format in IEC958 channel status helper

2016-03-31 Thread Jyri Sarha
Treat 32 bit sample width as if it was 24 bits when generating IEC958 channel status bits. On some platforms 24 sample width is problematic and to get full 24 bit precision a 32 bit format, using only the 24 most significant bits, may have to be used. Signed-off-by: Jyri Sarha --- sound/core

[PATCH v9 6/7] drm/i2c: tda998x: Register ASoC hdmi-codec and add audio DT binding

2016-03-31 Thread Jyri Sarha
There may still be some identical lines left from the original patch and some of the ideas have come from there. [1] Documentation/devicetree/bindings/display/bridge/tda998x.txt [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/095255.html Signed-off-by: Jyri Sarha --- .../

[PATCH v9 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2016-03-31 Thread Jyri Sarha
of similar structures in ASoC headers. This is on purpose to avoid direct dependencies to ASoC structures in video side driver. Signed-off-by: Jyri Sarha --- include/sound/hdmi-codec.h| 100 +++ sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc

[PATCH v9 7/7] ARM: dts: am335x-boneblack: Add HDMI audio support

2016-03-31 Thread Jyri Sarha
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/am335x-boneblack.dts | 71 -- 1 file changed, 67 insertions(+), 4

[PATCH 11/14] drm/tilcdc: use drm_crtc_send_vblank_event()

2016-05-02 Thread Jyri Sarha
On 05/02/16 18:05, Daniel Vetter wrote: > On Tue, Apr 19, 2016 at 11:03:26AM -0300, Gustavo Padovan wrote: >> Hi Jyri, >> >> 2016-04-19 Jyri Sarha : >> >>> On 04/14/16 20:48, Gustavo Padovan wrote: >>>> From: Gustavo Padovan >>>> >>

[PATCH RFC 00/11] drm/tilcdc: Atomic modeset support

2016-05-10 Thread Jyri Sarha
On 05/09/16 17:10, Tomi Valkeinen wrote: > Hi Jyri, > > On 11/04/16 19:46, Jyri Sarha wrote: >> The LCDC in its simplicity does not fit too well into DRM atomic >> modeset abstractions. I wonder if I am doing the right thing in >> implementing the dummy primar

[PATCH RFC 00/11] drm/tilcdc: Atomic modeset support

2016-05-10 Thread Jyri Sarha
On 05/09/16 17:42, Daniel Vetter wrote: >> > It's not clear to me if a (primary) plane is required with atomic >> > universal planes and modesetting or not... I guess it is, when thinking >> > of how e.g. a framebuffer is configured to be shown on a screen when >> > using the atomic modesetting

[PATCH RFC 00/11] drm/tilcdc: Atomic modeset support

2016-05-10 Thread Jyri Sarha
On 05/10/16 09:34, Daniel Vetter wrote: >>> There's a drm_simple_display_pipe floating around which seems perfectly >>> > > suited to tilcdc. It's meant for the case where you have 1 plane, 1 crtc >>> > > and 1 encoder maybe linking to different connectors. And it takes care >>> > > of >>> > >

[PATCH 0/4] drm/omapdrm: gamma table support

2016-05-20 Thread Jyri Sarha
be applied or dropped independently. I just needed that in order to reproduce errata i734 conditions. Jyri Sarha (4): drm/omapdrm: omap_modeset_init: Separate crtc id and plane id indexing drm/omapdrm: Add gamma table support to DSS dispc drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in

[PATCH 1/4] drm/omapdrm: omap_modeset_init: Separate crtc id and plane id indexing

2016-05-20 Thread Jyri Sarha
Separate crtc id and plane id indexing in omap_modeset_init(). The coupling of crtc- and plane-id is hard to follow. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_drv.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/gpu

[PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc

2016-05-20 Thread Jyri Sarha
for the channel and returns 0 if gamma table is not supported by HW or DSS driver. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/dss/dispc.c| 189 ++--- drivers/gpu/drm/omapdrm/dss/dispc.h| 5 + drivers/gpu/drm/omapdrm/dss/dss_features.c | 2

[PATCH 4/4] drm/omapdrm: Implement gamma_lut atomic crtc property

2016-05-20 Thread Jyri Sarha
that is used for all CRTCs. The dss dispc API converts table of any length for HW and uses linear interpolation in the process. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_crtc.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/omapdrm

[PATCH 3/4] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc

2016-05-20 Thread Jyri Sarha
2.0 Silicon Errata Literature Number: SWPZ037E Or some other relevant errata document for the DSS IP version. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/dss/dispc.c| 166 + drivers/gpu/drm/omapdrm/dss/dss_features.c | 2 + drivers/gpu/drm/omapdrm

[PATCH 4/4] drm/omapdrm: Implement gamma_lut atomic crtc property

2016-05-20 Thread Jyri Sarha
On 05/20/16 10:05, Daniel Vetter wrote: > On Fri, May 20, 2016 at 09:35:56AM +0300, Jyri Sarha wrote: >> > Implement gamma_lut atomic crtc property, set crtc gamma size to 256 >> > for all crtcs and use drm_atomic_helper_legacy_gamma_set() as >> > gamma_set func. Th

[PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc

2016-05-20 Thread Jyri Sarha
On 05/20/16 15:51, Tomi Valkeinen wrote: >> +u32 dispc_mgr_gamma_size(enum omap_channel channel) >> > +{ >> > + const struct dispc_gamma_desc *gdesc = _desc[channel].gamma; >> > + >> > + if (!dss_has_feature(FEAT_GAMMA_TABLE)) >> > + return 0; >> > + > This should probably check the

[PATCH 3/4] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc

2016-05-23 Thread Jyri Sarha
On 05/20/16 16:21, Tomi Valkeinen wrote: >> > + >> > +static int dispc_errata_i734_wa_init(void) >> > +{ >> > + size_t buff_size = i734.ovli.width * i734.ovli.height * > "buf_size" would match the other names =). > > Usually I try to do only simple initializations when declaring the > locals.

[PATCH v2 0/3] drm/omapdrm: gamma table support

2016-05-23 Thread Jyri Sarha
support to DSS dispc" - Address Tomi's comments here: https://patchwork.kernel.org/patch/9128629/ - "drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc" - Address Tomi's comments here: https://patchwork.kernel.org/patch/9128633/ Jyri Sarha (3): drm/omapdrm:

[PATCH v2 1/3] drm/omapdrm: Add gamma table support to DSS dispc

2016-05-23 Thread Jyri Sarha
. dispc_mgr_gamma_size() gives HW gamma table size for the channel and returns 0 if gamma table is not supported by the HW or the DSS driver. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/dss/dispc.c | 192 +++--- drivers/gpu/drm/omapdrm/dss/dispc.h | 5 + drivers/gpu

[PATCH v2 2/3] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc

2016-05-23 Thread Jyri Sarha
2.0 Silicon Errata Literature Number: SWPZ037E Or some other relevant errata document for the DSS IP version. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/dss/dispc.c | 176 +++- 1 file changed, 174 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH v2 3/3] drm/omapdrm: Implement gamma_lut atomic crtc property

2016-05-23 Thread Jyri Sarha
that is used for all CRTCs. The dss dispc API converts table of any length for HW and uses linear interpolation in the process. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_crtc.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/omapdrm

[PATCH v2 2/3] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc

2016-05-23 Thread Jyri Sarha
On 05/23/16 17:41, Jyri Sarha wrote: > @@ -4112,7 +4115,8 @@ static const struct dispc_features omap54xx_dispc_feats > = { > .has_writeback = true, > .supports_double_pixel = true, > .reverse_ilace_field_order =true, > -

[PATCH v2 2/3] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc

2016-05-24 Thread Jyri Sarha
On 05/23/16 18:06, Tomi Valkeinen wrote: >> For gamma tables to work on LCD1 the GFX plane has to be used at least >> > once after DSS HW has come out of reset. The work-a-round sets up a >> > minimal LCD setup with GFX plane and waits for one vertical sync irq >> > before disabling the setup and

[PATCH v3 0/3] drm/omapdrm: gamma table support

2016-05-24 Thread Jyri Sarha
dispc" - Address Tomi's comments here: https://patchwork.kernel.org/patch/9128629/ - "drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in DSS dispc" - Address Tomi's comments here: https://patchwork.kernel.org/patch/9128633/ Jyri Sarha (3): drm/omapdrm: Add gamma table support t

[PATCH v3 3/3] drm/omapdrm: Implement gamma_lut atomic crtc property

2016-05-24 Thread Jyri Sarha
that is used for all CRTCs. The dss dispc API converts table of any length for HW and uses linear interpolation in the process. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_crtc.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/omapdrm

<    1   2   3   4   5   6   7   8   9   10   >