Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Keith Packard
On Wed, 28 Sep 2011 15:22:48 -0300, Paulo Zanoni przan...@gmail.com wrote: I also tested the patch you sent today 1 hour ago (inline in one of the emails) and things still work with it. I'll keep using these patches since they fix my laptop. Any problem will be reported. Thanks. I think we're

[PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-09-28 Thread Keith Packard
The reference clock configuration must be done before any mode setting can occur as all outputs must be disabled to change anything. Initialize the clocks after turning everything off during the initialization process. Also, re-initialize the refclk at resume time. Signed-off-by: Keith Packard

[PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-09-27 Thread Keith Packard
On Tue, 27 Sep 2011 17:56:39 +0100, Chris Wilson wrote: > Ah, now I see why we moved from using the active configuration earlier. ;-) My evil plan is revealed! > Doesn't this prevent us from ever using SSC though, as virtually every > single PCH machine has HDMI encoders that haven't been

[PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-27 Thread Keith Packard
On Tue, 27 Sep 2011 17:47:10 +0100, Chris Wilson wrote: > On Mon, 26 Sep 2011 23:11:43 -0700, Keith Packard > wrote: > > The PCH refclk settings are global, so we need to look at all of the > > encoders, not just the current encoder when deciding how to configure > >

PCH reference clock cleanups

2011-09-27 Thread Keith Packard
On Tue, 27 Sep 2011 10:01:33 +0100, Chris Wilson wrote: > Oddly in the diagram SSC4 is given as a 100MHz clock that can be used for > any output other than DP_A. However, the configuration register marks that > as being a test-only mode. Ok, it's all irrelevant -- the only configurations using

[PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-09-27 Thread Keith Packard
The reference clock configuration must be done before any mode setting can occur as all outputs must be disabled to change anything. Initialize the clocks after turning everything off during the initialization process. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 10

[PATCH 8/9] drm/i915: All PCH refclks are 120MHz

2011-09-27 Thread Keith Packard
I can't find any reference clocks which run at 96MHz as seems to be indicated from the comments in this code. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 7/9] drm/i915: Use CK505 as non-SSC source where available

2011-09-27 Thread Keith Packard
This eliminates VGA shimmer on some Ironlake machines which have a CK505 clock source. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu

[PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-27 Thread Keith Packard
-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 96 +- 1 files changed, 59 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 6039496..f35 100644 --- a/drivers/gpu/drm

[PATCH 5/9] drm/i915: Allow SSC parameter to override VBT value

2011-09-27 Thread Keith Packard
Allow SSC to be enabled even when the BIOS disables it for testing SSC paths. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915/intel_display.c |4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 4/9] drm/i915: Document a few more BDB_GENERAL_FEATURES bits from PCH BIOS

2011-09-27 Thread Keith Packard
This includes whether an eDP panel is present, and whether that should use SSC (and at what frequency) Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_bios.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu

[PATCH 3/9] drv/i915: Pull display_clock_mode out of VBT table

2011-09-27 Thread Keith Packard
This tells the driver whether a CK505 clock source is available on pre-PCH hardware. If so, it should be used as the non-SSC source, leaving the internal clock for use as the SSC source. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915

[PATCH 2/9] drm/i915: Use DRM_DEBUG_KMS for all messages in intel_bios.c

2011-09-27 Thread Keith Packard
These are all KMS related anyways, so don't hide them under other debug levels. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_bios.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915

[PATCH 1/9] drm/i915: broken copyright encoding in intel_bios.c

2011-09-27 Thread Keith Packard
Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_bios.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 61abef8..4c530fa 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++ b/drivers

PCH reference clock cleanups

2011-09-27 Thread Keith Packard
Here's a patch sequence which cleans up a bunch of PCH refclk related bits. There are a couple of questionable patches that I'd like to see people look at: [PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings [PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time Here's the

PCH reference clock cleanups

2011-09-27 Thread Keith Packard
Here's a patch sequence which cleans up a bunch of PCH refclk related bits. There are a couple of questionable patches that I'd like to see people look at: [PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings [PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time Here's the

[PATCH 1/9] drm/i915: broken copyright encoding in intel_bios.c

2011-09-27 Thread Keith Packard
Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_bios.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 61abef8..4c530fa 100644 --- a/drivers/gpu/drm/i915

[PATCH 3/9] drv/i915: Pull display_clock_mode out of VBT table

2011-09-27 Thread Keith Packard
This tells the driver whether a CK505 clock source is available on pre-PCH hardware. If so, it should be used as the non-SSC source, leaving the internal clock for use as the SSC source. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu

[PATCH 5/9] drm/i915: Allow SSC parameter to override VBT value

2011-09-27 Thread Keith Packard
Allow SSC to be enabled even when the BIOS disables it for testing SSC paths. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915/intel_display.c |4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 4/9] drm/i915: Document a few more BDB_GENERAL_FEATURES bits from PCH BIOS

2011-09-27 Thread Keith Packard
This includes whether an eDP panel is present, and whether that should use SSC (and at what frequency) Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_bios.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 2/9] drm/i915: Use DRM_DEBUG_KMS for all messages in intel_bios.c

2011-09-27 Thread Keith Packard
These are all KMS related anyways, so don't hide them under other debug levels. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_bios.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu

[PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-09-27 Thread Keith Packard
The reference clock configuration must be done before any mode setting can occur as all outputs must be disabled to change anything. Initialize the clocks after turning everything off during the initialization process. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915

[PATCH 8/9] drm/i915: All PCH refclks are 120MHz

2011-09-27 Thread Keith Packard
I can't find any reference clocks which run at 96MHz as seems to be indicated from the comments in this code. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_display.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu

[PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-27 Thread Keith Packard
-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_display.c | 96 +- 1 files changed, 59 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 6039496..f35 100644

[PATCH 7/9] drm/i915: Use CK505 as non-SSC source where available

2011-09-27 Thread Keith Packard
This eliminates VGA shimmer on some Ironlake machines which have a CK505 clock source. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_display.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

Re: PCH reference clock cleanups

2011-09-27 Thread Keith Packard
On Tue, 27 Sep 2011 10:01:33 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Oddly in the diagram SSC4 is given as a 100MHz clock that can be used for any output other than DP_A. However, the configuration register marks that as being a test-only mode. Ok, it's all irrelevant -- the only

Re: [PATCH 6/9] drm/i915: Fix PCH SSC reference clock settings

2011-09-27 Thread Keith Packard
On Tue, 27 Sep 2011 17:47:10 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 26 Sep 2011 23:11:43 -0700, Keith Packard kei...@keithp.com wrote: The PCH refclk settings are global, so we need to look at all of the encoders, not just the current encoder when deciding how

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Keith Packard
On Fri, 23 Sep 2011 08:25:13 +0530, Jesse Barnes wrote: > Yeah that sounds good. (2) and (3) are ok cleanups, but it would be > best if they were a separate patch just in case the subtle timing > change breaks the panel power sequencing state machine. Ok, I'll split things up into tiny

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Keith Packard
On Fri, 23 Sep 2011 08:25:13 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: Yeah that sounds good. (2) and (3) are ok cleanups, but it would be best if they were a separate patch just in case the subtle timing change breaks the panel power sequencing state machine. Ok, I'll split

Whitespace cleanups in drm/i915

2011-09-21 Thread Keith Packard
On Wed, 21 Sep 2011 16:56:12 -0400, Akshay Joshi wrote: > Have we reached a consensus on this? Just curious. Your patch was merged to Dave Airlie's drm-core-next branch. -- keith.packard at intel.com -- next part -- A non-text attachment was scrubbed... Name: not

Re: Whitespace cleanups in drm/i915

2011-09-21 Thread Keith Packard
On Wed, 21 Sep 2011 16:56:12 -0400, Akshay Joshi m...@akshayjoshi.com wrote: Have we reached a consensus on this? Just curious. Your patch was merged to Dave Airlie's drm-core-next branch. -- keith.pack...@intel.com pgpDbfVeNrjh4.pgp Description: PGP signature

[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:47:59 +0530, Jesse Barnes wrote: > I'm worried this makes our PPS even more complex and hard to follow. > I'd rather see VDD AUX applied only when we need it (dpms, mode set and > detect; for hotplug we can assume the panel is alive) and that we > carefully disable it

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes wrote: > This one mixes up lots of cleanups plus the EDID read with the power > changes. I think the cleanups are; 1) edp checks inside vdd_on and vdd_off to make the other code a bit easier to read. 2) Hold VDD on until the end of

[PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
On Tue, 20 Sep 2011 17:24:21 +0100, Chris Wilson wrote: > On Tue, 20 Sep 2011 08:47:21 -0700, Keith Packard > wrote: > > We were relying on the BIOS to set these bits, which doesn't always > > happen. > > Do we need to clear IRQ bits on uninstall, for example to

Proposal for a low-level Linux display framework

2011-09-20 Thread Keith Packard
On Tue, 20 Sep 2011 10:29:23 +0200, Patrik Jakobsson wrote: > It would be nice to have a model that fits both DSI and SDVO, and the option > to configure some of it from userspace. > I thought the purpose of drm_encoder was to abstract hardware like this? SDVO is entirely hidden by the

[PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
We were relying on the BIOS to set these bits, which doesn't always happen. Signed-off-by: Keith Packard --- v2: set the hotplug bits in the irq post-install hook, just like we do for pre-PCH hardware. drivers/gpu/drm/i915/i915_irq.c | 24 drivers/gpu/drm/i915

[PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
We were relying on the BIOS to set these bits, which doesn't always happen. Signed-off-by: Keith Packard kei...@keithp.com --- v2: set the hotplug bits in the irq post-install hook, just like we do for pre-PCH hardware. drivers/gpu/drm/i915/i915_irq.c | 24 drivers

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Keith Packard
On Tue, 20 Sep 2011 10:29:23 +0200, Patrik Jakobsson patrik.r.jakobs...@gmail.com wrote: It would be nice to have a model that fits both DSI and SDVO, and the option to configure some of it from userspace. I thought the purpose of drm_encoder was to abstract hardware like this? SDVO is

Re: [PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
On Tue, 20 Sep 2011 17:24:21 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 20 Sep 2011 08:47:21 -0700, Keith Packard kei...@keithp.com wrote: We were relying on the BIOS to set these bits, which doesn't always happen. Do we need to clear IRQ bits on uninstall, for example

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: This one mixes up lots of cleanups plus the EDID read with the power changes. I think the cleanups are; 1) edp checks inside vdd_on and vdd_off to make the other code a bit easier to read. 2) Hold VDD on

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:47:59 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: I'm worried this makes our PPS even more complex and hard to follow. I'd rather see VDD AUX applied only when we need it (dpms, mode set and detect; for hotplug we can assume the panel is alive) and that we

[PATCH] drm/i915: FBC off for ironlake, otherwise on by default

2011-09-19 Thread Keith Packard
Make the default FBC behaviour chipset specific, allowing us to turn it on by default for everything except Ironlake where it has been seen to cause trouble with screen updates. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915

drm/i915 git repository at freedesktop.org

2011-09-19 Thread Keith Packard
I've created a (temporary?) git repository for the drm/i915 driver at git://people.freedesktop.org/~keithp/linux This has the drm-intel-next and drm-intel-fixes branches, and may also have occasional temporary branches with code which has not been merged yet. -- keith.packard at intel.com

[PULL] drm-intel-next

2011-09-19 Thread Keith Packard
This is a single patch which cleans up almost all of the whitespace errors in the i915 driver. It currently merges cleanly with your fdo drm-core-next tree. I've checked this patch quite carefully, examining the .o files with objdump -s to make sure nothing significant changed. The only thing

[PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-19 Thread Keith Packard
is respected before trying to turn it back on. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 93 +- 1 files changed, 80 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 5bc30f9

[PATCH 8/9] drm/i915: Move eDP panel fixed mode from dev_priv to intel_dp

2011-09-19 Thread Keith Packard
This value doesn't come directly from the VBT, and so is rather specific to the particular DP output. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_dp.c | 35 --- 2 files changed, 16 insertions(+), 20

[PATCH 7/9] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-19 Thread Keith Packard
Store the panel power sequencing delays in the dp private structure, rather than the global device structure. Who knows, maybe we'll get more than one eDP device in the future. Look at both the current hardware register settings and the VBT specified panel power sequencing timings. Use the

[PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-19 Thread Keith Packard
turning power on and off to ensure that the panel is keeping up. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 84 +- 1 files changed, 64 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[PATCH 5/9] drm/i915: Unlock PCH_PP_CONTROL always

2011-09-19 Thread Keith Packard
Avoid any question about locked registers by just writing the unlock pattern with every write to the register. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_dp.c | 14 +- 2 files changed, 14 insertions(+), 1 deletions

[PATCH 4/9] drm/i915: Check eDP power when doing aux channel communications

2011-09-19 Thread Keith Packard
Verify that the eDP VDD is on, either with the panel being on or with the VDD force-on bit being set. This demonstrates that in many instances, VDD is not on when needed, which leads to failed EDID communications. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 22

[PATCH 3/9] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-19 Thread Keith Packard
We're going to assume that EDID is more reliable than the VBT tables for eDP panels, which is notably true on MacBook machines where the VBT contains completely bogus data. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files changed, 10

[PATCH 2/9] drm/i915: Remove extra 300ms delay during eDP mode setting

2011-09-19 Thread Keith Packard
There's no reason to enforce a 300ms delay during eDP mode setting. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 44fef5e

[PATCH 1/9] drm/i915: Enable digital port hotplug on PCH systems

2011-09-19 Thread Keith Packard
We were relying on the BIOS to set these bits, which doesn't always happen. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/i915_reg.h |5 - drivers/gpu/drm/i915/intel_display.c | 12 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/gpu

drm/i915: eDP cleanup patch series -- fixes SNB MacBook Air

2011-09-19 Thread Keith Packard
Here's a sequence of eDP patches which are necessary to make the driver work on the Sandybridge MacBook Air The key trick was to make sure that the eDP power was applied before trying to communicate with the device.

Proposal for a low-level Linux display framework

2011-09-19 Thread Keith Packard
On Mon, 19 Sep 2011 09:33:34 +0300, Tomi Valkeinen wrote: > I think it's a bit more complex than that. True, there are MIPI > standards, for the video there are DPI, DBI, DSI, and for the commands > there is DCS. And, as you mentioned, many panels need custom > initialization, or support only

Re: Proposal for a low-level Linux display framework

2011-09-19 Thread Keith Packard
On Mon, 19 Sep 2011 09:33:34 +0300, Tomi Valkeinen tomi.valkei...@ti.com wrote: I think it's a bit more complex than that. True, there are MIPI standards, for the video there are DPI, DBI, DSI, and for the commands there is DCS. And, as you mentioned, many panels need custom initialization,

drm/i915: eDP cleanup patch series -- fixes SNB MacBook Air

2011-09-19 Thread Keith Packard
Here's a sequence of eDP patches which are necessary to make the driver work on the Sandybridge MacBook Air The key trick was to make sure that the eDP power was applied before trying to communicate with the device. ___ dri-devel mailing list

[PATCH 1/9] drm/i915: Enable digital port hotplug on PCH systems

2011-09-19 Thread Keith Packard
We were relying on the BIOS to set these bits, which doesn't always happen. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_reg.h |5 - drivers/gpu/drm/i915/intel_display.c | 12 2 files changed, 16 insertions(+), 1 deletions(-) diff

[PATCH 2/9] drm/i915: Remove extra 300ms delay during eDP mode setting

2011-09-19 Thread Keith Packard
There's no reason to enforce a 300ms delay during eDP mode setting. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PATCH 3/9] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-09-19 Thread Keith Packard
We're going to assume that EDID is more reliable than the VBT tables for eDP panels, which is notably true on MacBook machines where the VBT contains completely bogus data. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 20 ++-- 1 files

[PATCH 4/9] drm/i915: Check eDP power when doing aux channel communications

2011-09-19 Thread Keith Packard
Verify that the eDP VDD is on, either with the panel being on or with the VDD force-on bit being set. This demonstrates that in many instances, VDD is not on when needed, which leads to failed EDID communications. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915

[PATCH 8/9] drm/i915: Move eDP panel fixed mode from dev_priv to intel_dp

2011-09-19 Thread Keith Packard
This value doesn't come directly from the VBT, and so is rather specific to the particular DP output. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_dp.c | 35 --- 2 files changed, 16

[PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-19 Thread Keith Packard
turning power on and off to ensure that the panel is keeping up. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 84 +- 1 files changed, 64 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers

[PATCH 7/9] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-19 Thread Keith Packard
an awfully long time. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_drv.h |1 - drivers/gpu/drm/i915/intel_dp.c | 56 -- 2 files changed, 41 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers

[PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-19 Thread Keith Packard
is respected before trying to turn it back on. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 93 +- 1 files changed, 80 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[PULL] drm-intel-next

2011-09-19 Thread Keith Packard
This is a single patch which cleans up almost all of the whitespace errors in the i915 driver. It currently merges cleanly with your fdo drm-core-next tree. I've checked this patch quite carefully, examining the .o files with objdump -s to make sure nothing significant changed. The only thing

drm/i915 git repository at freedesktop.org

2011-09-19 Thread Keith Packard
I've created a (temporary?) git repository for the drm/i915 driver at git://people.freedesktop.org/~keithp/linux This has the drm-intel-next and drm-intel-fixes branches, and may also have occasional temporary branches with code which has not been merged yet. -- keith.pack...@intel.com

[PATCH] drm/i915: FBC off for ironlake, otherwise on by default

2011-09-19 Thread Keith Packard
Make the default FBC behaviour chipset specific, allowing us to turn it on by default for everything except Ironlake where it has been seen to cause trouble with screen updates. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm

Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 18:39:21 +, Florian Tobias Schandinat wrote: > Well, I'm not against sharing the code and not against taking DRM's current > implementation as a base but the steps required to make it generally > acceptable > would be to split it of, probably as a standalone module and

Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 20:21:15 +0300, Tomi Valkeinen wrote: > 2) panel drivers, handles panel specific things. Each panel may support > custom commands and features, for which we need a dedicated driver. And > this driver is not platform specific, but should work with any platform > which has the

Whitespace cleanups in drm/i915

2011-09-15 Thread Keith Packard
I've got this nice patch from Akshay Joshi that removes almost all of the checkpatch.pl warnings from drm/i915. If I don't merge it now, it's going to go stale and be useless; if I merge it only to drm-intel-next, it will be the source of endless conflicts. However, it's a huge patch (yes, the

Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 17:12:43 +, Florian Tobias Schandinat wrote: > Interesting that this comes from the people that pushed the latest mode > setting > code into the kernel. But I don't think that this will happen, the exposed > user > interfaces will be around for decades and the

Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 18:29:54 +0300, Tomi Valkeinen wrote: > 1) It's part of DRM, so it doesn't help fb or v4l2 drivers. Except if > the plan is to make DRM the core Linux display framework, upon which > everything else is built, and fb and v4l2 are changed to use DRM. I'd like to think we

Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 15:07:05 +0300, Tomi Valkeinen wrote: > This was a very rough and quite short proposal, but I'm happy to improve > and extend it if it's not totally shot down. Jesse Barnes has put together a proposal much like this to work within the existing DRM environment. This is

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault wrote: > At home only. At work, with a different VGA screen, I'm still getting > the issue. You're still having a problem with the LVDS screen at work with FBC disabled? Can you send along a kernel log with drm.debug=5? -- keith.packard at

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 01:27:17 +0200, Samuel Thibault wrote: Non-text part: multipart/mixed > Hello, > > I'm trying to upgrade from 3.0 to 3.1-rcsomething on a DELL latitude > E6420, but dual head is broken. Here is the scenario: > > - Turn computer on with VGA1 connected. Both LVDS1 and VGA1

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: At home only. At work, with a different VGA screen, I'm still getting the issue. You're still having a problem with the LVDS screen at work with FBC disabled? Can you send along a kernel log with

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 15:07:05 +0300, Tomi Valkeinen tomi.valkei...@ti.com wrote: This was a very rough and quite short proposal, but I'm happy to improve and extend it if it's not totally shot down. Jesse Barnes has put together a proposal much like this to work within the existing DRM

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 18:29:54 +0300, Tomi Valkeinen tomi.valkei...@ti.com wrote: 1) It's part of DRM, so it doesn't help fb or v4l2 drivers. Except if the plan is to make DRM the core Linux display framework, upon which everything else is built, and fb and v4l2 are changed to use DRM. I'd

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 17:12:43 +, Florian Tobias Schandinat florianschandi...@gmx.de wrote: Interesting that this comes from the people that pushed the latest mode setting code into the kernel. But I don't think that this will happen, the exposed user interfaces will be around for

Whitespace cleanups in drm/i915

2011-09-15 Thread Keith Packard
I've got this nice patch from Akshay Joshi that removes almost all of the checkpatch.pl warnings from drm/i915. If I don't merge it now, it's going to go stale and be useless; if I merge it only to drm-intel-next, it will be the source of endless conflicts. However, it's a huge patch (yes, the

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 20:21:15 +0300, Tomi Valkeinen tomi.valkei...@ti.com wrote: 2) panel drivers, handles panel specific things. Each panel may support custom commands and features, for which we need a dedicated driver. And this driver is not platform specific, but should work with any

Re: Proposal for a low-level Linux display framework

2011-09-15 Thread Keith Packard
On Thu, 15 Sep 2011 18:39:21 +, Florian Tobias Schandinat florianschandi...@gmx.de wrote: Well, I'm not against sharing the code and not against taking DRM's current implementation as a base but the steps required to make it generally acceptable would be to split it of, probably as a

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-14 Thread Keith Packard
On Thu, 15 Sep 2011 01:27:17 +0200, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: Non-text part: multipart/mixed Hello, I'm trying to upgrade from 3.0 to 3.1-rcsomething on a DELL latitude E6420, but dual head is broken. Here is the scenario: - Turn computer on with VGA1 connected.

[PATCH] drm/i915: Enable dither whenever display bpc < frame buffer bpc

2011-09-05 Thread Keith Packard
be larger than the display bpc. Signed-off-by: Keith Packard Reported-by: Oliver Hartkopp Tested-by: Oliver Hartkopp --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[PULL] drm-intel-fixes (drm/i915 driver)

2011-08-26 Thread Keith Packard
This is all I've seen since rc3; a couple of tiny fixes, but one has seen several complaints on the list, so I figured I'd send them in now. The following changes since commit fcb8ce5cfe30ca9ca5c9a79cdfe26d1993e65e0c: Linux 3.1-rc3 (2011-08-22 11:42:53 -0700) are available in the git

[PULL] drm-intel-fixes (drm/i915 driver)

2011-08-26 Thread Keith Packard
This is all I've seen since rc3; a couple of tiny fixes, but one has seen several complaints on the list, so I figured I'd send them in now. The following changes since commit fcb8ce5cfe30ca9ca5c9a79cdfe26d1993e65e0c: Linux 3.1-rc3 (2011-08-22 11:42:53 -0700) are available in the git

i915: -next: have to switch terms after display goes to sleep

2011-08-22 Thread Keith Packard
On Mon, 22 Aug 2011 12:47:49 +0300, Dan Carpenter wrote: > In linux-next 3.1.0-rc2-next-20110819+ when the screen goes to sleep > then the screen doesn't refresh properly until I switch to a > non-graphical TTY and then come back. It does this every time. > The gnome tool bar at the top of my

Re: i915: -next: have to switch terms after display goes to sleep

2011-08-22 Thread Keith Packard
On Mon, 22 Aug 2011 12:47:49 +0300, Dan Carpenter erro...@gmail.com wrote: In linux-next 3.1.0-rc2-next-20110819+ when the screen goes to sleep then the screen doesn't refresh properly until I switch to a non-graphical TTY and then come back. It does this every time. The gnome tool bar at

[PULL] drm-intel-fixes (drm/i915 driver)

2011-08-15 Thread Keith Packard
PCH refclk update code Keith Packard (6): drm/i915: Wait for LVDS panel power sequence drm/i915: Leave LVDS registers unlocked drm/i915: Fix PCH port pipe select in CPT disable paths drm/i915: Remove unused 'reg' argument to dp_pipe_enabled drm/i915: Can't do accurate

Reverting rc6 by default

2011-08-12 Thread Keith Packard
On Thu, 14 Jul 2011 19:00:26 +0200, Francesco Allertsen wrote: > I have tried to boot with the latest git with the commit > 05bd42688dbc066d4e2689b6f73c0470601f788b reverted (so I have the 'Idling > fix' and the rc6 enabled), but I have the same freeze. Can you send me your kernel .config file?

[PULL] drm-intel-next

2011-08-10 Thread Keith Packard
On Wed, 10 Aug 2011 12:20:14 -0400, Andy Lutomirski wrote: > Can you ack at least this one: > > >Revert and fix "drm/i915/dp: remove DPMS mode tracking from DP" > (i.e. d2b996ac698aebb28557355857927b8b934bb4f9) > > for -stable? It fixes an annoying regression in 3.0. I'm working on a

Re: [PULL] drm-intel-next

2011-08-10 Thread Keith Packard
On Wed, 10 Aug 2011 12:20:14 -0400, Andy Lutomirski l...@mit.edu wrote: Can you ack at least this one: Revert and fix drm/i915/dp: remove DPMS mode tracking from DP (i.e. d2b996ac698aebb28557355857927b8b934bb4f9) for -stable? It fixes an annoying regression in 3.0. I'm working

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes wrote: > On Mon, 08 Aug 2011 12:53:31 -0700 > Keith Packard wrote: > > > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > virtuousgeek.org> wrote: > > > > > Yep, it's safe and possible to do on pre-PCH as

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes wrote: > Yep, it's safe and possible to do on pre-PCH as well. For panel > fitting we do need to do an actual power cycle when going from > non-native back to native iirc, but we can still leave them unlocked so > we don't have to worry about the

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes wrote: > Yep, looks fine. The only think we might want to sprinkle about are > checks for panel off so we can avoid visible corruption if we whack > timing or fb stuff while the panel is on. So, I'd like to know if we could unlock the panel

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes wrote: > ...to catch places like this where the wrong register gets used. :) Ouch! There are only two places we *should* have these loops, one when turning it off, another when turning it on. There's a couple of loops which just need to be

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes wrote: > Yep, looks fine. The only think we might want to sprinkle about are > checks for panel off so we can avoid visible corruption if we whack > timing or fb stuff while the panel is on. Yeah, could do. Would be nice to somehow get the LVDS

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, looks fine. The only think we might want to sprinkle about are checks for panel off so we can avoid visible corruption if we whack timing or fb stuff while the panel is on. Yeah, could do. Would be nice to

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Keith Packard
just need to be removed. Here's a replacement patch: From 436f2b19cf17c43e4d5ad55b47aeb3660c2af9b9 Mon Sep 17 00:00:00 2001 From: Keith Packard kei...@keithp.com Date: Sat, 6 Aug 2011 10:30:45 -0700 Subject: [PATCH] drm/i915: Wait for LVDS panel power sequence During mode setting, check to make

<    3   4   5   6   7   8   9   10   11   >