.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
of years ago.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
/Hold_And_Modify
[2] http://lwn.net/Articles/440192/
[3] http://www.fourcc.org/
[4] http://lxr.linux.no/linux+v2.6.38/include/linux/videodev2.h#L271
[5] http://en.wikipedia.org/wiki/Rec._601
[6] http://lxr.linux.no/linux+v2.6.38/include/linux/videodev2.h#L175
--
Regards,
Laurent Pinchart
Hi Florian,
On Saturday 21 May 2011 00:33:02 Florian Tobias Schandinat wrote:
On 05/17/2011 10:07 PM, Laurent Pinchart wrote:
Hi everybody,
I need to implement support for a YUV frame buffer in an fbdev driver. As
the fbdev API doesn't support this out of the box, I've spent a couple
accross
subsystems also doesn't sound like a very good idea to me. We could create a
header that contains V4L2-agnostic FOURCC #define's, and generate a V4L2
header with the V4L2_ prefix, but I'm not sure it would be a good idea either.
--
Regards,
Laurent Pinchart
Hi Geert,
On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote:
On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote:
+The following types and visuals are supported.
+
+- FB_TYPE_PACKED_PIXELS
+
+- FB_TYPE_PLANES
You forgot FB_TYPE_INTERLEAVED_PLANES, FB_TYPE_TEXT
Hi Florian,
On Wednesday 22 June 2011 07:45:45 Florian Tobias Schandinat wrote:
On 06/21/2011 10:31 PM, Laurent Pinchart wrote:
On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote:
On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote:
+The FOURCC-based API replaces format
wrote:
On 06/21/2011 10:31 PM, Laurent Pinchart wrote:
On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote:
As FOURCC values are always 4 ASCII characters (hence all 4 bytes
must be non-zero), I don't think there are any conflicts with
existing values of
nonstd. To make it even safer
field to detect FOURCC
mode. I believe FB_CAP_FOURCC (or something similar) is needed.
Paul, Geert, Florian, what are your opinions ?
On Monday 11 July 2011 17:32:51 Laurent Pinchart wrote:
On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote:
On 06/24/2011 06:55 PM, Geert Uytterhoeven
Hi Guennadi,
Thanks for the review.
On Thursday 28 July 2011 10:31:24 Guennadi Liakhovetski wrote:
On Mon, 11 Jul 2011, Laurent Pinchart wrote:
On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote:
On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote:
On Fri, Jun 24, 2011 at 08
Hi Florian,
Thanks for the feedback.
On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote:
On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote:
On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote:
As for struct fb_var_screeninfo fields to support switching to a FOURCC
mode, I
Hi Geert,
Thanks for the feedback.
On Sunday 31 July 2011 22:32:42 Geert Uytterhoeven wrote:
On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote:
As for struct fb_var_screeninfo fields to support switching to a FOURCC
mode, I also prefer an explicit dedicated flag to specify switching
Hi Florian,
On Monday 01 August 2011 01:58:27 Florian Tobias Schandinat wrote:
On 07/31/2011 11:28 PM, Laurent Pinchart wrote:
On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote:
On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote:
On Thu, Jul 28, 2011 at 12:51, Laurent
Hi Geert,
On Monday 01 August 2011 11:49:46 Geert Uytterhoeven wrote:
On Mon, Aug 1, 2011 at 00:54, Florian Tobias Schandinat wrote:
On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote:
On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote:
As for struct fb_var_screeninfo fields to support
world vision fb would be a legacy layer on top of DRM.
DRM would get the silly recovery fail cases fixed, and a kernel console
would be attachable to a GEM object of your choice.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel
://www.ideasonboard.org/media/omap3isp.ps
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Rob,
(CC'ing linux-media, as I believe this is very on-topic)
On Sunday 18 September 2011 18:14:26 Rob Clark wrote:
On Sat, Sep 17, 2011 at 6:12 PM, Laurent Pinchart wrote:
On Thursday 15 September 2011 20:39:21 Florian Tobias Schandinat wrote:
On 09/15/2011 05:52 PM, Alex Deucher wrote
different version numbers. At least we're not yet into two digits
numbers ;)
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
);
+
+ mutex_unlock(dmabuf-lock);
+ return attach;
+
+err_alloc:
+ return ERR_PTR(-ENOMEM);
+err_attach:
+ kfree(attach);
+ mutex_unlock(dmabuf-lock);
+ return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(dma_buf_attach);
--
Regards,
Laurent Pinchart
Hi Sumit,
On Wednesday 25 January 2012 14:56:52 Semwal, Sumit wrote:
On Fri, Jan 20, 2012 at 6:53 PM, Laurent Pinchart wrote:
Hi Summit,
Sorry for the late review. I know that this code is now in mainline, but
I still have a couple of comments. I'll send patches if you agree with
them
, -struct sg_table *sg)
+ struct sg_table *sg, enum dma_data_direction write)
s/write/dir/ (or direction) ?
{
return;
}
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
the buffer several
times with different directions ?
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
not available on
our desk phone)
Sure. You can call me at +32477410753.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
then not be very
useful. This could be split to a DRM device without a KMS interface.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Daniel,
On Friday 17 February 2012 10:55:54 Daniel Vetter wrote:
On Fri, Feb 17, 2012 at 12:25:51AM +0100, Laurent Pinchart wrote:
Hello everybody,
First of all, I would like to thank all the attendees for their
participation in the mini-summit that helped make the meeting a success
Hi Sumit,
On Friday 17 February 2012 16:37:35 Semwal, Sumit wrote:
On Fri, Feb 17, 2012 at 4:55 AM, Laurent Pinchart wrote:
Hello everybody,
First of all, I would like to thank all the attendees for their
participation in the mini-summit that helped make the meeting a success.
snip
the fb_videomode - drm_mode_modeinfo conversion functions
accordingly.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/exynos/exynos_drm_connector.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
While trying to understand how
Hi Joonyoung,
On Thursday 08 March 2012 22:05:50 Joonyoung Shim wrote:
On 03/08/2012 08:34 PM, Laurent Pinchart wrote:
The fb_videomode structure stores the front porch and back porch in the
right_margin and left_margin fields respectively. right_margin should
thus be computed
Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Tested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I suppose this will be squashed with Sumit's [RFCv1 2/4] v4l:vb2: add support
for shared buffer (dma_buf) patch.
---
drivers/media/video
to review. I've already split it according to
the above (with the MMAP and USERPTR changes kept together as the original
patch). I'll post the patches in reply to this mail, with my comments as
further replies.
--
Regards,
Laurent Pinchart
___
dri-devel
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/videobuf2-dma-contig.c | 36 ++--
1 files changed, 18 insertions(+), 18 deletions(-)
Needless to say, feel free to modify authorship information for these patches
based
Group functions by buffer type.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/videobuf2-dma-contig.c | 94 ---
1 files changed, 56 insertions(+), 38 deletions(-)
diff --git a/drivers/media/video/videobuf2-dma-contig.c
b
vb2-dma-contig returns a vb2_dc_conf structure instance as the vb2
allocation context. That structure only stores a pointer to the physical
device. Remove it and use the device pointer directly as the allocation
context.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
From: Tomasz Stanislawski t.stanisl...@samsung.com
This patch combines updates and fixes to dma-contig allocator.
Moreover the allocator code was refactored.
The most important changes are:
- functions were reordered
- move compression of scatterlist to separete function
- add support for
Hi Tomasz,
Thanks for the patch.
On Thursday 22 March 2012 11:02:23 Laurent Pinchart wrote:
From: Tomasz Stanislawski t.stanisl...@samsung.com
This patch combines updates and fixes to dma-contig allocator.
Moreover the allocator code was refactored.
The most important changes
= vb2_dc_unmap_dmabuf,
+ .attach_dmabuf = vb2_dc_attach_dmabuf,
+ .detach_dmabuf = vb2_dc_detach_dmabuf,
.num_users = vb2_dc_num_users,
};
EXPORT_SYMBOL_GPL(vb2_dma_contig_memops);
--
Regards,
Laurent Pinchart
___
dri-devel mailing
v4l2_create_buffers *b);
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
;
}
+ dma_unmap_sg(buf-dev, sgt-sgl, sgt-nents, buf-dma_dir);
dma_buf_unmap_attachment(buf-db_attach, sgt);
buf-dma_addr = 0;
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
Hi Subash,
On Thursday 22 March 2012 19:27:01 Subash Patel wrote:
On 03/22/2012 04:46 PM, Laurent Pinchart wrote:
On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote:
[snip]
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index bb6844e..e71c787 100644
Hi Tomasz,
On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote:
Hi Laurent,
Thank you very much for your comments and question.
They were very useful.
You're welcome.
Please refer to the comments below.
On 03/22/2012 11:50 AM, Laurent Pinchart wrote:
On Thursday 22 March 2012
On Thursday 22 March 2012 15:26:08 Daniel Vetter wrote:
On Thu, Mar 22, 2012 at 03:07:18PM +0100, Laurent Pinchart wrote:
+ * Contains data used for exporting a video buffer as DMABUF file
+ * descriptor. Uses the same 'cookie' as mmap() syscall. All
reserved
fields
+ * must
Hi Subash,
On Thursday 22 March 2012 20:29:57 Subash Patel wrote:
On 03/22/2012 07:37 PM, Laurent Pinchart wrote:
On Thursday 22 March 2012 19:27:01 Subash Patel wrote:
On 03/22/2012 04:46 PM, Laurent Pinchart wrote:
On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote:
[snip
Hi Tomasz,
On Friday 23 March 2012 12:33:24 Tomasz Stanislawski wrote:
On 03/22/2012 12:16 PM, Laurent Pinchart wrote:
On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote:
[snip]
+ case VIDIOC_EXPBUF:
+ {
+ struct v4l2_exportbuffer *p = arg;
+
+ if (!ops
Hi Daniel,
On Thursday 22 March 2012 13:25:20 Daniel Vetter wrote:
On Thu, Mar 22, 2012 at 13:15, Laurent Pinchart wrote:
On Tuesday 13 March 2012 11:17:05 Tomasz Stanislawski wrote:
The DMABUF documentation says that the map_dma_buf callback should return
scatterlist that is mapped
Hi Tomasz,
On Thursday 22 March 2012 16:58:27 Tomasz Stanislawski wrote:
On 03/22/2012 03:42 PM, Laurent Pinchart wrote:
On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote:
On 03/22/2012 11:50 AM, Laurent Pinchart wrote:
On Thursday 22 March 2012 11:02:23 Laurent Pinchart wrote
Hi Jerome,
On Tuesday 27 March 2012 12:45:23 Jerome Glisse wrote:
On Tue, Mar 27, 2012 at 11:01 AM, Laurent Pinchart wrote:
On Thursday 22 March 2012 16:58:27 Tomasz Stanislawski wrote:
On 03/22/2012 03:42 PM, Laurent Pinchart wrote:
On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski
Hi Tomasz,
On Monday 26 March 2012 17:53:09 Tomasz Stanislawski wrote:
On 03/22/2012 12:04 PM, Laurent Pinchart wrote:
On Tuesday 13 March 2012 11:17:01 Tomasz Stanislawski wrote:
[snip]
+static void vb2_dc_detach_dmabuf(void *mem_priv)
+{
+ struct vb2_dc_buf *buf = mem_priv
/constant or
s/ or/,/
+constantV4L2_MEMORY_DMABUF/constant or
constantV4L2_MEMORY_USERPTR/constant./entry
/row
row
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org
);
+ int (*map_dmabuf)(void *buf_priv);
+ void(*unmap_dmabuf)(void *buf_priv);
+
void*(*vaddr)(void *buf_priv);
void*(*cookie)(void *buf_priv);
--
Regards,
Laurent Pinchart
___
dri
*/
+ for (plane = 0; plane vb-num_planes; ++plane)
+ call_memop(q, prepare, vb-planes[plane].mem_priv);
+
q-ops-buf_queue(vb);
}
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
);
}
/*/
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
(vb2_dma_contig_memops);
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
/footnote/para
/section
+ section id=dmabuf
+titleStreaming I/O (DMA buffer importing)/title
This section is very similar to the Streaming I/O (User Pointers) section. Do
you think we should merge the two ? I could handle that if you want.
--
Regards,
Laurent Pinchart
the comment below,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
+static void vb2_dc_detach_dmabuf(void *mem_priv)
+{
+ struct vb2_dc_buf *buf = mem_priv;
+
+ if (WARN_ON(buf-dma_addr))
+ vb2_dc_unmap_dmabuf(buf);
This should never happen, and would be a videobuf2
Szyprowski m.szyprow...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
as the allocation
context.
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
Semwal sumit.sem...@ti.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
...@samsung.com
[original work in the PoC for buffer sharing]
Signed-off-by: Sumit Semwal sumit.sem...@ti.com
Signed-off-by: Sumit Semwal sumit.sem...@linaro.org
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
Stanislawski t.stanisl...@samsung.com
[original work in the PoC for buffer sharing]
Signed-off-by: Sumit Semwal sumit.sem...@ti.com
Signed-off-by: Sumit Semwal sumit.sem...@linaro.org
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
in the Minutes from
V4L2 update call thread and reply there to avoid scattering the discussion ?
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
;
+ __u32 mem_offset;
+ __u32 flags;
+ __u32 reserved[12];
+};
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
)buf-dma_addr, vma-vm_start,
+ buf-size);
+
+ return 0;
}
/*/
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org
,
.vaddr = vb2_dc_vaddr,
.mmap = vb2_dc_mmap,
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Marek,
On Tuesday 17 April 2012 13:25:56 Marek Szyprowski wrote:
On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote:
(snipped)
+static struct vm_area_struct *vb2_dc_get_user_vma(
+ unsigned long start, unsigned long size)
+{
+ struct vm_area_struct *vma
-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri
as 'obsolete' feature and providing some emulation layer in
libv4l2 for legacy applications.
Sure.
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
dma_map_sg.
The code is based on the patch 'v4l: vb2-dma-contig: add support for
scatterlist in userptr mode' and hints from Laurent Pinchart.
The patch looks good to me. Just a small comment, what do you think about
naming the function sg_alloc_table_from_pages instead of
sg_table_alloc_by_pages
Hi Tomasz,
Sorry for the late reply, this one slipped through the cracks.
On Thursday 19 April 2012 12:42:12 Tomasz Stanislawski wrote:
On 04/17/2012 04:08 PM, Laurent Pinchart wrote:
On Tuesday 10 April 2012 15:10:39 Tomasz Stanislawski wrote:
This patch adds support for exporting a dma
;
+ cur_page = j;
+ }
+
+ return sgt;
+}
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
using dma_map_sg.
The code is based on the patch 'v4l: vb2-dma-contig: add support for
scatterlist in userptr mode' and hints from Laurent Pinchart.
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Laurent Pinchart
The private gem_create_mmap_offset() function is now implemented in the
DRM core as drm_gem_create_mmap_offset(). Use it and kill the private
copy.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/gma500/Makefile |2 +-
drivers/gpu/drm/gma500/gem.c
resulted
in any wrong patch.
Laurent Pinchart (4):
drm: exynos: DRIVER_BUS_PLATFORM is not a driver feature
drm: exynos: Remove dummy encoder get_crtc operation implementation
drm: exynos: Don't cast GEM object to Exynos GEM object when not
needed
drm: exynos: Keep a reference to frame
DRIVER_BUS_PLATFORM is a bus type used internally in the DRM core, not a
flag for the drm_driver::driver_features field.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |3 +--
1 files changed, 1 insertions(+), 2 deletions
The exynos_drm_gem_dumb_map_offset() doesn't need to access any
Exynos-specific GEM object fields, don't cast the GEM object.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/exynos/exynos_drm_gem.c |9 +++--
1 files changed, 3 insertions(+), 6
.
As the operation is not mandatory, don't implement it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/exynos/exynos_drm_encoder.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
b
GEM objects used by frame buffers must be referenced for the whole life
of the frame buffer. Release the references in the frame buffer
destructor instead of its constructor.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/exynos/exynos_drm_fb.c | 19
Hi Inki,
On Thursday 17 May 2012 17:21:46 Inki Dae wrote:
On Thursday, May 17, 2012 12:09 AM Laurent Pinchart wrote:
The encoder get_crtc operation is called to retrieve a pointer to the
CRTC the encoder is currenctly connected to, right after setting the
encoder::crtc field to the new
Hello,
While studying the DRM core I came across a couple of issues or strange
constructs. Here are 6 patches that try to fix them.
Criticism is as usual welcome. Please bear with my lack of experience with the
DRM core :-)
Laurent Pinchart (6):
drm: Delete the vblank timer synchronously
A race condition exists in drm_vblank_cleanup() if the vblank disable
timer callback runs after freeing the memory that its callback function
tries to access. Fix this by deleting the timer synchronously.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/drm_crtc.c| 12 ++--
drivers/gpu/drm/drm_crtc_helper.c |2 +-
drivers/gpu/drm/drm_edid_load.c |8
drivers/gpu/drm/drm_fb_helper.c |5 +
drivers/gpu/drm/drm_gem.c
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/drm_crtc.c|2 +-
drivers/gpu/drm/drm_sysfs.c |8
include/drm/drmP.h| 10 +-
include/drm/drm_crtc.h| 21 +++--
include/drm/drm_crtc_helper.h
The GEM vm operations structure is passed to the VM core that stores it
in a const field. There vm operations structures can thus be const in
DRM as well.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Inki Dae inki@samsung.com
Cc: Alan Cox a...@linux.intel.com
Cc
The DRM mode config functions structure declared by drivers and pointed
to by the drm_mode_config funcs field is never modified. Make it a const
pointer.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Inki Dae inki@samsung.com
Cc: Alan Cox a...@linux.intel.com
Cc
Drivers for hardware without gamma support should not be forced to
implement a no-op gamma set operation.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Rob Clark rob.cl...@linaro.org
---
drivers/gpu/drm/drm_crtc.c |5 +
drivers/gpu/drm/drm_fb_helper.c
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/v4l2-ioctl.c |1 +
include/linux/videodev2.h|7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/media/video/v4l2-ioctl.c
b/drivers/media/video/v4l2-ioctl.c index 91be4e8
/constant or
constantV4L2_MEMORY_USERPTR/constant. See xref linkend=v4l2-memory/.
/entry
like in v5 ?
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
DRM_IOCTL_MODESET_CTL must only be used for UMS drivers. Make it a no-op
for KMS drivers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/drm_irq.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
My understanding of the DRM framework tells me
The passed mode must not be modified by the operation, make it const.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
This will break the i915 driver, as it modifies mode-clock in
intel_dp_mode_fixup(), hence the RFC state. Is this incorrect behaviour from
the i915 driver
Hi Daniel,
On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote:
On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote:
The passed mode must not be modified by the operation, make it const.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Daniel
Hi Daniel,
On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote:
On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote:
On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote:
On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote:
The passed mode must
driver I'm pretty sure I've made
many mistakes. Review will as usual be very appreciated.
I've modified the modetest application from the libdrm repository to test this
driver, I will submit patches for it right after cleaning them up.
Laurent Pinchart (4):
fbdev: sh_mobile_meram: Add MERAM
Remove direct dependency on the MERAM driver implementation by
introducing inline wrappers for MERAM operations.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/video/sh_mobile_meram.c | 24
include/video/sh_mobile_meram.h | 28
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/video/sh_mobile_lcdcfb.c | 18 +++---
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 7a0b301..671685d 100644
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
include/drm/drm_fourcc.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index bdf0152..fac7235 100644
--- a/include/drm/drm_fourcc.h
+++ b/include
Hi Ville,
Thank you for the review.
On Wednesday 30 May 2012 16:09:25 Ville Syrjälä wrote:
On Wed, May 30, 2012 at 02:32:58PM +0200, Laurent Pinchart wrote:
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
include/drm/drm_fourcc.h |2 ++
1 files changed, 2
Hi Ville,
On Wednesday 30 May 2012 17:05:10 Ville Syrjälä wrote:
On Wed, May 30, 2012 at 03:20:09PM +0200, Laurent Pinchart wrote:
On Wednesday 30 May 2012 16:09:25 Ville Syrjälä wrote:
On Wed, May 30, 2012 at 02:32:58PM +0200, Laurent Pinchart wrote:
Signed-off-by: Laurent Pinchart
Hi Sascha,
On Wednesday 30 May 2012 15:43:24 Sascha Hauer wrote:
Hi Laurent,
On Wed, May 30, 2012 at 02:32:59PM +0200, Laurent Pinchart wrote:
The SH Mobile LCD controller (LCDC) DRM driver supports the main
graphics plane in RGB and YUV formats, as well as the overlay planes (in
alpha
;
+ void __iomem *vaddr;
+};
All drm objects end with _object, would it be better to rename this to struct
drm_gem_cma_object ?
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman
Hi Michel,
On Wednesday 30 May 2012 13:29:06 Michel Dänzer wrote:
On Mit, 2012-05-30 at 00:58 +0200, Laurent Pinchart wrote:
DRM_IOCTL_MODESET_CTL must only be used for UMS drivers. Make it a no-op
for KMS drivers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
1 - 100 of 8955 matches
Mail list logo
