On 2/13/2022 02:20, Lukas Wunner wrote:
On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote:
The `is_thunderbolt` attribute is currently a dumping ground for a
variety of things.
It's not as arbitrary as it may seem. Quite a bit of thought went into
the current design.
[Public]
> -Original Message-
> From: Mika Westerberg
> Sent: Friday, February 11, 2022 04:35
> To: Limonciello, Mario
> Cc: Bjorn Helgaas ; Andreas Noever
> ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.o
[Public]
> -Original Message-
> From: Mika Westerberg
> Sent: Friday, February 11, 2022 04:24
> To: Limonciello, Mario
> Cc: Bjorn Helgaas ; Andreas Noever
> ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.o
On 2/11/2022 15:35, Bjorn Helgaas wrote:
On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote:
`pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt
controller to indicate that D3 is possible. As this is used solely
for older Apple systems, move it into a quirk
On 2/16/2022 08:44, Alex Deucher wrote:
On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg
wrote:
Hi all,
On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote:
On 2/15/2022 01:29, Lukas Wunner wrote:
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
drivers
[AMD Official Use Only]
>
> On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote:
> > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-
> facing"
> > assumption above. Not having a Thunderbolt spec, I have no idea how
> > you deal with that.
>
> You can download the
[AMD Official Use Only]
> -Original Message-
> From: Lukas Wunner
> Sent: Monday, February 28, 2022 16:33
> To: Bjorn Helgaas
> Cc: Limonciello, Mario ; Mika Westerberg
> ; Michael Jamet
> ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open li
On 2/15/2022 01:29, Lukas Wunner wrote:
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +-
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, April 8, 2022 14:09
> To: Gong, Richard
> Cc: Deucher, Alexander ; Koenig, Christian
> ; Pan, Xinhui ; Dave Airlie
> ; Daniel Vetter ; Limonciello, Mario
> ; Maling list - DRI developers de.
[Public]
> -Original Message-
> From: Gong, Richard
> Sent: Friday, April 8, 2022 11:20
> To: Limonciello, Mario ; Deucher, Alexander
> ; Koenig, Christian
> ; Pan, Xinhui ;
> airl...@linux.ie; dan...@ffwll.ch
> Cc: amd-...@lists.freedesktop.org; dri-devel@list
top.org; linux-
> ker...@vger.kernel.org; Limonciello, Mario ;
> Gong, Richard
> Subject: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't
> support ASPM
>
> Active State Power Management (ASPM) feature is enabled since kernel
> 5.14.
> However there are some legacy product
t; gfx list ; Chiu, Solomon
> ; Limonciello, Mario
> ; Quan, Evan ;
> Tuikov, Luben
> Subject: Re: [PATCH] drm/amdgpu: Ensure HDA function is suspended
> before ASIC reset
>
> On Thu, Apr 7, 2022 at 8:21 AM Kai-Heng Feng
> wrote:
> >
> > DP/HDMI audio on AMD PR
[Public]
> On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel
> wrote:
> >
> > Dear Richard,
> >
> >
> > Thank you for sending out v4.
> >
> > Am 12.04.22 um 23:50 schrieb Richard Gong:
> > > Active State Power Management (ASPM) feature is enabled since kernel
> 5.14.
> > > There are some AMD GFX
exander ; Koenig, Christian
> ; Limonciello, Mario
>
> Subject: Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based
> systems
>
> On Wed, Apr 20, 2022 at 5:02 PM Paul Menzel
> wrote:
> >
> > Dear Richard,
> >
> >
> > Am 20.04.22 um
[Public]
> -Original Message-
> From: Werner Sembach
> Sent: Wednesday, July 13, 2022 12:08
> To: Hans de Goede ; Ben Skeggs
> ; Karol Herbst ; Lyude
> ; Daniel Dadap ; Maarten
> Lankhorst ; Maxime Ripard
> ; Thomas Zimmermann ;
> Jani Nikula ; Joonas Lahtinen
> ; Rodrigo Vivi ;
>
l test robot ; LKML ker...@vger.kernel.org>; Maling list - DRI developers de...@lists.freedesktop.org>; Limonciello, Mario
>
> Subject: Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake
> based systems
>
> Reviewed-by: Alex Deucher
>
> On Fri, Apr 29, 2022 at 1
On 8/24/2022 12:32, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki
According to the ACPI specification [1], the ACPI_FADT_LOW_POWER_S0
flag merely means that it is better to use low-power S0 idle on the
given platform than S3 (provided that the latter is supported) and it
doesn't preclude
On 10/25/2022 15:25, Hans de Goede wrote:
Hi Matthew,
On 10/25/22 21:32, Matthew Garrett wrote:
On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
That is a valid point, but keep in mind that this is only used on ACPI
platforms and then only on devices with a builtin LCD panel
[AMD Official Use Only - General]
> -Original Message-
> From: Lazar, Lijo
> Sent: Thursday, January 5, 2023 07:22
> To: Limonciello, Mario ; Deucher, Alexander
> ; linux-ker...@vger.kernel.org
> Cc: Javier Martinez Canillas ; Carlos Soriano Sanchez
> ; amd-...@
[Public]
> -Original Message-
> From: Christian König
> Sent: Wednesday, January 4, 2023 07:18
> To: Limonciello, Mario ; Deucher, Alexander
> ; linux-ker...@vger.kernel.org
> Cc: Pan, Xinhui ; Lazar, Lijo ;
> Javier Martinez Canillas ; dri-
> de...@li
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Wednesday, January 4, 2023 11:16
> To: Limonciello, Mario
> Cc: Deucher, Alexander ; linux-
> ker...@vger.kernel.org; Pan, Xinhui ; Lazar, Lijo
> ; Javier Martinez Canillas ; dri-
> de...@li
[AMD Official Use Only - General]
This particular one was fixed already in
https://patchwork.freedesktop.org/patch/518050/ which got applied today.
> -Original Message-
> From: coverity-bot
> Sent: Thursday, January 12, 2023 16:25
> To: Limonciello, Mario
>
On 1/12/2023 02:50, Wayne Lin wrote:
This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f.
[Why]
Changes cause regression on amdgpu mst.
E.g.
In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload
one by one and call fill_dc_mst_payload_table_from_drm() to update
[AMD Official Use Only - General]
> -Original Message-
> From: Lazar, Lijo
> Sent: Thursday, January 5, 2023 21:27
> To: Limonciello, Mario ; Deucher, Alexander
> ; linux-ker...@vger.kernel.org
> Cc: Javier Martinez Canillas ; Carlos Soriano Sanchez
> ; amd-...@
On 11/18/2022 13:25, Lyude Paul wrote:
It appears that amdgpu makes the mistake of completely ignoring the return
values from the DP MST helpers, and instead just returns a simple
true/false. In this case, it seems to have come back to bite us because as
a result of simply returning false from
On 1/13/2023 13:28, Lyude Paul wrote:
On Fri, 2023-01-13 at 11:25 +0100, Daniel Vetter wrote:
On Fri, Jan 13, 2023 at 12:16:57PM +0200, Jani Nikula wrote:
Cc: intel-gfx, drm maintainers
Please have the courtesy of Cc'ing us for changes impacting us, and
maybe try to involve us earlier
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Monday, January 16, 2023 15:42
> To: Guilherme G. Piccoli
> Cc: amd-...@lists.freedesktop.org; Jiang, Sonny ;
> ker...@gpiccoli.net; Pan, Xinhui ; dri-
> de...@lists.freedesktop.org; Lazar, Lijo ; Limoncie
On 1/16/2023 18:47, Guilherme G. Piccoli wrote:
On 16/01/2023 20:00, Alex Deucher wrote:
[...]
It's not clear to me when this would be used. We only disable it
briefly during new asic bring up, after that we never touch it again.
No end user on production hardware should ever have to change
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Monday, January 16, 2023 15:54
> To: Limonciello, Mario
> Cc: Guilherme G. Piccoli ; amd-
> g...@lists.freedesktop.org; Jiang, Sonny ;
> ker...@gpiccoli.net; Pan, Xinhui ; dri-
> de...@lists.free
On 1/20/2023 11:46, Guenter Roeck wrote:
On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote:
This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f.
[Why]
Changes cause regression on amdgpu mst.
E.g.
In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload
one
[Public]
> -Original Message-
> From: Guenter Roeck On Behalf Of Guenter Roeck
> Sent: Friday, January 20, 2023 12:18
> To: Limonciello, Mario
> Cc: Lin, Wayne ; dri-devel@lists.freedesktop.org;
> amd-...@lists.freedesktop.org; sta...@vger.kernel.org;
> stanisla
[Public]
> -Original Message-
> From: Linux kernel regression tracking (Thorsten Leemhuis)
>
> Sent: Friday, January 27, 2023 03:15
> To: Greg KH ; Limonciello, Mario
>
> Cc: dri-devel@lists.freedesktop.org; sta...@vger.kernel.org;
> stanislav.lisovs...@int
t; kernel-...@igalia.com; Guilherme G. Piccoli
> ; Zhu, James ; Lazar, Lijo
> ; Liu, Leo ; Limonciello, Mario
> ; Jiang, Sonny
> Subject: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM
> HW model check
>
> The HW model validation that guards the indirect SRAM checking
[Public]
> -Original Message-
> From: Guilherme G. Piccoli
> Sent: Tuesday, January 17, 2023 12:14
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org; Deucher, Alexander
>
> Cc: dri-devel@lists.freedesktop.org; Koenig, Christian
> ; Pan, Xinhui
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Tuesday, January 17, 2023 09:11
> To: Guilherme G. Piccoli
> Cc: Limonciello, Mario ; Liu, Leo
> ; amd-...@lists.freedesktop.org; Jiang, Sonny
> ; ker...@gpiccoli.net; Pan, Xinhui
> ; dri-devel@list
On 11/10/2022 06:28, Denis Arefev wrote:
Return value of a function 'amdgpu_ras_find_obj' is dereferenced at
nbio_v7_4.c:325 without checking for null
This line is too long, you should be wrapping lines at 75 characters.
Could you run your patch through checkpatch?
Found by Linux
[AMD Official Use Only - General]
> -Original Message-
> From: Greg KH
> Sent: Sunday, January 29, 2023 07:32
> To: Limonciello, Mario
> Cc: Linux regressions mailing list ; dri-
> de...@lists.freedesktop.org; sta...@vger.kernel.org;
> stanislav.lisovs...@intel.
lix ; Zhao, Victor ;
> Xiao, Jack ; Quan, Evan ;
> Limonciello, Mario ; Lazar, Lijo
> ; Chai, Thomas ; Andrey
> Grodzovsky ; Somalapuram, Amaranath
> ; Zhang, Bokun
> ; Liu, Leo ; Gopalakrishnan,
> Veerabadhran (Veera) ; Gong,
> Richard ; Feng, Kenneth
> ; Jian
+regressions
On 7/10/2023 04:58, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
On 5/30/2023 1:22 AM, Felix Fietkau wrote:
On 30.05.23 04:42, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform
designs there may
be likely interference of relatively high-powered harmonics of the
(G-)DDR memory
clocks with local radio module frequency bands
On 7/31/2023 8:26 AM, Ruan Jinjie wrote:
Ther are many ternary operators, the true or false judgement
of which is unnecessary in C language semantics.
s/Ther/There/
Unnecessary; sure. But don't they improve the readability quite a bit?
Signed-off-by: Ruan Jinjie
---
On 7/24/2023 04:22, Andrew Lunn wrote:
@@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
debugfs_hw_add(local);
rate_control_add_debugfs(local);
+ ieee80211_check_wbrf_support(local);
+
rtnl_lock();
wiphy_lock(hw->wiphy);
+void
[Public]
You've got an A-b from Evan already on this. It looks fine to me too.
Reviewed-by: Mario Limonciello
> -Original Message-
> From: Yang, WenYou
> Sent: Sunday, June 11, 2023 12:53 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Limonciello, Mario
> ; Koenig,
On 6/21/2023 5:22 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 13:45 +0800, Evan Quan wrote:
To support AMD's WBRF interference mitigation mechanism, Wifi adapters
utilized in the system must register the frequencies in use(or unregister
those frequencies no longer used) via the dedicated
On 6/21/2023 12:26 PM, Andrew Lunn wrote:
I think what you're asking for is another layer of indirection
like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF.
Producers would call functions like wbrf_supported_producer()
where the source file is not guarded behind CONFIG_ACPI_WBRF,
but instead by
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another
question would be where should the new "wbrf.c" be stored? The ACPI only
version most certainly made sense in drivers/acpi/wbrf.c, but a generic
version that only has an ACPI implementation right now not so much.
On
On 6/21/2023 11:52 AM, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote:
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of
On 6/21/2023 11:31 AM, Andrew Lunn wrote:
I think there is enough details for this to happen. It's done
so that either the AML can natively behave as a consumer or a
driver can behave as a consumer.
+/**
+ * APIs needed by drivers/subsystems for contributing frequencies:
+ * During probe,
On 6/21/2023 11:14 AM, Andrew Lunn wrote:
Do only ACPI based systems have:
interference of relatively high-powered harmonics of the (G-)DDR
memory clocks with local radio module frequency bands used by
Wifi 6/6e/7."
Could Device Tree based systems not experience this problem?
On 6/21/2023 8:55 PM, Andrew Lunn wrote:
Honestly I'm not sure though we need this complexity right now? I mean,
it'd be really easy to replace the calls in mac80211 with some other
more generalised calls in the future?
You need some really deep platform/hardware level knowledge and
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory
eedesktop.org; Joonas Lahtinen
> ; dri-devel@lists.freedesktop.org; Chai,
> Thomas ; Limonciello, Mario
> ; Gao, Likun ; David
> Airlie ; Ville Syrjala ; Yi
> Liu
> ; k...@vger.kernel.org; amd-...@lists.freedesktop.org;
> Jason Gunthorpe ; Ben Skeggs ; linux-
> p..
On 6/12/2023 2:25 PM, Sui Jingfeng wrote:
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
On 6/30/2023 05:32, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory clocks with local radio module frequency bands used
by Wifi 6/6e/7.
To mitigate this, AMD has
On 6/23/2023 11:28 AM, Rafael J. Wysocki wrote:
On Fri, Jun 23, 2023 at 5:57 PM Limonciello, Mario
wrote:
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
is meaningless to call amdgpu_irq_put() for
On 5/10/2024 4:24 AM, Jani Nikula wrote:
On Fri, 10 May 2024, "Lin, Wayne" wrote:
[Public]
-Original Message-----
From: Limonciello, Mario
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list ; Wentland,
Harry
; Lin, Wayne
Cc: ly...@redhat.com; imre.d...
Also a direct acpi_lid_open() call seems a bit iffy. But I guess if
someone needs this to work on non-ACPI system they get to figure out
how to abstract it better. acpi_lid_open() does seem to return != 0
when ACPI is not supported, so at least it would err on the side
of enabling everything.
59 matches
Mail list logo
