[Intel-gfx] [PATCH v2 05/10] drm/i915/gen9: Get rid of redundant watermark values

Your is SAGV related, and when we don't make the SAGV happy people's machines usually hang. So I'm definitely for your patches getting merged first On Thu, 2016-10-13 at 17:07 -0300, Paulo Zanoni wrote: > Em Qui, 2016-10-13 às 17:04 -0300, Paulo Zanoni escreveu: > > > > Em Qui, 2016-10-13 às

[PATCH] drm/i915/dp: Stop enabling limited color ranges for everything

On Thu, 2017-01-05 at 09:52 +0100, Daniel Vetter wrote: > On Thu, Jan 05, 2017 at 10:41:07AM +0200, Jani Nikula wrote: > > No matter what we do here, the question remains what to do with > > Chamelium. Changing the color range is really a workaround for > > Chamelium, not a fix. Using CEA range is

[PATCH v6 6/6] drm/i915/skl: Update DDB values atomically with wms/plane attrs

On Wed, 2016-08-03 at 18:00 +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 06:37:37PM -0400, Lyude wrote: > > > > Now that we can hook into update_crtcs and control the order in which we > > update CRTCs at each modeset, we can finish the final step of fixing > > Skylake's watermark

[PATCH v12 2/7] drm/i915/skl: Add support for the SAGV, fix underrun hangs

On Thu, 2016-08-18 at 09:39 +0200, Maarten Lankhorst wrote: > Hey, > > Op 17-08-16 om 21:55 schreef Lyude: > > > > Since the watermark calculations for Skylake are still broken, we're apt > > to hitting underruns very easily under multi-monitor configurations. > > While it would be lovely if

[Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume

On Thu, 2016-11-03 at 16:02 +, Chris Wilson wrote: > On Thu, Nov 03, 2016 at 11:42:37AM -0400, Lyude wrote: > > > > Weine's investigation on benchmarking the suspend/resume process pointed > > out a lot of the time in suspend/resume is being spent reprobing. While > > the reprobing process is

[Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume

On Thu, 2016-11-03 at 12:11 -0400, Lyude Paul wrote: > On Thu, 2016-11-03 at 16:02 +, Chris Wilson wrote: > > > > On Thu, Nov 03, 2016 at 11:42:37AM -0400, Lyude wrote: > > > > > > > > > Weine's investigation on benchmarking the suspend/resume p

[Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume

On Thu, 2016-11-03 at 16:25 +, Chris Wilson wrote: > On Thu, Nov 03, 2016 at 12:11:55PM -0400, Lyude Paul wrote: > > > > On Thu, 2016-11-03 at 12:11 -0400, Lyude Paul wrote: > > > > > > On Thu, 2016-11-03 at 16:02 +, Chris Wilson wrote: > > >

[Intel-gfx] [PATCH v4] drm/i915/ilk: Don't disable SSC source if it's in use

On Mon, 2016-06-06 at 14:30 +0300, Ville Syrjälä wrote: > On Thu, May 26, 2016 at 09:54:56AM +0200, Daniel Vetter wrote: > > > > On Wed, May 25, 2016 at 02:11:02PM -0400, Lyude wrote: > > > > > > Thanks to Ville Syrjälä for pointing me towards the cause of this issue. > > > > > >

[PATCH v2 3/3] drm/i915: Enable polling when we don't have hpd

As a forewarning: I have confirmed the CRT hpd loops Vsyrjala has mentioned, and they are triggered by this patch. I'm working on a patch for this atm. On Mon, 2016-06-20 at 16:57 -0400, Lyude wrote: > Unfortunately, there's two situations where we lose hpd right now: > - Runtime suspend > - When

[PATCH 4/6] drm/i915/skl: Always wait for pipes to update after a flush

Two things for this one: 1. I completely messed up the description on this patchset, this was for fixing underruns on pipe disablement. I'm impressed I wrote up that whole description without realizing that at all, lol. 2. This patch may not actually be necessary. On the original git branch I was

[PATCH 0/4] Backported vlv fixes for 4.7.y

drm/i915/vlv: Make intel_crt_reset() per-encoder: 4570d833390b10043d082fe535375d4a0e071d9c drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init(): 4c732e6ee9e71903934d75b12a021eb3520b6197 drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug(): 21842ea84f161ae37ba25f0250c377fd19c5b307

[Intel-gfx] [PATCH] drm/i915: Resume DP MST before doing any kind of modesetting

Unfortunately MST is a wild beast, and doesn't work at all like other connectors. This being said, putting it above intel_display_resume() was the first thing I tried but that didn't work. Originally I had thought putting it this high up was required because I had assumed drm_mode_config_reset()

[Intel-gfx] [PATCH] drm/i915: Fix enc_to_dig_port() for MST encoders

I gave a short try at fixing MST audio, but it definitely looks like it's going to require quite a bit of troubleshooting and a few more patches :(. Since I can't find an immediate fix to actually make MST audio work I'm totally in favor of reverting the MST audio support for the time being On

[Intel-gfx] [PATCH] drm/i915: Discard previous atomic state on resume if connectors change

Yeah airlied said the same thing. This patch is more intended for just 4.6 since the refcounting patch isn't very likely to get into 4.6. On Tue, 2016-05-03 at 16:29 +0200, Daniel Vetter wrote: > On Tue, May 03, 2016 at 10:03:40AM -0400, Lyude wrote: > > > > If an MST device is disconnected

[PATCH 2/3] drm/fb_helper: Fix references to dev->mode_config.num_connector

I would Cc it to stable just in case tbh. I picked up on this one since KASAN was picking up on some of the memcpy() calls around here going out of bounds. I can include some of the backtraces from that if needed. On Wed, 2016-05-04 at 19:11 +0200, Daniel Vetter wrote: > On Wed, May 04, 2016 at

[PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change

Yep, Dave's patches fix the issue on their own so this is only going to be needed for 4.6. On Mon, 2016-05-09 at 08:42 +0200, Daniel Vetter wrote: > On Fri, May 06, 2016 at 05:39:56PM -0400, Lyude wrote: > > > > If an MST device is disconnected while the machine is suspended, the > > number of

[PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change

no problem, I'll let you know when they're ready On Mon, 2016-05-09 at 16:53 +0200, Daniel Vetter wrote: > On Mon, May 09, 2016 at 10:07:08AM -0400, Lyude Paul wrote: > > > > Yep, Dave's patches fix the issue on their own so this is only going to be > > needed for 4.6. >

[2/3] drm/mst: Fix error handling during MST sideband message reception

On Thu, 2016-05-12 at 16:00 +0300, Imre Deak wrote: > Handle any error due to partial reads, timeouts etc. to avoid parsing > uninitialized data subsequently. Also bail out if the parsing itself > fails. > > CC: Dave Airlie > Signed-off-by: Imre Deak > --- >  

[PATCH] drm/i915/ilk: Wait one vblank before enabling audio

On Mon, 2016-05-23 at 21:06 +0300, Ville Syrjälä wrote: > On Fri, May 20, 2016 at 05:36:40PM -0400, Lyude wrote: > > > > We no longer call ilk_audio_codec_enable() while we have vblanks > > disabled. As such, we can finally fix this and stop the occasional pipe > > underruns I'm seeing on this

[PATCH v2] drm/i915/ilk: Don't disable SSC source if it's in use

Huh… so I'm going to have to take back what I said before about this. On further observation, it looks like the "Don't disable SSC source if it's in use" patch actually got rid of the underruns entirely, with or without the wait for a vblank here. On Tue, 2016-05-24 at 16:14 +0300, Ville

[PATCH] drm/dp/mst: Always clear proposed vcpi table for port.

Looks good to me. Reviewed-by: Lyude On Thu, 2016-05-19 at 23:18 -0400, Andrey Grodzovsky wrote: > Not clearing mst manager's proposed vcpis table for destroyed > connectors when the manager is stopped leaves it pointing to > unrefernced memory, this causes pagefault when the manager is >

[PATCH] drm/i915: Fix race condition in intel_dp_destroy_mst_connector()

On Wed, 2016-03-16 at 21:39 +0200, Ville Syrjälä wrote: > On Wed, Mar 16, 2016 at 03:18:04PM -0400, Lyude wrote: > > > > After unplugging a DP MST display from the system, we have to go through > > and destroy all of the DRM connectors associated with it since none of > > them are valid

[Intel-gfx] [PATCH 1/2] drm/i915: Call intel_dp_mst_resume() before resuming displays

On Sun, 2016-03-13 at 19:45 +0100, Daniel Vetter wrote: > On Fri, Mar 11, 2016 at 10:57:01AM -0500, Lyude wrote: > > > > Since we need MST devices ready before we try to resume displays, > > calling this after intel_display_resume() can result in some issues with > > various laptop docks where

[Intel-gfx] [PATCH 2/2] drm/i915: Get rid of intel_dp_dpcd_read_wake()

On Fri, 2016-03-18 at 20:05 +0200, Ville Syrjälä wrote: > On Fri, Mar 18, 2016 at 07:00:29PM +0100, Daniel Vetter wrote: > > > > On Fri, Mar 18, 2016 at 06:41:40PM +0200, Ville Syrjälä wrote: > > > > > > On Fri, Mar 18, 2016 at 06:12:35PM +0200, Ville Syrjälä wrote: > > > > > > > > On

[PATCH v4 RESEND 1/5] drm/dp_helper: Increase retry interval to 1000us

Yep, the rest of the patchset works fine without this patch On Tue, 2016-03-29 at 10:27 +0200, Daniel Vetter wrote: > On Mon, Mar 28, 2016 at 10:33:22AM -0400, Lyude wrote: > > > > This is part of a patch series to migrate all of the workarounds for > > commonly seen behavior from bad sinks in

[Intel-gfx] [PATCH 1/2] drm/i915: Call intel_dp_mst_resume() before resuming displays

bump Could we get a reviewed-by for this patch? It's needed in addition to the patch series I sent for removing intel_dp_dpcd_read_wake() for the T560 to have it's monitors work properly on resume. On Wed, 2016-03-16 at 17:49 -0400, Lyude Paul wrote: > On Sun, 2016-03-13 at 19:45 +0100, Dan

Re: [Intel-gfx] [PATCH] drm/probe-helpers: Drop locking from poll_enable

Fixes locking issues I've witnessed on the W541. Tested-by: Lyude Reviewed-by: Lyude On Wed, 2017-01-11 at 10:01 +0100, Daniel Vetter wrote: > It was only needed to protect the connector_list walking, see > > commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f

[PATCH] drm/i915/vlv: Enable/disable VGA hotplugging properly

Looks like we might not need to worry about this patch anymore actually, looks like this problem got fixed by accident by one of the other vlv fixes you pushed. Now it's not always modesetting on hotplug when it was before though :(, so I'll get to work on bisecting that. On Thu, 2016-04-14 at

[PATCH] drm/i915/vlv: Enable/disable VGA hotplugging properly

Huh, neither am I now. I seem to be able to reproduce the problem just fine again. Anyway I'll send the new versions of the patches in a little bit On Fri, 2016-04-15 at 18:49 +0300, Ville Syrjälä wrote: > On Fri, Apr 15, 2016 at 09:47:51AM -0400, Lyude Paul wrote: > > > > Look

Re: [PATCH 2/2] drm/i915/dp: Leave the AUX block powered on for MST

Acked-by: Lyude Paul <ly...@redhat.com> On Thu, 2017-08-10 at 18:16 -0700, Dhinakaran Pandiyan wrote: > Dell monitor with a built-in MST branch does not light up on boot > when > connected to a Thinkpad dock. The monitor also does not wake up after > Suspend-t

Re: [PATCH 3/3] drm: Avoid dereferencing a NULL mstb in drm_dp_mst_handle_up_req()

Looks good to me. Reviewed-by: Lyude On Mon, 2017-07-17 at 15:10 +0300, Imre Deak wrote: > On Thu, May 12, 2016 at 04:00:40PM +0300, Imre Deak wrote: > > In case of an unknown broadcast message is sent mstb will remain > > unset, > > so check for this. > > > > CC: Dave Airlie

Re: [Intel-gfx] [PATCH i-g-t 0/2] Unrelated hotplug uevent masking out actual test result

For the whole series Reviewed-by: Lyude will push in just a sec On Tue, 2017-07-18 at 18:16 +0300, Paul Kocialkowski wrote: > This patch introduces a workaround for a case where a uevent is > issued > by the kernel because of DP link training failing on a connector >

Re: [PATCH v3 3/3] drm/mst: Avoid processing partially received up/down message transactions

On Wed, 2017-07-19 at 16:46 +0300, Imre Deak wrote: > Currently we may process up/down message transactions containing > uninitialized data. This can happen if there was an error during the > reception of any message in the transaction, but we happened to > receive > the last message correctly

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/chamelium: Skip suspend/resume test with unreliable hotplug event

On Wed, 2017-07-19 at 11:31 +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-18 at 22:21 +0100, Chris Wilson wrote: > > Quoting Paul Kocialkowski (2017-07-18 16:16:26) > > > It may occur that a hotplug uevent is detected at resume, even > > > though it > > > does not indicate that an actual

Re: [PATCH v2 0/3] drm/mst: Fix sideband msg reception error path

On Wed, 2017-07-19 at 14:43 +0300, Imre Deak wrote: > This is a resend of the last two patches from [1], addressing Lyude's > comments and adding his R-bs. The first patch in [1] isn't needed any It's "her" by the way :P. Also would you mind resending this with a Cc to sta...@vger.kernel.org

Re: [PATCH] drm/nouveau: Add support for clockgating on Fermi+

= -1; /* undefined */ > > return 0; > >  } > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/clkgate.c > > b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/clkgate.c > > new file mode 100644 > > index 000..c030ea9 > > --

Re: [PATCH] drm/nouveau: Fix drm poll_helper handling

> Fixes: cae9ff036eea ("drm/nouveau: Don't enabling polling twice on > runtime resume") > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> > Cc: Lyude Paul <ly...@redhat.com> > Cc: Dave Airlie <airl...@redhat.com> > Cc: Gleb Nemshilov <g..

Re: [PATCH] drm/radeon: Unbreak HPD handling for r600+

Mind giving me this a poke when this gets pushed upstream btw? On Fri, 2017-05-12 at 08:56 +0200, Christian König wrote: > Am 12.05.2017 um 01:31 schrieb Lyude: > > We end up reading the interrupt register for HPD5, and then writing > > it > > to HPD6 which on systems without anything using HPD5

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

On Sat, 2017-05-20 at 13:39 +0200, Christian König wrote: > Am 20.05.2017 um 01:48 schrieb Lyude: > > This is the first part of me going through and cleaning up the IRQ > > handling > > code for radeon, since after taking a look at it the other day > > while trying to > > debug something I

Re: [PATCH v2] drm/dp/mst: Sideband message transaction to power up/down nodes

Looks good to me. Reviewed-by: Lyude Paul <ly...@redhat.com> On Wed, 2017-09-06 at 17:14 -0700, Dhinakaran Pandiyan wrote: > The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions > allow > the source to reqest any node in a mst path or a whole path to be >

Re: [PATCH 1/2] drm/dp/mst: Sideband message transaction to power up/down nodes

On Tue, 2017-09-05 at 18:26 -0700, Dhinakaran Pandiyan wrote: > The POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions > allow > the source to reqest any node in a mst path or a whole path to be > powered down or up. This allows drivers to target a specific sink in > the > MST topology,

[PATCH 2/4] dma-buf: make reservation_object_copy_fences rcu save

amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/1504551766-5093-1-git-send-email-deathsim...@vodafone.de Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/dma-buf/reservation.c | 56 +

[PATCH 0/4] Backported amdgpu ttm deadlock fixes for 4.14

I haven't gone to see where it started, but as of late a good number of pretty nasty deadlock issues have appeared with the kernel. Easy reproduction recipe on a laptop with i915/amdgpu prime with lockdep enabled: DRI_PRIME=1 glxinfo Additionally, some more race conditions exist that I've

[PATCH 4/4] drm/ttm: Always and only destroy bo->ttm_resv in ttm_bo_release_list

tian König <christian.koe...@amd.com> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 11 --- 1 file changed, 4 insertions(+), 7 deleti

[PATCH 1/4] drm/ttm: fix ttm_bo_cleanup_refs_or_queue once more

eserve it. commit 378e2d5b504fe0231c557751e58b80fcf717cc20 upstream Signed-off-by: Christian König <christian.koe...@amd.com> Acked-by: Chunming Zhou <david1.z...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lyude Paul <ly...@redhat.com> ---

[PATCH 3/4] drm/amdgpu: reserve root PD while releasing it

d-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 +++-- 1 file ch

Re: radeon_dp_aux_transfer_native: 74 callbacks suppressed

The main reason I added this was because the radeon driver's hotplugging paths for DP do a ton of unnessecary probing, and because the driver usually also checks all connectors every time there's a hotplug (there isn't much of a good reason for this, it's just an old driver) it's not at all

[PATCH] drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()

new atomic state. Signed-off-by: Lyude Paul --- As a note, I'm not entirely happy with this fix and I wouldn't be surprised if I missed something while looking through amdgpu. So, please don't hesistate to suggest a better fix :). drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +

[PATCH 4/4] drm/amdgpu: Dynamically probe for ATIF handle

to use for ATIF and using that instead of the device's handle. This fixes HPD detection while in runtime suspend for this ZBook! Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 80 +--- 1 file changed, 59 insertions(+), 21 deletions(-) diff --git

[PATCH 2/4] drm/amdgpu: s/disp_detetion_ports/disp_detection_ports/

Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c index 1ae5ae8c45a4..717cc5a90313 100644

[PATCH 1/4] drm/amdgpu: Make struct amdgpu_atif private to amdgpu_acpi.c

, the type definition for acpi_handle and all of the other acpi headers) doesn't need to be included within the amdgpu_drv struct itself. This follows the example set by amdgpu_atpx_handler.c. Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 40 +- drivers/gpu/drm

[PATCH 3/4] drm/amdgpu: Add amdgpu_atpx_get_dhandle()

Since it seems that some vendors are storing the ATIF ACPI methods under the same handle that ATPX lives under instead of the device's own handle, we're going to need to be able to retrieve this handle later so we can probe for ATIF there. Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd

[PATCH 0/4] Fix HPD detection in runtime suspend

Does what it says on the label, more information in the patches Lyude Paul (4): drm/amdgpu: Make struct amdgpu_atif private to amdgpu_acpi.c drm/amdgpu: s/disp_detetion_ports/disp_detection_ports/ drm/amdgpu: Add amdgpu_atpx_get_dhandle() drm/amdgpu: Dynamically probe for ATIF handle

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

On Fri, 2018-06-22 at 13:34 -0400, Andrey Grodzovsky wrote: > > On 06/21/2018 04:48 PM, Lyude Paul wrote: > > This fixes a regression I accidentally reduced that was picked up by > > kasan, where we were checking the CRTC atomic states after DRM's helpers > > had alr

[PATCH] video/console/vgacon: Print big fat warning with nomodeset

enabled. Signed-off-by: Lyude Paul --- drivers/video/console/vgacon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c index f09e17b60e45..09731b2f6815 100644 --- a/drivers/video/console/vgacon.c +++ b/drivers/video/console

[PATCH] drm/nouveau: Fix deadlock in nv50_mstm_register_connector()

mple from i915, the only time we need to hold any modesetting locks is when changing the port on the mstc, and in that case we only need to hold the connection mutex. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Karol Herbst <kher...@redhat.com> Cc: sta...@vger.kernel.org Signed-off-b

[PATCH] drm/nouveau: Set DRIVER_ATOMIC cap earlier to fix debugfs

allowed to modify it through anything other than the legacy ioctls. Additionally, disable the DRIVER_ATOMIC cap in nv04's display core, as this was already disabled there previously. Signed-off-by: Lyude Paul Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/dispnv04/disp.c | 3 +++ drivers

[PATCH 2/2] drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit()

A CRTC being enabled doesn't mean it's on! It doesn't even necessarily mean it's being used. This fixes runtime PM leaks on the P50 I've got next to me. Signed-off-by: Lyude Paul Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/2] drm/nouveau: Fix runtime PM leaks

One very easy to trigger runtime PM leak, along with a rare never before seen runtime PM leak! Lyude Paul (2): drm/nouveau: Fix runtime PM leak in drm_open() drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau

[PATCH 1/2] drm/nouveau: Fix runtime PM leak in drm_open()

Noticed this as I was skimming through, if we fail to allocate memory for cli we'll end up returning without dropping the runtime PM ref we got. Additionally, we'll even return the wrong return code! (ret most likely will == 0 here, we want -ENOMEM). Signed-off-by: Lyude Paul Cc: sta

Re: [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

Sorry for the late reply, I've been having very similar issues on my own MST hub and I wanted to make sure that they were the same issue, although it seems like they aren't. So; I've been doing a lot of MST debugging this week and last and something I've discovered needs to be taken into account

[RFC 0/4] Implement full clockgating for Kepler1 and 2

patchset and let us know how well it works for you! Lyude Paul (4): drm/nouveau: Add support for basic clockgating on Kepler1 drm/nouveau: Add support for BLCG clockgating for Kepler1 drm/nouveau: Add BLCG clockgating for Kepler2 drm/nouveau: Add SLCG clockgating for Kepler2 drivers/gpu

Re: [Nouveau] [RFC 0/4] Implement full clockgating for Kepler1 and 2

mi patch set available somewhere for me to test? > > Thank you > Regards Brock > > > > On 16 Jan. 2018 9:08 am, "Lyude Paul" <ly...@redhat.com> wrote: > > It's here! After a lot of investigation, rewrites, and traces, I present > > the patch series

[RFC 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 10 ++ drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 17 +-- drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 72

[RFC 3/4] drm/nouveau: Add BLCG clockgating for Kepler2

This is mostly the same as Kepler1, but we save even more power! Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c

[RFC 4/4] drm/nouveau: Add SLCG clockgating for Kepler2

be noted that SLCG was added starting with kepler2, previous generations have no SLCG. SLCG can be enabled with the nouveau config option, NvPmEnableGating=3 Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 1 + drivers/gpu/drm/nouvea

[RFC 2/4] drm/nouveau: Add support for BLCG clockgating for Kepler1

since BLCG is mostly the same there as far as we can tell. In the future, it's likely we'll reformat the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 14 ++ d

Re: [PATCH] dma-buf: fix reservation_object_wait_timeout_rcu once more

Could you please make sure to add Cc: sta...@vger.kernel.org for this? This is causing crashing of wayland sessions on Fedora so we should definitely get this into stable. Other then that: Tested-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Lyude Paul <ly...@redhat.com> On Mon

[RFC v2 2/4] drm/nouveau: Add support for BLCG on Kepler1

the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 12 ++ drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/gr/g

[RFC v2 0/4] Implement full clockgating for Kepler1 and 2

boolean option. - Fixup nvkm_info() messages so that we don't mention powergating in them, since this isn't actually added in this series (and may not be for a while, only time will tell :) - Don't export unused function gk104_therm_new_() Lyude Paul (4): drm/nouveau: Add support

[RFC v2 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 5 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 17 +-- drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c

[RFC v2 4/4] drm/nouveau: Add support for SLCG for Kepler2

before taking affect. As with the previous series, this results in another noticeable drop in power consumption and is programmed in the same manner. Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c | 93 ++ 1 file chang

[RFC v2 3/4] drm/nouveau: Add support for BLCG on Kepler2

Same as the previous patch, but for Kepler2 now Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c

Re: [Nouveau] [RFC v2 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

On Fri, 2018-01-26 at 12:34 +0100, Karol Herbst wrote: > On Fri, Jan 26, 2018 at 4:35 AM, Lyude Paul <ly...@redhat.com> wrote: > > This adds support for enabling automatic clockgating on nvidia GPUs for > > Kepler1. While this is not technically a clockgating level, it does &

Re: [RFC v2 3/4] drm/nouveau: Add support for BLCG on Kepler2

On Fri, 2018-01-26 at 02:53 -0500, Ilia Mirkin wrote: > On Thu, Jan 25, 2018 at 10:35 PM, Lyude Paul <ly...@redhat.com> wrote: > > Same as the previous patch, but for Kepler2 now > > > > Signed-off-by: Lyude Paul <ly...@redhat.com> > > --- > > dri

[PATCH] drm/nouveau: Move irq setup/teardown to pci ctor/dtor

, this probably means we can also just remove the msi rearm call inside nvkm_pci_init(). But since our main focus here is to fix suspend/resume before 4.16, we'll save that for a later patch. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Karol Herbst <kher...@redhat.com> Cc: Thomas

[PATCH v2] drm/nouveau: Move irq setup/teardown to pci ctor/dtor

, this probably means we can also just remove the msi rearm call inside nvkm_pci_init(). But since our main focus here is to fix suspend/resume before 4.15, we'll save that for a later patch. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Karol Herbst <kher...@redhat.com> Cc: Thomas

[PATCH v3] drm/nouveau: Move irq setup/teardown to pci ctor/dtor

, this probably means we can also just remove the msi rearm call inside nvkm_pci_init(). But since our main focus here is to fix suspend/resume before 4.15, we'll save that for a later patch. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Karol Herbst <kher...@redhat.com> Cc: Thomas

[RFC v3 0/4] Implement full clockgating for Kepler1 and 2

that these patches have a higher chance of crashing your card if you reclock under load. However, reclocking under load has never been supported by nouveau in the first place and has always caused trouble so that's nothing new :). Reclocking while not under load with powergating works A-OK. Lyude

[RFC v3 4/4] drm/nouveau: Add support for SLCG for Kepler2

before taking affect. As with the previous series, this results in another noticeable drop in power consumption and is programmed in the same manner. Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c | 93 ++ 1 file chang

[RFC v3 3/4] drm/nouveau: Add support for BLCG on Kepler2

Same as the previous patch, but for Kepler2 now Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c

[RFC v3 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 5 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 17 +-- drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild | 1 + drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c

[RFC v3 2/4] drm/nouveau: Add support for BLCG on Kepler1

the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 12 ++ drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/gr/g

[RFC v4 4/5] drm/nouveau: Add support for SLCG for Kepler2

before taking affect. As with the previous series, this results in another noticeable drop in power consumption and is programmed in the same manner. Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c | 93 ++ 1 file chang

[RFC 5/5] drm/nouveau: Introduce NvPmEnableGating option

that clockgating is enabled. Since clockgating has only had limited testing thus far, we leave this option disabled by default for now. Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[RFC v4 3/5] drm/nouveau: Add support for BLCG on Kepler2

Same as the previous patch, but for Kepler2 now Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk110.c

[RFC v4 2/5] drm/nouveau: Add support for BLCG on Kepler1

the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 12 ++ drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/gr/g

[RFC v4 0/5] Implement full clockgating for Kepler1 and 2

uce the NvPmEnableGating option Lyude Paul (5): drm/nouveau: Add support for basic clockgating on Kepler1 drm/nouveau: Add support for BLCG on Kepler1 drm/nouveau: Add support for BLCG on Kepler2 drm/nouveau: Add support for SLCG for Kepler2 drm/nouveau: Introduce NvPmEnableGating opt

[RFC v4 1/5] drm/nouveau: Add support for basic clockgating on Kepler1

for certain however, we at least add those into a new subdev/therm/gf100.h header. Signed-off-by: Lyude Paul <ly...@redhat.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 5 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 17 +-- drivers/gpu/drm/nouveau/nvkm/subdev/therm/

[RFC v5 2/5] drm/nouveau: Add support for BLCG on Kepler1

the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 12 ++ drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100

[RFC v5 3/5] drm/nouveau: Add support for BLCG on Kepler2

Same as the previous patch, but for Kepler2 now Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/

[RFC v5 1/5] drm/nouveau: Add support for basic clockgating on Kepler1

for certain however, we at least add those into a new subdev/therm/gf100.h header. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 5 + drivers/gpu/drm/nouveau/nvkm/engine/device/b

[RFC v5 0/5] Implement full clockgating for Kepler1 and 2

Next version of my patchseries for adding clockgating support for kepler1 and 2 on nouveau. The first version of this series can be found here: https://patchwork.freedesktop.org/series/36504/ One small change: - Add Martin's R-B, whoops Lyude Paul (5): drm/nouveau: Add support for basic

[RFC v5 5/5] drm/nouveau: Introduce NvPmEnableGating option

that clockgating is enabled. Since clockgating has only had limited testing thus far, we leave this option disabled by default for now. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 4

[RFC v5 4/5] drm/nouveau: Add support for SLCG for Kepler2

before taking affect. As with the previous series, this results in another noticeable drop in power consumption and is programmed in the same manner. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/

[RFC v6 3/5] drm/nouveau: Add support for BLCG on Kepler2

Same as the previous patch, but for Kepler2 now Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 8 +-- drivers/gpu/drm/

[RFC v6 2/5] drm/nouveau: Add support for BLCG on Kepler1

the clkgate_packs for kepler1 so that they share a list of mmio packs with Fermi. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 12 ++ drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100

[RFC v6 4/5] drm/nouveau: Add support for SLCG for Kepler2

before taking affect. As with the previous series, this results in another noticeable drop in power consumption and is programmed in the same manner. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/

[RFC v6 5/5] drm/nouveau: Introduce NvPmEnableGating option

that clockgating is enabled. Since clockgating has only had limited testing thus far, we leave this option disabled by default for now. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 4

[RFC v6 1/5] drm/nouveau: Add support for basic clockgating on Kepler1

for certain however, we at least add those into a new subdev/therm/gf100.h header. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- .../gpu/drm/nouveau/include/nvkm/subdev/therm.h| 5 + drivers/gpu/drm/nouveau/nvkm/engine/device/b

  1   2   3   4   5   6   7   8   9   10   >