[PATCH 1/1] drm/radeon: use kzalloc for allocating one thing

2015-06-19 Thread Maninder Singh
Use kzalloc for allocating one thing rather than kcalloc(1... The semantic patch that makes this change is as follows: // @@ @@ - kcalloc(1, + kzalloc( ...) // Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/gpu/drm/radeon/radeon_ttm.c |2 +- 1 files

[PATCH 1/1]drm/gma500: mdfld: Remove unncessary code

2015-06-24 Thread Maninder Singh
eck from __read_panel_data. Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma

[PATCH 1/1]drm/gma500: mdfld: Remove unncessary code

2015-06-24 Thread Maninder Singh
Hi, >> - if (!sender || !data_out || !len_out) { >> - DRM_ERROR("Invalid parameters\n"); >> - return -EINVAL; >> - } >> - > >I would prefer to have these kind of checks where it actually matters >(ie. in __read_panel_data()). The saner thing would be to

[PATCH v2] drm/gma500: mdfld: Remove unncessary check

2015-06-24 Thread Maninder Singh
rom mdfld_dsi_read_mcs and initializing dev struct after NULL check of sender. Suggested-by: Patrick Jakobsson Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- v1: removes check from __read_panel_data v2: remove check from mdfld_dsi_read_mcs instead of __read_panel_data drivers/

[PATCH 1/1] gpu/drm: use kzalloc for allocating one thing

2015-06-26 Thread Maninder Singh
Use kzalloc rather than kcalloc(1.. for allocating one thing. Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm

[PATCH 1/1] gpu/drm: remove unnecessary check before kfree

2015-06-26 Thread Maninder Singh
kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu

[PATCH 1/1] gpu/drm: remove unnecessary check before kfree

2015-06-26 Thread Maninder Singh
Hi, >The shortlog prefix of both your patches should be "drm/amdgpu:" instead >of "gpu/drm:". With that fixed, both are Do i need to send V2 of patch with that change or you have fixed that? >Reviewed-by: Michel Dänzer Thanks. ..

[PATCH v2] drm/amdgpu: remove unnecessary check before kfree

2015-06-26 Thread Maninder Singh
kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang Reviewed-by: Christian Konig --- v2: Chnged shortlog prefix - gpu/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH v2] drm/amdgpu: use kzalloc for allocating one thing

2015-06-26 Thread Maninder Singh
Use kzalloc rather than kcalloc(1.. for allocating one thing. Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang Reviewed-by: Christian Konig --- v2: Chnged shortlog prefix - gpu/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[RFC][PATCH 1/1] drm/amdkfd: Remove redundant pdd validation

2015-06-29 Thread Maninder Singh
pdd is already dereferenced before this check. So it is redundtant to validate pdd here. Signed-off-by: Maninder Singh --- drivers/gpu/drm/amd/amdkfd/kfd_process.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu

[PATCH v2] drm/amdkfd: validate pdd where it acquired first

2015-07-09 Thread Maninder Singh
Currently pdd is validate after dereferencing it, which is not correct, Thus validate pdd before its first use. Signed-off-by: Maninder Singh --- v1: remove validation of pdd after its usage v2: do validation at first place rather than removing drivers/gpu/drm/amd/amdkfd/kfd_process.c |9

[EDT][PATCh 1/1]mdfld_dsi_pkg_sender.c : Fix Possible NULL Pointer dereference

2015-05-19 Thread Maninder Singh
k of sender Signed-off-by: Maninder Singh Reviewed-By: Vaneet Narang --- drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c index