cleanups. The patches are based on top of current
exynos-drm-next branch.
Best regards
Marek Szyprowski
Samsung R Institute Poland
Patch summary:
Marek Szyprowski (17):
drm/exynos: rotator: convert to common clock framework
drm/exynos: exynos7-decon: remove excessive check
drm/exynos: move
Hello,
On 2015-11-18 16:40, Tobias Jakobi wrote:
> Marek Szyprowski wrote:
>> On 2015-11-17 19:00, Tobias Jakobi wrote:
>>> Marek Szyprowski wrote:
>>>> This patch adds common structure for keeping plane configuration and
>>>> capabilities data. This p
Hello,
On 2015-11-17 19:00, Tobias Jakobi wrote:
> Marek Szyprowski wrote:
>> This patch adds common structure for keeping plane configuration and
>> capabilities data. This patch is inspired by similar code developed by
>> Tobias Jakobi.
>>
>> Signed-off-by: Mare
Hello,
On 2015-11-12 15:46, Daniel Stone wrote:
> On 12 November 2015 at 12:44, Tobias Jakobi
> wrote:
>> Daniel Stone wrote:
>>> On 10 November 2015 at 13:23, Marek Szyprowski >> samsung.com> wrote:
>>>> This patch series introduces a new life i
This patch adds device node for Rotator device and it's SYSMMU to Exynos
542x device tree file.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5420.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts
This patch adds device node for Rotator device to Exynos 5250 device
tree file.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5250.dtsi | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 88b9cf5
Rotator device and it's SYSMMU belongs to different power domains
on various Exynos4 SoC revisions: LCD0 for 4210 and TOP for 4x12. This
patch fixes this by moving power-domains property to exynos4210.dtsi. TOP
power domain is always enabled and it is not represented in DTS.
Signed-off-by: Marek
This patch adds device node for Rotator device to Exynos 4210 and 4x12
device tree files.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi| 9 +
arch/arm/boot/dts/exynos4210.dtsi | 4
arch/arm/boot/dts/exynos4x12.dtsi | 4
3 files changed, 17 insertions
Hello,
On 2015-11-12 16:20, Tobias Jakobi wrote:
> Hello,
>
> Marek Szyprowski wrote:
>> From: Seung-Woo Kim
>>
>> NV12 and YUV420 formats are need to calculate offset of each plane
>> for ipp fimc in a gem buffer. Without proper offset, only Y plane
>>
Hello,
On 2015-11-13 03:29, Krzysztof Kozlowski wrote:
> On 10.11.2015 22:23, Marek Szyprowski wrote:
>> This patch adds device node for Rotator device to Exynos 4210 and 4x12
>> device tree files.
>>
>> Signed-off-by: Marek Szyprowski
>> ---
>>
Hello,
On 2015-11-13 03:23, Krzysztof Kozlowski wrote:
> On 10.11.2015 22:23, Marek Szyprowski wrote:
>> This patch adds device node for Rotator device to Exynos 4210 and 4x12
>> device tree files.
>>
>> Signed-off-by: Marek Szyprowski
>> ---
>>
This patch adds support for plane scaling. Minor changes were needed to
use existing Exynos IPP integration code for enabling scaling feature.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 8 +---
drivers/gpu/drm/exynos/exynos_drm_plane_ipp.c | 22
This patch adds generic plane rotation property for all supported
drivers. This has been implemented with additional help from Exynos IPP
(Exynos Image Post-Processing subsystem) with temporary framebuffers.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/Kconfig| 8
IPP framework stored global context in driver data of its platform device.
This patch moves it to global variable to simplify access. There exists
only one such framework, so there is no drawback of this change.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 50
Replace calls to exynos_drm_gem_get_{dma_addr,size}, by a simpler
function exynos_drm_gem_get(). This lets the caller to get access to
exynos_drm_gem object and extract any information about GEM object
without searching object tree for getting each parameter.
Signed-off-by: Marek Szyprowski
This patch removes old, unused function prototypes from exynos_drm_gem.h.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_gem.h | 28
1 file changed, 28 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h
b/drivers/gpu/drm
This patch forces all GEM buffers to have pitch aligned at least to 8
pixels. This is a common requirement for various Exynos IPP blocks,
which otherwise won't be able to operate on buffers of random size.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 2
Add framebuffer pointer to exynos_drm_plane_state and tell drivers to use
it. This lets common plane code to set temporary framebuffer in the
future and drivers will use it without additional changes.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2
This patch fixes trashed display of buffers cropped to very small width.
Even if DMA is unstable and causes tearing when changing the burst size,
it is still better than displaying a garbage.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24
This patch fixes calculation of src x/y offset for negative crtc x/y
values when scalling is enabled. This fixes possible IOMMU fault when
scalling is enabled.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 13 +++--
1 file changed, 7 insertions(+), 6
Common plane code already calculates and checks for supported scalling
modes, so additional code in mixer driver can be now removed.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++--
1 file changed, 3 insertions(+), 30 deletions
This patch adds generic check for plane state: pixel format and display
area dimensions, so drivers can always assume that they get valid plane
state to set.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 ++
drivers/gpu/drm/exynos/exynos_drm_plane.c | 51
This patch adds common structure for keeping plane configuration and
capabilities data. This patch is inspired by similar code developed by
Tobias Jakobi.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 18 +++---
drivers/gpu/drm/exynos
Video overlay plane should be registered only when suitable hardware
sub-block (Video Processor) is available.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu
This patch replaces usage of crtc->mode with crtc->state->adjusted_mode
like it is already done in common plane code.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_mixer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/d
This patch introduces exynos_drm_plane_state structure, which subclasses
drm_plane_state and holds precalculated data suitable for configuring
Exynos hardware.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 21 ++---
drivers/gpu/drm/exynos
DMA address is a framebuffer attribute and the right place for it is
exynos_drm_framebuffer not exynos_drm_plane. This patch also introduces
helper function for getting dma address of the given framebuffer.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 13
Display area is already checked by exynos plane core, so there is no
need for such check in driver code.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
b
This driver was not used after introduction of common clock framework.
This patch adds missing prepare/unprepare calls and allows to use it
again with current kernel code.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 ++--
1 file changed, 2 insertions
r NV12 and YUV420 formats.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 116
1 file changed, 116 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
YUV420 formats.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 106 +++
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 -
drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 +
3 files changed, 121 insertions
commit message, removed the need for wb-lcd property, because
all gscallers have support for lcd writeback, replaced dependency on
!ARCH_MULTIPLATFORM with !VIDEO_SAMSUNG_EXYNOS_GSC]
Signed-off-by: Marek Szyprowski
---
.../devicetree/bindings/media/exynos5-gsc.txt | 4 +++
drivers/gpu/drm
From: Seung-Woo Kim <sw0312@samsung.com>
At probe time, gsc clock is not enabled, so pm_runtime state should
be deactive. So this patch removes pm_runtime_set_active() from
gsc_probe().
Signed-off-by: Seung-Woo Kim
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/
From: Seung-Woo Kim <sw0312@samsung.com>
Ths patch changes the clk_enable and clk_disable call in gsc driver
into clk_prepare_enable and clk_disable_unprepare.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 4 ++--
1 file c
This patch adds device node for Rotator device to Exynos 542x device
tree file.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5420.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts/exynos5420.dtsi
This patch adds device node for Rotator device to Exynos 4210 and 4x12
device tree files.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi| 10 +-
arch/arm/boot/dts/exynos4210.dtsi | 8
arch/arm/boot/dts/exynos4x12.dtsi | 4
3 files changed, 21
properties
Patches have been prepared on top of linux-next from 10-11-2015. First
2 patches should be applied to Samsung SoC tree, all other should go
to Exynos DRM tree.
Best regards
Marek Szyprowski
Samsung R Institute Poland
Patch summary:
Marek Szyprowski (21):
ARM: dts: exynos4: add
109
>> #define CLK_SCLK_RGB_TV_VCLK 110
>>
>> -#define DISP_NR_CLK111
>> +#define CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY 111
>> +#define CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY
to dma_get_sgtable_attrs() and using the acquired scatter-list
to construct needed array. This approach is more portable (work also for
ARM64) and finally fixes the layering violation that was present in this
code.
Signed-off-by: Marek Szyprowski
---
Patch is based on exynos-drm-next branch.
v2: use
to dma_get_sgtable_attrs() and using the acquired scatter-list
to construct needed array. This approach is more portable (work also for
ARM64) and finally fixes the layering violation that was present in this
code.
Signed-off-by: Marek Szyprowski
---
Patch is based on exynos-drm-next branch
Exynos DRM reported that all planes for all supported sub-devices supports
only three pixel formats: XRGB24, ARGB24 and NV12. This patch lets each
Exynos DRM sub-drivers to provide the list of supported pixel formats
and registers this list to DRM core.
Signed-off-by: Marek Szyprowski
Hello,
On 2015-04-09 10:46, Marek Szyprowski wrote:
> Once pm_runtime_set_active() gets called, the kernel assumes that given
> device has already enabled runtime pm and will call pm_runtime_suspend()
> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
> this
hysical address. The actual physical address has to be
> derived
> from the EDID that is read by the HDMI transmitter.
>
> I think in the case of this driver it will have to be userspace that assigns
> the physical address after reading the EDID from drm/kms?
>
> How did you test this, Kamil?
If I remember correctly, physical address has been derived from EDID in the
userspace (it is available in /sys/class/drm/*) and passed to s5p-cec
driver by
appropriate ioctl.
I don't know what is the reason for the above 'adap->phys_addr = 0x100b'
assignment.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
have to use drm_iommu_attach_device_if_possible and then we can remove
> drm_iommu_attach_device_if_possible and clear_channels function pointer.
>
> Signed-off-by: Joonyoung Shim
Tested-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 +++--
Hello,
On 2015-07-02 14:49, Joonyoung Shim wrote:
> Already drm_iommu_attach_device and drm_iommu_detach_device check
> whether support iommu internally, so we don't have to call
> is_drm_iommu_supported before call them.
>
> Signed-off-by: Joonyoung Shim
Tested-by: M
MA_USE_IOMMU in is_drm_iommu_supported().
>
> Signed-off-by: Joonyoung Shim
Tested-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos_drm_iommu.h | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> b/drivers/gpu/drm/exyno
Some drivers (like Exynos mixer) calls drm_iommu_attach_device_if_possible
before registering crtc, so additional check for NULL crtc pointer is
required.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
tch removes this chained calls to enable plane from exynos hw
> drivers code letting only DRM core touch planes except to disable plane.
> Also it leads eliminable enabled and resume of struct exynos_drm_plane.
>
> Signed-off-by: Gustavo Padovan
> Signed-off-by: Joonyoung Shim
Tes
Hello,
On 2015-06-10 12:59, Inki Dae wrote:
> Hi Marek,
>
> On 2015ë
06ì 10ì¼ 19:03, Marek Szyprowski wrote:
>> Hello,
>>
>> On 2015-06-01 17:04, Gustavo Padovan wrote:
>>> From: Gustavo Padovan
>>>
>>> Hi,
>>>
>>> Her
an be observed with Exynos FIMD driver.
Gustavo: could you check if mixer_enable functions should really
call mixer_window_resume function, which in turn calls mixer_win_commit,
which calls mixer_graph_buffer with partially updated display buffer
data?
> (...)
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
the idea of moving pfn lookup from videobuf2/driver to some common
code in mm
and it is really great that someone managed to provide nice generic code
for it.
I've applied the whole patchset onto v4.0 and tested it on Odroid U3
(with some
additional patches). VideoBuf2-dc works still fine
d
from final buffer size calculation formula. This patch fixes this issue,
solving possible IOMMU page fault caused by FIMD module accessing memory
outside of the given display buffer.
Signed-off by: Marek Szyprowski
CC: stable at vger.kernel.org # v4.0+
---
drivers/gpu/drm/exynos/exynos_drm_fi
(). This patch removes call to pm_runtime_set_active() to
ensure that pm_runtime_suspend/resume calls will match.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm
le i.e.).
Add some basic checks to rule out those potential issues.
Signed-off-by: Beata Michalska
[mszyprow: rebased onto v4.0-rc1 and adapted to recent ipp changes]
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 44 +
1 file chang
Hello,
On 2015-02-11 12:12, Russell King - ARM Linux wrote:
> On Wed, Feb 11, 2015 at 09:28:37AM +0100, Marek Szyprowski wrote:
>> On 2015-01-27 09:25, Sumit Semwal wrote:
>>> Add some helpers to share the constraints of devices while attaching
>>> to the dmabuf buf
en from Rob Clark's RFC at
> https://lkml.org/lkml/2012/7/19/285, and the comments received on it.
>
> Cc: Rob Clark
> Signed-off-by: Sumit Semwal
The code looks okay, although it will probably will work well only with
typical
cases like 'contiguous memory needed' or 'no constraints
This patch adds entries for HDMI, Mixer and i2c with hdmi-phy modules
found in Exynos 4210 and 4x12 SoCs.
Signed-off-by: Marek Szyprowski
---
Resend reason: rebased onto latest kgene/v3.20-next/dt-samsung-4 branch
---
arch/arm/boot/dts/exynos4.dtsi| 40
Canillas
Tested-by: Javier Martinez Canillas
Signed-off-by: Marek Szyprowski
---
Documentation/devicetree/bindings/video/exynos_mixer.txt | 1 +
drivers/gpu/drm/exynos/exynos_mixer.c| 9 +
2 files changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings
From: Andrzej Hajda <a.ha...@samsung.com>
The patch adds domain definition and references to it in appropriate devices.
Signed-off-by: Andrzej Hajda
[mszyprow: rebased onto generic power domains dt bindings]
Signed-off-by: Marek Szyprowski
Tested-by: Javier Martinez Canillas
Re
Mixed block needs to control hdmi clock to properly perform power on/off
operation, so add 'hdmi' clock also to mixer nodes.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5250.dtsi | 5 +++--
arch/arm/boot/dts/exynos5420.dtsi | 5 +++--
2 files changed, 6 insertions(+), 4
From: Tomasz Stanislawski <t.stanisl...@samsung.com>
This patch adds configuration of hw modules required to enable HDMI
support on Universal C210 board.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4210-universal_c210.dt
This patch adds nodes specific to Exynos4412 based Odroid X/X2/U2/U3
boards required for enabling HDMI display.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 44 +
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts
TV Mixer needs both TV and LCD0 domains enabled to be fully operational.
This dependency is modelled by making TV power domains a sub-domain of
LCD0 power domain.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot
This patch adds entries for HDMI, Mixer and i2c with hdmi-phy modules
found in Exynos 4210 and 4x12 SoCs.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi| 40 +++
arch/arm/boot/dts/exynos4210.dtsi | 8
arch/arm/boot/dts
.
Signed-off-by: Marek Szyprowski
Reviewed-by: Ulf Hansson
---
.../bindings/arm/exynos/power_domain.txt | 2 ++
arch/arm/mach-exynos/pm_domains.c | 28 ++
2 files changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/exynos
This patch adds a note on defining subdomains to generic PM domain
binding documentation to let power domain providers use common approach
for defining power domain hierarchy.
Signed-off-by: Marek Szyprowski
Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>
Reviewed-by: Ulf H
/for-next branch and 'PM / Domains:
Export of_genpd_get_from_provider function' patch merged as commit
7496fcbe8a643097efc061160e1c3b65ee2fa350 to v3.19-rc4.
Regards
Marek Szyprowski
Changelog:
v5:
- fixed error value for clk_get() in mixer patch
- rebased onto samsung/for-next branch
v4: (http
Hello,
On 2015-01-22 14:00, Fabio Estevam wrote:
> On Tue, Jan 20, 2015 at 10:16 AM, Marek Szyprowski
> wrote:
>
>> + mixer_res->hdmi = devm_clk_get(dev, "hdmi");
>> + if (IS_ERR(mixer_res->hdmi)) {
>> +
ther the importer has constraints about
> maximum number of segments.
>
> Signed-off-by: Rob Clark
> [sumits: Minor updates wrt comments]
> Signed-off-by: Sumit Semwal
This feature is definitely needed to start thinking of real buffer
sharing between devices.
Acked-by: Marek S
Hello,
On 2015-01-23 00:19, Tobias Jakobi wrote:
> Marek Szyprowski wrote:
>> If system provides IOMMU feature, Exynos DRM should use it by default,
>> because the Exynos DRM subdrivers don't work correctly when Exynos IOMMU
>> driver has been enabled and no IOMMU supp
Hello,
On 2015-01-22 13:51, Javier Martinez Canillas wrote:
> Hello Marek,
>
> On 01/22/2015 01:41 PM, Marek Szyprowski wrote:
>>>>
>>>> + mixer_res->hdmi = devm_clk_get(dev, "hdmi");
>>> You need to update the
>>> Documentatio
Hello,
On 2015-01-20 13:52, Javier Martinez Canillas wrote:
> On 01/20/2015 01:16 PM, Marek Szyprowski wrote:
>> Mixed need to have hdmi clock enabled to properly perform power on/off
>> sequences, so add handling of this clock directly to the mixer driver.
>> Dependen
Mixed need to have hdmi clock enabled to properly perform power on/off
sequences, so add handling of this clock directly to the mixer driver.
Dependency between hdmi clock and mixer module has been observed on
Exynos4 based boards.
Suggested-by: Andrzej Hajda
Signed-off-by: Marek Szyprowski
If system provides IOMMU feature, Exynos DRM should use it by default,
because the Exynos DRM subdrivers don't work correctly when Exynos IOMMU
driver has been enabled and no IOMMU support has been compiled into Exynos
DRM driver.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos
Mixed need to have hdmi clock enabled to properly perform power on/off
sequences, so add handling of this clock directly to the mixer driver.
Dependency between hdmi clock and mixer module has been observed on
Exynos4 based boards.
Suggested-by: Andrzej Hajda
Signed-off-by: Marek Szyprowski
From: Andrzej Hajda <a.ha...@samsung.com>
The patch adds domain definition and references to it in appropriate devices.
Signed-off-by: Andrzej Hajda
[mszyprow: rebased onto generic power domains dt bindings]
Signed-off-by: Marek Szyprowski
Tested-by: Javier Martinez Canillas
Re
Mixed block needs to control hdmi clock to properly perform power on/off
operation, so add 'hdmi' clock also to mixer nodes.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5250.dtsi | 5 +++--
arch/arm/boot/dts/exynos5420.dtsi | 5 +++--
2 files changed, 6 insertions(+), 4
From: Tomasz Stanislawski <t.stanisl...@samsung.com>
This patch adds configuration of hw modules required to enable HDMI
support on Universal C210 board.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4210-universal_c210.dt
This patch adds nodes specific to Exynos4412 based Odroid X/X2/U2/U3
boards required for enabling HDMI display.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 44 +
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts
TV Mixer needs both TV and LCD0 domains enabled to be fully operational.
This dependency is modelled by making TV power domains a sub-domain of
LCD0 power domain.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot
This patch adds entries for HDMI, Mixer and i2c with hdmi-phy modules
found in Exynos 4210 and 4x12 SoCs.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi| 40 +++
arch/arm/boot/dts/exynos4210.dtsi | 8
arch/arm/boot/dts
.
Signed-off-by: Marek Szyprowski
Reviewed-by: Ulf Hansson
---
.../bindings/arm/exynos/power_domain.txt | 2 ++
arch/arm/mach-exynos/pm_domains.c | 28 ++
2 files changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/exynos
This patch adds a note on defining subdomains to generic PM domain
binding documentation to let power domain providers use common approach
for defining power domain hierarchy.
Signed-off-by: Marek Szyprowski
Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>
Reviewed-by: Ulf H
: set
parent of sclk_hdmiphy to hdmi') doesn't work in all cases. To finlly
solve the power on/off issues I've decided to simply add 'hdmi' clock
handling also to mixer module.
Regards
Marek Szyprowski
Changelog:
v4:
- added patches, which add 'hdmi' clock handling to mixed block, this
finally
Hello,
On 2014-08-12 15:00, Tomeu Vizoso wrote:
> On 1 July 2014 10:10, Marek Szyprowski wrote:
>> This is a long awaited patch series enabling support for HDMI output
>> available on Exynos4412-based Odroid boards (X/X2/U2/U3/U3+) and
>> Exynos4210 Universal C210 board.
>
Hello,
On 2014-07-01 19:54, Tobias Jakobi wrote:
> Marek Szyprowski wrote:
>> On 2014-07-01 10:52, Tobias Jakobi wrote:
>>> I think you had a similar patch in the tizen tree, but according to
>>> Tomasz Figa, it was considered a hack. I don't quite see how this is
w. Right now I have no better
idea.
Later, once the proper sequence is found we can remove those properties
from Odroid DTS.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
manages 'mout_hdmi/mixer'
clocks). If other solution is finally accepted, the code can be simplified
and mout_hdmi/mixer clocks simply ignored. For now - my changes are needed
to get HDMI output working and have least dependencies.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
From: Tomasz Stanislawski <t.stanisl...@samsung.com>
This patch adds configuration of hw modules required to enable HDMI
support on Universal C210 board.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4210-universal_c210.dt
This patch adds nodes specific to Exynos4412 based Odroid X/X2/U2/U3
boards required for enabling HDMI display.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 52 +
1 file changed, 52 insertions(+)
diff --git a/arch/arm/boot/dts
This patch adds entries for HDMI, Mixer and i2c with hdmi-phy modules
found in Exynos 4210 and 4x12 SoCs.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4.dtsi| 37 +
arch/arm/boot/dts/exynos4210.dtsi | 5 +
arch/arm/boot/dts/exynos4x12
This patch adds support for domain-always-on property to Exynos power
domain driver. Domains with this property as always kept enabled.
Signed-off-by: Marek Szyprowski
---
Documentation/devicetree/bindings/arm/exynos/power_domain.txt | 2 ++
arch/arm/mach-exynos/pm_domains.c
and samsung,exynos4210-hdmi. It also corrects
access to sclk_mixer clock, which is available only on Exynos 4210.
Signed-off-by: Marek Szyprowski
---
.../devicetree/bindings/video/exynos_mixer.txt | 5 ++-
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +
drivers/gpu/drm/exynos
(if available) on driver probe and keep it
enabled all the time to let TV-set correctly signal HPD event.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
This patch adds support for exporting mout_hdmi and mout_mixer to device
tree. Access to those clocks is required to correctly setup HDMI module
on Exynos 4210 and 4x12 SoCs.
Signed-off-by: Marek Szyprowski
CC: Mike Turquette
CC: Tomasz Figa
---
drivers/clk/samsung/clk-exynos4.c | 4
ied:
http://www.spinics.net/lists/linux-samsung-soc/msg33115.html
http://www.spinics.net/lists/linux-samsung-soc/msg33497.html
Kernel tree with all Odroid related patches is available at
http://git.linaro.org/git-ro/people/marek.szyprowski/linux-srpol.git
on v3.16-odroid branch.
Best regards
Marek Szypr
Hello,
On 2014-02-12 17:33, Russell King - ARM Linux wrote:
> On Wed, Feb 12, 2014 at 04:40:50PM +0100, Marek Szyprowski wrote:
> > Hello,
> >
> > On 2014-02-11 19:35, Russell King - ARM Linux wrote:
> >> The cubox-i4 just hit a new lockdep problem - no
e8ca2000 r6:e9902e00 r5:00b4 r4:e8ca3e38
> [] (drm_gem_dumb_destroy) from []
> (drm_mode_destroy_dumb_ioctl+0x34/0x40)
> [] (drm_mode_destroy_dumb_ioctl) from []
> (drm_ioctl+0x3f4/0x498)
> r4:e989e000 r3:c035e804
> [] (drm_ioctl) from [] (do_vfs_ioctl+0x84/0x664)
> r10: r9:e8ca2000 r8:beeb6bb4 r7:e9824560 r6:c01165d0 r5:0006
> r4:e9b97300
> [] (do_vfs_ioctl) from [] (SyS_ioctl+0x44/0x64)
> r10: r9:e8ca2000 r8:0006 r7:c00464b4 r6:beeb6bb4 r5:e9b97300
> r4:
> [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x48)
> r8:c000e8a4 r7:0036 r6:0006 r5:c00464b4 r4:beeb6bb4
>
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
avior.
>
>
> In case of ARM SoC, it seems like that it just ignores the attribute
> without iommu: in case of no iommu, dma_alloc_attr() always maps pages
> allocated from highmem with kernel space. So I think we make sure that
> exynos drm driver sets the attribute only with iommu to avoid such
> confusing. For this, will post it soon.
IMHO this case simply shows that ExynosDRM driver should manage IO address
space on it's own, because DMA-mapping api is too limited. ExynosDRM is
unlikely to be used on a hardware other than Samsung Exynos, so it can
better use hardware if it access IOMMU and CMA subsystems directly and
have its own address space manager to avoid hacking in internal structures
of dma-mapping.
Best regards
--
Marek Szyprowski
Samsung Poland R Center
is too limited. ExynosDRM is
unlikely to be used on a hardware other than Samsung Exynos, so it can
better use hardware if it access IOMMU and CMA subsystems directly and
have its own address space manager to avoid hacking in internal structures
of dma-mapping.
Best regards
--
Marek Szyprowski
Samsung
901 - 1000 of 1028 matches
Mail list logo
