[PATCH] drm/rockchip: cdn-dp: fix cdn-dp complie warning

fix warning: drivers/gpu/drm/rockchip/cdn-dp-reg.c:632:24: warning: 'val[1]' may be used uninitialized in this function [-Wmaybe-uninitialized] msa_misc = 2 * val[0] + 32 * val[1] + Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +-

Re: [GIT PULL] drm/rockchip: add cdn-dp support and some fixes

On 2017年02月07日 09:05, Dave Airlie wrote: On 5 February 2017 at 18:40, Mark yao <mark@rock-chips.com> wrote: Hi Dave drm/rockchip cdn-dp driver is v17 now, I think it's ready to land it. Thanks. The following changes since commit 99743ae4c5f52f8f8ceb17783056fcc9b4f8b64c: Merge

[PATCH 0/4] drm/rockchip: switch to drm_mm for support arm64 iommu

arm-kernel/msg513781.html [1]: https://patchwork.kernel.org/patch/9196367 [2]: https://patchwork.kernel.org/patch/9196369 Mark Yao (2): drm/rockchip: gem: add mutex lock for drm mm drm/rockchip: gem: fixup iommu_map_sg error path Shunqian Zheng (1): drm/rockchip: Use common IOMMU API to atta

[PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

ga <tf...@chromium.org> Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Acked-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 4 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 217 ++-- drivers/gpu/drm/roc

[PATCH 2/4] drm/rockchip: Use common IOMMU API to attach devices

gement, there is no need to use DMA API anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: Tomasz Figa <tf...@chromium.org> Acked-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/

[PATCH 4/4] drm/rockchip: gem: fixup iommu_map_sg error path

-Id: Id79c052691270553c1c60086f9926f39a5296354 Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_ge

[PATCH 3/4] drm/rockchip: gem: add mutex lock for drm mm

+0x24/0x28 Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 + 3 files chang

[PATCH v2 2/7] drm/rockchip: Use common IOMMU API to attach devices

gement, there is no need to use DMA API anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: Tomasz Figa <tf...@chromium.org> Acked-by: Mark Yao <mark@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-

[PATCH v2 1/7] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

ga <tf...@chromium.org> Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Acked-by: Mark Yao <mark@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 4 +- drivers/gpu/drm/roc

[PATCH v2 4/7] drm/rockchip: gem: fixup iommu_map_sg error path

-Id: Id79c052691270553c1c60086f9926f39a5296354 Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_ge

[PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

arm-kernel/msg513781.html [1]: https://patchwork.kernel.org/patch/9196367 [2]: https://patchwork.kernel.org/patch/9196369 Changes in v2: Advices by Tomasz: add some fixes patches from chromeos project. Mark Yao (2): drm/rockchip: gem: add mutex lock for drm mm drm/rockchip: gem: fixup io

[PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

+0x24/0x28 Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 + 3 files chang

[PATCH v2 5/7] drm/rockchip: Fix the call to drm_gem_put_pages()

ue; do backlight_dbus_tool --set --percent=0 && sleep 8 && backlight_dbus_tool --set --percent=100 && sleep 3 ; done Signed-off-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-on: https://chromium-review.googlesource.

Re: [PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

On 2017年02月07日 14:53, Tomasz Figa wrote: Hi Mark, Thanks for reviving this series and sorry for not taking care of it myself. Please see some comments inline. Hi Tomasz Thanks for review, I will add the patches you mentioned into v2 version. On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao

[PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base

Do not use DMA mapping API if attached to IOMMU domain") TEST=while true; do backlight_dbus_tool --set --percent=0 && sleep 8 && backlight_dbus_tool --set --percent=100 && sleep 3 ; done Signed-off-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Mark Ya

[PATCH v2 6/7] drm/rockchip: Respect page offset in IOMMU mmap

espect the offset. TEST=graphics_GLBench Signed-off-by: rjan Eide <orjan.e...@arm.com> Signed-off-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-on: https://chromium-review.googlesource.com/386477 Reviewed-by: Daniel Kurtz <djku...

Re: [PATCH v17 0/7] drm/rockchip: Add CDN DP driver

Hi Chris Applied to my drm-next and already sent pull request to Dave. Thanks. On 2017年02月05日 15:54, Chris Zhong wrote: This series adds support for the CDN DP controller to the rockchip drm driver. This version fixes some coding style error in v16, it post by Sean Paul, you can find it here:

Re: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function

e from rockchip_drm_mode_config_init, currently, they are both 4096. So you are right, drm driver does not distinguish between vop lit and big. I think Mark Yao already have a local solution, and he will post it soon. Hi See follow patches, support mode valid with vop callback. [0] https://patchwork.kernel.org

[GIT PULL] drm/rockchip: add cdn-dp support and some fixes

Hi Dave drm/rockchip cdn-dp driver is v17 now, I think it's ready to land it. Thanks. The following changes since commit 99743ae4c5f52f8f8ceb17783056fcc9b4f8b64c: Merge branch 'drm-etnaviv-next' of https://git.pengutronix.de/git/lst/linux into drm-next (2017-02-03 05:41:58 +1000) are

[PATCH 1/2] drm/rockchip: support mode_valid for crtc

drm crtc already has mode_fixup callback to can do mode check, but We actually want to valid display mode on connector getmode time, mode_fixup can't do it. So add a private mode_valid callback to rockchip crtc, connectors can check mode with this mode_valid callback. Signed-off-by: Mark Yao

[PATCH 2/2] drm/rockchip: dw_hdmi: check display mode with crtc mode valid

Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 47 +++-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm

On 2017年02月07日 20:19, Thierry Reding wrote: On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote: drm_mm_insert_node_generic and drm_mm_remove_node may access same resource with list ops, it's not threads safe, so protect this context with mutex lock. Fix bug: [49451.856244

Re: [PATCH 1/2] drm/rockchip: support mode_valid for crtc

On 2017年02月08日 00:14, Sean Paul wrote: On Sun, Feb 05, 2017 at 03:36:36PM +0800, Mark Yao wrote: drm crtc already has mode_fixup callback to can do mode check, but We actually want to valid display mode on connector getmode time, mode_fixup can't do it. So add a private mode_valid callback

Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

On 2017年02月07日 20:38, Thierry Reding wrote: On Tue, Feb 07, 2017 at 04:35:35PM +0800, Mark Yao wrote: Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] ready to landed, this series just r

Re: [PATCH v2 22/26] drm/rockchip: vop: test for P{H,V}SYNC

xcept mipi dsi connector, I think feed mipi's requirement would be better. So it's no problem on my side. Reviewed-by: Mark Yao <mark@rock-chips.com> VOP_CTRL_SET(vop, pin_pol, pin_pol); switch (s->output_type) { -- Ｍark Yao _

[GIT PULL] drm/rockchip: convert to drm_mm

Hi Dave After convert to drm_mm, rockchip arm64 platform can works with iommu, like rk3399. it's import patches for rockchip arm64 platform And these patches already have full reviewed, I hope these patches can be landed.   Best regards

[GIT PULL] drm/rockchip: some fixes

drm/rockchip: add extcon dependency for DP Christophe Jaillet (1): drm/rockchip: cdn-dp: Fix error handling Mark Yao (3): drm/rockchip: vop: no need wait vblank on crtc enable drm/rockchip: vop: verify display mode with vop max_output drm/rockchip: vop: verify

Re: [GIT PULL] drm/rockchip: some fixes

On 2017年02月24日 02:01, Sean Paul wrote: On Thu, Feb 23, 2017 at 10:03:23AM +0800, Mark yao wrote: On 2017年02月23日 00:09, Sean Paul wrote: On Tue, Feb 21, 2017 at 7:54 PM, Mark yao <mark@rock-chips.com> wrote: Hi Dave Some fixes, looks good to me. Hi Mark, As we discussed, ro

Re: [PATCH] drm/rockchip: cdn-dp: Fix error handling

On 2017年02月20日 14:41, Christophe JAILLET wrote: Le 20/02/2017 à 02:40, Mark yao a écrit : On 2017年02月20日 00:59, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> looks good for me Reviewed-by: Mark Yao <mark@rock-chips.com> --- V2: rename label add missing call to 'pm_runtime_put_sync()' in error path

Re: [PATCH] drm/rockchip: cdn-dp: Fix error handling

On 2017年02月20日 00:59, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support

[PATCH] drm/rockchip: vop: no need wait vblank on crtc enable

Since atomic framework, crtc enable and disable are in pairs, no need to wait vblank. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 - 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/ro

Re: [GIT PULL] drm/rockchip: some fixes

On 2017年02月23日 00:09, Sean Paul wrote: On Tue, Feb 21, 2017 at 7:54 PM, Mark yao <mark@rock-chips.com> wrote: Hi Dave Some fixes, looks good to me. Hi Mark, As we discussed, rockchip patches should now go through -misc. Since 4.10 is already released, I'll push these throug

Re: [PATCH] drm/rockchip: add extcon dependency for DP

On 2017年02月15日 05:31, Arnd Bergmann wrote: The newly added DP driver links against the extcon core, which fails when extcon is a module and this driver is not: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24):

[PATCH v3 1/2] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

ga <tf...@chromium.org> Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> Signed-off-by: rjan Eide <orjan.e...@arm.com> Tested-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.

[PATCH v3 0/2] drm/rockchip: switch to drm_mm for support arm64 iommu

Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] ready to landed, this series just rebase them to lastest drm-next. Thanks Heiko's Tested-by on rk3288 and rk3399 platform. Changes in v3: Advices by

[PATCH v3 2/2] drm/rockchip: Use common IOMMU API to attach devices

gement, there is no need to use DMA API anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Mark Yao <mark@rock-chips.com> Tested-by: Heiko Stuebner <he...@

Re: [01/26] drm/rockchip: dw-mipi-dsi: use mode from display state

On 2017年01月17日 18:38, Chris Zhong wrote: @@ -821,8 +824,6 @@ static void dw_mipi_dsi_encoder_mode_set(struct drm_encoder *encoder, struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder); int ret; -dsi->mode = adjusted_mode; - I prefer to keep the original method, although

[PATCH 2/3] drm: add ARM vendor format afbc

AFBC is arm vendor format, it's a compressed format. The AFBC format is supported by rk3399 vop big. We know little about AFBC layout, hope to some guys can fixme about the afbc comment. Signed-off-by: Mark Yao --- include/uapi/drm/drm_fourcc.h | 7 +++ 1 file changed, 7 insertions

[PATCH 1/3] drm/rockchip: vop: move dma_addr to plane atomic check

Calc dma_addr earlier, then the dma_addr can be used on crtc atomic check. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 52 - 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH 3/3] drm/rockchip: vop: support afdc for rk3399 vop

is a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 89 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h

[GIT PULL] drm/rockchip: some fixes

): drm/rockchip: Properly adjust to a true clock in adjusted_mode Mark Yao (1): drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 10 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: add missing header dependencies

On 2016年09月07日 18:53, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous > prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6:

[PATCH] drm/rockchip: mark symbols static where possible

On 2016年09月07日 19:01, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous > prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning:

[PATCH] drm/rockchip: vop: support afbc format for rk3399 vop

would die, we need take care of using it. AFBC is a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 89

[PATCH 3/3 v1.1] drm/rockchip: vop: support afbc format for rk3399 vop

would die, we need take care of using it. AFBC is a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- changes in v1.1 correct some comment. drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: vop: support afbc format for rk3399 vop

Sorry, wrong title on this mail, ignore this mail. I had resent it. On 2016年09月10日 11:07, Mark Yao wrote: > Rk3399 vop big can support one afbc decoder, the afbc decoder > can select which overlay window use it. > > on vop hardware, we call afbc decoder as afbdc. > > afb

[GIT PULL] drm/rockchip: some fixes

On 2016年09月13日 08:20, Dave Airlie wrote: > On 10 September 2016 at 12:57, Mark yao wrote: >> Hi Dave >> Here are some little fixes for rockchip drm, looks good for me, and >> there is no doubt on them, So I'd like you can land them. >> >> Thanks.

[PATCH 2/8] drm/rockchip: Get rid of some unnecessary code

ff-by: Tomasz Figa > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 -- > 1 file changed, 18 deletions(-) Hi Tomasz I think we can't get rid of the prepare_fb and cleanup_fb see the reason: commit 44d0237a26395ac94160cf23f32769013b365590 Author: Mark Yao Date:

[PATCH 2/8] drm/rockchip: Get rid of some unnecessary code

On 2016年09月18日 12:01, Tomasz Figa wrote: > Hi Mark, > > On Sun, Sep 18, 2016 at 10:50 AM, Mark yao wrote: >> On 2016年09月14日 20:54, Tomasz Figa wrote: >>> Current code implements prepare_fb and cleanup_fb callbacks only to >>> grab/release fb references

[PATCH] drm/bridge: analogix: protect power when get_modes or detect

0x44/0xdc [] drm_helper_probe_single_connector_modes_merge_bits+0xe8/0x41c [] drm_helper_probe_single_connector_modes+0x10/0x18 [] drm_mode_getconnector+0xf4/0x304 [] drm_ioctl+0x23c/0x390 [] do_vfs_ioctl+0x4b8/0x58c [] SyS_ioctl+0x60/0x88 Cc: Inki Dae Cc: Sean Paul Cc: Gustavo Padovan Cc: "Ville Syrjälä" Sign

Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

An HTML attachment was scrubbed... URL:

[PATCH v2] drm/bridge: analogix: protect power when get_modes or detect

0x44/0xdc [] drm_helper_probe_single_connector_modes_merge_bits+0xe8/0x41c [] drm_helper_probe_single_connector_modes+0x10/0x18 [] drm_mode_getconnector+0xf4/0x304 [] drm_ioctl+0x23c/0x390 [] do_vfs_ioctl+0x4b8/0x58c [] SyS_ioctl+0x60/0x88 Cc: Inki Dae Cc: Sean Paul Cc: Gustavo Padovan Cc: "Ville Syrjälä" Sign

Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

On 2016年10月12日 22:51, Sean Paul wrote: > On Wed, Oct 12, 2016 at 6:22 AM, Mark yao wrote: >> I'm not familiar with the analogix driver, maybe use a power reference count >> would better then direct power on/off analogix_dp. >> >> Does anyone has the idea to p

rockchip: drm: analogix_dp-rockchip would stock the kernel

On 2016年10月16日 02:03, ayaka wrote: > Hello: >I meet a problem with eDP in rk3288 with the linux next 20161006, > it is just like the early stage of 4.4 > kernel. I have added a eDP panel entry in the firefly reload board, > once the kernel loaded analogix_dp-rockchip.ko, after printed

About the Xserver for rockchip

On 2016年10月17日 15:12, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2016, 14:45:30 CEST schrieb Randy Li: >> Hello Tomasz: >>Heiko told me you are in charge of the graphics part of chromium, I >> think I had better told you the developing status of the xorg xserver in >> rockchip. >

[PATCH 2/2] drm/vc4: Add support for interlaced modes on HDMI.

On 2016年09月29日 10:20, Eric Anholt wrote: > We just needed to initialize a few more fields. > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 17 ++--- > drivers/gpu/drm/vc4/vc4_hdmi.c | 12 > drivers/gpu/drm/vc4/vc4_regs.h | 3 +++ > 3

Re: drm: rockchip: CONFIG_DRM_FBDEV_EMULATION will crash the HDMI down sometimes

static void vop_plane_atomic_update(struct drm_plane *plane, struct drm_plane_state *old_state) { if (WARN_ON(!vop->is_enabled)) return; The issues seems vop is not enable. but commit planes is using DRM_PLANE_COMMIT_ACTIVE_ONLY... Hi Randy Can you add some print for

Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs

On 2017年02月15日 04:32, Daniel Stone wrote: Hi John, On 14 February 2017 at 19:25, John Stultz wrote: +static enum drm_mode_status +drm_connector_check_crtc_modes(struct drm_connector *connector, +

Re: [PATCH v4 00/23] drm/rockchip: MIPI fixes & improvements

can't easily test it. It's on the list if anyone wants to pick it up in the future. Version 3 was posted here: http://www.spinics.net/lists/dri-devel/msg130977.html Thanks to Sean Paul and Chris Zhong for their review and testing of this series. Looks good to me. Acked-by: Mark Yao <m

Re: [GIT PULL] drm/rockchip: convert to drm_mm

On 2017年02月27日 04:45, Daniel Vetter wrote: On Thu, Feb 16, 2017 at 11:02:31AM +0800, Mark yao wrote: Hi Dave After convert to drm_mm, rockchip arm64 platform can works with iommu, like rk3399. it's import patches for rockchip arm64 platform And these patches already have full reviewed, I hope

[patch] drm/rockchip: inno_hdmi: fix an error code

On 2016年04月21日 22:03, Dan Carpenter wrote: > On Fri, Feb 26, 2016 at 02:26:23PM +0800, Yakir Yang wrote: >> Dan, >> >> On 02/26/2016 05:30 AM, Dan Carpenter wrote: >>> We were accidentally returning PTR_ERR(NULL) which means success when we >>> wanted to return a negative error code. >>> >>>

[PATCH v3] drm/rockchip: support non-iommu buffer path

Some rockchip vop not support iommu, need use non-iommu buffer for it. And if we get iommu issues, we can compare the issues with non-iommu path, the would help the debug. Signed-off-by: Mark Yao --- Changes in v3 - fix conflict with other iommu patch. Changes in v2 Advised by Heiko Stuebner

[PATCH] drm/rockchip: vop: fix iommu crash with async atomic

hardware. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 28596e7..38c4de9 100644 --- a/drivers/gpu/drm

[PATCH] drm/rockchip: vop: Initialize vskiplines to zero

There is a path that use vskiplines with non-initialize. That would cause vop abnormal behavior. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu

[PATCH v2] drm/rockchip: vop: fix iommu crash with async atomic

actually swap out from vop hardware. Signed-off-by: Mark Yao --- Changes in v2: - fix some format problem. drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

[1.172204] [] drm_kms_helper_hotplug_event+0x28/0x34 [1.172207] [] output_poll_execute+0x150/0x198 [1.172212] [] process_one_work+0x218/0x3dc [1.172215] [] worker_thread+0x24c/0x374 [1.172217] [] kthread+0xdc/0xe4 [1.17] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao

[PATCH] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

On 2016年08月03日 16:46, Daniel Vetter wrote: > On Wed, Aug 03, 2016 at 10:43:21AM +0200, Daniel Vetter wrote: >> On Wed, Aug 03, 2016 at 04:13:45PM +0800, Mark Yao wrote: >>> [1.162571] Unable to handle kernel NULL pointer dereference at virtual >>> address

[PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

Hi Yakir After apply your patch, I got following warning messge: drivers/gpu/drm/rockchip/inno_hdmi.c:818:2: warning: initialization from incompatible pointer type [enabled by default] drivers/gpu/drm/rockchip/inno_hdmi.c:818:2: warning: (near initialization for 'audio_codec_ops.hw_params')

[PATCH v1] drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION

[1.172204] [] drm_kms_helper_hotplug_event+0x28/0x34 [1.172207] [] output_poll_execute+0x150/0x198 [1.172212] [] process_one_work+0x218/0x3dc [1.172215] [] worker_thread+0x24c/0x374 [1.172217] [] kthread+0xdc/0xe4 [1.17] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao

[PATCH] drm/rockchip: Properly adjust to a true clock in adjusted_mode

On 2016年08月09日 03:29, Sean Paul wrote: > From: Douglas Anderson > > When fixing up the clock in vop_crtc_mode_fixup() we're not doing it > quite correctly. Specifically if we've got the true clock 26667 Hz, > we'll perform this calculation: > 26667 / 1000 => 26 > > Later

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

niel Vetter Cc: Fabio Estevam Cc: Liu Ying Signed-off-by: Mark Yao --- drivers/gpu/drm/bridge/dw-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 77ab473..a4fcb47 100644 --- a/drivers/gpu/drm/

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

An HTML attachment was scrubbed... URL:

[PATCH] drm/bridge: dw-hdmi: fix hdmi display lost

An HTML attachment was scrubbed... URL:

[v10.1 PATCH 5/5] drm/rockchip: cdn-dp: add cdn DP support for rk3399

dclk pin_pol of vop must not be invert for DP. > > Signed-off-by: Chris Zhong > Reviewed-by: Sean Paul > Acked-by: Mark Yao > > --- > > Changes in v10.1: > - support read sink count from DPCD > > Changes in v10: > - control the grf_clk in DP > > Ch

[PATCH 2/2] drm/rockchip: Use DRM_DEV_ERROR in vop

On 2016年08月13日 01:00, Sean Paul wrote: > Since we can have multiple vops, use DRM_DEV_ERROR to > make logs easier to process. > > Signed-off-by: Sean Paul looks good for me Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 ++---

[PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

Hi Sean Thanks for send v3 patch for rk3399 vop support. But sorry for that, I had changed my mind, those patches are deprecated, I have new rk3399 patch on my downstream kernel, I will upstream soon. Thanks. On 2016年08月18日 01:20, Sean Paul wrote: > From: Mark Yao > > No f

[PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

On 2016年08月18日 17:11, Daniel Vetter wrote: > On Thu, Aug 18, 2016 at 05:08:14PM +0800, Mark yao wrote: >> >Hi Sean >> > >> >Thanks for send v3 patch for rk3399 vop support. >> > >> >But sorry for that, I had changed my mind, those patches a

[PATCH] drm/rockchip: return ERR_PTR instead of NULL

On 2016年11月11日 05:10, Julia Lawall wrote: > rockchip_drm_framebuffer_init is only used in one case, in > rockchip_drm_fbdev.c, where its return value is tested using IS_ERR. To > enable propagating the reason for the error, change the definition so that > it returns an ERR_PTR value. > >

[RESEND PATCH 3/6] drm/rockchip: vop: add cdn DP support for rk3399

An HTML attachment was scrubbed... URL:

[PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support

les changed, 35 insertions(+), 3 deletions(-) > > Looks for me, So for the drm/rockchip side: Acked-by: Mark Yao Thanks. -- ï¼­ark Yao

[PATCH v2 02/10] drm/rockchip: analogix_dp: split the lcdc select setting into device data

for each chips. > > Signed-off-by: Yakir Yang Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode

e VOP output mode to RGA10 here. > > Signed-off-by: Yakir Yang Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc

tatic int rockchip_dp_bind(struct device *dev, struct > device *master, > dp->plat_data.subdev_type = dp_data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.mode_valid = rockchip_dp_mode_valid; > > return analogix_dp_bind(dev, dp->drm_dev, >plat_data); > } Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 06/10] drm/rockchip: analogix_dp: make panel detect to an optional action

On 2016年05月24日 13:02, Yakir Yang wrote: > Some boards don't need to declare a panel device node, like the > display interface is DP monitors, so it's necessary to make the > panel detect to an optional action. > > Signed-off-by: Yakir Yang > --- Looks for me, So: Acked-by

[PATCH] drm/rockchip: vop: do axi reset in vop initial time

On 2016年06月01日 17:19, Yakir Yang wrote: > There is a bug in RK3399 VOP, when bootloader/kernel only enable > VOP Big or VOP Little to display, then VOP IOMMU would failed to > reset at the initial time and VOP register couldn't write rightly. > > After do the pure reset of VOP module, then

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

On 2016年06月02日 13:57, Tomeu Vizoso wrote: > On 25 May 2016 at 03:33, Mark yao wrote: >> On 2016年05月25日 09:06, Mark yao wrote: >> >> On 2016年05月24日 18:11, Tomeu Vizoso wrote: >> >> Hi Tomeu >>> Sorry for reply late. >>> I do

[PATCH v2 1/5] drm/rockchip: sort registers define by chip's number

On 2016年06月02日 14:51, Tomasz Figa wrote: > Hi Mark, > > Mark Yao rock-chips.com> writes: >> No functional changes, sort the vop registers to make >> code more readable. > I might have found a typo. I guess it could be just fixed in this patch, > if it's

[PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP

On 2016年06月06日 15:58, Yakir Yang wrote: > The WIN0 of RK3036 VOP could support YUV data format, but driver > forget to add the uv_vir register field for it. > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) > > diff

[PATCH 2/2] drm/rockchip: vop: correct the source size of uv scale factor setting

On 2016年06月06日 15:58, Yakir Yang wrote: > From: Mark Yao > > When the input color format is YUV, we need to do some external scale > for CBCR. Like, > * In YUV420 data format: > cbcr_xscale = dst_w / src_w * 2; > cbcr_yscale = dst_h / src_h * 2; >

[PATCH 10/20] drm: rockchip: Rely on the default ->best_encoder() behavior

ncoder() for us. Good, All connectors and encoders is 1:1 relationship on rockchip outputs, so Acked-by: Mark Yao > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 9 - > drivers/gpu/drm/rockchip/inno_hdmi.c | 9 - >

[PATCH v3 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

Hi Yakir I'd like you can change your patch title into "drm/rockchip/hdmi", so when I search patches use "drm/rockchip" can find your patch. and I have some advices mail inline. Thanks:-) On 2016年01月15日 17:38, Yakir Yang wrote: > The Innosilicon HDMI is a low power HDMI 1.4 transmitter

[PATCH 3/3] drm/rockchip: explain why we can't wait_for_vblanks

On 2016年01月15日 00:26, John Keeping wrote: > On Thu, 14 Jan 2016 15:57:05 +0100, Thierry Reding wrote: > >> On Thu, Jan 14, 2016 at 02:39:42PM +, John Keeping wrote: >>> Signed-off-by: John Keeping >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 6 ++ >>> 1 file changed,

[PATCH v2 0/3] drm/rockchip: fix cursor performance with atomic

On 2016年01月19日 18:46, John Keeping wrote: > The first two patches are unchanged since v1 but the comment in the > third has been expanded following Thierry's comments. > > John Keeping (3): >drm/atomic-helper: Export framebuffer_changed() >drm/rockchip: don't wait for vblank if fb

[PATCH] drm/rockchip: fix wrong pitch/size using on gem

s 0x, then pitch < min_pitch return true, then gem will alloc very very big bufffer, it would eat all the memory and cause kernel crash. Stop using pitch/size from args, calc them from other args. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c |9 ++--- 1

[PATCH v2] drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION

On 2016年01月22日 02:19, John Keeping wrote: > If DRM_FBDEV_EMULATION is not selected in the config then we can save a > bit of space by not including the framebuffer code. > > Signed-off-by: John Keeping > --- > On Thu, 21 Jan 2016 17:52:51 +0100, Daniel Vetter wrote: > >> On Thu, Jan 21,

[GIT PULL] drm/rockchip: fixes

for vblank if fb hasn't changed drm/rockchip: explain why we can't wait_for_vblanks drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION Mark Yao (3): drm/rockchip: Don't build rockchip_drm_vop as modules drm/rockchip: cleanup unnecessary export symbol drm/rockchip: fix

[PATCH v7 0/2] Add Rockchip Inno-HDMI driver

On 2016年01月26日 10:59, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter >- Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec >- Digital video interface supports a pixel

[PATCH v8 2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform

An HTML attachment was scrubbed... URL:

[PATCH v5 7/8] drm/rockchip: Use common IOMMU API to attach devices

U address space > management, there is no need to use DMA API anymore and this patch wires > things to use the new method. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Tomasz Figa Looks good for me, and it works on rk3399 board, so Acked-by: Mark Yao > --- > drivers/gpu/d

  1   2   3   4   5   6   >