Re: [PATCH] drm/rockchip: gem: add the lacks lock and trivial changes

On 2017年05月31日 10:14, Caesar Wang wrote: As the allocation and free buffer that need to add mutex lock for drm mm, but it lacks the locking on error path in rockchip_gem_iommu_map(). Also, the trivial changes like The comment should be placed in the kerneldoc and unused blank line. Signed-off-b

[PATCH v2 0/4] Add RK3399 HDMI Support

on my test, so I remove them on this thread. Tested on rk3399 evb board with kernel 4.12.0-rc1. Changes in v2: rebase to newest uptream, reuse hdmi_phy_configure_dwc_hdmi_3d_tx Mark Yao (2): drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx drm/rockchip: dw_hdmi: add RK3399 HD

[PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx

So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx to configure their hardware. Signed-off-by: Mark Yao --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- include/drm/bridge/dw_hdmi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 2/4] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. base on Yakir Yang's rk3399 patch, rebase to newest upstrem kernel: https://patchwork.kernel.org/patch/9223323 Signed-off-by: Mark Yao Signed-off-by: Yakir Yang Changes in v2:

[PATCH v2 3/4] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

Yang Signed-off-by: Mark Yao Changes in v2: describe vpll on Documentation. --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 25 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 4/4] drm/rockchip: dw_hdmi: introduce the pclk for grf

For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao Changes in v2: descr

Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx

10:45, Mark Yao wrote: So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx to configure their hardware. Signed-off-by: Mark Yao --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- include/drm/bridge/dw_hdmi.h | 3 +++ 2 files changed, 5 insertions(+), 1

[PATCH 2/3] drm: add ARM vendor format afbc

AFBC is arm vendor format, it's a compressed format. The AFBC format is supported by rk3399 vop big. We know little about AFBC layout, hope to some guys can fixme about the afbc comment. Signed-off-by: Mark Yao --- include/uapi/drm/drm_fourcc.h | 7 +++ 1 file changed, 7 inser

[PATCH 1/3] drm/rockchip: vop: move dma_addr to plane atomic check

Calc dma_addr earlier, then the dma_addr can be used on crtc atomic check. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 52 - 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH 3/3] drm/rockchip: vop: support afdc for rk3399 vop

a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 89 + drivers/gpu/drm/rockchip/rockchip_drm_

[GIT PULL] drm/rockchip: some fixes

las Anderson (1): drm/rockchip: Properly adjust to a true clock in adjusted_mode Mark Yao (1): drm/rockchip: fix fbdev crash when not use DRM_FBDEV_EMULATION drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 10 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/g

[PATCH] drm/rockchip: add missing header dependencies

On 2016年09月07日 18:53, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous > prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warni

[PATCH] drm/rockchip: mark symbols static where possible

On 2016年09月07日 19:01, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous > prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning:

[PATCH] drm/rockchip: vop: support afbc format for rk3399 vop

would die, we need take care of using it. AFBC is a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH 3/3 v1.1] drm/rockchip: vop: support afbc format for rk3399 vop

would die, we need take care of using it. AFBC is a compressed format, means lower bandwidth consume, it's useful to improve performance. Signed-off-by: Mark Yao --- changes in v1.1 correct some comment. drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 6 ++ drivers/gpu/drm/roc

[PATCH] drm/rockchip: vop: support afbc format for rk3399 vop

Sorry, wrong title on this mail, ignore this mail. I had resent it. On 2016年09月10日 11:07, Mark Yao wrote: > Rk3399 vop big can support one afbc decoder, the afbc decoder > can select which overlay window use it. > > on vop hardware, we call afbc decoder as afbdc. > > afb

[GIT PULL] drm/rockchip: some fixes

On 2016年09月13日 08:20, Dave Airlie wrote: > On 10 September 2016 at 12:57, Mark yao wrote: >> Hi Dave >> Here are some little fixes for rockchip drm, looks good for me, and >> there is no doubt on them, So I'd like you can land them. >> >> Tha

[PATCH 2/8] drm/rockchip: Get rid of some unnecessary code

ned-off-by: Tomasz Figa > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 -- > 1 file changed, 18 deletions(-) Hi Tomasz I think we can't get rid of the prepare_fb and cleanup_fb see the reason: commit 44d0237a26395ac94160cf23f32769013b365590 Author: Mark

[PATCH 2/8] drm/rockchip: Get rid of some unnecessary code

On 2016年09月18日 12:01, Tomasz Figa wrote: > Hi Mark, > > On Sun, Sep 18, 2016 at 10:50 AM, Mark yao wrote: >> On 2016年09月14日 20:54, Tomasz Figa wrote: >>> Current code implements prepare_fb and cleanup_fb callbacks only to >>> grab/release fb references

[PATCH 2/2] drm/vc4: Add support for interlaced modes on HDMI.

On 2016年09月29日 10:20, Eric Anholt wrote: > We just needed to initialize a few more fields. > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 17 ++--- > drivers/gpu/drm/vc4/vc4_hdmi.c | 12 > drivers/gpu/drm/vc4/vc4_regs.h | 3 +++ > 3 fil

Re: drm: rockchip: CONFIG_DRM_FBDEV_EMULATION will crash the HDMI down sometimes

static void vop_plane_atomic_update(struct drm_plane *plane, struct drm_plane_state *old_state) { if (WARN_ON(!vop->is_enabled)) return; The issues seems vop is not enable. but commit planes is using DRM_PLANE_COMMIT_ACTIVE_ONLY... Hi Randy Can you add some print for this

Re: [01/26] drm/rockchip: dw-mipi-dsi: use mode from display state

On 2017年01月17日 18:38, Chris Zhong wrote: @@ -821,8 +824,6 @@ static void dw_mipi_dsi_encoder_mode_set(struct drm_encoder *encoder, struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder); int ret; -dsi->mode = adjusted_mode; - I prefer to keep the original method, although this"dsi->

Re: [PATCH v2 22/26] drm/rockchip: vop: test for P{H,V}SYNC

ept mipi dsi connector, I think feed mipi's requirement would be better. So it's no problem on my side. Reviewed-by: Mark Yao VOP_CTRL_SET(vop, pin_pol, pin_pol); switch (s->output_type) { -- Ｍark Yao ___ dri-devel mail

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event

On 2016年03月30日 21:48, Tomeu Vizoso wrote: > As per the docs, atomic_commit should return -EBUSY "if an asycnhronous > updated is requested and there is an earlier updated pending". > > Also wait for the pending event to complete when a sync update is > requested. > > Signed-off-by: Tomeu Vizo

[GIT PULL] drm/rockchip: some fixes

iplines to zero (2016-05-03 14:11:23 +0800) Dan Carpenter (1): drm/rockchip: inno_hdmi: fix an error code John Keeping (2): drm/rockchip: remove redundant statement drm/rockchip: don't leak iommu mapping Mark

[PATCH RESEND v3 1/2] drm: introduce bus_flags in drm_display_info

Hi Stefan Actually, the pixel clock or data enable polarity are also needed by drm/rockchip, but I have a question: why not add these polarity into drm_display_mode->flags. drm_display_mode->flags has hsync and vsync polarity, I think it's cool that add pixel clock or data enable polarity on

[PATCH 0/3] drm/rockchip: fix some sparse warnings

On 2016年05月11日 00:03, John Keeping wrote: > The first patch wasn't found by sparse, but is something I noticed while > in the area. The following two fix all of the sparse warnings inside > drm/rockchip. > > John Keeping (3): >drm/rockchip: dw_hdmi: remove unused #include >drm/rockch

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

On 2016年05月05日 17:34, Tomeu Vizoso wrote: > On 20 April 2016 at 16:23, Tomeu Vizoso wrote: >> On 11 April 2016 at 03:15, Mark yao wrote: >>> On 2016年04月08日 18:54, Tomeu Vizoso wrote: >>>> On 8 April 2016 at 03:07, Mark yao wrote: >>>>> O

[GIT PULL] drm/rockchip: new feature to support rk3399 vop and some fixes

trollers (2016-05-23 14:39:37 +0800) John Keeping (3): drm/rockchip: dw_hdmi: remove unused #include drm/rockchip: fb: add missing header drm/rockchip: fix "should it be static?" warnings Mark Y

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

An HTML attachment was scrubbed... URL:

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

An HTML attachment was scrubbed... URL:

[PATCH v8.1 1/2] drm/rockchip: hdmi: add Innosilicon HDMI support

On 2016年02月18日 05:00, Heiko Stuebner wrote: > Am Mittwoch, 3. Februar 2016, 17:44:57 schrieb Yakir Yang: >> The Innosilicon HDMI is a low power HDMI 1.4 transmitter >> IP, and it have been integrated on some rockchip CPUs >> (like RK3036, RK312x). >> >> Signed-off-by: Yakir Yang > On a Kylin

[GIT PULL] drm/rockchip: new feature to support inno hdmi

Hi Dave These patches based on drm-next, it looks good and Innosilicon HDMI works, so I'd like you can land them. Thanks. The following changes since commit 5443ce86fa37e7d3cc63d2067d05e3388fdeec17: drm: virtio-gpu: set atomic flag (2016-02-11 08:56:23 +1000) are available in the git repo

[PATCH v8 0/2] Add Rockchip Inno-HDMI driver

On 2016年01月29日 14:42, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter >- Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec >- Digital video interface supports a pixel siz

[PATCH v2 2/3] drm/rockchip: vop: add rk3229 vop support

On 2016年01月05日 11:58, Yakir Yang wrote: > RK3229 registers layout is simalar to RK3288 layout, only the > interruput registers is different to RK3288. > > RK3229 support two overlay plane and one hwc plane, max output > resolution is 4K. it support IOMMU, and its IOMMU same as rk3288's. > > S

[PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

On 2015年12月23日 11:43, Chris Zhong wrote: > +static int dw_mipi_dsi_register(struct drm_device *drm, > + struct dw_mipi_dsi *dsi) > +{ > + struct drm_encoder *encoder = &dsi->encoder; > + struct drm_connector *connector = &dsi->connector; > + struc

[PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

On 2015年12月23日 11:43, Chris Zhong wrote: > @@ -34,3 +34,13 @@ config ROCKCHIP_ANALOGIX_DP > This selects support for Rockchip SoC specific extensions > for the Analogix Core DP driver. If you want to enable DP > on RK3288 based SoC, you should selet this option. > + >

[PATCH v7 3/5] drm: rockchip: Support Synopsys DW MIPI DSI

Hi Chris Looks good for me except some tiny issues. On 2016年01月06日 12:03, Chris Zhong wrote: > +struct dw_mipi_dsi { > + struct drm_encoder encoder; > + struct drm_connector connector; > + struct mipi_dsi_host dsi_host; > + struct drm_panel *panel; > + struct device *de

[GIT PULL] drm/rockchip: new features to support Synopsys DW MIPI DSI

Hi Dave Now seems there is no doubt on these patches, Documentation is Acked-by Rob Herring, and it looks good for me. So I'd like you can land them. The following changes since commit c11b8989635166c5a1e6aac1853a847bd664f8db: Merge tag 'omapdrm-4.5-resolved' of git://git.kernel.org/pub/sc

[PATCH v7 0/5] Add mipi dsi support for rk3288

On 2016年01月06日 12:03, Chris Zhong wrote: > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > controller DRM driver. > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > chrome os

[PATCH] drm/rockchip: vop: fix mask when updating interrupts

On 2016年01月13日 02:05, John Keeping wrote: > Commit dbb3d94 (drm/rockchip: vop: move interrupt registers into > vop_data) introduced new macros for updating the interrupt control > registers but these always use the mask from the register definition > without refining it for the particular bit

[PATCH 1/2] drm/rockchip: Don't build rockchip_drm_vop as modules

rockchip_drm_vop's module init had moved to rockchip_vop_reg.c so no need to build rockchip_drm_vop.ko Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/Makefile |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gp

[PATCH 0/2] drm/rockchip: cleanup unnecessary modules and symbol

eeded: rockchip_drm_dma_attach_device rockchip_drm_dma_detach_device rockchip_drm_dma_attach_device rockchip_drm_dma_detach_device rockchip_register_crtc_funcs rockchip_unregister_crtc_funcs rockchip_fb_get_gem_obj Mark Yao (2): drm/rockchip: Don't build rockchip_drm_vop as mod

[PATCH 2/2] drm/rockchip: cleanup unnecessary export symbol

rockchip_unregister_crtc_funcs rockchip_fb_get_gem_obj Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c |4 drivers/gpu/drm/rockchip/rockchip_drm_fb.c |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip

[RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed

On 2016年01月14日 01:39, John Keeping wrote: > On Wed, 13 Jan 2016 18:19:17 +0100, Daniel Vetter wrote: > >> On Wed, Jan 13, 2016 at 04:40:38PM +, John Keeping wrote: >>> On Wed, 13 Jan 2016 17:21:56 +0100, Daniel Vetter wrote: >>> On Wed, Jan 13, 2016 at 03:55:29PM +, John Keep

[RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed

On 2016年01月14日 16:32, Daniel Vetter wrote: > On Thu, Jan 14, 2016 at 2:16 AM, Mark yao wrote: >> On 2016年01月14日 01:39, John Keeping wrote: >>> On Wed, 13 Jan 2016 18:19:17 +0100, Daniel Vetter wrote: >>> >>>> On Wed, Jan 13, 2016 at 04:40:38PM

[PATCH] drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result

On 2016年01月14日 16:59, Andrzej Hajda wrote: > The function can return negative value so it should be assigned to signed > variable. > > The problem has been detected using patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/

[PATCH v3 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support

Hi Yakir I'd like you can change your patch title into "drm/rockchip/hdmi", so when I search patches use "drm/rockchip" can find your patch. and I have some advices mail inline. Thanks:-) On 2016年01月15日 17:38, Yakir Yang wrote: > The Innosilicon HDMI is a low power HDMI 1.4 transmitter >

[RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

On 2015年10月19日 23:07, Liviu Dudau wrote: > A lot of component based DRM drivers use a variant of the same code > as the probe function. They bind the crtc ports in the first iteration > and then scan through the child nodes and bind the encoders attached > to the remote endpoints. Factor the

[RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

On 2015年11月10日 03:49, Heiko Stuebner wrote: > Hi Liviu, > > Am Montag, 9. November 2015, 12:07:20 schrieb Liviu Dudau: >> On Mon, Nov 09, 2015 at 12:03:35PM +, Russell King - ARM Linux wrote: >>> On Mon, Nov 09, 2015 at 11:57:27AM +, Liviu Dudau wrote: Meanwhile, what is your sug

[PATCH 2/2] drm/rockchip: unset pgoff when mmap'ing gems

bj()/drm_gem_mmap(). >*/ > vma->vm_flags &= ~VM_PFNMAP; > + vma->vm_pgoff = 0; > > ret = dma_mmap_attrs(drm->dev, vma, rk_obj->kvaddr, rk_obj->dma_addr, > obj->size, &rk_obj->dma_attrs); Hi Heiko Sorry for miss this patch, thanks for the fix. Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

Hi Heiko I don't think this patch is needed for rockchip drm, since rockchip drm only use kms. I saw the discussion about ("drm/exynos: create a fake mmap offset with gem creation"), Inki said that: "This patch makes drm_gem_create_mmap_offset to be called even in case of not using dumb* i

[PATCH] Revert "drm/rockchip: Convert the probe function to the generic drm_of_component_probe()"

This reverts commit 52f5eb60940de889ce98a876f6933b574ead3225. Rockchip drm can't work with generic drm_of_component_probe now Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +-- 1 file changed, 75 insertions(+), 6 deletions(-) diff

[RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

On 2015年11月09日 19:57, Liviu Dudau wrote: > Meanwhile, what is your suggestion regarding the patchset. I've seen David has > sent Linus a pull request for 4.4-rc1 that includes it. Should we send a > revert for rockchip commit and then patch later the function? Hi Liviu I had sent a patch

[RESEND PATCH] drm/rockchip: import dma_buf to gem

We want to display a buffer allocated by other driver, need import the buffer to gem. Signed-off-by: Mark Yao --- Changes in resend: - rebase to this patch to newest origin/drm-next 4.3-rc5 Changes in v2: Adviced by Russell King - check sgt-nents == 1 when get iova from scatterlist - remove

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

On 2015年11月10日 14:46, Heiko Stuebner wrote: > Hi Mark, > > Am Dienstag, 10. November 2015, 14:17:43 schrieb Mark yao: >> Hi Heiko >>I don't think this patch is needed for rockchip drm, since >> rockchip drm only use kms. >> I saw the discussion

[PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation

On 2015年11月10日 17:28, Heiko Stuebner wrote: > Am Dienstag, 10. November 2015, 17:26:10 schrieb Mark yao: >> On 2015年11月10日 14:46, Heiko Stuebner wrote: >>> Hi Mark, >>> >>> Am Dienstag, 10. November 2015, 14:17:43 schrieb Mark yao: >>>> H

[PATCH] drm/rockchip: vop: fix window origin calculation

From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] drm/rockchip: vop: fix window origin calculation

On 2015年11月10日 22:57, Heiko Stuebner wrote: > Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: >> From: Dominik Behr >> >> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to >> it. It actually causes the screen to be shifted by one

[GIT PULL] drm/rockchip: fixes

(1): drm/rockchip: vop: fix window origin calculation Heiko Stuebner (1): drm/rockchip: unset pgoff when mmap'ing gems Mark Yao (1): Revert "drm/rockchip: Convert the probe function to the generic drm_of_component_probe()" Sjoerd Simons (1): drm/rockc

drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

On 2015年11月11日 00:56, Thierry Reding wrote: > On Tue, Nov 10, 2015 at 03:01:03PM +, Liviu Dudau wrote: >> Hello, >> >> When booting my Juno board with the HDLCD driver that I have converted to >> atomic operations I'm getting the following warning: > Perhaps you can provide pointers to th

drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

On 2015年11月12日 14:27, Mark yao wrote: > On 2015年11月11日 00:56, Thierry Reding wrote: >> On Tue, Nov 10, 2015 at 03:01:03PM +, Liviu Dudau wrote: >>> Hello, >>> >>> When booting my Juno board with the HDLCD driver that I have converted to &

drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

On 2015年11月10日 23:01, Liviu Dudau wrote: > Hello, > > When booting my Juno board with the HDLCD driver that I have converted to > atomic operations I'm getting the following warning: > > [ cut here ] > WARNING: at /work/repositories/kernel/drivers/gpu/drm/drm_atomic_he

[PATCH] drm/rockchip: vop: do axi reset in vop initial time

On 2016年06月01日 17:19, Yakir Yang wrote: > There is a bug in RK3399 VOP, when bootloader/kernel only enable > VOP Big or VOP Little to display, then VOP IOMMU would failed to > reset at the initial time and VOP register couldn't write rightly. > > After do the pure reset of VOP module, then th

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

On 2016年06月02日 13:57, Tomeu Vizoso wrote: > On 25 May 2016 at 03:33, Mark yao wrote: >> On 2016年05月25日 09:06, Mark yao wrote: >> >> On 2016年05月24日 18:11, Tomeu Vizoso wrote: >> >> Hi Tomeu >>> Sorry for reply late. >>> I do

[PATCH v2 1/5] drm/rockchip: sort registers define by chip's number

On 2016年06月02日 14:51, Tomasz Figa wrote: > Hi Mark, > > Mark Yao rock-chips.com> writes: >> No functional changes, sort the vop registers to make >> code more readable. > I might have found a typo. I guess it could be just fixed in this patch, > if it&#x

[PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP

On 2016年06月06日 15:58, Yakir Yang wrote: > The WIN0 of RK3036 VOP could support YUV data format, but driver > forget to add the uv_vir register field for it. > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) > > diff -

[PATCH 2/2] drm/rockchip: vop: correct the source size of uv scale factor setting

On 2016年06月06日 15:58, Yakir Yang wrote: > From: Mark Yao > > When the input color format is YUV, we need to do some external scale > for CBCR. Like, > * In YUV420 data format: > cbcr_xscale = dst_w / src_w * 2; > cbcr_yscale = dst_h / src_h * 2; >

[PATCH 10/20] drm: rockchip: Rely on the default ->best_encoder() behavior

ncoder() for us. Good, All connectors and encoders is 1:1 relationship on rockchip outputs, so Acked-by: Mark Yao > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 9 - > drivers/gpu/drm/rockchip/inno_hdmi.c | 9 - >

[PATCH 3/3] drm/rockchip: explain why we can't wait_for_vblanks

On 2016年01月15日 00:26, John Keeping wrote: > On Thu, 14 Jan 2016 15:57:05 +0100, Thierry Reding wrote: > >> On Thu, Jan 14, 2016 at 02:39:42PM +, John Keeping wrote: >>> Signed-off-by: John Keeping >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 6 ++ >>> 1 file changed, 6

[PATCH v2 0/3] drm/rockchip: fix cursor performance with atomic

On 2016年01月19日 18:46, John Keeping wrote: > The first two patches are unchanged since v1 but the comment in the > third has been expanded following Thierry's comments. > > John Keeping (3): >drm/atomic-helper: Export framebuffer_changed() >drm/rockchip: don't wait for vblank if fb has

[PATCH] drm/rockchip: fix wrong pitch/size using on gem

ch is 0x, then pitch < min_pitch return true, then gem will alloc very very big bufffer, it would eat all the memory and cause kernel crash. Stop using pitch/size from args, calc them from other args. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c |9 ++-

[PATCH v2] drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION

On 2016年01月22日 02:19, John Keeping wrote: > If DRM_FBDEV_EMULATION is not selected in the config then we can save a > bit of space by not including the framebuffer code. > > Signed-off-by: John Keeping > --- > On Thu, 21 Jan 2016 17:52:51 +0100, Daniel Vetter wrote: > >> On Thu, Jan 21, 2016

[GIT PULL] drm/rockchip: fixes

hip: don't wait for vblank if fb hasn't changed drm/rockchip: explain why we can't wait_for_vblanks drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION Mark Yao (3): drm/rockchip: Don't build rockchip_drm_vop as modules drm/rockchip: cleanup unnecessary exp

[PATCH v7 0/2] Add Rockchip Inno-HDMI driver

On 2016年01月26日 10:59, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter >- Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec >- Digital video interface supports a pixel siz

[PATCH v8 2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform

An HTML attachment was scrubbed... URL:

[PATCH v5 7/8] drm/rockchip: Use common IOMMU API to attach devices

U address space > management, there is no need to use DMA API anymore and this patch wires > things to use the new method. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Tomasz Figa Looks good for me, and it works on rk3399 board, so Acked-by: Mark Yao > --- > drivers/gpu/d

[PATCH v5 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

eavily on GEM > implementation of Tegra DRM driver. Acked-by: Mark Yao > > Signed-off-by: Tomasz Figa > Signed-off-by: Shunqian Zheng > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 221 > +++

iommu/rockchip: Fix bugs and enable on ARM64

On 2016年06月27日 20:57, Joerg Roedel wrote: > On Fri, Jun 24, 2016 at 10:13:25AM +0800, Shunqian Zheng wrote: >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++-- >> drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + >> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 221 >>

[PATCH 5/7] drm/rockchip: dw-mipi: support HPD poll

On 2016年07月08日 21:52, John Keeping wrote: > On Fri, 8 Jul 2016 17:04:59 +0800, Chris Zhong wrote: > >> At the first time of bind, there is no any panel attach in mipi. Add a >> DRM_CONNECTOR_POLL_HPD porperty to detect the panel status, when panel >> probe, the dw_mipi_dsi_host_attach would

[patch] drm/rockchip: fix a couple off by one bugs

On 2016年07月13日 18:15, Dan Carpenter wrote: > The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should > be >= here. > > Fixes: 2048e3286f34 ('drm: rockchip: Add basic drm driver') > Signed-off-by: Dan Carpenter Thanks for the fix, applied to my drm-fixes. > diff --git a/driv

[PATCH 0/6] drm/rockchip: some fixes

: remove unused #include drm/rockchip: fb: add missing header drm/rockchip: fix "should it be static?" warnings Mark Yao (2): drm/rockchip: vop: correct the source size of uv scale factor setting drm/rockchip: vop: correct rk3036 register define Yakir Yang (1): drm/rockchip: vop:

[PATCH 1/6] drm/rockchip: dw_hdmi: remove unused #include

From: John Keeping drm_encoder_slave is not used in this file. Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip

[PATCH 2/6] drm/rockchip: fb: add missing header

ramebuffer_init' was not declared. Should it be static? drivers/gpu/drm/rockchip/rockchip_drm_fb.c:329:6: warning: symbol 'rockchip_drm_mode_config_init' was not declared. Should it be static? Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_

[PATCH 3/6] drm/rockchip: fix "should it be static?" warnings

From: John Keeping Combined with the previous commit, this fixes all of the sparse warnings in drm/rockchip. Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- drivers/gpu/drm

[PATCH 4/6] drm/rockchip: vop: add uv_vir register field for RK3036 VOP

From: Yakir Yang The WIN0 of RK3036 VOP could support YUV data format, but driver forget to add the uv_vir register field for it. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu

[PATCH 5/6] drm/rockchip: vop: correct the source size of uv scale factor setting

data format cbcr_xscale = dst_w / src_w; cbcr_yscale = dst_h / src_h; Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH 6/6] drm/rockchip: vop: correct rk3036 register define

Signed-off-by: Mark Yao Reported-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c index a348a7a..919992c 100644 --- a

[PATCH] drm/rockchip: allocate correct crtc state structure on reset

On 2016年07月14日 23:29, John Keeping wrote: > Because we are using a custom crtc_state structure, we must override the > reset helper to allocate the correct amount of memory. > > Cc: stable at vger.kernel.org > Fixes: 4e257d9eee23 ("drm/rockchip: get rid of rockchip_drm_crtc_mode_config") > Si

[PATCH] drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

On 2016年07月15日 21:35, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 15 Jul 2016 15:23:22 +0200 > > The drm_gem_object_unreference_unlocked() function tests whether > its argument is NULL and then returns immediately. > Thus the test around the call is not needed. > > This issu

[GIT PULL] drm/rockchip: some fixes

missing header drm/rockchip: fix "should it be static?" warnings drm/rockchip: allocate correct crtc state structure on reset Mark Yao (2): drm/rockchip: vop: correct the source size of uv scale factor setting drm/rockchip: vop: correct rk3036 register

[PATCH 2/2] dt-bindings: add simple-panel-dsi and simple-panel

Allow user add display timing on device tree with simple-panel-dsi or simple-panel. Cc: Thierry Reding Cc: Rob Herring Cc: Mark Rutland Signed-off-by: Mark Yao --- .../bindings/display/panel/simple-panel.txt| 48 ++ 1 file changed, 48 insertions(+) diff --git a

[PATCH 1/2] drm/panel: add of display timing support

from device node. Cc: Thierry Reding Signed-off-by: Mark Yao --- drivers/gpu/drm/panel/panel-simple.c | 73 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85

[v6 PATCH 6/6] drm/rockchip: cdn-dp: add cdn DP support for rk3399

hong > Reviewed-by: Sean Paul Sean Paul already do a good review, I think it's ready to be merged, so Acked-by: Mark Yao > --- > > Changes in v6: > - add a port struct > - select SND_SOC_HDMI_CODEC > - force reset the phy when hpd detected > > Changes in

[PATCH 2/2] dt-bindings: add simple-panel-dsi and simple-panel

An HTML attachment was scrubbed... URL:

[PATCH 1/3] drm: introduce share plane

has same shard id, so userspace can group them, judge share plane's limit. Signed-off-by: Mark Yao --- drivers/gpu/drm/drm_crtc.c | 110 drivers/gpu/drm/drm_ioctl.c | 5 ++ include/drm/drmP.h | 5 ++ include/drm/drm_crtc.h

[PATCH 3/3] drm/rockchip: vop: rk3288: add area plane

Change-Id: Iac8fde019020d8f1a671d52c1a4d91ad2d050d43 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 52 - 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip

[PATCH 2/3] drm/rockchip: vop: support multi area plane

The series vop of VOP_FULL framework support area plane, such as RK3288 and RK3399, one group of area planes share same hardware, reuse the hardware on different scanout time, this design is useful to support mulit planes with low hardware consume. Signed-off-by: Mark Yao --- drivers/gpu/drm

[PATCH 1/3] drm: introduce share plane

On 2016年07月26日 16:26, Daniel Vetter wrote: > On Tue, Jul 26, 2016 at 03:46:32PM +0800, Mark Yao wrote: >> >What is share plane: >> >Plane hardware only be used when the display scanout run into plane active >> >scanout, that means we can reuse the plane hardw

[PATCH 6/9] drm/rockchip: Use drm_plane_state.{src,dst}

Syrjälä Good cleanup, Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

<    1   2   3   4   5   6   >