[PATCH v2 2/5] drm/rockchip: vop: support verify registers with vop version

Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 66 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 18 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 20 ++--- 3 files changed, 77 insertions(

[PATCH v3 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Changes in v3: - Explain more in details Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++- drivers/gpu/drm/ro

[PATCH v3 0/7] drm/rockchip: add all full framework vop support

abnormal Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Mark Yao (7): drm/rockchip: vop: initialize registers directly drm/rockchip: vop: move write_relaxed flags to vop register drm/rockchip: vop: move line_flag_num to interrupt registers drm

[PATCH v3 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +- drivers/g

[PATCH v3 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

this patch Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 3 files changed,

[PATCH v3 5/7] drm/rockchip: vop: add a series of vop support

then old one. Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v3 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/g

[PATCH v3 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 - 2

[PATCH v3 6/7] dt-bindings: display: fill Documents for series of vop

Changes in v2: - rename rk322x to rk3228(Heiko Stübner) Signed-off-by: Mark Yao <mark@rock-chips.com> --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/ro

Re: [PATCH v2 1/5] drm/rockchip: vop: get rid of register init table

On 2017年07月14日 04:29, Sean Paul wrote: On Thu, Jul 13, 2017 at 09:33:45AM +0800, Mark yao wrote: On 2017年07月13日 00:47, Sean Paul wrote: On Wed, Jul 12, 2017 at 10:03:27AM +0800, Mark Yao wrote: Register init table use un-document define, it is unreadable, And sometimes we only want to update

Re: [PATCH v4 0/7] drm/rockchip: add all full framework vop support

Sorry for sending this mail without thread, my send-patches scripts has a bug:-( , Already fix the script bug. On 2017年07月19日 10:57, Mark Yao wrote: These patches try to make all current rockchip full framework vop works on drm, fill missing vop on full framework. Vop Full framework now has

[PATCH v4 0/7] drm/rockchip: add all full framework vop support

registers - Explain more on patch commit message - fix rk3328 overlay abnormal Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Mark Yao (7): drm/rockchip: vop: initialize registers directly drm/rockchip: vop: move write_relaxed flags to vop register drm

[PATCH v4 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 - 2

[PATCH v4 6/7] dt-bindings: display: fill Documents for series of vop

Changes in v2: - rename rk322x to rk3228(Heiko Stübner) Signed-off-by: Mark Yao <mark@rock-chips.com> --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/ro

[PATCH v4 5/7] drm/rockchip: vop: add a series of vop support

then old one. Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v4 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Changes in v3: - Explain more in details Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++- drivers/gpu/drm/ro

[PATCH v4 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +- drivers/g

[PATCH v4 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/g

[PATCH v4 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

this patch Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 3 files changed,

Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies

On 2017年07月22日 05:12, Arnd Bergmann wrote: A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, the rockchip drm driver will fail to link: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined

Re: [PATCH v5 6/7] dt-bindings: display: rockchip: fill Documents for vop series

On 2017年07月25日 03:53, Rob Herring wrote: On Thu, Jul 20, 2017 at 10:43:53AM +0800, Mark Yao wrote: Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v5: - clean document commit title - move changes description out of docummit commit msg Changes in v2: - rename rk322x to

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers facilitates make register definition clearer, and also

[PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6.1 - fix Null p

Re: [PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

On 2017年07月26日 05:47, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao: Since the drm atomic framework, only a small part of the vop register needs sync write, Currently seems only following registers need sync write: cfg_done, standby

Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

On 2017年07月26日 05:54, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: In the hardware design process, the design of line flags register is associated with the interrupt register, placing the line flags in the interrupt definition is more reasonable

[PATCH v6 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: - fix compile error drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 --- drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/g

[PATCH v6 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 drivers/gpu/drm/ro

[PATCH v6 5/7] drm/rockchip: vop: add a series of vop support

then old one. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series

Signed-off-by: Mark Yao <mark@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v5: - clean document commit title - move changes description out of docummit commit msg Changes in v2: - rename rk322x to rk3228 - correct some vop registers define Documentatio

[PATCH v6 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

In the hardware design process, the design of line flags register is associated with the interrupt register, placing the line flags in the interrupt definition is more reasonable, and it would make multi-vop define easilier. Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Sea

[PATCH v6 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: - fix rk3036 blank display Changes in v3: - Explain more in details drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.

[PATCH v6 0/7] drm/rockchip: add all full framework vop support

some vop registers define Mark Yao (7): drm/rockchip: vop: initialize registers directly drm/rockchip: vop: move write_relaxed flags to vop register drm/rockchip: vop: move line_flag_num to interrupt registers drm/rockchip: vop: group vop registers drm/rockchip: vop: add a series of vop

Re: [PATCH v2 5/5] dt-bindings: display: fill Documents for series of vop

On 2017年07月18日 01:24, Rob Herring wrote: On Wed, Jul 12, 2017 at 10:04:02AM +0800, Mark Yao wrote: Changes in v2: - rename rk322x to rk3228(Heiko Stübner) This goes below '---' and you need a commit msg here. Also, it is not clear in the subject this is for Rockchip. Got it, will fix

[PATCH v5 0/7] drm/rockchip: add all full framework vop support

: - group vop register instead using VOP_REG_VER mechanism - Explain more on patch commit message - move write_relaxed flags to vop registers - fix rk3328 overlay abnormal Changes in v2: - rename rk322x to rk3228 - correct some vop registers define Mark Yao (7): drm/rockchip: vop: initialize

[PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Changes in v3: - Explain more in details Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++- drivers/gpu/drm/ro

[PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

this patch Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 4 ++-- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 8 3 files changed,

[PATCH v5 5/7] drm/rockchip: vop: add a series of vop support

then old one. Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +++--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 - 2

[PATCH v5 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 +- drivers/g

[PATCH v5 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/g

[PATCH v5 6/7] dt-bindings: display: rockchip: fill Documents for vop series

Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v5: - clean document commit title - move changes description out of docummit commit msg Changes in v2: - rename rk322x to rk3228 - correct some vop registers define Documentation/devicetree/bindings/display/rockchip/ro

Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop

On 2017年07月11日 20:45, Heiko Stübner wrote: Hi Mark, Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: Signed-off-by: Mark Yao <mark@rock-chips.com> --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

avo A. R. Silva <garsi...@embeddedor.com> Thanks for the fix, Acked-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/

Re: [PATCH] drm/rockchip: Set line flag config register in vop_crtc_enable

com> looks good for me: Acked-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 +-- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20 +--- 3 files

Re: [PATCH v6 0/7] drm/rockchip: add all full framework vop support

Hi Pushed to drm-misc-next. Thanks Sean Paul, Jeffy Chen's review, Heiko's test and Rob's ack. Best regards. On 2017年07月26日 14:18, Mark Yao wrote: These patches try to make all current rockchip full framework vop works on drm, fill missing vop on full framework. Vop Full framework now has

Re: [PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

-by: Jose Abreu <joab...@synopsys.com> Tested-by: Mark Yao <mark@rock-chips.com> This is needed for RK3399 support. Can you please apply it? Best regards, Jose Miguel Abreu Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+ren

Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

On 2017年07月31日 20:28, Daniel Vetter wrote: On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: On 31 July 2017 at 10:50, Mark Yao <mark@rock-chips.com> wrote: Since fb_helper is not a pointer on rockchip_drm_private, it's no need to check pointer.

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko On 2017年07月28日 09:02, Mark yao wrote: Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers

Re: [PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

On 2017年07月26日 06:36, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao: At present we are using init_table to initialize some registers, but the Register init table use un-document define, it is unreadable, and sometimes we only want to update tiny

[PATCH v2 2/4] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. base on Yakir Yang's rk3399 patch, rebase to newest upstrem kernel: https://patchwork.kernel.org/patch/9223323 Signed-off-by: Mark Yao <mark@rock-chips.com> Signed-off-by: Yakir Y

[PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx

So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx to configure their hardware. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- include/drm/bridge/dw_hdmi.h | 3 +++ 2 files changed, 5 insertions

[PATCH v2 3/4] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

Yang <y...@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> Changes in v2: describe vpll on Documentation. --- .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 25 +- 2 files changed, 2

[PATCH v2 4/4] drm/rockchip: dw_hdmi: introduce the pclk for grf

For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang <y...@rock-chips.com> Signed-off-by: Mark Yao

Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx

10:45, Mark Yao wrote: So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx to configure their hardware. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- include/drm/bridge/dw_hdmi.h | 3 +++ 2 files c

[PATCH v2 0/4] Add RK3399 HDMI Support

, so I remove them on this thread. Tested on rk3399 evb board with kernel 4.12.0-rc1. Changes in v2: rebase to newest uptream, reuse hdmi_phy_configure_dwc_hdmi_3d_tx Mark Yao (2): drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx drm/rockchip: dw_hdmi: add RK3399 HDMI support

[PATCH v3 0/3] Add RK3399 HDMI Support

hdmi_phy_configure_dwc_hdmi_3d_tx Mark Yao (3): drm/rockchip: dw_hdmi: add RK3399 HDMI support drm/rockchip: dw_hdmi: introduce the VPLL clock setting drm/rockchip: dw_hdmi: introduce the pclk for grf .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 6 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v3 2/3] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

Yang <y...@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v3: none Changes in v2: describe vpll on Documentation. .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 25 +++

[PATCH v3 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v3: remove hdmi_phy_configure_dwc_hdmi_3d_tx callbak. Changes in

[PATCH v3 3/3] drm/rockchip: dw_hdmi: introduce the pclk for grf

For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang <y...@rock-chips.com> Signed-off-by: Mark Yao

Re: [PATCH 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures

On 2017年06月20日 21:07, Bhumika Goyal wrote: Add const to drm_encoder_helper_funcs structures as they are only passed as an argument to the function drm_encoder_helper_add and this argument is of type const. So, add const to these structures. Also, fix line over 80 characters warning while adding

Re: [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures

com> --- Changes in v2 - * Let the line exceed over 80 characters while adding const. Acked-by: Mark Yao <mark@rock-chips.com> Thanks -- Ｍark Yao ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

not familiar with hdmi, but hdmi display actually works for us. And, I had tried the 4.12-rc1 kernel with your patch, display works good. So: Tested-by: Mark Yao <mark@rock-chips.com> On 2017年06月13日 22:11, Jose Abreu wrote: Hi Laurent, Sorry for the late reply! On 10-06-2017 09:50, L

[PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v3.1: Correct documentation compatible's format(Rob Herring). C

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

On 2017年06月22日 15:31, Heiko Stuebner wrote: + >+/** >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips >+ * @lcdsel_grf_reg: grf register offset of lcdc select >+ * @lcdsel_big: reg value of selecting vop big for HDMI >+ * @lcdsel_lit: reg value of selecting vop little

Re: [PATCH v3 0/3] Add RK3399 HDMI Support

Thanks for Heiko's review and Rob's Ack. Seems no more confuse, pushed to drm-misc-next. Thanks. On 2017年06月09日 15:10, Mark Yao wrote: RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure, and an external VPLL clock need to configure. base

[PATCH] drm/rockchip: Correct vop out_mode configure

on atomic_check, but encoder maybe NULL, so out_mode configure would fail, it cause edp no display. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 12 drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 ++--- drive

Re: [PATCH] drm/rockchip: gem: add the lacks lock and trivial changes

-by: Caesar Wang <w...@rock-chips.com> Looks good. Reviewed-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dri

Re: [PATCH] drm/rockchip: gem: add the lacks lock and trivial changes

On 2017年05月31日 10:14, Caesar Wang wrote: As the allocation and free buffer that need to add mutex lock for drm mm, but it lacks the locking on error path in rockchip_gem_iommu_map(). Also, the trivial changes like The comment should be placed in the kerneldoc and unused blank line.

Re: [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*

Change the tile to: drm/rockchip: Replace dev_* with DRM_DEV_* Thanks. On 2017年09月15日 14:47, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the

Re: [PATCH] drm/rockchip: Fix uninitialized use of ret

On 2017年09月21日 08:13, Sean Paul wrote: If there are no children for lvds, ret is used uninitialized. This patch initializes ret and returns an error if the port has no children. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Mark Yao <mark@rock-

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <tho...@m3y3r.de> --- Looks good for me: Acked-by: Mark Yao <mark@rock-chips

Re: [PATCH v2] drm/rockchip: Replace dev_* with DRM_DEV_*

On 2017年09月15日 16:36, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the help of the following Coccinelle script: @r@ @@ ( -dev_info +DRM_DEV_INFO |

Re: [PATCH] drm/rockchip: add PINCTRL dependency for LVDS

On 2017年10月05日 20:09, Arnd Bergmann wrote: The new driver fails to build when CONFIG_PINCTRL is disabled: drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config': drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct

Re: [PATCH v3 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface

On 2017年10月09日 16:06, Sandy Huang wrote: Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang --- Changes in v3: update for

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 14:12, Mark yao wrote: On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

Hi Sandy Looks good for me, so: Reviewed-by: Mark Yao <mark@rock-chips.com> I'd like to apply these lvds patches tomorrow if there is no more doubts. Best Regards Mark On 2017年09月02日 19:28, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the p

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao <mark@rock-chips.com> I'd like to apply these lvds patches tomorrow if there is no more doubts. Rob had some minor co

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao <mark@r

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月26日 13:12, Daniel Vetter wrote: On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Th

Re: [PATCH v7 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

On 2017年08月23日 14:26, Sandy Huang wrote: This patch add Document for Rockchip Soc RK3288 LVDS, This based on the patches from Mark yao and Heiko Stuebner. Signed-off-by: Sandy Huang <h...@rock-chips.com> Signed-off-by: Mark yao <mark@rock-chips.com> Signed-off-by: Heiko

Re: [PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

On 2017年09月26日 15:55, Nickey Yang wrote: Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang Hi Nickey Haneen Mohammed already send similar patch, and it was applied, see following

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

On 2017年09月26日 15:55, Nickey Yang wrote: This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider

Re: [PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

an you rebase your patches to drm-misc-next, these patches would conflict to current drm-misc-next branch. And please see my comment inline. Mark Yao --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390 drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drive

Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

On 2017年10月19日 01:52, Brian Norris wrote: Hi Kristian, On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: We used to call drm_of_encoder_active_endpoint_id() from rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the active encoder. However, the encoder isn't

[PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

For personal reasons, Mark Yao will leave rockchip, can not continue maintain drm/rockchip, Sandy Huang will take over the drm/rockchip. Cc: Sandy Huang <h...@rock-chips.com> Cc: Heiko Stuebner <he...@sntech.de> Signed-off-by: Mark Yao <mark@rock-chips.com> --- MAINTAIN

Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

t;h...@rock-chips.com> Looks good. Reviewed-by:  Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/dri

Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

t;h...@rock-chips.com> Looks good. Reviewed-by:  Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/dri

Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

On 2017年10月20日 01:46, Kristian Høgsberg wrote: On Wed, Oct 18, 2017 at 5:49 PM, Mark yao <mark@rock-chips.com> wrote: On 2017年10月19日 01:52, Brian Norris wrote: Hi Kristian, On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: We used t

Re: [PATCH v6 06/10] drm/rockchip: dw-mipi-dsi: Fix error handling path

com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 07/10] drm/rockchip: inno_hdmi: Fix error handling path

On 2017年10月19日 11:48, Jeffy Chen wrote: Add missing error handling in bind(). Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Signed-off-by: Jeffy Chen<jeffy.c...@rock-chips.com> Looks good for me Acked-by: Mark Yao <mark@ro

Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path

ock-chips.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

On 2017年10月19日 11:48, Jeffy Chen wrote: The rockchip_drm_psr_register() can fail, so add a sanity check for that. Also reorder the calls in unbind() to match bind(). Signed-off-by: Jeffy Chen<jeffy.c...@rock-chips.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.c

Re: [PATCH v6 02/10] drm/rockchip: analogix_dp: Remove unnecessary init code

.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: None Changes in v5: None drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 27 ++--- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/rockchip/ana

<    1   2   3   4   5   6