double buffering. It is tested on
the i.MX6.
Code is based on
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/gpu/drm/xilinx/xilinx_drm_fb.c#L196
Signed-off-by: Stefan Christ <s.chr...@phytec.de>
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/d
Hi,
This is a respin of the previous serie called "Support fast framebuffer
panning for i.MX6" made by Stefan 6 monthes ago. The imx6 bits have been
removed, and the comments that were made at that time fixed (hopefully).
Let me know what you think,
Maxime
Changes from v1:
- Added
https://lkml.org/lkml/2015/9/14/188]
Signed-off-by: Stefan Christ <s.chr...@phytec.de>
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/drm/Kconfig | 8
drivers/gpu/drm/drm_fb_cma_helper.c | 8 +++-
2 files changed, 15 insertions
minor fix.
Christophe JAILLET (1):
drm/sun4i: Fix a return value in case of error
drivers/gpu/drm/sun4i/sun4i_backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Maxime Ripard, Free Electrons
Embedded Linux
Hi Noralf,
On Fri, Feb 03, 2017 at 07:48:51PM +0100, Noralf Trønnes wrote:
>
> Den 03.02.2017 10.59, skrev Maxime Ripard:
> > Hi,
> >
> > Here is an attempt at supporting the ST7789V LCD controller from Sitronix.
>
> What happens if there's another pane
Hi Noralf,
On Fri, Feb 03, 2017 at 07:53:58PM +0100, Noralf Trønnes wrote:
>
> Den 03.02.2017 10.59, skrev Maxime Ripard:
> > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
> > ---
> > drivers/gpu/drm/panel/Kconfig | 4 +-
> &
> Cc: Ben Skeggs <bske...@redhat.com>
> Cc: Tomi Valkeinen <tomi.valkei...@ti.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Mark Yao <mark@rock-chips.com>
> Cc: Benjamin Gaignard <benjamin.gaign...@linaro.org>
> Cc: Maxim
_funcs should be used instead.
>
> Signed-off-by: Shawn Guo <shawn@linaro.org>
> Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engin
On Mon, Feb 06, 2017 at 12:29:31PM +0100, Noralf Trønnes wrote:
>
> Den 06.02.2017 11.39, skrev Maxime Ripard:
> > Hi Noralf,
> >
> > On Fri, Feb 03, 2017 at 07:48:51PM +0100, Noralf Trønnes wrote:
> > > Den 03.02.2017 10.59, skrev Maxime Ripard:
> > >
1, value, 0x3);
>
> ? Wouldn't that invalidly read "value" as int and wrongly increment the
> ap by three bytes too many?
Hmmm, it might be. I'll remove it, and take all your other changes
into account.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel
Hi Thierry,
On Mon, Feb 06, 2017 at 02:05:49PM +0100, Thierry Reding wrote:
> On Fri, Feb 03, 2017 at 10:59:05AM +0100, Maxime Ripard wrote:
> > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that
> > can drive 18-bits 240x320 LCD displays.
> >
>
Hi Rob,
On Mon, Feb 06, 2017 at 11:32:01AM -0600, Rob Herring wrote:
> On Mon, Feb 06, 2017 at 11:03:01AM +0100, Maxime Ripard wrote:
> > Hi Rob,
> >
> > On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote:
> > > Similar to the previous commit, conver
> - if (!remote) {
> - DRM_DEBUG_DRIVER("Unable to parse remote node\n");
> - return ERR_PTR(-EINVAL);
> - }
> -
> - return of_drm_find_panel(remote) ?: ERR_PTR(-EPROBE_DEFER);
And the panel is only one of our endpoints, which is optional, whi
The ARM Mali Utgard GPU family is embedded into a number of SoCs from
Allwinner, Amlogic, Mediatek or Rockchip.
Add a binding for the GPU of that family.
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Cha
The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that
can drive 18-bits 240x320 LCD displays.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.tx
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/drm/panel/Kconfig | 4 +-
drivers/gpu/drm/panel/Makefile | 1 +-
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 435 ++-
3 files changed, 440 insertions
The A23 and A33 have an ARM Mali 400 GPU. Now that we have a binding, add
it to our DT.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Changes from v2:
- Removed leading 0 from the unit address
---
arch/arm/boot/dts/sun8i-a23-a33.dtsi | 26 +++
what you think,
Maxime
Maxime Ripard (2):
dt-bindings: display: panel: Add bindings for the Sitronix ST7789V panel
drm/panel: Add driver for sitronix ST7789V panel
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36
++-
drivers/gpu/drm/panel/Kconfig
On Tue, Sep 06, 2016 at 04:46:20PM +0200, Maxime Ripard wrote:
> Enable the display pipeline with the associated 7" panel sold with the
> SinA33.
>
> Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
Applied,
Maxime
--
Maxime Ripard, Free Electrons
Em
On Thu, Jan 26, 2017 at 10:54:56AM +0100, Thierry Reding wrote:
> On Tue, Sep 06, 2016 at 04:46:17PM +0200, Maxime Ripard wrote:
> > The E231732 is a 7" panel with a resolution of 800x480.
> >
> > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
&g
Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.
separately.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-deve
On Fri, Feb 17, 2017 at 01:45:44PM +0100, Tobias Jakobi wrote:
> Hello Maxime,
>
> Maxime Ripard wrote:
> > Hi,
> >
> > On Thu, Feb 16, 2017 at 01:43:06PM +0100, Tobias Jakobi wrote:
> >> I was wondering about the following. Wasn't there some strict
> &
? I'm pretty sure you wouldn't, yet
this is the exact same case.
And taking the ACPI example once again, this doesn't seem to bother
you at all that ACPI reports that it has a device that is not
supported in-tree in Linux. Why is it any different in DT.
We already have DT bindings for out of tree driv
1)
> +
> +/*
> + * VI channels are not used now, but the support of them may be introduced in
> + * the future.
> + */
> +
> +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR(ch, layer) \
> + (0x2000 + 0x1000 * (ch) + 0x20 * (layer) + 0x0)
> +#define SUN8I_MIXER_CHAN_UI
ted to
answer, but most of the changes introduced by the old driver was
duplication of code that was already existing (Allwinner TCON, TV
Encoder, Designware HDMI, etc).
This patchset superseeds it by using what is already supported without
the duplication. It also has a bit less features (for example
mixer;
> >> +
> >> + mixer->cfg = of_device_get_match_data(dev);
> >> + if (!mixer->cfg)
> >> + return -EINVAL;
> >> +
> >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >> + regs = devm_ioremap_resource(dev,
On Mon, Feb 20, 2017 at 01:35:50PM +0100, Michal Hocko wrote:
> On Mon 13-02-17 14:44:16, Maxime Ripard wrote:
> > Hi Michal,
> >
> > On Thu, Feb 09, 2017 at 08:20:47PM +0100, Michal Hocko wrote:
> > > [CC CMA people]
> > >
> > > On Thu 09-02-1
[DRM] developers.
DRM is really not important here. We could implement a driver using
i2c as far as the DT is concerned.
FreeBSD for example uses a different, !DRM framework to support our
display stack, and still uses the DT.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kerne
;);
> + if (IS_ERR(bus_clk)) {
> + ret = PTR_ERR(bus_clk);
> + if (ret != -EPROBE_DEFER)
> + dev_err(>dev, "Couldn't get bus clk: %d\n", ret);
> + return ret;
> + }
> +
> + rstc = devm_res
7 at 05:19:08PM +0100, Maxime Ripard wrote:
> > From: Xinliang Liu <xinliang@linaro.org>
>
> Mabye you should take the authorship here. Taking the credit and the
> blame, because the patch was heavily modified by you and me. But I don't
> really know what the offical pol
Hi Thierry,
On Mon, Feb 20, 2017 at 05:49:26PM +0100, Thierry Reding wrote:
> On Fri, Feb 17, 2017 at 04:43:41PM +0100, Maxime Ripard wrote:
> > On Fri, Feb 17, 2017 at 01:45:44PM +0100, Tobias Jakobi wrote:
> > > Hello Maxime,
> > >
> > > Maxime Ripard wrote:
Hi Ville, Stefan,
On Tue, Feb 21, 2017 at 12:55:01PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote:
> > Hi Maxime,
> >
> > On Wed, Feb 15, 2017 at 05:19:09PM +0100, Maxime Ripard wrote:
> > > From: Ste
o set drm_crtc.port to the output
> port node of the underlying TCON.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Added it, and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signat
u Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
ht
gt; sizeof(*layers), GFP_KERNEL);
> if (!layers)
> return ERR_PTR(-ENOMEM);
> --
> 2.11.0
>
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description
. This is done in a later
> patch.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
ause sun4i-drm
> also calls into sun4i-tcon.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
_
ese pointers only get used at bind time.
>
> Instead, have the crtc init code iterate through the returned layers
> to find the primary and cursor layers. And drop the pointer from the
> sun4i_drv structure.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, tha
g>
Applied all the previous patches, and this one
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-devel mailing lis
csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.fr
ayers), GFP_KERNEL);
>
> The element size should be the size of an individual element of the
> array. Change it to sizeof(*layers) to avoid wasting a lot of memory.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded L
rm, plane);
>
> Drop the assignment.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
>
> Save the pointers in the array, so that they may be used later.
>
> Signed-off-by: Chen-Yu Tsai <w...@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
plied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
On Mon, Feb 13, 2017 at 06:46:45PM +0200, Priit Laes wrote:
> On Mon, 2017-02-13 at 17:20 +0800, Chen-Yu Tsai wrote:
> > On Mon, Feb 13, 2017 at 5:16 PM, Maxime Ripard
> > <maxime.rip...@free-electrons.com> wrote:
> > > Hi,
> > >
> > > On S
Hi,
On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote:
> Hi Maxime,
>
> On 13 February 2017 at 10:54, Maxime Ripard
> <maxime.rip...@free-electrons.com> wrote:
> > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote:
> >> On Thursday 0
Hi,
On Tue, Feb 14, 2017 at 11:25:08PM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Tuesday 14 Feb 2017 21:09:51 Daniel Vetter wrote:
> > On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote:
> > > On 13 February 2017 at 10:54, Maxime Ripard wrote:
> >
Hi,
On Mon, Feb 13, 2017 at 04:45:33PM +0200, Ville Syrjälä wrote:
> On Mon, Feb 13, 2017 at 11:35:18AM +0100, Maxime Ripard wrote:
> > Hi Ville,
> >
> > On Fri, Feb 10, 2017 at 04:06:05PM +0200, Ville Syrjälä wrote:
> > > On Thu, Feb 02, 2017 at 11:31:5
0x88
> #define SUN4I_TCON0_IO_POL_DCLK_PHASE(phase) ((phase & 3) << 28)
> +#define SUN4I_TCON0_IO_POL_DCLK_PHASE_MASK (3 << 28)
> #define SUN4I_TCON0_IO_POL_HSYNC_POSITIVEBIT(25)
> #define SUN4I_TCON0_IO_POL_VSYNC
two output endpoints for the TV Encoder and HDMI,
something we cannot support right now in our binding, since we assume
that we have the two channels that only have one user, which turned
out to be wrong.
I guess an easy way would be to have an extra property defining which
channel the endpoint is
(tcon, mode);
> + sun4i_tcon0_mode_set(tcon, mode, DRM_MODE_ENCODER_DAC);
This is not the proper encoder type. You can just use encoder_type in
drm_encoder.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signat
so you cannot reuse that compatible (same thing for the other).
Also, I'd really like to have all the blocks listed here, and not only
the first pipeline. Ideally, on the A10, the two pipelines should be
enabled too.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kerne
Hi Ville,
On Fri, Feb 10, 2017 at 04:06:05PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 02, 2017 at 11:31:57AM +0100, Maxime Ripard wrote:
> > From: Stefan Christ <s.chr...@phytec.de>
> >
> > Implement legacy framebuffer ioctl FBIO_WAITFORVSYNC in the generic
>
Hi Laurent,
On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote:
> Hi Maxime,
>
> Thank you for the patch.
>
> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote:
> > From: Xinliang Liu <xinliang@linaro.org>
> >
> > This patch add a c
The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that
can drive 18-bits 240x320 LCD displays.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.tx
The Sitronix ST7789v controller is used to drive 240x320 LCD panels through
various interfaces, including SPI and RGB/Parallel.
The current driver is configuring it for the latter. Support for tinyDRM
can always be added later.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.
what you think,
Maxime
Changes from v1:
- Added regulator support
- Removed variadic arguments from the functions
- Added test on the success of the SPI transfers
- Used the MIPI DCS defines
- Expanded the Kconfig help, and fixed the option label
Maxime Ripard (2):
dt-bindings: display
Device frequency scaling is implemented through devfreq in the kernel,
which requires CONFIG_PM_OPP.
Let's select it.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
arch/arm/mach-sunxi/Kconfig | 1 +
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/arch/ar
The memory buffers might need to be allocated and shared from both the
scanout and the GPU.
Create a memory region reserved for their own usage so that each can
allocate from it, and get the informations on the region that is going to
be used (size and offset).
Signed-off-by: Maxime Ripard
The Mali clock rate was improperly assumed to be 408MHz, while it was
really 384Mhz, 408MHz being the "extreme" frequency, and definitely not
stable.
Switch for the stable, correct frequency for the GPU.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
arch/ar
The reserved memory bindings allow us to specify which memory areas our
buffers can be allocated from.
Let's use it.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 4
1 file changed, 4 insertions
know what you think,
Maxime
Maxime Ripard (8):
ARM: sun8i: Fix the mali clock rate
dt-bindings: gpu: mali: Add optional memory-region
mm: cma: Export a few symbols
drm/sun4i: Grab reserved memory region
ARM: sun8i: a33: Add shared display memory pool
dt-bindings: gpu: mali: Add optional
The Mali GPU in the A33 has various operating frequencies used in the
Allwinner BSP.
Add them to our DT.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
arch/arm/boot/dts/sun8i-a33.dtsi | 17 +
1 file changed, 17 insertions(+), 0 deletions(-)
diff
The operating-points-v2 binding gives a way to provide the OPP of the GPU.
Let's use it.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 4
1 file changed, 4 insertions(+), 0 deletions(-)
diff
Allow to provide an optional memory region to allocate from for our DRM
driver.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
such a failure.
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/base/dma-contiguous.c | 1 +
mm/cma.c | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
https://lkml.org/lkml/2015/9/14/188]
Signed-off-by: Stefan Christ <s.chr...@phytec.de>
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/drm/Kconfig | 9 +
drivers/gpu/drm/drm_fb_helper.c | 10 ++
2 files changed, 19 insertions(+), 0
double buffering. It is tested on
the i.MX6.
Code is based on
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/gpu/drm/xilinx/xilinx_drm_fb.c#L196
Signed-off-by: Stefan Christ <s.chr...@phytec.de>
Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
---
drivers/gpu/d
l had not a chance to work. I came up with a similar solution than
John's, but for the encoders (since our clocks are per-encoder), but
unfortunately had no time to push it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.as
Hi,
This is a respin of the previous serie called "Support fast framebuffer
panning for i.MX6" made by Stefan 6 monthes ago. The imx6 bits have been
removed, and the comments that were made at that time fixed (hopefully).
Let me know what you think,
Maxime
Changes from v2:
- Renamed the
Hi Daniel,
On Thu, Feb 09, 2017 at 06:04:38PM +0100, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 11:31:56AM +0100, Maxime Ripard wrote:
> > From: Xinliang Liu <xinliang@linaro.org>
> >
> > This patch add a config to support to create multi buffer for cma fbdev
Hi Michal,
On Thu, Feb 09, 2017 at 08:20:47PM +0100, Michal Hocko wrote:
> [CC CMA people]
>
> On Thu 09-02-17 17:39:17, Maxime Ripard wrote:
> > Modules might want to check their CMA pool size and address for debugging
> > and / or have additional checks.
> >
or it.
So yes, unfortunately, we don't have a driver upstream at the
moment. But that doesn't prevent us from describing the hardware
accurately.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signatu
lution, not the visible one.
> What I'm also not seeing is code that handles the fbdev's virtual
> resolutions. After all num_buffers should only increase those. Same for
> the panning ioctl().
This is already implemented through drm_fb_helper_pan_display.
Maxime
--
Maxime Ripard, Free Elect
Hi,
On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote:
> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
> wrote:
> > The planes can do more than what was previously exposed. Add support for
> > them.
> >
> > Signed-off-by: Maxime Ripard
>
nnot be the card device.
> ASoC does not use the CPU DAI device (I2S_controller), so, it is
> natural to use it to handle the card.
Still, duplicating the driver is not the solution. I agree with
Chen-Yu that we want to leverage the driver that is already there.
Maxime
--
Maxi
ings, 70 checks, 1458 lines checked
Please run checkpatch before sending your patches.
Apart from that, this looks an awful lot like the designware HDMI
controller, for which a driver already exists. Any reason to create a
new driver from scratch?
Maxime
--
Maxime Ripard, Free Electrons
Hi,
On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote:
> Allwinner's recent SoCs, as A64, A83T and H3, contain a new display
> engine, DE2.
> This patch adds a DRM video driver for this device.
>
> Signed-off-by: Jean-Francois Moine
Output from checkpatch:
total: 0 errors, 20
dumb_vga *vga = drm_bridge_to_dumb_vga(bridge);
> > +
> > + if (vga->enable_gpio)
> > + gpiod_set_value_cansleep(vga->enable_gpio, 1);
>
> So the driver should allow either active high or low.
You mean like having a enable-active-high property? Isn't t
Hi,
On Tue, Oct 25, 2016 at 08:42:26AM +0800, Chen-Yu Tsai wrote:
> On Mon, Oct 24, 2016 at 10:40 PM, Maxime Ripard
> wrote:
> > Hi,
> >
> > On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote:
> >> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
>
On Thu, Oct 27, 2016 at 05:13:25PM +0200, Jean-Francois Moine wrote:
> On Mon, 24 Oct 2016 14:34:49 +0200
> Maxime Ripard wrote:
>
> > Hi,
> >
> > On Sun, Oct 23, 2016 at 09:45:03AM +0200, Jean-Francois Moine wrote:
> > > On Sun, 23 Oct 2016 09:3
+ int lcd_num, int plane_ix)
> > > +{
> > > + void __iomem *mux_o = priv->mmio;
> > > + void __iomem *chan_o;
> > > + u32 fcolor;
> > > + int chan, layer, chan_disable = 0;
> > > + unsigned long flags;
> > > +
> >
://lists.infradead.org/pipermail/linux-arm-kernel/2016-September/453208.html
Let me know what you think,
Maxime
Maxime Ripard (7):
drm/sun4i: support TCONs without channel 1
drm/sun4i: support A33 tcon
drm/sun4i: Add SAT and DRC drivers
drm/panel: Add Sinlinx SinA33 7" panel
ARM:
Some Allwinner SoCs, such as the A33, have a variation of the TCON that
doesn't have a second channel (or it is not wired to anything).
Make sure we can handle that case.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 34 +-
drivers/gpu
for the
pipeline to operate properly.
Signed-off-by: Maxime Ripard
---
.../bindings/display/sunxi/sun4i-drm.txt | 37 +++
drivers/gpu/drm/sun4i/Makefile | 3 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 117 +
drivers/gpu/drm
Add all the needed blocks to the A33 DTSI.
Signed-off-by: Maxime Ripard
---
arch/arm/boot/dts/sun8i-a33.dtsi | 184 +++
1 file changed, 184 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index deb0cd613e97
The LCD output needs to be muxed. Add the proper pinctrl node.
Signed-off-by: Maxime Ripard
---
arch/arm/boot/dts/sun8i-a33.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index 5f9dbd17eb50..d5f93c05846f
The SinA33 has an unidentified panel. Add the timings for it under a new
compatible.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm
The A33 has a significantly different pipeline, with components that differ
too.
Make sure we had compatible for them.
Signed-off-by: Maxime Ripard
---
Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++-
drivers/gpu/drm/sun4i/sun4i_backend.c | 1
Enable the display pipeline with the associated 7" panel sold with the
SinA33.
Signed-off-by: Maxime Ripard
---
arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 34 ++
1 file changed, 34 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
b
ot;drm/sun4i: Add bridge support")
> Signed-off-by: Chen-Yu Tsai
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-- next part --
A non-text attachment was scrubbed...
Name: signature.a
Hi Chen-Yu,
On Wed, Aug 31, 2016 at 04:25:27PM +0800, Chen-Yu Tsai wrote:
> On Wed, Aug 31, 2016 at 4:18 PM, Maxime Ripard
> wrote:
> > The GR8 is an SoC made by Nextthing Co, loosely based on the sun5i family.
> >
> > It has a number of new controllers compared to
Hi Icenowy,
On Fri, Sep 02, 2016 at 09:30:05AM +0800, Icenowy Zheng wrote:
>
>
> 01.09.2016, 23:40, "Maxime Ripard" :
> > Hi everyone,
> >
> > This serie introduces the support in the sun4i-drm driver for the A33.
> >
> > Beside the new I
Hi,
On Mon, Sep 05, 2016 at 01:03:03AM +0800, Icenowy Zheng wrote:
> Hi Everyone,
>
> 01.09.2016, 23:40, "Maxime Ripard" :
> > Â The SinA33 has an unidentified panel. Add the timings for it under a new
> > Â compatible.
>
>
>
> Excuse me...
> I
n as part of the BE. Look at it
> this way: if it did come before the BE and is independent, we
> shouldn't have to bring the SAT out of reset for simplefb to work.
Indeed.
> For comparison, a similar function unit called "CMU" found on the
> other post-sun6i SoCs has the sa
On Fri, Sep 02, 2016 at 02:02:30PM +0800, Chen-Yu Tsai wrote:
> Hi,
>
> On Thu, Sep 1, 2016 at 11:31 PM, Maxime Ripard
> wrote:
> > The A33 has a significantly different pipeline, with components that differ
> > too.
> >
> > Make sure we had compatible for
->mod_clk);
> > + goto err_disable_bus_clk;
> > + }
> > +
> > + return clk_prepare_enable(drc->mod_clk);
>
> What happens if this fails? No cleanup happens.
Indeed, will fix.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Em
On Sat, Sep 03, 2016 at 09:43:59AM +0800, Chen-Yu Tsai wrote:
> On Sat, Sep 3, 2016 at 3:06 AM, Maxime Ripard
> wrote:
> > Hi Icenowy,
> >
> > On Fri, Sep 02, 2016 at 09:30:05AM +0800, Icenowy Zheng wrote:
> >>
> >>
> >> 01.0
Hi Peter,
On Sun, Sep 04, 2016 at 10:03:06PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard writes:
>
> Hi,
>
> > The A33 pipeline also has some new components called SAT and DRC. Even
> > though their exact features and p
1 - 100 of 7548 matches
Mail list logo
